1. 21 Aug, 2013 30 commits
    • fpizlo@apple.com's avatar
      Assertion failure in JSC::SlotVisitor::copyLater when marking JSDataView · cd07b473
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120099
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg.
              
      JSDataView should not store the ArrayBuffer* in the butterfly indexing header, since
      JSDataView may have ordinary JS indexed properties.
      
      * runtime/ClassInfo.h:
      * runtime/JSArrayBufferView.cpp:
      (JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
      (JSC::JSArrayBufferView::finishCreation):
      * runtime/JSArrayBufferView.h:
      (JSC::hasArrayBuffer):
      * runtime/JSArrayBufferViewInlines.h:
      (JSC::JSArrayBufferView::buffer):
      (JSC::JSArrayBufferView::neuter):
      (JSC::JSArrayBufferView::byteOffset):
      * runtime/JSCell.cpp:
      (JSC::JSCell::slowDownAndWasteMemory):
      * runtime/JSCell.h:
      * runtime/JSDataView.cpp:
      (JSC::JSDataView::JSDataView):
      (JSC::JSDataView::create):
      (JSC::JSDataView::slowDownAndWasteMemory):
      * runtime/JSDataView.h:
      (JSC::JSDataView::buffer):
      * runtime/JSGenericTypedArrayView.h:
      * runtime/JSGenericTypedArrayViewInlines.h:
      (JSC::::visitChildren):
      (JSC::::slowDownAndWasteMemory):
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg.
      
      * fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived-expected.txt: Added.
      * fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived.html: Added.
      * fast/js/regress/ArrayBuffer-DataView-alloc-long-lived-expected.txt: Added.
      * fast/js/regress/ArrayBuffer-DataView-alloc-long-lived.html: Added.
      * fast/js/regress/DataView-custom-properties-expected.txt: Added.
      * fast/js/regress/DataView-custom-properties.html: Added.
      * fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-large-long-lived.js: Added.
      * fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-long-lived.js: Added.
      * fast/js/regress/script-tests/DataView-custom-properties.js: Added.
      * platform/mac/TestExpectations: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd07b473
    • mhahnenberg@apple.com's avatar
      Remove incorrect ASSERT from CopyVisitor::visitItem · a61dc64e
      mhahnenberg@apple.com authored
      Rubber stamped by Filip Pizlo.
      
      Source/JavaScriptCore: 
      
      * heap/CopyVisitorInlines.h:
      (JSC::CopyVisitor::visitItem):
      
      LayoutTests: 
      
      Added a new test that triggered the old ASSERT. It's a useful test to have because we create
      TypedArrays with custom properties.
      
      * fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt: Added.
      * fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html: Added.
      * fast/js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a61dc64e
    • timothy_horton@apple.com's avatar
      Revert http://trac.webkit.org/changeset/154022, as it failed to update · 730200b4
      timothy_horton@apple.com authored
      a variety of scripts that depended on the old format.
      
      See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
      
      * Scripts/prepare-ChangeLog:
      (main):
      (generateNewChangeLogs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730200b4
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120127 · 8c300972
      barraclough@apple.com authored
      Remove JSObject::propertyIsEnumerable
      
      Reviewed by Sam Weinig.
      
      This method is just a wart - it contains unnecessary const-casting, function call overhead, and LOC.
      
      * runtime/JSObject.cpp:
      * runtime/JSObject.h:
          - remove propertyIsEnumerable
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncPropertyIsEnumerable):
          - Move implementation here using getOwnPropertyDescriptor directly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c300972
    • timothy_horton@apple.com's avatar
      REGRESSION(r154399): broke Mac ML debug WK1 tests > 50 crashes (Requested by thorton on #webkit). · eefba76d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120129
      
      Rolling out http://trac.webkit.org/changeset/154399.
      
      * rendering/RenderBlock.cpp:
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
      * rendering/RenderBox.h:
      
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Removed.
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eefba76d
    • fpizlo@apple.com's avatar
      DFG should inline new typedArray() · 372fa82b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120022
      
      Source/JavaScriptCore: 
      
      Reviewed by Oliver Hunt.
              
      Adds inlining of typed array allocations in the DFG. Any operation of the
      form:
              
          new foo(blah)
              
      or:
              
          foo(blah)
              
      where 'foo' is a typed array constructor and 'blah' is exactly one argument,
      is turned into the NewTypedArray intrinsic. Later, of child1 (i.e. 'blah')
      is predicted integer, we generate inline code for an allocation. Otherwise
      it turns into a call to an operation that behaves like the constructor would
      if it was passed one argument (i.e. it may wrap a buffer or it may create a
      copy or another array, or it may allocate an array of that length).
      
      * bytecode/SpeculatedType.cpp:
      (JSC::speculationFromTypedArrayType):
      (JSC::speculationFromClassInfo):
      * bytecode/SpeculatedType.h:
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      * dfg/DFGBackwardsPropagationPhase.cpp:
      (JSC::DFG::BackwardsPropagationPhase::propagate):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
      (JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
      * dfg/DFGCCallHelpers.h:
      (JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::putStructureStoreElimination):
      * dfg/DFGClobberize.h:
      (JSC::DFG::clobberize):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dump):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasTypedArrayType):
      (JSC::DFG::Node::typedArrayType):
      * dfg/DFGNodeType.h:
      * dfg/DFGOperations.cpp:
      (JSC::DFG::newTypedArrayWithSize):
      (JSC::DFG::newTypedArrayWithOneArgument):
      * dfg/DFGOperations.h:
      (JSC::DFG::operationNewTypedArrayWithSizeForType):
      (JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSafeToExecute.h:
      (JSC::DFG::safeToExecute):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileNewTypedArray):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_new_object):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_new_object):
      * runtime/JSArray.h:
      (JSC::JSArray::allocationSize):
      * runtime/JSArrayBufferView.h:
      (JSC::JSArrayBufferView::allocationSize):
      * runtime/JSGenericTypedArrayViewConstructorInlines.h:
      (JSC::constructGenericTypedArrayView):
      * runtime/JSObject.h:
      (JSC::JSFinalObject::allocationSize):
      * runtime/TypedArrayType.cpp:
      (JSC::constructorClassInfoForType):
      * runtime/TypedArrayType.h:
      (JSC::indexToTypedArrayType):
      
      LayoutTests: 
      
      Reviewed by Oliver Hunt.
      
      * fast/js/regress/Float64Array-alloc-long-lived-expected.txt: Added.
      * fast/js/regress/Float64Array-alloc-long-lived.html: Added.
      * fast/js/regress/Int16Array-alloc-long-lived-expected.txt: Added.
      * fast/js/regress/Int16Array-alloc-long-lived.html: Added.
      * fast/js/regress/Int8Array-alloc-long-lived-expected.txt: Added.
      * fast/js/regress/Int8Array-alloc-long-lived.html: Added.
      * fast/js/regress/script-tests/Float64Array-alloc-long-lived.js: Added.
      * fast/js/regress/script-tests/Int16Array-alloc-long-lived.js: Added.
      * fast/js/regress/script-tests/Int32Array-alloc-long-lived.js:
      * fast/js/regress/script-tests/Int8Array-alloc-long-lived.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      372fa82b
    • timothy_horton@apple.com's avatar
      <https://webkit.org/b/120099> Assertion failure in JSC::SlotVisitor::copyLater... · 5e1de64f
      timothy_horton@apple.com authored
      <https://webkit.org/b/120099> Assertion failure in JSC::SlotVisitor::copyLater when marking DataView
      
      Mark fast/canvas/webgl/array-message-passing.html as crashing on debug, for now.
      
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e1de64f
    • akling@apple.com's avatar
      <https://webkit.org/b/120118> Frame::animation() should return a reference. · 7c2be783
      akling@apple.com authored
      Reviewed by Anders Carlsson.
      
      Frame::m_animationController is never null.
      Also changed RenderObject::animation() to return a reference since it's just a wrapper
      around RenderObject::frame()->animation() with no null checking of frame().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2be783
    • simon.fraser@apple.com's avatar
      Allow opacity to apply to custom scrollbars · 7c818704
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120104
      
      Source/WebCore:
      
      Reviewed by David Hyatt.
      
      Opacity was ignored custom scrollbar pseudoelements because custom scrollbar
      renderers never create layers, and opacity is normally handled by the RenderLayer code.
      
      Fix by having RenderScrollbarTheme and RenderScrollbarPart do the transparency
      layers necessary for opacity. RenderScrollbarPart handles opacity for individual
      parts.
      
      Because ScrollbarThemeComposite::paint() renders the parts on after another (with
      no nesting), opacity handling for the entire scrollbar needs special-casing.
      This is done by willPaintScrollbar()/didPaintScrollbar() on the theme.
      RenderScrollbarTheme consults the opacity the scrollbar (which we get from
      the ScrollbarBGPart renderer) to decide whether to set up a transparency layer.
      
      Test: scrollbars/scrollbar-parts-opacity.html
      
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paint):
      * platform/ScrollbarThemeComposite.h:
      (WebCore::ScrollbarThemeComposite::willPaintScrollbar):
      (WebCore::ScrollbarThemeComposite::didPaintScrollbar):
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::opacity):
      * rendering/RenderScrollbar.h:
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::paintIntoRect):
      * rendering/RenderScrollbarTheme.cpp:
      (WebCore::RenderScrollbarTheme::willPaintScrollbar):
      (WebCore::RenderScrollbarTheme::didPaintScrollbar):
      * rendering/RenderScrollbarTheme.h:
      
      LayoutTests:
      
      Reviewed by David Hyatt.
      
      Ref test for custom scrollbars with opacity on the bar itself,
      and on the thumb.
      
      * scrollbars/scrollbar-parts-opacity-expected.html: Added.
      * scrollbars/scrollbar-parts-opacity.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c818704
    • robert@webkit.org's avatar
      REGRESSION(r127163): Respect clearance set on ancestors when placing floats · a10ca744
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119979
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      If a float has a self-collapsing ancestor with clearance then it needs to respect
      that clearance when placing itself on the line.
      
      Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::marginOffsetForSelfCollapsingBlock):
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::previousInFlowSiblingBox):
      
      LayoutTests:
      
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Added.
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a10ca744
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher. · 0cab07ec
      bfulgham@apple.com authored
      * WinLauncher/WinLauncher.cpp:
      (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cab07ec
    • ap@apple.com's avatar
      REGRESSION (r145458?): WebProcess doesn't respect UI process localization · 5b8c677c
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=120096
      
              Reviewed by Darin Adler.
      
              We used to get into a situation where CFBundle thought that we had no good localization,
              and used one passed as default. This is never the case with mixed localizations,
              so default is just ignored now.
      
              I think that the previous behavior was a bit of a hack. As WebProcess is not localized,
              it's more honest to say that we want mixed localizations, and force the language
              to match UI process localization.
      
              * Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
              (WebKit::ChildProcessMain): Don't set default localization, it's not taken into
              consideration unless all other attempts to compute bundle localization fail.
      
              * UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::createProcess): Pass
              UI process localization as -AppleLanguages argument, so that Core Foundation uses
              that instead of actual user languages. We want to match UI process localization.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b8c677c
    • bfulgham@apple.com's avatar
      ../WebInspectorUI: <http://webkit.org/b/120098> [Windows] Enable the New Web Inspector · 9be185b7
      bfulgham@apple.com authored
      Reviewed by Brian Weinstein.
      
      Add a new project to copy files to the appropriate spots in the
      Windows port.
      
      * WebInspectorUI.vcxproj: Added.
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Added.
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Added.
      * WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Added.
      * WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Added.
      
      ../WebKit: <https://webkit.org/b/120098> [Windows] Enable the new Web Inspector
      
      Reviewed by Brian Weinstein.
      
      * WebKit.vcxproj/WebKit.sln: Add reference to the new WebInspectorUI
      project so that it will be included in new distributions.
      
      ../WebKit/win: <https://webkit.org/b/120098> [Windows] Enable the New Web Inspector
      
      Reviewed by Brian Weinstein.
      
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorClient::openInspectorFrontend): Use the new inspector
      if present in the WebKit distribution.
      (WebInspectorFrontendClient::localizedStringsURL): Use the new
      Web Inspector's localized strings (if present).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9be185b7
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening. One more CSS_IMAGE_SET test can be activated. · 26cfb5c5
      bfulgham@apple.com authored
      * platform/win/TestExpectations: We can reactivate cssom/cssvalue-comparison.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26cfb5c5
    • zandobersek@gmail.com's avatar
      <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp · 63041f75
      zandobersek@gmail.com authored
      Reviewed by Andreas Kling.
      
      * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
      (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
      (WTR::activateFonts): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63041f75
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120113> Enable CSS_IMAGE_SET · 544444a9
      bfulgham@apple.com authored
      Reviewed by Anders Carlsson.
      
      * platform/win/TestExpectations: Turn on two CSS_IMAGE_SET-based tests that
      now pass on Windows.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      544444a9
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET · f491c1f8
      bfulgham@apple.com authored
      Reviewed by Anders Carlsson.
      
      We can now activate:
      fast/css/image-set-parsing.html
      fast/css/image-set-parsing-invalid.html
      
      * WebCore.vcxproj/WebCore.vcxproj: Add missing image set implementation files.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * css/CSSAllInOne.cpp: Add missing CSSImageSetValue.cpp
      * rendering/style/StyleAllInOne.cpp: Add missing StyeCachedImageSet.cpp
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f491c1f8
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET · e6e15169
      bfulgham@apple.com authored
      Reviewed by Anders Carlsson.
      
      * win/tools/vsprops/FeatureDefines.props: Enable CSS_IMAGE_SET feature.
      * win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e15169
    • robert@webkit.org's avatar
      In RenderTableCell::paintCollapsedBorders() check surrounding cells using... · b31a601a
      robert@webkit.org authored
      In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction
      https://bugs.webkit.org/show_bug.cgi?id=120074
      
      Reviewed by David Hyatt.
      
      No new tests, covered by existing tests.
      
      The functions cellAbove(), cellBelow() etc. check the logical rather than the physical direction but they're being
      used to decide the painting of the physical borders of the cell. As we paint all four sides of every cell, and
      the borders of adjoining cells twice over, this has no impact on painting currently but making the check consistent
      in its treatment of physical and logical direction will help with webkit.org/b/119759 and make the code less confusing
      to the next guy.
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::cellAtLeft):
      (WebCore::RenderTableCell::cellAtRight):
      (WebCore::RenderTableCell::cellAtTop):
      (WebCore::RenderTableCell::cellAtBottom):
      (WebCore::RenderTableCell::paintCollapsedBorders):
      * rendering/RenderTableCell.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b31a601a
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120106> Fix V_DFGOperation_EJPP signature in DFG. · 0a114a60
      commit-queue@webkit.org authored
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-21
      Reviewed by Geoffrey Garen.
      
      * dfg/DFGOperations.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a114a60
    • commit-queue@webkit.org's avatar
      [GTK] Suppress irrelevant or known leaks for Valgrind · 91c9df6f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119448
      
      Patch by Brian Holt <brian.holt@samsung.com> on 2013-08-21
      Reviewed by Martin Robinson.
      
      Add a suppressions file to suppress known leaks for Valgrind.
      Valgrind also takes longer when using suppressions and
      times out unless the driver timeout is increased.
      
      * Scripts/valgrind/suppressions.txt: Added.
      * Scripts/webkitpy/port/gtk.py:
      (GtkPort.driver_stop_timeout):
      (GtkPort.setup_environ_for_server):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91c9df6f
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120109> [curl] only include WebCoreBundleWin on Windows · ccffabc9
      commit-queue@webkit.org authored
      Patch by Róbert Sipka <sipka@inf.u-szeged.hu> on 2013-08-21
      Reviewed by Brent Fulgham.
      
      The WebCoreBundleWin is a windows specific file, it is only needed on Windows.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccffabc9
    • commit-queue@webkit.org's avatar
      [Qt] Remove unused code path in PluginView · eaf80124
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113173
      
      Patch by Jae Hyun Park <jae.park@company100.net> on 2013-08-21
      Reviewed by Anders Carlsson.
      
      m_platformLayer in PluginView has been removed in r121710, but there are
      still some leftover code path related to m_platformLayer. This patch
      removes unused code path.
      
      No new tests, removing unused code paths.
      
      * plugins/PluginView.h:
      (PluginView):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::updatePluginWidget):
      (WebCore::PluginView::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaf80124
    • allan.jensen@digia.com's avatar
      Font’s fast code path doesn’t handle partial runs correctly when kerning or ligatures are enabled · 52ea0c9f
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100050
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Always let WidthIterator iterate over an entire TextRun to avoid problems
      with pixel rounding or shaping on partial runs.
      
      This fix is necessary for Qt because the complex font-path can not disable
      shaping, leading to the complex path painting slighly different from the
      fast path, which messes up selection painting.
      
      No change in functionality, no new tests.
      
      * platform/graphics/Font.cpp:
      (WebCore::Font::drawText):
      (WebCore::Font::drawEmphasisMarks):
      (WebCore::Font::selectionRectForText):
      (WebCore::Font::offsetForPosition):
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
      (WebCore::Font::selectionRectForSimpleText):
      (WebCore::Font::offsetForPositionForSimpleText):
      * platform/graphics/GlyphBuffer.h:
      (WebCore::GlyphBuffer::add):
      (GlyphBuffer):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::advanceInternal):
      * platform/graphics/WidthIterator.h:
      (WidthIterator): Removed now unused advanceOneCharacter method.
      
      LayoutTests:
      
      * fast/text/resources/PTS55F-webfont.ttf: Added.
      * fast/text/partial-textruns-expected.html: Added.
      * fast/text/partial-textruns.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ea0c9f
    • tonikitoo@webkit.org's avatar
      Harden RenderBox::canBeScrolledAndHasScrollableArea logic... · 1bf1cb62
      tonikitoo@webkit.org authored
      Harden RenderBox::canBeScrolledAndHasScrollableArea logic https://bugs.webkit.org/show_bug.cgi?id=104373
      
      Reviewed by Simon Fraser.
      Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
      
      Source/WebCore:
      
      Previously if a say div has a overflown content on 'y' but is
      styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled
      would still return true. It interfers, among other things, with the way
      autoscroll works.
      
      Patch fixes it by adding two helper methods to RenderBox class in order to verify a box'
      scrollability in a given axis (x or y); They are used when checking if a given box is in
      fact programatically scrollable.
      
      Test: fast/events/autoscroll-overflow-hidden-longhands.html
      
      WebKit autoscroll behavior now matches Firefox and Opera12 (pre-blink)
      in that sense.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::canBeProgramaticallyScrolled):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::hasScrollableOverflowX):
      (WebCore::RenderBox::hasScrollableOverflowY):
      
      LayoutTests:
      
      Patch adds a test to ensure autoscrolling only happens on a given
      axis if it is scrollable in that direction, according to its style.
      
      * fast/events/autoscroll-overflow-hidden-longhands-expected.txt: Added.
      * fast/events/autoscroll-overflow-hidden-longhands.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bf1cb62
    • tonikitoo@webkit.org's avatar
      Text dragging can scroll overflow:hidden boxes https://bugs.webkit.org/show_bug.cgi?id=119760 · ce8f1831
      tonikitoo@webkit.org authored
      Reviewed by Darin Adler.
      Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
      
      Source/WebCore:
      
      Consider the case of the following HTML:
      <div style="overflow:hidden; width: 100px; height: 100px" >
        <input id="input" type="text" size=10 value="any text here!"/>
        <button style="position:relative; top: 100px; left: 100px"/>
      </div>
      
      If ones starts a text selection by dragging the mouse from within the input
      field, and continues to drag beyong the outer div boundary, the latter will
      be scrolled no matter its overflow:hidden style.
      That happens because when the autoscroll has started, it gets propagated up
      to the current layer's parent layer, instead of the to current layer's enclosing
      scrollable layer.
      
      Patch fixes the issue by hardening the way scrolling is
      propagated upwards when autoscroll is being performed.
      
      RenderLayer::enclosingScrollableLayer method also got rewritten
      in terms of RenderLayer tree traversing, instead of RenderObject tree.
      The rewrite adds support for cross frame upwards traversal.
      
      Test: fast/events/autoscroll-upwards-propagation.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::parentLayerCrossFrame):
      (WebCore::RenderLayer::enclosingScrollableLayer):
      (WebCore::RenderLayer::scrollRectToVisible):
      
      LayoutTests:
      
      * fast/events/autoscroll-upwards-propagation-expected.txt: Added.
      * fast/events/autoscroll-upwards-propagation.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8f1831
    • allan.jensen@digia.com's avatar
      Disable maybe-uninitialized warning in GCC 4.8 · 0450eb52
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119835
      
      Reviewed by Anders Carlsson.
      
      Disable the maybe-uninitialized warning.
      
      * wtf/Compiler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0450eb52
    • zandobersek@gmail.com's avatar
      <https://webkit.org/b/119836> [GTK] ChromeClient::paint is susceptible to system time changes · 1c5b3f59
      zandobersek@gmail.com authored
      Reviewed by Martin Robinson.
      
      Instead of using WTF::currentTime() as the value of the last display occurrence,
      WTF::monotonicallyIncreasingTime() should be used. The latter is not affected by
      the changes is the system's time, which can cause a halt in the display updating.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c5b3f59
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120086 · c6434f6d
      barraclough@apple.com authored
      REGRESSION (r154300): http/tests/security/cross-frame-access-getOwnPropertyDescriptor is failing or crashing on the bots
      
      Reviewed by Geoff Garen.
      
      Previously we allowed cross-frame access to these properties, but hid the descriptors.
      Now we allow access, but make them read-only, non-configurable.
      
      * http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
      * http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html:
      * platform/mac/TestExpectations:
          - Update test/results/expectations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6434f6d
    • jer.noble@apple.com's avatar
      <https://webkit.org/b/120101> [Mac] Suspended HTMLMediaElements can still hold... · de4fcd43
      jer.noble@apple.com authored
      <https://webkit.org/b/120101> [Mac] Suspended HTMLMediaElements can still hold power assertion after playback stops.
      
      Reviewed by Eric Carlson.
      
      Call updateDisplaySleep() when we clear our MediaPlayer, as doing so may kill any in-flight
      rateChanged() notifications.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::clearMediaPlayer):
      (WebCore::HTMLMediaElement::stop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de4fcd43
  2. 20 Aug, 2013 10 commits
    • fpizlo@apple.com's avatar
      fast/js/regress/emscripten-cube2hash is failing on all the Mac bots · b022c270
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120083
      
      Unreviewed.
              
      Fixed the test to work in web mode and removed the failure expectation.
      
      * fast/js/regress/script-tests/emscripten-cube2hash.js:
      (else.Module.string_appeared_here):
      * platform/mac/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b022c270
    • fpizlo@apple.com's avatar
      Add emscripten memops benchmark. · 1fabb414
      fpizlo@apple.com authored
      Rubber stamped by Oliver Hunt.
      
      * TestExpectations:
      * fast/js/regress/emscripten-memops-expected.txt: Added.
      * fast/js/regress/emscripten-memops.html: Added.
      * fast/js/regress/script-tests/emscripten-memops.js: Added.
      (.Module.string_appeared_here):
      (else.Module.string_appeared_here):
      (else.else.Module.string_appeared_here):
      (else.else):
      (globalEval):
      (Runtime.stackSave):
      (Runtime.stackRestore):
      (Runtime.forceAlign):
      (Runtime.isNumberType):
      (Runtime.isPointerType):
      (Runtime.isStructType):
      (or64):
      (and64):
      (xor64):
      (getNativeTypeSize):
      (getNativeFieldSize):
      (dedup):
      (.set var):
      (getAlignSize):
      (calculateStructAlignment):
      (.else.alignment):
      (generateStructInfo):
      (dynCall):
      (addFunction):
      (removeFunction):
      (warnOnce):
      (.Runtime.funcWrappers.func):
      (getFuncWrapper):
      (UTF8Processor.this.processCChar):
      (UTF8Processor.this.processJSString):
      (UTF8Processor):
      (stackAlloc):
      (staticAlloc):
      (dynamicAlloc):
      (alignMemory):
      (makeBigInt):
      (assert):
      (ccall):
      (getCFunc):
      (.toC):
      (.fromC):
      (ccallFunc):
      (setValue):
      (getValue):
      (.set else):
      (.set return):
      (allocate):
      (Pointer_stringify):
      (alignMemoryPage):
      (enlargeMemory):
      (callRuntimeCallbacks):
      (preRun):
      (ensureInitRuntime):
      (preMain):
      (exitRuntime):
      (postRun):
      (addOnPreRun):
      (addOnInit):
      (addOnPreMain):
      (addOnExit):
      (addOnPostRun):
      (intArrayFromString):
      (intArrayToString):
      (writeStringToMemory):
      (writeArrayToMemory):
      (unSign):
      (reSign):
      (Math.string_appeared_here):
      (addRunDependency):
      (removeRunDependency):
      (loadMemoryInitializer.applyData):
      (loadMemoryInitializer.set addOnPreRun):
      (__ATINIT__.push):
      (STATIC_BASE):
      (copyTempDouble):
      (___setErrNo):
      (PATH.splitPath):
      (PATH.normalizeArray):
      (PATH.normalize.join):
      (PATH.normalize):
      (PATH.dirname):
      (PATH.basename):
      (PATH.join):
      (PATH.trim):
      (PATH.relative):
      (TTY.register):
      (TTY.stream_ops.open):
      (TTY.stream_ops.close):
      (TTY.stream_ops.read):
      (TTY.stream_ops.write):
      (TTY.default_tty_ops.get_char):
      (TTY.default_tty_ops.put_char):
      (TTY.default_tty1_ops.put_char):
      (MEMFS.mount):
      (MEMFS.create_node):
      (MEMFS.node_ops.getattr):
      (MEMFS.node_ops.setattr):
      (MEMFS.node_ops.lookup):
      (MEMFS.node_ops.mknod):
      (MEMFS.node_ops.rename):
      (MEMFS.node_ops.unlink):
      (MEMFS.node_ops.rmdir):
      (MEMFS.node_ops.readdir):
      (MEMFS.node_ops.symlink):
      (MEMFS.node_ops.readlink):
      (MEMFS.stream_ops.set else):
      (MEMFS.stream_ops.read):
      (MEMFS.stream_ops.write):
      (MEMFS.stream_ops.llseek):
      (MEMFS.stream_ops.allocate):
      (MEMFS.stream_ops.set return):
      (MEMFS.stream_ops.mmap):
      (_fflush):
      (FS.ErrnoError):
      (FS.handleFSError):
      (FS.hashName):
      (FS.hashAddNode):
      (FS.hashRemoveNode):
      (FS.lookupNode):
      (FS.):
      (FS.destroyNode):
      (FS.isRoot):
      (FS.isMountpoint):
      (FS.isFile):
      (FS.isDir):
      (FS.isLink):
      (FS.isChrdev):
      (FS.isBlkdev):
      (FS.isFIFO):
      (FS.cwd):
      (FS.var):
      (FS.lookupPath):
      (FS.getPath):
      (FS.modeStringToFlags):
      (FS.flagsToPermissionString):
      (FS.nodePermissions):
      (FS.mayLookup):
      (FS.mayMknod):
      (FS.mayCreate):
      (FS.mayDelete):
      (FS.mayOpen):
      (FS.chrdev_stream_ops.open):
      (FS.chrdev_stream_ops.llseek):
      (FS.major):
      (FS.minor):
      (FS.makedev):
      (FS.registerDevice):
      (FS.getDevice):
      (FS.nextfd):
      (FS.getStream):
      (FS.closeStream):
      (FS.getMode):
      (FS.joinPath):
      (FS.absolutePath):
      (FS.standardizePath):
      (FS.findObject):
      (FS.analyzePath):
      (FS.createFolder):
      (FS.createPath):
      (FS.createFile):
      (FS.createDataFile):
      (FS.createDevice):
      (FS.createLink):
      (FS.forceLoadFile):
      (FS.LazyUint8Array):
      (FS.LazyUint8Array.prototype.get if):
      (FS.LazyUint8Array.prototype):
      (FS.LazyUint8Array.prototype.setDataGetter):
      (FS.LazyUint8Array.prototype.cacheLength.doXHR):
      (FS.LazyUint8Array.prototype.cacheLength):
      (FS.get Object):
      (FS.get var):
      (FS.keys.forEach):
      (FS.processData.finish):
      (FS.processData):
      (FS.else):
      (FS.createPreloadedFile):
      (FS.createDefaultDirectories):
      (FS.createDefaultDevices.):
      (FS.createDefaultDevices):
      (FS.createStandardStreams):
      (FS.staticInit):
      (FS.init):
      (FS.quit):
      (FS.mount):
      (FS.lookup):
      (FS.mknod):
      (FS.create):
      (FS.mkdir):
      (FS.mkdev):
      (FS.symlink):
      (FS.rename):
      (FS.rmdir):
      (FS.readdir):
      (FS.unlink):
      (FS.readlink):
      (FS.stat):
      (FS.lstat):
      (FS.chmod):
      (FS.lchmod):
      (FS.fchmod):
      (FS.chown):
      (FS.lchown):
      (FS.fchown):
      (FS.truncate):
      (FS.ftruncate):
      (FS.utime):
      (FS.open):
      (FS.close):
      (FS.llseek):
      (FS.read):
      (FS.write):
      (FS.allocate):
      (FS.mmap):
      (_send):
      (_pwrite):
      (_write):
      (_fwrite):
      (__reallyNegative):
      (.getNextArg):
      (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break):
      (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break):
      (_fprintf):
      (_printf):
      (_abort):
      (___errno_location):
      (_sbrk.Runtime.dynamicAlloc):
      (_sbrk):
      (_sysconf):
      (_time):
      (Browser.mainLoop.pause):
      (Browser.mainLoop.resume):
      (Browser.mainLoop.updateStatus):
      (Browser.init.imagePlugin.string_appeared_here):
      (Browser.init.img.onload):
      (Browser.init.img.onerror):
      (Browser.init.audioPlugin.string_appeared_here):
      (Browser.init.finish):
      (Browser.init.fail):
      (Browser.init.audio.onerror.encode64):
      (Browser.init.audio.onerror):
      (Browser.init.audio):
      (Browser.init.else):
      (Browser.init.pointerLockChange):
      (Browser.init.canvas):
      (Browser.init):
      (Browser.destroyContext):
      (Browser.fullScreenChange):
      (Browser.requestFullScreen):
      (Browser.requestAnimationFrame):
      (Browser.safeRequestAnimationFrame):
      (Browser.safeSetTimeout):
      (Browser.safeSetInterval):
      (Browser.getMimetype):
      (Browser.getUserMedia):
      (Browser.getMovementX):
      (Browser.getMovementY):
      (Browser.calculateMouseEvent):
      (Browser.xhr.onload):
      (Browser.xhrLoad):
      (Browser.updateResizeListeners):
      (Browser.setCanvasSize):
      (Browser.setFullScreenCanvasSize):
      (Browser.setWindowedCanvasSize):
      (__ATINIT__.unshift):
      (__ATMAIN__.push):
      (__ATEXIT__.push):
      (Module.string_appeared_here):
      (invoke_ii):
      (invoke_v):
      (invoke_iii):
      (invoke_vi):
      (asmPrintInt):
      (asmPrintFloat):
      (asm):
      (Runtime.stackAlloc):
      (ExitStatus):
      (Module.string_appeared_here.Module.callMain.callMain.pad):
      (Module.string_appeared_here.Module.callMain):
      (run.doRun):
      (run.else):
      (run):
      (exit):
      (abort):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fabb414
    • gyuyoung.kim@samsung.com's avatar
      <https://webkit.org/b/92330> [CSS] Pass an image orientation data to drawImage() · b1c9a8e5
      gyuyoung.kim@samsung.com authored
      Reviewed by Beth Dakin.
      
      In support of ongoing css3-images image-orientation implementation. This patch passes
      an imageOrientationDescription object to drawImage() function as a argument. The drawImage()
      can know information of image orientation by the argument.
      
      Spec: http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::paint):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      (WebCore::drawImageToContext):
      * platform/graphics/ImageOrientation.h: Add setter functions.
      (WebCore::ImageOrientationDescription::setRespectImageOrientation):
      (WebCore::ImageOrientationDescription::setImageOrientationEnum):
      * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
      (WebCore::BitmapTextureImageBuffer::updateContents):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintReplaced):
      (WebCore::RenderImage::paintIntoRect):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::paintSnapshot):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1c9a8e5
    • seokju@webkit.org's avatar
      Unreviewed gardening. Rebaseline after r154372. · e0099816
      seokju@webkit.org authored
      * platform/qt-mac/TestExpectations: fast/css/giant-stylesheet-crash.html was removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0099816
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120093 · 174570f9
      barraclough@apple.com authored
      Remove getOwnPropertyDescriptor trap
      
      Reviewed by Geoff Garen.
      
      All implementations of this method are now called via the method table, and equivalent in behaviour.
      Remove all duplicate implementations (and the method table trap), and add a single member function implementation on JSObject.
      
      Source/JavaScriptCore: 
      
      * API/JSCallbackObject.h:
      * API/JSCallbackObjectFunctions.h:
      * debugger/DebuggerActivation.cpp:
      * debugger/DebuggerActivation.h:
      * runtime/Arguments.cpp:
      * runtime/Arguments.h:
      * runtime/ArrayConstructor.cpp:
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      * runtime/ArrayPrototype.h:
      * runtime/BooleanPrototype.cpp:
      * runtime/BooleanPrototype.h:
          - remove getOwnPropertyDescriptor
      * runtime/ClassInfo.h:
          - remove getOwnPropertyDescriptor from MethodTable
      * runtime/DateConstructor.cpp:
      * runtime/DateConstructor.h:
      * runtime/DatePrototype.cpp:
      * runtime/DatePrototype.h:
      * runtime/ErrorPrototype.cpp:
      * runtime/ErrorPrototype.h:
      * runtime/JSActivation.cpp:
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      * runtime/JSArray.h:
      * runtime/JSArrayBuffer.cpp:
      * runtime/JSArrayBuffer.h:
      * runtime/JSArrayBufferView.cpp:
      * runtime/JSArrayBufferView.h:
      * runtime/JSCell.cpp:
      * runtime/JSCell.h:
      * runtime/JSDataView.cpp:
      * runtime/JSDataView.h:
      * runtime/JSDataViewPrototype.cpp:
      * runtime/JSDataViewPrototype.h:
      * runtime/JSFunction.cpp:
      * runtime/JSFunction.h:
      * runtime/JSGenericTypedArrayView.h:
      * runtime/JSGenericTypedArrayViewInlines.h:
      * runtime/JSGlobalObject.cpp:
      * runtime/JSGlobalObject.h:
      * runtime/JSNotAnObject.cpp:
      * runtime/JSNotAnObject.h:
      * runtime/JSONObject.cpp:
      * runtime/JSONObject.h:
          - remove getOwnPropertyDescriptor
      * runtime/JSObject.cpp:
      (JSC::JSObject::propertyIsEnumerable):
          - switch to call new getOwnPropertyDescriptor member function
      (JSC::JSObject::getOwnPropertyDescriptor):
          - new, based on imlementation from GET_OWN_PROPERTY_DESCRIPTOR_IMPL
      (JSC::JSObject::defineOwnNonIndexProperty):
          - switch to call new getOwnPropertyDescriptor member function
      * runtime/JSObject.h:
      * runtime/JSProxy.cpp:
      * runtime/JSProxy.h:
      * runtime/NamePrototype.cpp:
      * runtime/NamePrototype.h:
      * runtime/NumberConstructor.cpp:
      * runtime/NumberConstructor.h:
      * runtime/NumberPrototype.cpp:
      * runtime/NumberPrototype.h:
          - remove getOwnPropertyDescriptor
      * runtime/ObjectConstructor.cpp:
      (JSC::objectConstructorGetOwnPropertyDescriptor):
      (JSC::objectConstructorSeal):
      (JSC::objectConstructorFreeze):
      (JSC::objectConstructorIsSealed):
      (JSC::objectConstructorIsFrozen):
          - switch to call new getOwnPropertyDescriptor member function
      * runtime/ObjectConstructor.h:
          - remove getOwnPropertyDescriptor
      * runtime/PropertyDescriptor.h:
          - remove GET_OWN_PROPERTY_DESCRIPTOR_IMPL
      * runtime/RegExpConstructor.cpp:
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.cpp:
      * runtime/RegExpMatchesArray.h:
      * runtime/RegExpObject.cpp:
      * runtime/RegExpObject.h:
      * runtime/RegExpPrototype.cpp:
      * runtime/RegExpPrototype.h:
      * runtime/StringConstructor.cpp:
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      * runtime/StringObject.h:
          - remove getOwnPropertyDescriptor
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowCustom.cpp:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      (GenerateConstructorHelperMethods):
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
      * bindings/scripts/test/JS/JSTestActiveDOMObject.h:
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
      * bindings/scripts/test/JS/JSTestEventConstructor.h:
      * bindings/scripts/test/JS/JSTestEventTarget.cpp:
      * bindings/scripts/test/JS/JSTestEventTarget.h:
      * bindings/scripts/test/JS/JSTestException.cpp:
      * bindings/scripts/test/JS/JSTestException.h:
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      * bindings/scripts/test/JS/JSTestInterface.h:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      * bindings/scripts/test/JS/JSTestNamedConstructor.h:
      * bindings/scripts/test/JS/JSTestNode.cpp:
      * bindings/scripts/test/JS/JSTestNode.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      * bindings/scripts/test/JS/JSTestObj.h:
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
      * bindings/scripts/test/JS/JSTestTypedefs.h:
      * bridge/jsc/BridgeJSC.h:
      (JSC::Bindings::Instance::getOwnPropertySlot):
      * bridge/objc/objc_runtime.h:
      * bridge/objc/objc_runtime.mm:
      * bridge/runtime_array.cpp:
      * bridge/runtime_array.h:
      * bridge/runtime_method.cpp:
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      * bridge/runtime_object.h:
          - remove getOwnPropertyDescriptor
      
      Source/WebKit2: 
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      * WebProcess/Plugins/Netscape/JSNPObject.h:
          - remove getOwnPropertyDescriptor
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      174570f9
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120095> Delete fast/css/giant-stylesheet-crash.html... · 6114a00c
      rniwa@webkit.org authored
      <https://webkit.org/b/120095> Delete fast/css/giant-stylesheet-crash.html since it flakily timeout or crash
      
      Reviewed by Antti Koivisto.
      
      Deleted the test. This test was added in r82054 but it has been crashing since r154242.
      
      Since our expected behavior is to crash at the moment, this test's description doesn't even match
      the expected behavior anymore. Furthermore, it intermittently times out due to DRT taking too long to
      allocate memory before it can crash.
      
      * fast/css/giant-stylesheet-crash-expected.txt: Removed.
      * fast/css/giant-stylesheet-crash.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6114a00c
    • antti@apple.com's avatar
      <https://webkit.org/b/120071> Replace NodeRenderingContext with Node* as... · dacd6dee
      antti@apple.com authored
      <https://webkit.org/b/120071> Replace NodeRenderingContext with Node* as childShouldCreateRenderer() argument
      
      Reviewed by Darin Adler.
      
      This simplifies the code. NodeRenderingContext was basically only used for getting the Node.
      
      * dom/ContainerNode.h:
      (WebCore::ContainerNode::childShouldCreateRenderer):
      * dom/Element.cpp:
      (WebCore::Element::childShouldCreateRenderer):
      * dom/Element.h:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::shouldCreateRenderer):
      * dom/NodeRenderingContext.h:
              
          Move isOnEncapsulationBoundary() to InsertionPoint.h and call it hasShadowRootOrActiveInsertionPointParent().
          Move isOnUpperEncapsulationBoundary() to ShadowRoot.h and call it hasShadowRootParent().
      
      * dom/ShadowRoot.h:
      (WebCore::hasShadowRootParent):
      * html/HTMLDetailsElement.cpp:
      (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
      * html/HTMLDetailsElement.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::validationMessageShadowTreeContains):
      * html/HTMLFormControlElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::childShouldCreateRenderer):
      * html/HTMLMediaElement.h:
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::childShouldCreateRenderer):
      * html/HTMLMeterElement.h:
      * html/HTMLOptGroupElement.h:
      (WebCore::isHTMLOptGroupElement):
      * html/HTMLOptionElement.h:
      (WebCore::isHTMLOptionElement):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::childShouldCreateRenderer):
      * html/HTMLProgressElement.h:
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::childShouldCreateRenderer):
      * html/HTMLSelectElement.h:
      * html/HTMLSummaryElement.cpp:
      (WebCore::HTMLSummaryElement::childShouldCreateRenderer):
      * html/HTMLSummaryElement.h:
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
      (WebCore::enclosingTextFormControl):
      * html/HTMLTextFormControlElement.h:
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::shadowTreeContains):
      * html/ValidationMessage.h:
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::rendererIsNeeded):
      * html/shadow/InsertionPoint.h:
      (WebCore::isActiveInsertionPoint):
              
          Remove isShadowBoundary() as it was equivalent to isActive(). 
          Remove isLowerEncapsulationBoundary() as it was equivalent to isActiveInsertionPoint().
      
      (WebCore::hasShadowRootOrActiveInsertionPointParent):
              
          Moved and renamed from NodeRenderingContext::isOnEncapsulationBoundary().
      
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::childShouldCreateRenderer):
      * svg/SVGAElement.h:
      * svg/SVGAltGlyphElement.cpp:
      (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
      * svg/SVGAltGlyphElement.h:
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::childShouldCreateRenderer):
      * svg/SVGDocument.h:
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::childShouldCreateRenderer):
      * svg/SVGElement.h:
      * svg/SVGFilterElement.cpp:
      (WebCore::SVGFilterElement::childShouldCreateRenderer):
      * svg/SVGFilterElement.h:
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/SVGForeignObjectElement.cpp:
      (WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
      * svg/SVGForeignObjectElement.h:
      * svg/SVGSVGElement.h:
      (WebCore::toSVGSVGElement):
      * svg/SVGSwitchElement.cpp:
      (WebCore::SVGSwitchElement::childShouldCreateRenderer):
      * svg/SVGSwitchElement.h:
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::childShouldCreateRenderer):
      * svg/SVGTRefElement.h:
      * svg/SVGTSpanElement.cpp:
      (WebCore::SVGTSpanElement::childShouldCreateRenderer):
      * svg/SVGTSpanElement.h:
      * svg/SVGTextElement.cpp:
      (WebCore::SVGTextElement::childShouldCreateRenderer):
      * svg/SVGTextElement.h:
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::childShouldCreateRenderer):
      * svg/SVGTextPathElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dacd6dee
    • benjamin@webkit.org's avatar
      <https://webkit.org/b/120050> Don't bother using a Vector for the ouput of... · 7c754a75
      benjamin@webkit.org authored
      <https://webkit.org/b/120050> Don't bother using a Vector for the ouput of querySelector, just return the first element found
      
      Reviewed by Ryosuke Niwa.
      
      Simplify the case of querySelector. Instead of using the same output type as querySelectorAll,
      simply use a trait to define what to do in the loop.
      
      * dom/SelectorQuery.cpp:
      (WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
      (WebCore::SelectorDataList::queryAll):
      (WebCore::SingleElementExtractorSelectorQueryTrait::appendOutputForElement):
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::executeFastPathForIdSelector):
      (WebCore::elementsForLocalName):
      (WebCore::anyElement):
      (WebCore::SelectorDataList::executeSingleTagNameSelectorData):
      (WebCore::SelectorDataList::executeSingleClassNameSelectorData):
      (WebCore::SelectorDataList::executeSingleSelectorData):
      (WebCore::SelectorDataList::executeSingleMultiSelectorData):
      (WebCore::SelectorDataList::execute):
      * dom/SelectorQuery.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c754a75
    • achristensen@apple.com's avatar
      [Windows] Linking fix for Win64. · e95bc7af
      achristensen@apple.com authored
      Rubberstamped by Brent Fulgham.
      
      * win/DLLLauncher/DLLLauncherMain.cpp:
      (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e95bc7af
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT · 689121e5
      bfulgham@apple.com authored
      Reviewed by Tim Horton.
      
      * win/DLLLauncher/DLLLauncherMain.cpp:
      (getLastErrorString): New method to convert GetLastError to text.
      (wWinMain): Use new error formatter to provide useful diagnostic text to user.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      689121e5