1. 07 Apr, 2008 2 commits
    • beidson@apple.com's avatar
      2008-04-06 Brady Eidson <beidson@apple.com> · cce3c766
      beidson@apple.com authored
              Reviewed by Sam
      
              HTML5 Session and Local Storage
      
              Land a bunch of empty files and interfaces to keep things building while 
              I finish off the rest of the implementation of SessionStorage
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
      
              * storage/OriginStorage.cpp: Added.
              * storage/OriginStorage.h: Added.
      
              * storage/SessionStorage.cpp: Added.
              * storage/SessionStorage.h: Added.
      
              * storage/Storage.cpp: Added.
              (WebCore::Storage::length):
              (WebCore::Storage::key):
              (WebCore::Storage::getItem):
              (WebCore::Storage::setItem):
              (WebCore::Storage::removeItem):
              * storage/Storage.h: Added.
              * storage/Storage.idl: Added.
      
              * storage/StorageEvent.cpp: Added.
              * storage/StorageEvent.h: Added.
              (WebCore::StorageEvent::key):
              (WebCore::StorageEvent::oldValue):
              (WebCore::StorageEvent::newValue):
              (WebCore::StorageEvent::uri):
              (WebCore::StorageEvent::source):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.idl: Added.
      
              * storage/StorageMap.cpp: Added.
              * storage/StorageMap.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cce3c766
    • ap@webkit.org's avatar
      Reviewed by Darin. · 11f3871c
      ap@webkit.org authored
              Make UString thread-safe.
      
              No change on SunSpider total, although individual tests have changed a lot, up to 3%.
      
              * kjs/InitializeThreading.cpp: (KJS::initializeThreading): Call UString::null() to initialize
              a static.
              
              * kjs/identifier.cpp:
              (KJS::CStringTranslator::translate):
              (KJS::UCharBufferTranslator::translate):
              Use "true" for a boolean value instead of 1, because it's C++.
      
              * kjs/ustring.h:
              (KJS::CString::adopt): Added a method to create from a char* buffer without copying.
              (KJS::UString::Rep::ref): Removed an assertion for JSLock::lockCount, as it's no longer
              necessary to hold JSLock when working with strings.
              (KJS::UString::Rep::deref): Ditto.
              (KJS::UString::Rep::isStatic): Added a field to quickly determine that this is an empty
              or null static string.
      
              * kjs/ustring.cpp:
              (KJS::): Removed normalStatBufferSize and statBufferSize, as there is no reason to have such
              an advanced implementation of a debug-only ascii() method. Removed a long-obsolete comment
              about UChar.
              (KJS::UString::Rep::createCopying): Removed an assertion for JSLock::lockCount.
              (KJS::UString::Rep::create): Ditto.
              (KJS::UString::Rep::destroy): Ditto. Do not do anything for static null and empty strings,
              as refcounting is not reliable for those. Reordered branches for a noticeable speed gain -
              apparently this functiton is hot enough for SunSpider to see an effect from this!
              (KJS::UString::null): Moved a star, added a comment.
              (KJS::UString::cstring): Reimplemented to not call ascii(), which is not thread-safe.
              (KJS::UString::ascii): Simplified statBuffer handling logic.
              (KJS::UString::toDouble): Use cstring() instead of ascii().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11f3871c
  2. 06 Apr, 2008 1 commit
  3. 05 Apr, 2008 11 commits
  4. 04 Apr, 2008 21 commits
    • sfalken@apple.com's avatar
      Fix tooltip window leak. · 4e034497
      sfalken@apple.com authored
              
              Explicitly call DestroyWindow on the tooltip.
              Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.
      
              Reviewed by Ada Chan.
      
              * WebView.cpp:
              (WebView::~WebView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e034497
    • kevino@webkit.org's avatar
      Add GradientWx.cpp to the wx build process. · e8557d79
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8557d79
    • mitz@apple.com's avatar
      Reviewed by Sam Weinig. · 6a397794
      mitz@apple.com authored
              - speed up CSSFontSelector::getFontData()
      
              * css/CSSFontSelector.cpp:
              (WebCore::fontDataForGenericFamily): Factored out of getFontData().
              (WebCore::CSSFontSelector::getFontData): Changed to call
              fontDataForGenericFamily() directly if the map is empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a397794
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 3da811d0
      jhoneycutt@apple.com authored
              Reviewed by Oliver.
      
              Replace AccessibilityObject::isRenderImage() with a virtual
              RenderObject::isRenderImage().
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::accessibilityIsIgnored):
              (WebCore::AccessibilityObject::addChildren):
              * page/AccessibilityObject.h:
              (WebCore::AccessibilityObject::isDetached):
              * rendering/RenderImage.h:
              (WebCore::RenderImage::isRenderImage):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isRenderImage):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3da811d0
    • sfalken@apple.com's avatar
      Delete backing store after we go 5 seconds without a paint. · 22707065
      sfalken@apple.com authored
                      
              Timer will be reset if a paint occurs, so this won't negatively impact performance.
              
              Reviewed by Ada Chan.
      
              * WebView.cpp:
              (WebView::paint): Call deleteBackingStoreSoon after paint.
              (WebViewWndProc): Add DeleteBackingStoreTimer.
              (WebView::deleteBackingStoreSoon): Added.
              * WebView.h: Add deleteBackingStoreSoon.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22707065
    • mitz@apple.com's avatar
      - try to fix the wx build · b575e3bc
      mitz@apple.com authored
              * platform/graphics/wx/FontPlatformDataWx.cpp:
              (WebCore::fontWeightToWxFontWeight):
              (WebCore::FontPlatformData::FontPlatformData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b575e3bc
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 760da6dc
      jhoneycutt@apple.com authored
              Reviewed by Beth.
      
              Some more clean-up of AccessibilityObject:
              - Rearranged/grouped methods.
              - Marked many methods const.
              - Changed many methods to take args by const ref instead of by val.
              - Made headingLevel() static.
              - Renamed detached() to isDetached(), loaded() to isLoaded(),
                documentLinks to getDocumentLinks().
              - Made clearChildren(), removeAXObjectID(), isDetached() private.
              - Added notImplemented() calls for unimplemented methods.
              - Replaced stringForReplacedNode method with static function.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760da6dc
    • timothy@apple.com's avatar
      Restore the user entered text when clearing the auto-completion. · 5882d3f3
      timothy@apple.com authored
      This is important when the user typed text that is a different
      case than the completion. This has no affect on the Console, since
      it matches completions case-sensitively. This is used in the up-coming
      Database Query view for words like "SELECT" and "INSERT".
      
      Reviewed by Adam Roben.
      
      * page/inspector/TextPrompt.js:
      (WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
      text in the original DOM range that complete() saved away.
      (WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
      and it's text content so clearAutoComplete can restore it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5882d3f3
    • timothy@apple.com's avatar
      Don't trim whitespace when looking for the current match, this prevents... · 5c745141
      timothy@apple.com authored
      Don't trim whitespace when looking for the current match, this prevents tabbing through matches in the up-coming Database Query view.
      
      Reviewed by Adam Roben.
      
      * page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c745141
    • timothy@apple.com's avatar
      Factor out the Console text completion and command history into · 8b21c6eb
      timothy@apple.com authored
      a new TextPrompt object. This TextPrompt object will be used later
      other parts of the Inspector that need text completion and history.
      Not functionality changed, just moved code around.
      
      Reviewed by Adam Roben.
      
      * WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
      * page/inspector/Console.js: Call the new prompt object and
        delete all the code that moved.
      * page/inspector/TextPrompt.js: Added. Moved code from Console.js.
      * page/inspector/WebKit.qrc: Add TextPrompt.js.
      * page/inspector/inspector.html: Add TextPrompt.js.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b21c6eb
    • timothy@apple.com's avatar
      Makes setting shouldRefreshChildren on a TreeElement perform the refresh · 894ffe7f
      timothy@apple.com authored
      immediately if the element is already expanded.
      
      Reviewed by Adam Roben.
      
      * page/inspector/treeoutline.js:
      (TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
      (TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
      already expanded,
      call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
      (TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
      (TreeElement.prototype.expand): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      894ffe7f
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 47e63d77
      jhoneycutt@apple.com authored
              Reviewed by Beth.
      
              Some clean up of AccessibilityObject:
              - Use existing isImage() in more places.
              - Use existing isTextControl() in more places.
              - Added isRenderImage(). Check this before casting to RenderImage,
                since other, non-RenderImage derived RenderObjects (e.g.
                RenderListMarker) can return true for isImage().
              - Fix two copy/paste errors with improper semicolons.
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::isImageButton): Use isImage().
              (WebCore::AccessibilityObject::isRenderImage): Added.
              (WebCore::AccessibilityObject::isAnchor): Use isImage().
              (WebCore::AccessibilityObject::isAttachment): Same.
              (WebCore::AccessibilityObject::accessibilityDescription): Same.
              (WebCore::AccessibilityObject::accessibilityIsIgnored): Use
              isRenderImage() instead of isImage().
              (WebCore::AccessibilityObject::url): Use isImage().
              (WebCore::AccessibilityObject::textControl): Remove improper semicolon, 
              and use isTextControl().
              (WebCore::AccessibilityObject::textMarkerForIndex): Same.
              (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl().
              (WebCore::AccessibilityObject::doAXRangeForLine): Same.
              (WebCore::AccessibilityObject::doAXRangeForIndex): Same
              (WebCore::AccessibilityObject::doAXStringForRange): Same.
              (WebCore::AccessibilityObject::roleValue):  Use isImage().
              (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
              * page/AccessibilityObject.h:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e63d77
    • timothy@apple.com's avatar
      Fixes a null exception when hovering in some areas of the DOM tree. · cee3d6d1
      timothy@apple.com authored
      Reviewed by Adam Roben.
      
      * page/inspector/treeoutline.js:
      (TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
      before accessing any properties. Return null if listNode is null.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cee3d6d1
    • timothy@apple.com's avatar
      Changing WebInspector.currentFocusElement to/from an input element · 58fad059
      timothy@apple.com authored
      does not change the actual focus of that input element. You see this
      in the search field.
      
      Reviewed by Adam Roben.
      
      * page/inspector/inspector.js:
      (WebInspector.set currentFocusElement): Call blur and focus if the
      node implements them.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58fad059
    • hyatt@apple.com's avatar
      2008-04-04 David Hyatt <hyatt@apple.com> · 820875f7
      hyatt@apple.com authored
              Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
              Treat them as having a background-size of 100%.  This means their maximal size will be the box established
              by background-origin.
      
              Reviewed by Beth
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calculateBackgroundSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      820875f7
    • timothy@apple.com's avatar
      Correctly show DOCTYPE in the breadcrumbs and match the CSS rules · 8f6a18bd
      timothy@apple.com authored
      from view-source.css for the DOCTYPE in the DOM tree.
      
      Reviewed by Adam Roben.
      
      * css/view-source.css: Add and correct comments about keeping
      in-sync with inspector.css.
      * page/inspector/ElementsPanel.js:
      (WebInspector.DocumentPanel.prototype.updateBreadcrumb):
      Add a case for Node.DOCUMENT_TYPE_NODE.
      * page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
      * page/inspector/utilities.js:
      (nodeTitleInfo): Use the webkit-html-doctype class for nodes
      with Node.DOCUMENT_TYPE_NODE.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f6a18bd
    • mitz@apple.com's avatar
      - try to fix the Tiger build · bb10a991
      mitz@apple.com authored
              * icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb10a991
    • aroben@apple.com's avatar
      Make WebKit use WebCore's copy of the ICU headers · 6df273d6
      aroben@apple.com authored
      WebCore:
      
              Copy icu/ to PrivateHeaders for WebKit's benefit
      
              Rubberstamped by Tim Hatcher.
      
              * WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding
              Headers build phase to Copy Forwarding and ICU Headers, and added the
              icu/ directory to it.
      
      WebKit/mac:
      
              Use WebCore's ICU headers instead of our own copy
      
              Rubberstamped by Tim Hatcher.
      
              * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
              PrivateHeaders.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6df273d6
    • aroben@apple.com's avatar
      Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in... · 400d9ed1
      aroben@apple.com authored
      Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies
      
      WebCore:
      
              Fix <rdar://problem/5804776> Would like to use WebCore's
              ForwardingHeaders in WebKit without manually creating copies
      
              Patch by Tim Hatcher, typed by me.
      
              * WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy
              Forwarding Headers, that copies the ForwardingHeaders directory to
              WebCore's PrivateHeaders directory.
      
      WebKit/mac:
      
              Fix <rdar://problem/5804776> Would like to use WebCore's
              ForwardingHeaders in WebKit without manually creating copies
      
              Patch by Tim Hatcher, typed by me.
      
              * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
              WebCore's PrivateHeaders instead of our own copy.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      400d9ed1
    • adachan@apple.com's avatar
      WebCore: · b5db420f
      adachan@apple.com authored
              Changed the signature of imageTitleForFilename so we can pass in the width
              and height as integers.
      
              Reviewed by Dan.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::imageTitle):
      
      WebKit:
              Updated the format string for window title for a standalone image to take integers.
      
              Reviewed by Dan.
      
              * English.lproj/Localizable.strings:
      
      WebKit/mac:
              Now we pass width and height directly as integers to format
              the window title for a standalone image.
      
              Reviewed by Dan.
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory imageTitleForFilename:width:height:]):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5db420f
    • adachan@apple.com's avatar
      <rdar://problem/5830598> Image file opened in the browser window shows... · c470a11f
      adachan@apple.com authored
              <rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
              Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
              Changed the format string to take in integers.
      
              Reviewed by Dan.
      
              * English.lproj/Localizable.strings: Updated.
              * WebCoreLocalizedStrings.cpp:
              (WebCore::imageTitle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c470a11f
  5. 03 Apr, 2008 5 commits