Commits · cca140f1370b5a844a54119af61d72f165d0f0de · App_Technologies / webkit

06 Jan, 2012 27 commits

Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742 · cca140f1

dslomov@google.com authored Jan 06, 2012

and updated chromium-mac expectations for fast/forms/input-disabled-color.html.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cca140f1

Source/WebCore: Pass Content-Security-Policy directives to worker threads. · 34a3d9f3

tsepez@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

Tests: http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html
       http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html
       http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html
       http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html

* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::policy):
(WebCore::ContentSecurityPolicy::headerType):
* workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
* workers/DedicatedWorkerContext.h:
(WebCore::DedicatedWorkerContext::create):
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):
* workers/DedicatedWorkerThread.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
* workers/DefaultSharedWorkerRepository.h:
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::SharedWorkerContext):
* workers/SharedWorkerContext.h:
(WebCore::SharedWorkerContext::create):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):
* workers/SharedWorkerThread.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
* workers/WorkerThread.h:

Source/WebKit/chromium: Pass Content-security-policy directive to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242

Reviewed by David Levin.

* http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Added.
(onconnect):
* http/tests/security/contentSecurityPolicy/resources/worker-make-xhr.js: Added.
* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/worker-connect-src-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html: Added.
* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

34a3d9f3

[CSSRegions]Crash while collecting svg elements in render flow thread. · 240c13fa

mihnea@adobe.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=73735

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/svg-doc-fragment-not-collected-expected.html
       fast/regions/svg-doc-fragment-not-collected.html
       fast/regions/svg-element-not-collected-expected.html
       fast/regions/svg-element-not-collected.html
       fast/regions/svg-root-element-collected.html

By allowing only svg root elements to be collected in a render flow thread,
the svg render tree is properly constructed, thus prevented a possible further crash.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

LayoutTests:

* fast/regions/resources/region-style.css:
* fast/regions/svg-doc-fragment-not-collected-expected.html: Added.
* fast/regions/svg-doc-fragment-not-collected.html: Added.
* fast/regions/svg-element-not-collected-expected.html: Added.
* fast/regions/svg-element-not-collected.html: Added.
* fast/regions/svg-root-element-collected-expected.txt: Added.
* fast/regions/svg-root-element-collected.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

240c13fa

Make TextTrackCue more mutable · ffedf376

eric.carlson@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=72555

Reviewed by Anders Carlsson.

Source/WebCore: 

Test: media/track/track-cue-mutable.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"
    flag is set
(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have
    been added, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have
    been removed, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

* html/TextTrack.cpp:
(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its
    position in the interval tree is based on start and end times.
(WebCore::TextTrack::cueDidChange): Add the cue to the media element.
* html/TextTrack.h:

* html/TextTrackCue.cpp:
(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.
* html/TextTrackCue.h:
(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):
* html/TextTrackCue.idl:

LayoutTests: 

* media/track/track-cue-mutable-expected.txt: Added.
* media/track/track-cue-mutable.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ffedf376

ASSERT failure due to combine-text with preceding spaces · f6c35c0b

commit-queue@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=65147

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.

Source/WebCore:

A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.

This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.

* fast/text/international/spaces-combined-in-vertical-text.html: Added
* fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f6c35c0b

Crash with range selection across different documents. · 8b923b0d

inferno@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=74285

Reviewed by Ryosuke Niwa.

Source/WebCore: 

Test: fast/dom/Range/range-selection-across-documents-crash.html

* page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):

LayoutTests: 

* fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
* fast/dom/Range/range-selection-across-documents-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8b923b0d

Unreviewed; fixing expectation error. · 1edea935

dslomov@google.com authored Jan 06, 2012

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1edea935

Convert overflow-in-uniform-regions to a reftest · 0099ac26

commit-queue@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=74765

Replaced the bitmap version of the test with a "reftest" version.   Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.

Patch by Hans Muller <hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.

* fast/regions/overflow-in-uniform-regions-expected.html: Added.
* fast/regions/overflow-in-uniform-regions.html:
* platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0099ac26

Need to relayout when stretching the height of a flex item · d7bf4b0c

tony@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75661

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-align-stretch.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.

LayoutTests:

* css3/flexbox/flex-align-stretch-expected.txt: Added.
* css3/flexbox/flex-align-stretch.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d7bf4b0c

2012-01-06 Dmitry Lomov <dslomov@google.com> · 4488ddc2

dslomov@google.com authored Jan 06, 2012

	Unreviewed: [Chromium] rebaselining IMAGE expectations after http://trac.webkit.org/changeset/104240/

        * platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
        * platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
        * platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
        * platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
        * platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
        * platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
        * platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
        * platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4488ddc2

Fullscreen video controller can't be dragged the first time I enter fullscreen · 90155188

jer.noble@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

* fullscreen/video-controls-drag.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

90155188

Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299. · b3637912

jonlee@apple.com authored Jan 06, 2012

Unreviewed.

* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b3637912

Media Element: scrubbing in full-screen mode breaks playback. · d91faace

jer.noble@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75650

Reviewed by John Sullivan.

Source/WebCore:

Test: fullscreen/video-controls-timeline.html

Only begin scrubbing if the panel itself is the mousedown event target.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::defaultEventHandler):

LayoutTests:

* fullscreen/video-controls-timeline-expected.txt: Added.
* fullscreen/video-controls-timeline.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d91faace

Add new (failing) test to Chromium test_expectations. Fix tracked by · bfc36932

jer.noble@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75716

Unreviewed; test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bfc36932

REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally · d05b8a4d

jer.noble@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75200

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/video-controls-drag.html

The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp.  Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.

* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):

LayoutTests:

* fullscreen/video-controls-drag-expected.txt: Added.
* fullscreen/video-controls-drag.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d05b8a4d

[Chromium] Remove fast/files/domurl-script-execution-context-crash.html · 9cf5929a

senorblanco@chromium.org authored Jan 06, 2012

from test_expectations (no longer crashing).

Unreviewed; test expectations update.

* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9cf5929a

Tools: Update DRT on Mac to draw resize handles on text areas. · 52385a91

jonlee@apple.com authored Jan 06, 2012

Reviewed by John Sullivan.

Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.

Reviewed by John Sullivan.

Moved from mac to mac-snowleopard:

* platform/mac-snowleopard/fast/forms/001
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
* platform/mac-snowleopard/fast/forms/basic-buttons-expected
* platform/mac-snowleopard/fast/forms/basic-inputs-expected
* platform/mac-snowleopard/fast/forms/basic-selects-expected
* platform/mac-snowleopard/fast/forms/basic-textareas-expected
* platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
* platform/mac-snowleopard/fast/forms/box-shadow-override
* platform/mac-snowleopard/fast/forms/button-align
* platform/mac-snowleopard/fast/forms/button-generated-content
* platform/mac-snowleopard/fast/forms/button-sizes
* platform/mac-snowleopard/fast/forms/button-style-color
* platform/mac-snowleopard/fast/forms/button-table-styles
* platform/mac-snowleopard/fast/forms/button-text-transform
* platform/mac-snowleopard/fast/forms/button-white-space
* platform/mac-snowleopard/fast/forms/control-restrict-line-height
* platform/mac-snowleopard/fast/forms/disabled-select-change-index
* platform/mac-snowleopard/fast/forms/fieldset-align
* platform/mac-snowleopard/fast/forms/file/file-input-direction
* platform/mac-snowleopard/fast/forms/form-element-geometry
* platform/mac-snowleopard/fast/forms/form-hides-table
* platform/mac-snowleopard/fast/forms/input-appearance-height
* platform/mac-snowleopard/fast/forms/input-button-sizes
* platform/mac-snowleopard/fast/forms/input-table
* platform/mac-snowleopard/fast/forms/input-value
* platform/mac-snowleopard/fast/forms/menulist-style-color
* platform/mac-snowleopard/fast/forms/option-strip-whitespace
* platform/mac-snowleopard/fast/forms/placeholder-position
* platform/mac-snowleopard/fast/forms/radio_checked
* platform/mac-snowleopard/fast/forms/radio_checked_dynamic
* platform/mac-snowleopard/fast/forms/range/slider-padding
* platform/mac-snowleopard/fast/forms/select-align
* platform/mac-snowleopard/fast/forms/select-baseline-expected
* platform/mac-snowleopard/fast/forms/select-disabled-appearance
* platform/mac-snowleopard/fast/forms/select-initial-position
* platform/mac-snowleopard/fast/forms/select-style
* platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
* platform/mac-snowleopard/fast/forms/textAreaLineHeight
* platform/mac-snowleopard/fast/forms/textarea-align
* platform/mac-snowleopard/fast/forms/textarea-scroll-height
* platform/mac-snowleopard/fast/forms/textarea-width
* platform/mac-snowleopard/fast/overflow/overflow-x-y

New pixel test results:

* platform/mac/fast/forms/001-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/mac/fast/forms/basic-buttons-expected.png:
* platform/mac/fast/forms/basic-inputs-expected.png:
* platform/mac/fast/forms/basic-selects-expected.png:
* platform/mac/fast/forms/basic-textareas-expected.png:
* platform/mac/fast/forms/basic-textareas-quirks-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/button-align-expected.png:
* platform/mac/fast/forms/button-generated-content-expected.png:
* platform/mac/fast/forms/button-sizes-expected.png:
* platform/mac/fast/forms/button-style-color-expected.png:
* platform/mac/fast/forms/button-table-styles-expected.png:
* platform/mac/fast/forms/button-text-transform-expected.png:
* platform/mac/fast/forms/button-white-space-expected.png:
* platform/mac/fast/forms/control-restrict-line-height-expected.png:
* platform/mac/fast/forms/disabled-select-change-index-expected.png:
* platform/mac/fast/forms/fieldset-align-expected.png:
* platform/mac/fast/forms/file/file-input-direction-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-hides-table-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-button-sizes-expected.png:
* platform/mac/fast/forms/input-table-expected.png:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/menulist-style-color-expected.png:
* platform/mac/fast/forms/option-strip-whitespace-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/radio_checked-expected.png:
* platform/mac/fast/forms/radio_checked_dynamic-expected.png:
* platform/mac/fast/forms/range/slider-padding-expected.png:
* platform/mac/fast/forms/select-align-expected.png:
* platform/mac/fast/forms/select-baseline-expected.png:
* platform/mac/fast/forms/select-disabled-appearance-expected.png:
* platform/mac/fast/forms/select-initial-position-expected.png:
* platform/mac/fast/forms/select-style-expected.png:
* platform/mac/fast/forms/select-writing-direction-natural-expected.png:
* platform/mac/fast/forms/textAreaLineHeight-expected.png:
* platform/mac/fast/forms/textarea-align-expected.png:
* platform/mac/fast/forms/textarea-scroll-height-expected.png:
* platform/mac/fast/forms/textarea-width-expected.png:
* platform/mac/fast/overflow/overflow-x-y-expected.png:

Added new results:

* platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
* platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
* platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed
brand new baseline, and so does Snow Leopard.
* platform/mac/fast/forms/listbox-clip-expected.txt:
* platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.

New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.

* platform/mac/fast/table/003-expected.png:
* platform/mac/tables/mozilla/bugs/bug194024-expected.png:
* platform/mac/tables/mozilla/bugs/bug30692-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

52385a91

[Chromium] Expectations for svg/carto.net/button.svg can be updated · 0e8ed124

commit-queue@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed update to Chromium test_expectations

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-06

* platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0e8ed124

[Chromium] Set baseline for new test... · 7e9be1ae

jknotten@chromium.org authored Jan 06, 2012

[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
https://bugs.webkit.org/show_bug.cgi?id=75706

Unreviewed.

* platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7e9be1ae

make canvas-lineWidth test pass even if pixel values vary a tiny bit · cc97ad2b

commit-queue@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <epoger@google.com> on 2012-01-06
Reviewed by Stephen White.

* fast/canvas/canvas-lineWidth.js:
(compareRows):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cc97ad2b

Rebaseline mac results after r104240. · 45a1da04

jknotten@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.

Unreviewed.

* platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-leopard/fast/table/003-expected.png:
* platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
* platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
* platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
* platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
* platform/chromium-mac/fast/table/003-expected.png: Removed.
* platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
* platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
* platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
* platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
* platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

45a1da04

[Qt] Unreviewed gardening. Skip a new failing test. · 130062c9

ossy@webkit.org authored Jan 06, 2012

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

130062c9

[Chromium] Update test expectations. · c8a2ff16

jknotten@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75698

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c8a2ff16

Move MediaDocument styles into CSS. Set black background for chromium. · 20b955b1

commit-queue@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=74123

Source/WebCore:

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

Test: platform/chromium/media/video-black-bg-in-media-document.html

* css/mediaControls.css:
(body:-webkit-full-page-media):
(video:-webkit-full-page-media):
* css/mediaControlsChromium.css:
(body:-webkit-full-page-media):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Adds a new chromium specific test for ensuring the background is set
properly.

Rebaselines the text portions of media-document-audio-repaint.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium/media/media-document-audio-repaint-expected.txt:
* platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
* platform/chromium/media/video-black-bg-in-media-document.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

20b955b1

[Qt] Unreviewed gardening. Update Qt specific expected results after r104208. · 81c3381b

ossy@webkit.org authored Jan 06, 2012

* platform/qt/fast/table/032-expected.png:
* platform/qt/fast/table/032-expected.txt:
* platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
* platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
* platform/qt/tables/mozilla/bugs/bug55694-expected.png:
* platform/qt/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

81c3381b

Report correct line number for non-native editable text elements. · cf75b0ab

aboxhall@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=71263

Reviewed by Ryosuke Niwa.

Source/WebCore:

A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.

This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.

This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.

Test: accessibility/textbox-role-reports-line-number.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.
* dom/Node.cpp:
(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
* dom/Node.h:
(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable): Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.
* editing/EditingBoundary.h:
* editing/htmlediting.cpp:
(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.
* editing/htmlediting.h:
* editing/visible_units.cpp:
(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.
* editing/visible_units.h:

LayoutTests:

* accessibility/textbox-role-reports-line-number-expected.txt: Added.
* accessibility/textbox-role-reports-line-number.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cf75b0ab

Fix a crash by importing an element of which local name ends with ":input". · 02045fa1

tkent@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75103

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/importNode-confusing-localName.html

* dom/Document.cpp:
(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name

LayoutTests:

* fast/dom/importNode-confusing-localName-expected.txt: Added.
* fast/dom/importNode-confusing-localName.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

02045fa1

05 Jan, 2012 13 commits

Date constructor handles infinite values incorrectly. · 3d128b23

barraclough@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=70998

Reviewed by Filip Pizlo.

Source/JavaScriptCore: 

* runtime/DateConstructor.cpp:
(JSC::constructDate):
    - should be checking !finite rather then isnan.

LayoutTests: 

* fast/js/date-constructor-expected.txt:
* fast/js/script-tests/date-constructor.js:
    - Added test cases.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3d128b23

date.toISOString produces incorrect results for dates with ms prior to 1970 · 0e4e5254

barraclough@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75684

Reviewed by Sam Weinig.

Source/JavaScriptCore: 

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):

LayoutTests: 

* fast/js/date-toisostring-expected.txt:
* fast/js/script-tests/date-toisostring.js:
    - Added test case



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0e4e5254

More chromium expected results after r104208. · eb574aab

ojan@chromium.org authored Jan 06, 2012

* platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
* platform/chromium-win-xp/fast/table/032-expected.png:
* platform/chromium-win-xp/fast/table/032-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eb574aab

Array.prototype.lastIndexOf ignores undefined fromIndex. · 580681e5

barraclough@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75678

Reviewed by Sam Weinig.

Source/JavaScriptCore: 

array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncLastIndexOf):
    - should check argumnet count, rather than checking agument value for undefined.

LayoutTests: 

* ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
    - check in passing result



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

580681e5

Source/WebCore: Disallow access to DOM storage from detached frames. · 59632a7c

jochen@chromium.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):

Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* fast/storage/storage-detached-iframe-expected.txt:
* fast/storage/storage-detached-iframe.html:
* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

59632a7c

Source/WebCore: IndexedDB: fix cursor prefetch crash · 60073522

dgrogan@chromium.org authored Jan 06, 2012

http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium.  The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.
* storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

* storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
* storage/indexeddb/prefetch-bugfix-108071.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

60073522

Date parsing is too restrictive. · 11c47306

barraclough@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75671

Reviewed by Oliver Hunt.

Source/JavaScriptCore: 

ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.

The date portion on the should match: (pseudocode!:)
    [(+|-)YY]YYYY[-MM[-DD]]
though we are slightly more liberal (permitted by the spec), allowing:
    [+|-]Y+[-MM[-DD]]
The time portion should match:
    THH:mm[:ss[.sss]][Z|(+|-)HH:mm]
again we're slightly more liberal, allowing:
    THH:mm[:ss[.s+]][Z|(+|-)HH:mm]

* wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
    - Month/day fields are optional, default to 01.
(WTF::parseES5TimePortion):
    - Hours/Minutes are requires, seconds/timezone are optional.
(WTF::parseES5DateFromNullTerminatedCharacters):
    - Dates may be date only, or date + time.

LayoutTests: 

* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
    - Add more test cases for Date.parse.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11c47306

Mark flaky test as flaky. Filed · ba16caed

abarth@webkit.org authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75647 about making it not
flaky.

* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ba16caed

Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe · 779c8add

andersca@apple.com authored Jan 06, 2012

https://bugs.webkit.org/show_bug.cgi?id=75667
<rdar://problem/10389454>

Reviewed by Kevin Decker.

Source/WebKit2:

NPRuntimeObjectMap::invalidate is called whenever a plug-in view is destroyed. If invalidate is called for an object map
whose plug-in has a null frame, we'd crash.

The plug-in will have a null frame if the plug-in view is destroyed because its containing frame has been removed from the document,
and if the plug-in view is being destroyed asynchronously due to the plug-in itself calling JavaScript that will remove the frame
(see PluginView::unprotectPluginFromDestruction).

The reason NPRuntimeObjectMap::invalidate will crash when the frame is null is because we were trying to access the frame's global
object, causing a null dereference. The reason we were trying to get at the frame's global object was to create a Strong handle to
a JSNPObject so we could stick the object in a vector so we could later iterate over the vector elements and call invalidate() on
each JSNPObject which will end up releasing the underlying NPObject.

However, it turns out that we don't need to stick the JSNPObject in a vector; we can just get the underlying NPObject directly and
stick that in a vector and then iterate over the NPObjects, releasing them.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::invalidate):

Tools:

Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::executeScript):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):

LayoutTests:

* plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
* plugins/npruntime/object-from-destroyed-plugin-in-subframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

779c8add

New chromium expected results after r104208. · e810b99c

ojan@chromium.org authored Jan 05, 2012

* platform/chromium-linux/fast/table/032-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-mac-leopard/fast/table/032-expected.png:
* platform/chromium-mac-leopard/fast/table/032-expected.txt: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55694-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug55694-expected.png: Removed.
* platform/chromium-win-xp/fast/table/032-expected.png: Added.
* platform/chromium-win-xp/fast/table/032-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/table/032-expected.txt.
* platform/chromium-win/fast/table/032-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e810b99c

Unreviewed: Updating expecxtations for fast/media/viewport-media-query. · 26c1a238

dslomov@google.com authored Jan 05, 2012

My understanding of the semantics was a bit off.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

26c1a238

Literal tab in JSONString fails · f363ea28

barraclough@apple.com authored Jan 05, 2012

https://bugs.webkit.org/show_bug.cgi?id=71772

Reviewed by Oliver Hunt.

rfc4627 does not allow literal tab characters in JSON source.

Source/JavaScriptCore: 

* runtime/LiteralParser.cpp:
(JSC::isSafeStringCharacter):
    - do not allow literal tab in StrictJSON mode.

LayoutTests: 

* fast/js/JSON-parse-expected.txt:
* fast/js/resources/JSON-parse.js:
(createTests.result):
    - Updated expected results.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f363ea28

IE quirk for percentage size on a table element doesn't work with orthogonal writing modes · 9d818312

ojan@chromium.org authored Jan 05, 2012

https://bugs.webkit.org/show_bug.cgi?id=70195

Reviewed by Eric Seidel.

Source/WebCore:

Remove this quirk entirely. Mozilla and Opera don't implement it and IE
doesn't restrict the quirk to standards mode. As it's unlikely for
webkit-only content to hit this quirk (e.g. use tables for layout),
it should be relatively safe to match Mozilla/Opera here.

Test: fast/writing-mode/table-percent-width-quirk.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

* fast/table/032.html:
* fast/writing-mode/table-percent-width-quirk-expected.png: Added.
* fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
* fast/writing-mode/table-percent-width-quirk.html: Added.
* platform/mac/fast/table/032-expected.png:
* platform/mac/fast/table/032-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55694-expected.png:
* platform/mac/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d818312