1. 23 Jan, 2012 40 commits
    • commit-queue@webkit.org's avatar
      Fine tune Web Intents Chromium API · cc75f55e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76754
      
      Patch by Greg Billock <gbillock@google.com> on 2012-01-23
      Reviewed by Darin Fisher.
      
      * public/WebIntent.h:
      * public/WebIntentServiceInfo.h:
      * src/WebIntent.cpp:
      * src/WebIntentServiceInfo.cpp:
      (WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc75f55e
    • shawnsingh@chromium.org's avatar
      [chromium] updateRect is incorrect when contentBounds != bounds · 24b7c203
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72919
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Unit test added to TiledLayerChromiumTest.cpp
      
      The m_updateRect member in LayerChromium types is used to track
      what was painted for that layer. For tiled layers (especially
      image layers), the updateRect was being given with respect to the
      size of the content, rather than the size of the layer. This patch
      adds a conversion so that updateRect is always with respect to the
      layer size, so that damage tracking will work correctly in those
      cases.
      
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::updateCompositorResources):
      
      Source/WebKit/chromium:
      
      * tests/TiledLayerChromiumTest.cpp:
      (WTF::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
      (WTF::FakeTiledLayerWithScaledBounds::setContentBounds):
      (WTF::FakeTiledLayerWithScaledBounds::contentBounds):
      (WTF::FakeTiledLayerWithScaledBounds::updateRect):
      (WTF::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24b7c203
    • commit-queue@webkit.org's avatar
      Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods. · 2acc73bd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76706
      
      Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-23
      Reviewed by Pavel Feldman.
      
      Changed DOMAgent.copyNode to call getOuterHTML and use the callback function to
      return the text to InspectorFrontendHost.copyText.  This will make all copy
      functions use the same code path.
      
      Not testable.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorDOMAgent.h:
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode.prototype.copyNode.copy):
      (WebInspector.DOMNode.prototype.copyNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2acc73bd
    • macpherson@chromium.org's avatar
      Make zoom multiplier float instead of double to match... · 6f00b60a
      macpherson@chromium.org authored
      Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
      https://bugs.webkit.org/show_bug.cgi?id=69490
      
      Reviewed by Andreas Kling.
      
      Covered by existing tests.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::computeLength):
      Use float multiplier instead of double.
      (WebCore::CSSPrimitiveValue::computeLengthDouble):
      Use float multiplier instead of double.
      * css/CSSPrimitiveValue.h:
      Change type signatures of computeLength template prototype.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f00b60a
    • mhahnenberg@apple.com's avatar
      Use copying collector for out-of-line JSObject property storage · 4108deff
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76665
      
      Reviewed by Geoffrey Garen.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
      (JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to 
      operator new.
      * runtime/JSObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4108deff
    • toyoshim@chromium.org's avatar
      [Chromium][WebSocket] Remove binary communication using WebData in WebKit API · 2f3c7a92
      toyoshim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76608
      
      Reviewed by Darin Fisher.
      
      * public/WebSocket.h: Remove BinaryTypeData definition and sendBinary(const WebData&).
      * public/WebSocketClient.h: Remove didReceiveBinaryData(const WebData&).
      * src/WebSocketImpl.cpp: Remove WebData related code and set default binary type as BinaryTypeBlob.
      (WebKit::WebSocketImpl::WebSocketImpl): Remove sendBinary(const WebData&).
      (WebKit::WebSocketImpl::didReceiveBinaryData): Remove WebData supporting code.
      * src/WebSocketImpl.h: Remove sendBinary(const WebData&).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f3c7a92
    • dpranke@chromium.org's avatar
      nrwt: make --chromium work like --qt · d9061f86
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76875
      
      Reviewed by Adam Barth.
      
      --chromium used to have to be handled differently from --qt
      due to the way the PortFactory was implemented; there's not
      really a good reason for that any more so this patch makes
      things slightly more consistent and eliminates the
      options.chromium flag (--chromium is now truly a synonym for
      --platform chromium).
      
      * Scripts/webkitpy/layout_tests/port/factory.py:
      (PortFactory._default_port):
      (PortFactory.get):
      * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
      (FactoryTest.setUp):
      (FactoryTest.test_chromium_mac):
      (FactoryTest.test_chromium_linux):
      (FactoryTest.test_chromium_win):
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      (parse_args):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9061f86
    • dpranke@chromium.org's avatar
      run-webkit-tests needs to propagate --chromium · 13bb4476
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76870
      
      Reviewed by Eric Seidel.
      
      run-webkit-tests removes '--chromium' argument from @ARGV when
      determining which port to run, which means that that doesn't
      propagate to new-run-webkit-tests. That's bad (and is handled
      for the other ports by re-adding the flag, but apparently we're
      just now noticing for Chromium).
      
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13bb4476
    • eae@chromium.org's avatar
      Unreviewed test expectations fixes for a couple of window/frame tests. · f37684e3
      eae@chromium.org authored
      * http/tests/security/cross-frame-access-put-expected.txt:
      Updated expectations to reflect that window.frameElement now has the type
      HTMLIFrameElement. The test itself has already been updated.
      
      * platform/mac/fast/dom/Window/window-properties-expected.txt:
      Added window.applicationCache.abort method.
      
      * platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
      Added DOMURL class.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f37684e3
    • commit-queue@webkit.org's avatar
      [GTK][PATCH] More build silencing with (AM_V_...) · 4d65fba2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76791
      
      Patch by Priit Laes <plaes@plaes.org> on 2012-01-23
      Reviewed by Gustavo Noronha Silva.
      
      * GNUmakefile.am: Silence is golden...
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d65fba2
    • commit-queue@webkit.org's avatar
      [Qt] Implement SSL error handling QML API. · 628dca58
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76793
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23
      Reviewed by Simon Hausmann.
      
      This patch implements support for accepting or rejecting invalid SSL
      certificates from the QML API.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::QQuickWebViewPrivate):
      (QQuickWebViewPrivate::handleCertificateVerificationRequest):
      (QQuickWebViewExperimental::certificateVerificationDialog):
      (QQuickWebViewExperimental::setCertificateVerificationDialog):
      * UIProcess/API/qt/qquickwebview_p.h:
      * UIProcess/API/qt/qquickwebview_p_p.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::certificateVerificationRequest):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/qt/QtDialogRunner.cpp:
      (CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject):
      (CertificateVerificationDialogContextObject::hostname):
      (CertificateVerificationDialogContextObject::accept):
      (CertificateVerificationDialogContextObject::reject):
      (QtDialogRunner::initForCertificateVerification):
      * UIProcess/qt/QtDialogRunner.h:
      * UIProcess/qt/QtPageClient.cpp:
      (QtPageClient::handleCertificateVerificationRequest):
      * UIProcess/qt/QtPageClient.h:
      * WebProcess/qt/QtNetworkAccessManager.cpp:
      (WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
      (WebKit::QtNetworkAccessManager::onSslErrors):
      * WebProcess/qt/QtNetworkAccessManager.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      628dca58
    • bweinstein@apple.com's avatar
      More build fixing after r105646. · e88fc125
      bweinstein@apple.com authored
      Source/JavaScriptCore: 
      
      * JavaScriptCore.exp:
      
      Tools: 
      
      * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
      (TestWebKitAPI::TestNode::key):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e88fc125
    • commit-queue@webkit.org's avatar
      MicroData: Remove ExceptionCode& from setAttribute() call. · 7feb9533
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76695
      
      Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
      Reviewed by Hajime Morita.
      
      Changeset http://trac.webkit.org/changeset/103296 removed unused
      ExceptionCode& argument from Element::setAttribute(QualifiedName).
      Hence updating all calls to setAttribute() method in MicroData code.
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::setItemValueText):
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::setItemValueText):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::setItemValueText):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::setItemValueText):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::setItemValueText):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::setItemValueText):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::setItemValueText):
      * html/HTMLMetaElement.cpp:
      (WebCore::HTMLMetaElement::setItemValueText):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::setItemValueText):
      * html/HTMLSourceElement.cpp:
      (WebCore::HTMLSourceElement::setItemValueText):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::setItemValueText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7feb9533
    • levin@chromium.org's avatar
      [windows] Convert usages of GetDC to HWndDC Part 2. · 691549bb
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76750
      
      Reviewed by Adam Roben.
      
      Source/WebKit/win:
      
      * FullscreenVideoController.cpp:
      (createCompatibleDCForWindow): Moved out the code which creates a DC for a window
      to keep the same scope for the DC lifetime.
      (FullscreenVideoController::draw):  Switch to using OwnPtr<HDC>
      since createCompatibleDCForWindow returns a PassOwnPtr.
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::update):
        Cleaned up leaks from calling GetDC without release.
        Note that there is a potential leak of hdc that previously existed
        and still does in an early exit scenario. (This could be easily fixed
        by using OwnPtr<HDC> but I was trying to keep this patch focused.)
      * WebView.cpp:
      (WebView::scrollBackingStore): Typical conversion.
      (WebView::updateBackingStore): Reduced the scope of windowDC to be
      right where it is being used.
      (WebView::performLayeredWindowUpdate): Typical conversion.
      (WebView::paintIntoBackingStore): Ditto.
      
      Source/WebKit2:
      
      * Shared/win/ShareableBitmapWin.cpp:
      (WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which
      would do a DeleteDC instead of a ReleaseDC.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      691549bb
    • barraclough@apple.com's avatar
      Unreviewed build fix - r105646 broke this. · d24c6be6
      barraclough@apple.com authored
      * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
      (TestWebKitAPI::TestNode::TestNode):
      (TestWebKitAPI::TestNode::key):
      (TestWebKitAPI::RedBlackTreeTest::assertEqual):
      (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
      (TestWebKitAPI::RedBlackTreeTest::testDriver):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d24c6be6
    • hayato@chromium.org's avatar
      Fix crash when a focused node is removed while in processing focusin event. · 0159d533
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76656
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Test: fast/events/focus-remove-focuesed-node.html
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      
      LayoutTests:
      
      * fast/events/focus-remove-focuesed-node-expected.txt: Added.
      * fast/events/focus-remove-focuesed-node.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0159d533
    • scherkus@chromium.org's avatar
      Switch media/audio-data-url.html layout test to base64-encoded WAV data. · 52410747
      scherkus@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76759
      
      Reviewed by Eric Carlson.
      
      * media/audio-data-url-expected.txt:
      * media/audio-data-url.html:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52410747
    • abarth@webkit.org's avatar
      Unreviewed, rolling out r105658. · a219d97d
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/105658
      https://bugs.webkit.org/show_bug.cgi?id=76883
      
      We want this eventually, but not right at this moment
      (Requested by abarth on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a219d97d
    • jamesr@google.com's avatar
      [chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets... · 8c6bc93d
      jamesr@google.com authored
      [chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build
      https://bugs.webkit.org/show_bug.cgi?id=76879
      
      Reviewed by Dirk Pranke.
      
      * WebKit.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c6bc93d
    • levin@chromium.org's avatar
      [windows] Convert usages of GetDC to HWndDC Part 1. · 7ca31dfd
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76744
      
      Reviewed by Adam Roben.
      
      Source/WebCore:
      
      No new functionality so no new tests.
      
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC
      and removed ReleaseDC.
      (WebCore::createGDIFont): Ditto.
      (WebCore::FontCache::getTraitsInFamily): Ditto.
      * platform/graphics/win/FontPlatformDataWin.cpp:
      (WebCore::FontPlatformData::FontPlatformData): Ditto.
      * platform/graphics/win/SimpleFontDataCGWin.cpp:
      (WebCore::SimpleFontData::platformInit): Ditto.
      * platform/graphics/win/SimpleFontDataWin.cpp:
      (WebCore::SimpleFontData::initGDIFont): Ditto.
      (WebCore::SimpleFontData::containsCharacters): Ditto.
      (WebCore::SimpleFontData::determinePitch): Ditto.
      (WebCore::SimpleFontData::boundsForGDIGlyph): Ditto.
      (WebCore::SimpleFontData::widthForGDIGlyph): Ditto.
      (WebCore::SimpleFontData::scriptFontProperties): Ditto.
      * platform/win/CursorWin.cpp:
      (WebCore::createSharedCursor): Ditto.
      * platform/win/DragImageCGWin.cpp:
      (WebCore::scaleDragImage): Ditto.
      (WebCore::createDragImageFromImage): Ditto.
      * platform/win/DragImageWin.cpp:
      (WebCore::createDragImageForLink): Ditto.
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writeImage): Ditto.
      
      Source/WebKit/win:
      
      * WebIconDatabase.cpp:
      (createDIB): Changed GetDC to HWndDC and removed ReleaseDC.
      
      Source/WebKit2:
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::flashBackingStoreUpdates): Typical conversion.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ca31dfd
    • commit-queue@webkit.org's avatar
      [GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper properties · 0823eec7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76747
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23
      Reviewed by Gustavo Noronha Silva.
      
      No new tests. Regressions are covered by existing tests, but testing
      different GTK+ theme configurations is not possible yet.
      
      * platform/gtk/ScrollbarThemeGtk.cpp:
      (WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect.
      (WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect.
      (WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is
      no steppers.
      * platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers.
      * platform/gtk/ScrollbarThemeGtk2.cpp:
      (WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there
      are primary foward and back steppers.
      * platform/gtk/ScrollbarThemeGtk3.cpp:
      (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0823eec7
    • rniwa@webkit.org's avatar
      REGRESSION(r105396): drag state is not cleared after each drag · d22c03e2
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76878
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Revert a part of r105396 that made performDragAndDrop not call clearDragState
      when the default action was not prevented since it caused a regression.
      
      I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
      but I can't think of a test case where this becomes a problem at the moment.
      Since this area is not well tested, revert the change instead of making further
      changes to the code base.
      
      Tests: fast/events/clear-drag-state.html
             fast/events/clear-edit-drag-state.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::performDragAndDrop):
      
      LayoutTests: 
      
      Add a regression test to ensure we don't fire extra dragenter event
      on the second drag at an element that contains the dragged content.
      
      * fast/events/clear-drag-state-expected.txt: Added.
      * fast/events/clear-drag-state.html: Added.
      * fast/events/clear-edit-drag-state-expected.txt: Added.
      * fast/events/clear-edit-drag-state.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22c03e2
    • abarth@webkit.org's avatar
      garden-o-matic should support Chromium Mac Lion · e7a56a6f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76880
      
      Reviewed by Eric Seidel.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7a56a6f
    • commit-queue@webkit.org's avatar
      Fixed typo in exception messages · 994f1bc2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76710
      
      Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23
      Reviewed by Alexey Proskuryakov.
      
      * dom/DOMCoreException.cpp:
      * fileapi/FileException.cpp:
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::openTransactionAndPreflight):
      (WebCore::SQLTransaction::postflightAndCommit):
      * xml/XMLHttpRequestException.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      994f1bc2
    • levin@chromium.org's avatar
      Allow delayed DC allocation in HWndDC. · 40f8d29a
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76737
      
      Reviewed by Adam Roben.
      
      No new functionality exposed so no new tests.
      
      * platform/win/HWndDC.h: Changed this slightly to allow
      for allocating a window DC after the initial creation since
      this pattern occurrs in several places so this makes it easy to
      replace them in an upcoming change.
      (WebCore::HWndDC::HWndDC):
      (WebCore::HWndDC::~HWndDC):
      (WebCore::HWndDC::setHWnd):
      (WebCore::HWndDC::clear):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40f8d29a
    • commit-queue@webkit.org's avatar
      MicroData: Compilation error while building Webkit with --microdata. · 3820c1dc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76703
      
      Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
      Reviewed by Hajime Morita.
      
      * dom/MicroDataItemList.cpp:
      (WebCore::MicroDataItemList::MicroDataItemList):
      (WebCore::MicroDataItemList::~MicroDataItemList):
      * dom/MicroDataItemList.h:
      * dom/NodeRareData.h:
      (WebCore::NodeRareData::properties):
      * html/HTMLPropertiesCollection.cpp:
      (WebCore::HTMLPropertiesCollection::create):
      (WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
      * html/HTMLPropertiesCollection.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3820c1dc
    • levin@chromium.org's avatar
      [chromium] Convert uses of GetDC to HWndDC. · a07b659f
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76290
      
      Reviewed by Dmitry Titov.
      
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::createFontIndirectAndGetWinName):
      (WebCore::fontContainsCharacter):
      (WebCore::FontCache::getLastResortFallbackFont):
      (WebCore::FontCache::getTraitsInFamily):
      * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
      (WebCore::FontPlatformData::scriptFontProperties):
      * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
      (WebCore::FontMap::getAscent):
      (WebCore::FontMap::getSpaceGlyph):
      * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
      (WebCore::fillBMPGlyphs):
      * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
      (WebCore::SimpleFontData::platformInit):
      (WebCore::SimpleFontData::determinePitch):
      (WebCore::SimpleFontData::platformWidthForGlyph):
      * platform/graphics/chromium/UniscribeHelper.cpp:
      (WebCore::UniscribeHelper::EnsureCachedDCCreated):
      * rendering/RenderThemeChromiumWin.cpp:
      (WebCore::systemFontSize):
      (WebCore::pointsToPixels):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a07b659f
    • commit-queue@webkit.org's avatar
      website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page · fab3b104
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76544
      
      Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      WEBKITOUTPUTDIR is not only for Windows.
      
      * building/build.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fab3b104
    • eae@chromium.org's avatar
      check-webkit-style whitespace/operators triggers on overloaded division operator · ec58bb3c
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76650
      
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_spacing):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest.test_operator_methods):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec58bb3c
    • commit-queue@webkit.org's avatar
      Reduce throttling on video-buffering-repaints-controls test to prevent timeout. · 4de9c3dd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76113
      
      Also reduces flakiness by checking for a repaint between progress and
      suspend events versus just between progress events.
      
      Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
      Reviewed by Adam Barth.
      
      * http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
      * http/tests/media/video-buffering-repaints-controls.html:
      * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
      * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4de9c3dd
    • rniwa@webkit.org's avatar
      run-perf-tests should report server-side errors · b8edc624
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76802
      
      Reviewed by Tony Chang.
      
      Report errors whenever server's response doesn't match "OK".
      
      * Scripts/webkitpy/common/net/file_uploader.py:
      (FileUploader.upload_single_text_file):
      (FileUploader.upload_as_multipart_form_data):
      (FileUploader._upload_data.callback):
      (FileUploader):
      (FileUploader._upload_data):
      * Scripts/webkitpy/performance_tests/perftestsrunner.py:
      (PerfTestsRunner._upload_json):
      * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
      (test_upload_json):
      (test_upload_json.MockFileUploader.upload_single_text_file):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8edc624
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75799 · 5f5c5f30
      commit-queue@webkit.org authored
      Calling intersectsNode on a detached range should throw.
      
      Source/WebCore:
      
      INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      Test: fast/dom/Range/range-intersectsNode-exception.html
      
      * dom/Range.cpp:
      (WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.
      
      LayoutTests:
      
      Added test case to verify the exception thrown while calling intersectsNode on a detached range.
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      * fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
      * fast/dom/Range/range-intersectsNode-exception.html: Added.
      * fast/dom/Range/range-intersectsNode-expected.txt:
      * fast/dom/Range/resources/intersectsNode.js:  Modified the test case to catch the exception.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f5c5f30
    • dcheng@chromium.org's avatar
      Convert DataTransferItem/DataTransferItemList back into an interface class · ae86f2ab
      dcheng@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76856
      
      When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
      classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
      refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
      share the same data anymore so it doesn't make sense to keep that code in a common location.
      
      Reviewed by David Levin.
      
      Covered by existing tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/DataTransferItem.cpp:
      * dom/DataTransferItem.h:
      * dom/DataTransferItemList.cpp: Removed.
      * dom/DataTransferItemList.h:
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::mayUpdateItems):
      * platform/chromium/DataTransferItemChromium.cpp:
      (WebCore::DataTransferItemChromium::create):
      (WebCore::DataTransferItemChromium::DataTransferItemChromium):
      (WebCore::DataTransferItemChromium::getAsString):
      (WebCore::DataTransferItemChromium::getAsFile):
      (WebCore::DataTransferItemChromium::clipboardChromium):
      * platform/chromium/DataTransferItemChromium.h:
      (WebCore::DataTransferItemChromium::kind):
      (WebCore::DataTransferItemChromium::type):
      * platform/chromium/DataTransferItemListChromium.cpp:
      (WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
      * platform/chromium/DataTransferItemListChromium.h:
      * platform/qt/DataTransferItemListQt.cpp:
      (WebCore::DataTransferItemListQt::DataTransferItemListQt):
      (WebCore::DataTransferItemListQt::length):
      (WebCore::DataTransferItemListQt::item):
      (WebCore::DataTransferItemListQt::deleteItem):
      (WebCore::DataTransferItemListQt::clear):
      (WebCore::DataTransferItemListQt::add):
      * platform/qt/DataTransferItemListQt.h:
      * platform/qt/DataTransferItemQt.cpp:
      (WebCore::DataTransferItemQt::create):
      (WebCore::DataTransferItemQt::DataTransferItemQt):
      (WebCore::DataTransferItemQt::getAsString):
      (WebCore::DataTransferItemQt::getAsFile):
      * platform/qt/DataTransferItemQt.h:
      (WebCore::DataTransferItemQt::kind):
      (WebCore::DataTransferItemQt::type):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae86f2ab
    • mikelawther@chromium.org's avatar
      getComputedStyle margin percentage test for CSS calc · 26421928
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76130
      
      Reviewed by Darin Adler.
      
      Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
      
      These tests are expected to 'fail', and will pass once calc() functionality is landed.
      For now, they serve to demonstrate that the current code doesn't crash on these tests.
      
      * css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
      * css3/calc/getComputedStyle-margin-percentage.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26421928
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=76855 · 09041a4e
      barraclough@apple.com authored
      Implement a JIT-code aware sampling profiler for JSC
      
      Reviewed by Geoff Garen.
      
      Step 2: generalize RedBlackTree. The profiler is going to want tio use
      a RedBlackTree, allow this class to work with subclasses of
      RedBlackTree::Node, Node should not need to know the names of the m_key
      and m_value fields (the subclass can provide a key() accessor), and
      RedBlackTree does not need to know anything about ValueType.
      
      * JavaScriptCore.exp:
      * wtf/MetaAllocator.cpp:
      (WTF::MetaAllocator::findAndRemoveFreeSpace):
      (WTF::MetaAllocator::debugFreeSpaceSize):
      (WTF::MetaAllocator::addFreeSpace):
      * wtf/MetaAllocator.h:
      (WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
      (WTF::MetaAllocator::FreeSpaceNode::key):
      * wtf/MetaAllocatorHandle.h:
      (WTF::MetaAllocatorHandle::key):
      * wtf/RedBlackTree.h:
      (WTF::RedBlackTree::Node::successor):
      (WTF::RedBlackTree::Node::predecessor):
      (WTF::RedBlackTree::Node::parent):
      (WTF::RedBlackTree::Node::setParent):
      (WTF::RedBlackTree::Node::left):
      (WTF::RedBlackTree::Node::setLeft):
      (WTF::RedBlackTree::Node::right):
      (WTF::RedBlackTree::Node::setRight):
      (WTF::RedBlackTree::insert):
      (WTF::RedBlackTree::remove):
      (WTF::RedBlackTree::findExact):
      (WTF::RedBlackTree::findLeastGreaterThanOrEqual):
      (WTF::RedBlackTree::findGreatestLessThanOrEqual):
      (WTF::RedBlackTree::first):
      (WTF::RedBlackTree::last):
      (WTF::RedBlackTree::size):
      (WTF::RedBlackTree::treeMinimum):
      (WTF::RedBlackTree::treeMaximum):
      (WTF::RedBlackTree::treeInsert):
      (WTF::RedBlackTree::leftRotate):
      (WTF::RedBlackTree::rightRotate):
      (WTF::RedBlackTree::removeFixup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09041a4e
    • kling@webkit.org's avatar
      Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642. · 79f1c352
      kling@webkit.org authored
      * css/CSSMutableStyleDeclaration.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f1c352
    • rniwa@webkit.org's avatar
      run-perf-tests ignore Skipped list on chromium · 81d631ba
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76764
      
      Reviewed by Dirk Pranke.
      
      Move skipped_perf_tests from WebKit port to Base port so that Chromium port
      can also find skipped list. Chromium port only uses test_expectations.txt for
      layout tests but performacne tests don't use test_expectations.txt so Chromium port
      also needs to use Skipped list.
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port._tests_from_skipped_file_contents):
      (Port):
      (Port._expectations_from_skipped_files):
      (Port.skipped_perf_tests):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_skipped_perf_tests):
      (PortTest.test_skipped_perf_tests.add_text_file):
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      (WebKitPort._skipped_tests_for_unsupported_features):
      (WebKitPort._skipped_file_search_paths):
      (WebKitPort.skipped_layout_tests):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d631ba
    • commit-queue@webkit.org's avatar
      Update uniteIfNonZero to use isZero. · 3d93ef60
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76637
      
      Patch by Philip Rogers <pdr@google.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      No new tests. (I found no existing codepath that would be affected by
      this change but I think this change is still valuable in preventing
      future bugs.)
      
      * platform/graphics/FloatRect.cpp:
      (WebCore::FloatRect::uniteIfNonZero):
      
      The following change is a minor followup to
      https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
      related to the rest of this patch.
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d93ef60
    • antti@apple.com's avatar
      Eliminate CSSElementStyleDeclaration · 241a650f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76848
      
      Reviewed by Andreas Kling.
      
      CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.
              
      Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
      shrinks all inline style declarations by one pointer.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMBinding.h:
      (WebCore::root):
      * css/CSSAllInOne.cpp:
      * css/CSSElementStyleDeclaration.cpp: Removed.
      * css/CSSElementStyleDeclaration.h: Removed.
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::createInline):
      (WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
      (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
      * css/CSSStyleDeclaration.cpp:
      (WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
      (WebCore::CSSStyleDeclaration::parentStyleSheet):
              
          Merge the CSSElementStyleDeclaration::styleSheet() logic here.
              
      * css/CSSStyleDeclaration.h:
      (WebCore::CSSStyleDeclaration::parentRule):
      (WebCore::CSSStyleDeclaration::clearParentRule):
      (WebCore::CSSStyleDeclaration::parentElement):
      (WebCore::CSSStyleDeclaration::clearParentElement):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
              
          CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
          This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).
              
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::createInlineStyleDecl):
      (WebCore::StyledElement::destroyInlineStyleDecl):
      (WebCore::StyledElement::ensureInlineStyleDecl):
      (WebCore::StyledElement::copyNonAttributeProperties):
      * dom/StyledElement.h:
      (WebCore::StyledElement::inlineStyleDecl):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::createDeletionUI):
      * html/ValidationMessage.cpp:
      (WebCore::adjustBubblePosition):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlPanelElement::makeOpaque):
      (WebCore::MediaControlPanelElement::makeTransparent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::TrackLimiterElement::create):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      241a650f
    • senorblanco@chromium.org's avatar
      2436e67e