1. 20 Aug, 2013 19 commits
    • dbates@webkit.org's avatar
      <https://webkit.org/b/120032> Add DRT test to ensure that AccessibilityObject::stringValue() · cc030563
      dbates@webkit.org authored
      of <input type="file"> is meaningful
      
      Reviewed by Chris Fleizach.
      
      Adds a DRT test to ensure that AccessibilityObject::stringValue() returns a meaningful string
      for a single file- and multiple files-file upload control.
      
      * accessibility/file-upload-button-stringvalue.html: Added.
      * platform/mac-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      * platform/mac/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc030563
    • jberlin@webkit.org's avatar
      Remove a string no longer used after r154251. · cbe678d0
      jberlin@webkit.org authored
      Rubber-stamped by Brady Eidson.
      
      * English.lproj/Localizable.strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbe678d0
    • commit-queue@webkit.org's avatar
      [BlackBerry] Avoid an assertion from calling releaseBufferDrawable(nullptr) · 227c97ef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119862
      JIRA 470760
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-08-20
      Reviewed by Antonio Gomes.
      
      destroyBuffer() finds a null pointer valid but
      releaseBufferDrawable() does not. Fix by adding a
      null pointer check.
      
      No new tests, caught by existing layout test runs.
      
      * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
      (WebCore::ImageBuffer::~ImageBuffer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      227c97ef
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119487> [Gtk] Cancel authentication on load failed · 7a65b1a4
      commit-queue@webkit.org authored
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Added callback to handle load-failed event in default authentication dialog.
      Authentication request gets cancelled and the dialog widget gets destroyed.
      
      * UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
      (pageLoadFailed):
      (webkitAuthenticationDialogInitialize):
      (webkitAuthenticationDialogDispose):
      (webkit_authentication_dialog_class_init):
      (webkitAuthenticationDialogNew):
      * UIProcess/API/gtk/WebKitAuthenticationDialog.h:
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewAuthenticate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a65b1a4
    • kov@webkit.org's avatar
      <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings · 39952866
      kov@webkit.org authored
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      No new tests, these are just stubs for the DOM bindings API.
      
      * bindings/gobject/WebKitDOMCustom.cpp:
      (webkit_dom_bar_info_get_property):
      (webkit_dom_bar_info_class_init):
      (webkit_dom_bar_info_init):
      (webkit_dom_bar_info_get_visible):
      (webkit_dom_console_get_memory):
      (webkit_dom_css_style_declaration_get_property_css_value):
      (webkit_dom_document_get_webkit_hidden):
      (webkit_dom_document_get_webkit_visibility_state):
      (webkit_dom_html_document_open):
      (webkit_dom_html_element_set_item_id):
      (webkit_dom_html_element_get_item_id):
      (webkit_dom_html_element_get_item_ref):
      (webkit_dom_html_element_get_item_prop):
      (webkit_dom_html_element_set_item_scope):
      (webkit_dom_html_element_get_item_scope):
      (webkit_dom_html_element_get_item_type):
      (webkit_dom_html_properties_collection_get_property):
      (webkit_dom_html_properties_collection_class_init):
      (webkit_dom_html_properties_collection_init):
      (webkit_dom_html_properties_collection_item):
      (webkit_dom_html_properties_collection_named_item):
      (webkit_dom_html_properties_collection_get_length):
      (webkit_dom_html_properties_collection_get_names):
      (webkit_dom_node_get_attributes):
      (webkit_dom_node_has_attributes):
      (webkit_dom_memory_info_get_property):
      (webkit_dom_memory_info_class_init):
      (webkit_dom_memory_info_init):
      (webkit_dom_memory_info_get_total_js_heap_size):
      (webkit_dom_memory_info_get_used_js_heap_size):
      (webkit_dom_memory_info_get_js_heap_size_limit):
      (webkit_dom_micro_data_item_value_class_init):
      (webkit_dom_micro_data_item_value_init):
      (webkit_dom_performance_get_memory):
      (webkit_dom_property_node_list_get_property):
      (webkit_dom_property_node_list_class_init):
      (webkit_dom_property_node_list_init):
      (webkit_dom_property_node_list_item):
      (webkit_dom_property_node_list_get_length):
      * bindings/gobject/WebKitDOMCustom.h:
      
      Tools:
      
      * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
      from naming/enum_casing rules, since it needs to provide GObject-style APIs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39952866
    • antti@apple.com's avatar
      <https://webkit.org/b/120017> Remove NodeRenderingTraversal::ParentDetails · b4267a36
      antti@apple.com authored
      Reviewed by Andreas Kling.
      
      Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
              
      Also removed support for reset-style-inheritance attribute in InsertionPoint. We don't use or expose it.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::State::initForStyleResolve):
      (WebCore::StyleResolver::styleForElement):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::State::State):
      (WebCore::StyleResolver::State::elementLinkState):
              
          Remove m_distributedToInsertionPoint State field. We never hit the cases where it was used.
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
      (WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
              
          Return null instead of setting childWasOutOfComposition to details object. That's what would happen anyway in the caller.
      
      (WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
      * dom/ComposedShadowTreeWalker.h:
      * dom/Node.cpp:
      (WebCore::Node::insertionParentForBinding):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
              
          Make this look up InsertionPoint directly intead of relying it being populated in m_parentDetails. The function is used only in
          a few non-performance critical places.
      
      (WebCore::NodeRenderingContext::resetStyleInheritance):
              
          Return parent ShadowRoots resetStyleInheritance() flag instead of using m_parentDetails.
      
      * dom/NodeRenderingContext.h:
      * dom/NodeRenderingTraversal.cpp:
      (WebCore::NodeRenderingTraversal::parentSlow):
      * dom/NodeRenderingTraversal.h:
      (WebCore::NodeRenderingTraversal::parent):
              
          Remove ParentDetails.
      
      * html/HTMLAttributeNames.in:
      * html/shadow/InsertionPoint.cpp:
              
          Remove unused resetStyleInheritance attribute.
      
      (WebCore::InsertionPoint::removedFrom):
      (WebCore::findInsertionPointOf):
              
          Renamed for clarity.
      
      * html/shadow/InsertionPoint.h:
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4267a36
    • antti@apple.com's avatar
      <https://webkit.org/b/120025> REGRESSION (r154254):... · 927b66db
      antti@apple.com authored
      <https://webkit.org/b/120025> REGRESSION (r154254): fast/frames/frameset-frameborder-inheritance.html failing on Apple MountainLion Debug WK1 (Tests)
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::isFrameSet):
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::didAttachRenderers):
              
          Make helper public in HTMLFrameSetElement.
      
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::findContaining):
              
          Static function for finding containing frameset, if any.
      
      (WebCore::HTMLFrameSetElement::willAttachRenderers):
              
          This broke in refactoring. We should exit the loop when the first containing frameset is found. Fix by refactoring more.
      
      * html/HTMLFrameSetElement.h:
      (WebCore::isHTMLFrameSetElement):
      (WebCore::toHTMLFrameSetElement):
              
          Add casting functions.
      
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::frameSet):
      
      LayoutTests: 
      
      * platform/mac/TestExpectations: Unskip.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      927b66db
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120056> [GTK][ARM] enable DFG_JIT · 6a0bf880
      commit-queue@webkit.org authored
      Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Enable DFG_JIT in GTK+ platform for ARM/Thumb architecture
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a0bf880
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120062> Missing ensureSpace call in sh4 baseline JIT. · 97f763a0
      commit-queue@webkit.org authored
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-20
      Reviewed by Allan Sandfeld Jensen.
      
      branchPtrWithPatch() of baseline JIT must ensure that space is available for its
      instructions and two constants now DFG is enabled for sh4 architecture.
      These missing ensureSpace calls lead to random crashes.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::branchPtrWithPatch):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97f763a0
    • antti@apple.com's avatar
      <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and... · 3ae23fe9
      antti@apple.com authored
      <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
      
      Source/WebCore: 
      
      Reviewed by Andreas Kling.
      
      * xml/XMLErrors.cpp:
      (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.
      
      LayoutTests: 
      
      Reviewed by by Andreas Kling.
      
      * TestExpectations: Unskip.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ae23fe9
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser · 71c09a7b
      commit-queue@webkit.org authored
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Added stop button in MiniBrowser
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (reloadOrStopCallback): Callback to handle stop or reload button click.
      (webViewLoadProgressChanged): Update reload or stop button icon.
      (browser_window_init): Save button pointer for further icon updates.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71c09a7b
    • allan.jensen@digia.com's avatar
      [Qt][WK2] Doesn't build without Plugin-process · 4ad11389
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120060
      
      Reviewed by Jocelyn Turcotte.
      
      Disable netscape plugin api in WebKit2 when the plugin architecture is unsupported for WebKit2.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad11389
    • antti@apple.com's avatar
      <https://webkit.org/b/119969> REGRESSION (r154232): Crash on the japantimes.co.jp · 3cf260a2
      antti@apple.com authored
      Source/WebCore: 
      
      Reviewed by Andreas Kling.
              
      PseudoElement no longer has parent and calling Element::insertedInto for them crashes as it tries to access it.
      
      Normally there are no pseudo elements when Element::insertedInto() is invoked as they get detached and attached
      along with rendering. However in this case the page inserts a <style> that uses ::before along with an element
      that it applies to. Stylesheet insertion triggers synchronous style recalc that attaches rendering to all newly
      insered elements. Later Element::insertedInto gets called for the element that has pseudo element and we crash.
      
      Test: fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html
      
      * dom/Element.cpp:
      (WebCore::Element::insertedInto):
      (WebCore::Element::removedFrom):
              
          Remove calls to insertedInto/removedFrom for pseudo elements. They are not considered to be in document.
          When they are added normally during render tree attach these calls don't happen either.
      
      LayoutTests: 
      
      Reviewed by Andreas Kling.
      
      * fast/css-generated-content/insert-stylesheet-and-pseudo-crash-expected.txt: Added.
      * fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf260a2
    • simon.pena@samsung.com's avatar
      Added missing Reviewed By line. · d0e29b01
      simon.pena@samsung.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e29b01
    • simon.pena@samsung.com's avatar
      <https://webkit.org/b/117584> [GTK][WK1]... · 6ee4f8a3
      simon.pena@samsung.com authored
      <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
      
      Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
      printing didFailLoadWithError.
      
      Tools:
      
      Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
      DumpRenderTree, printing didFailLoadWithError.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webFrameLoadStatusNotified):
      
      LayoutTests:
      
      Adding that print makes
      http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
      and
      http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html,
      although it requires to modify the expected results for
      http/tests/loading/pdf-commit-load-callbacks.html.
      
      * platform/gtk-wk1/TestExpectations: Unskip
      http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
      and
      http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
      * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt:
      Update the expected results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ee4f8a3
    • rniwa@webkit.org's avatar
      Windows build fix after r154314. · 8ceaac2f
      rniwa@webkit.org authored
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::platformAddPathForRoundedRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ceaac2f
    • commit-queue@webkit.org's avatar
      [Cairo] Canvas putImageData is not working as expected · dc967a9c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119992
      
      Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-08-19
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      ImageBufferCairo::putImageArray didn't perform pre-multiply in case of zero alpha value.
      If the alpha value is not 255, image data should always be pre-multiplied.
      
      Test: fast/canvas/canvas-putImageData-zero-alpha.html
      
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      (WebCore::ImageBuffer::putByteArray):
      
      LayoutTests:
      
      Add a ref test that ensures that putImageData of canvas with zero alpha work correctly.
      
      * fast/canvas/canvas-putImageData-zero-alpha-expected.html: Added.
      * fast/canvas/canvas-putImageData-zero-alpha.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc967a9c
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119991> change usage of... · 11174a2c
      commit-queue@webkit.org authored
      <https://webkit.org/b/119991> change usage of calculateUTCOffset()/calculateDSTOffset  to calculateLocalTimeOffset
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-19
      Reviewed by Darin Adler.
      
      Resolving code error.
      
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
      * html/MonthInputType.cpp:
      (WebCore::MonthInputType::defaultValueForStepUp):
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::defaultValueForStepUp):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11174a2c
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120049> Delete code for Snow Leopard · 3feac41c
      rniwa@webkit.org authored
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Delete all the code for Mac OS 10.6. Nobody builds on Snow Leopard at this point.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * platform/LocalizedStrings.cpp:
      (WebCore::truncatedStringForLookupMenuItem):
      (WebCore::contextMenuItemTagSearchWeb):
      (WebCore::contextMenuItemTagLookUpInDictionary):
      * platform/MemoryPressureHandler.cpp:
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::acceleratesDrawing):
      (PlatformCALayer::setAcceleratesDrawing):
      (PlatformCALayer::contentsScale):
      (PlatformCALayer::setContentsScale):
      (PlatformCALayer::synchronouslyDisplayTilesInRect):
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::setScale):
      (WebCore::TileController::setAcceleratesDrawing):
      (WebCore::TileController::createTileLayer):
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData):
      (WebCore::ImageBufferData::putData):
      * platform/graphics/cg/ImageBufferDataCG.h:
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::platformAddPathForRoundedRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::FontPlatformData):
      (WebCore::FontPlatformData::setFont):
      * platform/graphics/mac/FontMac.mm:
      (WebCore::showGlyphsWithAdvances):
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::GraphicsContext::drawLineForDocumentMarker):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::layerHostChanged):
      * platform/graphics/mac/WebLayer.mm:
      (drawLayerContents):
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/EmptyProtocolDefinitions.h: Removed.
      * platform/mac/MemoryPressureHandlerMac.mm:
      (WebCore::MemoryPressureHandler::releaseMemory):
      * platform/mac/NSScrollerImpDetails.h:
      * platform/mac/PlatformEventFactoryMac.mm:
      (WebCore::momentumPhaseForEvent):
      (WebCore::phaseForEvent):
      * platform/mac/ScrollAnimatorMac.mm:
      * platform/mac/SharedTimerMac.mm:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::doUpdateResourceRequest):
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      * platform/text/cf/HyphenationCF.cpp:
      * platform/text/mac/HyphenationMac.mm: Removed.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::containsPaintedContent):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
      
      Source/WebKit/mac:
      
      * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
      (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
      (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
      * Misc/WebNSControlExtras.m:
      (-[NSControl sizeToFitAndAdjustWindowHeight]):
      * Misc/WebNSFileManagerExtras.mm:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
      (WebEditorClient::getGuessesForWord):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidLayout):
      (WebFrameLoaderClient::provisionalLoadStarted):
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      * WebKitPrefix.h:
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView scrollWheel:]):
      * WebView/WebFullScreenController.mm:
      (convertRectToScreen):
      (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
      (-[WebFullScreenController exitFullScreen]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
      (-[WebHTMLView removeMouseMovedObserver]):
      (-[WebHTMLView windowDidBecomeKey:]):
      (-[WebHTMLView windowDidResignKey:]):
      * WebView/WebView.mm:
      (-[WebView _deviceScaleFactor]):
      
      Source/WebKit2:
      
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::overrideSystemProxies):
      (WebKit::NetworkProcess::platformInitializeNetworkProcess):
      * WebKit2Prefix.h:
      
      Source/WTF:
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
      * wtf/FeatureDefines.h:
      * wtf/Platform.h:
      
      Tools:
      
      * DumpRenderTree/mac/CheckedMalloc.cpp:
      (protectionOfRegion):
      (makeLargeMallocFailSilently):
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
      (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
      * DumpRenderTree/mac/FrameLoadDelegate.mm:
      (testPathFromURL):
      (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
      * DumpRenderTree/mac/LayoutTestHelper.m:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
      (WTR::InjectedBundle::platformInitialize):
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
      (WTR::testPathFromURL):
      (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3feac41c
  2. 19 Aug, 2013 21 commits
    • barraclough@apple.com's avatar
      Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=120034 · 04551430
      barraclough@apple.com authored
      Remove custom getOwnPropertyDescriptor for global objects
      
      Reviewed by Geoff Garen.
      
      Fix attributes of JSC SynbolTableObject entries, ensure that cross frame access is safe, and suppress prototype chain walk.
      
      * runtime/JSGlobalObject.cpp:
          - Remove custom getOwnPropertyDescriptor implementation.
      * runtime/JSSymbolTableObject.h:
      (JSC::symbolTableGet):
          - The symbol table does not store the DontDelete attribute, we should be adding it back in.
      * runtime/PropertyDescriptor.h:
          - JSDOMWindow walks the prototype chain on own access. This is bad, but for now workaround for the getOwnPropertyDescriptor case.
      * runtime/PropertySlot.h:
      (JSC::PropertySlot::setUndefined):
          - This is used by WebCore when blocking access to properties on cross-frame access.
            Mark blocked properties as read-only, non-configurable to prevent defineProperty.
      
      Source/WebCore: <https://webkit.org/b/120041> Remove superfluous min calls in RenderBlock::computeOverflow
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2013-08-19
      Reviewed by Simon Fraser.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/29cad35d6b4642804e6b7c1a30f0b4435dd7a71d
      
      They are contained in an "if" statement that ensures that textIndent < 0 and so the min will never be 0.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeOverflow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04551430
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120051> Remove the Mail thread workaround · 70b7f396
      rniwa@webkit.org authored
      Reviewed by Sam Weinig.
      
      Remove the workaround for a very old version of Mail added in r39455.
      
      * WebView/WebArchive.mm:
      (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
      (-[WebArchive mainResource]):
      (-[WebArchive subresources]):
      (-[WebArchive subframeArchives]):
      * WebView/WebFrameView.mm:
      (-[WebFrameView initWithFrame:]):
      * WebView/WebResource.mm:
      (-[WebResource data]):
      (-[WebResource URL]):
      (-[WebResource MIMEType]):
      (-[WebResource textEncodingName]):
      (-[WebResource frameName]):
      (-[WebResource _ignoreWhenUnarchiving]):
      (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
      (-[WebResource _suggestedFilename]):
      (-[WebResource _response]):
      (-[WebResource _stringValue]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b7f396
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120041> Remove superfluous min calls in RenderBlock::computeOverflow · c23cc2ca
      rniwa@webkit.org authored
      Reviewed by Simon Fraser.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/29cad35d6b4642804e6b7c1a30f0b4435dd7a71d
      
      They are contained in an "if" statement that ensures that textIndent < 0 and so the min will never be 0.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeOverflow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c23cc2ca
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/118106> Web Inspector: AX: Add additional contextual... · ab23ed90
      commit-queue@webkit.org authored
      <https://webkit.org/b/118106> Web Inspector: AX: Add additional contextual labels for Error/Warnings/Logs that will be spoken for screen readers
      
      Patch by James Craig <james@cookiecrook.com> on 2013-08-19
      Reviewed by Joseph Pecoraro.
      
      Changed general console "Output" string to more specific "Error", "Warning", etc for accessibility.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ConsoleCommandResult.js:
      * UserInterface/ConsoleMessageImpl.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab23ed90
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/118754> AX: aria-required.html needs to test @required... · 8c545d5d
      commit-queue@webkit.org authored
      <https://webkit.org/b/118754> AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation
      
      Patch by James Craig <james@cookiecrook.com> on 2013-08-19
      Reviewed by Chris Fleizach.
      
      More thorough testing of @required and @aria-required, especially regarding conflict resolution.
      Found https://webkit.org/b/119988 as a result of the updated test.
      
      * accessibility/aria-required-expected.txt:
      * accessibility/aria-required.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c545d5d
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/119930> input[type=range]: Fix a crash by changing input... · fe7996e7
      rniwa@webkit.org authored
      <https://webkit.org/b/119930> input[type=range]: Fix a crash by changing input type in 'input' event handler
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Merge https://chromium.googlesource.com/chromium/blink/+/99afc9b55ce176b4f5fe053070e19dbebc1891a5
      
      In SliderThumbElement::setPositionFromPoint, renderer() can be NULL after HTMLInputElement::setValueFromRenderer,
      which dispatches 'input' event. Also, make a local vairable 'input' a RefPtr just in case.
      
      Also add null-poinetr checks for the host element as SliderThumbElement only weakly holds onto the host element.
      
      Test: fast/forms/range/range-type-change-oninput.html
      
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::matchesReadOnlyPseudoClass):
      (WebCore::SliderThumbElement::matchesReadWritePseudoClass):
      (WebCore::SliderThumbElement::setPositionFromPoint):
      (WebCore::SliderThumbElement::hostInput):
      
      LayoutTests:
      
      Add a regresion test from https://chromium.googlesource.com/chromium/blink/+/99afc9b55ce176b4f5fe053070e19dbebc1891a5
      
      * fast/forms/range/range-type-change-oninput-expected.txt: Added.
      * fast/forms/range/range-type-change-oninput.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe7996e7
    • joepeck@webkit.org's avatar
      <https://webkit.org/b/120036> [iOS] Upstream Source/WTF Xcode project for iOS · 9724566b
      joepeck@webkit.org authored
      Reviewed by David Kilzer.
      
      Include iOS only WebCoreThread.* files in an ios group, and clean up
      the included files a bit.
      
      * WTF.xcodeproj/project.pbxproj:
      * wtf/ios/WebCoreThread.cpp:
      * wtf/ios/WebCoreThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9724566b
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120028 · 4d286a95
      ap@apple.com authored
      ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
      when navigating to an uncached subframe
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      Test: http/tests/navigation/post-frames-goback1-uncached.html
      
      * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame):
      Set m_requestedHistoryItem in a code path that doesn't go through FrameLoader::loadItem.
      
      * loader/HistoryController.cpp: (WebCore::HistoryController::restoreDocumentState):
      Now that we always set m_requestedHistoryItem, there is no need to traverse frame
      tree to see if this document is being loaded as part of b/f navigation (which was
      add in bug 90870).
      
      LayoutTests:
      
      Added a nearly identical version of http/tests/navigation/post-frames-goback1.html
      that checks what happens when navigating back to an uncached main resource.
      
      * http/tests/navigation/post-frames-goback1-uncached-expected.txt: Added.
      * http/tests/navigation/post-frames-goback1-uncached.html: Copied from LayoutTests/http/tests/navigation/post-frames-goback1.html.
      * http/tests/navigation/resources/form-target-uncached.pl: Copied from LayoutTests/http/tests/navigation/resources/form-target.pl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d286a95
    • fpizlo@apple.com's avatar
      DFG should inline typedArray.byteOffset · 537a477d
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119962
      
      Source/JavaScriptCore: 
      
      Reviewed by Oliver Hunt.
              
      This adds a new node, GetTypedArrayByteOffset, which inlines
      typedArray.byteOffset.
              
      Also, I improved a bunch of the clobbering logic related to typed arrays
      and clobbering in general. For example, PutByOffset/PutStructure are not
      clobber-world so they can be handled by most default cases in CSE. Also,
      It's better to use the 'Class_field' notation for typed arrays now that
      they no longer involve magical descriptor thingies.
      
      * bytecode/SpeculatedType.h:
      * dfg/DFGAbstractHeap.h:
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      * dfg/DFGArrayMode.h:
      (JSC::DFG::neverNeedsStorage):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::getByValLoadElimination):
      (JSC::DFG::CSEPhase::getByOffsetLoadElimination):
      (JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::checkArrayElimination):
      (JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::getTypedArrayByteOffsetLoadElimination):
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGClobberize.h:
      (JSC::DFG::clobberize):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      (JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteLength):
      (JSC::DFG::FixupPhase::convertToGetArrayLength):
      (JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteOffset):
      * dfg/DFGNodeType.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSafeToExecute.h:
      (JSC::DFG::safeToExecute):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
      * dfg/DFGSpeculativeJIT.h:
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGTypeCheckHoistingPhase.cpp:
      (JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
      * runtime/ArrayBuffer.h:
      (JSC::ArrayBuffer::offsetOfData):
      * runtime/Butterfly.h:
      (JSC::Butterfly::offsetOfArrayBuffer):
      * runtime/IndexingHeader.h:
      (JSC::IndexingHeader::offsetOfArrayBuffer):
      
      LayoutTests: 
      
      Reviewed by Oliver Hunt.
      
      * fast/js/dfg-byteOffset-neuter.html: Added.
      * fast/js/dfg-byteOffset-neuter-expected.txt: Added.
      * fast/js/regress/ArrayBuffer-Int32Array-byteOffset-expected.txt: Added.
      * fast/js/regress/ArrayBuffer-Int32Array-byteOffset.html: Added.
      * fast/js/regress/script-tests/ArrayBuffer-Int32Array-byteOffset.js: Added.
      * fast/js/script-tests/dfg-byteOffset-neuter.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      537a477d
    • fpizlo@apple.com's avatar
      <https://webkit.org/b/119994> DFG new Array() inlining could get confused about global objects · ee834de5
      fpizlo@apple.com authored
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
      
      LayoutTests: 
      
      * fast/js/dfg-cross-global-object-new-array.html: Added.
      * fast/js/dfg-cross-global-object-new-array-expected.txt: Added.
      * fast/js/script-tests/dfg-cross-global-object-new-array.js: Added.
      (foo):
      (runTest):
      (doit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee834de5
    • msaboff@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119995 · 7b0e24be
      msaboff@apple.com authored
      Start removing custom implementations of getOwnPropertyDescriptor
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2013-08-18
      Reviewed by Oliver Hunt.
      
      This can now typically implemented in terms of getOwnPropertySlot.
      Add a macro to PropertyDescriptor to define an implementation of GOPD in terms of GOPS.
      Switch over most classes in JSC & the WebCore bindings generator to use this.
      
      * API/JSCallbackObjectFunctions.h:
      * debugger/DebuggerActivation.cpp:
      * runtime/Arguments.cpp:
      * runtime/ArrayConstructor.cpp:
      * runtime/ArrayPrototype.cpp:
      * runtime/BooleanPrototype.cpp:
      * runtime/DateConstructor.cpp:
      * runtime/DatePrototype.cpp:
      * runtime/ErrorPrototype.cpp:
      * runtime/JSActivation.cpp:
      * runtime/JSArray.cpp:
      * runtime/JSArrayBuffer.cpp:
      * runtime/JSArrayBufferView.cpp:
      * runtime/JSCell.cpp:
      * runtime/JSDataView.cpp:
      * runtime/JSDataViewPrototype.cpp:
      * runtime/JSFunction.cpp:
      * runtime/JSGenericTypedArrayViewInlines.h:
      * runtime/JSNotAnObject.cpp:
      * runtime/JSONObject.cpp:
      * runtime/JSObject.cpp:
      * runtime/NamePrototype.cpp:
      * runtime/NumberConstructor.cpp:
      * runtime/NumberPrototype.cpp:
      * runtime/ObjectConstructor.cpp:
          - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
      * runtime/PropertyDescriptor.h:
          - Added GET_OWN_PROPERTY_DESCRIPTOR_IMPL macro.
      * runtime/PropertySlot.h:
      (JSC::PropertySlot::isValue):
      (JSC::PropertySlot::isGetter):
      (JSC::PropertySlot::isCustom):
      (JSC::PropertySlot::isCacheableValue):
      (JSC::PropertySlot::isCacheableGetter):
      (JSC::PropertySlot::isCacheableCustom):
      (JSC::PropertySlot::attributes):
      (JSC::PropertySlot::getterSetter):
          - Add accessors necessary to convert PropertySlot to descriptor.
      * runtime/RegExpConstructor.cpp:
      * runtime/RegExpMatchesArray.cpp:
      * runtime/RegExpMatchesArray.h:
      * runtime/RegExpObject.cpp:
      * runtime/RegExpPrototype.cpp:
      * runtime/StringConstructor.cpp:
      * runtime/StringObject.cpp:
          - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b0e24be
    • bdakin@apple.com's avatar
      <https://webkit.org/b/120027> AXObjectCache's · ebcac2bd
      bdakin@apple.com authored
      accessibilityEnhancedUserInterfaceEnabled should be initialized on process 
      creation
      
      Reviewed by Sam Weinig.
      
      Right now we only call AXObjectCache::setEnhancedAccessibility() when AppKit sends 
      us a notification indicating that the value has changed. We should not have to 
      rely on that to properly initialize this value. It should be done with the 
      WebProcessCreationParamters. 
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::platformInitializeWebProcess):
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::platformInitializeWebProcess):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebcac2bd
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119915 · 3503443f
      ap@apple.com authored
      REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
      
      Reviewed by Darin Adler.
      
      Tools:
      
      The issue was that we ended up having no CFNetwork cache in the testing session due
      to an incorrect cache model. There is a number of things not implemented when it
      comes to dynamically changing cache model as attempted by WebKitTestRunner, but
      the easiest way to get this going is to initialize it to correct value upfront.
      
      * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
      
      LayoutTests:
      
      * platform/mac-wk2/TestExpectations: Unskipping the failing test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3503443f
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119995 · 47d7ba89
      barraclough@apple.com authored
      Start removing custom implementations of getOwnPropertyDescriptor
      
      Reviewed by Sam Weinig.
      
      This can now typically implemented in terms of getOwnPropertySlot.
      Add a macro to PropertyDescriptor to define an implementation of GOPD in terms of GOPS.
      Switch over most classes in JSC & the WebCore bindings generator to use this.
      
      Source/JavaScriptCore: 
      
      * API/JSCallbackObjectFunctions.h:
      * debugger/DebuggerActivation.cpp:
      * runtime/Arguments.cpp:
      * runtime/ArrayConstructor.cpp:
      * runtime/ArrayPrototype.cpp:
      * runtime/BooleanPrototype.cpp:
      * runtime/DateConstructor.cpp:
      * runtime/DatePrototype.cpp:
      * runtime/ErrorPrototype.cpp:
      * runtime/JSActivation.cpp:
      * runtime/JSArray.cpp:
      * runtime/JSArrayBuffer.cpp:
      * runtime/JSArrayBufferView.cpp:
      * runtime/JSCell.cpp:
      * runtime/JSDataView.cpp:
      * runtime/JSDataViewPrototype.cpp:
      * runtime/JSFunction.cpp:
      * runtime/JSGenericTypedArrayViewInlines.h:
      * runtime/JSNotAnObject.cpp:
      * runtime/JSONObject.cpp:
      * runtime/JSObject.cpp:
      * runtime/NamePrototype.cpp:
      * runtime/NumberConstructor.cpp:
      * runtime/NumberPrototype.cpp:
      * runtime/ObjectConstructor.cpp:
          - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
      * runtime/PropertyDescriptor.h:
          - Added GET_OWN_PROPERTY_DESCRIPTOR_IMPL macro.
      * runtime/PropertySlot.h:
      (JSC::PropertySlot::isValue):
      (JSC::PropertySlot::isGetter):
      (JSC::PropertySlot::isCustom):
      (JSC::PropertySlot::isCacheableValue):
      (JSC::PropertySlot::isCacheableGetter):
      (JSC::PropertySlot::isCacheableCustom):
      (JSC::PropertySlot::attributes):
      (JSC::PropertySlot::getterSetter):
          - Add accessors necessary to convert PropertySlot to descriptor.
      * runtime/RegExpConstructor.cpp:
      * runtime/RegExpMatchesArray.cpp:
      * runtime/RegExpMatchesArray.h:
      * runtime/RegExpObject.cpp:
      * runtime/RegExpPrototype.cpp:
      * runtime/StringConstructor.cpp:
      * runtime/StringObject.cpp:
          - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
      
      Source/WebCore: 
      
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      * bindings/js/JSHTMLAppletElementCustom.cpp:
      * bindings/js/JSHTMLEmbedElementCustom.cpp:
      * bindings/js/JSHTMLObjectElementCustom.cpp:
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::JSHistory::getOwnPropertySlotDelegate):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::getOwnPropertySlotDelegate):
      * bindings/js/JSWorkerGlobalScopeCustom.cpp:
          - Remove getOwnPropertyDescriptorDelegate methods,
            Change attributes of cross-frame access properties in JSHistory/JSLocation to prevent properties from being redefined.
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorHelperMethods):
          - Implement getOwnPropertySlot in terms of GET_OWN_PROPERTY_DESCRIPTOR_IMPL.
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
      * bindings/scripts/test/JS/JSTestEventTarget.cpp:
      * bindings/scripts/test/JS/JSTestException.cpp:
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      * bindings/scripts/test/JS/JSTestNode.cpp:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
          - Update test expectations.
      
      LayoutTests: 
      
      * http/tests/security/xss-DENIED-defineProperty-expected.txt:
          - Remove erroneous error messages - cross frame access to reload is allowed - it's just read-only, non-configurable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47d7ba89
    • benjamin@webkit.org's avatar
      <https://webkit.org/b/119936> Fix some encapsulation issues of RuleSet · 26d54a61
      benjamin@webkit.org authored
      Reviewed by Darin Adler.
      
      None of the attributes of RuleSet should be modified directly.
      
      * css/DocumentRuleSets.cpp:
      (WebCore::DocumentRuleSets::initUserStyle):
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
      * css/RuleSet.h:
      (WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
      (WebCore::RuleSet::regionSelectorsAndRuleSets):
      (WebCore::RuleSet::ruleCount):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::checkRegionStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26d54a61
    • msaboff@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120020 Change Set 154207 causes wrong... · cc7a2487
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120020 Change Set 154207 causes wrong register to be used for 32 bit tests
      
      Reviewed by Benjamin Poulain.
      
      Change branshTest32 to only use the byte for 8 bit test on the lower 4 registers.
      Registers 4 through 7 as byte regisers are ah, ch, dh and bh instead of sp, bp, si and di.
      
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86Common::branchTest32):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc7a2487
    • benjamin@webkit.org's avatar
      <https://webkit.org/b/119937> Remove ElementRuleCollector's m_behaviorAtBoundary · 7423158b
      benjamin@webkit.org authored
      Reviewed by Darin Adler.
      
      The value DoesNotCrossBoundary is the default behavior boundary of SelectorChecker,
      and it is never changed by ElementRuleCollector.
      
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRules):
      (WebCore::ElementRuleCollector::ruleMatches):
      * css/ElementRuleCollector.h:
      (WebCore::ElementRuleCollector::ElementRuleCollector):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7423158b
    • benjamin@webkit.org's avatar
      <https://webkit.org/b/119934> Remove a repeated "private:" from ElementRuleCollector · 6c35a046
      benjamin@webkit.org authored
      Reviewed by Darin Adler.
      
      * css/ElementRuleCollector.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c35a046
    • jer.noble@apple.com's avatar
      <https://bugs.webkit.org/show_bug.cgi?id=120025> REGRESSION (r154254):... · a2aec60f
      jer.noble@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=120025> REGRESSION (r154254): fast/frames/frameset-frameborder-inheritance.html failing on Apple MountainLion Debug WK1 (Tests)
      
      Unreviewed gardening. Add failing test to TestExpectations.
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2aec60f
    • joepeck@webkit.org's avatar
      <https://webkit.org/b/119905> [iOS] Upstream Source/WTF · 45ffc95e
      joepeck@webkit.org authored
      Reviewed by Benjamin Poulain.
      
      Upstream iOS WebKit Source/WTF.
      
      * Configurations/Base.xcconfig:
      JavaScriptCore.framework is a public framework.
      
      * wtf/Assertions.h:
      Define an export macro for iOS projects just including <wtf/Assertions.h>.
      
      * wtf/Platform.h:
      * wtf/FeatureDefines.h:
      iOS ENABLE and USE defines.
      
      * wtf/MainThread.h:
      * wtf/mac/MainThreadMac.mm:
      (WTF::initializeApplicationUIThreadIdentifier):
      (WTF::initializeWebThreadIdentifier):
      (WTF::canAccessThreadLocalDataForThread):
      * wtf/WeakPtr.h:
      (WTF::WeakReference::get):
      (WTF::WeakReference::clear):
      Shared WebThread and MainThread access to thread local data.
      
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      Shared WebThread and MainThread identifier tables.
      
      * wtf/ThreadSpecific.h:
      (WTF::::replace):
      Used later on so that WebThread can share the MainThread's thread global data.
      
      * wtf/text/StringStatics.cpp:
      (WTF::AtomicString::init):
      When USE(WEB_THREAD) assert AtomicString::init is initialized on the realMainThread.
      
      * wtf/unicode/CharacterNames.h:
      * wtf/unicode/icu/UnicodeIcu.h:
      (WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic):
      Minor iOS constants and functions used later by WebCore.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45ffc95e
    • antti@apple.com's avatar
      Skip these failing tests pending fix: · 0e92e0df
      antti@apple.com authored
              
      svg/custom/bug78807.svg
      svg/custom/use-invalid-style.svg
      
      * TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e92e0df