- 24 Nov, 2010 27 commits
-
-
commit-queue@webkit.org authored
Unreviewed, rolling out r72499. http://trac.webkit.org/changeset/72499 https://bugs.webkit.org/show_bug.cgi?id=50022 This change is causing crashes on the bots. (Requested by mrobinson on #webkit). * accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): * accessibility/AccessibilityMenuListOption.h: * accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): (optionFromList): (optionFromSelection): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_text_get_text): (getInterfaceMaskFromObject): * platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): 2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r72499. http://trac.webkit.org/changeset/72499 https://bugs.webkit.org/show_bug.cgi?id=50022 This change is causing crashes on the bots. (Requested by mrobinson on #webkit). * tests/testatk.c: (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72673 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
paroga@webkit.org authored
Reviewed by Csaba Osztrogonác. Simplify makeprop.pl https://bugs.webkit.org/show_bug.cgi?id=49925 Don't generate CSSPropertyNamesHash.h. Instead generate CSSPropertyNames directly. * GNUmakefile.am: Removed rule for CSSPropertyNamesHash.h. * css/makeprop.pl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72672 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Qt] Make QtTestBrowser remember the selected user agent https://bugs.webkit.org/show_bug.cgi?id=50021 Set user agent for a new page by using the old page's * QtTestBrowser/mainwindow.cpp: (MainWindow::setPage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72671 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
alex@webkit.org authored
Unreviewed, unskipped and rebaselined mathml/presentation tests after r72413 * platform/gtk/Skipped: * platform/gtk/mathml/presentation/attributes-expected.checksum: * platform/gtk/mathml/presentation/attributes-expected.png: * platform/gtk/mathml/presentation/attributes-expected.txt: * platform/gtk/mathml/presentation/fenced-expected.checksum: * platform/gtk/mathml/presentation/fenced-expected.png: * platform/gtk/mathml/presentation/fenced-expected.txt: * platform/gtk/mathml/presentation/fenced-mi-expected.checksum: * platform/gtk/mathml/presentation/fenced-mi-expected.png: * platform/gtk/mathml/presentation/fenced-mi-expected.txt: * platform/gtk/mathml/presentation/fractions-expected.checksum: * platform/gtk/mathml/presentation/fractions-expected.png: * platform/gtk/mathml/presentation/fractions-expected.txt: * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum: * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt: * platform/gtk/mathml/presentation/mo-expected.checksum: * platform/gtk/mathml/presentation/mo-expected.png: * platform/gtk/mathml/presentation/mo-expected.txt: * platform/gtk/mathml/presentation/over-expected.checksum: * platform/gtk/mathml/presentation/over-expected.png: * platform/gtk/mathml/presentation/over-expected.txt: * platform/gtk/mathml/presentation/roots-expected.checksum: * platform/gtk/mathml/presentation/roots-expected.png: * platform/gtk/mathml/presentation/roots-expected.txt: * platform/gtk/mathml/presentation/row-alignment-expected.checksum: * platform/gtk/mathml/presentation/row-alignment-expected.png: * platform/gtk/mathml/presentation/row-alignment-expected.txt: * platform/gtk/mathml/presentation/row-expected.checksum: * platform/gtk/mathml/presentation/row-expected.png: * platform/gtk/mathml/presentation/row-expected.txt: * platform/gtk/mathml/presentation/style-expected.checksum: * platform/gtk/mathml/presentation/style-expected.png: * platform/gtk/mathml/presentation/style-expected.txt: * platform/gtk/mathml/presentation/sub-expected.checksum: * platform/gtk/mathml/presentation/sub-expected.png: * platform/gtk/mathml/presentation/sub-expected.txt: * platform/gtk/mathml/presentation/subsup-expected.checksum: * platform/gtk/mathml/presentation/subsup-expected.png: * platform/gtk/mathml/presentation/subsup-expected.txt: * platform/gtk/mathml/presentation/sup-expected.checksum: * platform/gtk/mathml/presentation/sup-expected.png: * platform/gtk/mathml/presentation/sup-expected.txt: * platform/gtk/mathml/presentation/tables-expected.checksum: * platform/gtk/mathml/presentation/tables-expected.png: * platform/gtk/mathml/presentation/tables-expected.txt: * platform/gtk/mathml/presentation/tokenElements-expected.checksum: * platform/gtk/mathml/presentation/tokenElements-expected.png: * platform/gtk/mathml/presentation/tokenElements-expected.txt: * platform/gtk/mathml/presentation/under-expected.checksum: * platform/gtk/mathml/presentation/under-expected.png: * platform/gtk/mathml/presentation/under-expected.txt: * platform/gtk/mathml/presentation/underover-expected.checksum: * platform/gtk/mathml/presentation/underover-expected.png: * platform/gtk/mathml/presentation/underover-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72670 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
paroga@webkit.org authored
Reviewed by Csaba Osztrogonác. Remove Bakefile build system files https://bugs.webkit.org/show_bug.cgi?id=49983 r53757 only removed the content, but not the files. This patch removes that empty files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72669 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
reni@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=49919 Reviewed by Andreas Kling. Add ASSERT_NOT_REACHED() if the given WebCore type doesn't have an equivalent type in Qt. Also change the return value of toQtLineJoin() from Qt::MiterJoin to the default Qt::SvgMiterJoin, because the previous one doesn't work currently. No new test is needed. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::toQtFillRule): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Csaba Osztrogonác. Simplify makevalues.pl https://bugs.webkit.org/show_bug.cgi?id=49926 Don't generate CSSValueKeywordsHash.h. Instead generate CSSValueKeywords.cpp directly. * GNUmakefile.am: Removed rule for CSSValueKeywordsHash.h. * css/makevalues.pl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72667 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
abecsi@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Make WebKit2 compile with !ENABLE(INSPECTOR). https://bugs.webkit.org/show_bug.cgi?id=49973 No new tests needed. * bindings/js/ScriptHeapSnapshot.h: * bindings/js/ScriptProfile.cpp: * bindings/js/ScriptProfile.h: * inspector/InspectorDebuggerAgent.cpp: * inspector/InspectorDebuggerAgent.h: * inspector/InspectorProfilerAgent.cpp: * inspector/InspectorProfilerAgent.h: * inspector/ScriptBreakpoint.h: 2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu> Reviewed by Kenneth Rohde Christiansen. Make WebKit2 compile with !ENABLE(INSPECTOR). https://bugs.webkit.org/show_bug.cgi?id=49973 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): 2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu> Reviewed by Kenneth Rohde Christiansen. Make WebKit2 compile with !ENABLE(INSPECTOR). https://bugs.webkit.org/show_bug.cgi?id=49973 * Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl): * UIProcess/API/C/WKAPICast.h: * UIProcess/API/C/WKInspector.cpp: * UIProcess/API/C/WKInspector.h: * UIProcess/API/C/WKPage.cpp: * UIProcess/API/C/WKPage.h: * UIProcess/WebInspectorProxy.cpp: * UIProcess/WebInspectorProxy.h: * UIProcess/WebInspectorProxy.messages.in: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::processDidCrash): * UIProcess/WebPageProxy.h: * UIProcess/mac/WebInspectorProxyMac.mm: * UIProcess/qt/WebInspectorProxyQt.cpp: * UIProcess/win/WebInspectorProxyWin.cpp: * WebProcess/WebCoreSupport/WebInspectorClient.cpp: * WebProcess/WebCoreSupport/WebInspectorClient.h: * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: * WebProcess/WebPage/WebInspector.cpp: * WebProcess/WebPage/WebInspector.h: * WebProcess/WebPage/WebInspector.messages.in: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::close): (WebKit::WebPage::windowIsFocused): (WebKit::WebPage::didReceiveMessage): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/qt/WebInspectorQt.cpp: * WebProcess/WebPage/win/WebInspectorWin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72666 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt][WK2] Make deep copies of tile images We need the tile images we get from UpdateChunk::createImage() to persist, so we should take a copy() of them. * UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::updateFromChunk): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72665 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
paroga@webkit.org authored
Reviewed by Csaba Osztrogonác. Simplify make-hash-tools.pl https://bugs.webkit.org/show_bug.cgi?id=49922 HashTools.h does not need to be generated, because it only contains static code. * html/DocTypeStrings.gperf: Include findDoctypeEntry function. * make-hash-tools.pl: Do not generate HashTools.h. * platform/ColorData.gperf: Include findColor function. * platform/HashTools.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72664 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
loki@webkit.org authored
Reviewed by Csaba Osztrogonác. Merge the usage of jumps and calls at ARM-JIT https://bugs.webkit.org/show_bug.cgi?id=50008 Those JmpSrc objects which represent jumps (not calls) should point to after the jump instruction. * assembler/ARMAssembler.h: (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::getAbsoluteJumpAddress): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset): * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::call): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72663 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Xan Lopez. [GTK] Optimize foldCase, toLower and toUpper methods in glib unicode backend https://bugs.webkit.org/show_bug.cgi?id=48625 GLib methods use UTF-8 strings, so we have to convert from UTF-16 to UTF-8 to perform the case operations and then convert back the result to UTF-16. GLib conversion methods return a new allocated string, so we have to memcpy the result into the destination buffer too. Using our own methods to convert between UTF-8 and UTF-16 from wtf/unicode/UTF8.h we don't need such memcpy, since they take an already allocated buffer rather than returning a new one. There's another optimization for the case when the destination buffer is not large enough. In that case, methods should return the expected destination buffer size and are called again with a new buffer. We can avoid the conversion to UTF-16 by pre-calculating the required size for the destination buffer. * wtf/unicode/glib/UnicodeGLib.cpp: (WTF::Unicode::getUTF16LengthFromUTF8): (WTF::Unicode::convertCase): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72662 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
satish@chromium.org authored
Reviewed by Steve Block. Re-enabled layout tests which were disabled during an API migration. https://bugs.webkit.org/show_bug.cgi?id=50013 * platform/chromium/test_expectations.txt: 2010-11-24 Satish Sampath <satish@chromium.org> Reviewed by Steve Block. Remove API migration code which is no longer used. https://bugs.webkit.org/show_bug.cgi?id=50013 * public/WebSpeechInputControllerMock.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72661 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Reviewed by Simon Hausmann. [Qt] Pass Qt::TextBypassShaping flag when calculating shadow layer rects Without this, we could end up with a slightly too small shadow layer for some string/font combinations. * platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72660 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
loislo@chromium.org authored
Unreviewed. chromium expectation fix. BUG49967 MAC : font-size-zero.html = TEXT was restored. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72659 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
steveblock@google.com authored
Reviewed by Jeremy Orlow. LayoutTest fast/dom/DeviceOrientation/event-after-navigation.html is flaky https://bugs.webkit.org/show_bug.cgi?id=49384 This is an asynchronous script test which navigates the main page but relies on js-test-post.js calling LayoutTestController.waitUntilDone(). It's possible for the main page to be navigated and hence the load of js-test-post.js to be cancelled before LayoutTestController.waitUntilDone() is called, which causes the test to fail. * fast/dom/DeviceOrientation/script-tests/event-after-navigation.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72658 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: add timing tab to the network item view. https://bugs.webkit.org/show_bug.cgi?id=49920 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showPopover): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set timing): * inspector/front-end/ResourceTimingView.js: Added. (WebInspector.ResourceTimingView): (WebInspector.ResourceTimingView.prototype.show): (WebInspector.ResourceTimingView.prototype._refresh): (WebInspector.ResourceTimingView.createTimingTable): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: * inspector/front-end/networkPanel.css: (#network-views .network-item-view .tabbed-pane-header): (.resource-timing-view): (.resource-timing-view table): (.resource-timing-view .network-timing-bar): (.resource-timing-view .network-timing-bar.proxy): (.resource-timing-view .network-timing-bar.dns): (.resource-timing-view .network-timing-bar.connecting): (.resource-timing-view .network-timing-bar.ssl): (.resource-timing-view .network-timing-bar.sending): (.resource-timing-view .network-timing-bar.waiting): (.resource-timing-view .network-timing-bar.receiving): (.resource-timing-view.visible): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72657 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Not reviewed. Follow up to r72652 (style id change in inspector). * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72656 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: refactor ResourceView hierarchy. https://bugs.webkit.org/show_bug.cgi?id=49864 This refactoring splits ResourceView.js into: NetworkItemView.js (tabbed pane) ResourceHeadersView.js (header tab) ResourceCookiesView.js (cookies tab) ResourceView.js (base class for content tab). CookiesTable was extracted from CookieItemsView and brushed up. headersVisible flag has been removed. * English.lproj/localizedStrings.js: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.resize): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._deleteCookie): (WebInspector.CookieItemsView.prototype._deleteButtonClicked): (WebInspector.CookieItemsView.prototype._refreshButtonClicked): (WebInspector.SimpleCookiesTable): (WebInspector.SimpleCookiesTable.prototype.setCookies): (WebInspector.SimpleCookiesTable.prototype.resize): * inspector/front-end/CookiesTable.js: Added. (WebInspector.CookiesTable): (WebInspector.CookiesTable.prototype.updateWidths): (WebInspector.CookiesTable.prototype.setCookies): (WebInspector.CookiesTable.prototype.addCookiesFolder): (WebInspector.CookiesTable.prototype.get selectedCookie): (WebInspector.CookiesTable.prototype._rebuildTable): (WebInspector.CookiesTable.prototype.reset): (WebInspector.CookiesTable.prototype._populateNode): (WebInspector.CookiesTable.prototype._totalSize): (WebInspector.CookiesTable.prototype._sortCookies.localeCompare): (WebInspector.CookiesTable.prototype._sortCookies.numberCompare): (WebInspector.CookiesTable.prototype._sortCookies.expiresCompare): (WebInspector.CookiesTable.prototype._sortCookies): (WebInspector.CookiesTable.prototype._createGridNode): (WebInspector.CookiesTable.prototype._onDeleteFromGrid): * inspector/front-end/FileSystemView.js: (WebInspector.FileSystemView.prototype._selectFileSystemTab): (WebInspector.FileSystemView.prototype.selectTemporaryFileSystemTab): * inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContent): (WebInspector.FontView.prototype._createContentIfNeeded): (WebInspector.FontView.prototype.show): (WebInspector.FontView.prototype.updateFontPreviewSize): * inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContent): (WebInspector.ImageView.prototype.show): * inspector/front-end/NetworkItemView.js: Added. (WebInspector.NetworkItemView): (WebInspector.NetworkItemView.prototype.show): (WebInspector.NetworkItemView.prototype._selectTab): (WebInspector.NetworkItemView.prototype._tabSelected): (WebInspector.NetworkItemView.prototype.resize): (WebInspector.NetworkItemView.prototype.selectContentTab): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refreshResource): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource): * inspector/front-end/ResourceCookiesView.js: Added. (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show): * inspector/front-end/ResourceHeadersView.js: Added. (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshURL): (WebInspector.ResourceHeadersView.prototype._refreshQueryString): (WebInspector.ResourceHeadersView.prototype._refreshFormData): (WebInspector.ResourceHeadersView.prototype._refreshRequestPayload): (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._toggleURLdecoding): (WebInspector.ResourceHeadersView.prototype._getHeaderValue): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation): (WebInspector.ResourceHeadersView.prototype._refreshHeaders): * inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.hasContent): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._showResourceView): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): * inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.hasContent): (WebInspector.SourceView.prototype.updateLocalContent): (WebInspector.SourceView.prototype.selectLocalContentTab): * inspector/front-end/StylesSidebarPane.js: * inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.selectTab): (WebInspector.TabbedPane.prototype._showTab): (WebInspector.TabbedPane.prototype._hideTab): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.css: (.webkit-line-gutter-backdrop): (.resource-view): (.resource-view.visible): (.resource-view.font): (.resource-view.image > .image): (.resource-view.image > .info): (.storage-view): (.storage-view .data-grid): (.storage-empty-view, .storage-view .storage-table-error): (.storage-view .storage-table-error): * inspector/front-end/inspector.html: * inspector/front-end/networkPanel.css: (.network-cell-subtitle): (.network-header-subtitle): (#network-views .network-item-view .tabbed-pane-header): (#network-views.small .network-item-view .tabbed-pane-header): (.network-item-view): (.network-item-view.visible): (.network-item-view .tabbed-pane-header): (.network-item-view .scope-bar li): (.resource-headers-view): (.resource-headers-view.visible): (.resource-headers-view .outline-disclosure .parent): (.resource-headers-view .outline-disclosure .children li): (.resource-headers-view .outline-disclosure li.expanded .header-count): (.resource-headers-view .outline-disclosure .header-name): (.resource-headers-view .outline-disclosure .header-value): (.resource-headers-view .outline-disclosure .raw-form-data): (.resource-cookies-view): (.resource-cookies-view.visible): (.resource-cookies-view .data-grid): (.resource-cookies-view .data-grid .row-group): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72655 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: add "Locally modified" group into the resource panel. https://bugs.webkit.org/show_bug.cgi?id=50005 * English.lproj/localizedStrings.js: * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.addLocallyModifiedRevision): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.BaseStorageTreeElement.prototype.set titleText): (WebInspector.LocallyModifiedResourceTreeElement): (WebInspector.LocallyModifiedResourceTreeElement.prototype.onselect): (WebInspector.LocallyModifiedResourceTreeElement.prototype.gcRevisions): (WebInspector.LocallyModifiedRevisionTreeElement): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onattach): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onselect): (WebInspector.LocallyModifiedRevisionTreeElement.prototype._ondragstart): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72654 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed, rolling out r72650. http://trac.webkit.org/changeset/72650 https://bugs.webkit.org/show_bug.cgi?id=50010 breaks focus in scenes focus item other than graphicswebiview (Requested by tronical_ on #webkit). * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::itemChange): * Api/qgraphicswebview.h: * tests/qgraphicswebview/tst_qgraphicswebview.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72653 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: pass style id to front-end as Object, not string. https://bugs.webkit.org/show_bug.cgi?id=49971 * inspector/Inspector.idl: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getStyleSheetText2): (WebCore::InspectorCSSAgent::setPropertyText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2): * inspector/InspectorCSSAgent.h: * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyleSheet::finalURL): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::text): * inspector/InspectorStyleSheet.h: (WebCore::InspectorCSSId::InspectorCSSId): (WebCore::InspectorCSSId::isEmpty): (WebCore::InspectorCSSId::styleSheetId): (WebCore::InspectorCSSId::ordinal): (WebCore::InspectorCSSId::asInspectorValue): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheetForInlineStyle::styleForId): * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText): 2010-11-23 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: pass style id to front-end as Object, not string. https://bugs.webkit.org/show_bug.cgi?id=49971 * inspector/styles-new-API.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72652 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Fix uninitialized variable in QGraphicsWKViewPrivate Always initialize QGWKVP::m_isChangingScale in the constructor. * UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72651 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Html autofocus not working with QGraphicsWebView https://bugs.webkit.org/show_bug.cgi?id=43169 QGraphicsScene does not propagate Qt::ActivateWindowFocusReason focus events when there are no active items. * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::eventFilter): (QGraphicsWebView::itemChange): * Api/qgraphicswebview.h: * tests/qgraphicswebview/tst_qgraphicswebview.cpp: (FocusPage::FocusPage): (FocusPage::event): (FocusPage::gotFocus): (tst_QGraphicsWebView::receivesFocusInOnShow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72650 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed, rolling out r72647. http://trac.webkit.org/changeset/72647 https://bugs.webkit.org/show_bug.cgi?id=50009 breaks the http layout tests (Requested by philn-tp on #webkit). * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): (WebCore::startHttp): (WebCore::ResourceHandle::platformSetDefersLoading): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72649 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
loislo@chromium.org authored
Unreviewed. Fix for chromium expectations. composited-plugin.html is crashing on MAC. small-to-large-composited-plugin.html is crashing on MAC. font-size-zero.html is passing. * platform/chromium-gpu/test_expectations.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72648 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
philn@webkit.org authored
Reviewed by Martin Robinson. [soup] implement ResourceHandle::platformSetDefersLoading https://bugs.webkit.org/show_bug.cgi?id=44158 * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Implemented using the soup_session_{,un}pause_message APIs. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 Nov, 2010 13 commits
-
-
paroga@webkit.org authored
Reviewed by David Levin. Add WebKit2 VisualStudio files to .gitattributes https://bugs.webkit.org/show_bug.cgi?id=49969 * .gitattributes: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72646 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
inferno@chromium.org authored
Unreviewed. Drag and drop not working properly. Skipping just like other similar drag and drop tests. E.g. similar test drag-image-in-about-blank-frame.html. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72645 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
inferno@chromium.org authored
Reviewed by Adam Barth. r71925 broke the chrome new tab page. r71925 blocked drag and drop of same security origin objects onto themselves if their origin is marked unique. We need to allow drag and drop in that scenario. https://bugs.webkit.org/show_bug.cgi?id=49098 Test: http/tests/security/drag-drop-same-unique-origin.html * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canReceiveDragData): 2010-11-23 Abhishek Arya <inferno@chromium.org> Reviewed by Adam Barth. Tests that drag and drop is allowed across the same security origin object, even if they are marked unique. * http/tests/security/drag-drop-same-unique-origin-expected.txt: Added. * http/tests/security/drag-drop-same-unique-origin.html: Added. * http/tests/security/resources/drag-drop-allowed.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72644 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Unreviewed update of GTK's skipped list. Disabled editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html because they require editing delegates dump which haven't been implemented in GTK. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72643 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tony@chromium.org authored
Unreviewed, [chromium] merge the plugin failures in test_expectations https://bugs.webkit.org/show_bug.cgi?id=49993 * platform/chromium/drt_expectations.txt: Remove plugin failures * platform/chromium/test_expectations.txt: Move them into this file with expectations that are valid for either plugin. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72642 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dpranke@chromium.org authored
Reviewed by Tony Chang. This patch cleans up the logic used to shard tests into groups a bit and adds the --worker-model flag to NRWT. The flag is only used at the moment to control whether to run single-threaded or not, but eventually will also allow toggling between threads and processes. Also add a minor cleanup with _test_is_slow(), which just eliminates some repetition and gives slightly better encapsulation. https://bugs.webkit.org/show_bug.cgi?id=49773 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72641 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mihaip@chromium.org authored
Reviewed by Tony Chang. Rebaseline server: list current baselines and platforms https://bugs.webkit.org/show_bug.cgi?id=49991 List existing baselines (with Trac links) for tests. Add dropdowns for choosing with platform baselines to target (and what to do with existing ones). Also fix MockFileSystem.join to behave more like os.path.join (unit test was ending up with two consecutive slashes in a layout test path). * Scripts/webkitpy/common/system/filesystem_mock.py: * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: * Scripts/webkitpy/tool/commands/rebaselineserver.py: * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72640 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
inferno@chromium.org authored
Reviewed by Dimitri Glazkov. Removed unneeded conversions to RenderBlock. https://bugs.webkit.org/show_bug.cgi?id=49896 Test: fast/css/input-search-table-column-crash.html * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): 2010-11-23 Cris Neckar <cdn@chromium.org> Reviewed by Dimitri Glazkov. Test for crash with input type search and table column style. https://bugs.webkit.org/show_bug.cgi?id=49896 * fast/css/input-search-table-column-crash-expected.txt: Added. * fast/css/input-search-table-column-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72639 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Reviewed by Adam Barth. XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag https://bugs.webkit.org/show_bug.cgi?id=49701 Fixed the bug by calling ScriptElement's executeScript, which sets isEvaluated flag to true. Test: fast/dom/script-clone-rerun-src.xhtml * dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): 2010-11-23 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Adam Barth. XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag https://bugs.webkit.org/show_bug.cgi?id=49701 Added a test to ensure WebKit doesn't run the script twice when a script element with an external script file is cloned in a XML document. * fast/dom/resources/script-clone-rerun-src.js: Added. * fast/dom/script-clone-rerun-src.xhtml: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72638 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Reviewed by Tony Chang. dumpAsText conversion: editing/deleting/delete-by-word-001.html and delete-by-word-002.html https://bugs.webkit.org/show_bug.cgi?id=48130 Converted editing/deleting/delete-by-word-001.html and delete-by-word-002.html to dumpAsText tests by replacing calls to runEditingTest by runDumpAsTextEditingTest. * editing/deleting/delete-by-word-001-expected.txt: Added. * editing/deleting/delete-by-word-001.html: * editing/deleting/delete-by-word-002-expected.txt: Added. * editing/deleting/delete-by-word-002.html: * platform/chromium-linux/editing/deleting/delete-by-word-001-expected.checksum: Removed. * platform/chromium-linux/editing/deleting/delete-by-word-001-expected.png: Removed. * platform/chromium-linux/editing/deleting/delete-by-word-002-expected.checksum: Removed. * platform/chromium-linux/editing/deleting/delete-by-word-002-expected.png: Removed. * platform/chromium-win/editing/deleting/delete-by-word-001-expected.checksum: Removed. * platform/chromium-win/editing/deleting/delete-by-word-001-expected.png: Removed. * platform/chromium-win/editing/deleting/delete-by-word-001-expected.txt: Removed. * platform/chromium-win/editing/deleting/delete-by-word-002-expected.checksum: Removed. * platform/chromium-win/editing/deleting/delete-by-word-002-expected.png: Removed. * platform/chromium-win/editing/deleting/delete-by-word-002-expected.txt: Removed. * platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Removed. * platform/mac/editing/deleting/delete-by-word-001-expected.checksum: Removed. * platform/mac/editing/deleting/delete-by-word-001-expected.png: Removed. * platform/mac/editing/deleting/delete-by-word-001-expected.txt: Removed. * platform/mac/editing/deleting/delete-by-word-002-expected.checksum: Removed. * platform/mac/editing/deleting/delete-by-word-002-expected.png: Removed. * platform/mac/editing/deleting/delete-by-word-002-expected.txt: Removed. * platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Removed. * platform/qt/editing/deleting/delete-by-word-001-expected.png: Removed. * platform/qt/editing/deleting/delete-by-word-001-expected.txt: Removed. * platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Removed. * platform/qt/editing/deleting/delete-by-word-002-expected.png: Removed. * platform/qt/editing/deleting/delete-by-word-002-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72637 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ojan@chromium.org authored
Reviewed by Tony Chang. remove timeout argument to urlopen https://bugs.webkit.org/show_bug.cgi?id=49995 Apparently the version of python we have on the bots doesn't accept a timeout argument. * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72636 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed, rolling out r72628. http://trac.webkit.org/changeset/72628 https://bugs.webkit.org/show_bug.cgi?id=49994 This patch is causing layout-test failtures on GTK Linux 64-bit Debug (Requested by ctguil on #webkit). * accessibility/iframe-has-document-expected.txt: Removed. * accessibility/iframe-has-document.html: Removed. * platform/win/Skipped: 2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r72628. http://trac.webkit.org/changeset/72628 https://bugs.webkit.org/show_bug.cgi?id=49994 This patch is causing layout-test failtures on GTK Linux 64-bit Debug (Requested by ctguil on #webkit). * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren): * accessibility/AccessibilityRenderObject.h: * accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): 2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r72628. http://trac.webkit.org/changeset/72628 https://bugs.webkit.org/show_bug.cgi?id=49994 This patch is causing layout-test failtures on GTK Linux 64-bit Debug (Requested by ctguil on #webkit). * public/WebAccessibilityObject.h: * src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::parentObject): 2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r72628. http://trac.webkit.org/changeset/72628 https://bugs.webkit.org/show_bug.cgi?id=49994 This patch is causing layout-test failtures on GTK Linux 64-bit Debug (Requested by ctguil on #webkit). * DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback): * DumpRenderTree/chromium/AccessibilityUIElement.h: * DumpRenderTree/chromium/CppBoundClass.cpp: * DumpRenderTree/chromium/CppBoundClass.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72635 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xan@webkit.org authored
2010-11-23 Xan Lopez <xlopez@igalia.com> Reviewed by Martin Robinson. [GTK] Fix IFrame DOM bindings API https://bugs.webkit.org/show_bug.cgi?id=49980 Fix IFrame API naming. It needs special casing because of the two consecutive capital letters. * bindings/scripts/CodeGeneratorGObject.pm: WebKit/gtk: 2010-11-23 Xan Lopez <xlopez@igalia.com> Reviewed by Martin Robinson. [GTK] Fix IFrame DOM bindings API https://bugs.webkit.org/show_bug.cgi?id=49980 * tests/testdomdocument.c: (test_dom_document_garbage_collection): change to use the fixed IFrame APIs. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
