Commits · cb0075b0f3bddbedb1ac86666f6b69f9520c847b · App_Technologies / webkit

30 Nov, 2009 38 commits

2009-11-30 Yuzo Fujishima <yuzo@google.com> · cb0075b0

eric@webkit.org authored Dec 01, 2009

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.2.1.
        This is to fix a bug that some messages are logged to stderr even when the log file is specified.
        https://bugs.webkit.org/show_bug.cgi?id=31976

        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cb0075b0

wx build fix, add header needed for wx build. · 326e8dea

kevino@webkit.org authored Dec 01, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

326e8dea

<rdar://problem/7424387 > WebCore binary missing symbols when built for x86_64... · 384efa6a

mrowe@apple.com authored Dec 01, 2009

<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
be performed against the x86_64 architecture.

* DerivedSources.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

384efa6a

2009-11-30 Adam Barth <abarth@webkit.org> · 39598035

eric@webkit.org authored Dec 01, 2009

        Reviewed by Eric Seidel.

        [bzt] Generate pass messages for style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31995

        With this change, the style-queue posts "pass" messages to bugs as
        well.  Also, added more information to the state store w.r.t. passing
        and failing.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

39598035

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in · 70c2e451

bdakin@apple.com authored Nov 30, 2009

Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used 
as a divisor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

* fast/multicol/huge-column-gap-crash-expected.txt: Added.
* fast/multicol/huge-column-gap-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

70c2e451

Reviewed by Oliver Hunt. · 53c40236

ap@apple.com authored Nov 30, 2009

        https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

53c40236

2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com> · e1dd094e

eric@webkit.org authored Nov 30, 2009

        Reviewed by Simon Hausmann.

        [Qt][Symbian] Report SymbianOS in user agent string for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31961

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e1dd094e

Windows Build fix. Reviewed by NOBODY. · ca49f604

barraclough@apple.com authored Nov 30, 2009

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ca49f604

Use the correct path to Info.plist to avoid creating an empty file at the top... · 5a35b872

mrowe@apple.com authored Nov 30, 2009

Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5a35b872

Bug 31859 - Make world selection for JSC IsolatedWorlds automagical. · 6539bbe2

barraclough@apple.com authored Nov 30, 2009

Reviewed by Geoff Garen.

JavaScriptCore: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
        
Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:

WebCore: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

* WebCore.base.exp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
* dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
* dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
* dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6539bbe2

2009-11-30 Eric Carlson <eric.carlson@apple.com> · 8fec90f7

eric.carlson@apple.com authored Nov 30, 2009

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::noneSupported):
        (WebCore::HTMLMediaElement::mediaEngineError):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::userCancelledLoad):
            Call scheduleEvent instead of scheduleProgressEvent.
        (WebCore::HTMLMediaElement::progressEventTimerFired):
            Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
            after scheduling a 'progress' event so the controller will update download
            progress indicator.
        * html/HTMLMediaElement.h:
            Remove scheduleProgressEvent prototype.

2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513
        
        Remove progress event tests.

        * media/progress-event-at-least-one-expected.txt: Removed.
        * media/progress-event-at-least-one.html: Removed.
        * media/progress-event-expected.txt: Removed.
        * media/progress-event-total-expected.txt: Removed.
        * media/progress-event-total.html: Removed.
        * media/progress-event.html: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8fec90f7

Fix double-free of BSTRs passed to WebNavigationData::createInstance · 391d91e9

aroben@apple.com authored Nov 30, 2009

WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

* WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
* WebNavigationData.h:
Changed to take const WebCore::Stri...

391d91e9

It was me who reviewed the patch, not Eric! Alas, some tools we use cause... · 6d23a697

ap@apple.com authored Nov 30, 2009

It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6d23a697

2009-11-30 Yuzo Fujishima <yuzo@google.com> · 87995de7

ap@apple.com authored Nov 30, 2009

        Reviewed by Eric Seidel.

        In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
        https://bugs.webkit.org/show_bug.cgi?id=31465

        * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to
        Skipped list, and filed bug 31659 to investigate.

        * websocket/tests/handshake-error_wsh.py: Call write() on a correct object.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

87995de7

Remove file git invisibly added · 0edf8337

joepeck@webkit.org authored Nov 30, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0edf8337

2009-11-30 Joseph Pecoraro <joepeck@webkit.org> · 723f16eb

joepeck@webkit.org authored Nov 30, 2009

        Reviewed by Pavel Feldman.

        Web Inspector: Wrong console output for Regexp escape sequence
        https://bugs.webkit.org/show_bug.cgi?id=31538

        Updated inspector/console-format.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement): style issues.
        (WebInspector.ConsoleView.createFilterElement): style issues.
        (WebInspector.ConsoleView): added _customFormatters table.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
        (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
        (WebInspector.ConsoleView.prototype._formatobject):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._printArray):
        (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
        (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/InjectedScript.js: simplified regex formatting.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass): update inaccurate comment.
        (String.prototype.trimURL): converted new RegExp to literal for performance benefits.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

723f16eb

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5c6ee644

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove obsolete PLATFORM(KDE) code
        https://bugs.webkit.org/show_bug.cgi?id=31958

        KDE is now using unpatched QtWebKit.

        * parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
        * wtf/Platform.h: Remove PLATFORM(KDE) definition and code
        section that is guarded with it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5c6ee644

Skipping test that fails because of broken DND, and some tests · f4d1ccff

kov@webkit.org authored Nov 30, 2009

requiring new results.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4d1ccff

Rubber-stamped by Xan Lopez. · 2a1f73ca

kov@webkit.org authored Nov 30, 2009

Make sure we distribute and install GObject Introspection files.

* GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2a1f73ca

2009-11-30 Erik Arvidsson <arv@chromium.org> · 10fcdba8

eric@webkit.org authored Nov 30, 2009

        Reviewed by Adam Barth.

        Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=31895

        No new tests. This is already covered by:
                fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                fast/dom/CSSStyleDeclaration/css-style-item.html

        * bindings/v8/V8Collection.h:
        (WebCore::collectionStringIndexedPropertyGetter):
        (WebCore::setCollectionStringIndexedGetter):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10fcdba8

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld... · 18e1477d

sfalken@apple.com authored Nov 30, 2009

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18e1477d

Reviewed by Simon Fraser. · a9abbee5

kov@webkit.org authored Nov 30, 2009

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a9abbee5

2009-11-30 Steve Block <steveblock@google.com> · 2b92f0e3

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
        https://bugs.webkit.org/show_bug.cgi?id=31932

        Build fix only, no new tests.

        * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2b92f0e3

2009-11-30 Steve Block <steveblock@google.com> · 4caafb76

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds PassOwnPtr include to ScriptExecutionContext.h.
        https://bugs.webkit.org/show_bug.cgi?id=31929

        Build fix only, no new tests.

        * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4caafb76

2009-11-30 Dirk Schulze <krit@webkit.org> · 5b0c5989

eric@webkit.org authored Nov 30, 2009

Reviewed by Nikolas Zimmermann.

Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.

* platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
* platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
* platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
* svg/custom/mask-with-all-units.svg: Added.
2009-11-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
[https://bugs.webkit.org/show_bug.cgi?id=31980]

It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.

Test: svg/custom/mask-with-all-units.svg

* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5b0c5989

2009-11-30 Steve Block <steveblock@google.com> · 54abffc6

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31928

        Build fix only, no new tests.

        * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

54abffc6

2009-11-30 Yaar Schnitman <yaar@chromium.org> · 1c1a18c1

eric@webkit.org authored Nov 30, 2009

        Reviewed by Dimitri Glazkov.

        update-webkit --chromium forces gclient sync

        https://bugs.webkit.org/show_bug.cgi?id=31967

        * Scripts/update-webkit-chromium:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1c1a18c1

2009-11-30 Steve Block <steveblock@google.com> · 70a4bba4

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=31926

        Build fix only, no new tests.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

70a4bba4

2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com> · 9c8c379e

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        Chrome::contentsSizeChanged() is called when the content size has not changed
        https://bugs.webkit.org/show_bug.cgi?id=31978

        Do not trigger contentsSizeChaned() is the new size is the same as the old one.

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9c8c379e

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9e1d35df

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix minor waning in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=31963

        * tests/qwebpage/tst_qwebpage.cpp:
        (ErrorPage::extension): Remove info wariable as it is
        not used.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9e1d35df

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · b6de04f4

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix some compiler warnings seen on QtWebKit/Mac
        https://bugs.webkit.org/show_bug.cgi?id=31962

        No new tests as there is no functional change.

        * platform/network/ResourceHandle.h: Make destructor virtual as
        after r50772 ResourceHandle has virtual functions.

        * plugins/mac/PluginPackageMac.cpp:
        (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
        not a label

        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
        specifier

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b6de04f4

Versioning. · e2f9debf

mrowe@apple.com authored Nov 30, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e2f9debf

Build fix. Make sure JSCore-1.0.gir is added to the distributed · 60affd13
kov@webkit.org authored Nov 30, 2009
```
tarball.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
60affd13

2009-11-30 Xan Lopez <xlopez@igalia.com> · 22674493

xan@webkit.org authored Nov 30, 2009

        Reviewed by Gustavo Noronha.

        Bump versions for 1.1.17 release.

        * configure.ac:

WebCore:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add new headers to sources list.

        * GNUmakefile.am:

WebKit/gtk:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Prepare for 1.1.17 release.

        * NEWS:
        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22674493

[Qt] Mac Plugins : Get context menu to work in QGraphicsView · 9efe23b6

girish@forwardbias.in authored Nov 30, 2009

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

https://bugs.webkit.org/show_bug.cgi?id=31979

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9efe23b6

[Qt] Fix compilation with win32-icc · 6eb95ffc

hausmann@webkit.org authored Nov 30, 2009

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

* WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the __has_trivial_constructor type
trait.  The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

* wtf/TypeTraits.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6eb95ffc

Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController. · 021719e4

steveblock@google.com authored Nov 30, 2009

https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

* bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

021719e4

[Qt] Put tests into skiplist because of missing features. · 1fd3cff0

ossy@webkit.org authored Nov 30, 2009

* platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1fd3cff0

29 Nov, 2009 2 commits

Build fix. · 4af99e8b

bfulgham@webkit.org authored Nov 30, 2009

Correct draw signature used in ImageCairoWin.cpp.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4af99e8b

postMessage should serialize File objects · 88ed9c19

oliver@apple.com authored Nov 30, 2009

https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

88ed9c19