1. 26 Sep, 2006 1 commit
    • sullivan's avatar
      WebCore: · caf3550b
      sullivan authored
              Reviewed by Darin
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed down to Frame
              
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::markAllMatchesForText):
              Added limit parameter. Stop the search if it hits limit.
      
      WebKit:
      
              Reviewed by Darin
      
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebHTMLView.m:
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed over the bridge. Stop the search if it hits limit.
      
              * WebView/WebViewPrivate.h:
              * WebView/WebView.m:
              (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
              Added limit parameter, passed to WebHTMLView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caf3550b
  2. 21 Sep, 2006 1 commit
    • ggaren's avatar
      JavaScriptCore: · 0de1f3e4
      ggaren authored
              Reviewed by Maciej.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              Updated to include the right path.
              * wtf/FastMalloc.h: #include Platform.h, since we use Platform macros.
      
      WebCore:
      
              Reviewed by Maciej.
              
              Some Widget refactoring.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * bridge/mac/FrameMac.mm:
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::runJavaScriptAlert):
              (WebCore::FrameWin::runJavaScriptConfirm):
              * bridge/win/PageWin.cpp:
              (WebCore::Page::Page):
              (WebCore::rootWindowForFrame):
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::translate):
              * page/FrameView.cpp:
              (WebCore::FrameView::isFrameView):
              * page/Page.h:
              (WebCore::Page::setInstanceHandle):
              (WebCore::Page::instanceHandle):
              * platform/GraphicsContext.h:
              * platform/ScrollView.h:
              * platform/Widget.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::translate):
              (WebCore::GraphicsContext::origin):
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::clearFocus):
              * platform/win/ResourceLoaderWin.cpp:
              (WebCore::initializeOffScreenResourceLoaderWindow):
              * platform/win/ScreenWin.cpp:
              (WebCore::monitorInfo):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::updateContents):
              (WebCore::ScrollView::visibleWidth):
              (WebCore::ScrollView::visibleHeight):
              (WebCore::ScrollView::visibleContentRect):
              (WebCore::ScrollView::viewportToContents):
              (WebCore::ScrollView::contentsToViewport):
              (WebCore::ScrollView::scrollBy):
              (WebCore::ScrollView::updateScrollInfo):
              (WebCore::ScrollView::updateScrollBars):
              * platform/win/SharedTimerWin.cpp:
              (WebCore::initializeOffScreenTimerWindow):
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameView::updateBorder):
              (ScrollView::paint):
              (GraphicsContext::clip):
              * platform/win/WidgetWin.cpp:
              (WebCore::Widget::Widget):
              (WebCore::Widget::parentWindow):
              (WebCore::Widget::setParentWindow):
              (WebCore::Widget::frameGeometry):
              (WebCore::Widget::hasFocus):
              (WebCore::Widget::setFocus):
              (WebCore::Widget::show):
              (WebCore::Widget::hide):
              (WebCore::Widget::setFrameGeometry):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0de1f3e4
  3. 18 Sep, 2006 2 commits
    • beidson's avatar
      WebCore: · b4e0cebe
      beidson authored
              Reviewed by Anders
      
              <rdar://problem/3028061> - WebKit never updates favicon
              The WebKit enforced expiration date for icons has worked for some time, but the
              move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
              functionality.  This patch fixes that up, along with some other architectural improvements,
              the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
      
              * bridge/mac/FrameMac.h: Added isLoadTypeReload()
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
              * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
              * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
              * dom/Document.h: Added m_iconURL
              (WebCore::Document::iconURL): Added
              (WebCore::Document::setIconURL): Ditto
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkE...
      b4e0cebe
    • beidson's avatar
      Reviewed by John · c4640ed9
      beidson authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
              REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
      
              * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
              * bridge/win/FrameWin.h: Added originalRequestURL()
              * loader/icon/IconLoader.cpp:
              (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
              * page/Frame.cpp:
              (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
              (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
              (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
              * page/Frame.h: Added pure virtual originalRequestURL()
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameWin::originalRequestURL): Added
      
      
      
      git-svn-id: http://svn.webkit.org...
      c4640ed9
  4. 15 Sep, 2006 2 commits
    • thatcher's avatar
      WebCore: · fd4a1a63
      thatcher authored
              Reviewed by Justin.
      
              Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
              (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
              (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
              (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
              (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              (-[WebCoreFrameBridge increaseSelectionListLevel]):
              (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
              (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
              (-[WebCoreFrameBridge decreaseSelectionListLevel]):
              (-[WebCoreFrameBridge insertLineBreak]):
              (-[WebCoreFrameBridge insertParagraphSeparator]):
              (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
              (-[WebCoreFrameBridge insertText:selectInsertedText:]):
              (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
              (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
              (createMouseEventFromDraggingInfo):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::moveTo):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::modify):
              (WebCore::SelectionController::setBase):
              (WebCore::SelectionController::setExtent):
              * editing/SelectionController.h:
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::revealCaret):
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by Justin.
      
              Call the bridge directly for alter selection calls. All of this logic is now
              in WebCore's SelectionController.
      
              * WebView/WebHTMLView.m:
              (-[NSArray moveBackward:]):
              (-[NSArray moveBackwardAndModifySelection:]):
              (-[NSArray moveDown:]):
              (-[NSArray moveDownAndModifySelection:]):
              (-[NSArray moveForward:]):
              (-[NSArray moveForwardAndModifySelection:]):
              (-[NSArray moveLeft:]):
              (-[NSArray moveLeftAndModifySelection:]):
              (-[NSArray moveRight:]):
              (-[NSArray moveRightAndModifySelection:]):
              (-[NSArray moveToBeginningOfDocument:]):
              (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
              (-[NSArray moveToBeginningOfSentence:]):
              (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
              (-[NSArray moveToBeginningOfLine:]):
              (-[NSArray moveToBeginningOfLineAndModifySelection:]):
              (-[NSArray moveToBeginningOfParagraph:]):
              (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
              (-[NSArray moveToEndOfDocument:]):
              (-[NSArray moveToEndOfDocumentAndModifySelection:]):
              (-[NSArray moveToEndOfSentence:]):
              (-[NSArray moveToEndOfSentenceAndModifySelection:]):
              (-[NSArray moveToEndOfLine:]):
              (-[NSArray moveToEndOfLineAndModifySelection:]):
              (-[NSArray moveToEndOfParagraph:]):
              (-[NSArray moveToEndOfParagraphAndModifySelection:]):
              (-[NSArray moveParagraphBackwardAndModifySelection:]):
              (-[NSArray moveParagraphForwardAndModifySelection:]):
              (-[NSArray moveUp:]):
              (-[NSArray moveUpAndModifySelection:]):
              (-[NSArray moveWordBackward:]):
              (-[NSArray moveWordBackwardAndModifySelection:]):
              (-[NSArray moveWordForward:]):
              (-[NSArray moveWordForwardAndModifySelection:]):
              (-[NSArray moveWordLeft:]):
              (-[NSArray moveWordLeftAndModifySelection:]):
              (-[NSArray moveWordRight:]):
              (-[NSArray moveWordRightAndModifySelection:]):
              (-[NSArray pageUp:]):
              (-[NSArray pageDown:]):
              (-[NSArray pageUpAndModifySelection:]):
              (-[NSArray pageDownAndModifySelection:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4a1a63
    • bdash's avatar
      2006-09-14 Mark Rowe <opendarwin.org@bdash.net.nz> · eceeaea9
      bdash authored
              Reviewed by Adam.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
              Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
      
              FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
              Frame::cleanupPluginObjects method is called from Frame's destructor, which results
              in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
              will be called from Frame::clear
              * page/Frame.cpp:
              (WebCore::Frame::~Frame): Use cancelAndClear.
              (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
              FrameMac can use.
              * page/Frame.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eceeaea9
  5. 14 Sep, 2006 1 commit
    • beidson's avatar
      WebCore: · 2212efda
      beidson authored
              Reviewed by Maciej
      
              Icon loads now take place in WebCore
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              - Moved enforcement of a Mozilla Favicon extension elsewhere
              
              * bridge/mac/FrameMac.h: 
              * bridge/mac/FrameMac.mm: 
              (WebCore::FrameMac::originalRequestURL):
              - Added accessor to "original request URL"
              
              * bridge/mac/WebCoreFrameBridge.h: 
              - Removed methods to set the iconURL as all loading is now done in WebCore
              - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
              
              * html/HTMLLinkElement.cpp: 
              (WebCore::HTMLLinkElement::process):
              - Moved enforcement of a Mozilla Favicon extension elsewhere
              
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::setIconURLForPageURL):
              - Changed an ASSERT to correctly handle a sketchy (invalid) situation
      
              * loader/icon/IconLoader.h: Added.
              * loader/icon/IconLoader.cpp: Added.
              (IconLoader::IconLoader):
              (IconLoader::createForFrame):
              - Static factory method with a private constructor to enforce 
                "you MUST have a Frame to create an IconLoader" semantics
              (IconLoader::~IconLoader):
              (IconLoader::startLoading):
              (IconLoader::stopLoading):
              (IconLoader::receivedData):
              - ResourceLoaderClient delegate
              (IconLoader::receivedAllData):
              - Ditto
      
              * loader/mac/IconLoaderMac.mm: Added.
              (IconLoader::receivedResponse):
              (IconLoader::notifyIconChanged):
              - For now, these are platform specific methods
              - One to get the HTTP response code of an icon load
              - The other to call through to the app when the icon has changed (loaded)
      
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::iconURL):
              (WebCore::Frame::setIconURL):
              - Frame objects now have an inherent icon URL and a way to calculate/access it
              (WebCore::Frame::endIfNotLoading):
              - This is where we actually kick off the IconLoader
              (WebCore::Frame::stop):
              - Added call to stop loading the icon
      
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              (WebCore::FramePrivate::~FramePrivate):
              - Added the icon URL as a private member
              - Added the IconLoader as a private member, and clean it up on deletion
      
              * platform/mac/ResourceLoaderMac.mm:
              (WebCore::ResourceLoader::start):  Added a valuable ASSERT
      
      WebKit:
      
              Reviewed by Maciej
      
              Add infrastructure to support icon loads taking place in WebCore
              Will remove WebKit icon loaders in a later patch
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge notifyIconChanged:]):
              (-[WebFrameBridge originalRequestURL]):
              - Nuked two old, obsolete methods
              - Added bridge for notifying of an icon change
              - Added bridge for getting the "original request URL" which is still needed
                until that info is available in the WebCore loaders
      
              * WebView/WebDataSource.m:
              (-[WebDataSource _loadIcon]):
              - Empty body just for now, as it still gets called - next patch will prune all the old impl out
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2212efda
  6. 13 Sep, 2006 1 commit
    • andersca's avatar
      2006-09-14 Anders Carlsson <acarlsson@apple.com> · cd71fdd1
      andersca authored
              Reviewed by Tim O.
      
              Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
              
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::createLanguageInstanceForValue):
              * bindings/js/kjs_dom.cpp:
              (KJS::getRuntimeObject):
              * bridge/mac/FrameMac.h:
              * config.h:
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::~HTMLAppletElement):
              (WebCore::HTMLAppletElement::detach):
              * html/HTMLAppletElement.h:
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
              (WebCore::HTMLEmbedElement::detach):
              * html/HTMLEmbedElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::~HTMLObjectElement):
              (WebCore::HTMLObjectElement::detach):
              * html/HTMLObjectElement.h:
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::HTMLPlugInElement):
              (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
              (WebCore::HTMLPlugInElement::createNPObject):
              * html/HTMLPlugInElement.h:
              * page/Frame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd71fdd1
  7. 12 Sep, 2006 1 commit
  8. 06 Sep, 2006 1 commit
    • darin's avatar
      Reviewed by Tim Hatcher. · be6eb6ba
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=10675
                tweak font-related headers and convert lists to vectors
      
              One major change was to greatly reduce the number of files that include Font.h.
              Another was to convert many uses of DeprecatedPtrList/DeprecatedValueList to Vector.
      
              * WebCore.xcodeproj/project.pbxproj: Added TextStyle.h.
      
              * bindings/objc/DOM.mm: (-[DOMElement _font]): Changed to not depend on
              Font::getNSFont since a WebCore::Font represents more than one NSFont.
      
              * bindings/objc/DOMNode.mm: (-[DOMNode lineBoxRects]): Updated to use Vector.
              * bridge/mac/FormDataMac.mm: (WebCore::arrayFromFormData): Ditto.
              * bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateDashboardRegions): Ditto.
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
              * dom/Document.cpp:
              (WebCore::Document::dashboardRegions): D...
      be6eb6ba
  9. 05 Sep, 2006 2 commits
    • darin's avatar
      LayoutTests: · b3547a37
      darin authored
              Reviewed by Alexey.
      
              - test for bug where the charset in a link element for a CSS stylesheet is ignored.
                I noticed this while working on new text encoding machinery.
      
              * fast/encoding/css-link-charset-expected.txt: Added.
              * fast/encoding/css-link-charset.css: Added.
              * fast/encoding/css-link-charset.html: Added.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10681
                REGRESSION: Reproducible crash at Wikipedia
                (Alexey wrote this one, I reviewed.)
      
              * fast/forms/form-data-encoding-normalization-overrun-expected.txt: Added.
              * fast/forms/form-data-encoding-normalization-overrun.html: Added.
      
              - and a tweak to an existing test
      
              * fast/forms/form-data-encoding.html: Changed to dump encoded URL so it's easier to
              diagnose this when it fails.
      
      WebCore:
      
              Reviewed by Alexey.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=10728
                text encodings should work...
      b3547a37
    • justing's avatar
      LayoutTests: · 397edaa4
      justing authored
              Reviewed by thatcher
              
              Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete
      
              Fixed:
              * editing/pasteboard/4641033-expected.checksum:
              * editing/pasteboard/4641033-expected.png:
              * editing/execCommand/outdent-selection-expected.checksum:
              * editing/execCommand/outdent-selection-expected.png:
      
              Added a didChangeSelection notification that was absent before:
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-block-table-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-first-list-item-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/boldSelection-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/createLink-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/hilitecolor-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/execCommand/insertHorizontalRule-expected.txt:
              * editing/execCommand/remove-formatting-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/strikethroughSelection-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/execCommand/unlink-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3654864-fix-expected.txt:
              * editing/inserting/insert-3659587-fix-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-001-expected.txt:
              * editing/inserting/insert-div-002-expected.txt:
              * editing/inserting/insert-div-003-expected.txt:
              * editing/inserting/insert-div-005-expected.txt:
              * editing/inserting/insert-div-007-expected.txt:
              * editing/inserting/insert-div-009-expected.txt:
              * editing/inserting/insert-div-010-expected.txt:
              * editing/inserting/insert-div-020-expected.txt:
              * editing/inserting/insert-div-023-expected.txt:
              * editing/inserting/insert-div-024-expected.txt:
              * editing/inserting/insert-div-025-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/paragraph-separator-03-expected.txt:
              * editing/inserting/paragraph-separator-in-table-2-expected.txt:
              * editing/inserting/redo-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/inserting/return-key-with-selection-003-expected.txt:
              * editing/pasteboard/3976872-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/block-wrappers-necessary-expected.txt:
              * editing/pasteboard/copy-paste-bidi-expected.txt:
              * editing/pasteboard/displaced-generic-placeholder-expected.txt:
              * editing/pasteboard/displaced-placeholder-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-4035648-fix-expected.txt:
              * editing/pasteboard/paste-4039777-fix-expected.txt:
              * editing/pasteboard/paste-line-endings-001-expected.txt:
              * editing/pasteboard/paste-line-endings-006-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-match-style-002-expected.txt:
              * editing/pasteboard/paste-pre-001-expected.txt:
              * editing/pasteboard/paste-pre-002-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-table-003-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-007-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/paste-text-011-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/pasteboard/paste-text-016-expected.txt:
              * editing/pasteboard/paste-text-017-expected.txt:
              * editing/pasteboard/paste-text-018-expected.txt:
              * editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/pasteboard/testcase-9507-expected.txt:
              * editing/pasteboard/undoable-fragment-removes-expected.txt:
              * editing/selection/expanding-selections-expected.txt:
              * editing/selection/expanding-selections2-expected.txt:
              * editing/selection/node-removal-1-expected.txt:
              * editing/selection/node-removal-2-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/triple-click-in-pre-expected.txt:
              * editing/style/apple-style-editable-mix-expected.txt:
              * editing/style/block-style-004-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/block-style-006-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/designmode-expected.txt:
              * editing/style/relative-font-size-change-001-expected.txt:
              * editing/style/relative-font-size-change-002-expected.txt:
              * editing/style/remove-underline-across-paragraph-expected.txt:
              * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-after-paragraph-expected.txt:
              * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-from-stylesheet-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/smoosh-styles-003-expected.txt:
              * editing/style/style-3681552-fix-001-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/style-3690704-fix-expected.txt:
              * editing/style/style-3998892-fix-expected.txt:
              * editing/style/style-boundary-001-expected.txt:
              * editing/style/style-boundary-003-expected.txt:
              * editing/style/style-boundary-004-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-003-expected.txt:
              * editing/undo/undo-misspellings-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/attributed-strings-expected.txt:
              * fast/forms/cursor-position-expected.txt:
              * fast/forms/drag-into-textarea-expected.txt:
              * fast/forms/input-appearance-maxlength-expected.txt:
              * fast/forms/input-paste-undo-expected.txt:
              * fast/forms/input-selection-restore-expected.txt:
              * fast/forms/input-text-paste-maxlength-expected.txt:
              * fast/forms/selection-functions-expected.txt:
              * fast/forms/text-field-setvalue-crash-expected.txt:
              * fast/forms/textarea-paste-newline-expected.txt:
      
      WebCore:
      
              Reviewed by thatcher
              
              Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete
              
              Fixes:
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6498>
              SelectionController's setters should notify delegates of selection changes
              
              Moved setSelection from Frame to SelectionController.
              I haven't moved any of the work that's done as a result of a 
              Selection change to SelectionController yet.
              Make fewer uses of SelectionControllers.  They're now only used for 
              the Frame's selection, the Page's drag caret, and functions that
              need to do Selection expansion.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Selection::getValueProperty):
              (KJS::Selection::toString):
              (KJS::SelectionFunc::callAsFunction):
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::advanceToNextMisspelling):
              (WebCore::FrameMac::dispatchCPPEvent):
              (WebCore::FrameMac::fontForSelection):
              (WebCore::FrameMac::baseWritingDirectionForSelectionStart):
              (WebCore::FrameMac::markMisspellingsInAdjacentWords):
              (WebCore::FrameMac::markMisspellings):
              (WebCore::FrameMac::respondToChangedSelection):
              (WebCore::FrameMac::shouldChangeSelection):
              (WebCore::FrameMac::shouldDeleteSelection):
              (WebCore::FrameMac::respondToChangedContents):
              * bridge/mac/PageMac.mm:
              (WebCore::Page::Page):
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
              (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
              (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
              (-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge isSelectionEditable]):
              (-[WebCoreFrameBridge isSelectionRichlyEditable]):
              (-[WebCoreFrameBridge selectionState]):
              (-[WebCoreFrameBridge deselectText]):
              (-[WebCoreFrameBridge selectedAttributedString]):
              (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
              (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]):
              (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
              (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
              (-[WebCoreFrameBridge selectedDOMRange]):
              (-[WebCoreFrameBridge selectNSRange:]):
              (-[WebCoreFrameBridge selectedNSRange]):
              (-[WebCoreFrameBridge selectionAffinity]):
              (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]):
              (-[WebCoreFrameBridge setSelectionToDragCaret]):
              (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
              (-[WebCoreFrameBridge moveDragCaretToPoint:]):
              (-[WebCoreFrameBridge removeDragCaret]):
              (-[WebCoreFrameBridge dragCaretDOMRange]):
              (-[WebCoreFrameBridge isDragCaretRichlyEditable]):
              (-[WebCoreFrameBridge editableDOMRangeForPoint:]):
              (-[WebCoreFrameBridge ensureSelectionVisible]):
              (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
              * bridge/win/PageWin.cpp:
              (WebCore::Page::Page):
              * dom/Document.cpp:
              (WebCore::Document::updateSelection):
              (WebCore::Document::clearSelectionIfNeeded):
              (WebCore::Document::notifyBeforeNodeRemoval):
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand):
              * editing/JSEditor.cpp:
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
              * editing/Selection.cpp:
              (WebCore::Selection::setBase):
              (WebCore::Selection::setExtent):
              * editing/Selection.h:
              (WebCore::Selection::extent):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              (WebCore::SelectionController::moveTo):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::nodeWillBeRemoved):
              (WebCore::SelectionController::modify):
              (WebCore::SelectionController::clear):
              (WebCore::SelectionController::setBase):
              (WebCore::SelectionController::setExtent):
              * editing/SelectionController.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::caretRect):
              * editing/VisiblePosition.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::selectedText):
              (WebCore::Frame::hasSelection):
              (WebCore::Frame::selectionController):
              (WebCore::Frame::dragCaretController):
              (WebCore::Frame::notifyRendererOfSelectionChange):
              (WebCore::Frame::invalidateSelection):
              (WebCore::Frame::clearCaretRectIfNeeded):
              (WebCore::Frame::setFocusNodeIfNeeded):
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::paintCaret):
              (WebCore::Frame::paintDragCaret):
              (WebCore::Frame::isPointInsideSelection):
              (WebCore::Frame::selectClosestWordFromMouseEvent):
              (WebCore::Frame::handleMousePressEventDoubleClick):
              (WebCore::Frame::handleMousePressEventTripleClick):
              (WebCore::Frame::handleMousePressEventSingleClick):
              (WebCore::Frame::handleMouseMoveEvent):
              (WebCore::Frame::handleMouseReleaseEvent):
              (WebCore::Frame::selectAll):
              (WebCore::Frame::selectContentsOfNode):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::shouldDeleteSelection):
              (WebCore::Frame::isSelectionInPasswordField):
              (WebCore::Frame::appliedEditing):
              (WebCore::Frame::unappliedEditing):
              (WebCore::Frame::reappliedEditing):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::applyStyle):
              (WebCore::Frame::applyParagraphStyle):
              (WebCore::Frame::selectionListState):
              (WebCore::Frame::selectionHasStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::selectFrameElementInParentIfFullySelected):
              (WebCore::Frame::currentForm):
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::centerSelectionInVisibleArea):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::findString):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * page/FrameView.cpp:
              (WebCore::FrameView::clear):
              * page/Page.cpp:
              (WebCore::Page::dragCaretController):
              * page/Page.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionStart):
              (WebCore::RenderTextControl::selectionEnd):
              (WebCore::RenderTextControl::setSelectionRange):
              (WebCore::RenderTextControl::selectionChanged):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      397edaa4
  10. 01 Sep, 2006 1 commit
    • adele's avatar
      Reviewed by John. · 8a8acfda
      adele authored
              - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10580
                Password: New secure text field allows non-Roman text entry
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode.
              (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
              * bridge/mac/FrameMac.h: ditto.
              * page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
              * page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a8acfda
  11. 31 Aug, 2006 2 commits
    • harrison's avatar
      Reviewed by Adele. · bb58767d
      harrison authored
              <rdar://problem/4708119> REGRESSION: Cannot observe an AXTextField element directly
      
              ... and most of
              <rdar://problem/4708022> REGRESSION: TextRange-based attributes are missing from text fields
              <rdar://problem/4709515> REGRESSION: Expose text areas
      
              Remaining work for those two bugs in new bugs:
      
              <rdar://problem/4712101> Support NSAccessibilityVisibleCharacterRangeAttribute for AXTextField and AXTextArea elements
              <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
              <rdar://problem/4712125> Support setting NSAccessibilitySelectedTextAttribute for AXTextField and AXTextArea elements
      
              * bridge/AXObjectCache.h:
              (WebCore::AXObjectCache::postNotificationToElement):
              * bridge/mac/AXObjectCacheMac.mm:
              (WebCore::AXObjectCache::postNotification):
              (WebCore::AXObjectCache::postNotificationToElement):
              Removed postNotificationToTopWebArea.
              postNotification now posts to input element or top web area, as appropriate.
              postNotificationToElement posts to the specified element itself.
              
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::respondToChangedContents):
              Take a selection.  Pass the starting position's renderer to postNotification so that postNotification can post to the appropriate input element, if any.
              
              * bridge/mac/WebCoreAXObject.h:
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject isWebArea]):
              (-[WebCoreAXObject isAnchor]):
              (-[WebCoreAXObject isTextRange]):
              New convenience methods.
              
              (-[WebCoreAXObject role]):
              (-[WebCoreAXObject roleDescription])        
              (-[WebCoreAXObject value]):
              (-[WebCoreAXObject accessibilityDescription]):
              Support AXTextField and AXTextArea.
      
              (-[WebCoreAXObject accessibilityShouldUseUniqueId]):
              Register AXTextField and AXTextArea elements so notifications to them can be observed.
              
              (-[WebCoreAXObject accessibilityIsIgnored]):
              Use new convenience method isWebArea.
      
              (-[WebCoreAXObject accessibilityAttributeNames]):
              Simplify the array creation.
              Add text range support.
             
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              Add text range support.
             
              (-[WebCoreAXObject canSetFocusAttribute]):
              (-[WebCoreAXObject canSetValueAttribute]):
              (-[WebCoreAXObject canSetTextRangeAttributes]):
              New convenience methods.
              
              (-[WebCoreAXObject accessibilityIsAttributeSettable:]):
              (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
              Add text range support.
      
              (-[WebCoreAXObject observableObject]):
              New to locate text field or text area to notify.
              
              * dom/Document.cpp:
              (WebCore::Document::updateSelection):
              Post AXSelectedTextChanged notification with new selection's start node.
              postNotification will send it to the input element, if there is one, or the top WebArea.
              
              (WebCore::Document::implicitClose):
              Use postNotificationToElement now that it acts like the old postNotification.
              
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::appliedEditing):
              (WebCore::Frame::unappliedEditing):
              (WebCore::Frame::reappliedEditing):
              Pass the selection of interest to respondToChangedContents.
              
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              Use postNotificationToElement now that it acts like the old postNotification.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb58767d
    • adele's avatar
      WebCore: · d51c0cfd
      adele authored
              Reviewed by Darin.
      
              WebCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
              Password: Disallow Spelling, Font, Speech, and Writing Direction context menu
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionInPasswordField]): Added.
              * page/Frame.cpp: (WebCore::Frame::isSelectionInPasswordField): Added.
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by Darin.
      
              WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
              Password: Disallow Spelling, Font, Speech, and Writing Direction context menu
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
                Check that the selection isn't in a password field before adding these items to the default editing context menu.
                    Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font...
      d51c0cfd
  12. 30 Aug, 2006 2 commits
    • adele's avatar
      WebCore: · 9845beda
      adele authored
              Reviewed by Hyatt.
      
              WebCore part of fix for  http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
              Enable secure input mode for new password fields
      
              * WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
              * platform/mac/WebCoreSystemInterface.h: ditto.
              * platform/mac/WebCoreSystemInterface.mm: ditto.
      
              * page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput.
              (WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry.
              (WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
              * page/...
      9845beda
    • adele's avatar
      WebCore: · e641062a
      adele authored
              Reviewed by Darin.
      
              - WebCore part of fix for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
              Disallow copy from new password fields
      
              * page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
              * page/Frame.h: Added mayCopy.
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag.
              (WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method.  This also checks mayCopy now.
              (WebCore::FrameMac::mayDHTMLCopy): ditto.
              (WebCore::FrameMac::tryDHTMLCut): ditto.
              (WebCore::FrameMac::tryDHTMLCopy): ditto.
              (WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function.
              (WebCore::FrameMac::tryDHTMLPaste): ditto.
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge mayCopy]): Call...
      e641062a
  13. 24 Aug, 2006 1 commit
    • darin's avatar
      LayoutTests: · 35384069
      darin authored
              Reviewed by Justin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
                REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
      
              * fast/forms/drag-into-textarea-expected.txt: Added.
              * fast/forms/drag-into-textarea.html: Added.
      
      WebCore:
      
              Reviewed by Justin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
                REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
              - eliminate the EditCommandPtr class from editing; use PassRefPtr and RefPtr instead
              - other editing-related cleanup
      
              Test: fast/forms/drag-into-textarea.html
      
              * bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
              * bridge/win/FrameWin.h: Ditto.
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto.
              (WebCore::FrameMac::registerCommandForUndo): Ditto.
              (WebCore::FrameMac::registerCommandForRedo): Ditto.
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter.
              (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto.
              (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.
      
              * editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child
              parameter to be a PassRefPtr. Reversed order of child and parent parameters.
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
              (WebCore::AppendNodeCommand::doApply): Ditto.
              (WebCore::AppendNodeCommand::doUnapply): Ditto.
      
              * editing/ApplyStyleCommand.h: Removed document parameter from constructor.
              * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.
      
              * editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
              * editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here.
              (WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly
              since setEndingSelection is no longer overloaded for Position.
      
              * editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from
              a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it
              m_commands and made both doUnapply and doReapply private.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands.
              (WebCore::CompositeEditCommand::doReapply): Ditto.
              (WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up
              starting and ending selection -- now done inside setParent. Rewrote to use m_commands.
              (WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::applyStyledElement): Ditto.
              (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
              (WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto.
              (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
              (WebCore::CompositeEditCommand::appendNode): Ditto.
              (WebCore::CompositeEditCommand::removeNode): Ditto.
              (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
              (WebCore::CompositeEditCommand::splitTextNode): Ditto.
              (WebCore::CompositeEditCommand::splitElement): Ditto.
              (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
              (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
              (WebCore::CompositeEditCommand::inputText): Ditto.
              (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
              (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
              (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
              (WebCore::CompositeEditCommand::deleteSelection): Ditto.
              (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
              (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code
              would not remove an empty attribute -- will not come up in practice, but wrong in theory.
              (WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
              (WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop.
              (WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a
              Selection explicitly since setEndingSelection is no longer overloaded for Position.
              (WebCore::createBlockPlaceholderElement): Collapsed this code so that the
              block placeholder class string is no longer spread across multiple functions.
              Perhaps we can get rid of this altogether at some point.
      
              * editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor.
              Also removed unneeded destructor.
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.
      
              * editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.
      
              * editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(),
              and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected
              and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected.
              Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(),
              endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which
              are needed so we can determine which editable elements an editing operation affects. Changed setParent()
              and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added
              applyCommand() function that's convenient to use on a newly-created command.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting
              and ending root editable elements.
              (WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed
              code to assert and set m_start. Eliminated use of EditCommandPtr.
              (WebCore::EditCommand::unapply): Ditto.
              (WebCore::EditCommand::reapply): Ditto.
              (WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this
              not change the starting selection of the parent unless this is the first command in the parent -- didn't
              make sense the way it was.
              (WebCore::EditCommand::setEndingSelection): Changed to set root editable element too.
              (WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child
              based on the ending selection of the parent, formerly done by callers.
              (WebCore::applyCommand): Added.
      
              * editing/FormatBlockCommand.h: Tweaked formatting.
              * editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
              * editing/InsertLineBreakCommand.h: Ditto.
              * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr.
              (WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum.
              (WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.
      
              * editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.
      
              * editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off
              the constants.
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::InsertListCommand): Ditto.
              (WebCore::InsertListCommand::doApply): Ditto.
      
              * editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor
              and changed the parameter of the node to insert to a PassRefPtr.
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
      
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.
      
              * editing/InsertTextCommand.h: Changed insertTab to take const Position&.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Ditto.
              (WebCore::InsertTextCommand::insertTab): Ditto.
      
              * editing/JSEditor.h: Tweaked formatting and names.
              * editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.
      
              * editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
              * editing/MergeIdenticalElementsCommand.h: Ditto.
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.
      
              * editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of
              IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers.
              (WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
              Changed to use Type instead of EListType.
              (WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers.
              (WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel.
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto.
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              Changed to not use EditCommandPtr.
              (WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers.
              (WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel.
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto.
              (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use
              EditCommandPtr.
      
              * editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment
              parameter to be a PassRefPtr.
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto.
              (WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.
      
              * editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
              * editing/RebalanceWhitespaceCommand.cpp:
              (WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto.
              (WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.
      
              * editing/RemoveCSSPropertyCommand.h: Tweaked formatting.
      
              * editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.
      
              * editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.
      
              * editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
      
              * editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
              (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto.
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
      
              * editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than
              a macro. Added constructors that take visible positions. Changed setBase and
              setExtent to take const Position& for better efficiency.
              * editing/Selection.cpp:
              (WebCore::Selection::Selection): Removed unnecessary double initialization of m_state
              and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.
      
              * editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.
      
              * editing/SplitElementCommand.h: Removed unnneeded document parameter.
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand): Ditto.
      
              * editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.
      
              * editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.
      
              * editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*.
              Renamed openForMoveTyping() with isOpenForMoreTyping().
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
              (WebCore::TypingCommand::insertText): Ditto.
              (WebCore::TypingCommand::insertLineBreak): Ditto.
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto.
              (WebCore::TypingCommand::insertParagraphSeparator): Ditto.
              (WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto.
              (WebCore::TypingCommand::closeTyping): Ditto.
              (WebCore::TypingCommand::typingAddedToOpenCommand): Ditto.
              (WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.
      
              * editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.
      
              * editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of
              unsigned short.
      
              * page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed
              appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(),
              and registerCommandForRedo() to take PassRefPtr<EditCommand>.
              * page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
              * page/Frame.cpp:
              (WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand.
              (WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function
              from Selection to simplify the code.
              (WebCore::Frame::selectAll): Ditto.
              (WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand.
              (WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to
              both of the root editable elements involved in a change -- the start selection
              might be in a different element than the end selection.
              (WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents,
              and to do it before setting the ending selection. Also update to use PassRefPtr instead
              of EditCommandPtr and change the order of setting m_lastEditCommand since passing it
              to registerCommandForUndo will take ownership and set it to 0.
              (WebCore::Frame::unappliedEditing): Ditto.
              (WebCore::Frame::reappliedEditing): Ditto.
              (WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr.
              (WebCore::Frame::applyStyle): Ditto.
              (WebCore::Frame::applyParagraphStyle): Ditto.
      
              * platform/gdk/FrameGdk.h: Updated for above changes.
              * platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
              * platform/win/TemporaryLinkStubs.cpp: Updated for above changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35384069
  14. 18 Aug, 2006 1 commit
  15. 29 Jul, 2006 1 commit
    • weinig's avatar
      JavaScriptCore: · ab5f09e0
      weinig authored
              Reviewed by Darin.
      
              - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
                Adopt pedantic changes from the Unity project to improve 
                cross-compiler compatibility
      
                Changes include:
                * Removing trailing semicolon from namespace braces.
                * Removing trailing comma from last enum declaration.
                * Updating to match style guidelines.
                * Adding missing newline to the end of the file.
                * Turning on gcc warning for missing newline at the end of a source file
                  (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
                * Alphabetical sorting of Xcode source list files. 
                * Replace use of non-portable variable-size array with Vector.
                * Use C-style comments instead of C++ comments in files that might
                  be included by either C or C++ files.
      
              * API/JSCallbackConstructor.cpp:
              (KJS::JSCallbackConstructor::construct):
              * API/JSCallbackF...
      ab5f09e0
  16. 17 Jul, 2006 1 commit
    • tomernic's avatar
      WebCore: · f917f147
      tomernic authored
              Reviewed by Maciej.
      
              <rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
              by script
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setProhibitsScrolling:]):
              * page/Frame.cpp:
              (WebCore::Frame::prohibitsScrolling):
              (WebCore::Frame::setProhibitsScrolling):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollPointRecursively):
              (WebCore::FrameView::setContentsPos):
              * page/FrameView.h:
              * platform/ScrollView.h:
      
      WebKit:
      
              Reviewed by Maciej.
      
              <rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
              by script
      
              * WebView/WebViewPrivate.h:
              * WebView/WebView.m:
              (-[WebView setProhibitsMainFrameScrolling:]):
              New method.  Prohibits scrolling in the WebView's main frame.  Used to "lock" a WebView to a specific
              scroll position.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f917f147
  17. 14 Jul, 2006 1 commit
    • adele's avatar
      Reviewed by Darin. · 898672a6
      adele authored
              - Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
      
              * page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
              * bridge/mac/FrameMac.h: ditto.
              * bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter
              if the input manager says there's marked text.  I added this code for all text field paths.  For widgets, WebCoreTextField.mm
              has code to deal with this case.  But as we convert search, password, and isindex, they will need to do this check too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      898672a6
  18. 13 Jul, 2006 1 commit
    • harrison's avatar
      LayoutTests: · 0ddb977a
      harrison authored
              Reviewed by Justin and Levi.
      
              <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
      
              * editing/deleting/delete-by-word-001-expected.checksum: Added.
              * editing/deleting/delete-by-word-001-expected.png: Added.
              * editing/deleting/delete-by-word-001-expected.txt: Added.
              * editing/deleting/delete-by-word-001.html: Added.
              * editing/deleting/delete-by-word-002-expected.checksum: Added.
              * editing/deleting/delete-by-word-002-expected.png: Added.
              * editing/deleting/delete-by-word-002-expected.txt: Added.
              * editing/deleting/delete-by-word-002.html: Added.
      
      WebCore:
      
              Reviewed by Justin and Levi.
      
              <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
      
              * Tests:
              editing/deleting/delete-by-word-001.html
              editing/deleting/delete-by-word-002.html
      
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::doApply):
              * editing/TypingCommand.h:
              Delete and forward delete to use specified granularity.
              Undo of delete and forward delete to select what had been deleted (non-char granularity only).
              
              * page/Frame.cpp:
              (WebCore::Frame::setSelection):
              Close typing and end style even if selection is not changing.
              * page/Frame.h:
              Remove unused setSelection parameter keepTypingStyle.
      
      WebKit:
      
              Reviewed by Justin and Levi.
      
              <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
      
              * Tests:
              editing/deleting/delete-by-word-001.html
              editing/deleting/delete-by-word-002.html
      
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ddb977a
  19. 09 Jul, 2006 3 commits
    • darin's avatar
      Reviewed by Tim Hatcher. · f4b05b29
      darin authored
              - put more into the WebCore namespace
              - removed unused code for plain text fields
      
              Put more classes, class templates, enums, functions, and constants into
              the WebCore namespace, including all the headers in the platform directory.
      
              Removed lots of unneeded "WebCore::" qualifiers and "using" directives.
      
              Added some "WebCore::" qualifiers in a few places.
      
              Removed "uses WebCore::" in headers that we said we'd remove "when
              everything is in the WebCore namespace".
      
              * bindings/js/JSDOMParser.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/JSXSLTProcessor.cpp:
              * bindings/js/kjs_binding.cpp:
              * bindings/js/kjs_css.cpp:
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_proxy.h:
              * bindings/js/kjs_window.h:
              * bindings/objc/DOM.mm:
              * bridge/History.h:
              * bridge/JavaAppletWidget.h:
              * bridge/mac/FormDataMac.h:
              * bridge/mac/FormDataMac.mm:
              * bridge/mac/WebCoreAXObject.mm:
              * bridge/mac/WebCoreEncodings.mm:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreIconDatabaseBridge.mm:
              * bridge/mac/WebCorePageState.h:
              * bridge/mac/WebCoreScriptDebugger.mm:
              * bridge/mac/WebCoreSettings.h:
              * css/CSSGrammar.y:
              * css/CSSPageRule.cpp:
              * css/CSSPageRule.h:
              * css/MediaList.cpp:
              * css/cssstyleselector.h:
              * dom/Clipboard.h:
              * dom/Document.cpp:
              * dom/Document.h:
              * dom/EventTargetNode.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * dom/Position.h:
              * dom/Range.cpp:
              * dom/XMLTokenizer.cpp:
              * editing/AppendNodeCommand.h:
              * editing/ApplyStyleCommand.cpp:
              * editing/BreakBlockquoteCommand.cpp:
              * editing/BreakBlockquoteCommand.h:
              * editing/CompositeEditCommand.cpp:
              * editing/CompositeEditCommand.h:
              * editing/CreateLinkCommand.h:
              * editing/DeleteFromTextNodeCommand.h:
              * editing/DeleteSelectionCommand.h:
              * editing/FormatBlockCommand.h:
              * editing/HTMLInterchange.cpp:
              * editing/HTMLInterchange.h:
              * editing/IndentOutdentCommand.h:
              * editing/InsertIntoTextNodeCommand.h:
              * editing/InsertLineBreakCommand.h:
              * editing/InsertListCommand.h:
              * editing/InsertNodeBeforeCommand.h:
              * editing/InsertTextCommand.cpp:
              * editing/InsertTextCommand.h:
              * editing/JSEditor.cpp:
              * editing/JSEditor.h:
              * editing/JoinTextNodesCommand.h:
              * editing/MergeIdenticalElementsCommand.cpp:
              * editing/MergeIdenticalElementsCommand.h:
              * editing/ModifySelectionListLevel.h:
              * editing/MoveSelectionCommand.h:
              * editing/RebalanceWhitespaceCommand.h:
              * editing/RemoveNodeAttributeCommand.h:
              * editing/RemoveNodeCommand.h:
              * editing/RemoveNodePreservingChildrenCommand.h:
              * editing/ReplaceSelectionCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * editing/SplitElementCommand.cpp:
              * editing/SplitElementCommand.h:
              * editing/SplitTextNodeCommand.cpp:
              * editing/SplitTextNodeCommand.h:
              * editing/SplitTextNodeContainingElementCommand.h:
              * editing/TypingCommand.cpp:
              * editing/TypingCommand.h:
              * editing/UnlinkCommand.h:
              * editing/VisiblePosition.cpp:
              * editing/WrapContentsInDummySpanCommand.cpp:
              * editing/WrapContentsInDummySpanCommand.h:
              * editing/markup.cpp:
              * editing/markup.h:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLBodyElement.cpp:
              * html/HTMLButtonElement.h:
              * html/HTMLCollection.h:
              * html/HTMLDocument.h:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFormElement.cpp:
              * html/HTMLFormElement.h:
              * html/HTMLFrameElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLKeygenElement.cpp:
              * html/HTMLLabelElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLObjectElement.h:
              * html/HTMLTableElement.cpp:
              * html/HTMLTablePartElement.cpp:
              * icon/IconDatabase.h:
              * kcanvas/KCanvasPath.h:
              * kcanvas/KCanvasResources.cpp:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              * kcanvas/KCanvasTreeDebug.h:
              * kcanvas/RenderSVGContainer.cpp:
              * kcanvas/RenderSVGText.h:
              * kcanvas/device/KRenderingPaintServer.h:
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerSolid.cpp:
              * ksvg2/misc/SVGImageLoader.cpp:
              * ksvg2/svg/SVGElement.cpp:
              * ksvg2/svg/SVGElement.h:
              * ksvg2/svg/SVGForeignObjectElement.cpp:
              * ksvg2/svg/SVGForeignObjectElement.h:
              * ksvg2/svg/SVGImageElement.cpp:
              * ksvg2/svg/SVGPoint.h:
              * ksvg2/svg/SVGStylable.h:
              * ksvg2/svg/SVGTRefElement.cpp:
              * ksvg2/svg/SVGTRefElement.h:
              * ksvg2/svg/SVGTSpanElement.cpp:
              * ksvg2/svg/SVGTSpanElement.h:
              * ksvg2/svg/SVGTextElement.h:
              * ksvg2/svg/svgpathparser.cpp:
              * ksvg2/svg/svgpathparser.h:
              * loader/Cache.h:
              * loader/DocLoader.h:
              * loader/LoaderFunctions.h:
              * loader/mac/LoaderFunctionsMac.mm:
              * page/Frame.h:
              * page/FrameView.h:
              * page/Page.h:
              * page/Settings.h:
              * platform/AffineTransform.cpp:
              * platform/AffineTransform.h:
              * platform/Arena.cpp:
              * platform/Arena.h:
              * platform/CookieJar.h:
              * platform/DeprecatedCString.cpp:
              * platform/DeprecatedCString.h:
              * platform/DeprecatedPtrList.h:
              * platform/DeprecatedPtrListImpl.cpp:
              * platform/DeprecatedPtrListImpl.h:
              * platform/DeprecatedPtrQueue.h:
              * platform/DeprecatedString.cpp:
              * platform/DeprecatedString.h:
              * platform/DeprecatedStringList.cpp:
              * platform/DeprecatedStringList.h:
              * platform/DeprecatedValueList.h:
              * platform/DeprecatedValueListImpl.cpp:
              * platform/DeprecatedValueListImpl.h:
              * platform/FileButton.h:
              * platform/FloatPoint.h:
              * platform/FloatRect.h:
              * platform/FloatSize.h:
              * platform/FontData.h:
              * platform/FontFallbackList.h:
              * platform/GraphicsContext.h:
              * platform/IntPoint.h:
              * platform/IntRect.h:
              * platform/IntSize.h:
              * platform/KURL.cpp:
              * platform/KURL.h:
              * platform/ListBox.h:
              * platform/Logging.cpp:
              * platform/Logging.h:
              * platform/Pen.h:
              * platform/PopUpButton.h:
              * platform/RegularExpression.cpp:
              * platform/RegularExpression.h:
              * platform/SSLKeyGenerator.h:
              * platform/ScrollBar.h:
              * platform/SegmentedString.h:
              * platform/Shared.h:
              * platform/Slider.h:
              * platform/StringImpl.h:
              * platform/TextBox.h:
              * platform/TextField.h:
              * platform/TextStream.cpp:
              * platform/TextStream.h:
              * platform/TransferJob.h:
              * platform/TransferJobClient.h:
              * platform/Widget.h:
              * platform/cg/AffineTransformCG.cpp:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/DeprecatedStringListMac.mm:
              * platform/mac/FontCacheMac.mm:
              * platform/mac/KURLMac.mm:
              * platform/mac/ListBoxMac.mm:
              * platform/mac/PopUpButtonMac.mm:
              * platform/mac/SSLKeyGeneratorMac.mm:
              * platform/mac/TextBoxMac.mm:
              * platform/mac/TextFieldMac.mm:
              * platform/mac/WebCoreTextArea.h:
              * platform/mac/WebCoreTextArea.mm:
              * platform/mac/WebCoreTextField.h:
              * platform/mac/WebCoreTextField.mm:
              * rendering/DeprecatedRenderSelect.h:
              * rendering/RenderArena.cpp:
              * rendering/RenderArena.h:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderContainer.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderFlow.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLineEdit.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              * rendering/RenderStyle.h:
              * rendering/RenderText.cpp:
              * rendering/RenderTextFragment.cpp:
              * rendering/RenderTheme.h:
              * rendering/RenderTreeAsText.cpp:
              * rendering/RenderTreeAsText.h:
              * rendering/RenderView.h:
              * rendering/bidi.h:
              * xml/XSLStyleSheet.cpp:
              * xml/XSLTProcessor.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b05b29
    • darin's avatar
      - move all but the last 12 files out of kwq directory · 3e865649
      darin authored
              - removed a few unused source files I discovered
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Update for new file locations.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * bridge/mac/FrameMac.mm:
              * dom/Element.h:
              * html/HTMLImageLoader.cpp:
              * loader/Cache.cpp:
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              * loader/CachedImage.h:
              * loader/CachedObject.h:
              * loader/CachedScript.cpp:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              * loader/DocLoader.h:
              * page/Frame.cpp:
              * page/Frame.h:
              * page/FramePrivate.h:
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/win/TemporaryLinkStubs.cpp:
              * rendering/DeprecatedSlider.cpp:
              * rendering/RenderObject.h:
              * xml/xmlhttprequest.cpp:
              Updated includes as needed for file location changes. Changed
              CachePolicy uses to match new filename and enum names.
      
              * loader/CachedResource.cpp: Removed.
              * loader/CachedResource.h: Removed.
              * loader/CachedResourceClient.h: Removed.
              * loader/CachedResourceClientWalker.cpp: Removed.
              * loader/CachedResourceClientWalker.h: Removed.
              The above files were checked in by accident a while back. The rename of
              CachedObject to CachedResource is now reflected in do-webcore-rename,
              and will be done soon.
      
              * kwq/AffineTransform.cpp: Removed.
              * kwq/AffineTransform.h: Removed.
              * kwq/CacheControl.h: Removed.
              * kwq/DeprecatedPtrQueue.h: Removed.
              * kwq/FileButton.h: Removed.
              * kwq/FileButton.mm: Removed.
              * kwq/ListBox.h: Removed.
              * kwq/ListBox.mm: Removed.
              * kwq/LoaderFunctions.h: Removed.
              * kwq/LoaderFunctions.mm: Removed.
              * kwq/PopUpButton.h: Removed.
              * kwq/PopUpButton.mm: Removed.
              * kwq/SSLKeyGenerator.h: Removed.
              * kwq/SSLKeyGenerator.mm: Removed.
              * kwq/Settings.h: Removed.
              * kwq/TextBox.h: Removed.
              * kwq/TextBox.mm: Removed.
              * kwq/TextField.h: Removed.
              * kwq/TextField.mm: Removed.
              * kwq/WebCoreScrollBar.h: Removed.
              * kwq/WebCoreScrollBar.mm: Removed.
              * kwq/WebCoreSlider.h: Removed.
              * kwq/WebCoreSlider.mm: Removed.
      
              * loader/CachePolicy.h: Added.
              * loader/LoaderFunctions.h: Added.
      
              * loader/mac/LoaderFunctionsMac.mm: Added.
      
              * page/Settings.h: Added.
      
              * platform/AffineTransform.cpp: Added.
              * platform/AffineTransform.h: Added.
              * platform/DeprecatedPtrQueue.h: Added.
              * platform/FileButton.h: Added.
              * platform/ListBox.h: Added.
              * platform/PopUpButton.h: Added.
              * platform/SSLKeyGenerator.h: Added.
              * platform/ScrollBar.h: Added.
              * platform/Slider.h: Added.
              * platform/TextBox.h: Added.
              * platform/TextField.h: Added.
      
              * platform/cg/AffineTransformCG.cpp: Added.
      
              * platform/mac/FileButtonMac.mm: Added.
              * platform/mac/ListBoxMac.mm: Added.
              * platform/mac/PopUpButtonMac.mm: Added.
              * platform/mac/SSLKeyGeneratorMac.mm: Added.
              * platform/mac/ScrollBarMac.mm: Added.
              * platform/mac/ScrollBarMac.mm: Added.
              * platform/mac/SliderMac.mm: Added.
              * platform/mac/SliderMac.mm: Added.
              * platform/mac/TextBoxMac.mm: Added.
              * platform/mac/TextFieldMac.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e865649
    • darin's avatar
      Rubber stamped by Maciej (kinda). · b53ebdcb
      darin authored
              - did the next pass of renaming (used do-webcore-rename script)
                this takes care of most of the remaining KWQ names (almost all)
      
              * WebCore+SVG/DOMList.h:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_window.cpp:
              * bindings/objc/DOMHTML.mm:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * bridge/mac/WebCoreSettings.h:
              * bridge/mac/WebCoreSettings.mm:
              * bridge/win/FrameWin.cpp:
              * css/CSSPrimitiveValue.cpp:
              * css/CSSValueKeywords.in:
              * css/MediaQueryEvaluator.cpp:
              * css/cssparser.cpp:
              * css/cssstyleselector.cpp:
              * css/cssstyleselector.h:
              * dom/CharacterData.cpp:
              * dom/CharacterData.h:
              * dom/Document.cpp:
              * dom/Element.cpp:
              * dom/Element.h:
              * dom/EventTargetNode.cpp:
              * dom/EventTargetNode.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * dom/Position.cpp:
              * dom/ProcessingInstruction.cpp:
              * dom/QualifiedName.cpp:
              * dom/QualifiedName.h:
              * dom/XMLTokenizer.cpp: Added.
              * dom/xml_tokenizer.cpp: Removed.
              * dom/xml_tokenizer.h: Removed.
              * editing/EditAction.h:
              * editing/HTMLInterchange.cpp:
              * editing/HTMLInterchange.h:
              * editing/Selection.h:
              * editing/SelectionController.h:
              * editing/TextAffinity.h:
              * editing/TextIterator.cpp:
              * editing/TextIterator.h:
              * editing/VisiblePosition.h:
              * editing/htmlediting.cpp:
              * editing/markup.cpp:
              * editing/markup.h:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * html/HTMLDocument.cpp:
              * html/HTMLFontElement.cpp:
              * html/HTMLInputElement.cpp:
              * html/HTMLKeygenElement.cpp:
              * html/HTMLSelectElement.h:
              * html/HTMLTextAreaElement.cpp:
              * html/HTMLTextFieldInnerElement.cpp:
              * html/HTMLTokenizer.cpp:
              * html/HTMLTokenizer.h:
              * kcanvas/KCanvasContainer.cpp: Removed.
              * kcanvas/KCanvasContainer.h: Removed.
              * kcanvas/KCanvasCreator.cpp:
              * kcanvas/KCanvasFilters.cpp:
              * kcanvas/KCanvasFilters.h:
              * kcanvas/KCanvasMatrix.cpp:
              * kcanvas/KCanvasMatrix.h:
              * kcanvas/KCanvasPath.cpp:
              * kcanvas/KCanvasPath.h:
              * kcanvas/KCanvasResources.cpp:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              * kcanvas/KCanvasTreeDebug.h:
              * kcanvas/RenderForeignObject.cpp:
              * kcanvas/RenderForeignObject.h:
              * kcanvas/RenderPath.cpp:
              * kcanvas/RenderPath.h:
              * kcanvas/RenderSVGContainer.cpp: Added.
              * kcanvas/RenderSVGContainer.h: Added.
              * kcanvas/RenderSVGImage.cpp:
              * kcanvas/RenderSVGImage.h:
              * kcanvas/RenderSVGText.cpp:
              * kcanvas/RenderSVGText.h:
              * kcanvas/device/KRenderingPaintServer.h:
              * kcanvas/device/KRenderingPaintServerGradient.cpp:
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerPattern.cpp:
              * kcanvas/device/KRenderingPaintServerPattern.h:
              * kcanvas/device/KRenderingPaintServerSolid.cpp:
              * kcanvas/device/KRenderingPaintServerSolid.h:
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              * kcanvas/device/quartz/KCanvasItemQuartz.h:
              * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              * ksvg2/css/CSSValueKeywords.in:
              * ksvg2/css/SVGRenderStyleDefs.cpp:
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              * ksvg2/misc/KSVGTimeScheduler.cpp:
              * ksvg2/svg/SVGAElement.cpp:
              * ksvg2/svg/SVGAnimateTransformElement.cpp:
              * ksvg2/svg/SVGAnimateTransformElement.h:
              * ksvg2/svg/SVGGElement.cpp:
              * ksvg2/svg/SVGHelper.cpp:
              * ksvg2/svg/SVGHelper.h:
              * ksvg2/svg/SVGImageElement.cpp:
              * ksvg2/svg/SVGLinearGradientElement.cpp:
              * ksvg2/svg/SVGMarkerElement.cpp:
              * ksvg2/svg/SVGMaskElement.cpp:
              * ksvg2/svg/SVGMatrix.cpp:
              * ksvg2/svg/SVGMatrix.h:
              * ksvg2/svg/SVGPatternElement.cpp:
              * ksvg2/svg/SVGRadialGradientElement.cpp:
              * ksvg2/svg/SVGSVGElement.cpp:
              * ksvg2/svg/SVGStyledElement.h:
              * ksvg2/svg/SVGStyledTransformableElement.cpp:
              * ksvg2/svg/SVGStyledTransformableElement.h:
              * ksvg2/svg/SVGSwitchElement.cpp:
              * ksvg2/svg/SVGTextElement.cpp:
              * ksvg2/svg/SVGTransformable.h:
              * ksvg2/svg/SVGUseElement.cpp:
              * kwq/AffineTransform.cpp: Added.
              * kwq/AffineTransform.h: Added.
              * kwq/DeprecatedCString.cpp: Added.
              * kwq/DeprecatedCString.h: Added.
              * kwq/DeprecatedPtrQueue.h: Added.
              * kwq/FileButton.h: Added.
              * kwq/FileButton.mm: Added.
              * kwq/FormDataMac.mm: Added.
              * kwq/KWQCString.cpp: Removed.
              * kwq/KWQCString.h: Removed.
              * kwq/KWQComboBox.h: Removed.
              * kwq/KWQComboBox.mm: Removed.
              * kwq/KWQEditCommand.h: Removed.
              * kwq/KWQEditCommand.mm: Removed.
              * kwq/KWQFileButton.h: Removed.
              * kwq/KWQFileButton.mm: Removed.
              * kwq/KWQFormData.h: Removed.
              * kwq/KWQFormData.mm: Removed.
              * kwq/KWQKHTMLSettings.h: Removed.
              * kwq/KWQKIOGlobal.h: Removed.
              * kwq/KWQKSSLKeyGen.h: Removed.
              * kwq/KWQKSSLKeyGen.mm: Removed.
              * kwq/KWQLineEdit.h: Removed.
              * kwq/KWQLineEdit.mm: Removed.
              * kwq/KWQListBox.h: Removed.
              * kwq/KWQListBox.mm: Removed.
              * kwq/KWQLoader.h: Removed.
              * kwq/KWQLoader.mm: Removed.
              * kwq/KWQPageState.h: Removed.
              * kwq/KWQPageState.mm: Removed.
              * kwq/KWQPtrQueue.h: Removed.
              * kwq/KWQResourceLoader.h: Removed.
              * kwq/KWQResourceLoader.mm: Removed.
              * kwq/KWQScrollBar.h: Removed.
              * kwq/KWQScrollBar.mm: Removed.
              * kwq/KWQSlider.h: Removed.
              * kwq/KWQSlider.mm: Removed.
              * kwq/KWQTextEdit.h: Removed.
              * kwq/KWQTextEdit.mm: Removed.
              * kwq/KWQTextStream.cpp: Removed.
              * kwq/KWQTextStream.h: Removed.
              * kwq/KWQWMatrix.cpp: Removed.
              * kwq/KWQWMatrix.h: Removed.
              * kwq/ListBox.h: Added.
              * kwq/ListBox.mm: Added.
              * kwq/LoaderFunctions.h: Added.
              * kwq/LoaderFunctions.mm: Added.
              * kwq/PopUpButton.h: Added.
              * kwq/PopUpButton.mm: Added.
              * kwq/SSLKeyGenerator.h: Added.
              * kwq/SSLKeyGenerator.mm: Added.
              * kwq/Settings.h: Added.
              * kwq/TextBox.h: Added.
              * kwq/TextBox.mm: Added.
              * kwq/TextField.h: Added.
              * kwq/TextField.mm: Added.
              * kwq/TextStream.cpp: Added.
              * kwq/TextStream.h: Added.
              * kwq/WebCoreEditCommand.h: Added.
              * kwq/WebCoreEditCommand.mm: Added.
              * kwq/WebCorePageState.h: Added.
              * kwq/WebCorePageState.mm: Added.
              * kwq/WebCoreResourceLoaderImp.h: Added.
              * kwq/WebCoreResourceLoaderImp.mm: Added.
              * kwq/WebCoreScrollBar.h: Added.
              * kwq/WebCoreScrollBar.mm: Added.
              * kwq/WebCoreSlider.h: Added.
              * kwq/WebCoreSlider.mm: Added.
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedImage.cpp:
              * loader/CachedObject.h:
              * loader/CachedObjectClientWalker.h:
              * loader/CachedResource.h:
              * loader/CachedResourceClientWalker.h:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.h:
              * loader/Decoder.h:
              * loader/DocLoader.cpp:
              * loader/DocLoader.h:
              * loader/FormData.h:
              * loader/ImageDocument.cpp:
              * loader/PluginDocument.cpp:
              * loader/TextDocument.cpp:
              * loader/loader.cpp:
              * loader/loader.h:
              * page/Frame.cpp:
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/Page.cpp:
              * page/Page.h:
              * platform/DeprecatedPtrList.h:
              * platform/DeprecatedPtrListImpl.cpp:
              * platform/DeprecatedPtrListImpl.h:
              * platform/DeprecatedString.cpp:
              * platform/DeprecatedString.h:
              * platform/DeprecatedStringList.cpp:
              * platform/DeprecatedStringList.h:
              * platform/DeprecatedValueList.h:
              * platform/DeprecatedValueListImpl.cpp:
              * platform/DeprecatedValueListImpl.h:
              * platform/FloatSize.h:
              * platform/Font.cpp:
              * platform/KURL.cpp:
              * platform/RegularExpression.cpp:
              * platform/RegularExpression.h:
              * platform/SegmentedString.h:
              * platform/StreamingTextDecoder.cpp:
              * platform/String.cpp:
              * platform/StringImpl.cpp:
              * platform/TextEncoding.cpp:
              * platform/TransferJob.cpp:
              * platform/TransferJob.h:
              * platform/TransferJobInternal.h:
              * platform/gdk/FrameGdk.cpp:
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/CursorMac.mm:
              * platform/mac/DeprecatedStringMac.mm: Added.
              * platform/mac/FontCacheMac.mm:
              * platform/mac/FontMac.mm:
              * platform/mac/FoundationExtras.h:
              * platform/mac/ImageMac.mm:
              * platform/mac/KURLMac.mm:
              * platform/mac/MouseEventMac.mm: Removed.
              * platform/mac/QStringListMac.mm: Removed.
              * platform/mac/QStringMac.mm: Removed.
              * platform/mac/TransferJobMac.mm:
              * platform/mac/WebCoreTextArea.h:
              * platform/mac/WebCoreTextArea.mm:
              * platform/mac/WebCoreTextField.h:
              * platform/mac/WebCoreTextField.mm:
              * platform/mac/WidgetMac.mm:
              * platform/win/TemporaryLinkStubs.cpp:
              * rendering/DataRef.h:
              * rendering/DeprecatedRenderSelect.cpp:
              * rendering/DeprecatedRenderSelect.h:
              * rendering/DeprecatedSlider.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderApplet.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderFileButton.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderFlow.cpp:
              * rendering/RenderFormElement.cpp:
              * rendering/RenderFrameSet.cpp:
              * rendering/RenderFrameSet.h:
              * rendering/RenderImage.cpp:
              * rendering/RenderInline.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayer.h:
              * rendering/RenderLineEdit.cpp:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderPartObject.cpp:
              * rendering/RenderReplaced.cpp:
              * rendering/RenderStyle.cpp: Added.
              * rendering/RenderStyle.h: Added.
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableCell.h:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableCol.h:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/RenderTableSection.h:
              * rendering/RenderText.cpp:
              * rendering/RenderText.h:
              * rendering/RenderTextArea.cpp:
              * rendering/RenderTextControl.cpp: Added.
              * rendering/RenderTextControl.h: Added.
              * rendering/RenderTextField.cpp: Removed.
              * rendering/RenderTextField.h: Removed.
              * rendering/RenderTheme.cpp:
              * rendering/RenderThemeMac.mm:
              * rendering/RenderTreeAsText.cpp:
              * rendering/RenderTreeAsText.h:
              * rendering/RenderView.cpp:
              * rendering/RenderWidget.cpp:
              * rendering/bidi.cpp:
              * rendering/render_style.cpp: Removed.
              * rendering/render_style.h: Removed.
              * xml/XSLStyleSheet.cpp:
              * xml/XSLTProcessor.cpp:
              * xml/xmlhttprequest.cpp:
              * xpath/impl/XPathParser.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53ebdcb
  20. 07 Jul, 2006 2 commits
    • lweintraub's avatar
      LayoutTests: · 1bb7d0bf
      lweintraub authored
              Reviewed by justin
      
              Deletion editing deligates now show up!
      
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-br-001-expected.txt:
              * editing/deleting/delete-br-002-expected.txt:
              * editing/deleting/delete-br-003-expected.txt:
              * editing/deleting/delete-br-004-expected.txt:
              * editing/deleting/delete-br-005-expected.txt:
              * editing/deleting/delete-br-006-expected.txt:
              * editing/deleting/delete-br-007-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-009-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-character-001-expected.txt:
              * editing/deleting/delete-contiguous-ws-001-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-leading-ws-001-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/delete-selection-001-expected.txt:
              * editing/deleting/delete-tab-001-expected.txt:
              * editing/deleting/delete-tab-002-expected.txt:
              * editing/deleting/delete-tab-003-expected.txt:
              * editing/deleting/delete-tab-004-expected.txt:
              * editing/deleting/delete-trailing-ws-001-expected.txt:
              * editing/deleting/delete-trailing-ws-002-expected.txt:
              * editing/deleting/delete-ws-fixup-001-expected.txt:
              * editing/deleting/delete-ws-fixup-002-expected.txt:
              * editing/deleting/delete-ws-fixup-003-expected.txt:
              * editing/deleting/delete-ws-fixup-004-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-into-empty-block-1-expected.txt:
              * editing/deleting/merge-into-empty-block-2-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/merge-unrendered-space-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/smart-delete-001-expected.txt:
              * editing/deleting/smart-delete-002-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-021-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/input-text-option-delete-expected.checksum:
              * fast/forms/input-text-option-delete-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Allowed deletion typing commands to take in a granularity
      
              * bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
              * bridge/mac/WebCoreFrameBridge.mm: Ditto
              (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
              (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
              * editing/TypingCommand.cpp: Constructors take in a granularity
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/TypingCommand.h: ditto
              * page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual
      
      WebKit:
      
              Reviewed by justin
      
              Finished moving deletion selection expansion across the bridge... say that 3 times fast.
      
              * WebView/WebHTMLView.m:  Pass granularity to WebCore to handle expansion
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
              (-[WebHTMLView _deleteSelection]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
              (-[NSArray deleteToMark:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb7d0bf
    • lweintraub's avatar
      LayoutTests: · 6d377800
      lweintraub authored
              Reviewed by justin
      
              Improved table editing
      
              * editing/deleting/delete-to-select-table-expected.checksum: Added.
              * editing/deleting/delete-to-select-table-expected.png: Added.
              * editing/deleting/delete-to-select-table-expected.txt: Added.
              * editing/deleting/delete-to-select-table.html: Added.
              * editing/input/text-input-controller-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Improved table editing: pressing delete directly before or after a table will now select
              the table first, then delete it, instead of just deleting it. Useful for when the table's
              existence is non-obvious.
      
              * bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger
              deletion editing deligates
              * bridge/mac/FrameMac.mm: ditto
              (WebCore::FrameMac::shouldDeleteSelection):
              * bridge/mac/WebCoreFrameBridge.h: ditto
              * editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and
              subsequent selection (as opposed to removal)
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * page/Frame.cpp: shouldDeleteSelection added
              (WebCore::Frame::shouldDeleteSelection):
              * page/Frame.h: ditto
      
      WebKit:
      
              Reviewed by justin
      
              Improved table editing
      
              * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
              deletion editing delegate
              (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
              * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
              key is pressed over to WebCore so we can be more intelligent about how to handle it
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d377800
  21. 05 Jul, 2006 1 commit
    • andersca's avatar
      WebCore: · 3a434621
      andersca authored
      2006-07-05  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
              iFrames set to display:none are Missing from frames array
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::FrameMac):
              (WebCore::FrameMac::createFrame):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
              (-[WebCoreFrameBridge installInFrame:]):
              Modify to pass the owner element instead of the owner renderer.        
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::appendChild):
              Dispatch the node inserted events before attaching the nodes. This is what the
              tokenizer does.
              
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::openURL):
              (WebCore::HTMLFrameElement::attach):
              Pass the element to requestFrame.
              
              (WebCore::HTMLFrameElement::setLocation):
              Don't call attach/detach on an iframe.
      
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::insertedIntoDocument):
              Load the frame here (using openURL).
              
              (WebCore::HTMLIFrameElement::removedFromDocument):
              Call frameDetached.
              
              (WebCore::HTMLIFrameElement::attach):
              If there's a renderer, attach the content frame to it.
              
              (WebCore::HTMLIFrameElement::detach):
              Reset the renderer's frame.
              
              (WebCore::HTMLIFrameElement::openURL):
              Modify to request the frame.
              
              * html/HTMLIFrameElement.h:
              Add detach.
              
              * page/Frame.cpp:
              (WebCore::parentFromOwnerElement):
              (WebCore::Frame::Frame):
              (WebCore::Frame::~Frame):
              (WebCore::Frame::requestFrame):
              (WebCore::Frame::requestObject):
              (WebCore::Frame::loadSubframe):
              (WebCore::Frame::ownerElement):
              (WebCore::Frame::ownerRenderer):
              (WebCore::Frame::disconnectOwnerElement):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):        
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::setFrame):
              Modify to keep an owner element around instead of the renderer. 
              
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
              Don't do anything for iframes.
      
      WebKit:
      
      2006-07-05  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
              iFrames set to display:none are Missing from frames array
              
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
              (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
              Modify to pass the owner element instead of the owner renderer.
              
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _topHTMLView]):
              Remove assertion, it's not valid anymore.
      
      LayoutTests:
      
      2006-07-05  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
              iFrames set to display:none are Missing from frames array
      
              * fast/events/mouseover-mouseout2-expected.txt:
              * fast/events/mouseover-mouseout2.html:
              Update expected result. Since we now keep the frame around, the mouseout event is 
              now dispatched to the element in the frame.
      
              * fast/events/onloadFrameCrash-expected.checksum:
              * fast/events/onloadFrameCrash-expected.png:
              * fast/events/onloadFrameCrash-expected.txt:
              This does hide the frame now.
              
              * fast/frames/iframe-display-none-expected.txt: Added.
              * fast/frames/iframe-display-none.html: Added.
              * fast/frames/resources/iframe-display-none-child.html: Added.
              New test that tests JS interaction with frames.
              
              * fast/frames/iframe-double-attach-expected.txt: Added.
              * fast/frames/iframe-double-attach.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a434621
  22. 26 Jun, 2006 2 commits
    • hyatt's avatar
      Fix for 9538, support syntax highlighted HTML source. Lots of loose · 3ad24079
      hyatt authored
              ends still (script/style/comments/doctype/entities/accurate whitespace).
      
              Reviewed by darin
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setInViewSourceMode:]):
              (-[WebCoreFrameBridge inViewSourceMode]):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::loadDefaultStyle):
              (WebCore::CSSStyleSelector::matchUARules):
              * css/cssstyleselector.h:
              * css/view-source.css: Added.
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              * dom/xml_tokenizer.h:
              (WebCore::Tokenizer::Tokenizer):
              (WebCore::Tokenizer::~Tokenizer):
              (WebCore::Tokenizer::inViewSourceMode):
              (WebCore::Tokenizer::setInViewSourceMode):
              * html/HTMLAttributeNames.in:
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::init):
              (WebCore::HTMLFrameElement::parseMappedAttribute):
              (WebCore::HTMLFrameElement::attach):
              * html/HTMLFrameElement.h:
              (WebCore::HTMLFrameElement::viewSourceMode):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::HTMLTokenizer):
              (WebCore::HTMLTokenizer::scriptHandler):
              (WebCore::HTMLTokenizer::scriptExecution):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::continueProcessing):
              (WebCore::HTMLTokenizer::write):
              (WebCore::HTMLTokenizer::timerFired):
              (WebCore::HTMLTokenizer::end):
              (WebCore::HTMLTokenizer::processToken):
              (WebCore::HTMLTokenizer::notifyFinished):
              * html/HTMLTokenizer.h:
              * html/HTMLViewSourceDocument.cpp: Added.
              (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
              (WebCore::HTMLViewSourceDocument::createTokenizer):
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addViewSourceAttribute):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              * html/HTMLViewSourceDocument.h: Added.
              * page/Frame.cpp:
              (WebCore::Frame::begin):
              (WebCore::Frame::inViewSourceMode):
              (WebCore::Frame::setInViewSourceMode):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ad24079
    • andersca's avatar
      2006-06-26 Anders Carlsson <acarlsson@apple.com> · 5dc61eae
      andersca authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
              REGRESSION: Crash when closing tabs on newegg.com
              
              * page/Frame.cpp:
              (WebCore::Frame::pageDestroyed):        
              * page/Frame.h:
              Add new method which is invoked when the frame's page has been destroyed.
              Currently this function disassociates the JS Window object with the frame, 
              stopping any running JS timers.
              
              * page/Page.cpp:
              (WebCore::Page::~Page):
              Call pageDestroyed on all frames.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dc61eae
  23. 20 Jun, 2006 1 commit
    • adele's avatar
      LayoutTests: · 19869953
      adele authored
              Reviewed by Maciej.
      
              Tests for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
              REGRESSION: onSelect handler doesn't work for text fields
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
              REGRESSION: Selection methods on new text fields don't work if text field is hidden
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
              REGRESSION: selectionStart/End return 0 for input element once it no longer has focus
      
              * fast/forms/double-focus-expected.txt:
              * fast/forms/input-selection-hidden-expected.txt: Added.
              * fast/forms/input-selection-hidden.html: Added.
              * fast/forms/input-selection-restore-expected.txt: Added.
              * fast/forms/input-selection-restore.html: Added.
              * fast/forms/input-text-paste-maxlength-expected.txt:
              * fast/forms/onselect-textarea-expected.txt: Added.
              * fast/forms/onselect-textarea.html: Added.
              * fast/forms/onselect-textfield-expected.txt: Added.
              * fast/forms/onselect-textfield.html: Added.
              * fast/forms/selection-functions-expected.txt:
      
      WebCore:
      
              Reviewed by Maciej.
      
              Fixes for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
              REGRESSION: onSelect handler doesn't work for text fields
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
              REGRESSION: Selection methods on new text fields don't work if text field is hidden
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
              REGRESSION: selectionStart/End return 0 for input element once it no longer has focus
      
              Implemented onSelect for new text fields and textareas.  Also fixed selection restore
              behavior to better match other browsers and Safari 2.0 behavior.
      
              Tests:
              * fast/forms/input-selection-restore.html
              * fast/forms/input-selection-hidden.html
              * fast/forms/onselect-textarea.html
              * fast/forms/onselect-textfield.html
      
              * html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::init): Initializes cached selection.
              (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value.
              (WebCore::HTMLInputElement::selectionEnd): ditto.
              (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection.  Matches Safari 2.0 behavior.
      
              * html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection.
              (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value.
              (WebCore::HTMLTextAreaElement::selectionEnd): ditto.
              (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text.  Otherwise,
              restore the cached selection.  This matches other browsers' behavior.
              (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection.  Matches Safari 2.0 behavior.
      
              * page/Frame.h: Added notifyRendererOfSelectionChange method. 
              * page/Frame.cpp:
              (WebCore::Frame::notifyRendererOfSelectionChange): Added.  Calls selectionChanged for text fields and textareas.  Forwards a userTriggered
              argument so selectionChanged knows whether or not to fire onSelect.
              (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false).  This gets called for all selection changes, so the renderer
              can always update its cached selection values.
              (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done
              making a selection with the mouse.
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets
              fired when the user makes a selection with the keyboard.
              (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.
      
              * rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
              * rendering/RenderTextField.cpp:
              (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and 
              return early since we won't be able to actually set the selection.
              (WebCore::RenderTextField::selectionChanged): Caches the selection.  
              If the selection is a range, and its triggered by user action, then fire the onSelect event.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19869953
  24. 19 Jun, 2006 1 commit
    • ap's avatar
      Reviewed by Darin. · a01e8e12
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=5499
              Page reload does not send any cache control headers
      
      WebCore:
              * bindings/js/kjs_window.cpp:
              (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.
      
              * page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was
              used only for storing response HTTP headers, which was an overkill.
      
              * page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.
      
              * page/Frame.cpp:
              (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob.
              (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob.
              (WebCore::Frame::receivedFirstData): Ditto.
              (WebCore::Frame::addMetaData): Ditto.
              (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what
              scheduleRedirection() does.
              (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.
      
      WebKit:
              * WebView/WebFrame.m:
              (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for 
              reload requests.
              (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at 
              WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).
      
      LayoutTests:
              * http/tests/misc/refresh-headers-expected.txt: Added.
              * http/tests/misc/refresh-headers.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a01e8e12
  25. 18 Jun, 2006 1 commit
    • andersca's avatar
      JavaScriptCore: · db812fdd
      andersca authored
      2006-06-18  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              * kjs/interpreter.cpp:
              (KJS::TimeoutChecker::pauseTimeoutCheck):
              Do nothing if the timeout check hasn't been started.
              
              (KJS::TimeoutChecker::resumeTimeoutCheck):
              Do nothing if the timeout check hasn't been started.
              Use the right signal handler when unblocking.
              
              (KJS::Interpreter::handleTimeout):
              pause/resume the timeout check around the call to
              shouldInterruptScript().
              
      WebCore:
      
      2006-06-17  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::ScriptInterpreter):
              Set the default script timeout.
              
              (KJS::ScriptInterpreter::shouldInterruptScript):
              New function which asks the frame if the script should be interrupted.
              
              * bindings/js/kjs_binding.h:
                      
              * bindings/js/kjs_events.cpp:
              (KJS::JSAbstractEventListener::handleEvent):
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::evaluate):
              Add calls to startTimeoutCheck/stopTimeoutCheck
              
              * bindings/js/kjs_window.cpp:
              (KJS::WindowFunc::callAsFunction):
              Add calls to pauseTimeoutCheck/unpauseTimeoutCheck 
              
              (KJS::ScheduledAction::execute):
              Add calls to startTimeoutCheck/stopTimeoutCheck
              
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::shouldInterruptJavaScript):
              New function which asks the bridge if the script should be interrupted.
              
              * bridge/mac/WebCoreFrameBridge.h:
              * page/Frame.h:
              Add function declarations.
              
      WebKit:
      
      2006-06-18  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge shouldInterruptJavaScript]):
              Ask the UI delegate if the script should be interrupted.
              
              * WebView/WebUIDelegatePrivate.h:
              Declare webViewShouldInterruptJavaScript: delegate method
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db812fdd
  26. 11 Jun, 2006 1 commit
    • andersca's avatar
      WebCore: · c79dba31
      andersca authored
      2006-06-11  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
              Move full-frame plugins to WebCore
              
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              Add PluginDocument
              
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::redirectDataToPlugin):
              Call the bridge.
              
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              Add redirectDataToPlugin which is used to redirect incoming data
              to a plugin.
              
              * bridge/mac/WebCoreViewFactory.h:
              Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.
              
              * dom/DOMImplementation.cpp:
              * dom/DOMImplementation.h:
              Get rid of createTextDocument and just create a text document explicitly when needed.
              
              * dom/Document.h:
              (WebCore::Document::isPluginDocument):
              * loader/PluginDocument.cpp: Added.
              (WebCore::PluginTokenizer::PluginTokenizer):
              (WebCore::PluginTokenizer::wantsRawData):
              (WebCore::PluginTokenizer::write):
              (WebCore::PluginTokenizer::createDocumentStructure):
              (WebCore::PluginTokenizer::writeRawData):
              (WebCore::PluginTokenizer::stopParsing):
              (WebCore::PluginTokenizer::finish):
              (WebCore::PluginTokenizer::isWaitingForScripts):
              (WebCore::PluginDocument::PluginDocument):
              (WebCore::PluginDocument::createTokenizer):
              * loader/PluginDocument.h: Added.
              (WebCore::PluginDocument::isPluginDocument):
              Add PluginDocument.
              
              * page/Frame.cpp:
              (WebCore::Frame::begin):
              Possibly create a plugin document.
              
              * page/Frame.h:
              (WebCore::Frame::redirectDataToPlugin):
              Add declaration.
              
              * platform/PlugInInfoStore.h:
              * platform/mac/PlugInInfoStoreMac.mm:
              (WebCore::PlugInInfoStore::supportsMIMEType):
              Ask WebCoreViewFactory if the MIME type is supported.
      
      WebKit:
      
      2006-06-11  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Tim.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
              Move full-frame plugins to WebCore
      
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream instance]):
              Add instance method which returns the plugin instance.
              
              * Plugins/WebBasePluginPackage.h:
              Add WebPluginManualLoader protocol
              
              * Plugins/WebNetscapePluginDocumentView.h: Removed.
              * Plugins/WebNetscapePluginDocumentView.m: Removed.
      
              * Plugins/WebNetscapePluginEmbeddedView.h:
              * Plugins/WebNetscapePluginEmbeddedView.m:
              (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]):
              (-[WebNetscapePluginEmbeddedView dealloc]):
              (-[WebNetscapePluginEmbeddedView didStart]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]):
              (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]):
              (-[WebNetscapePluginEmbeddedView redeliverStream]):
              Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the
              data manually. Much of this code has been copied from WebNetscapePluginRepresentation.
      
              * Plugins/WebNetscapePluginRepresentation.h: Removed.
              * Plugins/WebNetscapePluginRepresentation.m: Removed.
      
              * Plugins/WebPluginController.h:
              * Plugins/WebPluginController.m:
              (-[WebPluginController pluginView:receivedResponse:]):
              (-[WebPluginController pluginView:receivedData:]):
              (-[WebPluginController pluginView:receivedError:]):
              (-[WebPluginController pluginViewFinishedLoading:]):
              Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.
      
              * Plugins/WebPluginDatabase.m:        
              (-[WebPluginDatabase refresh]):
              Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.
              
              * Plugins/WebPluginDocumentView.h: Removed.
              * Plugins/WebPluginDocumentView.m: Removed.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
              (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
              Add loadManually argument.
              
              (-[WebFrameBridge redirectDataToPlugin:]):
              Call down to the HTML representation.
              
              (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
              Pass NO to loadManually.
              
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
              Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.
              
              * WebCoreSupport/WebViewFactory.m:
              (-[WebViewFactory pluginSupportsMIMEType:]):
              New function which returns whether any plugins support a given MIME type.
              
              * WebKit.xcodeproj/project.pbxproj:
              Update for removed files.
              
              * WebView/WebFrame.m:
              (-[WebFrame _reloadForPluginChanges]):
              Remove view type checks.
              
              (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
              (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
              Remove FIXME comments.
              
              * WebView/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):        
              New function which redirects incoming data to a manual loader.
              
              (-[WebHTMLRepresentation receivedData:withDataSource:]):
              (-[WebHTMLRepresentation receivedError:withDataSource:]):
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
              Optionally redirect incoming data.
              
              * WebView/WebHTMLRepresentationPrivate.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79dba31
  27. 10 Jun, 2006 1 commit
    • ggaren's avatar
      JavaScriptCore: · 1ec99535
      ggaren authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
              Linux porting compile bug
              
              Fix by Mike Emmel, Reviewed by Darin.
      
              * JavaScriptCoreSources.bkl:
              * jscore.bkl:
              * wtf/Platform.h:
      
      WebCore:
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
              Linux porting compile bug
              
              Fix by Mike Emmel, Reviewed by Darin.
      
              * Projects/gdk/webcore-gdk.bkl:
              * WebCoreSources.bkl:
              * css/maketokenizer:
              * html/HTMLCanvasElement.cpp:
              * html/HTMLImageElement.h:
              * icon/IconDatabase.cpp:
              * make-generated-sources.sh:
              * page/Frame.h:
              * page/FramePrivate.h:
              * platform/Cursor.h:
              * platform/FontData.h:
              (WebCore::FontData::getGlyphIndex):
              * platform/GlyphBuffer.h:
              (WebCore::GlyphBuffer::glyphAt):
              (WebCore::GlyphBuffer::advanceAt):
              (WebCore::GlyphBuffer::add):
              * platform/GraphicsContext.h:
              * ...
      1ec99535
  28. 09 Jun, 2006 2 commits
    • hyatt's avatar
      WebCore: · 76a0c024
      hyatt authored
              Rework selection coloring.  Rename displaysWithFocusAttributes
              to isActive.  Move the white-blending code onto the Color API to make
              it more convenient to mutate colors for selection blending.  Eliminate all
              the selection state from the GraphicsContext and move it to the RenderTheme.
              Implement both Win32 and Mac theme selection colors.
      
              Reviewed by sfalken
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::setIsActive):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge drawRect:]):
              (-[WebCoreFrameBridge setIsActive:]):
              (-[WebCoreFrameBridge selectionColor]):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::checkOneSelector):
              * page/Frame.cpp:
              (WebCore::Frame::isActive):
              (WebCore::Frame::setIsActive):
              * page/Frame.h:
              * platform/Color.cpp:
              (WebCore::blend):
              (WebCore::Color::blendWithWhite):
              * platform/Color.h:
              (WebCore::Color::hasAlpha):
              * platform/GraphicsContext.cpp:
              (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
              * platform/GraphicsContext.h:
              * platform/mac/GraphicsContextMac.mm:
              * platform/win/TemporaryLinkStubs.cpp:
              (GraphicsContext::endTransparencyLayer):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintSelection):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::fillHorizontalSelectionGap):
              (WebCore::RenderBlock::fillVerticalSelectionGap):
              (WebCore::RenderBlock::fillLeftSelectionGap):
              (WebCore::RenderBlock::fillRightSelectionGap):
              * rendering/RenderHTMLCanvas.cpp:
              (WebCore::RenderHTMLCanvas::paint):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paint):
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::paint):
              * rendering/RenderListMarker.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::selectionColor):
              * rendering/RenderObject.h:
              * rendering/RenderReplaced.cpp:
              * rendering/RenderReplaced.h:
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::activeSelectionColor):
              (WebCore::RenderTheme::inactiveSelectionColor):
              (WebCore::RenderTheme::platformActiveSelectionColor):
              (WebCore::RenderTheme::platformInactiveSelectionColor):
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::platformActiveSelectionColor):
              (WebCore::RenderThemeMac::platformInactiveSelectionColor):
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::platformActiveSelectionColor):
              (WebCore::RenderThemeWin::platformInactiveSelectionColor):
              * rendering/RenderThemeWin.h:
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
      
      WebKit:
      
              Rename displaysWithFocusAttributes to isActive.
      
              Reviewed by sfalken
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _updateFocusState]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76a0c024
    • justing's avatar
      LayoutTests: · 7c9568d1
      justing authored
              Reviewed by levi
              
              <rdar://problem/4549980>
              REGRESSION: "Find Again" can get stuck when searching for string with a trailing space
      
              * editing/execCommand/findString-expected.checksum: Added.
              * editing/execCommand/findString-expected.png: Added.
              * editing/execCommand/findString-expected.txt: Added.
              * editing/execCommand/findString.html: Added.
      
      WebCore:
      
              Reviewed by levi
              
              <rdar://problem/4549980>
              REGRESSION: "Find Again" can get stuck when searching for string with a trailing space
      
              * bridge/mac/FrameMac.h: Moved findString to Frame.
              * bridge/mac/FrameMac.mm: Ditto.
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): 
              Convert the NSString to a String.
              * editing/JSEditor.cpp: Added execCommand(FindString, ...)
              * editing/Selection.cpp: Added a constructor for Ranges
              (WebCore::Selection::Sele...
      7c9568d1
  29. 08 Jun, 2006 1 commit
    • justing's avatar
      LayoutTests: · e6f80c1e
      justing authored
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              Added:
              * editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
              * editing/execCommand/create-list-from-range-selection-expected.png: Added.
              * editing/execCommand/create-list-from-range-selection-expected.txt: Added.
              * editing/execCommand/create-list-from-range-selection.html: Added.
              * editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
              * editing/execCommand/insert-list-and-stitch-expected.png: Added.
              * editing/execCommand/insert-list-and-stitch-expected.txt: Added.
              * editing/execCommand/insert-list-and-stitch.html: Added.
              * editing/execCommand/insert-list-with-id-expected.checksum: Added.
              * editing/execCommand/insert-list-with-id-expected.png: Added.
              * editing/execCommand/insert-list-with-id-expected.txt: Added.
              * editing/execCommand/insert-list-with-id.html: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.png: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
              * editing/execCommand/remove-list-from-range-selection.html: Added.
              * editing/execCommand/remove-list-items-expected.checksum: Added.
              * editing/execCommand/remove-list-items-expected.png: Added.
              * editing/execCommand/remove-list-items-expected.txt: Added.
              * editing/execCommand/remove-list-items.html: Added.
              * editing/execCommand/switch-list-type-expected.checksum: Added.
              * editing/execCommand/switch-list-type-expected.png: Added.
              * editing/execCommand/switch-list-type-expected.txt: Added.
              * editing/execCommand/switch-list-type.html: Added.
              
              Fixes:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/paste-list-001-expected.txt:
              * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
              * editing/selection/drag-to-contenteditable-iframe-expected.png:
              * editing/selection/drag-to-contenteditable-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * fast/text/textIteratorNilRenderer-expected.checksum:
              * fast/text/textIteratorNilRenderer-expected.png:
              * fast/text/textIteratorNilRenderer-expected.txt:
              * editing/deleting/delete-line-016-expected.checksum:
              * editing/deleting/delete-line-016-expected.png:
              * editing/deleting/delete-line-016-expected.txt:
      
      WebCore:
      
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
              * dom/Position.cpp:
              (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): 
              Added. A block with height is only a candidate if this is false.  This should fix the problems
              getting carets into empty blocks.
              (WebCore::Position::inRenderedContent):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::hasARenderedDescendant):
              (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet
              have no rendered descendants.  Fixed the pruning rule to avoid removing a node like this.
              (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to
              each other if they aren't already, as a convenience.
              (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection.
              (WebCore::CompositeEditCommand::moveParagraphs): Ditto. 
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should
              continue to happen until it is no longer possible.
              (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node
              wouldn't always avoid removing the start block.
              * editing/InsertListCommand.cpp: Added.
              (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list
              into a list.
              (WebCore::InsertListCommand::InsertListCommand):
              (WebCore::InsertListCommand::modifyRange):
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h: Added.
              (WebCore::InsertListCommand::):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              * editing/JSEditor.cpp:
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the 
              iterator ends at the start of that node.
              used to create the iterator.
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::next):
              (WebCore::VisiblePosition::previous):
              * editing/VisiblePosition.h: 
              Added a parameter to next/previous to prevent them from going outside the current editable region.
              * editing/htmlediting.cpp:
              (WebCore::highestAncestor):
              (WebCore::enclosingList):
              (WebCore::enclosingListChild):
              (WebCore::outermostEnclosingList):
              (WebCore::createListItemElement):
              * editing/htmlediting.h:
              * page/Frame.cpp:
              (WebCore::Frame::selectionListState): Added.
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              * WebView/WebFrame.m:
              (-[WebFrame _findFrameWithSelection]): Removed an assertion
              that we only have one frame with a selection.  
              * WebView/WebView.m:
              (-[WebView selectedFrame]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6f80c1e
  30. 06 Jun, 2006 1 commit
    • andersca's avatar
      WebCore: · a70ccbc8
      andersca authored
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by John.
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge containsPlugins]):
              * page/Frame.cpp:
              (WebCore::Frame::containsPlugins):
              * page/Frame.h:
              Add containsPlugins function which returns whether a frame contains plugins
              or not.
      
      WebKit:
      
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by John.
      
              * WebView/WebFrame.m:
              (-[WebFrame _reloadForPluginChanges]):
              Don't traverse the view hierarchy looking for plugin views. Instead, just
              ask the frame whether it contains any plugins.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a70ccbc8