1. 12 Nov, 2013 40 commits
    • timothy_horton@apple.com's avatar
      fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2... · ca94cf42
      timothy_horton@apple.com authored
      fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2 testers, fails about 20% of the time
      https://bugs.webkit.org/show_bug.cgi?id=124223
      
      Mark as flaky on Mac-Mavericks-WebKit2.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca94cf42
    • oliver@apple.com's avatar
      Support unprefixed deconstructing assignment · 2bae57ad
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124172
      
      Reviewed by Mark Lam.
      
      Source/JavaScriptCore:
      
      Add support for unprefixed descontructive assignment.
      
      Happily non-reference types on the left hand side of an assignment
      are a runtime error, so we're able to defer validation of the binding
      pattern to codegen time when we're already doing a lot more work.
      
      We're also able to predicate our attempt to parse on the existence of
      '[' or '{' as they are not as common as other constructs.
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ArrayPatternNode::emitDirectBinding):
      * parser/ASTBuilder.h:
      * parser/Parser.cpp:
      (JSC::::createBindingPattern):
      (JSC::::tryParseDeconstructionPatternExpression):
      (JSC::::parseDeconstructionPattern):
      (JSC::::parseForStatement):
      (JSC::::parseAssignmentExpression):
      * parser/Parser.h:
      (JSC::Parser::createSavePoint):
      (JSC::Parser::restoreSavePoint):
      * parser/SyntaxChecker.h:
      
      LayoutTests:
      
      Add and expand testing of destructuring assignment
      
      * js/basic-for-of-expected.txt:
      * js/destructuring-assignment-expected.txt:
      * js/parser-syntax-check-expected.txt:
      * js/script-tests/basic-for-of.js:
      * js/script-tests/destructuring-assignment.js:
      (testDestructuring):
      * js/script-tests/parser-syntax-check.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bae57ad
    • aestes@apple.com's avatar
      Run JavaScriptCore Objective-C API tests on all supported platforms · 529b5ec5
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124214
      
      Reviewed by Mark Hahnenberg.
      
      Now that we support the API on iOS and on OS X 10.8, there's no reason
      to limit the tests to OS X 10.9 (or greater).
      
      * API/tests/CurrentThisInsideBlockGetterTest.h:
      * API/tests/CurrentThisInsideBlockGetterTest.mm:
      * API/tests/testapi.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      529b5ec5
    • roger_fong@apple.com's avatar
      [Windows] Unreviewed gardening of some media tests. · 9145a28d
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9145a28d
    • mhahnenberg@apple.com's avatar
      CodeBlocks should be able to determine bytecode liveness · 3811e215
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118546
      
      Reviewed by Filip Pizlo.
      
      This will simplify some things in the DFG related to OSR exits and determining 
      which bytecode variables are live at which points during execution. It will
      also be useful for making our conservative GC scan more precise. Currently it 
      doesn't properly account for liveness while the DFG is running, so it will be 
      off by default behing a runtime Options flag.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/BytecodeBasicBlock.cpp: Added.
      (JSC::isBranch): Used to determine the end of basic blocks.
      (JSC::isUnconditionalBranch): Used to determine when a branch at the end of a 
      basic block can't possibly fall through to the next basic block in program order.
      (JSC::isTerminal): Also used to detect the end of a block.
      (JSC::isThrow):
      (JSC::isJumpTarget): Used to correctly separate basic blocks. Any jump destination 
      must be the head of its own basic block.
      (JSC::linkBlocks): Links two blocks together in a bi-direcitonal fashion.
      (JSC::computeBytecodeBasicBlocks): Creates a set of basic blocks given a particular 
      CodeBlock and links them together.
      * bytecode/BytecodeBasicBlock.h: Added.
      (JSC::BytecodeBasicBlock::isEntryBlock): Entry blocks are a special basic blocks 
      that indicate the beginning of the function.
      (JSC::BytecodeBasicBlock::isExitBlock): Exit blocks are a special basic block that 
      all blocks that exit the function have as a successor. Entry and exit blocks allows 
      the various code paths to be more regular.
      (JSC::BytecodeBasicBlock::leaderBytecodeOffset): The leader bytecode offset is the 
      bytecode offset of the first instruction in the block.
      (JSC::BytecodeBasicBlock::totalBytecodeLength): The total length of all the bytecodes 
      in this block.
      (JSC::BytecodeBasicBlock::bytecodeOffsets): The bytecode offsets in this particular 
      basic block. This Vector allows us to iterate over the bytecodes in reverse order 
      which wouldn't be possible normally since they are of variable size.
      (JSC::BytecodeBasicBlock::addPredecessor): Links a block to a specified predecessor. 
      Only creates one direction of the link.
      (JSC::BytecodeBasicBlock::addSuccessor): Same as addPredecessor, but for successors.
      (JSC::BytecodeBasicBlock::predecessors): Getter for predecessors.
      (JSC::BytecodeBasicBlock::successors): Getter for successors.
      (JSC::BytecodeBasicBlock::in): Getter for the liveness info at the head of the block.
      (JSC::BytecodeBasicBlock::out): Getter for the liveness info at  the tail of the block.
      (JSC::BytecodeBasicBlock::BytecodeBasicBlock):
      (JSC::BytecodeBasicBlock::addBytecodeLength): When creating basic blocks we call 
      this function when we want to add the next bytecode in program order to this block.
      * bytecode/BytecodeLivenessAnalysis.cpp: Added.
      (JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
      (JSC::numberOfCapturedVariables): Convenience wrapper. Returns the
      number of captured variables for a particular CodeBlock, or 0 if 
      the CodeBlock has no SymbolTable.
      (JSC::captureStart): Ditto, but for captureStart().
      (JSC::captureEnd): Ditto, but for captureEnd().
      (JSC::isValidRegisterForLiveness): Returns true if the liveness analysis should 
      track the liveness of a particular operand. We ignore constants, arguments, and 
      captured variables. We ignore arguments because they're live for the duration of 
      a function call. We ignore captured variables because we also treat them as live 
      for the duration of the function. This could probably be improved to be more precise, 
      but it didn't seem worth it for now.
      (JSC::setForOperand): Convenience wrapper that sets the bit in the provided bit 
      vector for the provided operand. It handles skipping over captured variables.
      (JSC::computeUsesForBytecodeOffset): Computes which operands are used by a particular bytecode.
      (JSC::computeDefsForBytecodeOffset): Computes which operands are defined by a particular 
      bytecode. Typically this is just the left-most operand.
      (JSC::findBasicBlockWithLeaderOffset): 
      (JSC::findBasicBlockForBytecodeOffset): Scans over basic blocks to find the block 
      which contains a particular bytecode offset.
      (JSC::computeLocalLivenessForBytecodeOffset): Computes block-local liveness from the 
      bottom of the block until a specified bytecode offset is reached. 
      (JSC::computeLocalLivenessForBlock): Computes liveness for the entire block and 
      stores the resulting liveness at the head.
      (JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Runs backward flow liveness 
      analysis to fixpoint.
      (JSC::BytecodeLivenessAnalysis::getLivenessInfoForNonCapturedVarsAtBytecodeOffset): 
      Slow path to get liveness info for non-captured, non-argument variable.
      (JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset): 
      (JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset): Returns the liveness 
      info for both captured and non-captured vars at a particular bytecode offset.
      (JSC::BytecodeLivenessAnalysis::dumpResults): Dumps the output of the liveness analysis. 
      Controlled by new flag in Options.h/.cpp.
      (JSC::BytecodeLivenessAnalysis::compute): Creates bytecode basic blocks and runs 
      full liveness analysis.
      * bytecode/BytecodeLivenessAnalysis.h: Added.
      (JSC::BytecodeLivenessAnalysis::hasBeenComputed):
      (JSC::BytecodeLivenessAnalysis::computeIfNecessary):
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::CodeBlock):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::livenessAnalysis):
      * bytecode/PreciseJumpTargets.cpp: Refactored to be able to get the jump targets for 
      a particular bytecode offset for use during bytecode basic block construction.
      (JSC::getJumpTargetsForBytecodeOffset):
      (JSC::computePreciseJumpTargets):
      (JSC::findJumpTargetsForBytecodeOffset):
      * bytecode/PreciseJumpTargets.h:
      * runtime/Options.cpp:
      (JSC::Options::initialize):
      * runtime/Options.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3811e215
    • timothy_horton@apple.com's avatar
      "AVF info: hasOfflineRenderer, board-id check : true" in... · 7368f1e7
      timothy_horton@apple.com authored
      "AVF info: hasOfflineRenderer, board-id check : true" in media/track/track-forced-subtitles-in-band.html
      https://bugs.webkit.org/show_bug.cgi?id=124219
      
      Logging that happens unpredictably underneath us; marking the test as flaky on Mavericks for now.
      
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7368f1e7
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix after r159129. · 9ccf9f00
      zandobersek@gmail.com authored
      * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
      (webkit_file_chooser_request_select_files): Use ImmutableArray::create() instead.
      * UIProcess/API/gtk/WebKitWebViewGroup.cpp:
      (toImmutableArray): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ccf9f00
    • andersca@apple.com's avatar
      Stop using WKArrayCreate internally · bb2ed332
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124217
      
      Reviewed by Andreas Kling.
      
      * UIProcess/API/mac/WKBrowsingContextGroup.mm:
      (createWKArray):
      (-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
      (-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageCopyContextMenuItems):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb2ed332
    • stavila@adobe.com's avatar
      Created test for testing repaint rects for elements inside relative-positioned regions. · ba4495bf
      stavila@adobe.com authored
      [CSS Regions] clip rectangles are incorrectly computed in some positioned elements
      https://bugs.webkit.org/show_bug.cgi?id=114722
      
      Reviewed by Mihnea Ovidenie.
      
      * fast/repaint/increasing-region-content-height-expected.txt: Added.
      * fast/repaint/increasing-region-content-height.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba4495bf
    • ossy@webkit.org's avatar
      URTBF after r159129, use create() instead of adopt() everywhere. · 9d93140a
      ossy@webkit.org authored
      * UIProcess/WebGrammarDetail.cpp:
      (WebKit::WebGrammarDetail::guesses):
      * UIProcess/efl/WebUIPopupMenuClient.cpp:
      (WebUIPopupMenuClient::showPopupMenu):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d93140a
    • timothy_horton@apple.com's avatar
      After http://trac.webkit.org/changeset/159109, update · 31803ed0
      timothy_horton@apple.com authored
      rebaseline_unittest to use the new GTK bot names.
      
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (TestRebaselineTest.test_baseline_directory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31803ed0
    • andersca@apple.com's avatar
      Simplify ImmutableArray creation · 7241adc0
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124213
      
      Reviewed by Andreas Kling.
      
      Get rid of the various ImmutableArray::adopt functions and have a single create function instead.
      Use std::move to avoid unnecessarily copying vector data.
      
      * Shared/API/c/WKArray.cpp:
      (WKArrayCreate):
      (WKArrayCreateAdoptingValues):
      * Shared/Cocoa/WKNSArray.mm:
      (-[WKNSArray copyWithZone:]):
      * Shared/ImmutableArray.cpp:
      (WebKit::ImmutableArray::create):
      (WebKit::ImmutableArray::createStringArray):
      (WebKit::ImmutableArray::ImmutableArray):
      * Shared/ImmutableArray.h:
      (WebKit::ImmutableArray::at):
      (WebKit::ImmutableArray::size):
      (WebKit::ImmutableArray::entries):
      * Shared/ImmutableDictionary.cpp:
      (WebKit::ImmutableDictionary::keys):
      * Shared/MutableArray.cpp:
      (WebKit::MutableArray::MutableArray):
      (WebKit::MutableArray::append):
      (WebKit::MutableArray::reserveCapacity):
      (WebKit::MutableArray::removeItemAtIndex):
      * Shared/SecurityOriginData.cpp:
      (WebKit::performAPICallbackWithSecurityOriginDataVector):
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebArchive.cpp:
      (WebKit::WebArchive::subresources):
      (WebKit::WebArchive::subframeArchives):
      * Shared/WebContextMenuItem.cpp:
      (WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
      * UIProcess/API/C/mac/WKContextPrivateMac.mm:
      (WKContextGetInfoForInstalledPlugIns):
      * UIProcess/StatisticsRequest.cpp:
      (WebKit::StatisticsRequest::completedRequest):
      * UIProcess/WebBackForwardList.cpp:
      (WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
      (WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
      * UIProcess/WebDatabaseManagerProxy.cpp:
      (WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
      (WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
      * UIProcess/WebKeyValueStorageManager.cpp:
      (WebKit::didGetKeyValueStorageOrigins):
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::didChangeBackForwardList):
      * UIProcess/WebPageContextMenuClient.cpp:
      (WebKit::WebPageContextMenuClient::showContextMenu):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::relatedPages):
      (WebKit::WebPageProxy::didFindStringMatches):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::originsWithApplicationCache):
      * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
      (WebKit::InjectedBundleBackForwardListItem::children):
      * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
      (WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::childFrames):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::trackedRepaintRects):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7241adc0
    • timothy_horton@apple.com's avatar
      Fix accessibility/aria-help after r159067. · 1641b4bb
      timothy_horton@apple.com authored
      It's failing everywhere because the path to its script is wrong.
      
      * accessibility/aria-help.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1641b4bb
    • ossy@webkit.org's avatar
      The last URTBF after r159108 to make GTK happy. · 82f3ae4f
      ossy@webkit.org authored
      * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82f3ae4f
    • ossy@webkit.org's avatar
      One more URTBF after r159108, I hope the last one. · a159dac6
      ossy@webkit.org authored
      * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a159dac6
    • aestes@apple.com's avatar
      [iOS] Define JSC_OBJC_API_ENABLED · 695a7f50
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124192
      
      Reviewed by Geoffrey Garen.
      
      * API/JSBase.h: JSC_OBJC_API_ENABLED should evaluate to true if
      TARGET_OS_IPHONE is true.
      * API/JSValue.h: Ensure CG types referenced later in the file are defined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      695a7f50
    • timothy_horton@apple.com's avatar
      Remote Layer Tree: Assertions during layer flushing after replaceSublayer() · 744bfb9b
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124194
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
      (PlatformCALayerRemote::replaceSublayer):
      Only remove the old layer from the children array once (via removeFromSuperlayer).
      Update the superlayer backpointer on the new layer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      744bfb9b
    • andersca@apple.com's avatar
      Add ImmutableArray::createStringArray · 59e56558
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124210
      
      Reviewed by Andreas Kling.
      
      Creating an ImmutableArray of WebStrings is a common operation, so add a
      helper function to ImmutableArray that does this from a Vector of Strings.
      
      * Shared/ImmutableArray.cpp:
      (WebKit::ImmutableArray::createStringArray):
      * Shared/ImmutableArray.h:
      * Shared/ImmutableDictionary.cpp:
      (WebKit::ImmutableDictionary::keys):
      * Shared/WebOpenPanelParameters.cpp:
      (WebKit::WebOpenPanelParameters::acceptMIMETypes):
      (WebKit::WebOpenPanelParameters::selectedFileNames):
      * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
      (WebKit::WebPluginSiteDataManager::didGetSitesWithData):
      * UIProcess/WebCookieManagerProxy.cpp:
      (WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
      * UIProcess/WebMediaCacheManagerProxy.cpp:
      (WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e56558
    • alex.christensen@flexsim.com's avatar
      [WinCairo] Preparation for ENABLE(VIDEO). · 0e4d08bf
      alex.christensen@flexsim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57420
      
      Reviewed by Martin Robinson.
      
      Source/WebCore: 
      
      * platform/FileSystem.h:
      * platform/graphics/MediaPlayer.cpp:
      * rendering/RenderMediaControls.cpp:
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderThemeWin::adjustSliderThumbSize):
      Separated CG code from GStreamer code.
      
      Source/WebKit/win: 
      
      * FullscreenVideoController.cpp:
      Don't compile if using GStreamer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e4d08bf
    • akling@apple.com's avatar
      Remove body onload handler from html5-8266.html that was causing · 31b95729
      akling@apple.com authored
      the test to sometimes finish before doing anything interesting.
      
      Unskip Parser/HTML5-8266-FullRender.html now that it's stable.
      
      Rubber-stamped by Antti Koivisto.
      
      * Parser/resources/html5-8266.html:
      * Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31b95729
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 36ba3413
      m.pakula@samsung.com authored
      Skip media/media-source tests, as EFL port does not support MEDIA_SOURCE.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36ba3413
    • commit-queue@webkit.org's avatar
      Fix reported build warnings for GTK · 98e3802f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123439
      
      Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-12
      Reviewed by Carlos Garcia Campos.
      
      There was a void method, that has return value in it's documentation, so I removed it.
      
      * bindings/gobject/WebKitDOMCustom.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98e3802f
    • ossy@webkit.org's avatar
      One more URTBF after r159108. · 92b18b1a
      ossy@webkit.org authored
      * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92b18b1a
    • andersca@apple.com's avatar
      Begin cleaning up handling of ImmutableArray vectors · 188fa89f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124208
      
      Reviewed by Andreas Kling.
      
      Use range based for to iterate the loops. Use reserveInitialCapacity + uncheckedAppend
      when appending vector elements.
      
      * Shared/SecurityOriginData.cpp:
      (WebKit::performAPICallbackWithSecurityOriginDataVector):
      * Shared/WebArchive.cpp:
      (WebKit::WebArchive::subresources):
      (WebKit::WebArchive::subframeArchives):
      * Shared/WebContextMenuItem.cpp:
      (WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
      * Shared/WebOpenPanelParameters.cpp:
      (WebKit::WebOpenPanelParameters::acceptMIMETypes):
      (WebKit::WebOpenPanelParameters::selectedFileNames):
      * UIProcess/API/C/mac/WKContextPrivateMac.mm:
      (WKContextGetInfoForInstalledPlugIns):
      * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
      (WebKit::WebPluginSiteDataManager::didGetSitesWithData):
      * UIProcess/StatisticsRequest.cpp:
      (WebKit::StatisticsRequest::completedRequest):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
      * UIProcess/WebCookieManagerProxy.cpp:
      (WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
      * UIProcess/WebDatabaseManagerProxy.cpp:
      (WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
      (WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
      * UIProcess/WebMediaCacheManagerProxy.cpp:
      (WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
      * UIProcess/WebPageContextMenuClient.cpp:
      (WebKit::WebPageContextMenuClient::showContextMenu):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::relatedPages):
      (WebKit::WebPageProxy::didFindStringMatches):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::originsWithApplicationCache):
      * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
      (WebKit::InjectedBundleBackForwardListItem::children):
      * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
      (WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::trackedRepaintRects):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      188fa89f
    • commit-queue@webkit.org's avatar
      Fix undefined reference issues in JavaScriptCore build. · fc6d4eae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124152
      
      Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-12
      Reviewed by Michael Saboff.
      
      Missing includes added.
      
      * runtime/SymbolTable.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc6d4eae
    • zandobersek@gmail.com's avatar
      Manage StorageThread through std::unique_ptr · d554bbb9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124197
      
      Reviewed by Anders Carlsson.
      
      New StorageThread objects are crafted through std::make_unique. This removes the need for the static
      StorageThread::create() method but requires that the StorageThread constructor is made public.
      
      * storage/StorageSyncManager.cpp:
      (WebCore::StorageSyncManager::StorageSyncManager):
      * storage/StorageSyncManager.h:
      * storage/StorageThread.cpp:
      * storage/StorageThread.h:
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::StorageTracker):
      * storage/StorageTracker.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d554bbb9
    • zandobersek@gmail.com's avatar
      Remove unnecessary PassOwnPtr.h header includes under Source/WebCore/fileapi · 54afa34e
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124196
      
      Reviewed by Anders Carlsson.
      
      PassOwnPtr is not used anywhere under Source/WebCore/fileapi/, so PassOwnPtr.h inclusions can be removed.
      
      * fileapi/Blob.h:
      * fileapi/FileThread.h:
      * fileapi/FileThreadTask.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54afa34e
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · d7535571
      zandobersek@gmail.com authored
      * platform/gtk/js/dom/global-constructors-attributes-expected.txt: Rebaseline after new constructors
      were made available with enabling the Media Stream feature.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7535571
    • ossy@webkit.org's avatar
      One more URTBF after r159108. · 28570381
      ossy@webkit.org authored
      * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28570381
    • ossy@webkit.org's avatar
      URTBF after r159108. · de95dc1f
      ossy@webkit.org authored
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de95dc1f
    • achicu@adobe.com's avatar
      Web Inspector: Crash when closing the Inspector while debugging an exception... · ff170404
      achicu@adobe.com authored
      Web Inspector: Crash when closing the Inspector while debugging an exception inside a breakpoint condition.
      https://bugs.webkit.org/show_bug.cgi?id=124078
      
      Reviewed by Joseph Pecoraro.
      
      Source/JavaScriptCore:
      
      The crash would happen because the Debugger is not designed to support nested
      breaks. For example, when the debugger handles a breakpoint and the Inspector
      executes a console command that would hit the breakpoint again, the Debugger
      will just ignore the breakpoint.
      
      There were no checks for conditions and actions. Because of that conditions and actions
      could trigger exceptions and breakpoints. This patch disables that functionality as it
      cannot be supported without a bigger rewrite of the code.
      
      * debugger/Debugger.cpp:
      (JSC::TemporaryPausedState::TemporaryPausedState):
      (JSC::TemporaryPausedState::~TemporaryPausedState):
      (JSC::Debugger::hasBreakpoint):
      (JSC::Debugger::pauseIfNeeded):
      * debugger/Debugger.h:
      
      LayoutTests:
      
      Checking that the debugger will not crash nor stall when exceptions are throw while the debugger
      is already paused. The cases when that can happen include breakpoint conditions, actions, eval
      or runtime object inspection.
      
      The current behavior was to ignore the exceptions or breakpoints while executing "console commands"
      when the debugger was already paused. I'm extending this mechanism to breakpoint conditions and
      actions as the Debugger is not designed to support nested "debugger breaks".
      
      * http/tests/inspector-protocol/resources/protocol-test.js:
      (closeTest): Avoid having internals.closeDummyInspectorFrontend and testRunner.notifyDone
      in the same function. The debugger will not have a chance to exit the temporary EventLoop
      before loading the next test.
      * inspector-protocol/debugger/breakpoint-action-detach-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-action-detach.html: Added.
      * inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-action-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-condition-detach-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-condition-detach.html: Added.
      * inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-condition-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-eval-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff170404
    • commit-queue@webkit.org's avatar
      [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py · 7b949ac2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124144
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-12
      Reviewed by Gustavo Noronha Silva.
      
      Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
      according to http://build.webkit.org/builders.
      
      * Scripts/webkitpy/port/builders.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b949ac2
    • andersca@apple.com's avatar
      Move StringReference to Platform/IPC · 96fe6840
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124203
      
      Reviewed by Antti Koivisto.
      
      * Platform/IPC/StringReference.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.cpp.
      (CoreIPC::StringReference::toString):
      (CoreIPC::StringReference::encode):
      (CoreIPC::StringReference::decode):
      (CoreIPC::StringReference::Hash::hash):
      * Platform/IPC/StringReference.h: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.h.
      (CoreIPC::StringReference::StringReference):
      (CoreIPC::StringReference::isEmpty):
      (CoreIPC::StringReference::size):
      (CoreIPC::StringReference::data):
      (CoreIPC::StringReference::operator==):
      (CoreIPC::StringReference::Hash::equal):
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96fe6840
    • mario@webkit.org's avatar
      Unreviewed GTK gardening. Share expectations for vertical text among WK1 and WK2. · 27c6d69d
      mario@webkit.org authored
      * platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
      * platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
      * platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
      * platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
      * platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27c6d69d
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 1dcb0819
      m.pakula@samsung.com authored
      Mark 73 tests as failing/skipped after r158954.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dcb0819
    • antti@apple.com's avatar
      Text on simple lines sometimes paints one pixel off · cbdae682
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124200
      
      Reviewed by Andreas Kling.
      
      Source/WebCore: 
      
      Test: fast/text/line-runs-simple-lines.html
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::adjustRunOffsets):
              
          Don't round on run construction time.
      
      (WebCore::SimpleLineLayout::createTextRuns):
      * rendering/SimpleLineLayoutResolver.h:
      (WebCore::SimpleLineLayout::RunResolver::Run::rect):
              
          Instead round when generating rects.
      
      (WebCore::SimpleLineLayout::RunResolver::Run::baseline):
              
          Provide the baseline (used by painting) as unrounded FloatPoint.
      
      LayoutTests: 
      
      * fast/text/line-runs-rounding-simple-lines-expected.html: Added.
      * fast/text/line-runs-rounding-simple-lines.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbdae682
    • akling@apple.com's avatar
      Elements with class names automatically get unique ElementData. · e5720746
      akling@apple.com authored
      <https://webkit.org/b/124184>
      
      We were calling Element::ensureUniqueElementData() for all Elements
      with a non-empty list of class names. Doing that on parser-fresh
      Elements caused us to upgrade them to UniqueElementData despite not
      needing it (ElementData::setClass() is a const function for caching
      the "cooked" class and can be called on ShareableElementData.)
      
      1.09 MB progression on HTML5 spec at <http://whatwg.org/c>
      
      Reviewed by Antti Koivisto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5720746
    • berto@igalia.com's avatar
      Webkit - Updated Tamil translation · 6a9e57e3
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124142
      
      Patch by Shantha kumar <shkumar@redhat.com> on 2013-11-12
      Reviewed by Gustavo Noronha Silva.
      
      * ta.po: updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a9e57e3
    • akling@apple.com's avatar
      Neutralize external resource loads in the new HTML5 spec copy. · 0a0c12da
      akling@apple.com authored
      Skip Parser/HTML5-8266-FullRender.html until I can make it less flaky.
      
      * Parser/resources/html5-8266.html:
      * Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a0c12da
    • akling@apple.com's avatar
      Import a fresh version of the full HTML5 spec for perf testing. · 9b6223e3
      akling@apple.com authored
      Rubber-stamped by Antti Koivisto.
      
      * Parser/HTML5-8266-FullRender.html: Added.
      * Parser/HTML5-8266-ParseOnly.html: Added.
      * Parser/resources/html5-8266.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b6223e3