1. 18 Sep, 2009 1 commit
    • mitz@apple.com's avatar
      WebCore: Fix <rdar://problem/7050773> REGRESSION (r40098) Crash at · ca290e54
      mitz@apple.com authored
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      Test: accessibility/nested-layout-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::updateBackingStore): Changed to
          call Document::updateLayoutIgnorePendingStylesheets() instead of
          calling RenderObject::layoutIfNeeded(). The latter requires that
          there be no pending style recalc, which allows methods that call
          Document::updateLayout() to be called during layout without risking
          re-entry into layout.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check
          m_object after calling updateBackingStore(), since style recalc may
          destroy the renderer, which destroys the accessibility object and
          detaches it from the wrapper.
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
           Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
          Ditto.
      
      LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      * accessibility/nested-layout-crash-expected.txt: Added.
      * accessibility/nested-layout-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca290e54
  2. 25 Aug, 2009 1 commit
    • eric.carlson@apple.com's avatar
      2009-08-25 Eric Carlson <eric.carlson@apple.com> · c7790787
      eric.carlson@apple.com authored
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible (edit)
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Test: accessibility/media-element.html
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
                  Add AccessibilityMediaControls.cpp/.h
      
              * accessibility/AXObjectCache.cpp:
              * accessibility/AXObjectCache.h:
              (WebCore::AXObjectCache::getOrCreate):
                  Create AccessibilityMediaControl. Update Copyright
      
              * accessibility/AccessibilityMediaControls.cpp:
              * accessibility/AccessibilityMediaControls.h:
                  Added.
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityObject.h:
                  Add isMediaTimeline. Update Copyright.
      
              * accessibility/AccessibilitySlider.h:
                  Make constructor protected instead of private so AccessibilityMediaTimeline can
                  call it.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
                  Add NSAccessibilityValueDescriptionAttribute to range attributes. 
              (-[AccessibilityObjectWrapper subrole]):
                  Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
      
              * dom/Node.h:
                  add isMediaControlElement.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::localizedMediaControlElementString): 
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription): 
                  New, return localized media controller strings.
      
              * platform/gtk/LocalizedStringsGtk.cpp:
              (WebCore::mediaElementLoadingStateText):
              (WebCore::mediaElementLiveBroadcastStateText):
                  Move inside of "#if ENABLE(VIDEO)"
              (WebCore::localizedMediaControlElementString):
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription):
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlElement::MediaControlElement):
                  Initialize m_displayType.
              (WebCore::MediaControlElement::MediaControlElement):
              (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
                  Fix style.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  Set m_displayType based on pseudo style ID.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  rename local "o" to "object".
              (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
              (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
              (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
              (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
              (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
                  Update for MediaControlInputElement constructor change.
              (WebCore::MediaControlTimeDisplayElement::formatTime):
                  New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
              (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
                  New, set text to current time.
              * rendering/MediaControlElements.h:
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateControls):
                  Create controls in tab order.
              (WebCore::RenderMedia::formatTime):
                  Moved to MediaControlTimeDisplayElement::formatTime.
              (WebCore::RenderMedia::updateTimeDisplay):
                  Call MediaControlTimeDisplayElement::setCurrentValue.
              * rendering/RenderMedia.h:
      
      2009-08-25  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Add localized strings for media controller accessiblility.
      
              * English.lproj/Localizable.strings:
      
      2009-08-25  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory localizedMediaControlElementString:]):
              (-[WebViewFactory localizedMediaControlElementHelpText:]):
              (-[WebViewFactory localizedMediaTimeDescription:]):
                  New.
      
      2009-08-25  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaControlElementString):
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription):
                  New.
      
      2009-08-25  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * accessibility/media-element.html: Added.
              * platform/mac/accessibility/media-element-expected.txt: Added.
              * media/video-controls-visible-audio-only.html:
              * platform/mac-leopard/accessibility/media-element-expected.txt: Added.
              * platform/mac-leopard/media/controls-drag-timebar-expected.txt: Added.
              * platform/mac-leopard/media/controls-strict-expected.txt: Added.
              * platform/mac-leopard/media/video-controls-rendering-expected.txt: Added.
              * platform/mac-leopard/media/video-display-toggle-expected.txt: Added.
              * platform/win/media/controls-strict-expected.txt: Added.
              * platform/win/media/video-controls-rendering-expected.txt: Added.
              * platform/win/media/video-display-toggle-expected.txt: Added.
                  Added.
      
              * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
              * platform/mac-leopard/media/controls-after-reload-expected.txt:
              * platform/mac-leopard/media/controls-styling-expected.txt:
              * platform/mac-leopard/media/video-zoom-controls-expected.txt:
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
              * platform/win/media/audio-controls-rendering-expected.txt:
              * platform/win/media/controls-after-reload-expected.txt:
              * platform/win/media/controls-drag-timebar-expected.txt:
              * platform/win/media/controls-styling-expected.txt:
                  Update for controller element tab order change.
      
              * platform/gtk/Skipped:
              * platform/win/Skipped:
                  Skip new test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7790787
  3. 21 Aug, 2009 1 commit
  4. 16 Aug, 2009 1 commit
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe... · edb53c3f
      ddkilzer@apple.com authored
              <http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates
      
              Reviewed by Dan Bernstein.
      
      WebCore:
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetSpelling): Changed MIN() to min().
              * platform/graphics/mac/FontMacATSUI.mm:
              (WebCore::Font::selectionRectForComplexText): Changed MAX() to
              max() and MIN() to min().
              (WebCore::Font::floatWidthForComplexText): Ditto.
              * platform/graphics/mac/SimpleFontDataMac.mm: Added using
              std::max statement.
              (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
              * platform/text/mac/TextCodecMac.cpp:
              (WebCore::TextCodecMac::decode): Changed MIN() to min().
      
      WebKit/mac:
      
              * Plugins/WebBaseNetscapePluginStream.mm: Added using std::min
              statement.
              (WebNetscapePluginStream::deliverData): Changed MIN() to min().
              Changed C-style cast to a static_cast.
              * Plugins/WebNetscapePluginView.mm: Added using std::min
              statement.
              (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
              Changed MIN() to min().  Changed C-style cast to a static_cast.
              * WebView/WebHTMLView.mm: Added using std::max statement.
              (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to
              max().
              (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
              * WebView/WebTextCompletionController.mm: Added using std::max
              and using std::min statements.
              (-[WebTextCompletionController _placePopupWindow:]): Changed
              type of maxWidth variable from float to CGFloat to prevent a
              type mismatch on x86_64.  Changed MAX() to max() and MIN() to
              min().  Added static_cast for a constant value since CGFloat is
              defined as a float on i386 and as a double on x86_64.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edb53c3f
  5. 12 Aug, 2009 3 commits
    • andersca@apple.com's avatar
      As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113... · 4e29e672
      andersca@apple.com authored
      As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e29e672
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · 6a6009e7
      eric.carlson@apple.com authored
              Tiger build fix.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm: 
                  Define NSAccessibilityTimelineSubrole for Tiger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a6009e7
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · cd791f33
      eric.carlson@apple.com authored
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Test: accessibility/media-element.html
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
                  Add AccessibilityMediaControls.cpp/.h
      
              * accessibility/AXObjectCache.cpp:
              * accessibility/AXObjectCache.h:
              (WebCore::AXObjectCache::getOrCreate):
                  Create AccessibilityMediaControl. Update Copyright
      
              * accessibility/AccessibilityMediaControls.cpp:
              * accessibility/AccessibilityMediaControls.h:
                  Added.
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityObject.h:
                  Add isMediaTimeline. Update Copyright.
      
              * accessibility/AccessibilitySlider.h:
                  Make constructor protected instead of private so AccessibilityMediaTimeline can
                  call it.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
                  Add NSAccessibilityValueDescriptionAttribute to range attributes. 
              (-[AccessibilityObjectWrapper subrole]):
                  Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
      
              * dom/Node.h:
                  add isMediaControlElement.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::localizedMediaControlElementString): 
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription): 
                  New, return localized media controller strings.
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlElement::MediaControlElement):
                  Initialize m_displayType.
              (WebCore::MediaControlElement::MediaControlElement):
              (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
                  Fix style.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  Set m_displayType based on pseudo style ID.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  rename local "o" to "object".
              (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
              (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
              (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
              (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
              (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
                  Update for MediaControlInputElement constructor change.
              (WebCore::MediaControlTimeDisplayElement::formatTime):
                  New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
              (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
                  New, set text to current time.
              * rendering/MediaControlElements.h:
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateControls):
                  Create controls in tab order.
              (WebCore::RenderMedia::formatTime):
                  Moved to MediaControlTimeDisplayElement::formatTime.
              (WebCore::RenderMedia::updateTimeDisplay):
                  Call MediaControlTimeDisplayElement::setCurrentValue.
              * rendering/RenderMedia.h:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Add localized strings for media controller accessiblility.
      
              * English.lproj/Localizable.strings:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory localizedMediaControlElementString:]):
              (-[WebViewFactory localizedMediaControlElementHelpText:]):
              (-[WebViewFactory localizedMediaTimeDescription:]):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaControlElementString):
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * accessibility/media-element.html: Added.
              * platform/mac-leopard/accessibility/media-element-expected.txt:
              * platform/mac-leopard/media/controls-strict-expected.txt: 
              * platform/mac/accessibility/media-element-expected.txt:
                  Added.
      
              * platform/mac-leopard/media/controls-after-reload-expected.txt:
              * platform/mac-leopard/media/controls-styling-expected.txt:
              * platform/mac-leopard/media/video-empty-source-expected.txt:
              * platform/mac-leopard/media/video-zoom-controls-expected.txt:
              * media/video-controls-visible-audio-only.html:
              * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-controls-rendering-expected.txt:
              * platform/mac/media/video-display-toggle-expected.txt:
              * platform/mac/media/video-empty-source-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
                  Update for controller element tab order change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd791f33
  6. 11 Aug, 2009 1 commit
    • cfleizach@apple.com's avatar
      WebCore: Bug 28200 - ListMarker should be included as part of the text value to parse · d82fd890
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28200
      
      Reviewed by Darin Adler.
      
      When returning text through the marker range attributes, the list marker text should
      also be included. It isn't included by default because a TextIterator is used which
      only looks at Nodes for text. A list marker does not have a corresponding node,
      so its text is not returned through accessibility. That is, until now.
      
      Test: platform/mac/accessibility/string-range-contains-listmarker.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::listMarkerTextForRange):
      (WebCore::AccessibilityObject::stringForVisiblePositionRange):
      * accessibility/AccessibilityObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      * rendering/RenderListItem.h:
      
      Make markerText() public so that accessibility code can access it.
      
      WebKitTools: Bug 28200 - ListMarker should be included as part of the text value to parse
      https://bugs.webkit.org/show_bug.cgi?id=28200
      
      Reviewed by Darin Adler.
      
      Add the ability to retrieve a string given a plain NSRange.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (stringForRangeCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::valueDescription):
      (AccessibilityUIElement::stringForRange):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::stringForRange):
      
      LayoutTests: Bug 28200 - ListMarker should be included as part of the text value to parse
      https://bugs.webkit.org/show_bug.cgi?id=28200
      
      Reviewed by Darin Adler.
      
      Tests for checking that the list marker text is included when asking for text 
      through accessibility.
      
      * platform/mac/accessibility/bounds-for-range-expected.txt.
      * platform/mac/accessibility/string-range-contains-listmarker-expected.txt: Added.
      * platform/mac/accessibility/string-range-contains-listmarker.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d82fd890
  7. 06 Aug, 2009 1 commit
    • cfleizach@apple.com's avatar
      2009-08-06 Chris Fleizach <cfleizach@apple.com> · 92d485ea
      cfleizach@apple.com authored
              Reviewed by Eric Seidel.
      
              Bug 27956 - AX: roleValue should be cached for performance
              https://bugs.webkit.org/show_bug.cgi?id=27956
      
              Caches the role value of an accessibility object instead of calculating it everytime.
              The changes gained a 5% speedup using VoiceOver to navigate a webpage.
      
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::handleAriaRoleChanged):
      
              Use generic role setter instead of specific ARIA role setter.
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::AccessibilityObject):
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::headingLevel):
      
              Make headingLevel into instance method so that it can *safely* be called in the constructor.
      
              (WebCore::AccessibilityObject::setRoleValue):
              (WebCore::AccessibilityObject::roleValue):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
              (WebCore::AccessibilityRenderObject::headingLevel):
              (WebCore::AccessibilityRenderObject::intValue):
              (WebCore::AccessibilityRenderObject::updateAccessibilityRole):
              (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetHeadingLevel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92d485ea
  8. 05 Aug, 2009 1 commit
    • cfleizach@apple.com's avatar
      WebCore: · 399016cc
      cfleizach@apple.com authored
      2009-08-05  Chris Fleizach  <cfleizach@apple.com>
      
              Fix Tiger build breakage.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
      
      WebKitTools:
      
      2009-08-05  chris fleizach  <cfleizach@apple.com>
      
              Fix Tiger build breakage.
      
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      399016cc
  9. 04 Aug, 2009 3 commits
    • cfleizach@apple.com's avatar
      WebCore: · 9b3fa5bb
      cfleizach@apple.com authored
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              Test: platform/mac/accessibility/aria-valuetext.html
      
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::valueDescription):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::valueDescription):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
              * html/HTMLAttributeNames.in:
      
      WebKitTools:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              Expose valueDescription for accessibility. 
      
              * DumpRenderTree/AccessibilityUIElement.cpp:
              (getValueDescriptionCallback):
              (AccessibilityUIElement::getJSClass):
              * DumpRenderTree/AccessibilityUIElement.h:
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
              (AccessibilityUIElement::valueDescription):
              * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
              (AccessibilityUIElement::valueDescription):
      
      LayoutTests:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              * platform/mac/accessibility/aria-valuetext-expected.txt: Added.
              * platform/mac/accessibility/aria-valuetext.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3fa5bb
    • cfleizach@apple.com's avatar
      WebCore: · 2365e885
      cfleizach@apple.com authored
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Expose appropriate actions and attributes for sliders.
      
              Test: platform/mac/accessibility/slider-supports-actions.html
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::orientation):
              * accessibility/AccessibilityObject.h:
              (WebCore::):
              * accessibility/AccessibilitySlider.cpp:
              (WebCore::AccessibilitySlider::orientation):
              * accessibility/AccessibilitySlider.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityActionNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      WebKitTools:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Add ability to check if any arbitrary action is supported.
      
              * DumpRenderTree/AccessibilityUIElement.cpp:
              (isActionSupportedCallback):
              (AccessibilityUIElement::getJSClass):
              * DumpRenderTree/AccessibilityUIElement.h:
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
              (AccessibilityUIElement::isActionSupported):
              * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
              (AccessibilityUIElement::isActionSupported):
      
      LayoutTests:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Update tests to use more generic isActionSupported.
      
              * accessibility/aria-link-supports-press.html:
              * accessibility/button-press-action.html:
              * accessibility/onclick-handlers.html:
              * platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
              * platform/mac/accessibility/slider-supports-actions.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2365e885
    • cfleizach@apple.com's avatar
  10. 03 Aug, 2009 2 commits
    • cfleizach@apple.com's avatar
    • eric.carlson@apple.com's avatar
      2009-08-03 Eric Carlson <eric.carlson@apple.com> · 7d12a642
      eric.carlson@apple.com authored
              Reviewed by Eric Seidel.
      
              HTMLInputElement is not controllable by assistive technologies
              https://bugs.webkit.org/show_bug.cgi?id=27941
      
              Test: accessibility/input-slider.html
      
              * WebCore.xcodeproj/project.pbxproj:
                  Add AccessibilitySlider.cpp/.h
      
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::getOrCreate):
                  Create AccessibilitySlider and AccessibilitySliderThumb.
      
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::increment):
              (WebCore::AccessibilityObject::decrement):
                  Add default, do nothing, base class methods.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
                  Correct typo.
      
              * accessibility/AccessibilitySlider.cpp: Added.
              (WebCore::AccessibilitySlider::AccessibilitySlider):
              (WebCore::AccessibilitySlider::create):
              (WebCore::AccessibilitySlider::children):
              (WebCore::AccessibilitySlider::addChildren):
              (WebCore::AccessibilitySlider::getAttribute):
              (WebCore::AccessibilitySlider::valueForRange):
              (WebCore::AccessibilitySlider::maxValueForRange):
              (WebCore::AccessibilitySlider::minValueForRange):
              (WebCore::AccessibilitySlider::changeValue):
              (WebCore::AccessibilitySlider::setValue):
              (WebCore::AccessibilitySlider::increment):
              (WebCore::AccessibilitySlider::decrement):
              (WebCore::AccessibilitySlider::element):
              (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
              (WebCore::AccessibilitySliderThumb::create):
              (WebCore::AccessibilitySliderThumb::elementRect):
              (WebCore::AccessibilitySliderThumb::size):
              * accessibility/AccessibilitySlider.h: Added.
              (WebCore::AccessibilitySlider::~AccessibilitySlider):
              (WebCore::AccessibilitySlider::roleValue):
              (WebCore::AccessibilitySlider::accessibilityIsIgnored):
              (WebCore::AccessibilitySlider::isSlider):
              (WebCore::AccessibilitySlider::canSetValueAttribute):
              (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
              (WebCore::AccessibilitySliderThumb::roleValue):
              (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
              (WebCore::AccessibilitySliderThumb::setParentObject):
              (WebCore::AccessibilitySliderThumb::parentObject):
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (RoleEntry::):
                  SliderThumbRole -> NSAccessibilityValueIndicatorRole
              (-[AccessibilityObjectWrapper roleDescription]):
                  Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
                  Minor coding style correction.
              (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
                  If attachement view handles press action, don't also call object wrapper.
              (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
                  New, call object's increment() method.
              (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
                  New, call object's decrement() method.
              (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
                  Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.
      
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::thumbRect):
                  Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.
              (WebCore::RenderSlider::layout):
                  Move code to thumbRect().
              * rendering/RenderSlider.h:
      
      2009-08-03  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Eric Seidel.
      
              HTMLInputElement is not controllable by assistive technologies
              https://bugs.webkit.org/show_bug.cgi?id=27941
      
              Accessibility control of a slider required adding increment() and decrement()
              methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.
      
              * DumpRenderTree/AccessibilityUIElement.cpp:
              (incrementCallback): New, call UI element increment method.
              (decrementCallback): New, call UI element decrement method.
              (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
      
              * DumpRenderTree/AccessibilityUIElement.h:
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
              (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper.
              (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
      
              * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
              (AccessibilityUIElement::increment): New, do nothing.
              (AccessibilityUIElement::decrement): New, do nothing.
      
      2009-08-03  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Eric Seidel.
      
              HTMLInputElement is not controllable by assistive technologies
              https://bugs.webkit.org/show_bug.cgi?id=27941
              
              Add test for <input type=range> accessibility .
      
              * accessibility/input-slider.html: Added.
              * platform/mac/accessibility/input-slider-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d12a642
  11. 29 Jul, 2009 1 commit
  12. 09 Jul, 2009 1 commit
  13. 01 Jul, 2009 1 commit
  14. 24 Jun, 2009 1 commit
  15. 15 Jun, 2009 1 commit
  16. 18 May, 2009 1 commit
  17. 13 May, 2009 1 commit
  18. 05 May, 2009 1 commit
  19. 29 Apr, 2009 3 commits
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 4e32ebc3
      eric@webkit.org authored
              Make m_offset private and change all callers to use deprecatedEditingOffset().
              https://bugs.webkit.org/show_bug.cgi?id=25472
      
              Per Darin's suggestion, this was just a simple search replace
              of .m_offset with .deprecatedEditingOffset().
      
              There was one change in InsertParagraphSeparatorCommand::doApply to use
              Position::moveToOffset(0) instead of .m_offset = 0;
      
              * dom/Position.cpp:
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              * dom/Position.h:
              (WebCore::Position::deprecatedEditingOffset):
              (WebCore::Position::moveToOffset):
              (WebCore::operator==):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::compareBoundaryPoints):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * page/mac/AccessibilityObjectWrapper.mm:
              (textMarkerForVisiblePosition):
              (visiblePositionForTextMarker):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e32ebc3
    • eric@webkit.org's avatar
      2009-04-29 Eric Seidel <eric@webkit.org> · 3f436f73
      eric@webkit.org authored
              No review, rolling out a patch.
      
              Revert 43020 as it caused accessibility/lists.html to fail
              and no one is around to tell me if it's a progression or not.
      
              * page/AccessibilityObject.h:
              (WebCore::):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::roleValue):
              (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
              * page/mac/AccessibilityObjectWrapper.mm:
              (RoleEntry::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f436f73
    • eric@webkit.org's avatar
      2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com> · f10f5478
      eric@webkit.org authored
              Reviewed by Jon Honeycutt.
      
              Add a new accessibility role for list items. Part of
              http://bugs.webkit.org/show_id.cgi?id=20013
      
              * win/AccessibleBase.cpp:
              (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f10f5478
  20. 21 Apr, 2009 1 commit
  21. 10 Mar, 2009 1 commit
  22. 01 Mar, 2009 1 commit
  23. 25 Feb, 2009 1 commit
    • cfleizach@apple.com's avatar
      Bug 24143: Crash occurs at... · 70b144ce
      cfleizach@apple.com authored
      Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
      https://bugs.webkit.org/show_bug.cgi?id=24143
      
      When an AX object is marked dirty, do not create AX elements while going up the parent chain.
      Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
      Make sure the AXObjectWrapper's have an object before calling them
      In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b144ce
  24. 11 Feb, 2009 1 commit
    • hyatt@apple.com's avatar
      2009-02-11 David Hyatt <hyatt@apple.com> · 7e03253f
      hyatt@apple.com authored
              Combine RenderObject::element() and RenderObject::node() into a single function.  
              node() now has the "anonymous bit" checking behavior of element() and will
              return 0 for anonymous content.  This patch switches all callers of element() 
              to node() and patches old callers of node() to deal with situations where they
              did not expect node() to be 0.  A bunch of node() calls were calling stuff on 
              Document that they clearly didn't intend, so overall this is a nice improvement.
          
              Reviewed by Sam Weinig
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner):
              * dom/Element.cpp:
              (WebCore::Element::offsetParent):
              * dom/Position.cpp:
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::getStartEndListChildren):
              (WebCore::IncreaseSelectionListLevelCommand::doApply):
              (WebCore::DecreaseSelectionListLevelCommand::doApply):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              * page/AXObjectCache.cpp:
              (WebCore::AXObjectCache::get):
              * page/AccessibilityList.cpp:
              (WebCore::AccessibilityList::isUnorderedList):
              (WebCore::AccessibilityList::isOrderedList):
              (WebCore::AccessibilityList::isDefinitionList):
              * page/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isPasswordField):
              (WebCore::AccessibilityRenderObject::isFileUploadButton):
              (WebCore::AccessibilityRenderObject::isInputImage):
              (WebCore::AccessibilityRenderObject::isMultiSelect):
              (WebCore::AccessibilityRenderObject::isControl):
              (WebCore::AccessibilityRenderObject::getAttribute):
              (WebCore::AccessibilityRenderObject::anchorElement):
              (WebCore::AccessibilityRenderObject::actionElement):
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              (WebCore::AccessibilityRenderObject::helpText):
              (WebCore::AccessibilityRenderObject::textUnderElement):
              (WebCore::AccessibilityRenderObject::hasIntValue):
              (WebCore::AccessibilityRenderObject::intValue):
              (WebCore::AccessibilityRenderObject::labelElementContainer):
              (WebCore::AccessibilityRenderObject::title):
              (WebCore::AccessibilityRenderObject::accessibilityDescription):
              (WebCore::AccessibilityRenderObject::boundingBoxRect):
              (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
              (WebCore::AccessibilityRenderObject::titleUIElement):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              (WebCore::AccessibilityRenderObject::text):
              (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
              (WebCore::AccessibilityRenderObject::accessKey):
              (WebCore::AccessibilityRenderObject::setSelectedTextRange):
              (WebCore::AccessibilityRenderObject::url):
              (WebCore::AccessibilityRenderObject::isFocused):
              (WebCore::AccessibilityRenderObject::setFocused):
              (WebCore::AccessibilityRenderObject::setValue):
              (WebCore::AccessibilityRenderObject::isEnabled):
              (WebCore::AccessibilityRenderObject::visiblePositionRange):
              (WebCore::AccessibilityRenderObject::index):
              (WebCore::AccessibilityRenderObject::activeDescendant):
              (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
              (WebCore::AccessibilityRenderObject::observableObject):
              (WebCore::AccessibilityRenderObject::roleValue):
              (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
              (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
              * page/AccessibilityTable.cpp:
              (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
              (WebCore::AccessibilityTable::title):
              * page/AccessibilityTableCell.cpp:
              (WebCore::AccessibilityTableCell::titleUIElement):
              * page/AccessibilityTableColumn.cpp:
              (WebCore::AccessibilityTableColumn::headerObjectForSection):
              * page/AccessibilityTableRow.cpp:
              (WebCore::AccessibilityTableRow::headerObject):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::canMouseDownStartSelect):
              (WebCore::EventHandler::canMouseDragExtendSelect):
              (WebCore::EventHandler::shouldDragAutoNode):
              * page/Frame.cpp:
              (WebCore::Frame::searchForLabelsAboveCell):
              (WebCore::Frame::setFocusedNodeIfNeeded):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::updateStateMachine):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateAnimationTimer):
              (WebCore::AnimationController::cancelAnimations):
              (WebCore::AnimationController::updateAnimations):
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::KeyframeAnimation):
              (WebCore::KeyframeAnimation::endAnimation):
              * page/mac/AccessibilityObjectWrapper.mm:
              (blockquoteLevel):
              (AXAttributeStringSetHeadingLevel):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::searchForNSLabelsAboveCell):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::verticallyAlignBoxes):
              (WebCore::InlineFlowBox::paint):
              (WebCore::shouldDrawTextDecoration):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintDocumentMarkers):
              * rendering/RenderBR.cpp:
              (WebCore::RenderBR::positionForCoordinates):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::handleRunInChild):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::isSelectionRoot):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::positionForBox):
              (WebCore::RenderBlock::positionForRenderer):
              (WebCore::RenderBlock::positionForCoordinates):
              (WebCore::RenderBlock::hasLineIfEmpty):
              (WebCore::RenderBlock::updateFirstLetter):
              (WebCore::RenderBlock::updateHitTestResult):
              (WebCore::RenderBlock::addFocusRingRects):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleWillChange):
              (WebCore::RenderBox::updateBoxModelInfoFromStyle):
              (WebCore::RenderBox::paintRootBoxDecorations):
              (WebCore::RenderBox::positionForCoordinates):
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::updateFromElement):
              (WebCore::RenderButton::canHaveChildren):
              * rendering/RenderCounter.cpp:
              (WebCore::planCounter):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::findLegend):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::translationForAttributes):
              (WebCore::RenderForeignObject::calculateLocalTransform):
              * rendering/RenderFrame.h:
              (WebCore::RenderFrame::element):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paintReplaced):
              (WebCore::RenderImage::imageMap):
              (WebCore::RenderImage::nodeAtPoint):
              (WebCore::RenderImage::updateAltText):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::cloneInline):
              (WebCore::RenderInline::updateHitTestResult):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::isTransparent):
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::resize):
              (WebCore::RenderLayer::createScrollbar):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateScrollInfoAfterLayout):
              (WebCore::RenderLayer::enclosingElement):
              (WebCore::RenderLayer::updateHoverActiveState):
              (WebCore::RenderLayer::updateScrollCornerStyle):
              (WebCore::RenderLayer::updateResizerStyle):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::isRootLayer):
              * rendering/RenderListItem.cpp:
              (WebCore::getParentOfFirstLineBox):
              * rendering/RenderMarquee.cpp:
              (WebCore::RenderMarquee::marqueeSpeed):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::RenderObject):
              (WebCore::RenderObject::isBody):
              (WebCore::RenderObject::isHR):
              (WebCore::RenderObject::isHTMLMarquee):
              (WebCore::RenderObject::isEditable):
              (WebCore::RenderObject::addPDFURLRect):
              (WebCore::RenderObject::showTreeForThis):
              (WebCore::RenderObject::draggableNode):
              (WebCore::RenderObject::hasOutlineAnnotation):
              (WebCore::RenderObject::positionForCoordinates):
              (WebCore::RenderObject::updateDragState):
              (WebCore::RenderObject::updateHitTestResult):
              (WebCore::RenderObject::getUncachedPseudoStyle):
              (WebCore::RenderObject::getTextDecorationColors):
              (WebCore::RenderObject::caretMaxOffset):
              (WebCore::RenderObject::offsetParent):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isRoot):
              (WebCore::RenderObject::isInlineContinuation):
              (WebCore::RenderObject::node):
              (WebCore::RenderObject::setNode):
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::destroyLeftoverChildren):
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::updateWidgetPosition):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
              (WebCore::RenderPartObject::viewCleared):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::calculateLocalTransform):
              (WebCore::RenderPath::layout):
              (WebCore::RenderPath::paint):
              (WebCore::RenderPath::drawMarkersIfNeeded):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::positionForCoordinates):
              (WebCore::RenderReplaced::isSelected):
              * rendering/RenderSVGGradientStop.cpp:
              (WebCore::RenderSVGGradientStop::gradientElement):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::calculateLocalTransform):
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::positionForCoordinates):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::layout):
              (WebCore::RenderSVGRoot::applyContentTransforms):
              (WebCore::RenderSVGRoot::paint):
              (WebCore::RenderSVGRoot::calcViewport):
              (WebCore::RenderSVGRoot::absoluteTransform):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::calculateLocalTransform):
              (WebCore::RenderSVGText::layout):
              * rendering/RenderSVGTextPath.cpp:
              (WebCore::RenderSVGTextPath::layoutPath):
              (WebCore::RenderSVGTextPath::startOffset):
              (WebCore::RenderSVGTextPath::exactAlignment):
              (WebCore::RenderSVGTextPath::stretchMethod):
              * rendering/RenderSVGTransformableContainer.cpp:
              (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::calcViewport):
              (WebCore::RenderSVGViewportContainer::viewportTransform):
              (WebCore::RenderSVGViewportContainer::nodeAtPoint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::addChild):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::updateFromElement):
              (WebCore::RenderTableCell::calcPrefWidths):
              * rendering/RenderTableCol.cpp:
              (WebCore::RenderTableCol::updateFromElement):
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::addChild):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::originalText):
              (WebCore::RenderText::positionForCoordinates):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::nodeAtPoint):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::nodeAtPoint):
              * rendering/RenderTextFragment.cpp:
              (WebCore::RenderTextFragment::originalText):
              (WebCore::RenderTextFragment::previousCharacter):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isActive):
              (WebCore::RenderTheme::isChecked):
              (WebCore::RenderTheme::isIndeterminate):
              (WebCore::RenderTheme::isEnabled):
              (WebCore::RenderTheme::isFocused):
              (WebCore::RenderTheme::isPressed):
              (WebCore::RenderTheme::isReadOnlyControl):
              (WebCore::RenderTheme::isHovered):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::updatePressedState):
              (WebCore::RenderThemeMac::paintMediaFullscreenButton):
              (WebCore::RenderThemeMac::paintMediaMuteButton):
              (WebCore::RenderThemeMac::paintMediaPlayButton):
              (WebCore::RenderThemeMac::paintMediaSeekBackButton):
              (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
              (WebCore::RenderThemeMac::paintMediaSliderTrack):
              (WebCore::RenderThemeMac::paintMediaSliderThumb):
              (WebCore::RenderThemeMac::paintMediaTimelineContainer):
              (WebCore::RenderThemeMac::paintMediaCurrentTime):
              (WebCore::RenderThemeMac::paintMediaTimeRemaining):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMediaMuteButton):
              (WebCore::RenderThemeSafari::paintMediaPlayButton):
              (WebCore::RenderThemeSafari::paintMediaSliderTrack):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<):
              (WebCore::writeSelection):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::setWidgetGeometry):
              (WebCore::RenderWidget::updateWidgetPosition):
              (WebCore::RenderWidget::nodeAtPoint):
              * rendering/RootInlineBox.cpp:
              (WebCore::isEditableLeaf):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::prepareToRenderSVGContent):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildLayoutInformation):
              (WebCore::SVGRootInlineBox::layoutInlineBoxes):
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/style/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::cssPrimitiveToLength):
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk):
              (WebCore::floatWidthOfSubStringUsingSVGFont):
              (WebCore::Font::drawTextUsingSVGFont):
              * svg/SVGTextContentElement.cpp:
              (WebCore::findInlineTextBoxInTextChunks):
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::SVGPaintServer::fillPaintServer):
              (WebCore::SVGPaintServer::strokePaintServer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e03253f
  25. 09 Feb, 2009 1 commit
  26. 02 Feb, 2009 1 commit
    • darin@apple.com's avatar
      JavaScriptCore: · 5241db74
      darin@apple.com authored
      2009-02-02  Darin Adler  <darin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
              https://bugs.webkit.org/show_bug.cgi?id=23676
      
              * API/JSObjectRef.cpp:
              (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
              * parser/Lexer.cpp:
              (JSC::Lexer::Lexer): Ditto.
              (JSC::Lexer::clear): Ditto.
      
              * wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of
              reserveCapacity for use when the vector is brand new (still size 0 with no
              capacity other than the inline capacity).
      
      WebCore:
      
      2009-02-02  Darin Adler  <darin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
              https://bugs.webkit.org/show_bug.cgi?id=23676
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::cssPropertyName):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
              (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::cssText):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::sortMatchedRules):
              * dom/Document.cpp:
              (WebCore::Document::formElementsState):
              * dom/NamedAttrMap.h:
              (WebCore::NamedAttrMap::reserveInitialCapacity):
              * editing/TextIterator.cpp:
              (WebCore::CharacterIterator::string):
              (WebCore::SearchBuffer::SearchBuffer):
              (WebCore::plainTextToMallocAllocatedBuffer):
              * editing/markup.cpp:
              (WebCore::joinMarkups):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem):
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::items):
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::toString):
              * page/mac/AccessibilityObjectWrapper.mm:
              (convertToVector):
              * platform/graphics/FontCache.cpp:
              (WebCore::FontCache::purgeInactiveFontData):
              (WebCore::FontCache::invalidate):
              * platform/network/FormData.cpp:
              (WebCore::FormData::deepCopy):
              * platform/network/HTTPHeaderMap.cpp:
              (WebCore::HTTPHeaderMap::copyData):
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::copyData):
              * platform/network/mac/FormDataStreamMac.mm:
              (WebCore::formCreate):
              * xml/XPathNodeSet.cpp:
              (WebCore::XPath::NodeSet::sort):
              Use reserveInitialCapacity instead of of reserveCapacity in all these call sites,
              which are working on new vectors that are guaranteed not to be empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5241db74
  27. 30 Jan, 2009 1 commit
  28. 29 Jan, 2009 1 commit
    • zimmermann@webkit.org's avatar
      Reviewed by David Hyatt. · 4695eef7
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=23539
      
      Remove several virtual functions from Node & Element related to form control / input elements,
      that shouldn't reside there, but move to approriate locations, in the new form control /
      input element abstract base classes.
      
      Remove the isControl() method from Node, as it's redundant - isFormControlElement() provides the same information.
      Move isEnabled( / isReadOnlyControl() / isTextControl() from Node to FormControlElement.
      Move isAutofilled() / isChecked() / isIndeterminate() from Node to InputElement.
      Move isInputTypeHidden() / isPasswordField() from Element to InputElement.
      
      Querying these methods requires using the toInputElement/toFormControlElement casting helper functions
      to cast Element pointers to InputElement/FormControlElement pointers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4695eef7
  29. 21 Jan, 2009 1 commit
  30. 19 Jan, 2009 1 commit
  31. 16 Jan, 2009 2 commits
  32. 12 Jan, 2009 1 commit
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · faced26e
      darin@apple.com authored
              Reviewed by Oliver Hunt.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Fourth step: Remove arguments entirely in the many cases where they are not
              needed at all. This step is a little less mechanical than the earlier ones.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
              the regular expression, since we already specify a-zA-Z in our expression.
      
              * dom/Document.cpp:
              (WebCore::Document::databaseThread): Don't pass in the document when creating
              a DatabaseThread.
      
              * dom/Element.cpp:
              (WebCore::Element::createRareData): Don't pass the element when creating an
              ElementRareData.
              (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
              (WebCore::Element::recalcStyle): Ditto.
      
              * dom/ElementRareData.h: Remove the unused Element* from the constructor and
              the resetComputedStyle function.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
              (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
              (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
              * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
      
              * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
              start and end arguments.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
              and end to pushDownTextDecorationStyleAroundNode.
      
              * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
              unused start and end arguments from pushDownTextDecorationStyleAroundNode.
      
              * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute): Removed unused Document* argument.
              (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
      
              * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
      
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove): Removed unused DragData argument.
              (WebCore::DragController::performDrag): Call concludeEditDrag rather than
              concludeDrag.
              (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
              (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
              should only be called for edit drags. Removed the action mask argument. Also
              changed dragIsMove call sites to not pass dragData.
      
              * page/DragController.h: Updated for above changes and tweaked comment format.
      
              * page/Frame.cpp:
              (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
      
              * page/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetHeadingLevel): Removed unused object argument.
              (AXAttributedStringAppendText): Ditto.
              (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
      
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * platform/graphics/SegmentedFontData.cpp:
              (WebCore::SegmentedFontData::containsCharacter): Added.
              (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
              instead of just the first one, using containsCharacter.
      
              * platform/graphics/SegmentedFontData.h: Made more members private.
              Added containsCharacter function member.
      
              * platform/mac/DragImageMac.mm:
              (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
              DragImageRef for clarity, since this is platform-specific code.
              (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
              variable warning.
              (WebCore::scaleDragImage): Ditto.
              (WebCore::dissolveDragImageToFraction): Ditto.
              (WebCore::createDragImageFromImage): Ditto.
              (WebCore::createDragImageIconForCachedImage): Ditto.
      
              * platform/mac/WebFontCache.mm:
              (acceptableChoice): Removed the unused weight-related arguments.
              (betterChoice): Ditto.
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
      
              * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
              because we'd rather get a link error rather than a runtime error if we use it
              for anything, and right now it's not used.
      
              * platform/text/RegularExpression.cpp: Removed unused private data,
              including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
              and lastMatchPos. Made the RegularExpression::Private::regex be private
              and use an accessor function to get at it.
              (WebCore::RegularExpression::RegularExpression): Removed the const char* version
              of the constructor because it's not any more efficient. Changed the boolean
              constructor argument to use TextCaseSensitivity instead to make it less likely
              we'll use it wrong.
              (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
              just use plain old assignment on it. The only reason we do this instead of using
              the compiler generated assignment operator is that we want the Private structure
              to be internal to the .cpp file.
              (WebCore::RegularExpression::match): Added a null check so we won't crash if
              we fail to compile the regular expression. Removed the code to handle multiple
              match strings, since that was unused.
      
              * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
              TextCaseSensitivity and not have a default value. Removed the default constructor,
              and the pattern, match, and pos functions.
      
              * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
              Page.h, because we should eventually use it in all the places where we have
              an argument to control case sensitivity, starting with the functions in this
              class.
      
              * platform/text/mac/ShapeArabic.c:
              (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
              this is code borrowed from ICU, this seems like a simple safe change to make.
              (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::RenderPath): Removed the unused style argument.
              Also removed the type check. The argument already has the correct type,
              so it's not helpful to upcast it and then check its type again, unless
              we have some reason to believe the type is not reliable. And we don't.
      
              * rendering/RenderPath.h: Removed the RenderStyle* argument to the
              constructor. Also removed the explicit declaration of the destructor.
              It's not helpful or needed.
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
              make it clear that just returning an empty rect is not a good implementation.
              Removed the argument names to get rid of the warning.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::printBorderStyle): Removed the unused RenderObject argument.
              (WebCore::operator<<): Updated for the change to printBorderStyle function.
      
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
              * storage/DatabaseThread.h: Ditto.
      
              * storage/LocalStorage.cpp:
              (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
              * storage/LocalStorage.h: Ditto.
      
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
              code location to dispatchGenericEvent.
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::dispatchEvent): Ditto.
      
              * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
              (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
              the RenderPath constructor.
      
              * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
      
              * xml/XSLTProcessor.cpp:
              (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
              (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faced26e