GitLab

WebCore::RenderBlock::layoutBlock()
https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

Test: accessibility/nested-layout-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateBackingStore): Changed to
    call Document::updateLayoutIgnorePendingStylesheets() instead of
    calling RenderObject::layoutIfNeeded(). The latter requires that
    there be no pending style recalc, which allows methods that call
    Document::updateLayout() to be called during layout without risking
    re-entry into layout.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check
    m_object after calling updateBackingStore(), since style recalc may
    destroy the renderer, which destroys the accessibility object and
    detaches it from the wrapper.
(-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
(-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
     Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
    Ditto.
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
    Ditto.

LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
WebCore::RenderBlock::layoutBlock()
https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

* accessibility/nested-layout-crash-expected.txt: Added.
* accessibility/nested-layout-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Hausmann.

        Update Qt build system for Web Socket.
        https://bugs.webkit.org/show_bug.cgi?id=29270

        * WebCore.pro:
        * platform/network/qt/SocketStreamError.h: Added.
        * platform/network/qt/SocketStreamHandle.h: Added.
        * platform/network/qt/SocketStreamHandleSoup.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        NULL check HTMLMediaElement::m_playedTimeRanges.
        Fix for https://bugs.webkit.org/show_bug.cgi?id=29494

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::addPlayedRange): New. Create m_playedTimeRanges if
        necessary, add range specified.
        (WebCore::HTMLMediaElement::seek): Use addPlayedRange. 
        (WebCore::HTMLMediaElement::played): Use addPlayedRange. Change time comparison 
        to be more readable.
        (WebCore::HTMLMediaElement::updatePlayState): Ditto.
        * html/HTMLMediaElement.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Build fix.

        Add missing file to the repository.

        * tests/testhittestresult.c: Added.
        (test_info_new):
        (test_info_destroy):
        (hit_test_result_fixture_setup):
        (hit_test_result_fixture_teardown):
        (load_status_cb):
        (test_webkit_hit_test_result):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

refactor much more of the script into functions. Later we can add
parallel test running to the tool. But better structure may help
even if someone decides to translate this into another scripting
language instead.

Patch by Darin Adler <darin@apple.com> on 2009-08-28
Reviewed by Mark Rowe.

* Scripts/run-webkit-tests: Break more pieces of the script into
seprate functions. Added readSkippedFiles, findTestsToRun, and
printResults functions. Removed custom code to skip results.html
and instead just put it into the ignoredFiles hash. Fixed some
indentation. Sorted function declarations, global variables,
and options at the top of the file alphabetically so they're not
in a semi-random order.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Don't use Document.elementFromPoint since it returns null if the point
is outside the viewport.  Instead, just hit test ourselves.

Test: fast/events/drag-file-crash.html

* page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

* fast/events/drag-file-crash-expected.txt: Added.
* fast/events/drag-file-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=29351
rdar://problem/7142294

Patch by Darin Adler <darin@apple.com> on 2009-09-18
Reviewed by Sam Weinig.

* WebCore.base.exp: Added a newly-needed exported symbol.

* bindings/objc/DOMInternal.h: Eliminated unused
createWrapperCacheWithIntegerKeys; it has not been needed since the
RGBColor wrappers were reworked.
* bindings/objc/DOMInternal.mm: Ditto.

* bridge/objc/objc_instance.h: Made the create function non-inline.
* bridge/objc/objc_instance.mm:
(createInstanceWrapperCache): Added. Creates an appropriate map table.
(ObjcInstance::create): Moved here from header. Uses NSMapGet and
NSMapInsert to cache the instance in a map table.
(ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
the instance from the map table.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
the instance from cachedObjects, which no longer exists.
(JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
bottleneck. Caching is now handled by the base class.

* bridge/runtime.cpp:
(JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
(JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
(JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
if it's already set. Set m_runtimeObject and call addRuntimeObject
if it's not.
(JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
used only by createRuntimeObject.
(JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
Calls removeRuntimeObject and then clears m_runtimeObject.
(JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
Clears m_runtimeObject.

* bridge/runtime.h: Made createRuntimeObject non-virtual. Added
willDestroyRuntimeObject, willInvalidateRuntimeObject,
newRuntimeObject, and m_runtimeObject.

* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
call, now handled by caller.
(JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
call with willDestroyRuntimeObject call; the latter nows calls
removeRuntimeObject.
(JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
call.

* bridge/runtime_object.h: Made invalidate non-virtual.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-18
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::platformPageClient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=29085

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.

WebCore:

Make platformWindow return a PlatformPageClient
(for now typedef'ed to PlatformWidget)

Also, change the name of platformWindow to platformPageClient()

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getPangoLayoutForAtk):
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::platformPageClient):
* page/Chrome.cpp:
(WebCore::Chrome::platformPageClient):
* page/Chrome.h:
* page/ChromeClient.h:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::currentPlatformMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
* platform/HostWindow.h:
* platform/Widget.h:
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::show):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
(WebCore::ScrollView::visibleContentRect):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setFocus):
(WebCore::Widget::setCursor):
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::show):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::setCursor):
* platform/win/PlatformScreenWin.cpp:
(WebCore::monitorInfoForWidget):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::wndProc):
* platform/wx/RenderThemeWx.cpp:
(WebCore::nativeWindowForRenderObject):
* platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::paint):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformStart):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::getValue):
(WebCore::PluginView::platformStart):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

WebKit/gtk:

Reflect the rename of platformWindow and it's return type.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::platformPageClient):
(WebKit::ChromeClient::runOpenPanel):
* WebCoreSupport/ChromeClientGtk.h:
* webkit/webkitprivate.cpp:
(currentToplevelCallback):
* webkit/webkitwebview.cpp:
(webkit_web_view_popup_menu_handler):

WebKit/haiku:

Reflect the rename of platformWindow and it's return type.

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::platformPageClient):
* WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

Reflect the rename of platformWindow and it's return type.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::platformPageClient):

WebKit/qt:

Reflect the rename of platformWindow and it's return type.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::platformPageClient):
* WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reflect the rename of platformWindow and it's return type.

* AccessibleBase.cpp:
(AccessibleBase::get_accParent):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::platformPageClient):
* WebCoreSupport/WebChromeClient.h:

WebKit/wx:

Reflect the rename of platformWindow and it's return type.

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::platformPageClient):
* WebKitSupport/ChromeClientWx.h:
* WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::isEditable):
(WebCore::EditorClientWx::registerCommandForUndo):
(WebCore::EditorClientWx::registerCommandForRedo):
(WebCore::EditorClientWx::clearUndoRedoOperations):
(WebCore::EditorClientWx::canUndo):
(WebCore::EditorClientWx::canRedo):
(WebCore::EditorClientWx::undo):
(WebCore::EditorClientWx::redo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

- Hide the close button
- Hide the dock button
- Disable the draggable toolbar

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29384

* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
(WebInspector.toolbarDragStart):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

* JavaScriptCore.pri: Build the ce_time.cpp functions from
within Qt externally.
* wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
Qt build these functions are no external, too.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

Exclude certain pure-WINCE specific code paths from the Qt build.

* platform/graphics/BitmapImage.h:
* platform/graphics/FontCache.h:
* platform/graphics/MediaPlayer.cpp:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
* plugins/PluginView.cpp:
(WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
the corresponding PluginViewWndProc has the same guard in the header file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jan Alonzo.

        Document webkit_web_view_stop_loading.

        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gustavo Noronha and Jan Alonzo.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Add new tests to the build.

        * GNUmakefile.am:

WebKit/gtk:

2009-09-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha and Jan Alonzo.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Add webkit_web_view_get_hit_test_result, a function to get a hit
        test result from a GdkEventButton. Useful to let applications
        decide between several actions on button press depending on what
        is being pressed.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_stop_loading):
        (documentPointForWindowPoint):
        (webkit_web_view_get_hit_test_result):
        * webkit/webkitwebview.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gustavo Noronha and Jan Alonzo.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Add WebKitHitTestResult to the build.

        * GNUmakefile.am:

WebKit/gtk:

2009-09-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha and Jan Alonzo.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
        context information about a point in the web page.

        * webkit/webkit.h:
        * webkit/webkitdefines.h:
        * webkit/webkithittestresult.cpp: Added.
        (webkit_hit_test_result_finalize):
        (webkit_hit_test_result_get_property):
        (webkit_hit_test_result_set_property):
        (webkit_hit_test_result_class_init):
        (webkit_hit_test_result_init):
        * webkit/webkithittestresult.h: Added.
        * webkit/webkitprivate.cpp:
        (WebKit::kit):
        * webkit/webkitprivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

inspector.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

* Api/qwebinspector.cpp:
* QtLauncher/main.cpp:
(main):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):
(WebCore::variantToSetting):
(WebCore::settingToVariant):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        Geolocation does not correctly handle Infinity for PositionOptions properties.
        https://bugs.webkit.org/show_bug.cgi?id=29099

        * fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
        * fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.
2009-09-18  Steve Block  <steveblock@google.com>

        Reviewed by Dimitri Glazkov.

        Geolocation does not correctly handle Infinity for PositionOptions properties.
        https://bugs.webkit.org/show_bug.cgi?id=29099

        * bindings/js/JSGeolocationCustom.cpp: Modified.
        (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
        * page/PositionOptions.h: Modified.
        (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age.
        (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age.
        (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age.
        (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set.
        (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
Reviewed by Ariya Hidayat.

* Api/qwebgraphicsitem.cpp:
* Api/qwebplugindatabase.cpp:
* Api/qwebpluginfactory.cpp:
* Api/qwebsecurityorigin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

* tests/qwebpage/tst_qwebpage.cpp:
(ConsolePage::ConsolePage):
(ConsolePage::javaScriptConsoleMessage):
(tst_QWebPage::consoleOutput):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Document.elementFromPoint now takes point in client space, not page space.

* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        Reimplement default media UI for Mac Chromium to match the style
        of the Windows and Linux versions.  Also breaks the dependency
        on the internal wk* functions that were previously used to
        render the media controller widgets.
        https://bugs.webkit.org/show_bug.cgi?id=29161

        No media layout tests are currently enabled in Mac Chromium, so
        nothing needs rebaselineing, etc.

        This is a recommit of r48438 with a compile fix and merges of
        recent changes to the file.

        * css/mediaControlsChromium.css:
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::mediaElementParent):
        (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
        (WebCore::mediaSliderThumbImage):
        (WebCore::mediaVolumeSliderThumbImage):
        (WebCore::RenderThemeChromiumMac::paintSliderTrack):
        (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal):
        (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
        (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Steve Falkenburg.

        Add failing test on both Windows Debug and Release to the
        Windows Skipped List.
        
        http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
        being tracked by <https://bugs.webkit.org/show_bug.cgi?id=29353>.

        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        The Console scope bar should have a divider between All and the other possible
        values (Errors, Warnings, Logs). It will look something like:
        
        All | Errors Warnings Logs.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement):
        (WebInspector.ConsoleView):
        * inspector/front-end/inspector.css:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        Remove assertions that were being hit by calls to
        m_verticalScrollbar->invalidate(). These assertions were valid,
        but they were causing tests to fail, so replacing with a FIXME 
        until we can find out the real cause/solution that is being tracked 
        by http://webkit.org/b/29350.

        * WebView.cpp:
        (WebView::addToDirtyRegion):
        (WebView::paintIntoBackingStore):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Mark Rowe.

* DerivedSources.cpp:
* WebCore.vcproj/WebCore.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Carlson.

        Media layout tests should have a way to provide test files in different formats
        https://bugs.webkit.org/show_bug.cgi?id=28327

        Updating 19 media layout tests to use media files based on supported codecs.

        * media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port.
        Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure
        findMediaFile() will return test.wav but not test.mp3 or other formats.
        (setSrcById): Fixing bug in code.
        * media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
        * media/video-click-dblckick-standalone.html: ditto.
        * media/video-controls-transformed.html: ditto.
        * media/video-controls-visible-audio-only.html: ditto.
        * media/video-controls-zoomed.html: ditto.
        * media/video-controls.html: ditto.
        * media/video-currentTime-set.html: ditto.
        * media/video-currentTime-set2.html: ditto.
        * media/video-currentTime.html: ditto.
        * media/video-display-none-crash.html: ditto.
        * media/video-display-toggle.html: ditto.
        * media/video-dom-autoplay.html: ditto.
        * media/video-dom-src.html: ditto.
        * media/video-error-abort.html: ditto.
        * media/video-load-networkState.html: ditto.
        * media/video-load-readyState.html: ditto.
        * media/video-loop.html: ditto.
        * media/video-muted.html: ditto.
        * media/video-no-autoplay.html: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Brady Eidson.

* page/DOMWindow.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
        
Reviewed by Oliver Hunt.

Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
crashes while we're calling into it).
        
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp):
(JSC::RuntimeObjectImp::~RuntimeObjectImp):
(JSC::RuntimeObjectImp::invalidate):
(JSC::RuntimeObjectImp::fallbackObjectGetter):
(JSC::RuntimeObjectImp::fieldGetter):
(JSC::RuntimeObjectImp::methodGetter):
(JSC::RuntimeObjectImp::getOwnPropertySlot):
(JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
(JSC::RuntimeObjectImp::put):
(JSC::RuntimeObjectImp::defaultValue):
(JSC::RuntimeObjectImp::getCallData):
(JSC::RuntimeObjectImp::getConstructData):
(JSC::RuntimeObjectImp::getPropertyNames):
* bridge/runtime_object.h:
(JSC::RuntimeObjectImp::getInternalInstance):

WebKit/mac: <rdar://problem/7007541> 
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...

Reviewed by Oliver Hunt.

Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).
        
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
(WebKit::ProxyInstance::invalidate):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        Wrap primitive values (as objects) in InspectorController::wrap.

        https://bugs.webkit.org/show_bug.cgi?id=28983

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies,
         only object proxies will have objectId.
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi
         that accepts an expression and returns possible completions. This way we don't need to wrap
         and unwrap the completions result into a proxy object.
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getCompletions):
        (InjectedScript.evaluate):
        (InjectedScript._evaluateOn):
        (InjectedScript.createProxyObject):
        * inspector/front-end/InjectedScriptAccess.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        Wrap PageTransitionEvents properly for V8's use.

        https://bugs.webkit.org/show_bug.cgi?id=29340

        Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dave Hyatt.

        Hardware-accelerated opacity transition on inline asserts
        https://bugs.webkit.org/show_bug.cgi?id=29342

        Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
        pass an empty size, because the box size is only required for transform animations.

        Test: compositing/transitions/opacity-on-inline.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::startTransition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Update contributing.html to mention recently added tools.
        https://bugs.webkit.org/show_bug.cgi?id=29318

        Update our contributing instructions to mention
        the new tools (check-webkit-style and commit-queue)
        recently added to make contributions easier.

        * coding/contributing.html:
         - Mention check-webkit-style as an optional helper tool.
         - Mention checking the 'patch' checkbox.
         - Mention the commit-queue as an optional helper tool.
         - Remove "or in email" since patch reviews are all done via bugzilla.
         - Encourage contributers to be responsible for getting their patch landed.  Provide a list of committers.
         - Mention commit-queue as an optional help in getting your patch landed.
         - Give an overview of the commit-queue process and link to the Commit Queue docs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Brady Eidson.

        Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
        https://bugs.webkit.org/show_bug.cgi?id=29329

        Skip test that fails on Tiger because of a bug in its version of
        CFNetwork.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        [V8] OwnHandle might get a weak callback after destruction
        https://bugs.webkit.org/show_bug.cgi?id=29172

        Be sure to clear out weak reference so we don't get a weak callback
        after we've destructed ourselves.  Also, removed some tricky methods
        that had no clients.

        * bindings/v8/OwnHandle.h:
        (WebCore::OwnHandle::clear):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        REGRESSION: media/video-size-intrinsic-scale.html (and other media tests?) crashing/timing-out intermittently
        https://bugs.webkit.org/show_bug.cgi?id=28845

        Skip media/video-size-intrinsic-scale.html in hopes of stopping the crashers.
        I ran the media tests with --iterations 30 w/o seeing a crash.
        I also re-enabled media/video-source-add-src.html now that we know it is not at fault.

        * media/video-source-add-src.html: Renamed from LayoutTests/media/video-source-add-src.html-disabled.
        * platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Add layout tests to verify there is no security leaks if someone sets a prototype of top
        window to its child window.
        https://bugs.webkit.org/show_bug.cgi?id=29334

        * http/tests/security/resources/iframe-with-element.html: Added.
        * http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt: Added.
        * http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html: Added.
        * http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt: Added.
        * http/tests/security/xss-DENIED-method-with-iframe-proto.html: Added.
        * http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt: Added.
        * http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto.html: Added.
        * http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt: Added.
        * http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, build fix.

        [V8] Partial roll out of http://trac.webkit.org/changeset/48455 to
        fix crashes that started happening in V8Proxy::getEnteredContext().

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=29335

Reviewed by Beth Dakin.

WebCore: 

When an accessibility hit test is done and it hits the label of a control element,
the control element should be returned instead of nothing, since the label
itself is usually ignored.

Test: accessibility/label-for-control-hittest.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::correspondingControlForLabelElement):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
* accessibility/AccessibilityRenderObject.h:

LayoutTests: 

* accessibility/label-for-control-hittest-expected.txt: Added.
* accessibility/label-for-control-hittest.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48482 268f45cc-cd09-0410-ab3c-d52691b4dbfc