1. 03 Oct, 2012 16 commits
    • jochen@chromium.org's avatar
      Make sure that user gestures can't be consumed twice · ca1aea26
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97483
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Instead of a simple counter, use a ref counted token to track how many
      user gestures happened and where consumed. When creating a timer that
      is supposed to forward the user gesture, take a reference to this token
      and reinstantiate the UserGestureIndicator with that token when the
      timer is triggered.
      
      Tests: platform/chromium/fast/events/popup-forwarded-gesture-blocked.html
             platform/chromium/fast/events/popup-forwarded-gesture.html
      
      * dom/UserGestureIndicator.cpp:
      (WebCore):
      (WebCore::UserGestureIndicator::UserGestureIndicator):
      (WebCore::UserGestureIndicator::~UserGestureIndicator):
      (WebCore::UserGestureIndicator::processingUserGesture):
      (WebCore::UserGestureIndicator::consumeUserGesture):
      (WebCore::UserGestureIndicator::currentToken):
      * dom/UserGestureIndicator.h:
      (Token):
      (WebCore::UserGestureIndicator::Token::~Token):
      (UserGestureIndicator):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::DOMTimer):
      (WebCore::DOMTimer::fired):
      * page/DOMTimer.h:
      (DOMTimer):
      
      LayoutTests:
      
      * platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt: Added.
      * platform/chromium/fast/events/popup-forwarded-gesture-blocked.html: Added.
      * platform/chromium/fast/events/popup-forwarded-gesture-expected.txt: Added.
      * platform/chromium/fast/events/popup-forwarded-gesture.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca1aea26
    • dmazzoni@google.com's avatar
      AX: Heap-use-after-free when deleting a ContainerNode with an AX object · a09b3cd4
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98073
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      Calls axObjectCache()->remove(this) in ~ContainerNode so that the AX tree
      doesn't try to access the container node while walking up the parent chain
      from one of the container node's children.
      
      Test: accessibility/container-node-delete-causes-crash.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::~ContainerNode):
      * dom/Node.cpp:
      (WebCore::Node::~Node):
      * dom/Node.h:
      (WebCore::Node::document):
      (WebCore::Node::documentInternal):
      
      LayoutTests:
      
      Adds test for heap-use-after-free when container node with AX object is deleted.
      
      * accessibility/container-node-delete-causes-crash-expected.txt: Added.
      * accessibility/container-node-delete-causes-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a09b3cd4
    • commit-queue@webkit.org's avatar
      [Qt][WRT] Fix build error with MSVC on Windows. · 1c0d37d7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97697
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-03
      Reviewed by Simon Hausmann.
      
      WTR build is failing when WebKit directory is located on a longer path.
      This seems to caused by source files that has the same name in
      WTR and DRT directories. The solution is removing referencies
      from Target.pri to DRT directory and adding an alternate version of
      the required files to WTR. Those files simply include the real ones from DRT.
      
      * WebKitTestRunner/InjectedBundle/Target.pri:
      * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
      * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c0d37d7
    • vsevik@chromium.org's avatar
      Web Inspector: SourceURL should be taken from debugger agent when possible. · 4b25f827
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98239
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Removed a check that sourceURL coming from js engine is the same as the one parsed by debugger agent.
      Alwys use the one from debugger agent now.
      
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::didParseSource):
      
      LayoutTests:
      
      Unskipped test.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b25f827
    • loislo@chromium.org's avatar
      Unreviewed. Touch FrameView.cpp file for fixing mac bot compilation. · 3e7e2e81
      loislo@chromium.org authored
      * page/FrameView.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7e2e81
    • commit-queue@webkit.org's avatar
      [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness · f6f27f39
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98238
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-03
      Reviewed by Csaba Osztrogonác.
      
      Reset AlwaysAcceptCookies setting between tests to avoid
      flakiness due to TestRunner.setAlwaysAcceptCookies().
      
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6f27f39
    • loislo@chromium.org's avatar
      Web Inspector: "Load profile..." context menu item has to be shown only for... · cc5ebeb9
      loislo@chromium.org authored
      Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles.
      https://bugs.webkit.org/show_bug.cgi?id=98163
      
      Reviewed by Yury Semikhatsky.
      
      The text was changed to "Load Heap Snapshot..."
      Also I changed "Save profile..." to "Save Heap Snapshot..." because other profiles don't support Save/Load operations yet.
      The Load context menu item will appear only when the user clicked in sidebar the tree empty space or a profile.
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
      (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc5ebeb9
    • commit-queue@webkit.org's avatar
      Add data passing to the GetStats interface of RTCPeerConnection · 301e929c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98003
      
      Patch by Harald Alvestrand <hta@google.com> on 2012-10-03
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/WebRTCStatsRequest.h:
      (WebKit):
      (WebRTCStatsRequest):
      * chromium/public/WebRTCStatsResponse.h: Added.
      (WebCore):
      (WebKit):
      (WebRTCStatsResponse):
      (WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
      (WebKit::WebRTCStatsResponse::~WebRTCStatsResponse):
      (WebKit::WebRTCStatsResponse::operator=):
      
      Source/WebCore:
      
      Added an RTCStatsResponseBase interface to platform, and let the
      RTCStatsRequestImpl class produce an implementation of it that's returned
      to WebCore.
      
      Tested by extension of the RTCPeerConnection-stats.html test.
      
      * Modules/mediastream/RTCStatsElement.cpp:
      (WebCore::RTCStatsElement::addStatistic):
      (WebCore):
      * Modules/mediastream/RTCStatsElement.h:
      (RTCStatsElement):
      * Modules/mediastream/RTCStatsReport.cpp:
      (WebCore):
      (WebCore::RTCStatsReport::addElement):
      (WebCore::RTCStatsReport::addStatistic):
      * Modules/mediastream/RTCStatsReport.h:
      (RTCStatsReport):
      * Modules/mediastream/RTCStatsRequestImpl.cpp:
      (WebCore::RTCStatsRequestImpl::createResponse):
      (WebCore):
      (WebCore::RTCStatsRequestImpl::requestSucceeded):
      * Modules/mediastream/RTCStatsRequestImpl.h:
      (RTCStatsRequestImpl):
      * Modules/mediastream/RTCStatsResponse.cpp:
      (WebCore::RTCStatsResponse::create):
      (WebCore::RTCStatsResponse::addReport):
      (WebCore):
      (WebCore::RTCStatsResponse::addElement):
      (WebCore::RTCStatsResponse::addStatistic):
      * Modules/mediastream/RTCStatsResponse.h:
      (RTCStatsResponse):
      * WebCore.gypi:
      * platform/chromium/support/WebRTCStatsRequest.cpp:
      (WebKit::WebRTCStatsRequest::response):
      (WebKit):
      (WebKit::WebRTCStatsRequest::requestSucceeded):
      * platform/chromium/support/WebRTCStatsResponse.cpp: Added.
      (WebKit):
      (WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
      (WebKit::WebRTCStatsResponse::assign):
      (WebKit::WebRTCStatsResponse::reset):
      (WebKit::WebRTCStatsResponse::operator WTF::PassRefPtr<WebCore::RTCStatsResponseBase>):
      (WebKit::WebRTCStatsResponse::addReport):
      (WebKit::WebRTCStatsResponse::addElement):
      (WebKit::WebRTCStatsResponse::addStatistic):
      * platform/mediastream/RTCStatsRequest.h:
      (WebCore):
      (RTCStatsRequest):
      * platform/mediastream/RTCStatsResponseBase.h: Added.
      (WebCore):
      (RTCStatsResponseBase):
      (WebCore::RTCStatsResponseBase::~RTCStatsResponseBase):
      
      Tools:
      
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
      (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
      (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
      (MockWebRTCPeerConnectionHandler::addStream):
      (MockWebRTCPeerConnectionHandler::removeStream):
      (MockWebRTCPeerConnectionHandler::getStats):
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
      (MockWebRTCPeerConnectionHandler):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-stats-expected.txt:
      * fast/mediastream/RTCPeerConnection-stats.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      301e929c
    • carlosgc@webkit.org's avatar
      [GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+ · 8cff89f2
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97895
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      * platform/network/NetworkingContext.h:
      (NetworkingContext): Add initiatingPageID().
      * platform/network/ResourceHandle.h:
      (ResourceHandle): Add static method
      getSoupRequestInitiaingPageID().
      * platform/network/ResourceHandleInternal.h:
      (ResourceHandleInternal): Add initiatingPageID().
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::ResourceHandleInternal::initiatingPageID): Get the
      initiating page ID of the resource handle networking context.
      (WebCore::setSoupRequestInitiaingPageID): Helper function to
      attach a page ID to a SoupRequest.
      (WebCore::startHTTPRequest): Call setSoupRequestInitiaingPageID()
      to attch the initiating page ID to the SoupRequest.
      (WebCore::startNonHTTPRequest): Ditto.
      (WebCore::ResourceHandle::getSoupRequestInitiaingPageID): Static
      method to get the page ID attached to a SoupRequest.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameNetworkingContextEfl.cpp:
      (WebCore::FrameNetworkingContextEfl::initiatingPageID): Stub
      implementation.
      * WebCoreSupport/FrameNetworkingContextEfl.h:
      (FrameNetworkingContextEfl): Added.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameNetworkingContextGtk.cpp:
      (WebKit::FrameNetworkingContextGtk::initiatingPageID): Stub
      implementation.
      * WebCoreSupport/FrameNetworkingContextGtk.h:
      (FrameNetworkingContextGtk): Added.
      
      Source/WebKit2:
      
      The message DidReceiveURIRequest is now sent to the page that
      initiated the request that forwards the mesassage to the
      WebSoupRequestManagerProxy.
      
      * UIProcess/API/C/soup/WKSoupRequestManager.h: Update
      didReceiveURIRequest callback to receive the initiating page ID.
      * UIProcess/API/efl/ewk_context_request_manager_client.cpp:
      (didReceiveURIRequest): Update the callback API change.
      * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
      (didReceiveURIRequest): Pass the initiating page to the
      WebKitURISchemeRequest constructor.
      * UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
      (_WebKitURISchemeRequestPrivate): Keep a reference to the
      WebPageProxy that initiatesd the request.
      (webkitURISchemeRequestCreate): Save the initiating page.
      (webkit_uri_scheme_request_get_web_view): Return the view widget
      of the initiating WebPageProxy.
      * UIProcess/API/gtk/WebKitURISchemeRequest.h:
      * UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
      * UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveURIRequest): Forward the request
      to the soup request manager proxy.
      * UIProcess/WebPageProxy.h:
      (WebPageProxy): Add didReceiveURIRequest().
      * UIProcess/WebPageProxy.messages.in: Add DidReceiveURIRequest
      message.
      * UIProcess/soup/WebSoupRequestManagerClient.cpp:
      (WebKit::WebSoupRequestManagerClient::didReceiveURIRequest):
      Pass the inititing page to the client callback.
      * UIProcess/soup/WebSoupRequestManagerClient.h:
      (WebSoupRequestManagerClient):
      * UIProcess/soup/WebSoupRequestManagerProxy.cpp:
      (WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Pass
      the inititing page to the client.
      * UIProcess/soup/WebSoupRequestManagerProxy.h:
      (WebSoupRequestManagerProxy):
      * UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Remove
      DidReceiveURIRequest message.
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
      (WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
      Save the pageID of the WebFrame.
      (WebKit::WebFrameNetworkingContext::initiatingPageID): Return the
      inititing page ID.
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
      * WebProcess/soup/WebSoupRequestManager.cpp:
      (WebKit::WebSoupRequestManager::send): Send DidReceiveURIRequest
      message to the WebPage that initiated the request.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cff89f2
    • zandobersek@gmail.com's avatar
      Unreviewed build fix for the GTK port after r130207. · ccdce3c2
      zandobersek@gmail.com authored
      Use proper file separators for new entries.
      
      * GNUmakefile.list.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccdce3c2
    • tkent@chromium.org's avatar
      Introduce DateComponents::minimumYear and maximumYear · 3d443374
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98230
      
      Reviewed by Kentaro Hara.
      
      Share same difinitions in DateComponents.cpp and DateTimeFieldElements.cpp.
      
      No new tests. This doesn't change any bahevior.
      
      * platform/DateComponents.h:
      (WebCore::DateComponents::minimumYear): Moved from DateComponents.cpp.
      (WebCore::DateComponents::maximumYear): ditto.
      * platform/DateComponents.cpp:
      (WebCore): Move out static minimumYear and maximumYear.
      (WebCore::DateComponents::parseYear): Use DateCompnents::minimumYear and/or maximumYear.
      (WebCore::withinHTMLDateLimits): ditto.
      (WebCore::DateComponents::parseWeek): ditto.
      (WebCore::DateComponents::setMonthsSinceEpoch): ditto.
      (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): ditto.
      
      * html/shadow/DateTimeFieldElements.cpp:
      (WebCore): Remove minimumYear and maximumYear.
      (WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
      Use DateComponents::minimumYear and maximumYear.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d443374
    • arko@motorola.com's avatar
      Microdata: itemprop names must not override builtin properties. · 222c11fa
      arko@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98025
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore: 
      
      We should look in the prototype for functions before assuming it as
      an item's name. Return false if the prototype of the object has a
      property (function) with propertyName.
      Named properties Spec: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties
      Named property visibility algorithm:
      http://dev.w3.org/2006/webapi/WebIDL/#indexed-and-named-properties
      ...
      7. If the result of calling the [[HasProperty]] internal method on
      prototype with property name P is true, then return false.
      ...
      Also [OverrideBuiltins] is not declared for any of the properties,
      hence no overriding is allowed in this case.
      
      Test: fast/dom/MicroData/itemprop-names-override-builtin-properties.html
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      
      LayoutTests: 
      
      Added test case to verify that itemprop names must not override builtin properties.
      
      * fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Added.
      * fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      222c11fa
    • keishi@webkit.org's avatar
      REGRESSION (r129738): Suggestion picker label is placed in the wrong location · 6ba86f9e
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98094
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      We needed to reverse padding-left/right when rtl.
      
      No new tests. Covered by date-suggestion-picker-appearance.html.
      
      * Resources/pagepopups/suggestionPicker.css:
      (.suggestion-list-entry .label):
      (.rtl .suggestion-list-entry .label):
      
      LayoutTests:
      
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ba86f9e
    • yurys@chromium.org's avatar
      Provide memory instrumentation for HashCountedSet · 4d3e1731
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98138
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Replaced addHashCountedSet calls with addMember that now automatically
      detects HashCountedSet and calls appropriate routine.
      
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
      * loader/cache/CachedResource.cpp:
      
      Source/WebKit/chromium:
      
      Added unit test for HashCountedSet memory instrumentation.
      
      * tests/MemoryInstrumentationTest.cpp:
      
      Source/WTF:
      
      Added memory instrumentation for HashCountedSet.
      
      Extracted common routines for collecting memory info for an iterable sequence.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationHashCountedSet.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashSet.h.
      (WTF):
      (WTF::reportMemoryUsage):
      * wtf/MemoryInstrumentationHashMap.h:
      (WTF::reportMemoryUsage):
      * wtf/MemoryInstrumentationHashSet.h:
      * wtf/MemoryInstrumentationSequence.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashMap.h.
      (WTF):
      (WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):
      (WTF::reportSequenceMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d3e1731
    • ossy@webkit.org's avatar
      Buildfix after r130235. · 45ce807d
      ossy@webkit.org authored
      Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-02
      Reviewed by Csaba Osztrogonác.
      
      systemAllowsMultisamplingOnATICards was deleted from GraphicsContext3D,
      but function body remained in GraphicsContext3DOpenGLES. Delete method body.
      
      * platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45ce807d
    • joone.hur@intel.com's avatar
      Unreviewed, GTK+,Efl debug build fix after r130225. · 3f063983
      joone.hur@intel.com authored
      This patch allows to include the static xErrorString variable when LOG_DISABLED is 0.
      
      * PluginProcess/unix/PluginProcessMainUnix.cpp:
      (WebKit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f063983
  2. 02 Oct, 2012 24 commits
    • tkent@chromium.org's avatar
      Fix assertion failures on Chromium Debug bots for datetime/datetime-local input types. · e9ae0aff
      tkent@chromium.org authored
      * html/shadow/DateTimeFieldElements.cpp:
      If a placeholder stirng is empty, use a sequence of "-".
      (WebCore::DateTimeDayFieldElement::create):
      (WebCore::DateTimeMonthFieldElement::create):
      (WebCore::DateTimeYearFieldElement::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9ae0aff
    • morrita@google.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=98134 · da910aae
      morrita@google.com authored
      [Refactoring] StyleResolver::matchScopedAuthorRules() could be simpler.
      
      Reviewed by Dimitri Glazkov.
      
      matchScopedAuthorRules() did have some optimization which only
      makes sense for heavily nested shadow tree. However, we don't see
      such type of usage of Shadow DOM and this looks premature
      optimization. This change unified its triple for loop into one,
      which makes the code much simpler.
      
      No new tests. Covered by existing tests.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::matchScopedAuthorRules):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da910aae
    • weinig@apple.com's avatar
      Fix a typo and add some \n's to make Mark happy. · 7ccd38fd
      weinig@apple.com authored
      Rubber-stamped by Mark "logging must be fast" Rowe.
      
      * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
      (WebKit::InjectedBundle::load):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ccd38fd
    • tkent@chromium.org's avatar
      Introduce Localizer::dateTimeFormatWithSecond and dateTimeFormatWithoutSecond · 86d00978
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98229
      
      Reviewed by Kentaro Hara.
      
      Unify identical code in DateTimeInputType and DateTimeLocalInputType as
      Localizer member functions.
      They still have some common code. We'll address it later.
      
      No new tests. This doesn't change any behavior.
      
      * platform/text/Localizer.h:
      (Localizer): Add dateTimeFormatWithSecond and dateTimeFormatWithoutSecond.
      * platform/text/Localizer.cpp:
      (WebCore::Localizer::dateTimeFormatWithSecond):
      Implemented. Just concatenating dateFormat, a space, and timeFormat.
      (WebCore::Localizer::dateTimeFormatWithoutSecond):
      Implemented. Just concatenating dateFormat, a space, and shortTimeFormat.
      
      * html/DateTimeInputType.cpp:
      (WebCore::DateTimeInputType::setupLayoutParameters):
      Use dateTimeFormatWithSecond and dateTimeFormatWithoutSecond.
      * html/DateTimeLocalInputType.cpp:
      (WebCore::DateTimeLocalInputType::setupLayoutParameters): ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86d00978
    • tkent@chromium.org's avatar
      Refactoring: DateTimeEditBuilder had better hold LayoutParameters · ba29d01e
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98228
      
      Reviewed by Kentaro Hara.
      
      Stop copying multiple members of LayoutParameters in DateTimeEditBuilder
      constructor. This change improves code size and runtime cost.
      
      No new tests. This doesn't change user-visible behavior.
      
      * html/shadow/DateTimeEditElement.cpp:
      (DateTimeEditBuilder): Add a comment about lifetime of objects.
      (WebCore::DateTimeEditBuilder::stepRange):
      Added. A helper to access m_parameters.stepRange.
      (WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
      Remove m_stepRange, m_localizer, m_placeholderFor* members.
      Add m_parameters.
      (WebCore::DateTimeEditBuilder::needMillisecondField):
      Use stepRange() instead of m_stepRange.
      (WebCore::DateTimeEditBuilder::visitField):
      Use m_parameters.placeholderFor*.
      (WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
      Use stepRange() instead of m_stepRange.
      (WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly): ditto.
      (WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba29d01e
    • weinig@apple.com's avatar
      Add Objective-C API for the InjectedBundle · 5e919c0b
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98222
      
      Reviewed by Anders Carlsson.
      
      Add skeleton of the Objective-C API for the InjectedBundle.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new API files.
      
      * WebProcess/InjectedBundle/API/mac: Added.
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Added.
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Added.
      (-[WKWebProcessPlugIn _initWithPrincipalClassInstance:injectedBundle:]):
      Initialization method for the WKWebProcessPlugIn object. This object will act as the WKBundleRef
      object does in the C-SPI.
      (+[WKWebProcessPlugIn _shared]):
      Access the shared instance.
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Added.
      
      * WebProcess/InjectedBundle/InjectedBundle.h:
      Store an NSBundle rather than a CFBundleRef as the platform bundle.
      
      * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Removed.
      * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm: Copied from Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp.
      (WebKit::InjectedBundle::load):
      If a principal class is provided and no WKBundleInitialize function is present in the bundle, use the principal class
      as the initialization point. The principal class must conform to the WKWebProcessPlugIn protocol and if a
      webProcessPlugInInitialize: method is present, it is called. 
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e919c0b
    • tkent@chromium.org's avatar
      Implement LocaleICU::dateFormat · 3073bb52
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98118
      
      Reviewed by Hajime Morita.
      
      http://trac.webkit.org/changeset/130127 introduced
      Localizer::dateFormat, and this is its implementation for LocaleICU
      classs. The code is going to be used when
      ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.
      
      No new tests. The function is not used yet.
      
      * platform/text/LocaleICU.cpp:
      (WebCore::LocaleICU::dateFormat):
      Implemented. Note that m_shortDateFormat is a UDateFormat object, which
      knows various format information.
      * platform/text/LocaleICU.h:
      (LocaleICU): Add m_dateFormat to cache the format string.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3073bb52
    • tkent@chromium.org's avatar
      [Mac][Chromium-Mac] Implement LocaleMac::dateFormat · 6ab68e4a
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98116
      
      Reviewed by Hajime Morita.
      
      http://trac.webkit.org/changeset/130127 introduced
      Localizer::dateFormat, and this is its implementation for LocaleICU
      classs. The code is going to be used when
      ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.
      
      No new tests. The function is not used yet.
      
      * platform/text/mac/LocaleMac.h:
      (LocaleMac): Declare m_dateFormat.
      * platform/text/mac/LocaleMac.mm:
      (WebCore::LocaleMac::dateFormat): Implemented.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab68e4a
    • tkent@chromium.org's avatar
      [Chromium-Win] Implement LocaleWin::dateFormat · c934c4b0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98117
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      http://trac.webkit.org/changeset/130127 introduced
      Localizer::dateFormat, and this is its implementation for LocaleICU
      classs. The code is going to be used when
      ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.
      
      Tests: Added a new test to WebKit/chromium/tests/LocaleWinTest.cpp.
      
      * platform/text/LocaleWin.cpp:
      (WebCore::parseDateFormat):
      Fix a continuous apostrophes parsing bug; "abc''''def" produced "abc'''def"
      (WebCore::appendAsLDMLLiteral):
      A helper function to make a literal string for LDML.
      (WebCore::convertWindowsDateFormatToLDML):
      Creates an LDML format from a parsed date format tokens.
      (WebCore::LocaleWin::dateFormat):
      Implemented. This uses convertWindowsDateFormatToLDML.
      (WebCore::LocaleWin::dateFormat):
      Added for testing. The source windows format is specified as a function
      argument.
      * platform/text/LocaleWin.h:
      (LocaleWin): Declare m_dateFormat and dateFormat().
      
      Source/WebKit/chromium:
      
      * tests/LocaleWinTest.cpp:
      (TEST_F): Add tests for LocaleWin::dateFormat.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c934c4b0
    • ojan@chromium.org's avatar
      [chromium] Fix spelling of isNVIDIA override in Extensions3DChromium · eed26124
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98219
      
      Patch by Ian Vollick <vollick@chromium.org> on 2012-10-02
      Reviewed by Dean Jackson.
      
      The override in Extensions3dChromium should have been spelled isNVIDIA, not isNVidia.
      
      No new tests. No change in functionality.
      
      * platform/graphics/chromium/Extensions3DChromium.h:
      (WebCore::Extensions3DChromium::isNVIDIA):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eed26124
    • mitz@apple.com's avatar
      Fixed a crash when the localization option is not passed to the web process. · c6131bbd
      mitz@apple.com authored
      Reviewed by Sam Weinig.
      
      * PluginProcess/mac/PluginProcessMainMac.mm:
      (WebKit::PluginProcessMain): Changed to not call WKSetDefaultLocalization
      with the empty string.
      * WebProcess/mac/WebProcessMainMac.mm:
      (WebKit::WebProcessMain): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6131bbd
    • andersca@apple.com's avatar
      Try to fix the Snow Leopard build. · f2acd7b2
      andersca@apple.com authored
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2acd7b2
    • jsbell@chromium.org's avatar
      Add htons/htonl definitions and implementations · b4ac43ba
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98054
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Update users of htons and friends to use new wtf/ByteOrder.h header.
      
      No new tests - just refactoring.
      
      * platform/graphics/WOFFFileFormat.cpp:
      * platform/graphics/chromium/VDMXParser.cpp:
      
      Source/WTF:
      
      For parsing or serializing binary data, byte order matters. The canonical htons/htonl/
      ntohs/ntohl functions are not present everywhere, so implementations are proliferating in
      parsers. Expose a new WTF header (wtf/ByteOrder.h) that includes the standard
      implementations on UNIX-like OSs and provides basic inlined implementations on Windows.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/ByteOrder.h: Added.
      (WTF::wswap32): Inline functions so arguments are only evaluated once.
      (WTF::bswap32):
      (WTF::bswap16):
      (ntohs): Inline functions on OS(WINDOWS) to match macros on OS(UNIX)
      (htons):
      (ntohl):
      (htonl):
      * wtf/CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4ac43ba
    • simon.fraser@apple.com's avatar
      Source/JavaScriptCore: == Rolled over to ChangeLog-2012-10-02 == · eec26cbc
      simon.fraser@apple.com authored
      Source/WebCore: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit/chromium: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit/mac: == Rolled over to ChangeLog-2012-10-02 ==
      
      Source/WebKit2: == Rolled over to ChangeLog-2012-10-02 ==
      
      Tools: == Rolled over to ChangeLog-2012-10-02 ==
      
      LayoutTests: == Rolled over to ChangeLog-2012-10-02 ==
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eec26cbc
    • simon.fraser@apple.com's avatar
      Make TiledBacking slightly less aware of scrolling · cb3ce90c
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98216
      
      Reviewed by Anders Carlsson.
      
      TiledBacking shouldn't really care about there being scrollbars;
      recast this in terms of "tile coverage", described by a bitfield
      that has flags for coverage optimized for horizontal and vertical
      scrolling. This allows for additional tile coverage behaviors later.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      * platform/graphics/TiledBacking.h:
      * platform/graphics/ca/mac/TileCache.h:
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::TileCache): Initialize m_isInWindow to false to
      be more conservative. It gets explicitly set by the only caller now, so this is
      not a behavior change.
      (WebCore::TileCache::setIsInWindow):
      (WebCore::TileCache::setTileCoverage):
      (WebCore::TileCache::tileCoverageRect):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3ce90c
    • dino@apple.com's avatar
      Expose some GPU Information · 742a55a2
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97813
      
      Reviewed by Sam Weinig and Ken Russell and Tim Horton.
      
      Currently there are a few places in the WebGL code (and elsewhere, like CSS filters)
      where we do some feature detection by examining the GPU vendor and its capabilities.
      This patch puts this detection into our shared Extensions3D object.
      
      * platform/graphics/Extensions3D.h: Adds the new methods for detecting vendor and features.
      * platform/graphics/GraphicsContext3D.h:
      (GraphicsContext3D): No longer needs function to detect multisampling on ATI.
      * platform/graphics/chromium/Extensions3DChromium.h: Stub implementations of all
      the new methods. Chromium does its detection elsewhere.
      (WebCore::Extensions3DChromium::isNVIDIA):
      (WebCore::Extensions3DChromium::isAMD):
      (WebCore::Extensions3DChromium::isIntel):
      (WebCore::Extensions3DChromium::vendor):
      (Extensions3DChromium):
      (WebCore::Extensions3DChromium::maySupportMultisampling):
      (WebCore::Extensions3DChromium::requiresBuiltInFunctionEmulation):
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::createMultisampleBuffer): Add test for system multisampling to
      custom filter code.
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore::DrawingBuffer::create): Add test for system multisampling to drawing buffer's
      creation code.
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      (WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon): Detects all the features
      as the object is created.
      (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Can now simply ask
      itself if it needs to turn on built-in function translation.
      * platform/graphics/opengl/Extensions3DOpenGLCommon.h:
      (Extensions3DOpenGLCommon):
      (WebCore::Extensions3DOpenGLCommon::isNVIDIA):
      (WebCore::Extensions3DOpenGLCommon::isAMD):
      (WebCore::Extensions3DOpenGLCommon::isIntel):
      (WebCore::Extensions3DOpenGLCommon::vendor):
      (WebCore::Extensions3DOpenGLCommon::maySupportMultisampling):
      (WebCore::Extensions3DOpenGLCommon::requiresBuiltInFunctionEmulation):
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
      (WebCore::GraphicsContext3D::validateAttributes): Ask the extension object instead of
      testing directly.
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::validateDepthStencil): Ask the extension object instead
      of testing directly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      742a55a2
    • dbates@webkit.org's avatar
      Define watch list "webkitperl", "SVNScripts", and "XSS" to watch for changes · f7d43418
      dbates@webkit.org authored
      to Tools/Scripts/{VCSUtils.pm, webkitdirs.pm, webkitperl}, Tools/Scripts/svn-*
      scripts, and files whose name contains the word "XSS", respectively. Subscribe
      myself to these lists.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d43418
    • ojan@chromium.org's avatar
      Test rebaselines now that the Chromium Lion bot has been upgraded to 10.7.5. · ee622c55
      ojan@chromium.org authored
      All the differences are anti-aliasing in gradients.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee622c55
    • ap@apple.com's avatar
      <rdar://problem/12407920> Need to keep track of messages posted to... · 513e9456
      ap@apple.com authored
              <rdar://problem/12407920> Need to keep track of messages posted to injected bundle before creating a page
              https://bugs.webkit.org/show_bug.cgi?id=98210
      
              Reviewed by Anders Carlsson.
      
              Restore the pending message functionality, but only for shared process mode, and
              under a different name.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::setProcessModel):
              (WebKit::WebContext::createNewWebProcess):
              (WebKit::WebContext::postMessageToInjectedBundle):
              * UIProcess/WebContext.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      513e9456
    • bashi@chromium.org's avatar
      [Chromium] Introduce caches for HarfBuzzShaper · d22f961f
      bashi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97993
      
      Reviewed by Tony Chang.
      
      - Implement canRenderCombiningCharacterSequence() for ports which use
      HarfBuzzShaper. This function caches the result and will improve the
      performance of HarfBuzzShaper::collectHarfBuzzRuns.
      - Add a HashMap to HarfBuzzNGFace. It is used as a cache that holds
      glyph indexes of codepoints. It reduces the number of
      SkPaint::textToGlyphs() calls.
      
      This patch makes the intl2 page cycler 4.4% faster on my machine.
      
      No new tests. No changes in behavior.
      
      * platform/graphics/SimpleFontData.h:
      (SimpleFontData): Enabled canRenderCombiningCharacterSequence() if USE(HARFBUZZ_NG) is enabled.
      * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
      (WebCore):
      (WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added.
      * platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:
      (WebCore):
      (FaceCacheEntry): Added.
      (WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
      Lookup the cache entry in harfBuzzFaceCache. Create the entry if there is no entry in the cache.
      Increment the ref count of the entry and set cache entry values to member variables.
      (WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):
      Decrement the ref count of the cache entry. Remove the entry if no one refers the cache.
      * platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
      (HarfBuzzNGFace):
      * platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:
      (HarfBuzzFontData): Added. Used as |userData| of harfbuzz callback functions.
      (WebCore):
      (WebCore::SkiaGetGlyphWidthAndExtents):
      (WebCore::harfbuzzGetGlyph):
      Look up the glyphChache first. If the cache entry doesn't exist, call
      SkPaint::textToGlyphs() to get glyph index and store it to the cache.
      (WebCore::harfbuzzGetGlyphHorizontalAdvance):
      (WebCore::harfbuzzGetGlyphExtents):
      (WebCore::destroyHarfBuzzFontData): Added.
      (WebCore::HarfBuzzNGFace::createFont):
      Create HarfBuzzFontData and pass it to harfbuzz.
      * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
      (WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult):
      Don't initialize m_glyphToCharacterIndexes here.
      (WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
      Use SimpleFontData::canRenderCombiningCharacterSequence() instead of
      fontDataForCombiningCharacterSequence().
      (WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
      Set glyphToCharacterIndexes of the current HarfBuzzRun.
      * platform/graphics/skia/SimpleFontDataSkia.cpp:
      (WebCore):
      (WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22f961f
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=98182 · 3f0e8435
      bdakin@apple.com authored
      REGRESSION (r130091): Scroll wheel no longer scrolls within div
      
      Reviewed by Simon Fraser.
      
      Forgot to initialize m_nonFastScrollableRegion in this copy 
      constructor.
      * page/scrolling/ScrollingStateScrollingNode.cpp:
      (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f0e8435
    • fpizlo@apple.com's avatar
      REGRESSION(r128400): ASSERT (crash in release) @ app.asana.com · dc4b6b65
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98175
      
      Reviewed by Oliver Hunt.
      
      It's bad karma to create a new structure while stealing another structure's property table
      while leaving the m_offset unset. Eventually someone will then steal your property table, and
      then you won't know how many properties you have anymore.
      
      * runtime/Structure.cpp:
      (JSC::Structure::nonPropertyTransition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc4b6b65
    • roger_fong@apple.com's avatar
      Skipping flaky test... · b63e547e
      roger_fong@apple.com authored
      Skipping flaky test fast/text/international/float-as-only-child-of-isolate-crash.html is flaky on Windows.
      https://bugs.webkit.org/show_bug.cgi?id=98209
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b63e547e
    • japhet@chromium.org's avatar
      Source/WebCore: iframes with scrolling=no can't scroll to anchors · e22c48d7
      japhet@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96539
      
      Reviewed by Antonio Gomes.
      
      This appears to have regressed in r106730. This patch matches Firefox's behavior.
      
      Test: fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html
      
      * page/EventHandler.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollRectToVisible): Currently scrolls are always forbidden
         if scrollbars are explicitly disabled. This adds an exception for scrolls that
         are not user-initiated and are not autoscrolls.
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=96539.
      
      Reviewed by Antonio Gomes.
      
      * fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html: Added.
      * fast/dom/HTMLAnchorElement/resources: Added.
      * fast/dom/HTMLAnchorElement/resources/iframe-with-anchor.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e22c48d7