1. 14 Sep, 2012 40 commits
    • fpizlo@apple.com's avatar
      bbc homepage crashes immediately · c9f16125
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96812
      <rdar://problem/12081386>
      
      Reviewed by Oliver Hunt.
      
      If you use the old storage pointer to write to space you thought was newly allocated,
      you're going to have a bad time.
      
      * runtime/JSArray.cpp:
      (JSC::JSArray::unshiftCount):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9f16125
    • michelangelo@webkit.org's avatar
      [CSS Shaders] u_textureSize uniform should be set to the size of the texture. · 65db9806
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95914
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      This adds support for the following shader uniform variables:
      
          uniform vec2 u_textureSize
          uniform vec4 u_meshBox
          uniform vec2 u_tileSize
          uniform vec2 u_meshSize
      
      The relevant section of the specification is:
      http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
      
      Tests: css3/filters/custom/custom-filter-u-mesh-box.html
             css3/filters/custom/custom-filter-u-mesh-size.html
             css3/filters/custom/custom-filter-u-texture-size.html
             css3/filters/custom/custom-filter-u-tile-size.html
      
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::bindProgramAndBuffers):
      
      LayoutTests:
      
      Tests for the following uniform variables:
          uniform vec2 u_textureSize
          uniform vec4 u_meshBox
          uniform vec2 u_tileSize
          uniform vec2 u_meshSize
      
      The relevant section of the specification is:
      http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
      
      * css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-box.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-size.html: Added.
      * css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-texture-size.html: Added.
      * css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-tile-size.html: Added.
      * css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
      * css3/filters/resources/u-mesh-size.fs: Added.
      * css3/filters/resources/u-texture-size.fs: Added.
      * css3/filters/resources/u-tile-size.fs: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65db9806
    • ap@apple.com's avatar
      Unreviewed. · 59de8d92
      ap@apple.com authored
              
              A small improvement to this flaky test: use a correct URL, so that the test fails
              quickly and understandably instead of timing out. This code path didn't use to be
              taken before, so the URL was always wrong.
      
              * fast/loader/resources/submit-form-while-parsing-subframe.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59de8d92
    • slewis@apple.com's avatar
      new fast/loader tests from r128645 fail on Mac-wk2. · 4d73308c
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96832.
      
      Unreviewed.
      
      Update TestExpectations
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d73308c
    • ojan@chromium.org's avatar
      Provide a runtime setting to disable position:sticky · 52498d7e
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96827
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Have it be on by default so that only ports that both enable
      the define and don't want it on by default need to do something special.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParserContext::CSSParserContext):
      (WebCore::operator==):
      (WebCore::isValidKeywordPropertyAndValue):
      * css/CSSParserMode.h:
      (CSSParserContext):
      * dom/Document.cpp:
      (WebCore::Document::cssStickyPositionEnabled):
      (WebCore):
      * dom/Document.h:
      (Document):
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      (Settings):
      (WebCore::Settings::setCSSStickyPositionEnabled):
      (WebCore::Settings::cssStickyPositionEnabled):
      
      Source/WebKit/chromium:
      
      * public/WebSettings.h:
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52498d7e
    • slewis@apple.com's avatar
      mac-future ignores previous platform TestExpectations. · 160c1356
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96718.
      
      Reviewed by Dirk Pranke.
      
      TestExpectations match an expectation's configuraton against a list of configurations that are
      valid for that port.  That list does not contain mac-future so none of the expectations can be
      applied.
      
      * Scripts/webkitpy/layout_tests/port/apple.py:
      (ApplePort._generate_all_test_configurations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      160c1356
    • ojan@chromium.org's avatar
      Add expectations for tests that depend on other tests running before them. · 9cf0a964
      ojan@chromium.org authored
      Filed a bug for each with information on which test it depends on.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cf0a964
    • simon.fraser@apple.com's avatar
      Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656. · 7793b456
      simon.fraser@apple.com authored
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyImageResolution::applyInheritValue):
      (WebCore::ApplyPropertyImageResolution::applyInitialValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7793b456
    • jamesr@google.com's avatar
      Unreviewed gardening. · fb5d20a1
      jamesr@google.com authored
      Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
      DumpRenderTree.
      
      * fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
      * fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
      * platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
      * platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
      * platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
      * platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb5d20a1
    • abarth@webkit.org's avatar
      Remove webkitPostMessage · 79bb5ebb
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96577
      
      Reviewed by Ojan Vafai.
      
      .:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      webkitPostMessage works the same as postMessage. The spec and the
      implementation have been stable for a while. We should no longer be
      exposing this vendor-prefixed API.
      
      This patch places the webkitPostMessage API behind an ENABLE flag.
      We're going to try removing this API in the Chromium port. If we don't
      run into trouble, we'll remove it in all the other ports as well.
      
      This topic has been discussed on webkit-dev in
      http://lists.webkit.org/pipermail/webkit-dev/2012-April/020237.html and
      http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html
      
      This patch introduces the ENABLE(LEGACY_VENDOR_PREFIXES) flag. Rather
      than having a flag for each vendor-prefixed API we're experimenting
      with removing, we'll add vendor prefixed APIs to this ENABLE when we
      want to try removing them. If we succeed, we'll just delete the APIs.
      If we fail, we'll remove them from the ENABLE. That way we avoid the
      churn of adding and removing many ENABLE macros.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore):
      * bindings/js/JSDedicatedWorkerContextCustom.cpp:
      (WebCore):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore):
      * bindings/js/JSWorkerCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8MessagePortCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8WorkerCustom.cpp:
      (WebCore):
      * dom/MessagePort.idl:
      * page/DOMWindow.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/Worker.idl:
      
      Source/WebKit/chromium:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests:
      
      Update tests to rely only upon the unprefixed API.
      
      * fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:
      (wrapSend):
      (wrapFailSend):
      * fast/dom/Window/post-message-crash.html:
      * fast/dom/Window/window-postmessage-args-expected.txt:
      * fast/dom/Window/window-postmessage-args.html:
      * fast/events/message-port.html:
      * fast/events/resources/message-port-multi.js:
      * fast/workers/resources/worker-call.js:
      * fast/workers/worker-call-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79bb5ebb
    • ap@apple.com's avatar
      Minimize collisions when hashing pairs · 73a1c7fd
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=96022
      
              Build fix (with newer clang?)
      
              * wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from
              64 bit to 32 bit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73a1c7fd
    • simon.fraser@apple.com's avatar
      REGRESSION: transition doesn’t always override transition-property · 04224074
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96658
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Setting the animation property on an Animation in CSSToStyleMap::mapAnimationProperty()
      is special because we have to call setAnimationMode(Animation::AnimateAll) as well
      as setting the property to CSSPropertyInvalid if it's for the initial state
      of the transition-property property.
      
      In order to fix this via StyleBuilder PropertyHandlers, we have to know,
      in ApplyPropertyAnimation::applyInitialValue(), which property is getting applied.
      This requires passing the CSSPropertyID down through all of the "apply" methods.
      
      Do some unrelated cleanup in CSSParser::parseTransitionShorthand(); the existing code
      was not safe with respect to adding new properties to the shorthand.
      
      Test: transitions/longhand-vs-shorthand-initial.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseTransitionShorthand):
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyExpanding::applyInheritValue):
      (WebCore::ApplyPropertyExpanding::applyInitialValue):
      (WebCore::ApplyPropertyExpanding::applyValue):
      (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
      (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
      (WebCore::ApplyPropertyDefaultBase::applyValue):
      (WebCore::ApplyPropertyDefault::applyValue):
      (WebCore::ApplyPropertyNumber::applyValue):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::ApplyPropertyAuto::applyInheritValue):
      (WebCore::ApplyPropertyAuto::applyInitialValue):
      (WebCore::ApplyPropertyAuto::applyValue):
      (WebCore::ApplyPropertyClip::applyInheritValue):
      (WebCore::ApplyPropertyClip::applyInitialValue):
      (WebCore::ApplyPropertyClip::applyValue):
      (WebCore::ApplyPropertyColor::applyInheritValue):
      (WebCore::ApplyPropertyColor::applyInitialValue):
      (WebCore::ApplyPropertyColor::applyValue):
      (WebCore::ApplyPropertyDirection::applyValue):
      (WebCore::ApplyPropertyLength::applyValue):
      (WebCore::ApplyPropertyString::applyValue):
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyFillLayer::applyInheritValue):
      (WebCore::ApplyPropertyFillLayer::applyInitialValue):
      (WebCore::ApplyPropertyFillLayer::applyValue):
      (WebCore::ApplyPropertyComputeLength::applyValue):
      (WebCore::ApplyPropertyFont::applyInheritValue):
      (WebCore::ApplyPropertyFont::applyInitialValue):
      (WebCore::ApplyPropertyFont::applyValue):
      (WebCore::ApplyPropertyFontSize::applyInheritValue):
      (WebCore::ApplyPropertyFontSize::applyInitialValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyFontWeight::applyValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
      (WebCore::ApplyPropertyBorderImage::applyValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyValue):
      (WebCore::ApplyPropertyBorderImageSource::applyValue):
      (WebCore::ApplyPropertyCounter::emptyFunction):
      (WebCore::ApplyPropertyCounter::applyInheritValue):
      (WebCore::ApplyPropertyCounter::applyValue):
      (WebCore::ApplyPropertyCursor::applyInheritValue):
      (WebCore::ApplyPropertyCursor::applyInitialValue):
      (WebCore::ApplyPropertyCursor::applyValue):
      (WebCore::ApplyPropertyTextAlign::applyValue):
      (WebCore::ApplyPropertyTextDecoration::applyValue):
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyPageSize::applyInheritValue):
      (WebCore::ApplyPropertyPageSize::applyInitialValue):
      (WebCore::ApplyPropertyPageSize::applyValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
      (WebCore::ApplyPropertyAnimation::applyInheritValue):
      (WebCore::ApplyPropertyAnimation::applyInitialValue): If the property is
      CSSPropertyWebkitTransitionProperty, call setAnimationMode(Animation::AnimateAll).
      (WebCore::ApplyPropertyAnimation::applyValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
      (WebCore::ApplyPropertyOutlineStyle::applyValue):
      (WebCore::ApplyPropertyResize::applyValue):
      (WebCore::ApplyPropertyVerticalAlign::applyValue):
      (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
      (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
      (WebCore::ApplyPropertyAspectRatio::applyValue):
      (WebCore::ApplyPropertyZoom::applyInheritValue):
      (WebCore::ApplyPropertyZoom::applyInitialValue):
      (WebCore::ApplyPropertyZoom::applyValue):
      (WebCore::ApplyPropertyDisplay::applyInheritValue):
      (WebCore::ApplyPropertyDisplay::applyInitialValue):
      (WebCore::ApplyPropertyDisplay::applyValue):
      (WebCore::ApplyPropertyClipPath::applyValue):
      (WebCore::ApplyPropertyWrapShape::applyValue):
      (WebCore::ApplyPropertyImageResolution::applyInheritValue):
      (WebCore::ApplyPropertyImageResolution::applyInitialValue):
      (WebCore::ApplyPropertyImageResolution::applyValue):
      * css/StyleBuilder.h:
      (PropertyHandler):
      (WebCore::PropertyHandler::applyInheritValue):
      (WebCore::PropertyHandler::applyInitialValue):
      (WebCore::PropertyHandler::applyValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Pass in the property ID.
      
      LayoutTests:
      
      Test with longhand transition-property rule, followed by shorthand
      with missing property value. This test should pass, and not assert.
      
      * transitions/longhand-vs-shorthand-initial-expected.txt: Added.
      * transitions/longhand-vs-shorthand-initial.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04224074
    • commit-queue@webkit.org's avatar
      Support constructor-type attribute in idls other than DOMWindow. · 6cb79daf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96821
      
      Patch by Chang Shu <cshu@webkit.org> on 2012-09-14
      Reviewed by Kentaro Hara.
      
      In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
      attribute. So for other interfaces, we should pass castedThis->globalObject()
      instead of castedThis.
      
      Test: bindings/scripts/test/JS/JSTestObj.idl
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjConstructorTestSubObj):
      (WebCore::jsTestObjConditionalAttr4Constructor):
      (WebCore::jsTestObjConditionalAttr5Constructor):
      (WebCore::jsTestObjConditionalAttr6Constructor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cb79daf
    • tsepez@chromium.org's avatar
      ImageLoader can't be cleared when video element poster attribute removed. · ccd1e0c0
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96301
      
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
      clear the image loader when the src attribute is cleared, because we might be
      inside a handler called on top of an image loader event dispatch. Instead we
      will rely on the OwnPtr relationship between the Element and the Image Loader
      to limit the lifetime of the loader to that of the element.
      
      Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html
      
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      
      LayoutTests:
      
      Added test case.
      
      * fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
      * fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccd1e0c0
    • jpfau@apple.com's avatar
      Allow third-party storage blocking setting to change while a page is loaded · aaef7311
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95790
      
      Reviewed by Brady Eidson.
      
      .:
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Pipe through changes to the storage blocking policy to each document and plugin.
      
      Tests: http/tests/security/storage-blocking-loosened-local-storage.html
             http/tests/security/storage-blocking-loosened-plugin.html
             http/tests/security/storage-blocking-loosened-private-browsing-plugin.html
             http/tests/security/storage-blocking-loosened-shared-worker.html
             http/tests/security/storage-blocking-loosened-websql.html
             http/tests/security/storage-blocking-strengthened-local-storage.html
             http/tests/security/storage-blocking-strengthened-plugin.html
             http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html
             http/tests/security/storage-blocking-strengthened-shared-worker.html
             http/tests/security/storage-blocking-strengthened-websql.html
      
      * WebCore.exp.in:
      * dom/Document.cpp: Pipe changes through to the Document's SecurityOrigin.
      (WebCore::Document::storageBlockingStateDidChange):
      (WebCore):
      * dom/Document.h:
      (Document):
      * page/DOMWindow.cpp: Check to make sure access is allowed before returning a cached storage area.
      (WebCore::DOMWindow::sessionStorage):
      (WebCore::DOMWindow::localStorage):
      * page/Page.cpp:
      (WebCore::Page::collectPluginViews): Refactored out into a function.
      (WebCore):
      (WebCore::Page::storageBlockingStateChanged): Pipe changes through to each PluginView.
      (WebCore::Page::privateBrowsingStateChanged):
      * page/Page.h:
      (Page):
      * page/Settings.cpp:
      (WebCore::Settings::setStorageBlockingPolicy): Tell Pages about changes to the storage blocking policy.
      (WebCore):
      * page/Settings.h:
      (Settings):
      * plugins/PluginViewBase.h:
      (WebCore::PluginViewBase::storageBlockingStateChanged):
      
      Source/WebKit2:
      
      Inform plugins about changes to the storage blocking policy by way of the private browsing feature.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::storageBlockingStateChanged):
      (WebKit):
      * PluginProcess/PluginControllerProxy.h:
      (PluginControllerProxy):
      * PluginProcess/PluginControllerProxy.messages.in: Add WK2 message for storageBlockingStateChanged.
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::storageBlockingStateChanged):
      (WebKit):
      (WebKit::NetscapePlugin::privateBrowsingStateChanged):
      (WebKit::NetscapePlugin::updateNPNPrivateMode): Set plugin's private browsing if either private browsing or storage blocking is enabled.
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      (NetscapePlugin):
      * WebProcess/Plugins/PDF/BuiltInPDFView.h:
      (BuiltInPDFView):
      * WebProcess/Plugins/PDF/BuiltInPDFView.mm: Treat storageBlockingStateChanged as a no-op.
      (WebKit::BuiltInPDFView::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/Plugin.h: Add pure virtual storageBlockingStateChanged method.
      (Plugin):
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/PluginProxy.h:
      (PluginProxy):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/PluginView.h:
      (PluginView):
      * win/WebKit2.def:
      
      LayoutTests:
      
      Tested combinations of loosening and strengthening the storage blocking policy on various types of storage.
      
      * http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html: Added.
      * http/tests/security/resources/iframe-for-storage-blocking-changed-shared-worker.html: Added.
      * http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html: Added.
      * http/tests/security/storage-blocking-loosened-local-storage-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-local-storage.html: Added.
      * http/tests/security/storage-blocking-loosened-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-plugin.html: Added.
      * http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-private-browsing-plugin.html: Added.
      * http/tests/security/storage-blocking-loosened-shared-worker-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-shared-worker.html: Added.
      * http/tests/security/storage-blocking-loosened-websql-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-websql.html: Added.
      * http/tests/security/storage-blocking-strengthened-local-storage-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-local-storage.html: Added.
      * http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-plugin.html: Added.
      * http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html: Added.
      * http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-shared-worker.html: Added.
      * http/tests/security/storage-blocking-strengthened-websql-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-websql.html: Added.
      * platform/chromium/TestExpectations: Skip shared worker and plugin tests.
      * platform/mac-wk2/http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
      * platform/mac-wk2/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaef7311
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=96688 · 2b20219a
      bdakin@apple.com authored
      Put position:fixed elements in their own layers and allow them to 
      create a stacking context
      -and corresponding-
      <rdar://problem/11467961>
      
      Reviewed by Simon Fraser.
      
      Source/WebKit/mac: 
      
      Enable these settings in WK1 too for consistency. 
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit2: 
      
      Soon we want pages with fixed positioned elements to be able to be 
      scrolled by the ScrollingCoordinator. As a part of that work, we have 
      to composite fixed position elements, and we have to allow those
      elements to create a stacking context.
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      
      LayoutTests: 
      
      A few test result differences. These first three tests actually
      render differently now.
      * platform/mac/fast/block/positioning/016-expected.png:
      * platform/mac/fast/block/positioning/016-expected.txt:
      * platform/mac/fast/block/positioning/025-expected.png:
      * platform/mac/fast/block/positioning/025-expected.txt:
      * platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
      * platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      
      These tests just have different layer trees. 
      * platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/mac/compositing/rtl: Added.
      * platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
      * platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b20219a
    • commit-queue@webkit.org's avatar
      Prevent workers from calling back into other worlds · 41cab7c7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96790
      
      Patch by Dan Carney <dcarney@google.com> on 2012-09-14
      Reviewed by Adam Barth.
      
      Added a few sanity checks to ensure callbacks are always using the correct world.
      
      No new tests. No new change in functionality.
      
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::getEventListener):
      * bindings/v8/V8LazyEventListener.cpp:
      (WebCore::V8LazyEventListener::prepareListenerObject):
      * bindings/v8/WorldContextHandle.cpp:
      (WebCore::WorldContextHandle::WorldContextHandle):
      (WebCore::WorldContextHandle::adjustedContext):
      * bindings/v8/WorldContextHandle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41cab7c7
    • danakj@chromium.org's avatar
      Minimize collisions when hashing pairs · a9d74b51
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96022
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Use WTF::pairIntHash() to hash pairs of integers.
      
      * dom/Document.cpp:
      (WebCore::ImmutableAttributeDataCacheKey::hash):
      * dom/StyledElement.cpp:
      (WebCore::computePresentationAttributeCacheHash):
      * platform/graphics/Gradient.cpp:
      (WebCore::Gradient::hash):
      * platform/graphics/IntPointHash.h:
      (WTF::IntPointHash::hash):
      * platform/graphics/IntRectHash.h:
      * platform/graphics/IntSizeHash.h:
      * platform/graphics/blackberry/LayerTileIndex.h:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::SubimageCacheHash::hash):
      
      Source/WebKit/blackberry:
      
      Use WTF::pairIntHash() to hash a pair of integers.
      
      * WebKitSupport/TileIndexHash.h:
      
      Source/WTF:
      
      The current hash function for pairs has poor performance as it does a
      nice hash function on 64 bits, but then just drops the top 32 bits. The
      hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
      but this requires not dropping any bits in order to retain the
      characteristics mentioned by Thomas.
      
      A better method of hashing sets of 32-bit integers is to use
      multiplication in 64 bits with random integers. This method is a
      provably almost-universal hash function. Testing shows that this
      method decreases the time required, when compared with the current
      method, by more than 20% due to better hashing characteristics.
      
      * wtf/HashFunctions.h:
      (WTF):
      (WTF::pairIntHash):
      Implments the hashing method for a pair of unsigned integers.
      
      (WTF::PairHash::hash):
      Use pairIntHash() on the hash results of each object in the pair.
      
      (WTF::IntPairHash::hash):
      Implement an integer-specific PairHash class that does not need to
      hash each object in the pair. It uses pairIntHash on the two
      integers in the pair directly.
      
      (WTF::IntPairHash::equal):
      (IntPairHash):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9d74b51
    • rniwa@webkit.org's avatar
      Use performance.webkitNow in PerfTestRunner · e688af02
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92826
      
      Reviewed by Eric Seidel.
      
      Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.
      
      * resources/runner.js:
      (PerfTestRunner._runner):
      (PerfTestRunner._perSecondRunnerIterator):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e688af02
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled DEPS. · 10ca3256
      commit-queue@webkit.org authored
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10ca3256
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Use StringBuilder more in BlackBerry RSS classes · 34cecc60
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96820
      
      Reviewed by Antonio Gomes.
      
      Use append/appendLiteral where possible.
      
      * platform/MIMETypeRegistry.cpp:
      (WebCore::mimeTypeAssociationMap):
      * platform/network/blackberry/rss/RSSAtomParser.cpp:
      (WebCore::RSSAtomParser::parseContent):
      (WebCore::RSSAtomParser::parseAuthor):
      * platform/network/blackberry/rss/RSSGenerator.cpp:
      (WebCore::RSSGenerator::generateHtml):
      * platform/network/blackberry/rss/RSSParserBase.cpp:
      (WebCore::textFromXMLAttr):
      (WebCore::textFromXMLNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34cecc60
    • achicu@adobe.com's avatar
      [CSS Shaders] Enable anti-aliasing on the FECustomFilter · b6b4aac1
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96668
      
      Reviewed by Dean Jackson.
      
      Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
      with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
      so that we can read the pixels back.
      
      This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
      and GL_OES_rgb8_rgba8.
      
      No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.
      
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter):
      (WebCore::FECustomFilter::deleteRenderBuffers):
      (WebCore):
      (WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
      (WebCore::FECustomFilter::drawFilterMesh):
      (WebCore::FECustomFilter::createMultisampleBuffer):
      (WebCore::FECustomFilter::resolveMultisampleBuffer):
      (WebCore::FECustomFilter::canUseMultisampleBuffers):
      (WebCore::FECustomFilter::resizeMultisampleBuffers):
      (WebCore::FECustomFilter::resizeContext):
      * platform/graphics/filters/FECustomFilter.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b4aac1
    • commit-queue@webkit.org's avatar
      Add in-place reload behavior to ImagesEnabled setting · d0a50678
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95478
      
      .:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Export WebCore::Settings::setImagesEnabled symbol.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Store ImagesEnabled setting in CachedResourceLoader similar to
      AutoLoadImages. Move FrameLoaderClient::allowImage to after a
      CachedImage has been created and store the cache for reload if it is
      blocked.
      
      Make sure when image loads are deferred by either ImagesEnabled or
      LoadImagesAutomatically, onload is not called.
      
      Added ImagesEnabled to InternalSettings for layout tests.
      
      Tests: fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
             fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didBeginDocument):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::willSendRequest):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::load):
      * loader/cache/CachedImage.h:
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::didAddClient):
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::stillNeedsLoad):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      (WebCore):
      (WebCore::CachedResourceLoader::setImagesEnabled):
      (WebCore::CachedResourceLoader::shouldDeferImageLoad):
      (WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      (WebCore::CachedResourceLoader::imagesEnabled):
      * page/Settings.cpp:
      (WebCore::setImageLoadingSettings):
      (WebCore::Settings::Settings):
      (WebCore::Settings::setLoadsImagesAutomatically):
      (WebCore::Settings::imageLoadingSettingsTimerFired):
      (WebCore::Settings::setImagesEnabled):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setImagesEnabled):
      (WebCore):
      * testing/InternalSettings.h:
      (InternalSettings):
      * testing/InternalSettings.idl:
      
      Source/WebKit2:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Export WebCore::Settings::setImagesEnabled symbol.
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      Add tests to check autoLoadImages and imagesEnabled can block
      images and can reload them in place when setting is set to unblock.
      
      image-permissions tests are updated to reflect that onerror will no
      longer be called when images are blocked.
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
      * platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions.html:
      * platform/chromium/permissionclient/resources/image.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a50678
    • eae@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=96226 · 957a0d9b
      eae@chromium.org authored
      REGRESSION (r128006): Three spatial navigation tests are failing
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Fix spatial navigation regression by reverting parts of r128006.
      Specifically the change to remove the overridden boundingBox
      method in ContainerNode.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::getUpperLeftCorner):
      (WebCore):
      (WebCore::ContainerNode::getLowerRightCorner):
      (WebCore::ContainerNode::boundingBox):
      * dom/ContainerNode.h:
      (ContainerNode):
      
      LayoutTests:
      
      Remove spatial navigation tests from Skipped list.
      
      * platform/mac/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      957a0d9b
    • commit-queue@webkit.org's avatar
      [chromium] add touch area to gestureTapDown data · da4fc77b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96806
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Add width/height for GestureTapDown as for GestureTap/LongPress so that
      we can eventually do fuzzing on it.
      * public/WebInputEvent.h:
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da4fc77b
    • jamesr@google.com's avatar
      Unreviewed, rolling out r128627. · cd3fc72f
      jamesr@google.com authored
      http://trac.webkit.org/changeset/128627
      https://bugs.webkit.org/show_bug.cgi?id=96575
      
      Breaks indexeddb content_browsertests in chromium
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::IDBDatabase):
      (WebCore::IDBDatabase::setVersion):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/create-object-store-options-expected.txt:
      * storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/createObjectStore-null-name-expected.txt:
      * storage/indexeddb/cursor-added-bug-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-continue-validity-expected.txt:
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/cursor-inconsistency-expected.txt:
      * storage/indexeddb/cursor-index-delete-expected.txt:
      * storage/indexeddb/cursor-key-order-expected.txt:
      * storage/indexeddb/cursor-overloads-expected.txt:
      * storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
      * storage/indexeddb/cursor-primary-key-order-expected.txt:
      * storage/indexeddb/cursor-reverse-bug-expected.txt:
      * storage/indexeddb/cursor-skip-deleted-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update-value-argument-required-expected.txt:
      * storage/indexeddb/cursor-value-expected.txt:
      * storage/indexeddb/data-corruption-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/database-close-expected.txt:
      * storage/indexeddb/database-closepending-flag-expected.txt:
      * storage/indexeddb/database-deletepending-flag-expected.txt:
      * storage/indexeddb/delete-closed-database-object-expected.txt:
      * storage/indexeddb/delete-range-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/deleteObjectStore-null-name-expected.txt:
      * storage/indexeddb/deleted-objects-expected.txt:
      * storage/indexeddb/deletedatabase-transaction-expected.txt:
      * storage/indexeddb/duplicates-expected.txt:
      * storage/indexeddb/error-causes-abort-by-default-expected.txt:
      * storage/indexeddb/exception-in-event-aborts-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-deletedatabase-expected.txt:
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-cursor-expected.txt:
      * storage/indexeddb/index-duplicate-keypaths-expected.txt:
      * storage/indexeddb/index-get-key-argument-required-expected.txt:
      * storage/indexeddb/index-multientry-expected.txt:
      * storage/indexeddb/index-population-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-and-setversion-expected.txt:
      * storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
      * storage/indexeddb/intversion-long-queue-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-sort-order-across-types-expected.txt:
      * storage/indexeddb/key-sort-order-date-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/key-type-infinity-expected.txt:
      * storage/indexeddb/keypath-arrays-expected.txt:
      * storage/indexeddb/keypath-basics-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keypath-fetch-key-expected.txt:
      * storage/indexeddb/keypath-intrinsic-properties-expected.txt:
      * storage/indexeddb/lazy-index-population-expected.txt:
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/list-ordering-expected.txt:
      * storage/indexeddb/metadata-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
      * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
      * storage/indexeddb/mozilla/cursors-expected.txt:
      * storage/indexeddb/mozilla/delete-result-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/global-data-expected.txt:
      * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
      * storage/indexeddb/mozilla/indexes-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/object-cursors-expected.txt:
      * storage/indexeddb/mozilla/object-identity-expected.txt:
      * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
      * storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
      * storage/indexeddb/mozilla/objectstorenames-expected.txt:
      * storage/indexeddb/mozilla/odd-result-order-expected.txt:
      * storage/indexeddb/mozilla/put-get-values-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
      * storage/indexeddb/mozilla/readyState-expected.txt:
      * storage/indexeddb/mozilla/remove-index-expected.txt:
      * storage/indexeddb/mozilla/remove-objectstore-expected.txt:
      * storage/indexeddb/mozilla/versionchange-abort-expected.txt:
      * storage/indexeddb/mozilla/versionchange-expected.txt:
      * storage/indexeddb/mutating-cursor-expected.txt:
      * storage/indexeddb/noblobs-expected.txt:
      * storage/indexeddb/objectStore-required-arguments-expected.txt:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-clear-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/objectstore-cursor-expected.txt:
      * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
      * storage/indexeddb/odd-strings-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/open-during-transaction-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt:
      * storage/indexeddb/pending-activity-expected.txt:
      * storage/indexeddb/pending-activity-workers-expected.txt:
      * storage/indexeddb/pending-version-change-on-exit-expected.txt:
      * storage/indexeddb/persistence-expected.txt:
      * storage/indexeddb/prefetch-bugfix-108071-expected.txt:
      * storage/indexeddb/queued-commands-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/readonly-properties-expected.txt:
      * storage/indexeddb/request-continue-abort-expected.txt:
      * storage/indexeddb/request-event-propagation-expected.txt:
      * storage/indexeddb/setVersion-null-expected.txt:
      * storage/indexeddb/set_version_blocked-expected.txt:
      * storage/indexeddb/set_version_queue-expected.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/three-setversion-calls-expected.txt:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-event-propagation-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      * storage/indexeddb/transaction-rollback-expected.txt:
      * storage/indexeddb/transaction-storeNames-required-expected.txt:
      * storage/indexeddb/tutorial-expected.txt:
      * storage/indexeddb/two-version-changes-expected.txt:
      * storage/indexeddb/value-undefined-expected.txt:
      * storage/indexeddb/values-odd-types-expected.txt:
      * storage/indexeddb/version-change-abort-expected.txt:
      * storage/indexeddb/version-change-exclusive-expected.txt:
      * storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd3fc72f
    • achicu@adobe.com's avatar
      [CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations · bd6e70c5
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96801
      
      Reviewed by Dean Jackson.
      
      I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
      from outside.
      
      Also removed the Texture class as it is not available on some platforms.
      
      The changes for Skia will land in a different patch:
      https://bugs.webkit.org/show_bug.cgi?id=96579
      
      No new tests, the existing custom filters tests should already cover this.
      
      * platform/graphics/filters/CustomFilterGlobalContext.cpp:
      (WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter):
      (WebCore::FECustomFilter::deleteRenderBuffers):
      (WebCore::FECustomFilter::drawFilterMesh):
      (WebCore):
      (WebCore::FECustomFilter::prepareForDrawing):
      (WebCore::FECustomFilter::programNeedsInputTexture):
      (WebCore::FECustomFilter::applyShader):
      (WebCore::FECustomFilter::initializeContext):
      (WebCore::FECustomFilter::ensureInputTexture):
      (WebCore::FECustomFilter::uploadInputTexture):
      (WebCore::FECustomFilter::ensureFrameBuffer):
      (WebCore::FECustomFilter::resizeContextIfNeeded):
      (WebCore::FECustomFilter::resizeContext):
      (WebCore::FECustomFilter::bindProgramAndBuffers):
      * platform/graphics/filters/FECustomFilter.h:
      (FECustomFilter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6e70c5
    • ojan@chromium.org's avatar
      Comment out bug URL. This fixes a lint warning. · 6211ccfd
      ojan@chromium.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6211ccfd
    • ojan@chromium.org's avatar
      Update all the MISSING lines in chromium's TestExpectations. · 2c9525af
      ojan@chromium.org authored
      If the test always passed, removed the line. In some cases, they just needed
      obvious rebaselines. In others, they haven't reported MISSING in the past
      500 runs on the bots, so removed that expectation.
      
      * platform/chromium-linux-x86/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-linux-x86/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-mac/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-mac/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-win-xp/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-win-xp/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-win/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
      * platform/chromium/TestExpectations:
      * platform/chromium/perf/nested-combined-selectors-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9525af
    • ap@apple.com's avatar
      [WK2] webarchive/loading/javascript-url-iframe-crash.html fails · e4d7ad10
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=96817
      
              Reviewed by Kenneth Rohde Christiansen.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
              got overlooked when adding logging elsewhere.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4d7ad10
    • ap@apple.com's avatar
      REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey · 763a19de
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=95070
      
              Roll out r126717, and another change that depends on it.
              r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
              r127123: Cache and share parsed imported stylesheets
      
              * css/CSSImportRule.cpp:
              * css/CSSImportRule.h:
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::willMutateRules):
              (WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
              (WebCore::CSSStyleSheet::insertRule):
              (WebCore::CSSStyleSheet::ownerDocument):
              * css/CSSStyleSheet.h:
              (WebCore::CSSStyleSheet::clearOwnerRule):
              * css/StyleRuleImport.cpp:
              (WebCore::StyleRuleImport::StyleRuleImport):
              (WebCore::StyleRuleImport::~StyleRuleImport):
              (WebCore::StyleRuleImport::setCSSStyleSheet):
              (WebCore::StyleRuleImport::isLoading):
              (WebCore::StyleRuleImport::requestStyleSheet):
              * css/StyleRuleImport.h:
              (WebCore::StyleRuleImport::parentStyleSheet):
              (WebCore::StyleRuleImport::setParentStyleSheet):
              (WebCore::StyleRuleImport::clearParentStyleSheet):
              (ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::~ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::setCSSStyleSheet):
              * css/StyleSheetContents.cpp:
              (WebCore::StyleSheetContents::StyleSheetContents):
              (WebCore::StyleSheetContents::isCacheable):
              (WebCore::StyleSheetContents::parserAppendRule):
              (WebCore::StyleSheetContents::clearRules):
              (WebCore::StyleSheetContents::wrapperInsertRule):
              (WebCore::StyleSheetContents::wrapperDeleteRule):
              (WebCore::StyleSheetContents::parseAuthorStyleSheet):
              (WebCore::StyleSheetContents::parseStringAtLine):
              (WebCore::StyleSheetContents::checkLoaded):
              (WebCore::StyleSheetContents::notifyLoadedSheet):
              (WebCore::StyleSheetContents::startLoadingDynamicSheet):
              (WebCore::StyleSheetContents::rootStyleSheet):
              (WebCore::StyleSheetContents::singleOwnerNode):
              (WebCore::StyleSheetContents::singleOwnerDocument):
              (WebCore::StyleSheetContents::parentStyleSheet):
              * css/StyleSheetContents.h:
              (WebCore::StyleSheetContents::create):
              (StyleSheetContents):
              (WebCore::StyleSheetContents::ownerRule):
              (WebCore::StyleSheetContents::clearOwnerRule):
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::parseStyleSheet):
              * dom/StyleElement.cpp:
              (WebCore::StyleElement::createSheet):
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::setCSSStyleSheet):
              * loader/cache/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763a19de
    • commit-queue@webkit.org's avatar
      [EFL] RefPtr<Evas_Object> unit tests fails · a8149ebf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96809
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Added missing return.
      
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
      (EWK2UnitTest::EWK2UnitTestBase::canvas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8149ebf
    • ojan@chromium.org's avatar
      Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751. · 1add1d00
      ojan@chromium.org authored
      The results all look like they pass.
      
      * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1add1d00
    • ojan@chromium.org's avatar
      Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916. · 2d098aef
      ojan@chromium.org authored
      All the differences were anti-aliasing/form-controls.
      
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d098aef
    • ojan@chromium.org's avatar
      Simplify some code in RenderBox::computePercentageLogicalHeight · 106981c2
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96704
      
      Reviewed by Tony Chang.
      
      This is strictly code cleanup. No behavior change.
      Also removed some comments that were what comments and/or were
      getting stale.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
      (WebCore):
      (WebCore::RenderBox::computePercentageLogicalHeight):
      * rendering/RenderBox.h:
      (RenderBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      106981c2
    • peter@chromium.org's avatar
      [Chromium] Build fix for DumpRenderTree following r128628 · 439dffb1
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96808
      
      Reviewed by Tony Chang.
      
      When building DumpRenderTree from the Chromium project, a compile error
      shows up because including the header ForwardIOStreamsAndroid.h cannot
      be located. TestWebKitAPI does this correctly.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      439dffb1
    • danakj@chromium.org's avatar
      Change cc-bugs@google.com watchlist to cc-bugs@chromium.org · 04bbffca
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96805
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/common/config/committers.py:
      * Scripts/webkitpy/common/config/watchlist:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04bbffca
    • danakj@chromium.org's avatar
      [chromium] Add the ubercomp WebDelegatedRendererLayer · 5a473d21
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94145
      
      Reviewed by Adrienne Walker.
      
      Expose a WebDelegatedRendererLayer to allow the browser compositor to
      embed such a layer in its tree. This layer will be connected to IPC
      machinery in the compositor that is yet TBD which will give a set of
      RenderPasses with DrawQuads to the impl copy of the layer.
      
      * Platform.gypi:
      * chromium/public/WebCompositorSupport.h:
      (WebKit):
      (WebKit::WebCompositorSupport::createDelegatedRendererLayer):
      (WebCompositorSupport):
      * chromium/public/WebDelegatedRendererLayer.h: Added.
      (WebKit):
      (WebDelegatedRendererLayer):
      (WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a473d21
    • tkent@chromium.org's avatar
      Unreviewed, a workaround for a mysterious crash on Apple Windows port. · 3e304c72
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96636
      
      * testing/InternalSettings.cpp:
      Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
      ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      (WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
      * testing/InternalSettings.h:
      (Backup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e304c72
    • peter@chromium.org's avatar
      [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests · 741e8122
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96687
      
      Reviewed by Tony Chang.
      
      Android's DumpRenderTree currently supports these arguments, implemented
      as part of TestShellAndroid:
      http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
      
      They're used by the layout test runner to get the STDOUT and STDERR while
      a layout test run is in process, which is a safer alternative to parsing
      all the logcat output manually. The implementation can be seen here:
      http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
      
      This patch generalizes parsing of and applying the effects of these arguments
      so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
      After this patch, this will make it possible to pull out the output-reading
      code from Android's layout test port and generalize it so it can be re-used
      in the new test-runner for the other two test suites.
      
      This has no effect when compiling and running these tests as part of Chromium
      code, which has a much more advanced test-runner that does parse complete log
      output, but also directly depends on code licensed under Apache 2.
      
      Source/WebKit/chromium:
      
      * WebKit.gypi:
      * tests/ForwardIOStreamsAndroid.cpp: Added.
      (WebKit):
      (WebKit::maybeInitIOStreamForwardingForAndroid):
      * tests/ForwardIOStreamsAndroid.h: Added.
      (WebKit):
      * tests/RunAllTests.cpp:
      (main):
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      * DumpRenderTree/chromium/TestShellAndroid.cpp:
      (platformInit):
      * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      741e8122