Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 27 May, 2008 5 commits
  3. 26 May, 2008 15 commits
    • slewis@apple.com's avatar
      2008-05-26 Stephanie Lewis <slewis@apple.com> · 1ae776fd
      slewis@apple.com authored 
              Windows build fix.

        * kjs/testkjs.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ae776fd
    • alp@webkit.org's avatar
      2008-05-26 Alp Toker <alp@nuanti.com> · c7738990
      alp@webkit.org authored 
              Reviewed by Anders.

        http://bugs.webkit.org/show_bug.cgi?id=16495
        [GTK] Accessibility support with ATK/AT-SPI

        Implement basic action, text and editable text accessibility.

        Provide utility functions to simplify const string return and casting
        and add some more stubs.

        It's now possible to navigate and manipulate forms and text using
        assistive technologies.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
        (returnString):
        (core):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::AXButtonActionVerb):
        (WebCore::AXRadioButtonActionVerb):
        (WebCore::AXTextFieldActionVerb):
        (WebCore::AXCheckedCheckBoxActionVerb):
        (WebCore::AXUncheckedCheckBoxActionVerb):
        (WebCore::AXLinkActionVerb):
        (WebCore::imageTitle):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7738990
    • mjs@apple.com's avatar
      JavaScriptCore: · 29f56a87
      mjs@apple.com authored 
      2008-05-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.
        
        - make addStaticGlobals protected instead of private so subclasses can use it

        * JavaScriptCore.exp:
        * kjs/JSGlobalObject.h:

WebCore:

2008-05-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.

        - bind the window's "document" and "window" properties to static slots
        1.7% speedup on Acid3 test 26
        
        Only the "document" part matters for Acid3, but since I was doing
        this anyway, "window" also seemed like a good one to optimize.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable
        slots for document and window; but just put null in the document
        slot for now.
        (WebCore::JSDOMWindowBase::updateDocument): Fill in the document
        slot.        
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop
        tracking us.
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet
        for our still-not-dead inner windows.
        (WebCore::JSDOMWindowShell::updateDocument): Update all our
        inner windows ever (to make sure the update to the document
        property shows up everywhere).
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::setWindow): Update our hash.
        (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): Don't set self as a property map property of
        the window, this is no longer necessary.
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScript): Update document for the
        newly created window.
        * bindings/js/kjs_proxy.h:
        * page/Frame.cpp:
        (WebCore::Frame::setDocument): If the document is not null,
        update our window.

LayoutTests:

2008-05-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.
        
        - update test result for document/window being allocated to var slots

        * http/tests/security/cross-frame-access-put-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29f56a87
    • collinj@webkit.org's avatar
      2008-05-26 James Ren <jamesjren@gmail.com> · fbb4e7bd
      collinj@webkit.org authored 
              Reviewed by Sam Weinig, landed by Collin Jackson.

        http://bugs.webkit.org/show_bug.cgi?id=19163

        Modified some http/security layout tests to allow them to run in Firefox.

        * http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
        * http/tests/security/resources/localhost-accesssor.html:
          Added a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=434912

        * http/tests/security/resources/cross-frame-access.js:
          Changed shouldBe to also gracefully handle exceptions
        
        * http/tests/security/resources/foreign-domain-iframe-for-selection-test.html:
          Added feature detection for setBaseAndExtent and selectAllChildren

        * http/tests/security/cross-frame-access-enumeration-expected.txt:
        * http/tests/security/cross-frame-access-enumeration.html:
          Fixed typo (missing '.html')

        * http/tests/security/cross-frame-access-call-expected.txt:
        * http/tests/security/cross-frame-access-call.html:
        * http/tests/security/cross-frame-access-first-time.html:
        * http/tests/security/cross-frame-access-put.html:
        * http/tests/security/cross-frame-access-selection.html:
          Caught exceptions that Firefox throws, to allow the test to run to completion.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbb4e7bd
    • andersca@apple.com's avatar
      2008-05-26 Anders Carlsson <andersca@apple.com> · 4292302b
      andersca@apple.com authored 
              Reviewed by Sam.

        This patch does two things:
        
        * It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know
        that the node doesn't have a wrapper. This avoids a hash lookup.
        
        * It adds toJSNewlyCreated methods for JSElement and JSText. 
        
        All in all this is a 4.3% speedup on Acid 3 test 26.
        
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapper):
        (WebCore::toJSNewlyCreated):
        (WebCore::toJS):
        * bindings/js/JSTextCustom.cpp: Added.
        (WebCore::toJSNewlyCreated):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4292302b
    • darin@apple.com's avatar
      Fixed date of ChangeLog entry. · 9656ab16
      darin@apple.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9656ab16
    • weinig@apple.com's avatar
      2008-05-26 Sam Weinig <sam@webkit.org> · c2fb321b
      weinig@apple.com authored 
              Reviewed by Anders Carlsson.

        Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
        and JSDocument for a 1-2% speedup on Acide 3 test 26.

        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSEventTargetNode.h:
        (WebCore::JSEventTargetNode::getOwnPropertySlot):
        (WebCore::JSEventTargetNode::getValueProperty):
        (WebCore::JSEventTargetNode::put):
        (WebCore::JSEventTargetNode::putValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/Node.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2fb321b
    • darin@apple.com's avatar
      2008-05-25 Darin Adler <darin@apple.com> · 32dec5c7
      darin@apple.com authored 
              Reviewed by Maciej.

        - https://bugs.webkit.org/show_bug.cgi?id=19239

        Removed code that would only useful if if there was any way to create an Entity
        node or if we populated EntityReference nodes. It's likely that we'll remove
        these node types entirely in some future version of WebKit, depending in part
        on what happens with these in HTML 5.

        1.8% speedup of Acid3 test 26.

        The only read-only nodes we ever create are EntityReference nodes.
        These are only created by explicit calls to the Document.createEntityReference
        function. Since the created nodes are read-only, there can be no children of
        these nodes, so no other types of nodes can be read-only despite the rule that
        makes descendants of Entity and EntityReference nodes read-only.

        * bindings/objc/DOM.mm: Removed unneeded include.

        * dom/Attr.cpp:
        (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check.
        (WebCore::Attr::setNodeValue): Ditto.
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check.
        (WebCore::CharacterData::substringData): Don't initialize the ec variable before
        calling checkCharDataOperation, since that function already does it.
        (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check.
        (WebCore::CharacterData::insertData): Don't initialize ec.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setNodeValue): Removed now-misleading comment.
        (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary
        isReadOnlyNode check.
        * dom/CharacterData.h: Made checkCharDataOperation private and non-virtual
        since it's never used or defined in any other class.

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.

        * dom/Entity.cpp: Removed the entire contents of this file.

        * dom/Entity.h: Replaced the class with a stub -- just enough to keep the
        public bindings (JavaScript and Objective-C compiling), but the class is
        abstract and can't be instantianted.

        * dom/EntityReference.cpp: Removed unused constructor.
        (WebCore::EntityReference::cloneNode): Removed unneeded code and comments
        to clone nonexistent child nodes.
        * dom/EntityReference.h: Removed unused constructor and unnecessary override
        of childTypeAllowed, since no children are allowed at all.

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check.
        (WebCore::NamedAttrMap::removeNamedItem): Ditto.
        * dom/NamedAttrMap.h: Removed isReadOnlyNode function.

        * dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of
        virtual nodeType function calls.
        * dom/Node.h:
        (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode
        function with a new simple non-virtual one.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode
        check.

        * dom/Text.cpp:
        (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check.
        (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion.
        There is no reason for this function to go out of its way to mention the
        read-only node issue when none of the other DOM mutation functions do.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32dec5c7
    • abarth@webkit.org's avatar
      2008-05-26 Adam Barth <abarth@webkit.org> · 5fafea96
      abarth@webkit.org authored 
              Reviewed by Sam.

        Cleanup SecurityOrigin::canAccess.  Removed comment referring to an
        old version of the code.  Removed some useless code.

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fafea96
    • ggaren@apple.com's avatar
      ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors' · f7c50d3b
      ggaren@apple.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7c50d3b
    • ggaren@apple.com's avatar
      2008-05-26 Geoffrey Garen <ggaren@apple.com> · d0e5f774
      ggaren@apple.com authored 
              Reviewed by Darin Adler.
        
        Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
        error, all profile stack frames are incorrect
        
        SunSpider reports a .3% speedup, possibly because eval of a string is a
        little more efficient now.

        * VM/Machine.cpp:
        (KJS::callEval): Make sure to call didExecute when returning early. I
        simplified this function to remove one early return, making the job
        of adding special code to early returns easier.

        (KJS::Machine::execute): Use the new function ExecState when notifying
        the profiler. (This doesn't change behavior now, but it  might lead to
        subtle errors in the future.)



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e5f774
    • andersca@apple.com's avatar
      2008-05-26 Anders Carlsson <andersca@apple.com> · a395a4b8
      andersca@apple.com authored 
              Reviewed by Sam.

        Add a name to the source frame.
        
        * fast/frames/viewsource-empty-attribute-value-expected.txt:
        * fast/frames/viewsource-empty-attribute-value.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a395a4b8
    • jmalonzo@webkit.org's avatar
      2008-05-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org> · a51d0855
      jmalonzo@webkit.org authored 
              Reviewed by Alp Toker.

        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51d0855
    • hausmann@webkit.org's avatar
      JavaScriptCore: · 9f6c2938
      hausmann@webkit.org authored 
      2008-05-23  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Fixed toLower and toUpper implementations to allow being called
        with a null result pointer and resultLength, to determine the
        number of characters needed for the case conversion.

LayoutTests:

008-05-23  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Added a comment to the skipping of fast/css/case-transform.html that
        mentions the reason of failure being a Qt bug.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f6c2938
    • hausmann@webkit.org's avatar
      2008-05-26 Tor Arne Vestbø <tavestbo@trolltech.com> · a15751b7
      hausmann@webkit.org authored 
              Reviewed by Simon

        Update QtWebkit layout-tests in accordance with bug 18976

        https://bugs.webkit.org/show_bug.cgi?id=18976

        The test fast/xsl/xslt-text.xml is on our skipped list due to
        missing XSLT support in Qt.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a15751b7
  5. 25 May, 2008 14 commits
  7. 24 May, 2008 6 commits