1. 10 Dec, 2010 40 commits
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · c91e4970
      eric@webkit.org authored
              Reviewed by Tony Chang.
      
              commit-queue should report port/platform information when commenting on flaky test bugs
              https://bugs.webkit.org/show_bug.cgi?id=50839
      
              This was a suggestion from Tony Chang this morning.
              I added a platform.py class so I could easily mock the platform call,
              but that may not be the final solution for this mocking.
              We'll try it and see.
      
              * Scripts/webkitpy/common/system/platform.py: Added.
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/main.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c91e4970
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectations update. · 0572ec78
      pkasting@chromium.org authored
      * platform/chromium-gpu/test_expectations.txt:
      * platform/chromium/fast/encoding: Added.
      * platform/chromium/fast/encoding/meta-in-script-expected.txt: Added
        V8-specific expectation.
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0572ec78
    • enrica@apple.com's avatar
      WebCore: Implement IME support for Mac. · f6768536
      enrica@apple.com authored
      <rdar://problem/7660589> WebKit2: Implement IME support for Mac.
      https://bugs.webkit.org/show_bug.cgi?id=50788
      
      Reviewed by Alexey Proskuryakov.
      
      * dom/KeyboardEvent.h:
      (WebCore::KeypressCommand::KeypressCommand): Removed ASSERT in constructor,
      since it is now used for more than one command.
      
      WebKit2: Implement IME support for Mac.
      <rdar://problem/7660589> WebKit2: Implement IME support for Mac.
      https://bugs.webkit.org/show_bug.cgi?id=50788
                  
      Reviewed by Alexey Proskuryakov.
      
      This patch addes support for input methods in WebKit2.
      In order to support IME, it was necessary to add synchronous calls from the UIProcess
      to the WebProcess. These calls all have a timeout of 1 second.
      The current implementation still uses the NSTextInput protocol, but the plan is to move
      to the NSTextInputClient protocol. This has not been done yet for ease of comparison with
      WebKit. attributedSubstringFromRange is the only method that has not been implemented, because
      I have not yet decided what is the best way to send an NSAttributedString across the process
      boundary.
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction): Added template for member function.
      with four reply arguments.
      * Scripts/webkit2/messages.py: Added CompositionUnderline and relevant header.
      * Shared/WebCoreArgumentCoders.h:
      (CoreIPC::): Added encoder/decoder for CompositionUnderline.
      * UIProcess/API/mac/PageClientImpl.h: Added parameters to interceptKeyEvent and selectionChanged.
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::selectionChanged): Added parameters.
      (WebKit::PageClientImpl::interceptKeyEvent): Added parameters.
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]): Added initialization of new private members.
      (-[WKView insertText:]):
      (-[WKView _selectionChanged:isEditable:isPassword:hasMarkedText:range:]): Added parameters.
      (-[WKView _interceptKeyEvent:hasComposition:start:end:lines:WebCore::]): Added parameters.
      (-[WKView keyDown:]): Modified to reset state on each keyDown.
      (-[WKView selectedRange]): Added.
      (-[WKView hasMarkedText]): Added.
      (-[WKView unmarkText]): Added.
      (-[WKView validAttributesForMarkedText]): Added.
      (extractUnderlines): Added.
      (-[WKView setMarkedText:selectedRange:]): Added.
      (-[WKView markedRange]): Added.
      (-[WKView attributedSubstringFromRange:]): Added.
      (-[WKView characterIndexForPoint:]): Added.
      (-[WKView firstRectForCharacterRange:]): Added.
      (-[WKView conversationIdentifier]): Added.
      * UIProcess/API/mac/WKViewInternal.h: Added parameters to _interceptKeyEvent and _selectionChanged.
      * UIProcess/PageClient.h: Added parameters to interpretKeyEvent and selectionChanged.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::getMarkedRange): Added.
      (WebKit::WebPageProxy::characterIndexForPoint): Added.
      (WebKit::WebPageProxy::firstRectForCharacterRange): Added.
      (WebKit::WebPageProxy::interpretKeyEvent): Additional parameters.
      (WebKit::WebPageProxy::didSelectionChange): Additional parameters for Mac platform.
      * UIProcess/WebPageProxy.h: Added new methods and parameters to didSelectionChange
      and interpretKeyEvent.
      * UIProcess/WebPageProxy.messages.in: Added parameters to interpretKeyEvent and selectionChanged messages.
      * UIProcess/WebProcessProxy.h:
      (WebKit::WebProcessProxy::sendSync): Added support for synchronous messages.
      The default timeout is 1 second.
      * WebProcess/WebCoreSupport/WebEditorClient.cpp: respondToChangedSelection is now
      only for non Mac platform.
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      (WebKit::WebEditorClient::respondToChangedSelection): Added implementation for Mac platform.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didReceiveSyncMessage): Added.
      * WebProcess/WebPage/WebPage.h: Added new methods and support for synchronous messages.
      * WebProcess/WebPage/WebPage.messages.in: Added new messages.
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::interceptEditingKeyboardEvent): Added parameters.
      (WebKit::WebPage::convertRangeToPlatformRange): Added.
      (WebKit::WebPage::getMarkedRange): Added.
      (WebKit::characterRangeAtPoint): Added.
      (WebKit::WebPage::characterIndexForPoint): Added.
      (WebKit::convertToRange): Added.
      (WebKit::WebPage::firstRectForCharacterRange): Added.
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::didReceiveSyncMessage): Added.
      * WebProcess/WebProcess.h: Added didReceiveSyncMessage.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6768536
    • cmarrin@apple.com's avatar
      2010-12-10 Chris Marrin <cmarrin@apple.com> · 7bd7f39d
      cmarrin@apple.com authored
              Reviewed by Adam Roben.
      
              Add CACFContextGetLastCommitTime to WebKitSystemInterface for Windows.
              Also got rid of WebKitSystemInterface_debug.lib as recommended by
              Adam Roben. No OpenSource builds use it since r72327.
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
              * win/lib/WebKitSystemInterface_debug.lib: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bd7f39d
    • chang.shu@nokia.com's avatar
      2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> · eff3dea4
      chang.shu@nokia.com authored
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Added new signal to report ApplicationCache Database
              quota.
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
      
              Added new functions to accomodate new appcache layout
              test origin-quota.html.
      
              * Api/qwebsecurityorigin.cpp:
              (QWebSecurityOrigin::setApplicationCacheQuota):
              * Api/qwebsecurityorigin.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::clearAllApplicationCaches):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              * platform/qt/Skipped: Unskip now passing test origin-quota.html
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to work correctly under Qt.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to be successful under qt. Changes required because LayoutTestControllerQt
              does not inherit from LayoutController.
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::clearAllApplicationCaches):
              (LayoutTestController::setApplicationCacheOriginQuota):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
              (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eff3dea4
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · 0187ea8d
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Move buildbot.py into its own module so we can split it out into one-file-per-class
              https://bugs.webkit.org/show_bug.cgi?id=50806
      
              We're adding more buildbot logic these days, so it makes sense
              to give buildbot its own module.
      
              * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
              * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
              * Scripts/webkitpy/common/net/failuremap.py:
              * Scripts/webkitpy/common/net/regressionwindow.py:
              * Scripts/webkitpy/tool/commands/rebaseline.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0187ea8d
    • jberlin@webkit.org's avatar
      Windows build fix. Unreviewed. · 90c1b24c
      jberlin@webkit.org authored
      * WebCore.vcproj/WebCore.vcproj:
      Remove duplicate </File> tag.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90c1b24c
    • tony@chromium.org's avatar
      2010-12-10 Tony Chang <tony@chromium.org> · 8b1d738e
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              Use FileSystem::remove when cleaning up http lock files
              https://bugs.webkit.org/show_bug.cgi?id=50830
      
              * Scripts/webkitpy/layout_tests/port/http_lock.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b1d738e
    • commit-queue@webkit.org's avatar
      2010-12-09 Jenn Braithwaite <jennb@chromium.org> · b4be94a9
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              TextResourceDecoder::checkForHeadCharset can look way past the limit.
              https://bugs.webkit.org/show_bug.cgi?id=47397
      
              Replaced charset detection algorithm with real parser.
              Added tests for parser bugs mentioned in the thread for this bug report.
              Converted hixie's encoding parsing tests to a layout test.
      
              Tests: fast/encoding/bracket-in-script.html
                     fast/encoding/bracket-in-tag.html
                     fast/encoding/escaped-bracket.html
                     fast/encoding/meta-in-body.html
                     fast/encoding/meta-in-script.html
                     fast/encoding/meta-in-title.html
                     fast/encoding/mismatched-end-tag.html
                     fast/encoding/namespace-meta.html
                     fast/encoding/not-http-equiv-content.html
                     fast/encoding/parser-tests.html
                     fast/encoding/quotes-in-title.html
                     fast/encoding/tag-name-digit.html
                     http/tests/misc/charset-sniffer-end-sniffing.html
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * html/parser/HTMLMetaCharsetParser.cpp: Added.
              (WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
              (WebCore::HTMLMetaCharsetParser::~HTMLMetaCharsetParser):
              (WebCore::HTMLMetaCharsetParser::extractCharset):
              (WebCore::HTMLMetaCharsetParser::processMeta):
              (WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
              * html/parser/HTMLMetaCharsetParser.h: Added.
              (WebCore::HTMLMetaCharsetParser::create):
              (WebCore::HTMLMetaCharsetParser::encoding):
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::checkForHeadCharset):
              (WebCore::TextResourceDecoder::checkForMetaCharset):
              * loader/TextResourceDecoder.h:
      2010-12-09  Jenn Braithwaite  <jennb@chromium.org>
      
              Reviewed by Adam Barth.
      
              TextResourceDecoder::checkForHeadCharset can look way past the limit.
              https://bugs.webkit.org/show_bug.cgi?id=47397
      
              Replaced charset detection algorithm with real parser.
              Added tests for parser bugs mentioned in the thread for this bug report.
              Converted hixie's encoding parsing tests to a layout test.
              Added http-equiv attribute to meta tag in 2 existing tests.
      
              * fast/encoding/bracket-in-script-expected.txt: Added.
              * fast/encoding/bracket-in-script.html: Added.
              * fast/encoding/bracket-in-tag-expected.txt: Added.
              * fast/encoding/bracket-in-tag.html: Added.
              * fast/encoding/escaped-bracket-expected.txt: Added.
              * fast/encoding/escaped-bracket.html: Added.
              * fast/encoding/meta-in-body-expected.txt: Added.
              * fast/encoding/meta-in-body.html: Added.
              * fast/encoding/meta-in-script-expected.txt: Added.
              * fast/encoding/meta-in-script.html: Added.
              * fast/encoding/meta-in-title-expected.txt: Added.
              * fast/encoding/meta-in-title.html: Added.
              * fast/encoding/mismatched-end-tag-expected.txt: Added.
              * fast/encoding/mismatched-end-tag.html: Added.
              * fast/encoding/namespace-meta-expected.txt: Added.
              * fast/encoding/namespace-meta.html: Added.
              * fast/encoding/namespace-tolerance.html:
              * fast/encoding/not-http-equiv-content-expected.txt: Added.
              * fast/encoding/not-http-equiv-content.html: Added.
              * fast/encoding/parser-tests-expected.txt: Added.
              * fast/encoding/parser-tests.html: Added.
              * fast/encoding/quotes-in-title-expected.txt: Added.
              * fast/encoding/quotes-in-title.html: Added.
              * fast/encoding/resources/001.html: Added.
              * fast/encoding/resources/002.html: Added.
              * fast/encoding/resources/003.html: Added.
              * fast/encoding/resources/004.html: Added.
              * fast/encoding/resources/005.html: Added.
              * fast/encoding/resources/006.html: Added.
              * fast/encoding/resources/007.html: Added.
              * fast/encoding/resources/008.html: Added.
              * fast/encoding/resources/009.html: Added.
              * fast/encoding/resources/010.html: Added.
              * fast/encoding/resources/011.html: Added.
              * fast/encoding/resources/012.html: Added.
              * fast/encoding/resources/013.html: Added.
              * fast/encoding/resources/014.html: Added.
              * fast/encoding/resources/015.html: Added.
              * fast/encoding/resources/016.html: Added.
              * fast/encoding/resources/017.html: Added.
              * fast/encoding/resources/018.html: Added.
              * fast/encoding/resources/019.html: Added.
              * fast/encoding/resources/020.html: Added.
              * fast/encoding/resources/021.html: Added.
              * fast/encoding/resources/022.html: Added.
              * fast/encoding/resources/023.html: Added.
              * fast/encoding/resources/024.html: Added.
              * fast/encoding/resources/025.html: Added.
              * fast/encoding/resources/026.html: Added.
              * fast/encoding/resources/027.html: Added.
              * fast/encoding/resources/028.html: Added.
              * fast/encoding/resources/029.html: Added.
              * fast/encoding/resources/030.html: Added.
              * fast/encoding/resources/031.html: Added.
              * fast/encoding/resources/032.html: Added.
              * fast/encoding/resources/033.html: Added.
              * fast/encoding/resources/034.html: Added.
              * fast/encoding/resources/035.html: Added.
              * fast/encoding/resources/036.html: Added.
              * fast/encoding/resources/037.html: Added.
              * fast/encoding/resources/038.html: Added.
              * fast/encoding/resources/039.html: Added.
              * fast/encoding/resources/040.html: Added.
              * fast/encoding/resources/041.html: Added.
              * fast/encoding/resources/042.html: Added.
              * fast/encoding/resources/043.html: Added.
              * fast/encoding/resources/044.html: Added.
              * fast/encoding/resources/045.html: Added.
              * fast/encoding/resources/046.html: Added.
              * fast/encoding/resources/047.html: Added.
              * fast/encoding/resources/048.html: Added.
              * fast/encoding/resources/049.html: Added.
              * fast/encoding/resources/050.html: Added.
              * fast/encoding/resources/051.html: Added.
              * fast/encoding/resources/052.html: Added.
              * fast/encoding/resources/053.html: Added.
              * fast/encoding/resources/054.html: Added.
              * fast/encoding/resources/055.html: Added.
              * fast/encoding/resources/056.html: Added.
              * fast/encoding/resources/057.html: Added.
              * fast/encoding/resources/058.html: Added.
              * fast/encoding/resources/059.html: Added.
              * fast/encoding/resources/060.html: Added.
              * fast/encoding/resources/061.html: Added.
              * fast/encoding/resources/062.html: Added.
              * fast/encoding/resources/063.html: Added.
              * fast/encoding/resources/064.html: Added.
              * fast/encoding/resources/065.html: Added.
              * fast/encoding/resources/066.html: Added.
              * fast/encoding/resources/067.html: Added.
              * fast/encoding/resources/068.html: Added.
              * fast/encoding/resources/069.html: Added.
              * fast/encoding/resources/070.html: Added.
              * fast/encoding/resources/071.html: Added.
              * fast/encoding/resources/072.html: Added.
              * fast/encoding/resources/073.html: Added.
              * fast/encoding/resources/074.html: Added.
              * fast/encoding/resources/075.html: Added.
              * fast/encoding/resources/076.html: Added.
              * fast/encoding/resources/077.html: Added.
              * fast/encoding/resources/078.html: Added.
              * fast/encoding/resources/079.html: Added.
              * fast/encoding/resources/080.html: Added.
              * fast/encoding/resources/081.html: Added.
              * fast/encoding/resources/082.html: Added.
              * fast/encoding/resources/083.html: Added.
              * fast/encoding/resources/084.html: Added.
              * fast/encoding/resources/085.html: Added.
              * fast/encoding/resources/086.html: Added.
              * fast/encoding/resources/087.html: Added.
              * fast/encoding/resources/088.html: Added.
              * fast/encoding/resources/089.html: Added.
              * fast/encoding/resources/090.html: Added.
              * fast/encoding/resources/091.html: Added.
              * fast/encoding/resources/092.html: Added.
              * fast/encoding/resources/093.html: Added.
              * fast/encoding/resources/094.html: Added.
              * fast/encoding/resources/095.html: Added.
              * fast/encoding/resources/096.html: Added.
              * fast/encoding/resources/097.html: Added.
              * fast/encoding/resources/098.html: Added.
              * fast/encoding/resources/099.html: Added.
              * fast/encoding/resources/100.html: Added.
              * fast/encoding/resources/101.html: Added.
              * fast/encoding/resources/102.html: Added.
              * fast/encoding/resources/103.html: Added.
              * fast/encoding/resources/104.html: Added.
              * fast/encoding/resources/105.html: Added.
              * fast/encoding/resources/106.html: Added.
              * fast/encoding/resources/107.html: Added.
              * fast/encoding/resources/108.html: Added.
              * fast/encoding/resources/109.html: Added.
              * fast/encoding/resources/110.html: Added.
              * fast/encoding/resources/111.html: Added.
              * fast/encoding/resources/112.html: Added.
              * fast/encoding/resources/113.html: Added.
              * fast/encoding/resources/114.html: Added.
              * fast/encoding/resources/115.html: Added.
              * fast/encoding/resources/116.html: Added.
              * fast/encoding/resources/117.html: Added.
              * fast/encoding/resources/118.html: Added.
              * fast/encoding/resources/119.html: Added.
              * fast/encoding/resources/120.html: Added.
              * fast/encoding/resources/121.html: Added.
              * fast/encoding/resources/122.html: Added.
              * fast/encoding/resources/123.html: Added.
              * fast/encoding/tag-name-digit-expected.txt: Added.
              * fast/encoding/tag-name-digit.html: Added.
              * fast/text/international/bidi-innertext.html:
              * http/tests/misc/charset-sniffer-end-sniffing-expected.txt: Added.
              * http/tests/misc/charset-sniffer-end-sniffing.html: Added.
              * http/tests/misc/resources/charset-sniffer-end-sniffing.php: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4be94a9
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · a8969aab
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] DRT needs layoutTestController.setCacheModel
              https://bugs.webkit.org/show_bug.cgi?id=50705
      
              webkit_set_cache_mode() is called to set the cache model.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setCacheModel): Set the cache model.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8969aab
    • mihaip@chromium.org's avatar
      2010-12-10 Mihai Parparita <mihaip@chromium.org> · 78cc45eb
      mihaip@chromium.org authored
              Unreviewed Chromium test expectation update.
      
              Group Philip canvas test suite expectations better (by platform).
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78cc45eb
    • japhet@chromium.org's avatar
      2010-12-10 Nate Chapin <japhet@chromium.org> · f8d43691
      japhet@chromium.org authored
              Reviewed by Antti Koivisto.
      
              Merge Loader and Request. Currently, Loader is a singleton attached
              to MemoryCache. Our goal is to remove knowledge of the loading process
              from MemoryCache, so we should attach Loader to CachedResourceLoader instead.
              Once Loader is moved off of MemoryCache, there's no reason it needs to be a singleton,
              which removes the main reason for Request existing as a separate class (to store per-request
              state that Loader couldn't).
      
              Loader will be given a more descriptive name in a later patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=49837
      
              Refactor only, no new tests.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * loader/FrameLoader.cpp:
              * loader/Request.cpp:
              * loader/Request.h:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedResource.h:
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::CachedResourceLoader):
              (WebCore::CachedResourceLoader::~CachedResourceLoader):
              (WebCore::CachedResourceLoader::requestImage):
              (WebCore::CachedResourceLoader::setAutoLoadImages):
              (WebCore::CachedResourceLoader::load):
              (WebCore::CachedResourceLoader::loadDone): Was setLoadInProgress(false),
                  plus other CachedResourceLoader cleanup that had been handled in Loader.
              (WebCore::CachedResourceLoader::cancelRequests): Moved from Loader.
              (WebCore::CachedResourceLoader::requestCount):
              * loader/cache/CachedResourceLoader.h:
              (WebCore::CachedResourceLoader::loadFinishing): Was setLoadInProgress(true)
              * loader/cache/MemoryCache.h:
              * loader/loader.cpp:
              (WebCore::Loader::Loader):
              (WebCore::Loader::~Loader):
              (WebCore::Loader::load):
              (WebCore::Loader::willSendRequest):
              (WebCore::Loader::didFinishLoading):
              (WebCore::Loader::didFail):
              (WebCore::Loader::didReceiveResponse):
              (WebCore::Loader::didReceiveData):
              (WebCore::Loader::didReceiveCachedMetadata):
              * loader/loader.h:
              (WebCore::Loader::cachedResourceLoader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d43691
    • tony@chromium.org's avatar
      2010-12-10 Tony Chang <tony@chromium.org> · 044b6030
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] remove --use-drt and add --use-test-shell
              https://bugs.webkit.org/show_bug.cgi?id=50701
      
              Remove drt_expectations.txt since we don't need it anymore.
      
              * platform/chromium/drt_expectations.txt: Removed.
      2010-12-10  Tony Chang  <tony@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              [chromium] remove --use-drt and add --use-test-shell
              https://bugs.webkit.org/show_bug.cgi?id=50701
      
              * Scripts/webkitpy/common/config/ports.py:
              * Scripts/webkitpy/common/config/ports_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/style/checkers/test_expectations.py:
              * Scripts/webkitpy/tool/commands/queries.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      044b6030
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · 530062bd
      alex@webkit.org authored
              Unreviewed, rolling out r73743.
              http://trac.webkit.org/changeset/73743
      
              We need gtk+ specific results
      
              * http/tests/misc/dns-prefetch-control-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      530062bd
    • mrobinson@webkit.org's avatar
      2010-12-10 Martin Robinson <mrobinson@igalia.com> · 38d49040
      mrobinson@webkit.org authored
              Unreviewed, rolling out r73703.
              http://trac.webkit.org/changeset/73703
              https://bugs.webkit.org/show_bug.cgi?id=49658
      
              This patch is causing crashes on the GTK+ bots.
      
              * wtf/PlatformRefPtr.h:
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73703.
              http://trac.webkit.org/changeset/73703
              https://bugs.webkit.org/show_bug.cgi?id=49658
      
              This patch is causing crashes on the GTK+ bots.
      
              * platform/ContextMenuItem.h:
              (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
              * platform/gtk/ContextMenuGtk.cpp:
              (WebCore::ContextMenu::appendItem):
              * platform/gtk/ContextMenuItemGtk.cpp:
              (WebCore::ContextMenuItem::ContextMenuItem):
              (WebCore::ContextMenuItem::~ContextMenuItem):
              (WebCore::ContextMenuItem::createNativeMenuItem):
              (WebCore::ContextMenuItem::releasePlatformDescription):
              (WebCore::ContextMenuItem::type):
              (WebCore::ContextMenuItem::setType):
              (WebCore::ContextMenuItem::action):
              (WebCore::ContextMenuItem::setAction):
              (WebCore::ContextMenuItem::title):
              (WebCore::ContextMenuItem::setTitle):
              (WebCore::ContextMenuItem::platformSubMenu):
              (WebCore::ContextMenuItem::setSubMenu):
              (WebCore::ContextMenuItem::setChecked):
              (WebCore::ContextMenuItem::setEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38d49040
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 51d3357c
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * WebKit.gyp:
              * public/WebGeolocationClientMock.h: Added.
              (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
              (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
              * src/WebGeolocationClientMock.cpp: Added.
              (WebKit::WebGeolocationClientMock::create):
              (WebKit::WebGeolocationClientMock::initialize):
              (WebKit::WebGeolocationClientMock::reset):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
              (WebKit::WebGeolocationClientMock::setMockGeolocationError):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
              (WebKit::WebGeolocationClientMock::resetMock):
              (WebKit::WebGeolocationClientMock::startUpdating):
              (WebKit::WebGeolocationClientMock::stopUpdating):
              (WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
              (WebKit::WebGeolocationClientMock::geolocationDestroyed):
              (WebKit::WebGeolocationClientMock::setController):
              (WebKit::WebGeolocationClientMock::lastPosition):
              (WebKit::WebGeolocationClientMock::requestPermission):
              (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
              * src/WebGeolocationServiceMock.cpp:
      2010-12-10  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::geolocationClient):
              (WebViewHost::geolocationClientMock):
              (WebViewHost::reset):
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d3357c
    • mihaip@chromium.org's avatar
      2010-12-08 Mihai Parparita <mihaip@chromium.org> · 4a1481a0
      mihaip@chromium.org authored
              Reviewed by Darin Adler.
      
              fast/canvas/canvas-getImageData-negative-source.html fails on Mac
              https://bugs.webkit.org/show_bug.cgi?id=47901
      
              Add test for rounding behavior. Remove now-passing tests from
              test_expectations.txt.
      
              * fast/canvas/canvas-getImageData-rounding-expected.txt: Added.
              * fast/canvas/canvas-getImageData-rounding.html: Added.
              * platform/chromium/test_expectations.txt:
      2010-12-08  Mihai Parparita  <mihaip@chromium.org>
      
              Reviewed by Darin Adler.
      
              fast/canvas/canvas-getImageData-negative-source.html fails on Mac
              https://bugs.webkit.org/show_bug.cgi?id=47901
      
              Test: fast/canvas/canvas-getImageData-rounding.html
      
              static_cast<unsigned> is generally not what we want in
              convertLogicalToDevice. It produces inconsistent results when compiling
              for 32-bit vs. 64-bit, and in any case we weren't getting correct
              rounding behavior for source rectangles (e.g. we should get a source rect
              of width 2 if the source X is 0.9 and the source width is 0.2, but we
              were getting only one of width 1).
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::convertLogicalToDevice):
              (WebCore::HTMLCanvasElement::convertToValidDeviceSize):
              * html/HTMLCanvasElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a1481a0
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · c89d952a
      alex@webkit.org authored
              Unreviewed GTK test expectation update.
      
              * http/tests/misc/dns-prefetch-control-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c89d952a
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectation update. · d085de86
      pkasting@chromium.org authored
      * platform/chromium-gpu/test_expectations.txt:
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d085de86
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · 998a3df5
      alex@webkit.org authored
              Unreviewed, fixed small typo in the name of a function.
      
              * webkit/webkitwebsettings.cpp:
              (getAvailableDictionariesCallback):
              (webkit_web_settings_set_property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      998a3df5
    • alex@webkit.org's avatar
      2010-12-09 Alejandro G. Castro <alex@igalia.com> · 26df767f
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Added a new private API function to support the spelling marker
              tests in the DRT.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Implemented the hasSpellingMarker to support spelling tests.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::hasSpellingMarker):
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Unskipped spelling tests and added a bug for the one failing,
              added results for a new ones also.
      
              * platform/gtk/Skipped:
              * platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26df767f
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · 45662cb0
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Choose a dictionary in case there is no one defined or the
              env LANG does not propose one
              https://bugs.webkit.org/show_bug.cgi?id=50738
      
              In case no dict is set and we can not find one using the
              environment just get the first dictionary installed in the list.
      
              * webkit/webkitwebsettings.cpp:
              (getAvilableDictionariesCallback):
              (webkit_web_settings_set_property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45662cb0
    • commit-queue@webkit.org's avatar
      2010-12-10 Hironori Bono <hbono@chromium.org> · fbb324b3
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              [Chromium] Use libjpeg-turbo instead of libjpeg
              https://bugs.webkit.org/show_bug.cgi?id=50054
      
              This change replaces the hard-coded path to the GYP files of the JPEG
              library with a 'libjpeg_gyp_path' variable, which is added by Chromium
              r68453. (When building WebKit Chromium, this change sets its value to
              '<(chromium_src_dir)/third_party/libjpeg/libjpeg.gyp' to avoid changing
              the current behavior.)
      
              No new tests since this does not change the code at all.
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbb324b3
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · 1e6a1849
      commit-queue@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50808
      
              Unskipping the following test cases:
              userscripts/mixed-case-stylesheet.html
              userscripts/simple-stylesheet.html
              userscripts/user-style-all-frames.html
      
              * platform/gtk/Skipped:
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              Remove unnecessary variable names from DumpRenderTreeSupportGtk
              https://bugs.webkit.org/show_bug.cgi?id=50815
      
              There were some unnecessary variable names in DumpRenderTreeSupportGtk,
              so remove them.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
      2010-12-10  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              webkit-patch: not possible to use build-and-test with local commits
              https://bugs.webkit.org/show_bug.cgi?id=33378
      
              Make --no-clean not even check if we have local commits.
              It's unclear to me why the code was originally written this way.
              I was unable to dig up a reason from svn history.
      
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6a1849
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · 5ddfb643
      eric@webkit.org authored
              Reviewed by Ojan Vafai.
      
              webkit-patch: not possible to use build-and-test with local commits
              https://bugs.webkit.org/show_bug.cgi?id=33378
      
              Make --no-clean not even check if we have local commits.
              It's unclear to me why the code was originally written this way.
              I was unable to dig up a reason from svn history.
      
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ddfb643
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 8e07cd4f
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Unskip passing accessibility/aria-disabled.html test.
      
              * platform/gtk/Skipped: Unskip test.
      2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Implement AccessibilityUIElement::isEnabled() for GTK.
      
              * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
              (checkElementState): New function to refactor common code.
              (AccessibilityUIElement::isEnabled): Implement this by checking
              the current state of the AtkObject.
              (AccessibilityUIElement::isSelected): Use the new
              checkElementState function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e07cd4f
    • cmarrin@apple.com's avatar
      2010-12-10 Chris Marrin <cmarrin@apple.com> · 3aaada28
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
              https://bugs.webkit.org/show_bug.cgi?id=49388
      
              Got rid of the NonZeroBeginTimeFlag. Functionality is now hidden inside
              the implementation.
      
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::setAnimationOnLayer):
              * platform/graphics/ca/PlatformCAAnimation.h:
              * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
              (hasNonZeroBeginTimeFlag):
              (setNonZeroBeginTimeFlag):
              (PlatformCAAnimation::PlatformCAAnimation):
              (PlatformCAAnimation::setBeginTime):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aaada28
    • podivilov@chromium.org's avatar
      2010-12-10 Pavel Podivilov <podivilov@chromium.org> · 036cf88c
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor.
              https://bugs.webkit.org/show_bug.cgi?id=50679
      
              * inspector/front-end/Script.js:
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
              (WebInspector.SourceFrame.prototype._breakpointAdded):
              (WebInspector.SourceFrame.prototype._doEditLine):
              (WebInspector.SourceFrame.prototype._commitEditLine):
              (WebInspector.SourceFrame.prototype._breakpoints):
              (WebInspector.SourceFrame.prototype._sourceIDForLine):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      036cf88c
    • andreas.kling@nokia.com's avatar
      2010-12-10 Andreas Kling <kling@webkit.org> · 39078312
      andreas.kling@nokia.com authored
              Reviewed by Eric Seidel.
      
              Don't do GraphicsContext save/restore just to preserve the CompositeOperator
              https://bugs.webkit.org/show_bug.cgi?id=50070
      
              Add GraphicsContext::compositeOperation() so we don't have to do a full
              save/restore if the only context-tainting call is setCompositeOperation().
      
              GraphicsContext::setCompositeOperation() now stores the op in its state
              and calls a port-specific setPlatformCompositeOperation().
      
              No new tests, this is an optimization.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setCompositeOperation):
              (WebCore::GraphicsContext::compositeOperation):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/GraphicsContextPrivate.h:
              (WebCore::GraphicsContextState::GraphicsContextState):
              * platform/graphics/Image.cpp:
              (WebCore::Image::fillWithSolidColor):
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/haiku/GraphicsContextHaiku.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/mac/GraphicsContextMac.mm:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/skia/SkiaUtils.cpp:
              (WebCore::WebCoreCompositeToSkiaComposite):
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/wx/GraphicsContextWx.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::paintBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39078312
    • reni@webkit.org's avatar
      GraphicsContext: Merge m_common and m_data · a1db5cff
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49914
      
      Patch by Renata Hodovan <reni@webkit.org> on 2010-12-10
      Reviewed by Andreas Kling.
      
      Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
      and m_common became unnecessary. They are removed.
      Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
      make the constructor of GraphicsContext clearer.
      Besides add a getter to the private GraphicsContext::m_state member, because some inline
      functions in cairo need it.
      
      No new test is needed, because this is a refactoring.
      
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::~GraphicsContext):
      (WebCore::GraphicsContext::save):
      (WebCore::GraphicsContext::restore):
      (WebCore::GraphicsContext::setStrokeThickness):
      (WebCore::GraphicsContext::setStrokeStyle):
      (WebCore::GraphicsContext::setStrokeColor):
      (WebCore::GraphicsContext::setShadow):
      (WebCore::GraphicsContext::clearShadow):
      (WebCore::GraphicsContext::getShadow):
      (WebCore::GraphicsContext::strokeThickness):
      (WebCore::GraphicsContext::strokeStyle):
      (WebCore::GraphicsContext::strokeColor):
      (WebCore::GraphicsContext::strokeColorSpace):
      (WebCore::GraphicsContext::fillRule):
      (WebCore::GraphicsContext::setFillRule):
      (WebCore::GraphicsContext::setFillColor):
      (WebCore::GraphicsContext::fillColor):
      (WebCore::GraphicsContext::fillColorSpace):
      (WebCore::GraphicsContext::setShouldAntialias):
      (WebCore::GraphicsContext::shouldAntialias):
      (WebCore::GraphicsContext::state):
      (WebCore::GraphicsContext::setStrokePattern):
      (WebCore::GraphicsContext::setFillPattern):
      (WebCore::GraphicsContext::setStrokeGradient):
      (WebCore::GraphicsContext::setFillGradient):
      (WebCore::GraphicsContext::fillGradient):
      (WebCore::GraphicsContext::strokeGradient):
      (WebCore::GraphicsContext::fillPattern):
      (WebCore::GraphicsContext::strokePattern):
      (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
      (WebCore::GraphicsContext::updatingControlTints):
      (WebCore::GraphicsContext::setUpdatingControlTints):
      (WebCore::GraphicsContext::setPaintingDisabled):
      (WebCore::GraphicsContext::paintingDisabled):
      (WebCore::GraphicsContext::textDrawingMode):
      (WebCore::GraphicsContext::setTextDrawingMode):
      * platform/graphics/GraphicsContext.h:
      (WebCore::GraphicsContextState::GraphicsContextState):
      * platform/graphics/GraphicsContextPrivate.h: Removed.
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::setPlatformFill):
      (WebCore::setPlatformStroke):
      (WebCore::drawPathShadow):
      (WebCore::fillCurrentCairoPath):
      (WebCore::strokeCurrentCairoPath):
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      (WebCore::GraphicsContext::strokeRect):
      (WebCore::GraphicsContext::setAlpha):
      (WebCore::GraphicsContext::getAlpha):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::applyStrokePattern):
      (WebCore::GraphicsContext::applyFillPattern):
      (WebCore::GraphicsContext::drawPath):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      (WebCore::GraphicsContext::strokeRect):
      * platform/graphics/haiku/GraphicsContextHaiku.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::clip):
      (WebCore::GraphicsContext::clipOut):
      (WebCore::GraphicsContext::addInnerRoundedRectClip):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::setPlatformShadow):
      * platform/graphics/win/GraphicsContextCGWin.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::platformInit):
      * platform/graphics/win/GraphicsContextCairoWin.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::platformInit):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::fillRect):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1db5cff
    • mrobinson@webkit.org's avatar
      2010-12-10 Martin Robinson <mrobinson@igalia.com> · 6f4b5c9f
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Remove unnecessary variable names from DumpRenderTreeSupportGtk
              https://bugs.webkit.org/show_bug.cgi?id=50815
      
              There were some unnecessary variable names in DumpRenderTreeSupportGtk,
              so remove them.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f4b5c9f
    • podivilov@chromium.org's avatar
      2010-12-10 Pavel Podivilov <podivilov@chromium.org> · c6c51819
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: introduce a pair of set/remove methods for each breakpoint type.
              https://bugs.webkit.org/show_bug.cgi?id=50809
      
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setEventListenerBreakpoint):
              (WebCore::InspectorController::removeEventListenerBreakpoint):
              (WebCore::InspectorController::hasEventListenerBreakpoint):
              (WebCore::InspectorController::setXHRBreakpoint):
              (WebCore::InspectorController::removeXHRBreakpoint):
              (WebCore::InspectorController::hasXHRBreakpoint):
              (WebCore::InspectorController::clearNativeBreakpoints):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::setDOMBreakpoint):
              (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
              (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
              (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager):
              (WebInspector.NativeBreakpoint):
              (WebInspector.DOMBreakpoint):
              (WebInspector.EventListenerBreakpoint):
              (WebInspector.XHRBreakpoint):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane):
              (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.debuggerPaused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c51819
    • ossy@webkit.org's avatar
      Unreviewed. Remove platform specific expected files after r73720. · c19e900e
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c19e900e
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 38560d2b
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [chromium] Implement client based geolocation bindings
              https://bugs.webkit.org/show_bug.cgi?id=45752
      
              Implements the necessary plumbing to expose client-based geolocation in Chromium
              webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
              in the future.
      
              * WebKit.gyp:
              * public/WebGeolocationClient.h: Added.
              (WebKit::WebGeolocationClient::~WebGeolocationClient):
              * public/WebGeolocationController.h: Added.
              (WebKit::WebGeolocationController::WebGeolocationController):
              (WebKit::WebGeolocationController::reset):
              * public/WebGeolocationError.h:
              * public/WebGeolocationPermissionRequest.h: Added.
              (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest):
              (WebKit::WebGeolocationPermissionRequest::geolocation):
              * public/WebGeolocationPermissionRequestManager.h: Added.
              (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager):
              (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
              * public/WebGeolocationPosition.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::geolocationClient):
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
              (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
              * src/GeolocationClientProxy.cpp: Added.
              (WebKit::GeolocationClientProxy::GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::~GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::setController):
              (WebKit::GeolocationClientProxy::geolocationDestroyed):
              (WebKit::GeolocationClientProxy::startUpdating):
              (WebKit::GeolocationClientProxy::stopUpdating):
              (WebKit::GeolocationClientProxy::setEnableHighAccuracy):
              (WebKit::GeolocationClientProxy::lastPosition):
              (WebKit::GeolocationClientProxy::requestPermission):
              (WebKit::GeolocationClientProxy::cancelPermissionRequest):
              * src/GeolocationClientProxy.h: Added.
              * src/WebGeolocationController.cpp: Added.
              (WebKit::WebGeolocationController::positionChanged):
              (WebKit::WebGeolocationController::errorOccurred):
              (WebKit::WebGeolocationController::controller):
              * src/WebGeolocationPermissionRequest.cpp: Added.
              (WebKit::WebGeolocationPermissionRequest::securityOrigin):
              (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
              * src/WebGeolocationPermissionRequestManager.cpp: Added.
              (WebGeolocationPermissionRequestManager::add):
              (WebGeolocationPermissionRequestManager::remove):
              (WebGeolocationPermissionRequestManager::init):
              (WebGeolocationPermissionRequestManager::reset):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::WebViewImpl):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38560d2b
    • aroben@apple.com's avatar
      Windows production build fix after r72555 · a605c8fe
      aroben@apple.com authored
      * WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Use
      "$(WebKitVSPropsRedirectionDir)..\..\WebKitLibraries\win" to find the
      .vsprops files, rather than $(WebKitLibrariesDir).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a605c8fe
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Second attempt to fix the build with Qt 4.6 broken in 73710. · e825e022
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * platform/network/qt/QtNAMThreadSafeProxy.cpp:
      (WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
      (WebCore::QtNetworkReplyThreadSafeProxy::localCustomRequest):
      * platform/network/qt/QtNAMThreadSafeProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e825e022
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 7044b94e
      mario@webkit.org authored
              Unreviewed, unskip passing accessibility tests on GTK.
      
              * platform/gtk/Skipped: Unskip passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7044b94e
    • pfeldman@chromium.org's avatar
      2010-12-10 Pavel Feldman <pfeldman@chromium.org> · 9c0ba28c
      pfeldman@chromium.org authored
              Not reviewed. Get rid of spaces in ValidityState-patternMismatch test.
      
              * fast/forms/ValidityState-patternMismatch-expected.txt:
              * fast/forms/ValidityState-patternMismatch.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c0ba28c
    • ossy@webkit.org's avatar
      Unreviewed. Add platform specific expected files after r73715. · a7c49d2b
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7c49d2b
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix the build with Qt 4.6 broken in 73710. · 322a42e9
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * platform/network/qt/QtNAMThreadSafeProxy.cpp:
      (WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
      * platform/network/qt/QtNAMThreadSafeProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      322a42e9