1. 04 Jan, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-01-04 Zhe Su <suzhe@chromium.org> · 5f354cec
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
              2. Improve fast/events/ime-composition-events-001.html to cover more
                 cases. And fix test expectations of chromium port.
              https://bugs.webkit.org/show_bug.cgi?id=51693
      
              * fast/events/ime-composition-events-001-expected.txt:
              * fast/events/ime-composition-events-001.html:
              * platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
              * platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
              * platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.
      2011-01-04  Zhe Su  <suzhe@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Fix insertText, setMarkedText and unmarkText methods of
              TextInputController to call corresponding methods of WebKit::WebView
              rather than WebKit::WebFrame. This change matches the behavior of
              chromium browser.
              insertText corresponds to WebView::confirmComposition(text)
              setMarkedText corresponds to WebView::setComposition(...)
              unmarkText corresponds to WebView::confirmComposition()
              https://bugs.webkit.org/show_bug.cgi?id=51693
      
              * DumpRenderTree/chromium/TextInputController.cpp:
              (TextInputController::insertText):
              (TextInputController::setMarkedText):
              (TextInputController::unmarkText):
      2011-01-04  Zhe Su  <suzhe@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Changes:
              1. Add WebKit::WebWidget::confirmComposition(const WebString& text)
                 This new method corresponds to Editor::confirmComposition(text) and
                 Editor::insertText(text). It'll be used by both DumpRenderTree's
                 TextInputController and chromium browser.
              2. Fix WebFrameImpl::insertText
                 It should call Editor::confirmComposition(text) rather than
                 Editor::insertText(text) if there is an ongoing composition.
                 It matches the behavior of WebKit Mac port.
              3. Fix WebFrameImpl::setMarkedText
                 Editor::confirmComposition(text) shouldn't be called in this
                 method, which incorrectly inserts the text.
      
              https://bugs.webkit.org/show_bug.cgi?id=51693
      
              * public/WebWidget.h:
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::insertText):
              (WebKit::WebFrameImpl::setMarkedText):
              * src/WebPopupMenuImpl.cpp:
              (WebKit::WebPopupMenuImpl::confirmComposition):
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::confirmComposition):
              * src/WebViewImpl.h:
              * tests/PopupMenuTest.cpp:
              (WebKit::TestWebWidget::confirmComposition):
      2011-01-04  Zhe Su  <suzhe@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Fix test LayoutTests/fast/events/ime-composition-events-001.html.
      
              https://bugs.webkit.org/show_bug.cgi?id=51693
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to
              insert the commit string when no composition text is available.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f354cec
  2. 10 Sep, 2010 1 commit
    • darin@chromium.org's avatar
      2010-09-10 Nat Duca <nduca@chromium.org> · d89cb2ee
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Accelerated Compositing: screen garbage when scrolling
              https://bugs.webkit.org/show_bug.cgi?id=45092
      
              Split LayerRenderChromium::drawLayers into several different
              functions, responsible for preparing the backbuffer, updating the
              root texture, compositing and performing the final
              swapbuffers. This are then used by the new
              WebViewImpl::composite rendering path.
      
              * platform/graphics/chromium/LayerChromium.cpp:
              (WebCore::LayerChromium::setBounds):
              (WebCore::LayerChromium::setFrame):
              (WebCore::LayerChromium::setNeedsDisplay):
              (WebCore::LayerChromium::resetNeedsDisplay):
              * platform/graphics/chromium/LayerChromium.h:
              (WebCore::LayerChromium::dirtyRect):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::prepareToDrawLayers):
              (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
              (WebCore::LayerRendererChromium::drawLayers):
              (WebCore::LayerRendererChromium::present):
              * platform/graphics/chromium/LayerRendererChromium.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d89cb2ee
  3. 28 Jun, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-06-28 Zhe Su <suzhe@chromium.org> · d626a026
      commit-queue@webkit.org authored
              Reviewed by Jian Li.
      
              [chromium]Remove deprecated code related to input method.
              https://bugs.webkit.org/show_bug.cgi?id=41244
      
              Also update TestWebWidget in tests/PopupMenuTest.cpp to add missing implementations.
      
              * WebKit.gyp:
              * public/WebCompositionCommand.h: Removed.
              * public/WebViewClient.h:
              * public/WebWidget.h:
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::setInputMethodState):
              * src/WebPopupMenuImpl.cpp:
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              * src/WebViewImpl.h:
              * tests/PopupMenuTest.cpp:
              (WebKit::TestWebWidget::setComposition):
              (WebKit::TestWebWidget::confirmComposition):
              (WebKit::TestWebWidget::textInputType):
              (WebKit::TestWebWidget::caretOrSelectionBounds):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d626a026
  4. 19 Jun, 2010 1 commit
    • eric@webkit.org's avatar
      2010-06-19 Zhe Su <suzhe@chromium.org> · 079bebf2
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium]Refactor input method related APIs.
              https://bugs.webkit.org/show_bug.cgi?id=40608
      
              No new tests are needed, because there is no new functionality.
      
              * page/FocusController.cpp:
              (WebCore::FocusController::setFocusedNode):
      2010-06-19  Zhe Su  <suzhe@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [chromium]Refactor input method related APIs.
              https://bugs.webkit.org/show_bug.cgi?id=40608
      
              * WebKit.gyp:
              * public/WebCompositionCommand.h:
              * public/WebCompositionUnderline.h: Added.
              (WebKit::WebCompositionUnderline::WebCompositionUnderline):
              * public/WebTextInputType.h: Added.
              (WebKit::):
              * public/WebViewClient.h:
              * public/WebWidget.h:
              * public/WebWidgetClient.h:
              (WebKit::WebWidgetClient::resetInputMethod):
              * src/CompositionUnderlineBuilder.h: Added.
              (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
              * src/CompositionUnderlineVectorBuilder.cpp: Added.
              (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
              * src/CompositionUnderlineVectorBuilder.h: Added.
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::setInputMethodState):
              * src/WebPopupMenuImpl.cpp:
              (WebKit::WebPopupMenuImpl::setComposition):
              (WebKit::WebPopupMenuImpl::confirmComposition):
              (WebKit::WebPopupMenuImpl::textInputType):
              (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::handleCompositionEvent):
              (WebKit::WebViewImpl::setComposition):
              (WebKit::WebViewImpl::confirmComposition):
              (WebKit::WebViewImpl::textInputType):
              (WebKit::WebViewImpl::caretOrSelectionBounds):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079bebf2
  5. 04 May, 2010 1 commit
    • eric@webkit.org's avatar
      2010-05-04 Vangelis Kokkevis <vangelis@chromium.org> · a2ccb1f3
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
              Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
              https://bugs.webkit.org/show_bug.cgi?id=38220
      
              * public/WebWidget.h:
              * src/WebPopupMenuImpl.h:
              (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::WebViewImpl):
              (WebKit::WebViewImpl::paint):
              (WebKit::WebViewImpl::isAcceleratedCompositingActive):
              (WebKit::WebViewImpl::setRootGraphicsLayer):
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
              (WebKit::WebViewImpl::updateRootLayerContents):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2ccb1f3
  6. 09 Nov, 2009 1 commit
    • eric@webkit.org's avatar
      2009-11-09 Yaar Schnitman <yaar@chromium.org> · 7c6268b9
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Upstreaming the Chromium WebKit API: WebVector to WebWorkerClient
      
              https://bugs.webkit.org/show_bug.cgi?id=28394
      
              * public/WebVector.h: Added.
              (WebKit::WebVector::~WebVector):
              (WebKit::WebVector::WebVector):
              (WebKit::WebVector::operator=):
              (WebKit::WebVector::assign):
              (WebKit::WebVector::size):
              (WebKit::WebVector::isEmpty):
              (WebKit::WebVector::operator[]):
              (WebKit::WebVector::data):
              (WebKit::WebVector::swap):
              (WebKit::WebVector::initialize):
              (WebKit::WebVector::initializeFrom):
              (WebKit::WebVector::destroy):
              * public/WebView.h: Added.
              (WebKit::WebView::~WebView):
              * public/WebViewClient.h: Added.
              (WebKit::WebViewClient::createView):
              (WebKit::WebViewClient::createPopupMenu):
              (WebKit::WebViewClient::didAddMessageToConsole):
              (WebKit::WebViewClient::printPage):
              (WebKit::WebViewClient::notificationPresenter):
              (WebKit::WebViewClient::didStartLoading):
              (WebKit::WebViewClient::didStopLoading):
              (WebKit::WebViewClient::shouldBeginEditing):
              (WebKit::WebViewClient::shouldEndEditing):
              (WebKit::WebViewClient::shouldInsertNode):
              (WebKit::WebViewClient::shouldInsertText):
              (WebKit::WebViewClient::shouldChangeSelectedRange):
              (WebKit::WebViewClient::shouldDeleteRange):
              (WebKit::WebViewClient::shouldApplyStyle):
              (WebKit::WebViewClient::isSmartInsertDeleteEnabled):
              (WebKit::WebViewClient::isSelectTrailingWhitespaceEnabled):
              (WebKit::WebViewClient::setInputMethodEnabled):
              (WebKit::WebViewClient::didBeginEditing):
              (WebKit::WebViewClient::didChangeSelection):
              (WebKit::WebViewClient::didChangeContents):
              (WebKit::WebViewClient::didExecuteCommand):
              (WebKit::WebViewClient::didEndEditing):
              (WebKit::WebViewClient::handleCurrentKeyboardEvent):
              (WebKit::WebViewClient::spellCheck):
              (WebKit::WebViewClient::autoCorrectWord):
              (WebKit::WebViewClient::showSpellingUI):
              (WebKit::WebViewClient::isShowingSpellingUI):
              (WebKit::WebViewClient::updateSpellingUIWithMisspelledWord):
              (WebKit::WebViewClient::runFileChooser):
              (WebKit::WebViewClient::runModalAlertDialog):
              (WebKit::WebViewClient::runModalConfirmDialog):
              (WebKit::WebViewClient::runModalPromptDialog):
              (WebKit::WebViewClient::runModalBeforeUnloadDialog):
              (WebKit::WebViewClient::setStatusText):
              (WebKit::WebViewClient::setMouseOverURL):
              (WebKit::WebViewClient::setKeyboardFocusURL):
              (WebKit::WebViewClient::setToolTipText):
              (WebKit::WebViewClient::showContextMenu):
              (WebKit::WebViewClient::startDragging):
              (WebKit::WebViewClient::acceptsLoadDrops):
              (WebKit::WebViewClient::focusNext):
              (WebKit::WebViewClient::focusPrevious):
              (WebKit::WebViewClient::navigateBackForwardSoon):
              (WebKit::WebViewClient::historyBackListCount):
              (WebKit::WebViewClient::historyForwardListCount):
              (WebKit::WebViewClient::didAddHistoryItem):
              (WebKit::WebViewClient::focusAccessibilityObject):
              (WebKit::WebViewClient::didUpdateInspectorSettings):
              (WebKit::WebViewClient::queryAutofillSuggestions):
              (WebKit::WebViewClient::removeAutofillSuggestions):
              (WebKit::WebViewClient::~WebViewClient):
              * public/WebWidget.h: Added.
              (WebKit::WebWidget::~WebWidget):
              * public/WebWidgetClient.h: Added.
              (WebKit::WebWidgetClient::didInvalidateRect):
              (WebKit::WebWidgetClient::didScrollRect):
              (WebKit::WebWidgetClient::didFocus):
              (WebKit::WebWidgetClient::didBlur):
              (WebKit::WebWidgetClient::didChangeCursor):
              (WebKit::WebWidgetClient::closeWidgetSoon):
              (WebKit::WebWidgetClient::show):
              (WebKit::WebWidgetClient::runModal):
              (WebKit::WebWidgetClient::windowRect):
              (WebKit::WebWidgetClient::setWindowRect):
              (WebKit::WebWidgetClient::windowResizerRect):
              (WebKit::WebWidgetClient::rootWindowRect):
              (WebKit::WebWidgetClient::screenInfo):
              (WebKit::WebWidgetClient::~WebWidgetClient):
              * public/WebWorker.h: Added.
              (WebKit::WebWorker::~WebWorker):
              * public/WebWorkerClient.h: Added.
              (WebKit::WebWorkerClient::~WebWorkerClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6268b9