1. 06 Jan, 2011 26 commits
  2. 05 Jan, 2011 14 commits
    • sfalken@apple.com's avatar
      Windows build fix. · 1c577514
      sfalken@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c577514
    • commit-queue@webkit.org's avatar
      2011-01-05 Xianzhu Wang <wangxianzhu@google.com> · c9e7da71
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
              https://bugs.webkit.org/show_bug.cgi?id=51736
      
              No new tests. This change has potential effect on @font-face CSS feature
              on ports using Skia. Tested on Chromium that this change won't break
              fast/css/font-face-remote.html. This change can make the test pass on
              other ports using Skia.
      
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::RemoteFontStream::read):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9e7da71
    • commit-queue@webkit.org's avatar
      2011-01-05 Helder Correia <helder@sencha.com> · 13b196e5
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
              https://bugs.webkit.org/show_bug.cgi?id=51869
      
              GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
              The shadow is being drawn, but getting clipped to the rect being filled.
              The solution is to draw the gradient into a CGLayer (when a shadow is
              required), then render the layer to the GraphicsContext.
      
              This patch also fixes:
              canvas/philip/tests/2d.shadow.gradient.alpha.html
              canvas/philip/tests/2d.shadow.gradient.basic.html
              canvas/philip/tests/2d.shadow.gradient.transparent.2.html
      
              New test to ensure that shadows are drawn when fillStyle is a gradient,
              possibly with some transparency and blur, and specifically using
              fillRect.
      
              * fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.
      2011-01-05  Helder Correia  <helder@sencha.com>
      
              Reviewed by Simon Fraser.
      
              Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
              https://bugs.webkit.org/show_bug.cgi?id=51869
      
              GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
              The shadow is being drawn, but getting clipped to the rect being filled.
              The solution is to draw the gradient into a CGLayer (when a shadow is
              required), then render the layer to the GraphicsContext.
      
              This patch also fixes:
              canvas/philip/tests/2d.shadow.gradient.alpha.html
              canvas/philip/tests/2d.shadow.gradient.basic.html
              canvas/philip/tests/2d.shadow.gradient.transparent.2.html
      
              Test: fast/canvas/canvas-fillRect-gradient-shadow.html
      
              * platform/graphics/Gradient.h:
              * platform/graphics/cg/GradientCG.cpp:
              (WebCore::Gradient::paint):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b196e5
    • sfalken@apple.com's avatar
      2011-01-05 Steve Falkenburg <sfalken@apple.com> · 3bc314c4
      sfalken@apple.com authored
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * win/tools/vsprops/common.vsprops: 
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * WebKit.vcproj/InterfacesCommon.vsprops:
              * WebKit.vcproj/InterfacesPostBuild.cmd:
              * WebKit.vcproj/InterfacesPreBuild.cmd:
              * WebKit.vcproj/WebKit.make:
              * WebKit.vcproj/WebKitGUID.vcproj:
              * WebKit.vcproj/WebKitGUIDCommon.vsprops:
              * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
              * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
              * WebKit.vcproj/WebKitLibCommon.vsprops:
              * WebKit.vcproj/WebKitLibPostBuild.cmd:
              * WebKit.vcproj/WebKitLibPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * WebCore.vcproj/QTMovieWinCommon.vsprops:
              * WebCore.vcproj/QTMovieWinPostBuild.cmd:
              * WebCore.vcproj/QTMovieWinPreBuild.cmd:
              * WebCore.vcproj/WebCore.make:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/WebCoreCommon.vsprops:
              * WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
              * WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
              * WebCore.vcproj/WebCoreMediaQT.vsprops:
              * WebCore.vcproj/WebCorePostBuild.cmd:
              * WebCore.vcproj/WebCorePreBuild.cmd:
              * WebCore.vcproj/copyForwardingHeaders.cmd:
              * WebCore.vcproj/copyInspectorFiles.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
              
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
              
              For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
              for proper operation of the instrumentation/optimization scripts.
      
              * JavaScriptCore.vcproj/JavaScriptCore.make:
              * JavaScriptCore.vcproj/JavaScriptCore.sln:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePGOOptimize.vsprops: Added.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
              * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
              * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
              * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
              * JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
              * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
              * JavaScriptCore.vcproj/jsc/jsc.vcproj:
              * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
              * JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
              * JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
              * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
              * JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
              * JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
              * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
              * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
              * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
              * DumpRenderTree/win/ImageDiffCommon.vsprops:
              * DumpRenderTree/win/ImageDiffPostBuild.cmd:
              * DumpRenderTree/win/ImageDiffPreBuild.cmd:
              * FindSafari/FindSafari.vcproj:
              * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
              * MiniBrowser/MiniBrowserPostBuild.cmd:
              * MiniBrowser/MiniBrowserPreBuild.cmd:
              * Scripts/webkitdirs.pm:
              * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
              * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
              * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
              * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
              * TestWebKitAPI/win/copy-resources.cmd:
              * WebKitAPITest/WebKitAPITestCommon.vsprops:
              * WebKitAPITest/WebKitAPITestPostBuild.cmd:
              * WebKitAPITest/WebKitAPITestPreBuild.cmd:
              * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
              * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
              * WebKitTestRunner/win/InjectedBundle.vcproj:
              * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
              * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
              * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
              * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
              * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
              * WinLauncher/WinLauncherCommon.vsprops:
              * WinLauncher/WinLauncherPostBuild.cmd:
              * WinLauncher/WinLauncherPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * win/WebKit2.make:
              * win/WebKit2.vcproj:
              * win/WebKit2Common.vsprops:
              * win/WebKit2Generated.make:
              * win/WebKit2GeneratedCommon.vsprops:
              * win/WebKit2WebProcessPostBuild.cmd:
              * win/WebKit2WebProcessPreBuild.cmd:
              * win/WebKitPostBuild.cmd:
              * win/WebKitPreBuild.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc314c4
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · 1f3fb4c5
      simon.fraser@apple.com authored
              Reviewed by Ariya Hidayat.
      
              Directly composited SVG images fail to render
              https://bugs.webkit.org/show_bug.cgi?id=51975
      
              There was already code, added in r67900, to detect whether an image
              may be directly composited, by checking to see if it's a bitmap image.
      
              However, CachedImage::image() returns the nullImage() if m_image is null,
              which is a BitmapImage, confusing this test.
      
              Test: compositing/images/direct-svg-image.html
      
              * loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
              exactly the same method.
              (WebCore::CachedImage::image): Use Image::nullImage().
              * loader/cache/CachedImage.h:
              (WebCore::CachedImage::hasImage): New method to ask whether the m_image is
              non-null.
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
              so that we don't test the nullImage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f3fb4c5
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · b81b821c
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              Fix percentage values in radius of radial gradients
              https://bugs.webkit.org/show_bug.cgi?id=51979
      
              Handle percentage values for the ending size of radial gradients.
      
              Test: fast/gradients/css3-radial-gradients3.html
      
              * css/CSSGradientValue.cpp:
              (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
              non-null if percentage values are allowed, and compute percentage values when we see them.
              (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
              percentages are OK when resolving end radii.
              * css/CSSGradientValue.h: New parameter for resolveRadius.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b81b821c
    • ap@apple.com's avatar
      2011-01-05 Alexey Proskuryakov <ap@apple.com> · b9997acd
      ap@apple.com authored
              Reviewed by Anders Carlsson.
      
              https://bugs.webkit.org/show_bug.cgi?id=51973
              Make main frame PDF printing work
      
              * UIProcess/API/mac/PDFViewController.h:
              * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation):
              Ask PDFDocument to create an NSPrintOperation.
      
              * UIProcess/API/mac/WKView.h:
              * UIProcess/API/mac/WKView.mm:
              (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either
              from scratch or from a PDF view.
              (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers
              and footers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9997acd
    • commit-queue@webkit.org's avatar
      2011-01-05 Jan Erik Hanssen <jhanssen@sencha.com> · ca748a37
      commit-queue@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] TestNetscapePlugin doesn't link on OS X
              https://bugs.webkit.org/show_bug.cgi?id=51948
      
              Only add a dependency on libX11 on X11 systems
      
              * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca748a37
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · d1b4d8a2
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              change the way we do comment highlighting in the code review tool
              https://bugs.webkit.org/show_bug.cgi?id=51971
      
              Store a space-separated list of base line IDs on each line that has
              comments associated with that line. This allows for overlapping comments,
              but more importantly, makes adding side-by-side diff support easier.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b4d8a2
    • commit-queue@webkit.org's avatar
      2011-01-05 Jeff Miller <jeffm@apple.com> · 6601cf39
      commit-queue@webkit.org authored
              Reviewed by Adam Roben.
      
              check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
              https://bugs.webkit.org/show_bug.cgi?id=51970
      
              * Scripts/webkitpy/style/checker.py:
              Add -readability/naming for WebKit2 C API directories.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6601cf39
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · 10618cf8
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              minor code cleanup for code review tool
              https://bugs.webkit.org/show_bug.cgi?id=51962
      
              Consolidates some queries to using shared functions.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10618cf8
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · 5f240620
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              assorted cleanups to prepare for side-by-side diffing
              https://bugs.webkit.org/show_bug.cgi?id=51961
      
              Mostly, use selector queries instead of assuming comments are next siblings.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f240620
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · 92bc9b02
      simonjam@chromium.org authored
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately.
              (checkTimingWhileDeferred): Ditto.
              (checkWebTimingOnDOMContentLoaded): Ditto.
              (checkWebTimingWhileAsync): Ditto.
              (checkWebTimingOnLoad): Ditto.
              (checkWebTimingAfterLoad): Ditto.
              * fast/dom/webtiming-expected.txt:
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
              * http/tests/misc/resources/webtiming-no-origin.html: Added.
              * http/tests/misc/webtiming-origins-expected.txt: Added.
              * http/tests/misc/webtiming-origins.html: Added.
              * platform/gtk/Skipped: Skip new web timing test.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      2011-01-05  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              Tests: http/tests/misc/webtiming-cross-origin-redirect.php
                     http/tests/misc/webtiming-origins.html
      
              * loader/DocumentLoadTiming.h:
              (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::~FrameLoader):
              (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
              (WebCore::FrameLoader::completed):
              (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
              (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
              * page/PerformanceNavigation.cpp:
              (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::redirectStart): Ditto.
              (WebCore::PerformanceTiming::redirectEnd): Ditto.
              (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
              (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bc9b02
    • andersca@apple.com's avatar
      <rdar://problem/8750248> · f33fd63b
      andersca@apple.com authored
      Need a way to create a new DownloadProxy from an arbitrary resource request
      
      Reviewed by Sam Weinig.
      
      <rdar://problem/8750465>
      Need a way to start a download in WKDownload
              
      <rdar://problem/8752204>
      WK2 Context Menus - "Save linked file" support
      
      * Shared/ContextMenuState.h: Added.
      Add a ContextMenuState struct which contains state for context menus.
      
      * UIProcess/API/C/WKContext.cpp:
      (WKContextDownloadURLRequest):
      Call WebContext::download.
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::download):
      Send a DownloadRequest message to the web process.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showContextMenu):
      Set the active context menu state.
      
      (WebKit::WebPageProxy::contextMenuItemSelected):
      Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
      WebContext::Download, passing the respective URLs.
      
      * UIProcess/WebPageProxy.messages.in:
      ShowContextMenu now takes state as well.
      
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::downloadURL):
      Assert that this is never reached; downloads are handled in the UI process.
      
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::show):
      Pass the context menu state along when sending the ShowContextMenu message.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      Call the shared DownloadManager.
      
      * WebProcess/WebProcess.messages.in:
      Add DownloadRequest message.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      Add ContextMenuState.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f33fd63b