1. 14 Jan, 2013 30 commits
    • tommyw@google.com's avatar
      MediaStream API: Update MediaStreamTrack::readyState to match specification · c7f0bd90
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106781
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.
      
      Existing tests expanded to cover patch.
      
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::processTrack):
      * Modules/mediastream/MediaStreamTrack.cpp:
      (WebCore::MediaStreamTrack::readyState):
      (WebCore::MediaStreamTrack::ended):
      (WebCore):
      * Modules/mediastream/MediaStreamTrack.h:
      (MediaStreamTrack):
      * Modules/mediastream/MediaStreamTrack.idl:
      
      LayoutTests:
      
      * fast/mediastream/MediaStreamTrack-expected.txt:
      * fast/mediastream/MediaStreamTrack.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7f0bd90
    • commit-queue@webkit.org's avatar
      Web Inspector: add text editor formatter test · 62428106
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106705
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-14
      Reviewed by Pavel Feldman.
      
      Adds a test checking text editor formatting.
      The test creates a new text editor and fills it in with some
      code by the means of simulated key and textInput events.
      
      * inspector/editor/text-editor-formatter-expected.txt: Added.
      * inspector/editor/text-editor-formatter.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62428106
    • vsevik@chromium.org's avatar
      Web Inspector: Audit Tool's False Positive on Set-Cookie header · c2e5a9f3
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106794
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Header value is now returned as undefined if there is no such header as it was before regression.
      
      Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
      
      * inspector/front-end/AuditRules.js:
      (WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
      * inspector/front-end/NetworkRequest.js:
      (WebInspector.NetworkRequest.prototype._headerValue):
      
      LayoutTests:
      
      * http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
      * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
      * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2e5a9f3
    • eric.carlson@apple.com's avatar
      Do not pass nil when initializing legible output · c0733956
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106799
      
      Reviewed by Jessie Berlin.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]
          wants an empty NSArray rather than nil.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0733956
    • aandrey@chromium.org's avatar
      Web Inspector: [Canvas] UI: add control buttons for doing the replay steps · 62a35f13
      aandrey@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106788
      
      Reviewed by Pavel Feldman.
      
      Adding UI control buttons for doing the Canvas replay steps.
      Drive-by: fixed a bug in DataGrid (found by the JSCompiler).
      
      * inspector/front-end/CanvasProfileView.js:
      (WebInspector.CanvasProfileView):
      (WebInspector.CanvasProfileView.prototype._createControlButton):
      (WebInspector.CanvasProfileView.prototype._onReplayStepClick):
      (WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
      (WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
      (WebInspector.CanvasProfileView.prototype._enableWaitIcon):
      (WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
      (WebInspector.CanvasProfileView.prototype._replayTraceLog):
      (WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
      (WebInspector.CanvasProfileType.prototype._updateDecorationElement):
      * inspector/front-end/DOMExtension.js:
      (Element.prototype.enableStyleClass):
      * inspector/front-end/DataGrid.js:
      (WebInspector.DataGrid.prototype.setRootNode):
      (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
      (WebInspector.DataGrid.prototype.moveToNextIfNeeded):
      (WebInspector.DataGrid.prototype._editingCommitted):
      (WebInspector.DataGridNode):
      * inspector/front-end/canvasProfiler.css:
      (.canvas-replay-image):
      (.canvas-replay-image.wait):
      (.canvas-replay-controls):
      (.canvas-replay-log):
      (.canvas-control-button):
      (.canvas-control-button:active):
      (.canvas-control-button:disabled):
      (.canvas-control-button img):
      (.canvas-replay-first-step img):
      (.canvas-replay-next-step img):
      (.canvas-replay-prev-step img):
      (.canvas-replay-last-step img):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62a35f13
    • commit-queue@webkit.org's avatar
      Web Inspector: devtools front-end doesn't have focus in TestShell · 477ab2c1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106778
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-14
      Reviewed by Pavel Feldman.
      
      Focus devTools window after loadURL method.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::runFileTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477ab2c1
    • commit-queue@webkit.org's avatar
      [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script · fee34546
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106573
      
      Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-01-14
      Reviewed by Philippe Normand.
      
      Similarly to what's been described in bug 106569, we're building
      from release tarballs, so there's no reason to regenerate the
      autoconf-related stuff with autogen.sh, especially since we might
      run into trouble with automake 1.13 and deprecated macros.
      
      * efl/jhbuild.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fee34546
    • tommyw@google.com's avatar
      MediaStream API: Update the track accessors on MediaStream to match the latest specification · fd01ce17
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106660
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      The spec has significantly changed how tracks are accessed from a MediaStream:
      http://dev.w3.org/2011/webrtc/editor/getusermedia.html
      
      In short: the attributes audioTrack/videoTrack that returned special MediaStreamTrackLists have been
      replaced by the functions getAudioTracks()/getVideoTracks that return standard sequences of
      MediaStreamTracks.
      
      Existing tests updated and expanded to cover patch.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::MediaStream::create):
      (WebCore::MediaStream::MediaStream):
      (WebCore::MediaStream::~MediaStream):
      (WebCore::MediaStream::readyState):
      (WebCore):
      (WebCore::MediaStream::addTrack):
      (WebCore::MediaStream::removeTrack):
      (WebCore::MediaStream::getTrackById):
      (WebCore::MediaStream::streamEnded):
      (WebCore::MediaStream::contextDestroyed):
      (WebCore::MediaStream::scheduleDispatchEvent):
      (WebCore::MediaStream::scheduledEventTimerFired):
      * Modules/mediastream/MediaStream.h:
      (MediaStream):
      (WebCore::MediaStream::getAudioTracks):
      (WebCore::MediaStream::getVideoTracks):
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrackList.cpp: Removed.
      * Modules/mediastream/MediaStreamTrackList.h: Removed.
      * Modules/mediastream/MediaStreamTrackList.idl: Removed.
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::createMediaStreamSource):
      * WebCore.gypi:
      * dom/EventTargetFactory.in:
      * platform/mediastream/MediaStreamDescriptor.h:
      (WebCore::MediaStreamDescriptor::addAudioComponent):
      (WebCore::MediaStreamDescriptor::removeAudioComponent):
      (WebCore::MediaStreamDescriptor::addVideoComponent):
      (WebCore::MediaStreamDescriptor::removeVideoComponent):
      
      LayoutTests:
      
      Updating and expanding tests for the new getAudioTracks()/getVideoTracks().
      
      * fast/mediastream/MediaStreamConstructor-expected.txt:
      * fast/mediastream/MediaStreamConstructor.html:
      * fast/mediastream/MediaStreamTrack.html:
      * fast/mediastream/MediaStreamTrackList-expected.txt:
      * fast/mediastream/MediaStreamTrackList.html:
      * fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
      * fast/mediastream/RTCPeerConnection-statsSelector.html:
      * fast/mediastream/getusermedia-expected.txt:
      * fast/mediastream/getusermedia.html:
      * webaudio/mediastreamaudiosourcenode-expected.txt:
      * webaudio/mediastreamaudiosourcenode.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd01ce17
    • haraken@chromium.org's avatar
      [V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell · 3f070ca6
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106771
      
      Reviewed by Adam Barth.
      
      This is one of the steps to pass an Isolate everywhere.
      
      No tests. No change in behavior.
      
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::ScriptController):
      (WebCore::ScriptController::windowShell):
      * bindings/v8/ScriptController.h:
      (ScriptController):
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::create):
      (WebCore::V8DOMWindowShell::V8DOMWindowShell):
      (WebCore::V8DOMWindowShell::initializeIfNeeded):
      (WebCore::V8DOMWindowShell::installDOMWindow):
      * bindings/v8/V8DOMWindowShell.h:
      (V8DOMWindowShell):
      * bindings/v8/V8Initializer.cpp:
      (WebCore::V8Initializer::initializeMainThreadIfNeeded):
      (WebCore::V8Initializer::initializeWorker):
      * bindings/v8/V8Initializer.h:
      (V8Initializer):
      * bindings/v8/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::WorkerScriptController):
      (WebCore::WorkerScriptController::initializeContextIfNeeded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f070ca6
    • jocelyn.turcotte@digia.com's avatar
      [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg · 8e7e3c0e
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104909
      
      Reviewed by Simon Hausmann.
      
      To be able to build redistribuable binary packages, Qt's configure switches
      -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
      dynamically link to optional system libraries.
      QtWebKit is doing its own configure checks for those libraries, thus adding a
      runtime dependency that might not be fulfilled if the packager's machine had
      those libraries while the user's machine won't.
      
      Since in most cases where WebKit will want to use those system libraries, Qt will
      also be using them, remove these configure tests from WebKit.
      
      * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
      * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
      * qmake/config.tests/libpng/libpng.cpp: Removed.
      * qmake/config.tests/libpng/libpng.pro: Removed.
      * qmake/mkspecs/features/features.prf:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e7e3c0e
    • rakuco@webkit.org's avatar
      [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5. · a8c6b99d
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106574
      
      Reviewed by Laszlo Gombos.
      
      Rely on a more recent stable release, which includes support for
      Lua 5.2 in Edje and other assorted minor fixes.
      
      While here, also use the "configure" script to build the libraries
      instead of relying on autogen.sh, which is not really needed with
      a release tarball and may have problems with automake 1.13.
      
      * efl/jhbuild.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8c6b99d
    • apavlov@chromium.org's avatar
      Web Inspector: [Styles] Color names parsed inside "background-image" values · 30b4f83e
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106770
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Test: inspector/styles/url-color-swatch.html
      
      Spaces were not allowed in url(...) CSS property values.
      
      * inspector/front-end/StylesSidebarPane.js:
      
      LayoutTests:
      
      * inspector/styles/url-color-swatch-expected.txt: Added.
      * inspector/styles/url-color-swatch.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30b4f83e
    • commit-queue@webkit.org's avatar
      Web Inspector: fix DRT to deliver simulated events to devtools front-end · 71dabfd9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106650
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-14
      Reviewed by Pavel Feldman.
      
      Add separated m_devToolsTestInterfaces object to testShell which is
      bind to devTools webview.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::initialize):
      (TestShell::createMainWindow):
      (TestShell::~TestShell):
      (TestShell::showDevTools):
      (TestShell::resetTestController):
      (TestShell::bindJSObjectsToWindow):
      (TestShell::createNewWindow):
      * DumpRenderTree/chromium/TestShell.h:
      (TestShell):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71dabfd9
    • commit-queue@webkit.org's avatar
      Web Inspector: InspectorTest.createTestEditor should not set any text in editor · d6cefd63
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106772
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-14
      Reviewed by Pavel Feldman.
      
      Add InspectorTest.fillEditorWithText helper method and remove this
      functionality from InspectorTest.createTestEditor method.
      
      * inspector/editor/editor-test.js:
      (initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
      (initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
      * inspector/editor/text-editor-remove-chunks-from-dom.html:
      * inspector/editor/text-editor-selection.html:
      * inspector/editor/text-editor-type-over-decoration.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6cefd63
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, skip a new asserting test to paint the bots green. · c8789d81
      ossy@webkit.org authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8789d81
    • haraken@chromium.org's avatar
      [V8] Pass an Isolate to associateObjectWithWrapper() · a5db36a6
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106773
      
      Reviewed by Adam Barth.
      
      In preparation for making an Isolate parameter mandatory
      in associateObjectWithWrapper(), this patch passes an
      Isolate to associateObjectWithWrapper().
      
      No tests. No change in behavior.
      
      * bindings/v8/custom/V8ArrayBufferCustom.cpp:
      (WebCore::V8ArrayBuffer::constructorCallbackCustom):
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::wrapArrayBufferView):
      (WebCore::constructWebGLArray):
      * bindings/v8/custom/V8AudioContextCustom.cpp:
      (WebCore::V8AudioContext::constructorCallbackCustom):
      * bindings/v8/custom/V8DOMFormDataCustom.cpp:
      (WebCore::V8DOMFormData::constructorCallbackCustom):
      * bindings/v8/custom/V8DataViewCustom.cpp:
      (WebCore::V8DataView::constructorCallbackCustom):
      * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
      (WebCore::v8HTMLImageElementConstructorCallback):
      * bindings/v8/custom/V8IntentCustom.cpp:
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8MessageChannelCustom.cpp:
      (WebCore::V8MessageChannel::constructorCallbackCustom):
      * bindings/v8/custom/V8MutationObserverCustom.cpp:
      (WebCore::V8MutationObserver::constructorCallbackCustom):
      * bindings/v8/custom/V8WebKitPointCustom.cpp:
      (WebCore::V8WebKitPoint::constructorCallbackCustom):
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::constructorCallbackCustom):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5db36a6
    • kbalazs@webkit.org's avatar
      [Qt][WK2] plugin tests assert in debug · 2fcbc516
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106659
      
      Reviewed by Benjamin Poulain.
      
      Fixed the misuse of String::split.
      
      * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
      (WebKit::truncateToSingleLine):
      Add an assert to make sure this function works well. I just walked there
      while debugging the bug, and although it was innocent, adding this assertion
      is logical.
      * UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
      (WebKit::PluginProcessProxy::scanPlugin):
      The ASSERT was wrong. We have three lines, each ends in a newline, so split
      with allowEmptyEntries=true will devide it to 4 substrings.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fcbc516
    • haraken@chromium.org's avatar
      [V8] Call Isolate::GetCurrent() in a callback from WebCore · 90a7acaf
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106766
      
      Reviewed by Adam Barth.
      
      The objective is to pass an Isolate everywhere.
      Given that a callback from WebCore is an entry point to V8,
      we can call Isolate::GetCurrent() at the head of the callback
      and pass it to other places. (In practice, handleEvent() is
      the only callback used in the current WebKit.)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallbackImplementation):
      (NativeToJSValue):
      * bindings/scripts/test/V8/V8TestCallback.cpp:
      (WebCore::V8TestCallback::callbackWithNoParam):
      (WebCore::V8TestCallback::callbackWithClass1Param):
      (WebCore::V8TestCallback::callbackWithClass2Param):
      (WebCore::V8TestCallback::callbackWithStringList):
      (WebCore::V8TestCallback::callbackWithBoolean):
      (WebCore::V8TestCallback::callbackRequiresThisToPass):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a7acaf
    • tommyw@google.com's avatar
      MediaStream API: Change MediaStream::readyState to an boolean attribute called ended. · 4aad81ec
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106568
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      See specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
      
      Existings tests updated to cover patch.
      
      * Modules/mediastream/LocalMediaStream.cpp:
      (WebCore::LocalMediaStream::stop):
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::MediaStream::ended):
      (WebCore::MediaStream::streamEnded):
      * Modules/mediastream/MediaStream.h:
      (MediaStream):
      (WebCore::MediaStream::isLocal):
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrackList.cpp:
      (WebCore::MediaStreamTrackList::add):
      (WebCore::MediaStreamTrackList::remove):
      
      LayoutTests:
      
      * fast/mediastream/LocalMediaStream-onended-expected.txt:
      * fast/mediastream/LocalMediaStream-onended.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4aad81ec
    • apavlov@chromium.org's avatar
      Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when... · c319a079
      apavlov@chromium.org authored
      Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when "Color format" feature used
      https://bugs.webkit.org/show_bug.cgi?id=106767
      
      Reviewed by Vsevolod Vlasov.
      
      We used to render named colors as names regardless of the selected color format option.
      
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c319a079
    • commit-queue@webkit.org's avatar
      Crash caused by incomplete cleanup of regions information for anonymous block · a7170797
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106191
      
      Patch by Andrei Bucur <abucur@adobe.com> on 2013-01-14
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      When an anonymous block is no longer required it is removed from the render tree and deleted. For example, this can happen when an anonymous block children change
      from inlines to blocks. The patch updates the removeLeftoverAnonymousBlock function to delete the flow thread information attached to the obsolete anonymous block.
      The removeFromRenderFlowThread() function is recursive and it needs to be called after the anonymous block children were reparented and the child list cleared.
      I've also placed the children reset operation before clearing the parent because the latter also deletes the inRenderFlowThread flag from the object and it makes
      flow thread ownership detection impossible.
      
      Tests: fast/regions/remove-leftover-anon-block-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
      
      LayoutTests:
      
      * fast/regions/remove-leftover-anon-block-crash-expected.txt: Added.
      * fast/regions/remove-leftover-anon-block-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7170797
    • haraken@chromium.org's avatar
      [V8] Make an Isolate parameter mandatory in v8DateOrNull() · c7059e40
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106765
      
      Reviewed by Adam Barth.
      
      This is one of the efforts to kill all optional Isolate parameters.
      
      No tests. No change in behavior.
      
      * bindings/v8/V8Binding.h:
      (WebCore::v8DateOrNull):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7059e40
    • commit-queue@webkit.org's avatar
      Allow nesting of at-rules · 104b5ab7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106696
      
      Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-14
      Reviewed by Allan Sandfeld Jensen.
      
      Source/WebCore:
      
      http://dev.w3.org/csswg/css3-conditional/ introduces the
      concept of grouping rules, and allows for them to be nested. In
      particular, this change affects @media (and is needed for @supports as
      well).
      
      Test: fast/css/nested-at-rules.html
      
      * css/CSSGrammar.y.in:
          Move media to the block_valid_rule list.
      
      * css/RuleSet.cpp:
      (WebCore::RuleSet::addRegionRule):
      (WebCore::RuleSet::addChildRules):
      (WebCore::RuleSet::addRulesFromSheet):
      * css/RuleSet.h:
          Rip out the rule-adding loop into a new method, for added
          cleanliness and recursing.
      
      LayoutTests:
      
      * fast/css/nested-at-rules-expected.txt: Added.
      * fast/css/nested-at-rules.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      104b5ab7
    • commit-queue@webkit.org's avatar
      Web Inspector: [Network] Add domain column · 7539b7eb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106757
      
      Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-14
      Reviewed by Pavel Feldman.
      
      Adding new column will ease domain tracking / sorting.
      
      * inspector/front-end/NetworkPanel.js: Added column.
      * inspector/front-end/NetworkRequest.js:
      (WebInspector.NetworkRequest.prototype.get domain): Added getter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7539b7eb
    • commit-queue@webkit.org's avatar
      Sheriffbot command aliases need test cases · 554d8a4a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106754
      
      Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-14
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
      (SheriffBotTest.test_command_aliases):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554d8a4a
    • commit-queue@webkit.org's avatar
      Fix a typo error in the comments in PlatformContextSkia.h · 209d0ad4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105612
      
      Patch by Qiankun Miao <qiankun.miao@intel.com> on 2013-01-14
      Reviewed by Stephen White.
      
      "If false we're rendering to a GraphicsContext for a web page, if false
      we're not (as is the case when rendering to a canvas object)." is
      self-contradictory. The second "flase" in the comments should be
      "true". If true, we're rendering to an ImageBuffer which has a canvas
      object.
      
      * platform/graphics/skia/PlatformContextSkia.h:
      (PlatformContextSkia):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      209d0ad4
    • loislo@chromium.org's avatar
      Web Inspector: Native Memory Instrumentation: fix instrumentation for already... · a5b5f955
      loislo@chromium.org authored
      Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3
      https://bugs.webkit.org/show_bug.cgi?id=106764
      
      Reviewed by Vsevolod Vlasov.
      
      Last three classes with not instrumented members were fixed.
      
      * css/CSSGroupingRule.cpp:
      (WebCore::CSSGroupingRule::reportMemoryUsage):
      * css/StyleScopeResolver.cpp:
      (WebCore::StyleScopeResolver::reportMemoryUsage):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5b5f955
    • loislo@chromium.org's avatar
      Web Inspector: Native Memory Instrumentation: fix instrumentation for already... · 771ab1fe
      loislo@chromium.org authored
      Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
      https://bugs.webkit.org/show_bug.cgi?id=106546
      
      Reviewed by Vsevolod Vlasov.
      
      Many nontrivial class members were added into reportMemoryUsage methods.
      
      * bindings/v8/V8PerIsolateData.cpp:
      (WebCore::V8PerIsolateData::reportMemoryUsage):
      * css/CSSMediaRule.cpp:
      (WebCore::CSSMediaRule::reportMemoryUsage):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::reportMemoryUsage):
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::reportMemoryUsage):
      * css/MediaList.cpp:
      (WebCore::MediaList::reportMemoryUsage):
      * css/RuleSet.cpp:
      (WebCore::RuleData::reportMemoryUsage):
      (WebCore::RuleSet::reportMemoryUsage):
      (WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
      (WebCore::StyleResolver::reportMemoryUsage):
      * css/StyleSheetContents.cpp:
      (WebCore::StyleSheetContents::reportMemoryUsage):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::reportMemoryUsage):
      * inspector/HeapGraphSerializer.cpp:
      (WebCore::HeapGraphSerializer::reportMemoryUsage):
      * inspector/InspectorMemoryAgent.cpp:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::reportMemoryUsage):
      * inspector/MemoryInstrumentationImpl.cpp:
      (WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::reportMemoryUsage):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::reportMemoryUsage):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::reportMemoryUsage):
      * loader/Prerenderer.cpp:
      (WebCore::Prerenderer::reportMemoryUsage):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::reportMemoryUsage):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::reportMemoryUsage):
      * page/Page.cpp:
      (WebCore::Page::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      771ab1fe
    • noel.gordon@gmail.com's avatar
      [chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg everywhere · 9345c27d
      noel.gordon@gmail.com authored
      Unreviewed w/end gardening.
      
      * platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
      * platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
      * platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
      * platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
      * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9345c27d
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL gardening. · ea5f1155
      christophe.dumez@intel.com authored
      Mark accessibility/render-counter-text.html as flaky
      on EFL port since it sometimes crashes.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5f1155
  2. 13 Jan, 2013 10 commits