- 30 Apr, 2010 40 commits
-
-
http://webkit.org/b/38364ddkilzer@apple.com authored
<http://webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html Reviewed by NOBODY (OOPS!). * http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Fixed MIME typo from "application-javascript" to "application/javascript". git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* plugins/qt/PluginPackageQt.cpp: (WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue): (WebCore::PluginPackage::NPVersion): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::NPVersion): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* Plugins/WebNetscapeContainerCheckContextInfo.h: * Plugins/WebNetscapeContainerCheckContextInfo.mm: (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): (-[WebNetscapeContainerCheckContextInfo checkRequestID]): (-[WebNetscapeContainerCheckContextInfo callback]): * Plugins/WebNetscapePluginPackage.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* bridge/npapi.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=38228 Reviewed by Darin Fisher. WebCore: * platform/chromium/ChromiumBridge.h: * platform/chromium/FileSystemChromium.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile): WebKit/chromium: * WebKit.gyp: * public/WebFileSystem.h: Added. * public/WebKitClient.h: (WebKit::WebKitClient::fileSystem): * src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Dan Bernstein. Final part of https://bugs.webkit.org/show_bug.cgi?id=20784 move npapi.h to C99 integer types * bridge/npapi.h: Remove the old types. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed, rolling out r58569. http://trac.webkit.org/changeset/58569 https://bugs.webkit.org/show_bug.cgi?id=38399 This broke the GTK bots due to bad GC behavior (Requested by ericu on #webkit). * fast/workers/change-version-handle-reuse-worker-expected.txt: Removed. * fast/workers/change-version-handle-reuse-worker.html: Removed. * fast/workers/execute-sql-args-worker-expected.txt: Removed. * fast/workers/execute-sql-args-worker.html: Removed. * fast/workers/resources/database-worker-controller.js: Removed. * fast/workers/resources/database-worker.js: Removed. * storage/change-version-handle-reuse-expected.txt: * storage/change-version-handle-reuse.html: * storage/change-version-handle-reuse.js: Removed. * storage/execute-sql-args.html: * storage/execute-sql-args.js: Removed. 2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r58569. http://trac.webkit.org/changeset/58569 https://bugs.webkit.org/show_bug.cgi?id=38399 This broke the GTK bots due to bad GC behavior (Requested by ericu on #webkit). * bindings/js/JSWorkerContextCustom.cpp: * bindings/v8/custom/V8WorkerContextCustom.cpp: * storage/Database.idl: * storage/SQLError.idl: * storage/SQLResultSet.idl: * storage/SQLResultSetRowList.idl: * storage/SQLTransaction.idl: * workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase): * workers/WorkerContext.h: (WebCore::WorkerContext::databaseExceededQuota): * workers/WorkerContext.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* Plugins/WebNetscapeContainerCheckContextInfo.h: * Plugins/WebNetscapeContainerCheckContextInfo.mm: (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): * Plugins/WebNetscapeContainerCheckPrivate.h: * Plugins/WebNetscapePluginPackage.mm: (functionPointerForTVector): * Plugins/WebNetscapePluginView.mm: (PluginTimer::PluginTimer): (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yaar@chromium.org authored
Not Reviewed. Updating expectations for svg-as-border-* https://bugs.webkit.org/show_bug.cgi?id=38398 * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Added. * platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Added. * platform/chromium-win/transforms/svg-vs-css-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
* platform/mac-tiger/Skipped: Added two tests that fail on buidbot. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::platformGetValueStatic): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::platformGetValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Timothy Hatcher. Next step towards fixing https://bugs.webkit.org/show_bug.cgi?id=20784 move npapi.h to C99 integer types Use the C99 types everywhere. The "old" types are still around but will be removed in a subsequent commit. * Plugins/WebBaseNetscapePluginStream.h: * Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData): * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]): * Plugins/npapi.mm: (NPN_MemAlloc): (NPN_MemFlush): (NPN_PostURLNotify): (NPN_PostURL): (NPN_Write): (NPN_ScheduleTimer): (NPN_UnscheduleTimer): (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo): (WKN_CheckIfAllowedToLoadURL): (WKN_CancelCheckIfAllowedToLoadURL): 2010-04-30 Anders Carlsson <andersca@apple.com> Reviewed by Timothy Hatcher. Next step towards fixing https://bugs.webkit.org/show_bug.cgi?id=20784 move npapi.h to C99 integer types Use the C99 types everywhere. The "old" types are still around but will be removed in a subsequent commit. * bridge/npapi.h: (_NPCocoaEvent::): * plugins/PluginPackage.h: * plugins/PluginStream.cpp: (WebCore::PluginStream::deliverData): * plugins/PluginStream.h: * plugins/PluginView.cpp: (WebCore::PluginView::postURLNotify): (WebCore::PluginView::postURL): (WebCore::PluginView::write): (WebCore::PluginView::handlePost): * plugins/PluginView.h: * plugins/PluginViewNone.cpp: (WebCore::PluginView::handlePostReadFile): * plugins/npapi.cpp: (NPN_MemAlloc): (NPN_MemFlush): (NPN_PostURLNotify): (NPN_PostURL): (NPN_Write): * plugins/npfunctions.h: * plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::NPVersion): * plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile): 2010-04-30 Anders Carlsson <andersca@apple.com> Reviewed by Timothy Hatcher. Next step towards fixing https://bugs.webkit.org/show_bug.cgi?id=20784 move npapi.h to C99 integer types Use the C99 types everywhere. The "old" types are still around but will be removed in a subsequent commit. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (int32VariantToIdentifier): (doubleVariantToIdentifier): (testIdentifierToInt): (testGetIntIdentifier): * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_HandleEvent): * DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_HandleEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
completely decoded, but no more data is coming. The ICO and BMP decoders already did this. https://bugs.webkit.org/show_bug.cgi?id=35411 Reviewed by David Levin. "Failed" does not cause the image to not be displayed, it simply causes us to not bother to try to decode again if future requests are made, and for some decoders, lets the decoder clean up some of its temporary objects. No layout tests because this does not change the visible output of decoding in any way. * platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameComplete): Return whether the frame could be marked as complete. (WebCore::GIFImageDecoder::decode): Fail if read() needs more data (and thus returns false) and no more is coming. * platform/image-decoders/gif/GIFImageDecoder.h: * platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Instead of returning true for buffer underrun and false for failure, return false for both and set the failure flag on failure. (GIFImageReader::read): Ditto. * platform/image-decoders/gif/GIFImageReader.h: * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::): (WebCore::JPEGImageReader::decode): See do_lzw() comment above. (WebCore::JPEGImageDecoder::decode): Fail if decode() needs more data (and thus returns false) and no more is coming. * platform/image-decoders/jpeg/JPEGImageDecoder.h: * platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode): Return true for decode success, false for buffer underrun or decode failure, and set the failure flag on decode failure. (WebCore::PNGImageDecoder::decode): See JPEGImageDecoder::decode() comment above. * platform/image-decoders/png/PNGImageDecoder.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=37334 * platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframesets.html skipped until fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Enable Sputnik tests on Tiger. * platform/mac-tiger/Skipped: Only skip tests that fail for me on Tiger/PPC, and Unicode tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/7902467beidson@apple.com authored
Reviewed by Eric Carlson. No new tests. (Currently no way to test such site specific hack behavior) * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay event, wrap the dispatch with m_dispatchingCanPlayEvent set. (WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org, don't perform the play(). * html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/6649734mitz@apple.com authored
WebCore: Part of <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font https://bugs.webkit.org/show_bug.cgi?id=6274 Reviewed by Adele Peterson. Account for glyph overflow of characters in the range U+1E00..U+2000, but without sending them through the complex text code path. Instead, introduce a variant of the fast path that tracks glyph overflow. * platform/graphics/Font.cpp: (WebCore::Font::drawText): Use codePath(). (WebCore::Font::floatWidth): Use codePath(). Pass the GlyphOverflow pointer through to floatWidthForSimpleText() if the code path is SimpleWithGlyphOverflow. (WebCore::Font::selectionRectForText): Use codePath(). (WebCore::Font::offsetForPosition): Ditto. * platform/graphics/Font.h: Replaced canUseGlyphCache() with codePath(). Added a GlyphOverflow parameter to floatWidthForSimpleText(). * platform/graphics/FontFastPath.cpp: Removed ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE. (WebCore::Font::codePath): Renamed canUseGlyphCache() to this. Where it used to return false, it now returns Complex. Where it used to return true, it now returns Simple, except for the range U+1E00..U+2000, where it now returns SimpleWithGlyphOverflow. (WebCore::Font::floatWidthForSimpleText): Added a GlyphOverflow parameter. If not 0, have the width iterator account for glyph bounds, then update the GlyphOverflow accordingly. * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): Added boolean parameter telling the width iterator whether to account for glyph bounds. Initialize m_accountForGlyphBounds accordingly. Initialize m_maxGlyphBoundingBoxY, m_minGlyphBoundingBoxY, m_firstGlyphOverflow and m_lastGlyphOverflow. (WebCore::WidthIterator::advance): If accounting for glyph bounds, update the above member variables. * platform/graphics/WidthIterator.h: (WebCore::WidthIterator::maxGlyphBoundingBoxY): Added this accessor. (WebCore::WidthIterator::minGlyphBoundingBoxY): Ditto. (WebCore::WidthIterator::firstGlyphOverflow): Ditto. (WebCore::WidthIterator::lastGlyphOverflow): Ditto. LayoutTests: Updated results for <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font https://bugs.webkit.org/show_bug.cgi?id=6274 Reviewed by Adele Peterson. * platform/mac/fast/repaint/stacked-diacritics-expected.checksum: * platform/mac/fast/repaint/stacked-diacritics-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
Reviewed by Simon Fraser. Reversed the order of the CSSMatrix.multiply method https://bugs.webkit.org/show_bug.cgi?id=38337 * css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::multiply): * platform/graphics/transforms/TransformationMatrix.cpp: These are the existing tests for 2D and 3D CSSMatrix and SVGMatrix. I've added tests missing between the two styles and now do tests that confirm that SVGMatrix and CSSMatrix both multiply the same. This also adds a new test from Simon which compares SVG to CSS matrixes. This is a pixel test for mac only. * platform/mac/transforms/svg-vs-css-expected.checksum: Added. * platform/mac/transforms/svg-vs-css-expected.png: Added. * platform/mac/transforms/svg-vs-css-expected.txt: Added. * svg/dom/SVGMatrix-interface-expected.txt: * svg/dom/SVGMatrix-interface.xhtml: * transforms/cssmatrix-2d-interface-expected.txt: * transforms/cssmatrix-2d-interface.xhtml: * transforms/cssmatrix-3d-interface-expected.txt: * transforms/cssmatrix-3d-interface.xhtml: * transforms/svg-vs-css.xhtml: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
[Chromium] Provide expectations for svg/custom/repaint-stroke-width-changes.svg, which was added in http://trac.webkit.org/changeset/58570/. * platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Added. * platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added. * platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.png: Added. * platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.checksum: Added. * platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac. https://bugs.webkit.org/show_bug.cgi?id=38334 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Beth Dakin. Update image results for SVG as CSS border image tests https://bugs.webkit.org/show_bug.cgi?id=37028 Improve the tests for SVG in border image to use an image that is not a solid color, and by adding comparison elements with PNG-based borders. Remove unused "green rect" SVG files. Update Mac pixel results, and remove Chromium pixel results with the expectation that someone will commit new ones. * fast/borders/resources/green-fixed-size-rect.svg: Removed. * fast/borders/resources/green-relative-size-rect.svg: Removed. * fast/borders/resources/large-tiles.png: Added. * fast/borders/resources/tiles-fixed-size.svg: Added. * fast/borders/resources/tiles-relative-size.svg: Added. * fast/borders/resources/tiles.png: Added. * fast/borders/svg-as-border-image-2.html: * fast/borders/svg-as-border-image.html: * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Removed. * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed. * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed. * platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Removed. * platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed. * platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed. * platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: * platform/mac/fast/borders/svg-as-border-image-2-expected.png: * platform/mac/fast/borders/svg-as-border-image-2-expected.txt: * platform/mac/fast/borders/svg-as-border-image-expected.checksum: * platform/mac/fast/borders/svg-as-border-image-expected.png: * platform/mac/fast/borders/svg-as-border-image-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
[Chromium] Defer Sputnik tests. * platform/chromium/test_expectations.txt: Tagged fast/js/sputnik with DEFER. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Reviewed by Simon Fraser. SHOULD NEVER BE REACHED assertion loading forbes.com https://bugs.webkit.org/show_bug.cgi?id=38272 * printing/pseudo-class-outside-page-expected.txt: Added. * printing/pseudo-class-outside-page.html: Added. 2010-04-30 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Simon Fraser. SHOULD NEVER BE REACHED assertion loading forbes.com https://bugs.webkit.org/show_bug.cgi?id=38272 Ignore page media related pseudo classes. Test: printing/pseudo-class-outside-page.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. While I'm at it: Update prototype-inheritance-2-expected.txt result, it's failing since CSSPageRule has been introduced. * platform/win/fast/dom/prototype-inheritance-2-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. Windows fails on svg/custom/mask-changes.svg. Trying to fix the test which is really flawed. Shows a DRT difference between Mac/Win. * svg/custom/mask-changes.svg: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Unreviewed. Fixing a missed test from https://bugs.webkit.org/show_bug.cgi?id=38331 * fast/events/init-events-expected.txt: * fast/events/script-tests/init-events.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
laszlo.1.gombos@nokia.com authored
Unreviewed, build fix. Fix compiler warning "suggest parentheses around" No new tests as there is no new functionality. * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Revert a part of r58564 to be compatible with prior behavior https://bugs.webkit.org/show_bug.cgi?id=38383 * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent): r58564 made a region check for the cancel button stricter, but it made some tests failing on Chromium. So, relax the check again. LayoutTests: Unreviewed. Revert a part of r58564 to be compatible with prior behavior https://bugs.webkit.org/show_bug.cgi?id=38383 * platform/chromium/test_expectations.txt: Remove expectations added by r58568. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Darin Fisher. Change StorageEvent.uri to StorageEvent.url to match the spec https://bugs.webkit.org/show_bug.cgi?id=38331 Change the existing tests to test 'url' rather than 'uri'. * storage/domstorage/events/documentURI-expected.txt: * storage/domstorage/events/script-tests/documentURI.js: (step2): (step3): * storage/domstorage/localstorage/resources/iframe-events-second.html: * storage/domstorage/sessionstorage/resources/iframe-events-second.html: 2010-04-29 Jeremy Orlow <jorlow@chromium.org> Reviewed by Darin Fisher. Change StorageEvent.uri to StorageEvent.url to match the spec https://bugs.webkit.org/show_bug.cgi?id=38331 As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html WebKit is the only one who places the document's URL in a 'uri' property rather than a 'url' property. Even though we've shipped several versions of browsers with the old name, we probably should change this to comply with the spec. This stuff is covered by existing tests. * storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent): * storage/StorageEvent.h: (WebCore::StorageEvent::url): * storage/StorageEvent.idl: 2010-04-29 Jeremy Orlow <jorlow@chromium.org> Reviewed by Darin Fisher. Change StorageEvent.uri to StorageEvent.url to match the spec https://bugs.webkit.org/show_bug.cgi?id=38331 Get rid of a stale FIXME and combine 2 lines that needn't be split. * src/StorageEventDispatcherImpl.cpp: (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed https://bugs.webkit.org/show_bug.cgi?id=38385 The last SVG performance patch broke repainting if bounds of a RenderPath get smaller. It would only repaint the smaller part, not the original larger bounds. Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(), combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject, right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method. Overall this is a regression fix, a performance improvement and saves memory. Something for everyone. Tests: svg/custom/repaint-stroke-width-changes.svg * rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance. (WebCore::RenderObject::strokeBoundingBox): * rendering/RenderObject.h: Ditto. * rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them. (WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated. (WebCore::RenderPath::styleWillChange): Mark boundaries as dirty. (WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout(). * rendering/RenderPath.h: Rename cached rect variables to have more sensible names. (WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code. (WebCore::RenderPath::strokeBoundingBox): Ditto. (WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto. * rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method. * rendering/RenderSVGImage.h: Ditto. * rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes. (WebCore::RenderSVGInline::strokeBoundingBox): * rendering/RenderSVGInline.h: Remove toSVGRenderBase() method. * rendering/RenderSVGModelObject.h: Ditto. * rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject. (WebCore::RenderSVGResourceFilter::applyResource): * rendering/RenderSVGText.h: Remove toSVGRenderBase() method. * rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox(). (WebCore::SVGRenderBase::strokeBoundingBox): * rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method. * rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath. (WebCore::SVGRenderStyle::hasMarkers): 2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Dirk Schulze. REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed https://bugs.webkit.org/show_bug.cgi?id=38385 Add new test covering the repaint problem. Influences some marker results, that can be safely ignored. * platform/mac/svg/custom/circular-marker-reference-1-expected.txt: * platform/mac/svg/custom/circular-marker-reference-3-expected.txt: * platform/mac/svg/custom/circular-marker-reference-4-expected.txt: * platform/mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added. * platform/mac/svg/custom/repaint-stroke-width-changes-expected.png: Added. * platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt: Added. * svg/custom/repaint-stroke-width-changes.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dmitry Titov. Add bindings for async DB API in Workers. https://bugs.webkit.org/show_bug.cgi?id=34992 * storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test. * storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do. * storage/change-version-handle-reuse.js: This is the extracted shared core of the test. * storage/execute-sql-args.html: Refactored to share code with the worker version of the test. * storage/execute-sql-args.js: This is the extracted shared core of the test. These are the worker versions of the tests; they're tiny shims around shared code. * fast/workers/execute-sql-args-worker-expected.txt: Added. * fast/workers/execute-sql-args-worker.html: Added. * fast/workers/change-version-handle-reuse-worker-expected.txt: Added. * fast/workers/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side. * fast/workers/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions. * fast/workers/resources/database-worker.js: Added. 2010-04-30 Eric Uhrhane <ericu@chromium.org> Reviewed by Dmitry Titov. Add bindings for async DB API in Workers. https://bugs.webkit.org/show_bug.cgi?id=34992 Tests: storage/change-version-handle-reuse-worker.html storage/execute-sql-args-worker.html * bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase): * bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback): Add NoStaticTables flags to all objects now shared with workers. * storage/Database.idl: * storage/SQLError.idl: * storage/SQLResultSet.idl: * storage/SQLResultSetRowList.idl: * storage/SQLTransaction.idl: * workers/WorkerContext.h: Add databaseExceededQuota. * workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion. Add the IDL for the call to openDatabase. * workers/WorkerContext.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=38383 Start failing after WebKit r58563:r58565 - fast/forms/search-abs-pos-cancel-button.html - fast/forms/search-cancel-button-mouseup.html - fast/forms/search-rtl.html - fast/forms/search-zoomed.html * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Reviewed by Darin Adler. Unnecessary PrintContext::end() calls https://bugs.webkit.org/show_bug.cgi?id=38247 Refactoring only, so no new tests. * page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
media/video-empty-source.html passes since r58480:r58515 (win), r58489 (linux), r58488:458490 (mac) fast/backround/svg-as-background-6.html passes since r58488:r58490 (mac) fast/repaint/caret-outside-block.html passes since r58414:r58415 (mac) fast/replaced/border-radius-clip.html passes since r58543 (win, linux) fast/images/svg-as-tiled-background.html passes r58488:r58490 (mac) fast/text/line-breaks.html passes since r58480:r58515 (win) fast/backgrounds/svg-as-background-2.html passes since r58480:r58515 (win), r58489 (linux), r58488:r58490 (mac) * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-