1. 27 Aug, 2006 13 commits
    • beidson's avatar
      Reviewed by Maciej · c7b04983
      beidson authored
              Plugged a leak in StringImpl::replace()
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::replace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7b04983
    • andersca's avatar
      2006-08-27 Nikolas Zimmermann <zimmermann@kde.org> · 91dde07e
      andersca authored
              Reviewed and landed by Anders.
      
              Remove most annoying notImplemented() usages and
              implement some missing ScrollViewQt functions.
              Much nicer output when invoking run-webkit-tests.
      
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::saveDocumentState):
              (WebCore::FrameQt::restoreDocumentState):
              (WebCore::FrameQt::clearUndoRedoOperations):
              (WebCore::FrameQt::partClearedInBegin):
              * platform/qt/ResourceLoaderManager.cpp:
              (WebCore::headerCallback):
              (WebCore::ResourceLoaderManager::downloadTimerCallback):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::updateContents):
              (WebCore::ScrollView::suppressScrollBars):
              (WebCore::ScrollView::setStaticBackground):
              (WebCore::ScrollView::addChild):
              (WebCore::ScrollView::removeChild):
              * platform/qt/TemporaryLinkStubs.cpp:
              (WebCore::historyContains):
              (WebCore::CheckCacheObjectStatus):
              (WebCore::CheckIfReloading):
              (loadResourceIntoArray):
              (WebCore::PlugInInfoStore::supportsMIMEType):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91dde07e
    • andersca's avatar
      Forgot this too (doh!) · 8efa6506
      andersca authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8efa6506
    • andersca's avatar
      Didn't mean to commit this! · 0e71f7b1
      andersca authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e71f7b1
    • andersca's avatar
      2006-08-27 Anders Carlsson <acarlsson@apple.com> · b0b15df5
      andersca authored
              Forgot to add these.
              
              * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::~DumpRenderTree):
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::readStdin):
              (WebCore::DumpRenderTree::checkLoaded):
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
              * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b15df5
    • andersca's avatar
      2006-08-27 Nikolas Zimmermann <zimmermann@kde.org> · 09245423
      andersca authored
              Reviewed by Eric, landed by Anders.
      
              Add DumpRenderTree support for Qt/Linux.
      
              * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::~DumpRenderTree):
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::readStdin):
              (WebCore::DumpRenderTree::checkLoaded):
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
              * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
              (main):
              * Scripts/build-dumprendertree:
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09245423
    • andersca's avatar
      2006-08-27 Nikolas Zimmermann <zimmermann@kde.org> · 8acce43f
      andersca authored
              Reviewed and landed by Anders.
      
              Fix Qt build (add SVGMetaDataElement.cpp to build system)
      
              * CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8acce43f
    • eseidel's avatar
      2006-08-27 Eric Seidel <eric@eseidel.com> · 9ac6744a
      eseidel authored
              Reviewed by andersca.
      
              No logic changes.  Just cleanup.
      
              * ksvg2/svg/SVGAngle.cpp:
              (SVGAngle::SVGAngle):
              (SVGAngle::unitType):
              (SVGAngle::valueAsString):
              (SVGAngle::newValueSpecifiedUnits):
              (SVGAngle::convertToSpecifiedUnits):
              * ksvg2/svg/SVGAngle.h:
              * ksvg2/svg/SVGLength.cpp:
              (WebCore::SVGLength::unitType):
              (WebCore::SVGLength::newValueSpecifiedUnits):
              (WebCore::SVGLength::convertToSpecifiedUnits):
              (WebCore::SVGLength::updateValue):
              (WebCore::SVGLength::updateValueInSpecifiedUnits):
              * ksvg2/svg/SVGLength.h:
              * platform/BitmapImage.cpp: Removed.
              * platform/BitmapImage.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ac6744a
    • beidson's avatar
      God, that ChangeLog entry was bad... · f3bdfcc3
      beidson authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3bdfcc3
    • beidson's avatar
      Reviewed by Anders · 90fdc7bf
      beidson authored
              -Changed all of the commonly used queries to keep around pre-prepared statements and bind
              their arguments instead of constructing a messy.  
              -Changed some code in pruneUnretainedIconsOnStartup regarding transactions
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::IconDatabase): Initializers
              (WebCore::IconDatabase::close): Wipe all the preprepared statements
              (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions
              (WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery()
              (WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment
              (WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding
              (WebCore::IconDatabase::timeStampForIconURLQuery): ditto
              (WebCore::IconDatabase::iconURLForPageURLQuery): ditto
              (WebCore::IconDatabase::forgetPageURLQuery): ditto
              (WebCore::IconDatabase::setIconIDForPageURLQuery): ditto
              (WebCore::IconDatabase::getIconIDForIconURLQuery): ditto
              (WebCore::IconDatabase::addIconForIconURLQuery): ditto
              (WebCore::IconDatabase::hasIconForIconURLQuery): ditto
              * loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
              * loader/icon/SQLStatement.h:
              (WebCore::SQLStatement::database): Added
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90fdc7bf
    • rwlbuis's avatar
      Reviewed by Eric. Landed by rwlbuis. · dcd15ddb
      rwlbuis authored
              Fix switch logic.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcd15ddb
    • rwlbuis's avatar
      Reviewed by Eric. · 04c7b59f
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
              KCanvasPath should be replace by platform/Path
      
              Refactoring out the KCanvasPath class.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04c7b59f
    • eseidel's avatar
      2006-08-26 Eric Seidel <eric@eseidel.com> · 59e92ca2
      eseidel authored
              Reviewed by hyatt.
      
              pointer-events attribute does not work.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10415
      
              * kcanvas/RenderPath.cpp:
              (WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic
              (WebCore::RenderPath::nodeAtPoint): respect pointer-events property
              * kcanvas/RenderPath.h:
              (WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
              * ksvg2/css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGValue):
              * ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value
              (WebCore::SVGPaint::SVGPaint):
              (WebCore::SVGPaint::paintType):
              (WebCore::SVGPaint::uri):
              (WebCore::SVGPaint::setUri):
              (WebCore::SVGPaint::setPaint):
              * ksvg2/svg/SVGPaint.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e92ca2
  2. 26 Aug, 2006 5 commits
    • rwlbuis's avatar
      Reviewed by Eric. · ceddffaa
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
              SVG should have support for <metadata> element
      
              Add support for metadata tag.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceddffaa
    • ap's avatar
      Reviewed by Eric. · 3924f3a0
      ap authored
              Daily Qt build fixes :-)
      
              * platform/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawConvexPolygon):
              * platform/qt/ImageQt.cpp:
              (WebCore::Image::initPlatformData):
              (WebCore::Image::invalidatePlatformData):
              (WebCore::Image::loadPlatformResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3924f3a0
    • hyatt's avatar
      Fix the ifdef in Path.h to be CG. · d3631bba
      hyatt authored
              * platform/Path.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3631bba
    • hyatt's avatar
      Fix Mac build bustage (lots of float/int confusion). I am not sure · 4c55e234
      hyatt authored
              whether rounding was desired or not... this is just a band-aid to get
              the build working again.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintMenuListButton):
              (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c55e234
    • hyatt's avatar
      More refactoring of image to disentangle graphics (e.g., Cairo) from · 81d79fed
      hyatt authored
              platform (e.g., Windows).
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              Add ImageWin to project.
      
              * loader/Cache.cpp:
              (WebCore::Cache::init):
              * loader/icon/IconDataCache.cpp:
              (WebCore::IconDataCache::loadImageFromResource):
              Renamed loadResource to loadPlatformResource to try to make it more clear
              that this call is implemented on each OS (and not by graphics libraries).
      
              * platform/Image.cpp:
              (WebCore::Image::Image):
              (WebCore::Image::~Image):
              (WebCore::Image::invalidateData):
              (WebCore::Image::size):
              (WebCore::Image::setData):
              (WebCore::Image::setNativeData):
              Fix up the PDF code to not be considered platform data any more, since
              PDF rendering is not for a specific OS.
      
              Renamed the methods that set OS-specific data (like NSImage) to PlatformData
              instead of NativeData.
      
              * platform/Image.h:
              Shifted the PDF members into CG defines.  Made CGImageRef a CG define.
              Renamed methods to reflect that they are OS-specific and not
              graphics-library-specific.
             
              * platform/cairo/ImageCairo.cpp:
              Removed the platform data methods.  Other platforms besides Windows that
              use Cairo will need to account for this change by adding these methods
              to their OS Image***.cpp file.
      
              * platform/cg/ImageCG.cpp:
              (WebCore::Image::drawTiled):
              Add FIXMEs to the wkpattern stuff.
      
              * platform/cg/PDFDocumentImage.cpp:
              Shouldn't have #imports in .cpp.
      
              * platform/mac/ImageMac.mm:
              (WebCore::Image::initPlatformData):
              (WebCore::Image::invalidatePlatformData):
              (WebCore::Image::loadPlatformResource):
              (WebCore::Image::getTIFFRepresentation):
              Add the platform data initializers to the Mac Image file.   Move the
              TIFF representation there as well, since this is only used by Mac code.
      
              * platform/win/ImageWin.cpp: Added.
              (WebCore::Image::initPlatformData):
              (WebCore::Image::invalidatePlatformData):
              (WebCore::Image::loadPlatformResource):
              (WebCore::Image::supportsType):
              Similar work for Windows.  Add stubs for possible future HBITMAP returns
              in the platform data methods.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintResizeControl):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintResizeControl):
              loadResource -> loadPlatformResource
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d79fed
  3. 25 Aug, 2006 10 commits
    • aroben's avatar
      Rubber-stamped by Adele. · 1e42eadb
      aroben authored
              Fixed build.
      
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::drawConvexPolygon):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e42eadb
    • beidson's avatar
      Reviewed by Tim Hatcher · 32519398
      beidson authored
              Fixed up some leaks on [WebIconDatabase init]
      
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase init]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32519398
    • adele's avatar
      LayoutTests: · f5dfc2ac
      adele authored
              Updated results for addition of -webkit-text-security.
      
              * fast/css/computed-style-expected.txt:
      
      WebCore:
      
              Patch by Francisco, Reviewed by me.
      
              Preparation for switch to new text field implementation of password field.
      
              Added -webkit-text-security property.
      
              Tests: updated fast/css/computed-style-expected.txt
      
              * css/CSSPropertyNames.in: Added -webkit-text-security.
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cases for textSecurity.
              * css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto.
              * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
              * css/html4.css: Added style for password field to use -webkit-text-security.
      
              * html/HTMLInputElement.cpp: Check appearance property to decide which renderer to use.
              (WebCore::HTMLInputElement::selectionStart):
              (WebCore::HTMLInputElement::selectionEnd):
              (WebCore::HTMLInputElement::setSelectionStart):
              (WebCore::HTMLInputElement::setSelectionEnd):
              (WebCore::HTMLInputElement::select):
              (WebCore::HTMLInputElement::setSelectionRange):
              (WebCore::HTMLInputElement::createRenderer):
              * html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added check for password.
      
              * platform/StringImpl.cpp: (WebCore::StringImpl::secure): Added. Converts a string to replace 
               characters with one character, like a bullet.
              * platform/StringImpl.h:
      
              * rendering/RenderStyle.cpp:
              (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): Initialize textSecurity.
              (WebCore::RenderStyle::diff): Added case for textSecurity.
              * rendering/RenderStyle.h:
              (WebCore::):
              (WebCore::RenderStyle::textSecurity): Added.
              (WebCore::RenderStyle::setTextSecurity): Added.
              (WebCore::RenderStyle::initialTextSecurity): Added.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::setStyle): Added case for textSecurity.
              (WebCore::RenderText::setText): ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5dfc2ac
    • adele's avatar
      LayoutTests: · 05abee33
      adele authored
              Reviewed by Hyatt.
      
              New tests and updated tests for styled selects.
      
              * fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
              * fast/borders/borderRadiusInvalidColor-expected.png: Added.
              * fast/borders/borderRadiusInvalidColor-expected.txt: Added.
              * fast/borders/borderRadiusInvalidColor.html: Added.
      
              * fast/forms/select-baseline-expected.checksum: Added.
              * fast/forms/select-baseline-expected.png: Added.
              * fast/forms/select-baseline-expected.txt: Added.
              * fast/forms/select-baseline.html: Added.
      
              * editing/pasteboard/4641033-expected.txt:
              * editing/selection/replaced-boundaries-3-expected.txt:
              * editing/selection/select-box-expected.txt:
              * fast/block/margin-collapse/103-expected.txt:
              * fast/forms/001-expected.checksum:
              * fast/forms/001-expected.png:
              * fast/forms/001-expected.txt:
              * fast/forms/003-expected.txt:
              * fast/forms/004-expected.txt:
              * fast/forms/HTMLOptionElement_label01-expected.txt:
              * fast/forms/HTMLOptionElement_label02-expected.txt:
              * fast/forms/HTMLOptionElement_label03-expected.txt:
              * fast/forms/HTMLOptionElement_label04-expected.txt:
              * fast/forms/HTMLOptionElement_label06-expected.txt:
              * fast/forms/HTMLOptionElement_label07-expected.txt:
              * fast/forms/form-element-geometry-expected.checksum:
              * fast/forms/form-element-geometry-expected.png:
              * fast/forms/form-element-geometry-expected.txt:
              * fast/forms/option-script-expected.txt:
              * fast/forms/option-text-clip-expected.txt:
              * fast/forms/select-change-listbox-to-popup-expected.txt:
              * fast/forms/select-selected-expected.txt:
              * fast/forms/select-style-expected.txt:
              * fast/forms/select-visual-hebrew-expected.txt:
              * fast/invalid/014-expected.txt:
              * fast/parser/document-write-option-expected.txt:
              * fast/replaced/width100percent-expected.txt:
              * http/tests/navigation/anchor-basic-expected.txt:
              * http/tests/navigation/anchor-frames-expected.txt:
              * http/tests/navigation/anchor-goback-expected.txt:
              * http/tests/navigation/anchor-subframeload-expected.txt:
              * http/tests/navigation/javascriptlink-basic-expected.txt:
              * http/tests/navigation/javascriptlink-frames-expected.txt:
              * http/tests/navigation/javascriptlink-goback-expected.txt:
              * http/tests/navigation/javascriptlink-subframeload-expected.txt:
              * http/tests/navigation/metaredirect-basic-expected.txt:
              * http/tests/navigation/metaredirect-frames-expected.txt:
              * http/tests/navigation/metaredirect-goback-expected.txt:
              * http/tests/navigation/metaredirect-subframeload-expected.txt:
              * http/tests/navigation/post-goback2-expected.txt:
              * http/tests/navigation/postredirect-goback2-expected.txt:
              * http/tests/navigation/redirect302-basic-expected.txt:
              * http/tests/navigation/redirect302-frames-expected.txt:
              * http/tests/navigation/redirect302-goback-expected.txt:
              * http/tests/navigation/redirect302-subframeload-expected.txt:
              * http/tests/navigation/relativeanchor-basic-expected.txt:
              * http/tests/navigation/relativeanchor-frames-expected.txt:
              * http/tests/navigation/relativeanchor-goback-expected.txt:
              * http/tests/navigation/slowmetaredirect-basic-expected.txt:
              * http/tests/navigation/slowtimerredirect-basic-expected.txt:
              * http/tests/navigation/success200-basic-expected.txt:
              * http/tests/navigation/success200-frames-expected.txt:
              * http/tests/navigation/success200-frames-loadsame-expected.txt:
              * http/tests/navigation/success200-goback-expected.txt:
              * http/tests/navigation/success200-loadsame-expected.txt:
              * http/tests/navigation/success200-reload-expected.txt:
              * http/tests/navigation/success200-subframeload-expected.txt:
              * http/tests/navigation/timerredirect-basic-expected.txt:
              * http/tests/navigation/timerredirect-frames-expected.txt:
              * http/tests/navigation/timerredirect-goback-expected.txt:
              * http/tests/navigation/timerredirect-subframeload-expected.txt:
              * tables/mozilla/bugs/bug1188-expected.txt:
              * tables/mozilla/bugs/bug18359-expected.txt:
              * tables/mozilla/bugs/bug2479-3-expected.txt:
              * tables/mozilla/bugs/bug2479-4-expected.txt:
              * tables/mozilla/bugs/bug29326-expected.txt:
              * tables/mozilla/bugs/bug33855-expected.txt:
              * tables/mozilla/bugs/bug4382-expected.txt:
              * tables/mozilla/bugs/bug96334-expected.txt:
              * tables/mozilla/core/margins-expected.txt:
              * tables/mozilla/dom/tableDom-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Enable styling for popup menus. Also fixed baseline calculation for buttons and selects.
      
              Tests:   fast/forms/select-baseline.html
                       fast/borders/borderRadiusInvalidColor.html
              updated: fast/forms/select-style-expected.txt and more...
      
              * css/html4.css: Added style rules for styled select elements.
      
              * platform/GraphicsContext.h: Added argument for antialiasing.
              * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
              * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBorderArc): Added textColor argument so this can be used when the border color is invalid.
              (WebCore::RenderObject::drawBorder): Removed invalidisInvert since its dead code 
               (any callers that set this to true were already ensuring that their color was valid).
               Updated drawConvexPolygon call to use FloatPoints instead of IntPoints.
              (WebCore::RenderObject::paintBorder): Updated to remove invalidisInvert argument from drawBorder call.
              (WebCore::RenderObject::paintOutline): ditto.
              * rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutlineForLine): ditto.
              * rendering/RenderObject.h: Updated arguments for drawBorder and drawBorderArc.
      
              * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): Changed isRootLineBox argument to true when setting line height.
                Added case for when there's no children to check for hasLineIfEmpty.
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Changed isRootLineBox argument to true when setting line height.
              * rendering/RenderButton.h: (WebCore::RenderButton::hasLineIfEmpty): Added so buttons always get a line height.
              * rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasLineIfEmpty): ditto.
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutHorizontalBox): Added code to check hasLineIfEmpty to give flex boxes line height.
              (WebCore::RenderFlexibleBox::layoutVerticalBox): ditto.
      
              * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Moved the appearance adjustment code into adjust style.
              * rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Lets the theme paint "decorations", like the arrow control and gradients
               immediately after painting the background.
      
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::adjustStyle): This now checks whether the control is styled, and adjusts the appearance property appropriately.
              For styled selects, instead of setting the appearance to none, which is what we do for other styled controls, we set the appearance
              to MenulistButtonAppearance, which indicates that we will draw the arrow controls and button appearance in the engine.
              (WebCore::RenderTheme::paintDecorations): Added. Paints MenulistButtonAppearance in a different function, 
               so the arrow control will draw at the right time (after the background).
              (WebCore::RenderTheme::paint): Added case for MenulistButtonAppearance.
              (WebCore::RenderTheme::paintBorderOnly): ditto.
              (WebCore::RenderTheme::isControlContainer): Removed cases for MenuListAppearance and MenulistButtonAppearance since the baseline is no longer provided by the theme.
              (WebCore::RenderTheme::adjustMenuListButtonStyle): Added.
              * rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): Added.
      
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::isControlStyled): Removed code that made selects unstyle-able.
              (WebCore::RenderThemeMac::baselinePosition): Removed cases for MenuListAppearance and MenulistButtonAppearance.
              (WebCore::RenderThemeMac::popupButtonPadding): Added top and bottom padding so empty popups have the right baseline.
              (WebCore::TopGradientInterpolate): Added.
              (WebCore::BottomGradientInterpolate): Added.
              (WebCore::MainGradientInterpolate): Added.
              (WebCore::RenderThemeMac::paintMenuListButtonGradients): Added.  Draws gradients for styled popup menu button appearance.
              (WebCore::RenderThemeMac::paintMenuListButton): Calls paintMenuListButtonGradients, and draws arrow control.
              (WebCore::RenderThemeMac::adjustMenuListButtonStyle): Added to set padding and border radius to account for the arrow control size and font size.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05abee33
    • beidson's avatar
      Reviewed by Adam · 3cf2be9a
      beidson authored
              Changed some time()-related code to be more platform independent
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::isIconExpiredForIconURL):
              (WebCore::IconDatabase::getOrCreateIconDataCache):
              (WebCore::IconDatabase::setIconDataForIconURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf2be9a
    • harrison's avatar
      Reviewed by Geoff. · f1d5eb93
      harrison authored
              <rdar://problem/4416432> Radio buttons and Checkboxes in AXWebAreas don't fill in their AXTitle attribute
      
              * bridge/mac/WebCoreAXObject.mm:
              (labelForElement):
              New. Returns the HTMLLabelElement, if any, for the specified Element.
              
              (-[WebCoreAXObject title]):
              For input elements, return the innerHTML() of the labelForElement().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1d5eb93
    • beidson's avatar
      Reviewed by Tim Hatcher · 6c180edd
      beidson authored
              Changed some debugging-only code to be more platform independent
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
              (WebCore::IconDatabase::syncDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c180edd
    • aroben's avatar
      Reviewed/landed by Adam. · 1be5653b
      aroben authored
              Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10561
              Qt platform build fixes.
      
              * platform/qt/FrameQt.h:
              * platform/qt/ScreenQt.cpp:
              (WebCore::qwidgetForPage):
              (WebCore::screenRect):
              (WebCore::screenDepth):
              (WebCore::usableScreenRect):
              * platform/qt/TemporaryLinkStubs.cpp:
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              * platform/qt/WidgetQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1be5653b
    • aroben's avatar
      Reviewed/landed by Adam. · 2837ef71
      aroben authored
              Finally fix font caching. WebKit+Qt now works
              out of the box without any further patches :-)
      
              * platform/qt/FontDataQt.cpp:
              (WebCore::FontData::platformDestroy):
              * platform/qt/FontPlatformData.h:
              * platform/qt/FontPlatformDataQt.cpp:
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::isFixedPitch):
              (WebCore::FontPlatformData::font):
              (WebCore::FontPlatformData::fontPtr):
              (WebCore::FontPlatformData::hash):
              (WebCore::FontPlatformData::operator==):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2837ef71
    • aroben's avatar
      Reviewed/landed by Adam. · 3bad1044
      aroben authored
              Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
              Confirm to WebKit style guide - last fixes :-)
      
              * platform/ResourceLoaderClient.h:
              * platform/qt/ComboBoxQt.cpp:
              * platform/qt/FrameQt.cpp:
              (WebCore::doScroll):
              (WebCore::FrameQt::FrameQt):
              (WebCore::FrameQt::openURL):
              (WebCore::FrameQt::submitForm):
              (WebCore::FrameQt::setTitle):
              (WebCore::FrameQt::passSubframeEventToSubframe):
              (WebCore::FrameQt::registerCommandForUndo):
              (WebCore::FrameQt::registerCommandForRedo):
              (WebCore::FrameQt::keyEvent):
              (WebCore::FrameQt::setFrameGeometry):
              * platform/qt/GlyphMapQt.cpp:
              (WebCore::GlyphMap::fillPage):
              * platform/qt/GraphicsContextQt.cpp:
              (WebCore::toQtCompositionMode):
              (WebCore::toQtLineCap):
              (WebCore::toQtLineJoin):
              (WebCore::TextShadow::TextShadow):
              (WebCore::GraphicsContextPlatformPrivate::p):
              * platform/qt/ImageQt.cpp:
              (WebCore::FrameData::clear):
              (WebCore::Image::supportsType):
              * platform/qt/IntSizeQt.cpp:
              * platform/qt/LineEditQt.cpp:
              * platform/qt/ListBoxQt.cpp:
              * platform/qt/PageQt.cpp:
              (WebCore::Page::windowRect):
              * platform/qt/PathQt.cpp:
              (WebCore::Path::~Path):
              * platform/qt/ResourceLoaderCurl.cpp:
              (WebCore::ResourceLoader::assembleResponseHeaders):
              (WebCore::ResourceLoader::retrieveCharset):
              (WebCore::ResourceLoader::receivedResponse):
              * platform/qt/ResourceLoaderManager.cpp:
              (WebCore::headerCallback):
              (WebCore::ResourceLoaderManager::downloadTimerCallback):
              (WebCore::ResourceLoaderManager::add):
              * platform/qt/ScreenQt.cpp:
              (WebCore::screenRect):
              (WebCore::usableScreenRect):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::ScrollView):
              (WebCore::ScrollView::~ScrollView):
              (WebCore::ScrollView::setParentWidget):
              (WebCore::ScrollView::addChild):
              * platform/qt/SharedTimerQt.cpp:
              (WebCore::setSharedTimerFiredFunction):
              * platform/qt/SharedTimerQt.h:
              (WebCore::SharedTimerQt::SharedTimerQt):
              (WebCore::SharedTimerQt::fire):
              * platform/qt/SystemTimeQt.cpp:
              (WebCore::currentTime):
              * platform/qt/TextEditQt.cpp:
              (WebCore::PlatformTextEdit::setParentWidget):
              (WebCore::PlatformTextEdit::text):
              (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bad1044
  4. 24 Aug, 2006 12 commits
    • thatcher's avatar
      Reviewed by Darin. · 26c41f4c
      thatcher authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=10444
                Navigation links overlap the Spam Karma 2 footer
      
              * blog/wp-content/themes/webkit/style.css: Hide the footer altogether.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26c41f4c
    • thatcher's avatar
      Reviewed by Darin. · dd296cc5
      thatcher authored
              * WebView/WebFrame.m:
              (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
              * WebView/WebView.m:
              (-[WebViewPrivate dealloc]): release the background color
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd296cc5
    • harrison's avatar
      Reviewed by Justin. · 6fde4ef6
      harrison authored
              Follow up for...
              <rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
      
              Fix bug I introduced in r15959.
              
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              Use topDocument in case we are in a subframe (we want the start/end of the overall page).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fde4ef6
    • beidson's avatar
      Reviewed by Alice · 6d679882
      beidson authored
              Fixed my previous checkin, which was pruning the users entire icon db on startup everytime
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
                are indexed to 1, not 0
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d679882
    • ggaren's avatar
      · 59b56c71
      ggaren authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59b56c71
    • thatcher's avatar
      WebCore: · 7122a90b
      thatcher authored
              Reviewed by Hyatt.
      
              Allow changing the background color WebCore draws under transparent page backgrounds.
              No automated way to test. All tests pass, no performance regression.
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setBaseBackgroundColor:]):
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate):
              (WebCore::FrameView::baseBackgroundColor):
              (WebCore::FrameView::setBaseBackgroundColor):
              * page/FrameView.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBackgroundExtended):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::paintBoxDecorations):
      
      WebKit:
      
              Reviewed by Hyatt.
      
              WebView API to allow changing the background color that draws under transparent page backgrounds.
      
              * WebView/WebFrame.m:
              (-[WebFrame _makeDocumentView]):
              (-[WebFrame _updateBackground]):
              * WebView/WebFrameInternal.h:
              * WebView/WebFrameView.m:
              (-[WebFrameView drawRect:]):
              * WebView/WebView.m:
              (-[WebView setBackgroundColor:]):
              (-[WebView backgroundColor]):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              (-[WebView setDrawsBackground:]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7122a90b
    • darin's avatar
      LayoutTests: · 35384069
      darin authored
              Reviewed by Justin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
                REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
      
              * fast/forms/drag-into-textarea-expected.txt: Added.
              * fast/forms/drag-into-textarea.html: Added.
      
      WebCore:
      
              Reviewed by Justin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
                REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
              - eliminate the EditCommandPtr class from editing; use PassRefPtr and RefPtr instead
              - other editing-related cleanup
      
              Test: fast/forms/drag-into-textarea.html
      
              * bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
              * bridge/win/FrameWin.h: Ditto.
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto.
              (WebCore::FrameMac::registerCommandForUndo): Ditto.
              (WebCore::FrameMac::registerCommandForRedo): Ditto.
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter.
              (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto.
              (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.
      
              * editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child
              parameter to be a PassRefPtr. Reversed order of child and parent parameters.
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
              (WebCore::AppendNodeCommand::doApply): Ditto.
              (WebCore::AppendNodeCommand::doUnapply): Ditto.
      
              * editing/ApplyStyleCommand.h: Removed document parameter from constructor.
              * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.
      
              * editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
              * editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here.
              (WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly
              since setEndingSelection is no longer overloaded for Position.
      
              * editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from
              a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it
              m_commands and made both doUnapply and doReapply private.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands.
              (WebCore::CompositeEditCommand::doReapply): Ditto.
              (WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up
              starting and ending selection -- now done inside setParent. Rewrote to use m_commands.
              (WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::applyStyledElement): Ditto.
              (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
              (WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto.
              (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
              (WebCore::CompositeEditCommand::appendNode): Ditto.
              (WebCore::CompositeEditCommand::removeNode): Ditto.
              (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
              (WebCore::CompositeEditCommand::splitTextNode): Ditto.
              (WebCore::CompositeEditCommand::splitElement): Ditto.
              (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
              (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
              (WebCore::CompositeEditCommand::inputText): Ditto.
              (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
              (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
              (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
              (WebCore::CompositeEditCommand::deleteSelection): Ditto.
              (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
              (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code
              would not remove an empty attribute -- will not come up in practice, but wrong in theory.
              (WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
              (WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop.
              (WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a
              Selection explicitly since setEndingSelection is no longer overloaded for Position.
              (WebCore::createBlockPlaceholderElement): Collapsed this code so that the
              block placeholder class string is no longer spread across multiple functions.
              Perhaps we can get rid of this altogether at some point.
      
              * editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor.
              Also removed unneeded destructor.
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.
      
              * editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.
      
              * editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(),
              and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected
              and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected.
              Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(),
              endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which
              are needed so we can determine which editable elements an editing operation affects. Changed setParent()
              and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added
              applyCommand() function that's convenient to use on a newly-created command.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting
              and ending root editable elements.
              (WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed
              code to assert and set m_start. Eliminated use of EditCommandPtr.
              (WebCore::EditCommand::unapply): Ditto.
              (WebCore::EditCommand::reapply): Ditto.
              (WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this
              not change the starting selection of the parent unless this is the first command in the parent -- didn't
              make sense the way it was.
              (WebCore::EditCommand::setEndingSelection): Changed to set root editable element too.
              (WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child
              based on the ending selection of the parent, formerly done by callers.
              (WebCore::applyCommand): Added.
      
              * editing/FormatBlockCommand.h: Tweaked formatting.
              * editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
              * editing/InsertLineBreakCommand.h: Ditto.
              * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr.
              (WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum.
              (WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.
      
              * editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.
      
              * editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off
              the constants.
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::InsertListCommand): Ditto.
              (WebCore::InsertListCommand::doApply): Ditto.
      
              * editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor
              and changed the parameter of the node to insert to a PassRefPtr.
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
      
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.
      
              * editing/InsertTextCommand.h: Changed insertTab to take const Position&.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Ditto.
              (WebCore::InsertTextCommand::insertTab): Ditto.
      
              * editing/JSEditor.h: Tweaked formatting and names.
              * editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.
      
              * editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
              * editing/MergeIdenticalElementsCommand.h: Ditto.
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.
      
              * editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of
              IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers.
              (WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
              Changed to use Type instead of EListType.
              (WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers.
              (WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel.
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto.
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              Changed to not use EditCommandPtr.
              (WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers.
              (WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel.
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto.
              (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use
              EditCommandPtr.
      
              * editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment
              parameter to be a PassRefPtr.
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto.
              (WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.
      
              * editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
              * editing/RebalanceWhitespaceCommand.cpp:
              (WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto.
              (WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.
      
              * editing/RemoveCSSPropertyCommand.h: Tweaked formatting.
      
              * editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.
      
              * editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.
      
              * editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
      
              * editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
              (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto.
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
      
              * editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than
              a macro. Added constructors that take visible positions. Changed setBase and
              setExtent to take const Position& for better efficiency.
              * editing/Selection.cpp:
              (WebCore::Selection::Selection): Removed unnecessary double initialization of m_state
              and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.
      
              * editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.
      
              * editing/SplitElementCommand.h: Removed unnneeded document parameter.
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand): Ditto.
      
              * editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.
      
              * editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.
      
              * editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*.
              Renamed openForMoveTyping() with isOpenForMoreTyping().
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
              (WebCore::TypingCommand::insertText): Ditto.
              (WebCore::TypingCommand::insertLineBreak): Ditto.
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto.
              (WebCore::TypingCommand::insertParagraphSeparator): Ditto.
              (WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto.
              (WebCore::TypingCommand::closeTyping): Ditto.
              (WebCore::TypingCommand::typingAddedToOpenCommand): Ditto.
              (WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.
      
              * editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.
      
              * editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of
              unsigned short.
      
              * page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed
              appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(),
              and registerCommandForRedo() to take PassRefPtr<EditCommand>.
              * page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
              * page/Frame.cpp:
              (WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand.
              (WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function
              from Selection to simplify the code.
              (WebCore::Frame::selectAll): Ditto.
              (WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand.
              (WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to
              both of the root editable elements involved in a change -- the start selection
              might be in a different element than the end selection.
              (WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents,
              and to do it before setting the ending selection. Also update to use PassRefPtr instead
              of EditCommandPtr and change the order of setting m_lastEditCommand since passing it
              to registerCommandForUndo will take ownership and set it to 0.
              (WebCore::Frame::unappliedEditing): Ditto.
              (WebCore::Frame::reappliedEditing): Ditto.
              (WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr.
              (WebCore::Frame::applyStyle): Ditto.
              (WebCore::Frame::applyParagraphStyle): Ditto.
      
              * platform/gdk/FrameGdk.h: Updated for above changes.
              * platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
              * platform/win/TemporaryLinkStubs.cpp: Updated for above changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35384069
    • rwlbuis's avatar
      Reviewed by Eric. Landed by rwlbuis. · e67ea09b
      rwlbuis authored
              Add QtLauncher (was testunity before), which provides a
              standalone "browser" to test the Qt platform stuff.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e67ea09b
    • beidson's avatar
      Reviewed by Alice · 1550aa24
      beidson authored
              <rdar://problem/4697973> - Unacceptable delay on startup
              <rdar://problem/4690949> - Need to correctly prune unretained pageurls and icons on startup
      
              This patch was started by me and finished by Mark Rowe - we now special case all retains during
              startup into one huge sql transaction.  Also we track PageURL retains instead of IconURLs so pruning works right.
              Testing with reasonable sets of bookmarks/history (3000), startup time is neglibile.  Testing with a huge set of 
              bookmarks (40,000), startup has a noticable delay, but reasonable, and is inline with shipping safari which also 
              has a noticeable delay.
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::IconDatabase):
              (WebCore::IconDatabase::open): adding an initialStartupTransaction and pageRetainStatement
              (WebCore::IconDatabase::close): do cleanup on the initialStartupSQL stuff
              (WebCore::IconDatabase::retainIconForPageURL): Track initial PageURL retains in the temporary table
              (WebCore::IconDatabase::releaseIconForPageURL): Ditto
              (WebCore::IconDatabase::retainIconURL): We no longer special case this on startup
              (WebCore::IconDatabase::releaseIconURL): We no longer special case this on startup
              (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Handle the big transaction correctly and quickly
              (WebCore::IconDatabase::syncDatabase): Change the timing log message
              * loader/icon/IconDatabase.h:
              * loader/icon/SQLStatement.cpp:
              (WebCore::SQLStatement::bindText16): Added this - for reusing commonly used statements by just rebinding parameters.
              * loader/icon/SQLStatement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1550aa24
    • thatcher's avatar
      Reviewed by Darin. · 75e3e23b
      thatcher authored
              Fix for Mail stationary. Selecting a stationary item would cause this exception.
              *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
              Uncaught exception - *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
      
              * Loader/WebFrameLoader.m:
              (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
              Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e3e23b
    • rwlbuis's avatar
      0aacaa71
    • aroben's avatar
      Reviewed/landed by Adam. · d82909f2
      aroben authored
              Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
              WebKit should have Qt platform support
      
              * CMakeLists.txt:
                  Remove KCanvasMatrix.cpp because it no longer exists
                  Remove platform/qt/test
              * platform/FloatSize.h:
              * platform/image-decoders/bmp/BMPImageDecoder.cpp:
              * platform/image-decoders/gif/GIFImageDecoder.cpp:
              * platform/image-decoders/gif/GIFImageReader.cpp:
              * platform/image-decoders/ico/ICOImageDecoder.cpp:
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              * platform/image-decoders/xbm/XBMImageDecoder.cpp:
                  Added PLATFORM(QT) hooks in the image-decoders/, as they also need
                  to work for Qt, not only for Cairo.
              * platform/qt/qt-encodings.txt: Added (required for build).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d82909f2