1. 03 Jan, 2006 1 commit
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · c70d1c6a
      andersca authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
              Javascript cloneNode(deep) does not clone form elements correctly
      
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
              * khtml/html/html_formimpl.h:
              Copy m_value, m_checked and m_indeterminate here.
      
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::importNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.h:
              (DOM::ElementImpl::copyNonAttributeProperties):
              Add function declaration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70d1c6a
  2. 02 Jan, 2006 4 commits
    • mjs's avatar
      Reviewed by Eric. · 7c79e17d
      mjs authored
      	- moved frame traversal logic from WebFrame to WebBridge
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
      
      	To do this, I had to invert the ownership so that WebBridge now
      	owns WebFrame instead of vice versa. As a result, WebView now owns
      	a WebBridge pointer and does not have a direct WebFrame pointer.
      
              * WebCoreSupport.subproj/WebBridge.h:
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating
      	the frame, so pass it what it needs to do that.
              (-[WebBridge dealloc]): The bridge now owns the frame, so release it.
              (-[WebBridge close]): ditto
              (-[WebBridge firstChild]): Moved from WebFrame
              (-[WebBridge lastChild]): ditto
              (-[WebBridge childCount]): ditto
              (-[WebBridge previousSibling]): ditto
              (-[WebBridge nextSibling]): ditto
              (-[WebBridge isDescendantOfFrame:]): ditto
              (-[WebBridge traverseNextFrameStayWithin:]): ditto
              (-[WebBridge appendChild:]): ditto
              (-[WebBridge removeChild:]): ditto
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _removeChild::]): Call WebBridge version
              (-[WebFramePrivate dealloc]): ditto
              (-[WebFrame _firstChildFrame]): ditto
              (-[WebFrame _lastChildFrame]): ditto
              (-[WebFrame _childFrameCount]): ditto
              (-[WebFrame _previousSiblingFrame]): ditto
              (-[WebFrame _nextSiblingFrame]): ditto
              (-[WebFrame _traverseNextFrameStayWithin:]): ditto
              (-[WebFrame _appendChild:]): ditto
              (-[WebFrame _removeChild:]): ditto
              (-[WebFrame _isDescendantOfFrame:]): ditto,
              (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge
      	pointer before the bridge is due to release us, and don't release the
      	bridge any more since it now owns us
              (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer,
      	we no longer create the bridge, instead it is passed in
              (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated
      	initializer, but this method is no longer viable and should be deprecated.
              * WebView.subproj/WebFrameInternal.h:
      
      	* WebView.subproj/WebView.m: WebView was changed to hold onto
      	the WebBridge for the main frame instead of the WebFrame.
      
              (-[WebViewPrivate dealloc]): update for the fact that we hold
      	a bridge now, not a frame.
              (-[WebView _close]): ditto
              (-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
      	a bridge, not a frame.
              (-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
              (-[WebView setDefersCallbacks:]): get mainFrame via method
              (-[WebView mainFrame]): Update to get the main frame properly
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c79e17d
    • mjs's avatar
      Rubber stamped by Eric. · bf2dc456
      mjs authored
              - remove the no longer used QIntDict
      
              * kwq/KWQIntDict.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf2dc456
    • ap's avatar
      Reviewed by Eric. · 658b4df8
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5609
                XSLT document() doesn't handle relative paths
      
              Test case: fast/xsl/xslt-relative-path.xml
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs.
              (DOM::XSLTProcessorImpl::transformToString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      658b4df8
    • vicki's avatar
      Reviewed by Maciej. · 07d08035
      vicki authored
      	- fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)
      
      	We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
      	reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
      	mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
      	we fail to fire onmouseout events.  Since the call to passSubframeEventToSubframe was originally added
      	to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
      	on passSubframeEventToSubframe.
      
              * khtml/khtmlview.cpp:
              (KHTMLView::viewportMouseMoveEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d08035
  3. 30 Dec, 2005 21 commits
    • darin's avatar
      Reviewed by Maciej. · 7baeccde
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=4557
                rename unusual strcmp and strcasecmp for DOMString family
      
              Added new functions named equal and equalIgnoringCase.
      
              * khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned
              to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a
              version of the hash function that works on char* to CaseInsensitiveHash as preparation for an
              atomic string change.
              * khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros
              here, and changed them into inline functions.
              (DOM::equal): Implemented.
              (DOM::equalIgnoringCase): Implemented.
              (DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar
              functions.
      
              * khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator
              overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp
              with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
              * khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.
      
              * khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary
              friend declarations. Removed AtomicString::equal. Filled out a larger set of == and
              != operator implementations, mostly with inlines calling through to DOMStringImpl.
              Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
              * khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==.
              Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.
      
              * khtml/html/html_listimpl.cpp:
              (DOM::HTMLOListElementImpl::parseMappedAttribute):
              (DOM::HTMLLIElementImpl::parseMappedAttribute):
              Use the "==" operator instead of strcmp.
      
              * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
              Use equalIgnoringCase instead of equalsIgnoreCase.
      
              * khtml/rendering/render_form.cpp:
              (RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into
              a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also
              used equalIgnoringCase instead of strcasecmp.
              (RenderSlider::slotSliderValueChanged): More of the same.
      
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp
              with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
              (&& binds tighter than ||) which fixes a crash when using a http-equiv pragma when there
              is no part (not sure how to reproduce that).
      
              * khtml/khtml_part.cpp:
              (updateState):
              (KHTMLPart::selectionStartHasStyle):
              * khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
              * khtml/editing/apply_style_command.cpp:
              (khtml::StyleChange::checkForLegacyHTMLStyleChange):
              (khtml::StyleChange::currentlyHasStyle):
              (khtml::hasTextDecorationProperty):
              (khtml::ApplyStyleCommand::extractTextDecorationStyle):
              (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::parseMappedAttribute):
              (HTMLFrameElementImpl::parseMappedAttribute):
              * khtml/html/html_blockimpl.cpp:
              (HTMLDivElementImpl::parseMappedAttribute):
              (HTMLHRElementImpl::parseMappedAttribute):
              (HTMLParagraphElementImpl::parseMappedAttribute):
              (HTMLMarqueeElementImpl::parseMappedAttribute):
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::parseMappedAttribute):
              (HTMLElementImpl::addHTMLAlignment):
              (HTMLElementImpl::setContentEditable):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseMappedAttribute):
              (DOM::HTMLButtonElementImpl::parseMappedAttribute):
              (DOM::HTMLInputElementImpl::setInputType):
              (DOM::HTMLInputElementImpl::parseMappedAttribute):
              (DOM::HTMLKeygenElementImpl::appendFormData):
              (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
              * khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
              * khtml/html/htmlparser.cpp: (HTMLParser::handleError):
              Use equalIgnoringCase instead of strcasecmp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7baeccde
    • ap's avatar
      Reviewed by Darin, landed by ap. · 2734996c
      ap authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
                Text width measured incorrectly when text-align: justify
      
      WebCore:
              * khtml/rendering/font.h:
              * khtml/rendering/font.cpp:
              (khtml::Font::selectionRectForText): Added.
              * khtml/rendering/render_text.cpp:
              (kthml::InlineTextBox::selectionRect): Use selectionRectForText. This
              works for justified text as well, and avoids intermediate rounding which
              resulted in selection rects narrower than AppKit's.
              (khtml::InlineTextBox::positionForOffset): Use selectionRectForText,
              which works for justified text as well.
              * kwq/KWQFontMetrics.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::selectionRectForText): Added.
              * kwq/WebCoreTextRenderer.h:
      
      WebKit:
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
              (CG_drawHighlight): Use new function CG_selectionRect.
              (CG_selectionRect): New function to compute the selection rect.
              Eliminated rounding hackery that was required for keeping the highlight
              rect within the selection rect computed by
              InlineTextBox::selectionRect, since the latter uses this function now.
              The new selection rect is wider and matches AppKit more closely,
              although the right hand side is roundf()ed instead of cielf()ed for
              optimal caret positioning.
              (ATSU_drawHighlight): Use new function ATSU_selectionRect.
              (ATSU_selectionRect): New function to compute the selection rect.
              Much like CG_selectionRect.
      LayoutTests:
              * fast/text/justified-text-rect-expected.checksum: Added.
              * fast/text/justified-text-rect-expected.png: Added.
              * fast/text/justified-text-rect-expected.txt: Added.
              * fast/text/justified-text-rect.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2734996c
    • ap's avatar
      - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6289 · 9bbc4e38
      ap authored
              REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
      
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              Only special-case (0, 0) ranges for empty documents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bbc4e38
    • andersca's avatar
      Forgot to commit this · d166e7a8
      andersca authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d166e7a8
    • eseidel's avatar
      Bug #: 6305 · 963be3ff
      eseidel authored
      Submitted by: eseidel
      Reviewed by: ggaren
              Missing CSS Style sheets in one of the XHTML tests in WebCore
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6305
      
              * fast/parser/entities-in-xhtml.xhtml: removed <link> to css sheet
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      963be3ff
    • ggaren's avatar
      Remove conflict marker from ChangeLog · b9fc7fa2
      ggaren authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9fc7fa2
    • ggaren's avatar
      WebCore: · 3d613f1f
      ggaren authored
              Added test case for <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              * manual-tests/onunload-form-submit-crash.html: Added.
      
      WebKit:
      
              Reviewed by Eric.
      
              Manual testcase added:
              WebCore/manual-tests/onunload-form-submit-crash.html
      
              - Fixed <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              The problem is that the form submission in the unload event kicks off
              a new load in the midst of the load that caused the unload event to
              fire in the first place, so the two loads stomp each other.
      
              The solution is to cancel the first load and let the unload handler's
              load win. (Firefox does the same.)
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
              the call stack to _continueLoadRequest. (See below.) This has the
              side-effect of always firing the unload event, even if the new
              datasource never becomes committed, which seems like a good thing.
      
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
              Call -closeURL here, instead of in _transitionToCommitted,  so that the
              unload handler can fire before we initialize any part of the load.
      
              Check provisionalDataSource for nil to discover if the unload event
              kicked off its own load.
      
              Cleared up some coments.
      
              (-[WebFrame _detachFromParent]):
              It turns out that if you close the window instead of just navigating
              to a new page, you get an alternate assertion failure/crash because
              the load kicked off by the unload event handler generates resource
              loader callbacks after the associated WebFrame/WebView has disappeared.
      
              The nifty solution here is just to reverse the order of calls to
              -stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
              last word when you close a window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d613f1f
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · 79f068c6
      andersca authored
              Reviewed by Eric.
      
      		- Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
              XMLSerializer should use createMarkup
      
              * fast/dom/XMLSerializer.html:
              * fast/dom/XMLSerializer-expected.txt:
              Create a document fragment and serialize it.
      
              * fast/dom/dom-parse-serialize.html:
              * fast/dom/dom-parse-serialize-expected.txt:
              Add some entities to attributes and text nodes.
      
              * fast/xsl/xslt-processer-expected.txt:
              Update test results.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f068c6
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · e1be1a16
      andersca authored
              Reviewed by Eric.
      
      		- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
      		XMLSerializer should use createMarkup.
      
              * khtml/ecma/xmlserializer.cpp:
              (KJS::XMLSerializerProtoFunc::callAsFunction):
      		Use createMarkup instead of NodeImpl::toString.
      
              * khtml/editing/markup.cpp:
              (khtml::startMarkup):
      		escape attribute values and ignore document fragment nodes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1be1a16
    • mjs's avatar
      No review, just test result update. · bb900e13
      mjs authored
              * tests/mozilla/expected.html: Updated for newly passing test from recent fixes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb900e13
    • eseidel's avatar
      Bug #: 6299 · a55f252f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              No functional changes, thus no layout test.
      
              Just removes debug NSLog() calls from ksvg2/kcanvas.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6299
      
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (KCanvasFilterQuartz::prepareFilter):
              (KCanvasFilterQuartz::applyFilter):
              (KCanvasFilterQuartz::getCIFilterStack):
              (KCanvasFilterQuartz::imageForName):
              (KCanvasFEBlendQuartz::getCIFilter):
              (KCanvasFEColorMatrixQuartz::getCIFilter):
              (KCanvasFEGaussianBlurQuartz::getCIFilter):
              * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
              (KCanvasClipperQuartz::applyClip):
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              (KRenderingDeviceContextQuartz::mapFromVisual):
              (KRenderingDeviceContextQuartz::mapToVisual):
              (KRenderingDeviceQuartz::createResource):
              (KRenderingDeviceQuartz::createFilterEffect):
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              (drawShadingWithStyle):
              (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              (KRenderingPaintServerPatternQuartz::draw):
              * ksvg2/svg/svgpathparser.cpp:
              (SVGPathParser::parseSVG):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a55f252f
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · 2a90f8ff
      andersca authored
              Reviewed by Maciej.
      
      		- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6298
      		Getter setter test is failing
      
              * kjs/object.cpp:
              (KJS::JSObject::put):
      		Rework the getter setter part. We now walk the prototype chain, checking for
      		getter/setter properties and only take the slow path if any are found.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a90f8ff
    • eseidel's avatar
      Bug #: none · a4aa18fc
      eseidel authored
      Submitted by: eseidel
      Reviewed by: No review, just adding a couple missing results.
              One missing pixel test.
              One result which never was updated properly after rounded rect fix:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
              * fast/parser/xhtml-alternate-entities-expected.checksum: Added.
              * fast/parser/xhtml-alternate-entities-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aa18fc
    • mjs's avatar
      Reviewed by Darin, landed by Maciej. · 6b58eda1
      mjs authored
      	- land test case documenting wontfix status for certain overflow/table behavior
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=3505
      
              * fast/overflow/overflow-auto-table-expected.checksum: Added.
              * fast/overflow/overflow-auto-table-expected.png: Added.
              * fast/overflow/overflow-auto-table-expected.txt: Added.
              * fast/overflow/overflow-auto-table.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b58eda1
    • eseidel's avatar
      Bug #: none · 349332ec
      eseidel authored
      Submitted by: eseidel
      Reviewed by: none, just updating stale results
              No review, updating stale results.
              I went over all the interesting ones with mjs and hyatt.
      
              * css2.1/t040304-c64-uri-00-a-g-expected.checksum:
              * css2.1/t040304-c64-uri-00-a-g-expected.png:
              * css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
              * css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
              * css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
              * css2.1/t100801-c544-valgn-02-d-agi-expected.png:
              * dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum:
              * dom/xhtml/level2/html/HTMLBaseElement02-expected.png:
              * dom/xhtml/level2/html/frame-expected.checksum:
              * dom/xhtml/level2/html/frame-expected.png:
              * dom/xhtml/level2/html/iframe-expected.checksum:
              * dom/xhtml/level2/html/iframe-expected.png:
              * editing/selection/extend-by-word-002-expected.checksum:
              * editing/selection/extend-by-word-002-expected.png:
              * fast/css/imageTileOpacity-expected.checksum:
              * fast/css/imageTileOpacity-expected.png:
              * fast/forms/001-expected.checksum:
              * fast/forms/001-expected.png:
              * fast/frames/empty-frame-src-expected.checksum:
              * fast/frames/empty-frame-src-expected.png:
              * fast/frames/invalid-expected.checksum:
              * fast/frames/invalid-expected.png:
              * fast/frames/valid-expected.checksum:
              * fast/frames/valid-expected.png:
              * svg/custom/conditional-processing-outside-switch-expected.txt:
              * svg/custom/control-points-for-S-and-T-expected.txt:
              * svg/custom/fill-update-expected.txt:
              * svg/custom/junk-data-expected.txt:
              * svg/custom/missing-xlink-expected.txt:
              * svg/custom/path-bad-data-expected.txt:
              * svg/custom/path-update-expected.txt:
              * svg/custom/simpleCDF-expected.txt:
              * svg/custom/transform-ignore-after-invalid-expected.txt:
              * svg/custom/transform-invalid-expected.txt:
              * svg/custom/transform-with-ending-space-expected.txt:
              * svg/custom/use-forward-refs-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      349332ec
    • mjs's avatar
      No review. · 21d8bcb5
      mjs authored
      	- updated test results for Number.toString() fixes:
      	<http://bugzilla.opendarwin.org/show_bug.cgi?id=6259>
      
              * fast/js/kde/Number-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21d8bcb5
    • mjs's avatar
      Reviewed and committed by Maciej. · b98d7720
      mjs authored
      	- Handle negative, FP numbers with non-10 radix in toString
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6259
      
              (Merged from KJS, original work by Harri Porten)
      
              * kjs/number_object.cpp:
              (NumberProtoFunc::callAsFunction): rewrote Number.toString(radix) to work with
      	negative numbers, floating point and very large numbers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b98d7720
    • eseidel's avatar
      Bug #: 6155 · 1ca0b85a
      eseidel authored
      Submitted by: eseidel
      Reviewed by: none, just updating pixel results
              Updating results, after landing color-matching change.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
      
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
              * svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
              * svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
              * svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
              * svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
              * svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
              * svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
              * svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
              * svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
              * svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
              * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
              * svg/custom/conditional-processing-outside-switch-expected.checksum:
              * svg/custom/conditional-processing-outside-switch-expected.png:
              * svg/custom/control-points-for-S-and-T-expected.checksum:
              * svg/custom/control-points-for-S-and-T-expected.png:
              * svg/custom/fill-update-expected.checksum:
              * svg/custom/fill-update-expected.png:
              * svg/custom/junk-data-expected.checksum:
              * svg/custom/junk-data-expected.png:
              * svg/custom/missing-xlink-expected.checksum:
              * svg/custom/missing-xlink-expected.png:
              * svg/custom/path-bad-data-expected.checksum:
              * svg/custom/path-bad-data-expected.png:
              * svg/custom/path-update-expected.checksum:
              * svg/custom/path-update-expected.png:
              * svg/custom/simpleCDF-expected.checksum:
              * svg/custom/simpleCDF-expected.png:
              * svg/custom/simpleCDF-expected.txt:
              * svg/custom/transform-ignore-after-invalid-expected.checksum:
              * svg/custom/transform-ignore-after-invalid-expected.png:
              * svg/custom/transform-ignore-after-invalid.svg:
              * svg/custom/transform-invalid-expected.checksum:
              * svg/custom/transform-invalid-expected.png:
              * svg/custom/transform-with-ending-space-expected.checksum:
              * svg/custom/transform-with-ending-space-expected.png:
              * svg/custom/use-forward-refs-expected.checksum:
              * svg/custom/use-forward-refs-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ca0b85a
    • eseidel's avatar
      Bug #: 6157 · 3b8950ef
      eseidel authored
      Submitted by: rob buis
      Reviewed by: eseidel
              WebCore+SVG has some problems with rounded rectangles
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * svg/custom/rounded-rects-expected.checksum: Added.
              * svg/custom/rounded-rects-expected.png: Added.
              * svg/custom/rounded-rects-expected.txt: Added.
              * svg/custom/rounded-rects.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b8950ef
    • mjs's avatar
      Reviewed by Eric, committed by Maciej. · 075676e6
      mjs authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6288
                HEAD build broken 12/29/2005
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (overrideLayoutOperation): Use previous character from the buffer
              instead of ch which may be uninitialized on the first iteration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075676e6
    • eseidel's avatar
      Bug #: none · 91bbfdc6
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Move WebView width/height logic into DumpRenderTree to support
              running the W3C SVG 1.1 tests along side other tests.  The W3C
              SVG 1.1 tests require a 480x360 view.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): don't accept width/height
              (dump): override width/height for SVG/W3C
              * Scripts/run-webkit-tests: don't pass width/height
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91bbfdc6
  4. 29 Dec, 2005 14 commits
    • darin's avatar
      LayoutTests: · c230576d
      darin authored
              Reviewed and refined by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
              * fast/css/margin-top-bottom-dynamic-expected.png: Added.
              * fast/css/margin-top-bottom-dynamic-expected.txt: Added.
              * fast/css/margin-top-bottom-dynamic.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues):
              Set all margin values in all cases.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c230576d
    • eseidel's avatar
      Bug #: none · b990c07f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: No review, only removing dead code.
              * DumpKCanvasTree/DumpKCanvasTree.m: Removed.
              * DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b990c07f
    • eseidel's avatar
      Bug #: 6155 · e79fa87d
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              DumpRenderTree should set a consistent color profile while running
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
      
              Creates consistent colormatched renderings on every test machine
              using the only way possible with Tiger APIs: by setting the
              system color profile on the test machine for the duration of the
              tests.  This will (unfortunately) cause colors to change while
              running DumpRenderTree.  This can also cause "permanent" color
              changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
              This is far from ideal, but it's be best way we've found to deal
              with the issue for now.
      
              * DumpRenderTree/DumpRenderTree.m:
              (restoreColorSpace):
              (setDefaultColorProfileToRGB):
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e79fa87d
    • eseidel's avatar
      Bug #: 6290 · d67c400f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              XML documents with "html" in dtd name use XHTML entities when they shouldn't
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
      
              * fast/parser/xhtml-alternate-entities-expected.txt: Added.
              * fast/parser/xhtml-alternate-entities.xml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d67c400f
    • eseidel's avatar
      Bug #: 6290 · 1fda09d0
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              XML documents with "html" in dtd name use XHTML entities when they shouldn't
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
      
              * khtml/xml/xml_tokenizer.cpp:
              (khtml::externalSubsetHandler): check for exact xhtml types
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fda09d0
    • eseidel's avatar
      Bug #: 6295 · ab66b6b1
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Close leak in CollectionInfo due to HashMap migration
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab66b6b1
    • eseidel's avatar
      Bug #: 6101 · bf437b45
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Leaks in XSLTProcessorImpl due to early exit in failure case
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6101
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::xmlDocPtrFromNode): add "shouldDelete" argument
              (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf437b45
    • mjs's avatar
      WebCore: · 6b709be4
      mjs authored
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol
      	since it is not actually used.
      
      WebKit:
      
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge childFrames]): Removed (this was unused)
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _removeChild::]): Moved to FrameTraversal category.
              (-[WebFrame _childFrameCount]): New frame traversal method to avoid
      	getting the count from the array directly.
              (-[WebFrame _appendChild:]): Factored out the parts of addChild: that
      	seem directly relevant to adding a child.
              (-[WebFrame _removeChild:]): Moved to FrameTraversal category.
              (-[WebFrame _detachChildren]): Don't deallocate children array because
      	there's no particular need to.
              (-[WebFrame _setDataSource:]): make the assert use _childFrameCount
              (-[WebFrame _opened]):
              (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
      	from the main frame, check this frame and all ancestors. If a resource
      	for a frame completes, that con only possibly finish loading for that
      	frame and its ancestors, not any other frame in the tree.
      	(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
              (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new
      	approved way.
              (-[WebFrame _internalChildFrames]): removed
      	(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
              (-[WebFrame _generateFrameName]): Get child frame count in the new
      	approved way.
              (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
      	upon further consideration there's no need to copy part of the frame tree here.
              (-[WebFrame findFrameNamed:]): Remove extra braces.
              (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
              * WebView.subproj/WebFramePrivate.h: Remove some methods.
              * WebView.subproj/WebMainResourceLoader.m:
              (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
      	frame not the main frame (before there was no difference and now the new version is
      	what is desired).
              * WebView.subproj/WebView.m:
              (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
              (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
      	and update FIXME comment.
              (-[WebView _receivedError:fromDataSource:]): Remove stray space
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b709be4
    • eseidel's avatar
      Bug #: 6230 · 07480eea
      eseidel authored
      Submitted by: eseidel
      Reviewed by: build fix only.
              File accidentally omitted from previous commit.
      
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::HTMLCollection::getNamedItems):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07480eea
    • eseidel's avatar
      Bug #: 6230 · 31504afb
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
              Uses HashMap instead.
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
              (DOM::HTMLCollectionImpl::CollectionInfo::reset):
              (DOM::HTMLCollectionImpl::namedItem):
              (DOM::HTMLCollectionImpl::updateNameCache):
              (DOM::HTMLCollectionImpl::namedItems):
              (DOM::HTMLCollectionImpl::nextNamedItem):
              (DOM::HTMLFormCollectionImpl::nextNamedItemInternal):
              (DOM::HTMLFormCollectionImpl::updateNameCache):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31504afb
    • eseidel's avatar
      Bug #: 6228 · ccbf3d76
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
              Added find(), contains(), startsWith() and endsWith() to DOMString
              Uses the above functions throughout the code.
              Small performance boost.
      
              * khtml/css/css_base.cpp:
              (CSSSelector::print):
              * khtml/css/css_ruleimpl.cpp:
              (DOM::CSSImportRuleImpl::init):
              * khtml/css/css_valueimpl.cpp:
              (DOM::CSSStyleDeclarationImpl::setProperty):
              * khtml/css/cssparser.cpp:
              (CSSParser::parseValue):
              (CSSParser::parseDeclaration):
              (CSSParser::parseContent):
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::CSSStyleSelector):
              (khtml::CSSStyleSelector::setEncodedURL):
              (khtml::parseUASheet):
              (khtml::cleanpath):
              (khtml::CSSStyleSelector::checkSelector):
              (khtml::CSSStyleSelector::checkOneSelector):
              (khtml::CSSRuleSet::addRulesFromSheet):
              (khtml::CSSStyleSelector::applyProperty):
              * khtml/dom/dom_string.cpp:
              * khtml/dom/dom_string.h:
              (DOM::DOMString::contains):
              (DOM::DOMString::find):
              (DOM::DOMString::startsWith):
              (DOM::DOMString::endsWith):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseEnctype):
              * khtml/khtml_part.cpp:
              (KHTMLPart::requestFrame):
              (KHTMLPart::submitForm):
              * khtml/misc/decoder.cpp:
              (Decoder::decode):
              * khtml/xml/dom_atomicstring.h:
              (DOM::AtomicString::length):
              (DOM::AtomicString::operator []):
              (DOM::AtomicString::contains):
              (DOM::AtomicString::find):
              (DOM::AtomicString::startsWith):
              (DOM::AtomicString::endsWith):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::processHttpEquiv):
              * khtml/xml/dom_stringimpl.cpp:
              (DOM::equal):
              (DOM::equalCaseInsensitive):
              (DOM::DOMStringImpl::find):
              (DOM::DOMStringImpl::endsWith):
              * khtml/xml/dom_stringimpl.h:
              (DOM::DOMStringImpl::startsWith):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccbf3d76
    • eseidel's avatar
      Bug #: 6157 · b401952a
      eseidel authored
      Submitted by: rob buis
      Reviewed by: eseidel
              WebCore+SVG has some problems with rounded rectangles
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * ksvg2/svg/SVGRectElementImpl.cpp:
              (SVGRectElementImpl::toPathData): fixed round rect calculations
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b401952a
    • eseidel's avatar
      Bug #: 4301 · eee032ed
      eseidel authored
      Submitted by: mark rowe
      Reviewed by: eseidel
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
              Support HTML entities on pages parsed as XHTML
      
              * fast/parser/entities-in-xhtml-expected.txt: Added.
              * fast/parser/entities-in-xhtml.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eee032ed
    • ggaren's avatar
      Updated test results for the last few JavaScriptCore patches · 38688496
      ggaren authored
              I checked in.
      
              * ChangeLog:
              * fast/js/array-float-delete-expected.txt: Added.
              * fast/js/kde/Date-expected.txt:
              * fast/js/kde/Number-expected.txt:
              * fast/js/kde/StringObject-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38688496