1. 30 May, 2012 1 commit
  2. 29 May, 2012 39 commits
    • pilgrim@chromium.org's avatar
      [Chromium] Move fileExists to Platform.h · 679dda06
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87531
      
      Reviewed by Adam Barth.
      
      Call fileExists through fileUtilities(), not directly.
      
      Source/Platform:
      
      * chromium/public/Platform.h:
      (Platform):
      
      Source/WebCore:
      
      * platform/chromium/FileSystemChromium.cpp:
      (WebCore::fileExists):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      679dda06
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update. · e647161d
      tkent@chromium.org authored
      Rebaseline for placeholder-related tests.
      
      * platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
      * platform/chromium-linux/fast/forms/search-styled-expected.txt:
      * platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-leopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-leopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
      * platform/chromium-mac/fast/css/text-overflow-input-expected.png:
      * platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
      * platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
      * platform/chromium-win/fast/css/text-overflow-input-expected.txt:
      * platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
      * platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
      * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
      * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/chromium-win/fast/forms/search-styled-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
      * platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e647161d
    • haraken@chromium.org's avatar
      Remove a dummy style sheet from CSSParser::parseFlowThread() · 57950234
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87715
      
      Reviewed by Darin Adler.
      
      r118736 changed CSSGrammar.y so that it works fine with no style sheet.
      r118736 removed a dummy style sheet from CSSParser::parserSelector().
      Now we can safely remove a dummy style sheet from parserFlowThread().
      
      Tests: fast/regions. No change in test results.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlowThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57950234
    • yosin@chromium.org's avatar
      REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled · db050d73
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87719
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      This patch added checking of "option" element for CSS pseudo class :enabled as same as
      :disabled to selector checker. Before r111497, it was done by using isFormControlElement.
      After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.
      
      Test: fast/form/select/optgroup-rendering.html
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
      as PseudoDisabled in PseudoEnabled case.
      
      LayoutTests:
      
      * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
      * platform/chromium/test_expectations.txt: Update comment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db050d73
    • hayato@chromium.org's avatar
      Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker. · b7d6f802
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87004
      
      Reviewed by Dimitri Glazkov.
      
      Introduces a ComposedShadowTreeParentWalker, which is only used
      for traversing a parent node (including shadow roots and insertion
      points) and get rid of an equivalent function from
      ComposedShadowTreeWalker.
      
      Before this patch, there is an inconsistency inside of
      ComposedShadowTreeWalker. The Walker uses 'Policy' to decide
      whether it should visit shadow roots or not, but
      parentIncludingInsertionPointAndShadowRoot() member function
      ignores the policy.  We can not add an assertion in its
      constructor due to this inconsistency.  To resolve it, we could
      add yet another special policy, but that makes the implementation
      complex and may add some overhead in runtime.  So separate the
      functionality into another class as ComposedShadowTreeParentWalker.
      
      No new tests, no new functionality except for assertion.
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
      (WebCore::ComposedShadowTreeParentWalker::ComposedShadowTreeParentWalker):
      (WebCore):
      (WebCore::ComposedShadowTreeParentWalker::parentIncludingInsertionPointAndShadowRoot):
      (WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):
      * dom/ComposedShadowTreeWalker.h:
      (ComposedShadowTreeWalker):
      (WebCore::ComposedShadowTreeWalker::assertPrecondition):
      (WebCore):
      (ComposedShadowTreeParentWalker):
      (WebCore::ComposedShadowTreeParentWalker::get):
      * dom/EventDispatcher.cpp:
      (WebCore::EventRelatedTargetAdjuster::adjust):
      (WebCore::EventDispatcher::ensureEventAncestors):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateMouseEventTargetNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7d6f802
    • hayato@chromium.org's avatar
      Add assertions to make sure that event's target and relatedTarget are accessible. · cfba43b6
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87641
      
      Reviewed by Dimitri Glazkov.
      
      No new tests. No new functionality except for assertions.
      
      * dom/EventContext.cpp:
      (WebCore::EventContext::EventContext):
      * dom/EventContext.h:
      (WebCore):
      (EventContext):
      (WebCore::EventContext::setRelatedTarget):
      (WebCore::EventContext::accessible):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfba43b6
    • tkent@chromium.org's avatar
      Fix inefficient usage of traverseNextNode() · 560ec954
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87804
      
      Reviewed by Ryosuke Niwa.
      
      foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
      firstChild() is more efficient.
      
      No new tests because of no behavior change.
      
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
      Replace traverseNextNode() with firstChild(), and shorten a variable name.
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      Replace traverseNextNode() with firstChild().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      560ec954
    • commit-queue@webkit.org's avatar
      [BlackBerry] Loading media data with http authentication · 54f7a01f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84214
      
      Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
      Reviewed by George Staikos.
      
      .:
      
      Added a manual test case which needs user to provide a HTTP server
      with HTTP authentication support when loading the specified media
      resource. The test case will test if the media resource is successfully
      loaded.
      
      * ManualTests/blackberry/video-load-with-authentication.html: Added.
      
      Source/WebCore:
      
      RIM PR: 117618
      Implemented http authentication feature for media by implementing
      two interface functions in class MediaPlayerPrivate:
      onAuthenticationNeeded(): this function is triggered when MMR
      engine requires http authentication. We search the CredentialStorage
      to see if we have already stored existing credential information,
      or challenge user to provide it.
      OnAuthenticationAccepted(): this function is triggered when MMR
      engine accepts the credential information, and we need to save
      it in CredentialStorage for later use.
      
      Internally reviewed by Max Feil <mfeil@qnx.com>.
      
      Manual test case: blackberry/video-load-with-authentication.html
      
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::generateProtectionSpaceFromMMRAuthChallenge):
      (WebCore):
      (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
      (WebCore::MediaPlayerPrivate::onAuthenticationAccepted):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f7a01f
    • morrita@google.com's avatar
      [Shadow DOM] Node distribution should be orthogonal from node attachment · 89c8aeea
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87223
      
      Reviewed by Dimitri Glazkov.
      
      This chagne reorganizes Shadow DOM subtree distribution implementation.
      
      Originally, it was interleaved across attach() of several classes like
      InsertionPoint and ShadowRoot. Its invalidation was also mixed as a part of
      the style recalculation and detach()-es.
      
      This change extracts these bits of code to a set of ContentDistributor methods, which are
      facaded by two ElementShadow API. Following two API are the primary entry points:
      
      - ElementShadow::ensureDistribution()
      - ElementShadow::invalidateDistribution()
      
      The actual implementations are ContentDistributor::distribute() and
      ContentDistributor::invalidate() respectively.
      
      When clients need to traverse composed tree, before attach() for
      example, they should call ensureDistribution() to make sure that
      the traversal data structure ("the distribution") is ready.  When
      there is any DOM mutation which can result a composed tree
      mutation, then clients should call invalidateDistribution() to
      mark the distribution being dated.
      
      Here are such DOM mutations:
      
      - The children of any ShadowRoots are changed,
      - The children of any InsertionPoints are changed,
      - The children of any host elements are changed,
      - Any insertion point is inserted to or removed from the shadow tree,
      - @select attribute of <content> is modified and
      - New ShadowRoot is added to the shadow tree.
      
      Note that the validity of the distribution is tracked and
      unnecessary distribution requests are ignored.
      
      After the invalidation, that shadow subtrees are detached once and
      request  their  re-attachment  through  the  style  recalculation.
      Then,  on the  responding  style recalculation  and attach(),  new
      distribution will be computed.
      
      No new tests. Covered by existing tests.
      
      * dom/Element.cpp:
      (WebCore::Element::~Element):
      (WebCore::Element::childrenChanged):
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::~ElementShadow):
      (WebCore::ElementShadow::addShadowRoot):
      (WebCore::ElementShadow::removeAllShadowRoots):
      (WebCore::ElementShadow::attach):
      (WebCore::ElementShadow::recalcStyle):
      (WebCore::ElementShadow::ensureDistribution):
      (WebCore::ElementShadow::invalidateDistribution):
      * dom/ElementShadow.h:
      (ElementShadow):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRendererFactory::createRendererIfNeeded):
      * dom/NodeRenderingContext.h:
      (NodeRenderingContext):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::setApplyAuthorStyles):
      (WebCore::ShadowRoot::attach):
      (WebCore::ShadowRoot::childrenChanged):
      (WebCore):
      * dom/ShadowRoot.h:
      (ShadowRoot):
      * html/HTMLFormControlElement.cpp:
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ContentDistributor):
      (WebCore::ContentDistributor::~ContentDistributor):
      (WebCore::ContentDistributor::findInsertionPointFor):
      (WebCore::ContentDistributor::distribute):
      (WebCore::ContentDistributor::invalidate):
      (WebCore::ContentDistributor::finishInivalidation):
      (WebCore::ContentDistributor::distributeSelectionsTo):
      (WebCore::ContentDistributor::distributeShadowChildrenTo):
      (WebCore::ContentDistributor::invalidateDistributionIn):
      * html/shadow/ContentDistributor.h:
      (WebCore::ContentDistributor::needsInvalidation):
      (ContentDistributor):
      (WebCore::ContentDistributor::needsDistribution):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::parseAttribute):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::attach):
      (WebCore::InsertionPoint::detach):
      (WebCore::InsertionPoint::nextTo):
      (WebCore::InsertionPoint::previousTo):
      (WebCore::InsertionPoint::childrenChanged):
      * html/shadow/InsertionPoint.h:
      (WebCore::InsertionPoint::setDistribution):
      (WebCore::InsertionPoint::clearDistribution):
      (InsertionPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89c8aeea
    • macpherson@chromium.org's avatar
      Implement post-landing feedback for WebKitCSSTransformValue::customCSSText(). · a9073a12
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87684
      
      Reviewed by Darin Adler.
      
      Darin provided some style suggesting on https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
      This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
      and WTF_ARRAY_LENGTH instead of hard coding the array length.
      
      Covered by existing transform tests.
      
      * css/WebKitCSSTransformValue.cpp:
      (WebCore):
      (WebCore::WebKitCSSTransformValue::customCssText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9073a12
    • ojan@chromium.org's avatar
      Add a linter error for pngs that lack an embedded checksum · a6a6a184
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87793
      
      Reviewed by Dirk Pranke.
      
      * Scripts/read-checksum-from-png:
      * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
      (read_checksum):
      * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
      (ReadChecksumFromPngTest):
      (ReadChecksumFromPngTest.test_read_checksum):
      * Scripts/webkitpy/layout_tests/port/base.py:
      * Scripts/webkitpy/style/checkers/png.py:
      (PNGChecker.check):
      * Scripts/webkitpy/style/checkers/png_unittest.py:
      (PNGCheckerTest.test_check):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6a6a184
    • eric@webkit.org's avatar
      Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless> · 8fe1b21c
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87646
      
      Reviewed by Adam Barth.
      
      In the process of moving the seamless feature out of github and into bugs.webkit.org
      multiple versions of the shouldDisplaySeamlessly function got written
      (and moved from HTMLIFrameElement to Document), but only one of them was wrapped
      in ENABLE_IFRAME_SEAMLESS.  HTMLIFrameElement was checking mayDisplaySeamlessly
      directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
      I've fixed this oversight, and the feature is now off when we tell it to be off.
      
      This is covered by many existing tests.  I've verified locally that
      all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
      only some of them.
      
      * dom/SecurityContext.h:
      (SecurityContext):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fe1b21c
    • ojan@chromium.org's avatar
      Show an error in the pretty diff when an image lacks a checksum · 26eac78b
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87791
      
      Reviewed by Dirk Pranke.
      
      * PrettyPatch/PrettyPatch.rb:
      * PrettyPatch/PrettyPatch_test.rb:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26eac78b
    • hayato@chromium.org's avatar
      Refactor shadow-dom-event-dispatching.html. · 05d904c9
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87626
      
      Reviewed by Dimitri Glazkov.
      
      There are badly named functions in shadow-dom-event-dispatching.html.
      e.g. prepareDOMTree1, prepareDOMTree2 and so on.
      That should have better namings which make the intention of each test clear.
      
      * fast/dom/shadow/shadow-dom-event-dispatching.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05d904c9
    • commit-queue@webkit.org's avatar
      Fix warning in preprocessing Source/WebCore/dom/DOMError.idl · bfdb5d3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87763
      
      Patch by Scott Graham <scottmg@chromium.org> on 2012-05-29
      Reviewed by Adam Barth.
      
      Add newline at end of file to avoid warning:
      ../dom/DOMError.idl:35:2: warning: no newline at end of file
      
      * dom/DOMError.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdb5d3a
    • pilgrim@chromium.org's avatar
      [Chromium] Move fileExists to Platform.h · d2d85ea7
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87531
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/Platform:
      
      * chromium/public/Platform.h:
      (WebKit::Platform::fileExists):
      (Platform):
      
      Source/WebCore:
      
      * platform/chromium/FileSystemChromium.cpp:
      (WebCore::fileExists):
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      
      Source/WebKit/chromium:
      
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2d85ea7
    • rakuco@webkit.org's avatar
      [EFL] Gardening after r118845 and r118851. · 162fff5c
      rakuco@webkit.org authored
      Apparently some baselines were not updated as expected, fixing
      that now.
      
      * platform/efl/fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * platform/efl/fast/ruby/ruby-text-before-after-content-expected.txt:
      * platform/efl/fast/selectors/166-expected.png:
      * platform/efl/fast/selectors/166-expected.txt:
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
      * platform/efl/svg/batik/text/textAnchor-expected.txt:
      * platform/efl/svg/batik/text/textOnPath3-expected.txt:
      * platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
      * platform/efl/svg/carto.net/tabgroup-expected.txt:
      * platform/efl/transitions/cross-fade-background-image-expected.txt: Added.
      * platform/efl/transitions/cross-fade-border-image-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      162fff5c
    • ggaren@apple.com's avatar
      Rolled back in r118646, now that · 15344ae6
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87784 is fixed.
      
      http://trac.webkit.org/changeset/118646
      https://bugs.webkit.org/show_bug.cgi?id=87599
      
      * heap/Heap.cpp:
      (JSC::Heap::collect):
      * heap/MarkedBlock.cpp:
      (JSC::MarkedBlock::sweep):
      * heap/MarkedBlock.h:
      (JSC):
      * heap/MarkedSpace.cpp:
      (JSC):
      * heap/MarkedSpace.h:
      (MarkedSpace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15344ae6
    • haraken@chromium.org's avatar
      [V8] Rename v8Null() to v8NullWithCheck() · 883bb54d
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87713
      
      Reviewed by Adam Barth.
      
      In IRC, cmarcelo@ pointed out that v8::Null() and v8Null()
      are confusing. This patch renames v8Null() to v8NullWithCheck().
      
      No tests. No behavior change.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventConstructor.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventTarget.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestException.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestInterface.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNamedConstructor.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNode.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestObj.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
      (WebCore::toV8):
      * bindings/v8/V8Binding.h:
      (WebCore::v8NullWithCheck):
      (WebCore::v8DateOrNull):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      883bb54d
    • commit-queue@webkit.org's avatar
      Some Content Security Policy console messages are missing line numbers in JSC · 24a70122
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87558
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-29
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Make ScriptController::eventHandlerPosition() behave the same way on
      JSC than V8. This means that TextPosition::minimumPosition() is
      returned if parser is null, instead of
      TextPosition::belowRangePosition(). The line numbers are now correctly
      printed in the output of Content Security Policy tests.
      
      Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
             http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
      
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::eventHandlerPosition):
      
      LayoutTests:
      
      Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
      tests now that the line numbers are correctly printed.
      
      * platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24a70122
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=87720 · c0599cb0
      slewis@apple.com authored
      WebProcess is often killed due to being unresponsive on the bots
      
      Reviewed by Alexey Proskuryakov.
      
      Blind attempt to improve flakiness on the bots by reducing the number
      of crashes due to an unresponsive process.  This helped on my personal machine
      under stress conditions.  I don't have enough cores to hit the problem
      under normal conditions.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0599cb0
    • andersca@apple.com's avatar
      String should be move enabled/optimized · 372f7d24
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87596
      
      Reviewed by Andreas Kling.
      
      Add move constructors and move assignment operators to String and AtomicString when building with
      compilers that support rvalue references. This gets rid of ref-churn when the source of the
      constructor or assignment is a temporary object.
      
      * wtf/text/AtomicString.h:
      (AtomicString):
      (WTF::AtomicString::AtomicString):
      (WTF::AtomicString::operator=):
      * wtf/text/WTFString.h:
      (String):
      (WTF::String::String):
      (WTF::String::operator=):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      372f7d24
    • fpizlo@apple.com's avatar
      DFG should keep captured variables alive until the (inline) return. · 4c0875e8
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87205
      
      Source/JavaScriptCore: 
      
      Reviewed by Gavin Barraclough.
              
      Changes the way we do flushing for captured variables and arguments. Instead of flushing
      each SetLocal immediately, we flush at kill points. So a SetLocal will cause a Flush of
      whatever was live in the variable previously, and a return will cause a Flush of all
      captured variables and all arguments.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::setDirect):
      (JSC::DFG::ByteCodeParser::set):
      (JSC::DFG::ByteCodeParser::setLocal):
      (JSC::DFG::ByteCodeParser::getArgument):
      (JSC::DFG::ByteCodeParser::setArgument):
      (JSC::DFG::ByteCodeParser::findArgumentPositionForArgument):
      (ByteCodeParser):
      (JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
      (JSC::DFG::ByteCodeParser::findArgumentPosition):
      (JSC::DFG::ByteCodeParser::flush):
      (JSC::DFG::ByteCodeParser::flushDirect):
      (JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
      (JSC::DFG::ByteCodeParser::handleInlining):
      (JSC::DFG::ByteCodeParser::parseBlock):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::setLocalStoreElimination):
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
      
      LayoutTests: 
      
      Reviewed by Gavin Barraclough.
      
      * fast/js/dfg-inline-arguments-osr-exit-and-capture-expected.txt: Added.
      * fast/js/dfg-inline-arguments-osr-exit-and-capture.html: Added.
      * fast/js/script-tests/dfg-inline-arguments-osr-exit-and-capture.js: Added.
      (foo):
      (bar):
      (baz):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c0875e8
    • shawnsingh@chromium.org's avatar
      [chromium] make WebTransformationMatrix object usable by non-webkit code · 4e1a16f4
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87315
      
      Reviewed by James Robinson.
      
      Source/Platform:
      
      * chromium/public/WebTransformationMatrix.h:
      (WebKit::WebTransformationMatrix::~WebTransformationMatrix):
      (WebTransformationMatrix):
      
      Source/WebCore:
      
      This change is covered by existing tests and by whether it
      compiles. There should be no changes in behavior.
      
      * platform/chromium/support/WebTransformationMatrix.cpp:
      (WebKit::WebTransformationMatrix::WebTransformationMatrix):
      (WebKit::WebTransformationMatrix::operator=):
      (WebKit::WebTransformationMatrix::operator==):
      (WebKit::WebTransformationMatrix::inverse):
      (WebKit::WebTransformationMatrix::to2dTransform):
      (WebKit::WebTransformationMatrix::multiply):
      (WebKit::WebTransformationMatrix::makeIdentity):
      (WebKit::WebTransformationMatrix::translate):
      (WebKit::WebTransformationMatrix::translate3d):
      (WebKit::WebTransformationMatrix::translateRight3d):
      (WebKit::WebTransformationMatrix::scale):
      (WebKit::WebTransformationMatrix::scaleNonUniform):
      (WebKit::WebTransformationMatrix::scale3d):
      (WebKit::WebTransformationMatrix::rotate):
      (WebKit::WebTransformationMatrix::rotate3d):
      (WebKit::WebTransformationMatrix::skewX):
      (WebKit::WebTransformationMatrix::skewY):
      (WebKit::WebTransformationMatrix::applyPerspective):
      (WebKit::WebTransformationMatrix::blend):
      (WebKit::WebTransformationMatrix::hasPerspective):
      (WebKit::WebTransformationMatrix::isInvertible):
      (WebKit::WebTransformationMatrix::isBackFaceVisible):
      (WebKit::WebTransformationMatrix::isIdentity):
      (WebKit::WebTransformationMatrix::isIdentityOrTranslation):
      (WebKit::WebTransformationMatrix::isIntegerTranslation):
      (WebKit::WebTransformationMatrix::m11):
      (WebKit::WebTransformationMatrix::setM11):
      (WebKit::WebTransformationMatrix::m12):
      (WebKit::WebTransformationMatrix::setM12):
      (WebKit::WebTransformationMatrix::m13):
      (WebKit::WebTransformationMatrix::setM13):
      (WebKit::WebTransformationMatrix::m14):
      (WebKit::WebTransformationMatrix::setM14):
      (WebKit::WebTransformationMatrix::m21):
      (WebKit::WebTransformationMatrix::setM21):
      (WebKit::WebTransformationMatrix::m22):
      (WebKit::WebTransformationMatrix::setM22):
      (WebKit::WebTransformationMatrix::m23):
      (WebKit::WebTransformationMatrix::setM23):
      (WebKit::WebTransformationMatrix::m24):
      (WebKit::WebTransformationMatrix::setM24):
      (WebKit::WebTransformationMatrix::m31):
      (WebKit::WebTransformationMatrix::setM31):
      (WebKit::WebTransformationMatrix::m32):
      (WebKit::WebTransformationMatrix::setM32):
      (WebKit::WebTransformationMatrix::m33):
      (WebKit::WebTransformationMatrix::setM33):
      (WebKit::WebTransformationMatrix::m34):
      (WebKit::WebTransformationMatrix::setM34):
      (WebKit::WebTransformationMatrix::m41):
      (WebKit::WebTransformationMatrix::setM41):
      (WebKit::WebTransformationMatrix::m42):
      (WebKit::WebTransformationMatrix::setM42):
      (WebKit::WebTransformationMatrix::m43):
      (WebKit::WebTransformationMatrix::setM43):
      (WebKit::WebTransformationMatrix::m44):
      (WebKit::WebTransformationMatrix::setM44):
      (WebKit::WebTransformationMatrix::a):
      (WebKit::WebTransformationMatrix::setA):
      (WebKit::WebTransformationMatrix::b):
      (WebKit::WebTransformationMatrix::setB):
      (WebKit::WebTransformationMatrix::c):
      (WebKit::WebTransformationMatrix::setC):
      (WebKit::WebTransformationMatrix::d):
      (WebKit::WebTransformationMatrix::setD):
      (WebKit::WebTransformationMatrix::e):
      (WebKit::WebTransformationMatrix::setE):
      (WebKit::WebTransformationMatrix::f):
      (WebKit::WebTransformationMatrix::setF):
      (WebKit::WebTransformationMatrix::toWebCoreTransform):
      (WebKit::WebTransformationMatrix::mapRect):
      (WebKit::WebTransformationMatrix::mapPoint):
      (WebKit::WebTransformationMatrix::mapQuad):
      (WebKit::WebTransformationMatrix::projectPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1a16f4
    • ggaren@apple.com's avatar
      WeakGCMap should be lazy-finalization-safe · 7cc57368
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87784
      
      Reviewed by Darin Adler.
      
      * runtime/WeakGCMap.h:
      (JSC::WeakGCMap::get): Since this is a map of raw WeakImpl pointers, and
      not Weak<T>, we need to verify manually that the WeakImpl is live before
      we return its payload.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc57368
    • dpranke@chromium.org's avatar
      webkitpy: rename 'rm' to 'delete' in rebaseline scm output · 76be4db0
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87779
      
      Reviewed by Eric Seidel.
      
      Update output to match the names in scm.py as per
      https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (RebaselineTest.execute):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (test_rebaseline_test_and_print_scm_changes):
      * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
      (GardeningServerTest.test_rebaselineall):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76be4db0
    • commit-queue@webkit.org's avatar
      Support WebKit log messages on Android · 91549421
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87773
      
      Patch by Alexandre Elias <aelias@google.com> on 2012-05-29
      Reviewed by Darin Adler.
      
      This sends WebKit log messages to the Android "logcat" facility, as
      Android sends stderr to /dev/null.
      
      * wtf/Assertions.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91549421
    • alexis.menard@openbossa.org's avatar
      [CSS3 Backgrounds and Borders] Implement box-decoration-break parsing. · 454e4e19
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87678
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Implement the parsing part of box-decoration-break. The specification
      is located at http://www.w3.org/TR/css3-background/#box-decoration-break.
      So far Opera implements it. This patch only implements the parsing part of
      the property. A following patch will implement the rendering part. Despite
      the rendering part missing it improves http://css3test.com by 1%.
      
      Test: fast/box-decoration-break/box-decoration-break-parsing.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue):
      (WebCore::isKeywordPropertyID):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore):
      (WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/CSSValueKeywords.in:
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleBoxData.cpp:
      (WebCore::StyleBoxData::StyleBoxData):
      (WebCore::StyleBoxData::operator==):
      * rendering/style/StyleBoxData.h:
      (WebCore::StyleBoxData::boxDecorationBreak):
      (StyleBoxData):
      
      LayoutTests:
      
      Add a new test to cover the parsing part of the new css property. Also rebase the
      existing tests which are listing the css properties of the style.
      
      * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: Added.
      * fast/box-decoration-break/box-decoration-break-parsing.html: Added.
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      454e4e19
    • commit-queue@webkit.org's avatar
      [text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of... · fc044e71
      commit-queue@webkit.org authored
      [text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of dispatching mouse events
      https://bugs.webkit.org/show_bug.cgi?id=63781
      
      Patch by David Barr <davidbarr@chromium.org> on 2012-05-29
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      "Ellipsing only affects rendering and must not affect layout nor dispatching of pointer events."
      http://www.w3.org/TR/2012/WD-css3-ui-20120117/#text-overflow
      
      Test: fast/css/text-overflow-ellipsis-hit-test.html
      
      * rendering/EllipsisBox.cpp:
      (WebCore::EllipsisBox::nodeAtPoint): Always return false.
      
      LayoutTests:
      
      * fast/css/text-overflow-ellipsis-hit-test-expected.txt: Added.
      * fast/css/text-overflow-ellipsis-hit-test.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc044e71
    • rakuco@webkit.org's avatar
      [EFL] Unreviewed gardening. · 297d891b
      rakuco@webkit.org authored
      Unskip a lot of fast/selectors tests which were really passing all
      the time, they just needed updated baselines after the jhbuild and
      font commits.
      
      * platform/efl/Skipped:
      * platform/efl/fast/selectors/001-expected.png:
      * platform/efl/fast/selectors/002-expected.png:
      * platform/efl/fast/selectors/003-expected.png:
      * platform/efl/fast/selectors/004-expected.png:
      * platform/efl/fast/selectors/005-expected.png:
      * platform/efl/fast/selectors/006-expected.png:
      * platform/efl/fast/selectors/007a-expected.png:
      * platform/efl/fast/selectors/007b-expected.png:
      * platform/efl/fast/selectors/008-expected.png:
      * platform/efl/fast/selectors/009-expected.png:
      * platform/efl/fast/selectors/010-expected.png:
      * platform/efl/fast/selectors/011-expected.png:
      * platform/efl/fast/selectors/012-expected.png:
      * platform/efl/fast/selectors/013-expected.png:
      * platform/efl/fast/selectors/014-expected.png:
      * platform/efl/fast/selectors/015-expected.png:
      * platform/efl/fast/selectors/018-expected.png:
      * platform/efl/fast/selectors/018b-expected.png:
      * platform/efl/fast/selectors/021-expected.png:
      * platform/efl/fast/selectors/021b-expected.png:
      * platform/efl/fast/selectors/032-expected.png:
      * platform/efl/fast/selectors/034-expected.png:
      * platform/efl/fast/selectors/038-expected.png:
      * platform/efl/fast/selectors/040-expected.png:
      * platform/efl/fast/selectors/043-expected.png:
      * platform/efl/fast/selectors/043b-expected.png:
      * platform/efl/fast/selectors/044-expected.png:
      * platform/efl/fast/selectors/044b-expected.png:
      * platform/efl/fast/selectors/044c-expected.png:
      * platform/efl/fast/selectors/044d-expected.png:
      * platform/efl/fast/selectors/045-expected.png:
      * platform/efl/fast/selectors/045b-expected.png:
      * platform/efl/fast/selectors/045c-expected.png:
      * platform/efl/fast/selectors/046-expected.png:
      * platform/efl/fast/selectors/054-expected.png:
      * platform/efl/fast/selectors/056-expected.png:
      * platform/efl/fast/selectors/058-expected.png:
      * platform/efl/fast/selectors/059-expected.png:
      * platform/efl/fast/selectors/060-expected.png:
      * platform/efl/fast/selectors/061-expected.png:
      * platform/efl/fast/selectors/063-expected.png:
      * platform/efl/fast/selectors/064-expected.png:
      * platform/efl/fast/selectors/066-expected.png:
      * platform/efl/fast/selectors/066b-expected.png:
      * platform/efl/fast/selectors/072-expected.png:
      * platform/efl/fast/selectors/072b-expected.png:
      * platform/efl/fast/selectors/077-expected.png:
      * platform/efl/fast/selectors/077b-expected.png:
      * platform/efl/fast/selectors/078b-expected.png:
      * platform/efl/fast/selectors/083-expected.png:
      * platform/efl/fast/selectors/087b-expected.png:
      * platform/efl/fast/selectors/090b-expected.png:
      * platform/efl/fast/selectors/154-expected.png:
      * platform/efl/fast/selectors/155-expected.png:
      * platform/efl/fast/selectors/155a-expected.png:
      * platform/efl/fast/selectors/155b-expected.png:
      * platform/efl/fast/selectors/155c-expected.png:
      * platform/efl/fast/selectors/155d-expected.png:
      * platform/efl/fast/selectors/156b-expected.png:
      * platform/efl/fast/selectors/157-expected.png:
      * platform/efl/fast/selectors/158-expected.png:
      * platform/efl/fast/selectors/160-expected.png:
      * platform/efl/fast/selectors/168-expected.png:
      * platform/efl/fast/selectors/168a-expected.png:
      * platform/efl/fast/selectors/169-expected.png:
      * platform/efl/fast/selectors/169a-expected.png:
      * platform/efl/fast/selectors/lang-inheritance-expected.png:
      * platform/efl/fast/selectors/lang-inheritance2-expected.png:
      * platform/efl/fast/selectors/lang-vs-xml-lang-expected.png:
      * platform/efl/fast/selectors/lang-vs-xml-lang-xhtml-expected.png:
      * platform/efl/fast/selectors/visited-descendant-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      297d891b
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebOverlay build fixes and bug fixes · e4ecf697
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87780
      
      Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
      Reviewed by Rob Buis.
      
      Fix build when accelerated compositing disabled, or debug build.
      
      Also fix a bug where the selection overlay would not disappear properly
      because of a typo in WebPage::removeOverlay(). Also convert said method
      to early return style.
      
      Debug build fixes contributed by Ming Xie.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlay::addAnimation):
      (BlackBerry::WebKit::WebOverlay::setContentsToImage):
      (WebKit):
      (BlackBerry::WebKit::WebOverlay::setContentsToColor):
      (BlackBerry::WebKit::WebOverlay::setDrawsContent):
      (BlackBerry::WebKit::WebOverlay::invalidate):
      (BlackBerry::WebKit::WebOverlay::setClient):
      (BlackBerry::WebKit::WebOverlay::override):
      (BlackBerry::WebKit::WebOverlay::resetOverrides):
      * Api/WebOverlayOverride.cpp:
      (BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
      * Api/WebOverlay_p.h:
      (BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::removeOverlay):
      (BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
      (BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4ecf697
    • jberlin@webkit.org's avatar
      <progress> element is unsupported on Windows · 9dc2ac24
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49769
      
      Add platform-specific results for tests that use the progress element on Windows.
      
      * platform/win/fast/forms/label: Added.
      * platform/win/fast/forms/label/labelable-elements-expected.txt: Added.
      * platform/win/fast/forms/label/labels-add-htmlFor-label-expected.txt: Added.
      * platform/win/fast/forms/label/labels-add-parent-label-expected.txt: Added.
      * platform/win/fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Added.
      * platform/win/fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
      * platform/win/fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
      * platform/win/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Added.
      * platform/win/fast/forms/label/labels-remove-htmlFor-label-expected.txt: Added.
      * platform/win/fast/forms/label/labels-remove-parent-label-expected.txt: Added.
      * platform/win/fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dc2ac24
    • gavinp@chromium.org's avatar
      [Chromium] Remove assertions on state in Prerender.cpp · 8d4431b2
      gavinp@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87746
      
      Chrome was crashing in the new Prerender API on Google Web Search; this was because the DOM would stop(), setting the
      state of the Prerenders in the document to Inactive, but an asyncronous GC would later come come along and trigger the
      removedFromDocument behaviour on each element, including the <link> element launching the prerender.  This causes an
      assertion failure.
      
      I believe the late-deletion of the DOM, and the HTMLElement::removedFromDocument calls are legal, and it was the
      overzealous assertions in Prerender that were inappropriate.
      
      Reviewed by Adam Barth.
      
      No new automated tests, working on a Chromium browser test. Manually test by entering many prerender and non-prerendered
      queries into Google Web Search.
      
      * platform/chromium/Prerender.cpp:
      (WebCore::Prerender::Prerender):
      (WebCore::Prerender::add):
      (WebCore::Prerender::cancel):
      (WebCore::Prerender::abandon):
      * platform/chromium/Prerender.h:
      (Prerender):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d4431b2
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add malloc info to about:memory page · 7733b379
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87676
      
      Patch by Yong Li <yoli@rim.com> on 2012-05-29
      Reviewed by Rob Buis.
      
      Detailed malloc info can tell us how much memory
      in the heaps is being in use.
      
      * WebCoreSupport/AboutData.cpp:
      (WebCore::memoryPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7733b379
    • rafaelw@chromium.org's avatar
      Updating test expectation (media/track/track-cues-missed CRASH). · 5f24e3f2
      rafaelw@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f24e3f2
    • rakuco@webkit.org's avatar
      [EFL] Unreviewed gardening. · f2d8ccc8
      rakuco@webkit.org authored
      House cleaning on Skipped: remove tests which do not exist, unskip
      some which are passing and add expectations for some which were
      lacking them.
      
      * platform/efl/Skipped:
      * platform/efl/editing/selection/fake-doubleclick-expected.png: Added.
      * platform/efl/editing/selection/fake-doubleclick-expected.txt: Added.
      * platform/efl/fast/borders/border-image-slice-constrained-expected.png: Added.
      * platform/efl/fast/borders/border-image-slice-constrained-expected.txt: Added.
      * platform/efl/fast/borders/border-mixed-alpha-expected.png: Added.
      * platform/efl/fast/borders/borderRadiusArcs01-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusDouble01-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusDouble02-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusDouble03-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusGroove01-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusGroove02-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusInset01-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusOutset01-expected.txt: Added.
      * platform/efl/fast/borders/borderRadiusRidge01-expected.txt: Added.
      * platform/efl/fast/borders/scaled-border-image-expected.png: Added.
      * platform/efl/fast/borders/scaled-border-image-expected.txt: Added.
      * platform/efl/fast/forms/input-appearance-disabled-expected.png: Added.
      * platform/efl/fast/forms/input-appearance-disabled-expected.txt: Added.
      * platform/efl/fast/forms/input-appearance-readonly-expected.png: Added.
      * platform/efl/fast/forms/input-appearance-readonly-expected.txt: Added.
      * platform/efl/fast/forms/input-placeholder-visibility-3-expected.png: Added.
      * platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
      * platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
      * platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
      * platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
      * platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
      * platform/efl/fast/forms/textarea-scrollbar-expected.png: Added.
      * platform/efl/fast/forms/textarea-scrollbar-expected.txt: Added.
      * platform/efl/fast/line-grid/line-grid-floating-expected.png: Added.
      * platform/efl/fast/line-grid/line-grid-floating-expected.txt: Added.
      * platform/efl/fast/line-grid/line-grid-inside-columns-expected.png: Added.
      * platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
      * platform/efl/fast/line-grid/line-grid-into-floats-expected.png: Added.
      * platform/efl/fast/line-grid/line-grid-into-floats-expected.txt: Added.
      * platform/efl/fast/line-grid/line-grid-positioned-expected.png: Added.
      * platform/efl/fast/line-grid/line-grid-positioned-expected.txt: Added.
      * platform/efl/fast/repaint/4774354-expected.png: Added.
      * platform/efl/fast/repaint/4774354-expected.txt: Added.
      * platform/efl/fast/repaint/4776765-expected.png: Added.
      * platform/efl/fast/repaint/4776765-expected.txt: Added.
      * platform/efl/fast/repaint/delete-into-nested-block-expected.png: Added.
      * platform/efl/fast/repaint/delete-into-nested-block-expected.txt: Added.
      * platform/efl/fast/repaint/inline-outline-repaint-expected.png: Added.
      * platform/efl/fast/repaint/inline-outline-repaint-expected.txt: Added.
      * platform/efl/fast/repaint/selection-after-delete-expected.png: Added.
      * platform/efl/fast/repaint/selection-after-delete-expected.txt: Added.
      * platform/efl/fast/selectors/159-expected.png: Added.
      * platform/efl/fast/selectors/159-expected.txt: Added.
      * platform/efl/fast/selectors/177a-expected.png: Added.
      * platform/efl/fast/selectors/177a-expected.txt: Added.
      * platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
      * platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
      * platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
      * platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
      * platform/efl/fast/text/delete-hard-break-character-expected.png: Added.
      * platform/efl/fast/text/delete-hard-break-character-expected.txt: Added.
      * platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png: Added.
      * platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt: Added.
      * platform/efl/mathml/presentation/roots-expected.png: Added.
      * platform/efl/mathml/presentation/roots-expected.txt: Added.
      * platform/efl/mathml/presentation/row-alignment-expected.png: Added.
      * platform/efl/mathml/presentation/row-alignment-expected.txt: Added.
      * platform/efl/media/controls-styling-expected.png: Added.
      * platform/efl/media/controls-styling-expected.txt: Added.
      * platform/efl/svg/batik/text/textAnchor-expected.png: Added.
      * platform/efl/svg/batik/text/textOnPath3-expected.png: Added.
      * platform/efl/svg/batik/text/verticalTextOnPath-expected.png: Added.
      * platform/efl/svg/carto.net/tabgroup-expected.png: Added.
      * platform/efl/transitions/cross-fade-background-image-expected.png: Added.
      * platform/efl/transitions/cross-fade-border-image-expected.png: Added.
      * platform/efl/transitions/default-timing-function-expected.png:
      * platform/efl/transitions/default-timing-function-expected.txt:
      * platform/efl/transitions/move-after-transition-expected.png:
      * platform/efl/transitions/move-after-transition-expected.txt:
      * platform/efl/transitions/svg-text-shadow-transition-expected.png:
      * platform/efl/transitions/svg-text-shadow-transition-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2d8ccc8
    • rafaelw@chromium.org's avatar
      Updating test expectations (fast/forms/form-associated-element-removal MISSING). · 8819e932
      rafaelw@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8819e932
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=87711 · 51ff9f35
      slewis@apple.com authored
      Reviewed by Jessie Berlin.
      
      Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
      are better maintained.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51ff9f35
    • commit-queue@webkit.org's avatar
      Display cues in the controls area · 8c58329a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87591
      
      Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Changed the behaviour to implicitly hide the volume slidebar
      if the controls are hidden (due mouse moving out of the video
      area or controls are toggled through JS).
      
      This seems to be the simplest fix to this issue, otherwise
      on toggling the display:none property on the controls the
      volume slidebar might appear below the video.
      
      Re-enabled failing tests for this functionality.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::makeTransparent): Re-enabled
      timer to set the display:none property on the controls.
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::hide): Added a call to hide
      the volume slider.
      (WebCore::MediaControlRootElement::makeTransparent): Same.
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore::MediaControlRootElementChromium::hide): Same.
      (WebCore::MediaControlRootElementChromium::makeTransparent): Same.
      
      LayoutTests:
      
      * media/media-volume-slider-rendered-normal-expected.txt: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none-expected.txt.
      * media/media-volume-slider-rendered-normal.html: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none.html.
      * platform/chromium/test_expectations.txt: Unmarked tests.
      * platform/efl/test_expectations.txt: Unmarked tests.
      * platform/mac/test_expectations.txt: Unmarked tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c58329a