- 29 Nov, 2013 8 commits
-
-
weinig@apple.com authored
* UIProcess/API/Cocoa/WKBrowsingContextController.mm: (-[WKBrowsingContextController loadDelegate]): (-[WKBrowsingContextController setLoadDelegate:]): (-[WKBrowsingContextController policyDelegate]): (-[WKBrowsingContextController setPolicyDelegate:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* UIProcess/API/Cocoa/WKBrowsingContextController.mm: (-[WKBrowsingContextController loadDelegate]): (-[WKBrowsingContextController policyDelegate]): (-[WKBrowsingContextController setPolicyDelegate:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125022 Reviewed by Dan Bernstein. * Shared/Cocoa/APIObject.mm: (API::Object::newObject): * Shared/mac/ObjCObjectGraphCoders.mm: Add support for WKProcessGroup. (WebKit::WebContextObjCObjectGraphDecoderImpl::decode): Replace call to _browsingContextControllerForPageRef: with wrapper. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline. (-[WKBrowsingContextController dealloc]): Add explicit destructor call. (-[WKBrowsingContextController setLoadDelegate:]): (-[WKBrowsingContextController setPolicyDelegate:]): Lazily set up the load and policy clients only once a delegate has been set to allow continued use of the C-SPI clients for WebKitTestRunner. (-[WKBrowsingContextController _finishInitialization]): Move remaining work that was done in the initialize (setting up the observer) here, and have the WebPageProxy call it. * UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: (WebKit::wrapper): Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used _initWithPageRef: and _browsingContextControllerForPageRef: helpers. * UIProcess/API/Cocoa/WKProcessGroup.mm: (didNavigateWithNavigationData): (didPerformClientRedirect): (didPerformServerRedirect): (didUpdateHistoryTitle): Switch to using wrapper(). * UIProcess/API/ios/WKContentView.mm: * UIProcess/API/mac/WKView.mm: Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object as the WebPageProxy. * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::platformInitialize): Inform the wrapper that it is safe to finish initialization. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125020 Reviewed by Sam Weinig. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: (createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from the given error, adding two keys to the user info dictionary: the context controller under the recovery attempter key, and the frame under a private key. (didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter. (didFailLoadWithErrorForFrame): Ditto. (-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the frame from the error. * UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting recovery from errors and declares the error user info dictionary key under which an object conforming to this protocol may be stored. * UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines WKRecoveryAttempterErrorKey. * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page. * UIProcess/WebFrameProxy.h: * WebKit2.xcodeproj/project.pbxproj: Added references to new files. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125019 Reviewed by Sam Weinig. * UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: (-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added. Calls WebPageProxy::loadAlternateHTMLString. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125017 Reviewed by Dan Bernstein. * UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm. * UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h. * UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h. * UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h. * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm. * UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h. * UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h. * UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h. * UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h. * UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h. * UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm. * UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h. * UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h. * UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm. * UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h. * UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h. * UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h. * UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm. * UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h. * UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h. * UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h. * UIProcess/API/mac/WKBrowsingContextController.h: Removed. * UIProcess/API/mac/WKBrowsingContextController.mm: Removed. * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed. * UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed. * UIProcess/API/mac/WKBrowsingContextGroup.h: Removed. * UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed. * UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed. * UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed. * UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed. * UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed. * UIProcess/API/mac/WKConnection.h: Removed. * UIProcess/API/mac/WKConnection.mm: Removed. * UIProcess/API/mac/WKConnectionInternal.h: Removed. * UIProcess/API/mac/WKProcessGroup.h: Removed. * UIProcess/API/mac/WKProcessGroup.mm: Removed. * UIProcess/API/mac/WKProcessGroupInternal.h: Removed. * UIProcess/API/mac/WKProcessGroupPrivate.h: Removed. * UIProcess/API/mac/WKTypeRefWrapper.h: Removed. * UIProcess/API/mac/WKTypeRefWrapper.mm: Removed. * UIProcess/API/mac/WKView.h: Removed. * UIProcess/API/mac/WKViewPrivate.h: Removed. * UIProcess/API/mac/WebKit2.h: Removed. * WebKit2.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124965 Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2013-11-29 Reviewed by Gyuyoung Kim. Currently, size of the viewport is larger than size of webview. Changed the size of viewport with size of webview, because viewport is translated by wrong calculation. * UIProcess/API/efl/EwkView.cpp: (EwkView::displayTimerFired): Changed to use the (0,0). (EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd. (EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=118548 Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-28 Reviewed by Noam Rosenthal. CoordinatedGraphics uses its own scaling logic - contents scaling - and WebView of CoordinatedGraphics maintains contents position by scaling with contents scaling factor. However transformToScene() and updateViewportSize() of WebView regard the contents position as a non-scaled value, so it should be fixed. * UIProcess/CoordinatedGraphics/WebView.cpp: (WebKit::WebView::transformToScene): (WebKit::WebView::updateViewportSize): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 28 Nov, 2013 7 commits
-
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=124993 Reviewed by Gyuyoung Kim. PageViewportController and PageViewportControllerEfl have same life cycle with EwkView. So, we don't need to make them as unique_ptr instance. * UIProcess/API/efl/EwkView.cpp: (EwkView::EwkView): (EwkView::handleEvasObjectCalculate): (EwkView::scrollBy): * UIProcess/API/efl/EwkView.h: (EwkView::pageViewportController): * UIProcess/efl/PageLoadClientEfl.cpp: (WebKit::PageLoadClientEfl::didCommitLoadForFrame): * UIProcess/efl/ViewClientEfl.cpp: (WebKit::ViewClientEfl::didChangeContentsSize): (WebKit::ViewClientEfl::didChangeContentsPosition): (WebKit::ViewClientEfl::didRenderFrame): (WebKit::ViewClientEfl::didCompletePageTransition): (WebKit::ViewClientEfl::didChangeViewportAttributes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124992 Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-28 Reviewed by Gyuyoung Kim. * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::didCommitLoadForMainFrame): Added. * UIProcess/API/gtk/PageClientImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jinwoo7.song@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=124991 Reviewed by Gyuyoung Kim. Redefined newly added pure virtual function in PageClient class after r159859. * UIProcess/CoordinatedGraphics/WebView.cpp: (WebKit::WebView::didCommitLoadForMainFrame): * UIProcess/CoordinatedGraphics/WebView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124961 Reviewed by Dan Bernstein. - Store the PageClientImpl in a std::unique_ptr. - Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame. - Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame. - Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner. - Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef). - Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView. - Remove incorrect implementations of initWithCoder. - Make WKContentView lazily create its WKBrowsingContextController wrapper. * UIProcess/API/ios/PageClientImplIOS.h: * UIProcess/API/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType): * UIProcess/API/ios/WKContentView.h: * UIProcess/API/ios/WKContentView.mm: (-[WKContentView initWithCoder:]): (-[WKContentView initWithFrame:processGroup:browsingContextGroup:]): (-[WKContentView browsingContextController]): (-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): (-[WKContentView _didCommitLoadForMainFrame]): (-[WKContentView _didReceiveMobileDocTypeForMainFrame]): (-[WKContentView _didChangeViewportArguments:WebCore::]): (-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]): (-[WKContentView _pageRef]): (-[WKContentView initWithFrame:contextRef:pageGroupRef:]): (-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/ios/WKContentViewInternal.h: * UIProcess/API/ios/WKContentViewPrivate.h: Added. * UIProcess/API/ios/WKView.mm: (-[WKView initWithFrame:processGroup:browsingContextGroup:]): (-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]): (-[WKView contentViewDidCommitLoadForMainFrame:]): (-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): (-[WKView pageRef]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didCommitLoadForMainFrame): * UIProcess/API/mac/WKBrowsingContextController.mm: (didCommitLoadForFrame): * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: * UIProcess/API/mac/WKViewPrivate.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124968 Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28 Reviewed by Csaba Osztrogonác. Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11) * Shared/APIObject.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=114119 .: Reviewed by Andreas Kling. * Source/cmakeconfig.h.cmake: Source/JavaScriptCore: Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Reviewed by Andreas Kling. The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to WebKit standards either. * Configurations/FeatureDefines.xcconfig: * GNUmakefile.list.am: * WebCore.xcodeproj/project.pbxproj: * css/CSSBasicShapes.cpp: * css/CSSBasicShapes.h: * css/CSSCalculationValue.cpp: (WebCore::unitCategory): (WebCore::hasDoubleValue): (WebCore::CSSCalcPrimitiveValue::toCalcValue): (WebCore::CSSCalcPrimitiveValue::computeLengthPx): (WebCore::determineCategory): (WebCore::CSSCalcBinaryOperation::primitiveType): * css/CSSCalculationValue.h: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSGrammar.y.in: * css/CSSParser.cpp: (WebCore::CSSParserContext::CSSParserContext): (WebCore::operator==): (WebCore::filterProperties): (WebCore::CSSParser::createStylePropertySet): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::validCalculationUnit): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::createPrimitiveNumericValue): (WebCore::CSSParser::parseValidPrimitive): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::detectDashToken): (WebCore::CSSParser::realLex): * css/CSSParser.h: * css/CSSParserMode.h: * css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue): * css/CSSParserValues.h: * css/CSSPrimitiveValue.cpp: (WebCore::isValidCSSUnitTypeForDoubleConversion): (WebCore::CSSPrimitiveValue::primitiveType): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::customCSSText): (WebCore::CSSPrimitiveValue::equals): * css/CSSPrimitiveValue.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): * css/CSSProperty.cpp: * css/CSSProperty.h: (WebCore::CSSProperty::CSSProperty): * css/CSSReflectValue.cpp: * css/CSSReflectValue.h: * css/CSSValue.cpp: (WebCore::CSSValue::equals): (WebCore::CSSValue::cssText): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::setCssText): * css/CSSValueList.cpp: * css/CSSValueList.h: * css/CSSVariableValue.h: Removed. * css/Pair.h: * css/Rect.h: * css/StylePropertySet.cpp: (WebCore::StylePropertySet::asText): (WebCore::StylePropertySet::PropertyReference::cssName): * css/StyleResolver.cpp: (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyProperties): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): * css/StyleResolver.h: * css/WebKitCSSTransformValue.cpp: * css/WebKitCSSTransformValue.h: (WebCore::WebKitCSSTransformValue::equals): * css/makeprop.pl: * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: * rendering/style/RenderStyle.h: * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): * rendering/style/StyleRareInheritedData.h: * rendering/style/StyleVariableData.h: Removed. * testing/InternalSettings.cpp: (WebCore::InternalSettings::Backup::Backup): (WebCore::InternalSettings::Backup::restoreTo): * testing/InternalSettings.h: * testing/InternalSettings.idl: Source/WebKit/mac: Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: Source/WebKit2: Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: Source/WTF: Reviewed by Andreas Kling. * wtf/FeatureDefines.h: Tools: Reviewed by Andreas Kling. * Scripts/webkitperl/FeatureList.pm: LayoutTests: Reviewed by Andreas Kling. * fast/css/variables: Removed. * fast/css/variables/border-width-expected.html: Removed. * fast/css/variables/border-width.html: Removed. * fast/css/variables/build-supports-variables-expected.txt: Removed. * fast/css/variables/build-supports-variables.html: Removed. * fast/css/variables/calc-expected.html: Removed. * fast/css/variables/calc-inside-calc-expected.html: Removed. * fast/css/variables/calc-inside-calc.html: Removed. * fast/css/variables/calc-invalid-value-expected.html: Removed. * fast/css/variables/calc-invalid-value.html: Removed. * fast/css/variables/calc-invalid-variable-expected.html: Removed. * fast/css/variables/calc-invalid-variable.html: Removed. * fast/css/variables/calc-negated-variable-expected.html: Removed. * fast/css/variables/calc-negated-variable.html: Removed. * fast/css/variables/calc-vw-crash-expected.txt: Removed. * fast/css/variables/calc-vw-crash.html: Removed. * fast/css/variables/calc.html: Removed. * fast/css/variables/case-sensitive-expected.html: Removed. * fast/css/variables/case-sensitive.html: Removed. * fast/css/variables/colors-test-expected.html: Removed. * fast/css/variables/colors-test.html: Removed. * fast/css/variables/complex-cycle-expected.html: Removed. * fast/css/variables/complex-cycle.html: Removed. * fast/css/variables/computed-style-expected.html: Removed. * fast/css/variables/computed-style.html: Removed. * fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed. * fast/css/variables/deferred-image-load-from-variable.html: Removed. * fast/css/variables/inherited-values-expected.html: Removed. * fast/css/variables/inherited-values.html: Removed. * fast/css/variables/inline-styles-expected.html: Removed. * fast/css/variables/inline-styles.html: Removed. * fast/css/variables/invalid-font-reference-expected.txt: Removed. * fast/css/variables/invalid-font-reference.html: Removed. * fast/css/variables/invalid-shorthand-expected.html: Removed. * fast/css/variables/invalid-shorthand.html: Removed. * fast/css/variables/invalid-value-list-crash-expected.txt: Removed. * fast/css/variables/invalid-value-list-crash.html: Removed. * fast/css/variables/invalid-variable-value-expected.html: Removed. * fast/css/variables/invalid-variable-value.html: Removed. * fast/css/variables/multi-level-cycle-expected.html: Removed. * fast/css/variables/multi-level-cycle.html: Removed. * fast/css/variables/redefinition-expected.html: Removed. * fast/css/variables/redefinition.html: Removed. * fast/css/variables/root-background-size-expected.html: Removed. * fast/css/variables/root-background-size.html: Removed. * fast/css/variables/shorthand-expected.html: Removed. * fast/css/variables/shorthand.html: Removed. * fast/css/variables/simple-cycle-expected.html: Removed. * fast/css/variables/simple-cycle.html: Removed. * fast/css/variables/transform-test-expected.html: Removed. * fast/css/variables/transform-test.html: Removed. * fast/css/variables/undefined-expected.html: Removed. * fast/css/variables/undefined.html: Removed. * fast/css/variables/use-before-defined-expected.html: Removed. * fast/css/variables/use-before-defined.html: Removed. * fast/css/variables/var-filter-expected.txt: Removed. * fast/css/variables/var-filter.html: Removed. * fast/css/variables/var-inside-box-reflect-expected.html: Removed. * fast/css/variables/var-inside-box-reflect.html: Removed. * fast/css/variables/var-inside-pair-expected.html: Removed. * fast/css/variables/var-inside-pair.html: Removed. * fast/css/variables/var-inside-quad-expected.html: Removed. * fast/css/variables/var-inside-quad.html: Removed. * fast/css/variables/var-inside-shape-expected.html: Removed. * fast/css/variables/var-inside-shape.html: Removed. * fast/css/variables/var-inside-shorthand-expected.html: Removed. * fast/css/variables/var-inside-shorthand.html: Removed. * fast/css/variables/variable-chain-expected.html: Removed. * fast/css/variables/variable-chain.html: Removed. * fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed. * fast/css/variables/variable-unparseable-value-crash.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gns@gnome.org authored
https://bugs.webkit.org/show_bug.cgi?id=124659 Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-27 Reviewed by Martin Robinson. Source/WebCore: Covered by fast/events/drag-customData.html. * platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set. (WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types. * platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set. (WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type. (WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type. * platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeString): handle unknown types as custom. (WebCore::Pasteboard::writePasteboard): ditto. (WebCore::Pasteboard::hasData): also check for custom types. (WebCore::Pasteboard::types): also obtain the list of custom types. (WebCore::Pasteboard::readString): handle unknown types as custom. * platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): new unknown atom. (WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets. (WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which is in turn serialized to a single string for GtkSelectionData to hold. (WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is set. (WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data from the serialized GVariant string held by GtkSelectionData. (WebCore::PasteboardHelper::dropAtomsForContext): handle custom types. Source/WebKit2: * Shared/gtk/ArgumentCodersGtk.cpp: (CoreIPC::encodeDataObject): encode the unknown types data. (CoreIPC::decodeDataObject): decode the unknown types data. LayoutTests: * platform/gtk/TestExpectations: remove failure expectation for test that now passes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 27 Nov, 2013 7 commits
-
-
weinig@apple.com authored
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it https://bugs.webkit.org/show_bug.cgi?id=124955 Reviewed by Dan Bernstein. Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient. * UIProcess/API/ios/PageClientImplIOS.h: * UIProcess/API/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest): * UIProcess/API/ios/WKContentView.mm: (-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]): (-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]): * UIProcess/API/ios/WKContentViewInternal.h: * UIProcess/PageClient.h: (WebKit::PageClient::decidePolicyForGeolocationPermissionRequest): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::requestGeolocationPermissionForFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* UIProcess/API/ios/WKGeolocationProviderIOS.mm: * UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124953 Reviewed by Dan Bernstein. * UIProcess/API/mac/WKBrowsingContextController.h: * UIProcess/API/mac/WKBrowsingContextController.mm: (-[WKBrowsingContextController processGroup]): (-[WKBrowsingContextController browsingContextGroup]): Add accessors. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124952 Reviewed by Dan Bernstein. * Shared/Cocoa/APIObject.mm: (API::Object::newObject): Add support for WKProcessGroup. * UIProcess/API/mac/WKProcessGroup.mm: (-[WKProcessGroup initWithInjectedBundleURL:]): (-[WKProcessGroup dealloc]): (-[WKProcessGroup API::]): (-[WKProcessGroup _contextRef]): (-[WKProcessGroup _geolocationProvider]): Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline * UIProcess/API/mac/WKProcessGroupInternal.h: Added. (WebKit::wrapper): Add wrapper() helper and declare conformance to the WKObject protocol. * UIProcess/WebContext.cpp: (WebKit::WebContext::create): (WebKit::WebContext::WebContext): * UIProcess/WebContext.h: Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter. * WebKit2.xcodeproj/project.pbxproj: Add new file. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124948 Reviewed by Dan Bernstein. - Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created by the caller (rather than by Object::newObject). - Adopts the mechanism for WKBrowsingContextGroup. * Shared/APIObject.h: (API::Object::constructInWrapper): Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper. (API::TypedObject::operator new): Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this. * Shared/Cocoa/APIObject.mm: (API::Object::newObject): Add support for WKBrowsingContextGroup. * UIProcess/API/mac/WKBrowsingContextGroup.mm: (-[WKBrowsingContextGroup API::]): (-[WKBrowsingContextGroup dealloc]): (-[WKBrowsingContextGroup initWithIdentifier:]): (-[WKBrowsingContextGroup allowsJavaScript]): (-[WKBrowsingContextGroup setAllowsJavaScript:]): (-[WKBrowsingContextGroup allowsJavaScriptMarkup]): (-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): (-[WKBrowsingContextGroup allowsPlugIns]): (-[WKBrowsingContextGroup setAllowsPlugIns:]): (-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): (-[WKBrowsingContextGroup removeAllUserStyleSheets]): (-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): (-[WKBrowsingContextGroup removeAllUserScripts]): (-[WKBrowsingContextGroup _pageGroupRef]): Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList). * UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added. (WebKit::wrapper): Add wrapper() helper and declare conformance to the WKObject protocol. * UIProcess/WebPageGroup.cpp: (WebKit::WebPageGroup::create): (WebKit::WebPageGroup::WebPageGroup): * UIProcess/WebPageGroup.h: Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap() to the constructor. * WebKit2.xcodeproj/project.pbxproj: Add new file. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124944 Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-27 Reviewed by Andreas Kling. Source/WebCore: No new tests needed. * WebCore.qrc: Removed. Source/WebKit2: * WebKit2.qrc: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=124924 Reviewed by Carlos Garcia Campos. 'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit' substrings should be checked for. * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettingsUserAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Nov, 2013 2 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=121943 Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26 Reviewed by Eric Carlson. Source/WebCore: Implement MediaStream direct assignment to Media Elements using the new 'srcObject' attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements Test: fast/mediastream/MediaStream-MediaElement-srcObject.html * CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build. * DerivedSources.make: Added HTMLMediaElementMediaStream.idl. * GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build. * WebCore.xcodeproj/project.pbxproj: Added new files. * Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added. (WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter. (WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter. * Modules/mediastream/HTMLMediaElementMediaStream.h: Added. * Modules/mediastream/HTMLMediaElementMediaStream.idl: Added. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896 * html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable and its corresponding getter. Source/WebKit2: Add mediastream module and platform to cmake include directories. * CMakeLists.txt: LayoutTests: Add layout tests to MediaStream direct assignment to HTMLMediaElement using brand new srcObject attribute. * fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt: Added. * fast/mediastream/MediaStream-MediaElement-srcObject.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124884 Reviewed by Anders Carlsson. * Shared/API/Cocoa/WKRemoteObjectInterface.h: Added import. * Shared/API/Cocoa/WKRemoteObjectRegistry.h: Ditto. * Shared/API/c/WKContextMenuItemTypes.h: Added include. * Shared/API/c/WKFindOptions.h: Ditto. * Shared/API/c/WKMutableArray.h: Ditto. * Shared/API/c/WKPageLoadTypes.h: Ditto. * Shared/API/c/WKPageVisibilityTypes.h: Ditto. * Shared/API/c/WKPluginInformation.cpp: (WKPluginInformationBundleIdentifierKey): Made this API function always be defined. When the Netscape plug-in API is not enabled, it returns 0. (WKPluginInformationBundleVersionKey): Ditto. (WKPluginInformationBundleShortVersionKey): Ditto. (WKPluginInformationPathKey): Ditto. (WKPluginInformationDisplayNameKey): Ditto. (WKPluginInformationDefaultLoadPolicyKey): Ditto. (WKPluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey): Ditto. (WKPluginInformationHasSandboxProfileKey): Ditto. (WKPluginInformationFrameURLKey): Ditto. (WKPluginInformationMIMETypeKey): Ditto. (WKPluginInformationPageURLKey): Ditto. (WKPluginInformationPluginspageAttributeURLKey): Ditto. (WKPluginInformationPluginURLKey): Ditto. (WKPlugInInformationReplacementObscuredKey): Ditto. * Shared/API/c/WKString.h: Added include. * UIProcess/API/C/WKCredentialTypes.h: Ditto. * UIProcess/API/C/WKPageContextMenuClient.h: Ditto. * UIProcess/API/C/WKPageLoaderClient.h: Added includes. * UIProcess/API/C/WKPagePolicyClient.h: Ditto. * UIProcess/API/C/WKPageUIClient.h: Ditto. * UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetTypeID): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build. * UIProcess/API/C/mac/WKContextPrivateMac.h: Removed use of ENABLE() from this private header. * UIProcess/API/C/mac/WKContextPrivateMac.mm: (WKContextCopyPlugInInfoForBundleIdentifier): Made this API function always be defined. When the Netscape plug-in API is not enabled, it returns 0. (WKContextGetInfoForInstalledPlugIns): Made this API function always be defined. * UIProcess/API/C/mac/WKInspectorPrivateMac.h: Added imports. * UIProcess/API/C/mac/WKPagePrivateMac.h: Added include. * UIProcess/API/Cocoa/WKBackForwardListItem.h: Added import. * UIProcess/API/Cocoa/WKNavigationData.h: Ditto. * UIProcess/API/cpp/WKRetainPtr.h: Replaced use of WARN_UNUSED_RETURN in this private header with an equivalent macro defined in the header. * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Added include. * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorGetTypeID): Made this API function always be defined. When the Inspector is not enabled, it returns the Null type. (WKBundleInspectorShow): Made this API function always be defined. (WKBundleInspectorClose): Ditto. (WKBundleInspectorEvaluateScriptForTest): Ditto. (WKBundleInspectorSetPageProfilingEnabled): Ditto. * WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed use of ENABLE() from this private header. * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added includes. * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added include. * WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm: (-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget): Ditto. * WebProcess/WebPage/mac/WebInspectorMac.mm: Fixed the !ENABLE(INSPECTOR) build. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 25 Nov, 2013 6 commits
-
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124870 Reviewed by Sam Weinig. * UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private cateogry isn’t stuck between the API methods and the internal methods. (-[WKBrowsingContextController setPaginationMode:]): (-[WKBrowsingContextController paginationMode]): (-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): (-[WKBrowsingContextController paginationBehavesLikeColumns]): (-[WKBrowsingContextController setPageLength:]): (-[WKBrowsingContextController pageLength]): (-[WKBrowsingContextController setGapBetweenPages:]): (-[WKBrowsingContextController gapBetweenPages]): (-[WKBrowsingContextController pageCount]): (-[WKBrowsingContextController handle]): * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into a class extension. * UIProcess/API/mac/WKConnection.mm: * UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class extension. * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* UIProcess/API/mac/WKBrowsingContextController.mm: (-[WKBrowsingContextController loadDelegateInternal]): (-[WKBrowsingContextController setLoadDelegateInternal:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime https://bugs.webkit.org/show_bug.cgi?id=123065 Reviewed by Sam Weinig. * UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and WKBrowsingContextControllerData class declaration. * UIProcess/API/mac/WKBrowsingContextController.mm: (-[WKBrowsingContextController dealloc]): Removed WKBrowsingContextControllerData class and moved ivars directly into WKBrowsingContextController, declaring them in the @implementation. Removed ivar and accessors for the delegate properties, letting the compiler synthesize them. (-[WKBrowsingContextController _pageRef]): Removed indirection via _data. (-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef. (-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto. (-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto. (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto. (-[WKBrowsingContextController stopLoading]): Ditto. (-[WKBrowsingContextController reload]): Ditto. (-[WKBrowsingContextController reloadFromOrigin]): Ditto. (-[WKBrowsingContextController goForward]): Ditto. (-[WKBrowsingContextController canGoForward]): Ditto. (-[WKBrowsingContextController goBack]): Ditto. (-[WKBrowsingContextController canGoBack]): Ditto. (-[WKBrowsingContextController goToBackForwardListItem:]): Ditto. (-[WKBrowsingContextController backForwardList]): Ditto. (-[WKBrowsingContextController activeURL]): Ditto. (-[WKBrowsingContextController provisionalURL]): Ditto. (-[WKBrowsingContextController committedURL]): Ditto. (-[WKBrowsingContextController unreachableURL]): Removed idirection via _data. (-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef. (-[WKBrowsingContextController title]): Ditto. (-[WKBrowsingContextController textZoom]): Ditto. (-[WKBrowsingContextController setTextZoom:]): Ditto. (-[WKBrowsingContextController pageZoom]): Ditto. (-[WKBrowsingContextController setPageZoom:]): Ditto. (-[WKBrowsingContextController setPaginationMode:]): Ditto. (-[WKBrowsingContextController paginationMode]): Ditto. (-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto. (-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto. (-[WKBrowsingContextController setPageLength:]): Ditto. (-[WKBrowsingContextController pageLength]): Ditto. (-[WKBrowsingContextController setGapBetweenPages:]): Ditto. (-[WKBrowsingContextController gapBetweenPages]): Ditto. (-[WKBrowsingContextController pageCount]): Ditto. (-[WKBrowsingContextController handle]): Ditto. (-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data. * UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and WKBrowsingContextGroupData class declaration. * UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the @implementation. (-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data. (-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef. (-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto. (-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto. (-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto. (-[WKBrowsingContextGroup allowsPlugIns]): Ditto. (-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto. (-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto. (-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto. (-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto. (-[WKBrowsingContextGroup removeAllUserScripts]): Ditto. (-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data. * UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration. * UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and accessors for the delegate property, letting the compiler synthesize them. (-[WKConnection dealloc]): Removed indirection via _data. (-[WKConnection sendMessageWithName:body:]): Ditto. (-[WKConnection remoteObjectRegistry]): Ditto. (didReceiveMessage): Ditto. (-[WKConnection _initWithConnectionRef:]): Ditto. * UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an import. Removed _data ivar and WKProcessGroupData class declaration. * UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved _contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed ivar and accessors for the delegate property, letting the compiler synthesize them. (-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data. (-[WKProcessGroup dealloc]): Ditto. (-[WKProcessGroup _contextRef]): Ditto. (-[WKProcessGroup _geolocationProvider]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/159740 https://bugs.webkit.org/show_bug.cgi?id=124859 Crashing xmlhttprequest/access-control-repeated-failed- preflight-crash.html on Mavericks and Mountain Lion - ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on #webkit). * Scripts/webkit2/messages.py: (struct_or_class): * Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * Shared/mac/ObjCObjectGraphCoders.h: * Shared/mac/ObjCObjectGraphCoders.mm: (WebKit::ObjCObjectGraphEncoder::baseEncode): (WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl): (WebKit::WebContextObjCObjectGraphEncoderImpl::encode): (WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode): (WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder): (WebKit::WebContextObjCObjectGraphEncoder::encode): * UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::encodeMessageBody): * UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess): (WebKit::WebContext::createWebPage): (WebKit::WebContext::postMessageToInjectedBundle): (WebKit::WebContext::didReceiveSyncMessage): * UIProcess/WebContextUserMessageCoders.h: (WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder): (WebKit::WebContextUserMessageEncoder::encode): (WebKit::WebContextUserMessageDecoder::decode): * UIProcess/WebPageGroup.cpp: * UIProcess/WebPageGroup.h: (WebKit::WebPageGroup::sendToAllProcessesInGroup): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::loadURL): (WebKit::WebPageProxy::loadURLRequest): (WebKit::WebPageProxy::loadFile): (WebKit::WebPageProxy::loadData): (WebKit::WebPageProxy::loadHTMLString): (WebKit::WebPageProxy::loadAlternateHTMLString): (WebKit::WebPageProxy::loadPlainTextString): (WebKit::WebPageProxy::loadWebArchiveData): (WebKit::WebPageProxy::postMessageToInjectedBundle): (WebKit::WebPageProxy::initializeCreationParameters): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::disconnect): (WebKit::WebProcessProxy::createWebPage): * UIProcess/WebProcessProxy.h: * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: (WebKit::InjectedBundleUserMessageEncoder::encode): (WebKit::InjectedBundleUserMessageDecoder::decode): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::webPageGroup): * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124850 Reviewed by Brady Eidson. Source/WebKit2: Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class unguarded, but limited its API. * Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute. * Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the imports. * Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto. * Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto. * Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto. * UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT. * UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED. (-[WKBrowsingContextController dealloc]): (-[WKBrowsingContextController setPolicyDelegate:]): (-[WKBrowsingContextController backForwardList]): (didChangeBackForwardList): (setUpPageLoaderClient): (setUpPagePolicyClient): (-[WKBrowsingContextController _initWithPageRef:]): * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto. * UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto. * UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED, chanegd to use WK_API_CLASS instead of WK_EXPORT. * UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything with WK_API_ENABLED. * UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED. * UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import. * UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to use WK_API_CLASS instead of WK_EXPORT. * UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED. (-[WKConnection remoteObjectRegistry]): (didReceiveMessage): * UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED. * UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of WK_EXPORT. * UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED. (-[WKProcessGroup initWithInjectedBundleURL:]): * UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED. * UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the imports, changed to use WK_API_CLASS instead of WK_EXPORT. * UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h". * UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API types. * UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods that are only declared when the API is enabled. * UIProcess/API/mac/WKViewInternal.h: Reordered imports. * UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif. * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Guarded use of WKBrowsingContextController with WK_API_ENABLED. (WebKit::WebContext::platformInitializeNetworkProcess): Ditto. * UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports. * WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import "config.h". * WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import "config.h". * WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto. * WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import. * WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import. * WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto. * WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after #import "config.h". * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant imports. * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Moved #if WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT. * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed newline after #import "config.h". Tools: Added #if WK_API_ENABLED guards around tests that use the Objective-C API. * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 24 Nov, 2013 3 commits
-
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124556 Reviewed by Dan Bernstein. * Scripts/webkit2/messages.py: (struct_or_class): Mark WebPageGroupData as a struct. * Shared/UserMessageCoders.h: * Shared/mac/ObjCObjectGraphCoders.h: * Shared/mac/ObjCObjectGraphCoders.mm: * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: * UIProcess/WebConnectionToWebProcess.cpp: * UIProcess/WebContext.cpp: * UIProcess/WebContextUserMessageCoders.h: * UIProcess/WebPageProxy.cpp: * UIProcess/WebPageProxy.h: Pass the WebProcess/WebProcessProxy to both encode and decode. * Shared/WebPageCreationParameters.h: Pass the page group by ID when creating a page, as it will have had its own creation message sent already. * UIProcess/WebPageGroup.cpp: * UIProcess/WebPageGroup.h: Keep track of processes. * UIProcess/WebProcessProxy.cpp: * UIProcess/WebProcessProxy.h: Keep track of the page groups used by the process. * WebProcess/WebPage/WebPage.cpp: Get the already create page group on creation. * WebProcess/WebProcess.cpp: * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Explicitly create page groups in the WebProcess. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124819 Reviewed by Dan Bernstein. Source/WebCore: * Modules/indexeddb/IDBDatabaseBackend.cpp: (WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory. Source/WebKit2: UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them. * DatabaseProcess/DatabaseProcess.cpp: (WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase): (WebKit::DatabaseProcess::removeUniqueIDBDatabase): * DatabaseProcess/DatabaseProcess.h: * DatabaseProcess/DatabaseToWebProcessConnection.h: Start forwarding things along to the appropriate UniqueIDBDatabase. * DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp: (WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection): (WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess): (WebKit::DatabaseProcessIDBConnection::establishConnection): (WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): * DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h: A class that represents a single concrete IDB database that multiple WebProcesses can connect to. * DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp: (WebKit::UniqueIDBDatabase::UniqueIDBDatabase): (WebKit::UniqueIDBDatabase::~UniqueIDBDatabase): (WebKit::UniqueIDBDatabase::registerConnection): (WebKit::UniqueIDBDatabase::unregisterConnection): (WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata): * DatabaseProcess/IndexedDB/UniqueIDBDatabase.h: (WebKit::UniqueIDBDatabase::create): (WebKit::UniqueIDBDatabase::identifier): A class to help uniquely identify an IDBDatabase that can be expanded as needed. Importantly, it knows how to be used as a key in a HashMap. * DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added. (WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier): (WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue): (WebKit::UniqueIDBDatabaseIdentifier::hash): (WebKit::UniqueIDBDatabaseIdentifier::isNull): (WebKit::operator==): * DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added. (WebKit::UniqueIDBDatabaseIdentifier::databaseName): (WebKit::UniqueIDBDatabaseIdentifier::openingOrigin): (WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin): (WebKit::UniqueIDBDatabaseIdentifierHash::hash): (WebKit::UniqueIDBDatabaseIdentifierHash::equal): (WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue): * Shared/SecurityOriginData.cpp: (WebKit::operator==): * Shared/SecurityOriginData.h: * UIProcess/WebContext.cpp: * WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: (WebKit::WebIDBFactoryBackend::open): (WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend): * WebKit2.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114298 Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24 Reviewed by Anders Carlsson. Adding SpatialNavigation support to WebPreferencesStore allows us to toggle that feature on WebKitSettings. * Shared/WebPreferencesStore.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetSpatialNavigationEnabled): (WKPreferencesGetSpatialNavigationEnabled): * UIProcess/API/C/WKPreferences.h: * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsSetProperty): (webKitSettingsGetProperty): (webkit_settings_class_init): (webkit_settings_set_enable_spatial_navigation): (webkit_settings_get_enable_spatial_navigation): * UIProcess/API/gtk/WebKitSettings.h: * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettings): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 Nov, 2013 1 commit
-
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124804 Reviewed by Dean Jackson and Benjamin Poulain. * DatabaseProcess/DatabaseProcess.cpp: (WebKit::DatabaseProcess::initializeDatabaseProcess): * DatabaseProcess/DatabaseProcess.h: (WebKit::DatabaseProcess::indexedDatabaseDirectory): * DatabaseProcess/DatabaseProcess.messages.in: * Shared/Databases/DatabaseProcessCreationParameters.cpp: Added. (WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters): (WebKit::DatabaseProcessCreationParameters::encode): (WebKit::DatabaseProcessCreationParameters::decode): * Shared/Databases/DatabaseProcessCreationParameters.h: Added. * UIProcess/WebContext.cpp: (WebKit::WebContext::ensureDatabaseProcess): * WebKit2.xcodeproj/project.pbxproj: * Scripts/webkit2/messages.py: (struct_or_class): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 22 Nov, 2013 6 commits
-
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=124806 Reviewed by Tim Horton. * Platform/CoreIPC/Connection.h: Include atomic header. * UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize. (WebKit::WebView::didChangeContentSize): * UIProcess/CoordinatedGraphics/WebView.h: Ditto. * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
There's probably a better fix, but this will work for now. * UIProcess/API/mac/WKView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124803 Reviewed by Anders Carlsson and Tim Horton. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124798 Reviewed by Geoffrey Garen. Source/WebCore: Make full screen windows movable by default. Previously, we wanted non-movable full screen windows since they were in the same space and were just placed atop non-full screen windows. Now that all our supported Mac platforms have explicit full screen support, we can remove this non-movable restriction. * platform/mac/WebCoreFullScreenWindow.mm: (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]): Source/WebKit2: Make full screen windows resizable by default. This allows the window to be resized when moved between monitors with different resolutions. * UIProcess/API/mac/WKView.mm: (-[WKView createFullScreenWindow]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124797 Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22 Reviewed by Alexey Proskuryakov. * NetworkProcess/NetworkResourceLoader.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124794 Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22 Reviewed by Alexey Proskuryakov. * NetworkProcess/AsynchronousNetworkLoaderClient.cpp: (WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer): * NetworkProcess/NetworkResourceLoader.h: * NetworkProcess/SynchronousNetworkLoaderClient.cpp: (WebKit::SynchronousNetworkLoaderClient::willSendRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-