Commits · c69c100b2e910c8dec2942f79b95026802d292b1 · App_Technologies / webkit

05 Jun, 2010 18 commits

Do not pass empty handles to v8. · c69c100b

dumi@chromium.org authored Jun 05, 2010

https://bugs.webkit.org/show_bug.cgi?id=39896

Reviewed by Adam Barth.

Passing an empty handle to v8 results in a crash with a stack
trace that doesn't give us much information about the cause of the
crash. Instead, if we check the handles we pass to v8 and crash
when they are empty, we do not make things worse, and should get a
more informative stack trace.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c69c100b

2010-05-30 Antonio Gomes <tonikitoo@webkit.org> · ea9821e1

tonikitoo@webkit.org authored Jun 05, 2010

        Reviewed by Darin Adler.

        Add a convenient helper getter for Frame* to RenderObject
        https://bugs.webkit.org/show_bug.cgi?id=39928

        document()->frame() is being called enough from RenderObject derivated classes
        that it worth adding a helper Frame getter as a shortcut.

        No behavior change, so no new tests.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isOffScreen):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::selection):
        (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
        * page/EventHandler.cpp:
        (WebCore::canAutoscroll):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintCustomHighlight):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::isActive):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::flattenFrameSet):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintFocusRings):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addDashboardRegions):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::~RenderLayer):
        (WebCore::RenderLayer::panScrollFromPoint):
        (WebCore::RenderLayer::scrollByRecursively):
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::autoscroll):
        (WebCore::RenderLayer::isActive):
        (showLayerTree):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::inspectorTimelineAgent):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        (WebCore::RenderListBox::panScroll):
        (WebCore::RenderListBox::autoscroll):
        (WebCore::RenderListBox::isActive):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::~RenderObject):
        (WebCore::RenderObject::selectionBackgroundColor):
        (WebCore::RenderObject::selectionForegroundColor):
        (WebCore::RenderObject::destroy):
        (WebCore::RenderObject::addDashboardRegions):
        (WebCore::RenderObject::animation):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::document):
        (WebCore::RenderObject::frame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ea9821e1

2010-06-05 Jonathan Kliegman <kliegs@chromium.org> · 6a844585

eric@webkit.org authored Jun 05, 2010

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

* platform/mac/svg/custom/fill-opacity-hsl-expected.checksum: Added.
* platform/mac/svg/custom/fill-opacity-hsl-expected.png: Added.
* platform/mac/svg/custom/fill-opacity-hsl-expected.txt: Added.
* platform/mac/svg/custom/fill-opacity-rgba-expected.checksum: Added.
* platform/mac/svg/custom/fill-opacity-rgba-expected.png: Added.
* platform/mac/svg/custom/fill-opacity-rgba-expected.txt: Added.
* svg/custom/fill-opacity-hsl.svg: Added.
* svg/custom/fill-opacity-rgba.svg: Added.
2010-06-05 Jonathan Kliegman <kliegs@chromium.org>

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

Removed unused svg paramater from CSSParser::parseColorFromValue

Tests: svg/custom/fill-opacity-hsl.svg
svg/custom/fill-opacity-rgba.svg

* css/CSSParser.cpp:
(WebCore::CSSParser::parseColorFromValue):
* css/CSSParser.h:
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGPaint):
(WebCore::CSSParser::parseSVGColor):
* svg/SVGColor.cpp:
(WebCore::SVGColor::colorFromRGBColorString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6a844585

2010-06-05 Anders Bakken <agbakken@gmail.com> · a4568ea4

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] ContextMenuItemQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39780

        * platform/qt/ContextMenuItemQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a4568ea4

2010-06-05 Anders Bakken <agbakken@gmail.com> · 0770cf36

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] ContextMenuQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39779

        * platform/qt/ContextMenuQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0770cf36

2010-06-05 Anders Bakken <agbakken@gmail.com> · 6c0b4660

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] DragDataQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39777

        * platform/qt/DragDataQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6c0b4660

2010-06-05 Anders Bakken <agbakken@gmail.com> · 4dd3b734

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] FileChooserQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39776

        * platform/qt/FileChooserQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4dd3b734

2010-06-05 Anders Bakken <agbakken@gmail.com> · 08a7dfa0

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] FileSystemQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39775

        * platform/qt/FileSystemQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

08a7dfa0

2010-06-05 Anders Bakken <agbakken@gmail.com> · 027ad2ed

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] KURLQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39774

        * platform/qt/KURLQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

027ad2ed

2010-06-05 Anders Bakken <agbakken@gmail.com> · 25cebac5

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] LoggingQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39772

        * platform/qt/LoggingQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

25cebac5

2010-06-05 Anders Bakken <agbakken@gmail.com> · f5cd3b4b

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] PlatformKeyboardEventQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39770

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::keyIdentifierForQtKeyCode):
        (WebCore::windowsKeyCodeForKeyEvent):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f5cd3b4b

2010-06-05 Anders Bakken <agbakken@gmail.com> · e9d6db66

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] PlatformScreenQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39768

        * platform/qt/PlatformMouseEventQt.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e9d6db66

2010-06-05 Anders Bakken <agbakken@gmail.com> · 5f664d66

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] RenderThemeQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39767

        * platform/qt/RenderThemeQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5f664d66

2010-06-05 Anders Bakken <agbakken@gmail.com> · fff8d6c2

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] ScrollbarQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39765

        * platform/qt/ScrollbarQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fff8d6c2

2010-06-05 Kwang Yul Seo <skyul@company100.net> · 0778ae4d

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [BREWMP] Add PLATFORM(BREWMP) guard for using std::xxx
        https://bugs.webkit.org/show_bug.cgi?id=39710

        Build fix for BREW MP.

        * wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0778ae4d

2010-06-04 Adam Barth <abarth@webkit.org> · 9e58a901

abarth@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        Make HTML5Lexer go fast
        https://bugs.webkit.org/show_bug.cgi?id=40048

        This patch changes us from using a jump table for each character to
        using absolute jumps between parser states.  This appears to be about a
        1% improvement on the parser bench mark (which is 1/10th of what we
        need to catch the old parser).

        I've kept the underlying logic as close to the old logic as possible.
        This new form will make it easier to handle the input stream part of
        the spec and to make further performance improvements.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::reset):
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::HTML5Lexer::emitCurrentToken):
        * html/HTML5Lexer.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9e58a901

2010-06-04 Adam Barth <abarth@webkit.org> · 004ef1e1

abarth@webkit.org authored Jun 05, 2010

        Reviewed by Darin Adler.

        HTML5 parser should be within 1% of old parser performance
        https://bugs.webkit.org/show_bug.cgi?id=40172

        Fix cast in this operator= to allow for assignment between vectors with
        different inline capacities (as clearly intended by its author).

        * wtf/Vector.h:
        (WTF::::operator):
2010-06-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        HTML5 parser should be within 1% of old parser performance
        https://bugs.webkit.org/show_bug.cgi?id=40172

        Stop using adopt().  I think this function is cause us to do extra
        mallocs that are hurting performance.  Instead of caching AtomicString
        on HTML5Token, just use the AtomicString on the old token.  Also,
        reserve inline capacity for 10 attributes.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::isAppropriateEndTag):
        * html/HTML5Lexer.h:
        * html/HTML5Token.h:
        (WebCore::HTML5Token::beginStartTag):
        (WebCore::HTML5Token::beginEndTag):
        (WebCore::HTML5Token::beginCharacter):
        (WebCore::HTML5Token::beginComment):
        (WebCore::HTML5Token::beginDOCTYPE):
        (WebCore::HTML5Token::name):
        (WebCore::HTML5Token::characters):
        (WebCore::HTML5Token::comment):
        * html/HTML5TreeBuilder.cpp:
        (WebCore::convertToOldStyle):
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

004ef1e1

2010-06-04 Anders Bakken <agbakken@gmail.com> · 631c2fb2

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] ScrollbarThemeQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39764

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::scPart):
        (WebCore::scrollbarPart):
        (WebCore::styleOptionSlider):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

631c2fb2

04 Jun, 2010 22 commits

2010-06-04 Anders Bakken <agbakken@gmail.com> · 10b9187d

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] SharedTimerQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39763

        * platform/qt/SharedTimerQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10b9187d

2010-06-04 Anders Bakken <agbakken@gmail.com> · 0885b1b8

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        WidgetQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39759

        * platform/qt/WidgetQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0885b1b8

2010-06-04 Anders Bakken <agbakken@gmail.com> · e0b5d014

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        TemporaryLinkStubsQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39761

        * platform/qt/TemporaryLinkStubsQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e0b5d014

2010-06-04 Anders Bakken <agbakken@gmail.com> · f34d60fe

eric@webkit.org authored Jun 05, 2010

        Reviewed by Eric Seidel.

        [Qt] SoundQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39762

        * platform/qt/SoundQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f34d60fe

2010-06-04 Tony Gentilcore <tonyg@chromium.org> · 318b030f

eric@webkit.org authored Jun 05, 2010

        Reviewed by Ojan Vafai.

        Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
        https://bugs.webkit.org/show_bug.cgi?id=40183

        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

318b030f

2010-06-04 Andreas Kling <andreas.kling@nokia.com> · a561090f

eric@webkit.org authored Jun 05, 2010

        Reviewed by Dirk Schulze.

        Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
        https://bugs.webkit.org/show_bug.cgi?id=40166

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

        * http/tests/misc/canvas-pattern-from-incremental-image-expected.txt: Updated baseline.
        * http/tests/misc/canvas-pattern-from-incremental-image.html: Fleshed out test.
2010-06-04  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Dirk Schulze.

        Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
        https://bugs.webkit.org/show_bug.cgi?id=40166

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

        Test: http/tests/misc/canvas-pattern-from-incremental-image.html (updated)

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createPattern):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a561090f

2010-06-04 Anders Bakken <agbakken@gmail.com> · 3e10defe

eric@webkit.org authored Jun 05, 2010

        Reviewed by David Levin.

        [Qt] Localizations.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39773

        * platform/qt/Localizations.cpp:
        (WebCore::localizedMediaTimeDescription):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3e10defe

2010-06-04 Lyon Chen <liachen@rim.com> · 61840bb6

eric@webkit.org authored Jun 05, 2010

        Reviewed by Darin Adler.

        ApplicationCacheStorage::storeNewestCache() Crash WebKit when openDatabase(true) failed
        https://bugs.webkit.org/show_bug.cgi?id=40074

        Adding m_database.isOpen() check for every openDatabase(true) call, this is needed because
        openDatabase(true) could still fail, for example when cacheStorage is full or no longer available.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store):
        (WebCore::ApplicationCacheStorage::storeNewestCache):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

61840bb6

2010-06-04 Sheriff Bot <webkit.review.bot@gmail.com> · a0bcd619

eric@webkit.org authored Jun 05, 2010

        Unreviewed, rolling out r60684.
        http://trac.webkit.org/changeset/60684
        https://bugs.webkit.org/show_bug.cgi?id=40196

        This patch broke chromium reliability tests (Requested by
        tonyg-cr on #webkit).

        * bindings/v8/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::compileScript):
        (WebCore::V8Proxy::evaluate):
        * bindings/v8/V8Proxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a0bcd619

AX: need an aria-help · 2adb5a15

cfleizach@apple.com authored Jun 05, 2010

https://bugs.webkit.org/show_bug.cgi?id=40010

Reviewed by David Kilzer.

WebCore: 

Test: accessibility/aria-help.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
* html/HTMLAttributeNames.in:

LayoutTests: 

* accessibility/aria-help-expected.txt: Added.
* accessibility/aria-help.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2adb5a15

2010-06-04 Andreas Kling <andreas.kling@nokia.com> · 32d242c0

eric@webkit.org authored Jun 05, 2010

        Reviewed by Tor Arne Vestbø.

        [Qt] Canvas arc() with zero radius should draw a line to the start point
        https://bugs.webkit.org/show_bug.cgi?id=40164

        Unskip canvas/philip/tests/2d.path.arc.zeroradius.html

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

        * platform/qt/Skipped:
2010-06-04  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Canvas arc() with zero radius should draw a line to the start point
        https://bugs.webkit.org/show_bug.cgi?id=40164

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::addArc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

32d242c0

2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 55f4f310

eric@webkit.org authored Jun 05, 2010

        Reviewed by Kenneth Rohde Christiansen.

        New QtScript API; QScriptValue::instanceOf.

        New function create an easy way to check value's prototype hierarchy.

        [Qt] QScriptValue should have an instanceOf method
        https://bugs.webkit.org/show_bug.cgi?id=40120

        * qt/api/qscriptvalue.cpp:
        (QScriptValue::instanceOf):
        * qt/api/qscriptvalue.h:
        * qt/api/qscriptvalue_p.h:
        (QScriptValuePrivate::instanceOf):
        * qt/tests/qscriptvalue/tst_qscriptvalue.h:
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp:
        (tst_QScriptValue::instanceOf_initData):
        (tst_QScriptValue::instanceOf_makeData):
        (tst_QScriptValue::instanceOf_test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

55f4f310

2010-06-04 Martin Robinson <mrobinson@igalia.com> · 361868bb

mrobinson@webkit.org authored Jun 05, 2010

        Reviewed by Xan Lopez.

        [GTK] RenderThemeGtk leaks memory
        https://bugs.webkit.org/show_bug.cgi?id=40168

        Call gtk_widget_destroy in the RenderThemeGtk destructor. This cleans
        up all widget resources when a theme is destroyed.

        No new tests, because functionality has not changed.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::~RenderThemeGtk): Call gtk_widget_destroy on m_gtkWindow.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

361868bb

2010-06-04 Martin Robinson <mrobinson@igalia.com> · 83d27ad2

mrobinson@webkit.org authored Jun 05, 2010

        Reviewed by Xan Lopez.

        [GTK] RenderThemeGtk leaks memory
        https://bugs.webkit.org/show_bug.cgi?id=40168

        Remove the use of releaseRef to assign a value to a RefPtr. This results in
        the original pointer taking an extra reference.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::initMediaStyling): Remove the use of releaseRef here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

83d27ad2

WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars · 4cb0e26d

alice.liu@apple.com authored Jun 05, 2010

https://bugs.webkit.org/show_bug.cgi?id=40034
<rdar://problem/7799848>

Reviewed by Jon Honeycutt.

* WebFrame.cpp:
(WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint. 
Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().

Just renaming changes:
* Interfaces/IWebFramePrivate.idl:
* Interfaces/IWebViewPrivate.idl:
* WebFrame.h:
* WebView.cpp:
(WebView::paintScrollViewRectToContextAtPoint):
* WebView.h:

* Interfaces/WebKit.idl: Touched for rebuild.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4cb0e26d

Added a couple of symbols needed to start using WKFrameRefs in Mac clients. · db607abc

sullivan@apple.com authored Jun 04, 2010

Rubber-stamped by Ada Chan.

* mac/WebKit2.exp:
Added _WKFrameRelease and _WKFrameRetain.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

db607abc

* interpreter/Interpreter.cpp: · 96438ccc

barraclough@apple.com authored Jun 04, 2010

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (interpreter build fix).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

96438ccc

Actually disable the correct warning. · 693d6ac9

abarth@webkit.org authored Jun 04, 2010

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

693d6ac9

2010-06-04 Martin Robinson <mrobinson@igalia.com> · e46e8bc7

mrobinson@webkit.org authored Jun 04, 2010

        Unreviewed.

        Add my new email and IRC nick to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e46e8bc7

2010-06-04 Adam Barth <abarth@webkit.org> · de729b70

abarth@webkit.org authored Jun 04, 2010

        Reviewed by Gavin Barraclough.

        Try to fix the windows build
        https://bugs.webkit.org/show_bug.cgi?id=40189

        Suppress the "unreachable code" warning because we want to assert that
        we don't reach certain code points.

        * html/HTML5Lexer.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

de729b70

Silence some warnings seen on the build bot. · c83e0cff

mrowe@apple.com authored Jun 04, 2010

* JavaScriptCore.JSVALUE32_64only.exp: Add a trailing newline.
* JavaScriptCore.JSVALUE32only.exp: Ditto.
* JavaScriptCore.JSVALUE64only.exp: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Remove the .exp files from all targets so that Xcode doesn't
complain about not knowing how to compile them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c83e0cff

2010-06-04 Martin Robinson <mrobinson@igalia.com> · f7379d5a

mrobinson@webkit.org authored Jun 04, 2010

        Unreviewed.

        Skipping another test which shows 1-pixel differences between the
        32-bit and 64-bit bot.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f7379d5a