- 08 Feb, 2012 3 commits
-
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78081 Reviewed by Adam Barth. [CustomPushEventHandlerScope] is a JSC-specific IDL attribute. This patch renames it to [JSCustomPushEventHandlerScope] No tests. No change in behavior. * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): * dom/Node.idl: * html/HTMLElement.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77959 Reviewed by Martin Robinson. Add a new WebKitGTK WebSetting to enable/disable WebAudio at runtime. * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsSetProperty): (webKitSettingsGetProperty): (webkit_settings_class_init): (webkit_settings_get_enable_webaudio): (webkit_settings_set_enable_webaudio): * UIProcess/API/gtk/WebKitSettings.h: * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76789 Reviewed by Philippe Normand. Add a WebKitResponsePolicyDecision GObject, use it for response policy decisions and add a test. * GNUmakefile.am: Added new source files to the list. * UIProcess/API/gtk/WebKitPolicyClient.cpp: (decidePolicyForResponseCallback): Added this callback which creates the request and fires the signal. (attachPolicyClientToPage): Added new callback to the C API policy client. * UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added. * UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added. * UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added. * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs. * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto. * UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp: (testResponsePolicy): Added this test for response policy decisions. (serverCallback): Added a SoupServer to test policy response policy decisions. (beforeAll): Ditto. (afterAll): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Feb, 2012 37 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78067 Patch by James Robinson <jamesr@chromium.org> on 2012-02-07 Reviewed by Adam Barth. Source/Platform: This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public. These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a bit of an issue. I've added an extra build step to copy the specific headers used into the SHARED_INTERMEDIATE_DIR to preserve this inlining. Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing that requires non-trivial modifications to every build system in WebKit. * Platform.gyp/Platform.gyp: * Platform.gyp/copy_webcore_headers.py: Added. (CopyHeaders): (Main): * chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h. (WebKit): (WebFloatPoint): (WebKit::WebFloatPoint::WebFloatPoint): (WebKit::WebFloatPoint::operator=): (WebKit::WebFloatPoint::operator WebCore::FloatPoint): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h. (WebKit): (WebFloatQuad): (WebKit::WebFloatQuad::WebFloatQuad): (WebKit::WebFloatQuad::operator=): * chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h. (WebKit): (WebFloatRect): (WebKit::WebFloatRect::isEmpty): (WebKit::WebFloatRect::WebFloatRect): (WebKit::WebFloatRect::operator=): (WebKit::WebFloatRect::operator WebCore::FloatRect): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h. (WebKit): (WebPoint): (WebKit::WebPoint::WebPoint): (WebKit::WebPoint::operator=): (WebKit::WebPoint::operator WebCore::IntPoint): (WebKit::WebPoint::operator gfx::Point): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h. (WebKit): (WebRect): (WebKit::WebRect::isEmpty): (WebKit::WebRect::WebRect): (WebKit::WebRect::operator=): (WebKit::WebRect::operator WebCore::IntRect): (WebKit::WebRect::operator gfx::Rect): (WebKit::operator==): (WebKit::operator!=): * chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h. (WebKit): (WebSize): (WebKit::WebSize::isEmpty): (WebKit::WebSize::WebSize): (WebKit::WebSize::operator=): (WebKit::WebSize::operator WebCore::IntSize): (WebKit::WebSize::operator gfx::Size): (WebKit::operator==): (WebKit::operator!=): Source/WebKit/chromium: Add forwarding headers for several API types moved into Platform. * public/platform/WebFloatPoint.h: * public/platform/WebFloatQuad.h: * public/platform/WebFloatRect.h: * public/platform/WebPoint.h: * public/platform/WebRect.h: * public/platform/WebSize.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77846 Reviewed by Darin Adler. In bug 77693, we have added "JS" prefix to several JSC specific IDLs. This patch adds "JS" prefix to the remaining JSC specific IDLs. Specifically, this patch renames IDLs as follows: [CustomDefineOwnProperty] => [JSCustomDefineOwnProperty] [CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty] [GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency with [JSGenerateToJS] and [JSCustomToNativeObject]) [DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS", should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot]) No tests. No change in behavior. * bindings/scripts/CodeGeneratorJS.pm: (GenerateGetOwnPropertySlotBody): (GenerateGetOwnPropertyDescriptorBody): (GenerateHeader): (GenerateImplementation): * bindings/scripts/test/TestTypedArray.idl: * dom/Attr.idl: * dom/DataTransferItemList.idl: * dom/Document.idl: * dom/DocumentType.idl: * dom/Element.idl: * dom/Node.idl: * fileapi/DirectoryEntry.idl: * fileapi/DirectoryEntrySync.idl: * fileapi/File.idl: * fileapi/FileEntry.idl: * fileapi/FileEntrySync.idl: * fileapi/WebKitBlobBuilder.idl: * html/DOMFormData.idl: * html/DOMURL.idl: * html/HTMLAppletElement.idl: * html/HTMLCanvasElement.idl: * html/HTMLElement.idl: * html/HTMLEmbedElement.idl: * html/HTMLImageElement.idl: * html/HTMLMediaElement.idl: * html/HTMLObjectElement.idl: * html/HTMLOptionElement.idl: * html/HTMLOptionsCollection.idl: * html/HTMLTableCaptionElement.idl: * html/HTMLTableSectionElement.idl: * html/HTMLVideoElement.idl: * html/TextTrackCue.idl: * html/canvas/Float32Array.idl: * html/canvas/Float64Array.idl: * html/canvas/Int16Array.idl: * html/canvas/Int32Array.idl: * html/canvas/Int8Array.idl: * html/canvas/Uint16Array.idl: * html/canvas/Uint32Array.idl: * html/canvas/Uint8Array.idl: * html/canvas/Uint8ClampedArray.idl: * mediastream/LocalMediaStream.idl: * page/DOMWindow.idl: * page/History.idl: * page/Location.idl: * storage/StorageInfo.idl: * svg/SVGElement.idl: * svg/SVGElementInstance.idl: * workers/DedicatedWorkerContext.idl: * workers/SharedWorker.idl: * workers/SharedWorkerContext.idl: * workers/Worker.idl: * workers/WorkerContext.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78066 Reviewed by Ryosuke Niwa. Added a new default constructor. ex-default constructor will be removed in an upcoming change. * public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult): (WebTextCheckingResult): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78076 Reviewed by Adam Barth. This patch renames the [HasOverridingNameGetter] attribute to the [CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter]. Test: bindings/scripts/test/TestCustomNamedGetter.idl * bindings/scripts/CodeGeneratorJS.pm: (GenerateGetOwnPropertySlotBody): (GenerateGetOwnPropertyDescriptorBody): (GenerateHeader): (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeaderNamedAndIndexedPropertyAccessors): (GenerateImplementationNamedPropertyGetter): * html/HTMLDocument.idl: * html/HTMLFormElement.idl: * html/HTMLFrameSetElement.idl: * bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl. * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results. (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate): (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate): (WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter): (WebDOMTestCustomNamedGetter::operator=): (WebDOMTestCustomNamedGetter::impl): (WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter): (WebDOMTestCustomNamedGetter::anotherFunction): (toWebCore): (toWebKit): * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto. (WebCore): (WebDOMTestCustomNamedGetter): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto. (WebKit): (WebKit::kit): (webkit_dom_test_custom_named_getter_another_function): (WebKit::core): (webkit_dom_test_custom_named_getter_finalize): (webkit_dom_test_custom_named_getter_set_property): (webkit_dom_test_custom_named_getter_get_property): (webkit_dom_test_custom_named_getter_constructed): (webkit_dom_test_custom_named_getter_class_init): (webkit_dom_test_custom_named_getter_init): (WebKit::wrapTestCustomNamedGetter): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto. (_WebKitDOMTestCustomNamedGetter): (_WebKitDOMTestCustomNamedGetterClass): * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto. (WebKit): * bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto. * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto. (WebCore): (WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetterConstructor::finishCreation): (WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor): (WebCore::JSTestCustomNamedGetterPrototype::self): (WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor): (WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter): (WebCore::JSTestCustomNamedGetter::finishCreation): (WebCore::JSTestCustomNamedGetter::createPrototype): (WebCore::JSTestCustomNamedGetter::destroy): (WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): (WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor): (WebCore::jsTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetter::getConstructor): (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction): (WebCore::isObservable): (WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots): (WebCore::JSTestCustomNamedGetterOwner::finalize): (WebCore::toJS): (WebCore::toTestCustomNamedGetter): * bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto. (WebCore): (JSTestCustomNamedGetter): (WebCore::JSTestCustomNamedGetter::create): (WebCore::JSTestCustomNamedGetter::createStructure): (WebCore::JSTestCustomNamedGetter::impl): (WebCore::JSTestCustomNamedGetter::releaseImpl): (WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull): (JSTestCustomNamedGetterOwner): (WebCore::wrapperOwner): (WebCore::wrapperContext): (JSTestCustomNamedGetterPrototype): (WebCore::JSTestCustomNamedGetterPrototype::create): (WebCore::JSTestCustomNamedGetterPrototype::createStructure): (WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype): (JSTestCustomNamedGetterConstructor): (WebCore::JSTestCustomNamedGetterConstructor::create): (WebCore::JSTestCustomNamedGetterConstructor::createStructure): * bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: * bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto. * bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto. (-[DOMTestCustomNamedGetter dealloc]): (-[DOMTestCustomNamedGetter finalize]): (-[DOMTestCustomNamedGetter anotherFunction:]): (core): (kit): * bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto. (WebCore): * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto. (WebCore): (TestCustomNamedGetterInternal): (WebCore::TestCustomNamedGetterInternal::V8_USE): (WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback): (WebCore::ConfigureV8TestCustomNamedGetterTemplate): (WebCore::V8TestCustomNamedGetter::GetRawTemplate): (WebCore::V8TestCustomNamedGetter::GetTemplate): (WebCore::V8TestCustomNamedGetter::HasInstance): (WebCore::V8TestCustomNamedGetter::wrapSlow): (WebCore::V8TestCustomNamedGetter::derefObject): * bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto. (WebCore): (V8TestCustomNamedGetter): (WebCore::V8TestCustomNamedGetter::toNative): (WebCore::V8TestCustomNamedGetter::existingWrapper): (WebCore::V8TestCustomNamedGetter::wrap): (WebCore::toV8): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77918 Reviewed by Eric Seidel. Change RenderTableSection cell width, row height and border calculations back to use integers. Table layout is done on integer bounds to comply with the specification and to ensure that columns given the same width, including percentage widths, are rendered with identical widths. The same applies to heights. No new tests. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellLogicalWidths): (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::calcOuterBorderBefore): (WebCore::RenderTableSection::calcOuterBorderAfter): (WebCore::RenderTableSection::calcOuterBorderStart): (WebCore::RenderTableSection::calcOuterBorderEnd): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::nodeAtPoint): * rendering/RenderTableSection.h: (RenderTableSection): (WebCore::RenderTableSection::RowStruct::RowStruct): (WebCore::RenderTableSection::outerBorderBefore): (WebCore::RenderTableSection::outerBorderAfter): (WebCore::RenderTableSection::outerBorderStart): (WebCore::RenderTableSection::outerBorderEnd): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78061 Patch by Gregg Tavares <gman@google.com> on 2012-02-07 Reviewed by Kenneth Russell. * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
gesture recognizer. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * wtf/Platform.h: Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * WebCore.gypi: * platform/PlatformGestureRecognizer.h: Removed. * platform/chromium/FramelessScrollView.h: (WebCore): (FramelessScrollView): * platform/chromium/GestureRecognizerChromium.cpp: Removed. * platform/chromium/GestureRecognizerChromium.h: Removed. * platform/chromium/PopupContainer.cpp: (WebCore): * platform/chromium/PopupContainer.h: * platform/chromium/PopupListBox.cpp: (WebCore): * platform/chromium/PopupListBox.h: (PopupListBox): Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * blackberry/WebCoreSupport/AboutDataEnableFeatures.in: Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * WebKit.gypi: * features.gypi: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFrameView): * src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::handleTouchEvent): * src/WebPopupMenuImpl.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::touchEvent): * src/WebViewImpl.h: (WebCore): (WebViewImpl): * tests/InnerGestureRecognizerTest.cpp: Removed. LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests. https://bugs.webkit.org/show_bug.cgi?id=77492 Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07 Reviewed by Adam Barth. * fast/events/touch/page-scaled-touch-gesture-click-expected.txt: * fast/events/touch/page-scaled-touch-gesture-click.html: * fast/events/touch/touch-gesture-click-expected.txt: Removed. * fast/events/touch/touch-gesture-click.html: Removed. * fast/events/touch/touch-gesture-scroll-expected.txt: Removed. * fast/events/touch/touch-gesture-scroll.html: Removed. * platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed. * platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
arv@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78052 Reviewed by Nate Chapin. Source/WebCore: Before this patch the code generator did not add the named hidden reference when the data node was a DOM Node. This lead to us having to create custom toV8 bindings in a few places. Covered by existing tests * Target.pri: * UseV8.cmake: * WebCore.gypi: * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter): (HasCustomToV8Implementation): * bindings/v8/custom/V8DOMStringMapCustom.cpp: * bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed. * bindings/v8/custom/V8NamedNodeMapCustom.cpp: LayoutTests: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78059 Reviewed by Adam Barth. CodeGeneratorGObject.pm does not support custom attributes. We can skip generating code for attributes with [Custom]. The change would make sense, since CodeGeneratorGObject.pm already skips attributes with [CustomGetter] or [CustomSetter]. Test: bindings/scripts/test/TestObj.idl * bindings/scripts/CodeGeneratorGObject.pm: (SkipAttribute): * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leo.yang@torchmobile.com.cn authored
https://bugs.webkit.org/show_bug.cgi?id=77843 Reviewed by Rob Buis. Initial upstream, no new tests. * blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added. * blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78040 Reviewed by Eric Seidel. Add pixel snapped versions of x/y/width/height methods. These return the same value as the x/w/width/height methods for now but once we move over to sub pixel layout they will snap the subpixel value to a device pixel and return an integer value. When snapping the left and top edge is simply rounded to the nearest device pixel. The right and bottom edges are computed by subtracting the rounded left/ top edge from the precise location and size. This ensures that the edges all line up with device pixels and that the total size of an object, including borders, is at most one pixel off. In summary, the values are computed as follows: x: round(x) y: round(y) maxX: round(x + width) maxY: round(y + height) width: round(x + width) - round(x) height: round(y + height) - round(y) We use the term pixel snapped to indicate that the numbers are not merely rounded. This also matches the naming used by the line box tree. No new tests, no functionality changes. * page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): * rendering/RenderBlock.cpp: (WebCore::::collectIfNeeded): * rendering/RenderBlock.h: (RenderBlock): (WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): (WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): (WebCore::RenderBlock::FloatingObject::pixelSnappedX): (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): (WebCore::RenderBlock::FloatingObject::pixelSnappedY): (WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): (WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): (WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): (FloatingObject): (WebCore::RenderBlock::pixelSnappedLogicalTopForFloat): (WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat): (WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat): (WebCore::RenderBlock::pixelSnappedLogicalRightForFloat): * rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): * rendering/RenderBox.cpp: (WebCore::RenderBox::pixelSnappedClientWidth): (WebCore): (WebCore::RenderBox::pixelSnappedClientHeight): (WebCore::RenderBox::scrollHeight): * rendering/RenderBox.h: (WebCore::RenderBox::pixelSnappedWidth): (WebCore::RenderBox::pixelSnappedHeight): (RenderBox): (WebCore::RenderBox::pixelSnappedOffsetWidth): (WebCore::RenderBox::pixelSnappedOffsetHeight): (WebCore::RenderBox::clientLogicalWidth): (WebCore::RenderBox::clientLogicalHeight): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth): (WebCore): (WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight): * rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft): (WebCore::RenderBoxModelObject::pixelSnappedOffsetTop): (RenderBoxModelObject): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::pixelSnappedScrollWidth): (WebCore): (WebCore::RenderLayer::pixelSnappedScrollHeight): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): * rendering/RenderLayer.h: (RenderLayer): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollHeight): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): * rendering/RenderTreeAsText.cpp: (WebCore::write): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg. * platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added. * platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added. * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikelawther@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77960 Source/WebCore: Adds simple number/percent expression evaluation. rgb() and hsl() functions now allow simple calc() expressions. Reviewed by Ojan Vafai. * css/CSSCalculationValue.cpp: (WebCore): (WebCore::CSSCalcValue::doubleValue): (WebCore::CSSCalcPrimitiveValue::doubleValue): (WebCore::CSSCalcBinaryOperation::doubleValue): (CSSCalcBinaryOperation): (WebCore::CSSCalcBinaryOperation::evaluate): * css/CSSCalculationValue.h: (CSSCalcExpressionNode): (WebCore::CSSCalcValue::isInt): (CSSCalcValue): * css/CSSParser.cpp: (WebCore::CSSParser::parsedDouble): LayoutTests: Reviewed by Ojan Vafai. * css3/calc/color-hsl-expected.txt: * css3/calc/color-rgb-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kling@webkit.org authored
<http://webkit.org/b/78068> Reviewed by Ryosuke Niwa. Create CSS_IDENT values for attribute styles in the document's CSSValuePool. This regressed in r106756 and I suspect it'll fix up the cycler regression. * dom/StyledElement.cpp: (WebCore::StyledElement::addCSSProperty): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
This also makes sure the inspector WKView is in a window before the page is loaded. This avoids some redundant work caused by moving it to a window later. https://webkit.org/b/78064 Reviewed by Brian Weinstein. * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here... (WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here. * UIProcess/WebInspectorProxy.h: (WebInspectorProxy): * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen. (WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged. (WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow. (WebKit::WebInspectorProxy::platformOpen): Make the view or window visible. (WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil. (WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle. (WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible. (WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window. (WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
noel.gordon@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=78055 Reviewed by Noam Rosenthal. TextureMapperQt.{cpp,h} were removed in r106659, remove references to these files from the gyp projects. * WebCore.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78036 Reviewed by Darin Adler. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. Source/WebCore: In r89362, we started running the preprocessor through CSSPropertyNames.in. Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in and wrap it in an #if. No new tests, build refactoring. * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. * DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in. * DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in. * WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in. * css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if. * css/DashboardSupportCSSPropertyNames.in: Removed. Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=75522 Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07 Reviewed by Tony Chang. Add the FFTFrame implementation using Intel IPP's DFT algorithm. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/audio/FFTFrame.h: (FFTFrame): * platform/audio/FFTFrameStub.cpp: * platform/audio/ipp/FFTFrameIPP.cpp: Added. (WebCore): (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enne@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=78033 Reviewed by James Robinson. There's no need to enumerate all tag names when searching for a top-level frame. If a render view's document has a frame, then that frame is not the top-level one. * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame): * rendering/RenderLayerCompositor.h: (RenderLayerCompositor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77907 Patch by Chris Palmer <palmer@google.com> on 2012-02-07 Reviewed by Eric Seidel. Source/WebCore: Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html. * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkTimerFired): LayoutTests: * http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added. * http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added. * http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added. * http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78039 Patch by Justin Novosad <junov@chromium.org> on 2012-02-07 Reviewed by Stephen White. Adding the --enable-deferred-2d-canvas switch to DumpRenderTree * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): (TestShell::runFileTest): * DumpRenderTree/chromium/TestShell.h: (TestShell::setDeferred2dCanvasEnabled): (TestShell): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78029 Patch by Yong Li <yoli@rim.com> on 2012-02-07 Reviewed by Rob Buis. When a redirect is rejected by security origin check, the ResourceRequest will be cleared (see DocumentThreadableLoader::redirectReceived()). In this case, we should stop handling the request. No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross -origin-tripmine.html) can cover this. * platform/network/blackberry/NetworkJob.cpp: (WebCore::NetworkJob::startNewJobWithRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=77928 Reviewed by Daniel Bates. CMake has used *Programs* directory for executable. In addition, shared libraries are being built in source directory. It is better to set common places in order to maintain executable and libraries. *bin* is for executable and *lib* is for library. .: * CMakeLists.txt: Set library output path. * Source/cmake/WebKitFS.cmake: Remove *Programs* creation. Source/JavaScriptCore: * shell/CMakeLists.txt: Change *Programs* with *bin*. Source/WebKit2: * CMakeLists.txt: Tools: * DumpRenderTree/efl/CMakeLists.txt: * EWebLauncher/CMakeLists.txt: * Scripts/run-launcher: * Scripts/webkitdirs.pm: (jscProductDir): * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._path_to_driver): (EflPort._path_to_image_diff): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78034 Source/WebCore: Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07 Reviewed by Eric Seidel. Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces. This patch removes a couple unused functions, some extra blank lines, unused #include directives, etc., and adds a very few WebKit-standard changes to these files. No new tests. * rendering/mathml/RenderMathMLBlock.cpp: (WebCore): * rendering/mathml/RenderMathMLBlock.h: (WebCore::RenderMathMLBlock::getBoxModelObjectHeight): - changed to a static member function since 'this' is unused; removed redundant non-const version (WebCore::RenderMathMLBlock::getBoxModelObjectWidth): - changed to a static member function since 'this' is unused; removed redundant non-const version (WebCore): * rendering/mathml/RenderMathMLFraction.cpp: * rendering/mathml/RenderMathMLMath.cpp: * rendering/mathml/RenderMathMLMath.h: * rendering/mathml/RenderMathMLOperator.h: (WebCore): * rendering/mathml/RenderMathMLRoot.cpp: * rendering/mathml/RenderMathMLRow.cpp: * rendering/mathml/RenderMathMLRow.h: * rendering/mathml/RenderMathMLSquareRoot.cpp: * rendering/mathml/RenderMathMLSquareRoot.h: * rendering/mathml/RenderMathMLSubSup.cpp: * rendering/mathml/RenderMathMLSubSup.h: * rendering/mathml/RenderMathMLUnderOver.cpp: * rendering/mathml/RenderMathMLUnderOver.h: LayoutTests: Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07 Reviewed by Eric Seidel. The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test environment timing issue, so I removed it. * mathml/presentation/row.xhtml: * platform/mac/mathml/presentation/row-expected.png: * platform/mac/mathml/presentation/row-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard. https://bugs.webkit.org/show_bug.cgi?id=78030 Unreviewed. Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07 * platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
If WKView was created and loaded a page with canvas elements before beinging moved to a window, the canvas elements would be locked in at a pixel ratio of 1. With this change the WKView will use the main screen's pixel ratio until it moves to a window. Reviewed by Anders Carlsson. * UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77833 Patch by Priit Laes <plaes@plaes.org> on 2012-02-07 Reviewed by Martin Robinson. Move checks from webkit.m4 to configure.ac and modernize macros: . Check for visibility flags after CXX has been defined . Use PKG_PROG_PKG_CONFIG for pkg-config lookup . Drop unused LIBFFTW_REQUIRED_VERSION . Update ICU libs for mingw (bug 77837). . Require Pango 1.21.0 (as per unicode backend) . Bump minimum glib version due to g_thread_init changes * Source/autotools/webkit.m4: Removed. * configure.ac: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78020 Patch by David Reveman <reveman@chromium.org> on 2012-02-07 Reviewed by James Robinson. Source/WebCore: Revert r101854. This patch is tested by the following unit test: - TextureManagerTest.requestTextureExceedingPreferredLimit * platform/graphics/chromium/ManagedTexture.cpp: (WebCore::ManagedTexture::reserve): * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::requestTexture): * platform/graphics/chromium/TextureManager.h: (TextureManager): Source/WebKit/chromium: Update TextureManagerTest.requestTextureExceedingPreferredLimit test. * tests/TextureManagerTest.cpp: (WTF::TextureManagerTest::requestTexture): (WTF::TEST_F): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78056 <rdar://problem/10247932> Reviewed by Sam Weinig. * page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::frameViewLayoutUpdated): Actually set the non-fast scrollable region on the scrolling tree state. * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::tryToHandleWheelEvent): Check if the wheel event's position is inside the non-fast-scrollable region and return false if it is. (WebCore::ScrollingTree::updateMainFrameScrollPosition): Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent. * platform/graphics/Region.cpp: * platform/graphics/Region.h: Add a simple contains(const IntPoint&) member function. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/10475450mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78044 Reviewed by Beth Dakin. Source/WebCore: Tests: fast/text/synthetic-bold-transformed-expected.html fast/text/synthetic-bold-transformed.html * platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels. LayoutTests: * fast/text/synthetic-bold-transformed-expected.html: Added. * fast/text/synthetic-bold-transformed.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77948 Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07 Reviewed by Eric Seidel. The value of editable in Ewk_Frame_Smart_Data struct is not set. * ewk/ewk_frame.cpp: (ewk_frame_editable_set): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77914 Reviewed by Eric Seidel. Updating ColumnInfo and RenderFrameSet to use LayoutUnits instead of directly referencing integers for locations and distances. No new tests. No changed behavior. * rendering/ColumnInfo.h: (WebCore::ColumnInfo::forcedBreakOffset): (WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks): (ColumnInfo): * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder): * rendering/RenderFrameSet.h: (RenderFrameSet): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adamk@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=70289 Reviewed by Eric Seidel. Source/WebCore: The meat of this change is in JSMainThreadExecState, where a counter is incremented every time WebCore calls into JSC and decremented every time it returns. When the counter reaches zero, any pending mutations are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope). The rest of the changes are of two sorts: compilation/logic fixes for JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional usages of JSMainThreadExecState so as to trigger the above increment/decrements at the appropriate times. * bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSDictionary.cpp: (WebCore::JSDictionary::convertValue): Add support for tryGetProperty with a HashMap<AtomicString>. * bindings/js/JSDictionary.h: * bindings/js/JSErrorHandler.cpp: (WebCore::JSErrorHandler::handleEvent): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSMainThreadExecState.cpp: (WebCore::JSMainThreadExecState::didLeaveScriptContext): * bindings/js/JSMainThreadExecState.h: (WebCore::JSMainThreadExecState::JSMainThreadExecState): Increment a static recursion level counter. (WebCore::JSMainThreadExecState::~JSMainThreadExecState): Decrement a static recursion level counter and, if we are at zero (the outermost script invocation), deliver any outstanding mutation records. * bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode): Use JSMainThreadExecState instead of JSC::call. * bindings/js/JSWebKitMutationObserverCustom.cpp: (WebCore::JSWebKitMutationObserver::observe): Fix JSDictionary logic, add support for attributeFilter. Tools: * DumpRenderTree/mac/EventSendingController.mm: Add support for eventSender.scheduleAsynchronousKeyDown. (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]): (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]): * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output. LayoutTests: With the various fixes in this change, 8/10 tests in fast/mutation pass under WebKit/Mac. Of the failing tests, only one is due to a deficiency in the Mac port's code (end-of-task-delivery.html); the other is due to lack of support for a feature (FILE_SYSTEM) exercised by the test (non-event-delivery.html). * fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available. * fast/mutation/observe-attributes.html: Fixed calls to removeEventListener. * fast/mutation/observe-characterdata.html: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* platform/ScrollableArea.h: (WebCore::ScrollableArea::scrollableAreaBoundingBox): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=74392 Reviewed by Eric Seidel. Source/WebCore: Solution uncovered by Nikolas Zimmermann. Removing an early return that caused SVGUseElements to not update the shadow root's style, and therefor not render correctly. Test: svg/custom/use-disappears-after-style-update.svg * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::didRecalcStyle): LayoutTests: * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added. * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added. * svg/custom/use-disappears-after-style-update.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=77973 Reviewed by Adam Barth. This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL attributes should be prefixed by "V8". No tests. No change in behavior. * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter): (GenerateNormalAttrSetter): (GenerateSingleBatchedAttribute): (GenerateImplementation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=69779 Reviewed by Eric Carlson. Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot handle those URLs. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-