1. 27 Jul, 2007 30 commits
  2. 26 Jul, 2007 10 commits
    • tristan's avatar
      Reviewed by Anders Carlsson. · ef173ccb
      tristan authored
              <rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              If the policy action is FrameLoadTypeRedirectLockHistory, don't add the frame load url to the history.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef173ccb
    • andersca's avatar
      Reviewed by Geoff. · dfbbc17b
      andersca authored
              Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::canCachePage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfbbc17b
    • hyatt's avatar
      FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658... · b85bc581
      hyatt authored
              FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
      
              Adding a null check for now and an assert.  We don't know how/why this
              bug happens, but hopefully the assert will help people to reproduce.
      
              Reviewed by kevin
      
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::height):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85bc581
    • andersca's avatar
      Reviewed by Oliver. · 83197933
      andersca authored
              <rdar://problem/5362783>
              In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
              
              If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
              
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83197933
    • adele's avatar
      Reviewed by Geoff. · e6047756
      adele authored
              Build fix.
      
              * platform/network/cf/ResourceRequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6047756
    • andersca's avatar
      Reviewed by John Sullivan. · b260e3ca
      andersca authored
              <rdar://problem/5349389> 
              Some frame load delegate methods not called when loading a page from the BF cache
              
              These calls were moved to FrameLoader::begin, which is never called for pages loaded
              from the BF cache. This happened in revision 24490.
               
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::transitionToCommitted):
              Call delegate methods if the load is from the BF cache.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b260e3ca
    • kmccullo's avatar
      LayoutTests: · 231507bc
      kmccullo authored
              Reviewed by Darin, Geoff and Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
      
              - Tests to ensure we resize/move the window out of bounds correctly.
      
              * fast/dom/Window/window-resize-expected.txt: Added.
              * fast/dom/Window/window-resize.html: Added.
              * mac/leopard/Skipped:
      
      WebCore:
      
              Reviewed by Darin, Geoff and Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
              - We now better match the behavior of other browsers.
      
              * bindings/js/kjs_window.cpp:
              (KJS::constrainToVisible):
              (KJS::WindowFunc::callAsFunction):
      
      WebKitTools:
      
              Reviewed by Darin, Geoff, Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
      
              - Added delegate methods to intercept and fake the frame location so methods like resizeTo and moveTo can change the window location without actually making the window appear on-screen.
      
              * DumpRenderTree/UIDelegate.h:
              * DumpRenderTree/UIDelegate.m:
              (-[UIDelegate webView:setFrame:]):
              (-[UIDelegate webViewFrame:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      231507bc
    • tristan's avatar
      Reviewed by Adele Peterson. · 0dfff97f
      tristan authored
              
              <rdar://problem/5359921> WebCore should maintain a dirty flag for confirmation on unsaved changes
      
              * bindings/objc/DOMHTML.mm:
              (-[DOMHTMLInputElement _isUserEdited]):
              (-[DOMHTMLTextAreaElement _isUserEdited]):
              Renamed _isEdited to _isUserEdited since the functionality is now different
              
              * bindings/objc/DOMPrivate.h:
              Renamed _isEdited to _isUserEdited.
              
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::RenderTextControl):
              Defaulted m_userEdited to false
              
              (WebCore::RenderTextControl::updateFromElement):
              Set m_userEdited to false, since the change wasn't triggered first by an edit
              
              (WebCore::RenderTextControl::subtreeHasChanged):
              Set m_userEdited to true, since it has been touched by the user
              
              * rendering/RenderTextControl.h:
              (WebCore::RenderTextControl::isUserEdited):
              (WebCore::RenderTextControl::setUserEdited):
              Added two new methods to set/return the userEdited boolean value.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dfff97f
    • ggaren's avatar
      Reviewed by Beth Dakin. · faf1a371
      ggaren authored
              Fixed NULL-dereference crash seen on buildbot.
              
              No bug filed because this is a part of <rdar://problem/5241167>.
      
              * history/PageCache.h:
              (WebCore::PageCache::get): NULL-check HistoryItems passed to get()
              and remove(), to match the old semantics of HashMap. For clarity,
              ASSERT that add() is not called with NULL arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf1a371
    • andersca's avatar
      Reviewed by Oliver Hunt. · 84806efe
      andersca authored
              <rdar://problem/5361106> Crash in user style sheet when loading webpage
      
              Null check m_frame.
              
              * dom/Document.cpp:
              (WebCore::Document::stylesheetLoaded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84806efe