1. 13 Sep, 2012 4 commits
  2. 12 Sep, 2012 36 commits
    • cfleizach@apple.com's avatar
      AX: svg:image not accessible · 0b44f2eb
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96341
      
      Unreviewed.
      
      Build fix for non-SVG ports.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b44f2eb
    • yosin@chromium.org's avatar
      New time input needs accessibility · 9f41c35e
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96032
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      This patch adds accessibility support into multiple fields time input
      UI by setting "role" HTML attribute of DateTimeFieldElement to "spinbutton"
      and changing ARIA attributes to post value change notification.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      Tests: fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html
             fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html
      
      * html/shadow/DateTimeFieldElement.cpp:
      (WebCore::DateTimeFieldElement::DateTimeFieldElement): Changed to set
      "role" HTML attribute to "spinbutton".
      (WebCore::DateTimeFieldElement::initialize): Changed to set new
      parameter axHelpText to aria-help attribute and set aria-valuemax and
      aria-valuemin attributes.
      (WebCore::DateTimeFieldElement::updateVisibleValue): Changed to set
      aria-valuetext and aria-valuenow attributes.
      * html/shadow/DateTimeFieldElement.h:
      (DateTimeFieldElement): Changed to add new parameter axHelpText to initialize().
      * html/shadow/DateTimeFieldElements.cpp:
      (WebCore::DateTimeAMPMFieldElement::create): Changed to add new argument.
      (WebCore::DateTimeHourFieldElement::create): ditto.
      (WebCore::DateTimeMillisecondFieldElement::create): ditto.
      (WebCore::DateTimeMinuteFieldElement::create): ditto.
      (WebCore::DateTimeSecondFieldElement::create): ditto.
      * html/shadow/DateTimeNumericFieldElement.cpp:
      (WebCore::DateTimeNumericFieldElement::maximum): Added for DateTimeFieldElement::initialize().
      (WebCore::DateTimeNumericFieldElement::minimum): ditto.
      * html/shadow/DateTimeNumericFieldElement.h:
      (DateTimeNumericFieldElement): Added maximum() and minimum() declarations.
      * html/shadow/DateTimeSymbolicFieldElement.cpp:
      (WebCore::DateTimeSymbolicFieldElement::maximum): Added for DateTimeFieldElement::initialize().
      (WebCore::DateTimeSymbolicFieldElement::minimum): ditto.
      * html/shadow/DateTimeSymbolicFieldElement.h:
      (DateTimeSymbolicFieldElement): Added maximum() and minimum() declarations.
      
      LayoutTests:
      
      This patch adds two tests for checking accessibility functionalities
      in multiple fields time input UI.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Added to check ARIA attributes used in multiple fields time input UI.
      * fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Added to check accessibility notification supports in multiple fields time input UI.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f41c35e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127876. · 3f2c0096
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127876
      https://bugs.webkit.org/show_bug.cgi?id=96600
      
      mouse click doesn't work for spin button if spin button in
      iframe (Requested by yosin on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateAutoscrollRenderer):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtPoint):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseUp):
      (WebKit::WebViewImpl::computeBlockBounds):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::hitTestContent):
      * Api/qwebpage.cpp:
      (QWebPagePrivate::handleSoftwareInputPanel):
      (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
      (QWebPage::updatePositionDependentActions):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      
      Source/WebKit/win:
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f2c0096
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 52725145
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96308
      
      * platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:
      Rebaseline for http://trac.webkit.org/changeset/128375.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52725145
    • mitz@apple.com's avatar
      Removed a reference to a file that doesn’t participate in any target. · 455405ff
      mitz@apple.com authored
      * WTF.xcodeproj/project.pbxproj: Removed the reference to
      CONTRIBUTORS.pthreads-win32.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      455405ff
    • fpizlo@apple.com's avatar
      JSC should have property butterflies · d8dd0535
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91933
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      This changes the JSC object model. Previously, all objects had fast lookup for
      named properties. Integer indexed properties were only fast if you used a
      JSArray. With this change, all objects have fast indexed properties. This is
      accomplished without any space overhead by using a bidirectional object layout,
      aka butterflies. Each JSObject has a m_butterfly pointer where previously it
      had a m_outOfLineStorage pointer. To the left of the location pointed to by
      m_butterfly, we place all named out-of-line properties. To the right, we place
      all indexed properties along with indexing meta-data. Though, some indexing
      meta-data is placed in the 8-byte word immediately left of the pointed-to
      location; this is in anticipation of the indexing meta-data being small enough
      in the common case that m_butterfly always points to the first indexed
      property.
              
      This is performance neutral, except on tests that use indexed properties on
      plain objects, where the speed-up is in excess of an order of magnitude.
              
      One notable aspect of what this change brings is that it allows indexing
      storage to morph over time. Currently this is only used to allow all non-array
      objects to start out without any indexed storage. But it could be used for
      some kinds of array type inference in the future.
      
      * API/JSCallbackObject.h:
      (JSCallbackObject):
      * API/JSCallbackObjectFunctions.h:
      (JSC::::getOwnPropertySlotByIndex):
      (JSC):
      (JSC::::getOwnNonIndexPropertyNames):
      * API/JSObjectRef.cpp:
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * bytecode/ArrayProfile.h:
      (JSC):
      (JSC::arrayModeFromStructure):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitDirectPutById):
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGAdjacencyList.h:
      (JSC::DFG::AdjacencyList::AdjacencyList):
      (AdjacencyList):
      * dfg/DFGArrayMode.cpp:
      (JSC::DFG::fromObserved):
      (JSC::DFG::modeAlreadyChecked):
      (JSC::DFG::modeToString):
      * dfg/DFGArrayMode.h:
      (DFG):
      (JSC::DFG::modeUsesButterfly):
      (JSC::DFG::modeIsJSArray):
      (JSC::DFG::isInBoundsAccess):
      (JSC::DFG::modeSupportsLength):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleGetByOffset):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      (JSC::DFG::FixupPhase::addNode):
      (FixupPhase):
      (JSC::DFG::FixupPhase::checkArray):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::byValIsPure):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::Node):
      (Node):
      * dfg/DFGNodeType.h:
      (DFG):
      * dfg/DFGOperations.cpp:
      (JSC::DFG::putByVal):
      * dfg/DFGOperations.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::generateProtoChainAccessStub):
      (JSC::DFG::tryCacheGetByID):
      (JSC::DFG::tryBuildGetByIDList):
      (JSC::DFG::emitPutReplaceStub):
      (JSC::DFG::emitPutTransitionStub):
      (JSC::DFG::tryBuildPutByIdList):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::checkArray):
      (JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileGetArrayLength):
      (JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      (JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::cachedGetById):
      (JSC::DFG::SpeculativeJIT::cachedPutById):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::cachedGetById):
      (JSC::DFG::SpeculativeJIT::cachedPutById):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGStructureCheckHoistingPhase.cpp:
      (JSC::DFG::StructureCheckHoistingPhase::run):
      * heap/CopiedSpace.h:
      (CopiedSpace):
      * jit/JIT.h:
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitAllocateBasicJSObject):
      (JSC::JIT::emitAllocateBasicStorage):
      (JSC::JIT::emitAllocateJSArray):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_new_array):
      (JSC::JIT::emitSlow_op_new_array):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_get_by_val):
      (JSC::JIT::compileGetDirectOffset):
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::compilePutDirectOffset):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_get_by_val):
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::compilePutDirectOffset):
      (JSC::JIT::compileGetDirectOffset):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * jsc.cpp:
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/Arguments.cpp:
      (JSC::Arguments::deletePropertyByIndex):
      (JSC::Arguments::defineOwnProperty):
      * runtime/ArrayConstructor.cpp:
      * runtime/ArrayConventions.h: Added.
      (JSC):
      (JSC::isDenseEnoughForVector):
      (JSC::indexingHeaderForArray):
      (JSC::baseIndexingHeaderForArray):
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::create):
      (JSC):
      (JSC::ArrayPrototype::ArrayPrototype):
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncJoin):
      (JSC::arrayProtoFuncSort):
      (JSC::arrayProtoFuncFilter):
      (JSC::arrayProtoFuncMap):
      (JSC::arrayProtoFuncEvery):
      (JSC::arrayProtoFuncForEach):
      (JSC::arrayProtoFuncSome):
      (JSC::arrayProtoFuncReduce):
      (JSC::arrayProtoFuncReduceRight):
      * runtime/ArrayPrototype.h:
      (ArrayPrototype):
      (JSC::ArrayPrototype::createStructure):
      * runtime/ArrayStorage.h: Added.
      (JSC):
      (ArrayStorage):
      (JSC::ArrayStorage::ArrayStorage):
      (JSC::ArrayStorage::from):
      (JSC::ArrayStorage::butterfly):
      (JSC::ArrayStorage::indexingHeader):
      (JSC::ArrayStorage::length):
      (JSC::ArrayStorage::setLength):
      (JSC::ArrayStorage::vectorLength):
      (JSC::ArrayStorage::setVectorLength):
      (JSC::ArrayStorage::copyHeaderFromDuringGC):
      (JSC::ArrayStorage::inSparseMode):
      (JSC::ArrayStorage::lengthOffset):
      (JSC::ArrayStorage::vectorLengthOffset):
      (JSC::ArrayStorage::numValuesInVectorOffset):
      (JSC::ArrayStorage::vectorOffset):
      (JSC::ArrayStorage::indexBiasOffset):
      (JSC::ArrayStorage::sparseMapOffset):
      (JSC::ArrayStorage::sizeFor):
      * runtime/Butterfly.h: Added.
      (JSC):
      (Butterfly):
      (JSC::Butterfly::Butterfly):
      (JSC::Butterfly::totalSize):
      (JSC::Butterfly::fromBase):
      (JSC::Butterfly::offsetOfIndexingHeader):
      (JSC::Butterfly::offsetOfPublicLength):
      (JSC::Butterfly::offsetOfVectorLength):
      (JSC::Butterfly::indexingHeader):
      (JSC::Butterfly::propertyStorage):
      (JSC::Butterfly::indexingPayload):
      (JSC::Butterfly::arrayStorage):
      (JSC::Butterfly::offsetOfPropertyStorage):
      (JSC::Butterfly::indexOfPropertyStorage):
      (JSC::Butterfly::base):
      * runtime/ButterflyInlineMethods.h: Added.
      (JSC):
      (JSC::Butterfly::createUninitialized):
      (JSC::Butterfly::create):
      (JSC::Butterfly::createUninitializedDuringCollection):
      (JSC::Butterfly::base):
      (JSC::Butterfly::growPropertyStorage):
      (JSC::Butterfly::growArrayRight):
      (JSC::Butterfly::resizeArray):
      (JSC::Butterfly::unshift):
      (JSC::Butterfly::shift):
      * runtime/ClassInfo.h:
      (MethodTable):
      (JSC):
      * runtime/IndexingHeader.h: Added.
      (JSC):
      (IndexingHeader):
      (JSC::IndexingHeader::offsetOfIndexingHeader):
      (JSC::IndexingHeader::offsetOfPublicLength):
      (JSC::IndexingHeader::offsetOfVectorLength):
      (JSC::IndexingHeader::IndexingHeader):
      (JSC::IndexingHeader::vectorLength):
      (JSC::IndexingHeader::setVectorLength):
      (JSC::IndexingHeader::publicLength):
      (JSC::IndexingHeader::setPublicLength):
      (JSC::IndexingHeader::from):
      (JSC::IndexingHeader::fromEndOf):
      (JSC::IndexingHeader::propertyStorage):
      (JSC::IndexingHeader::arrayStorage):
      (JSC::IndexingHeader::butterfly):
      * runtime/IndexingHeaderInlineMethods.h: Added.
      (JSC):
      (JSC::IndexingHeader::preCapacity):
      (JSC::IndexingHeader::indexingPayloadSizeInBytes):
      * runtime/IndexingType.h: Added.
      (JSC):
      (JSC::hasIndexingHeader):
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::JSActivation):
      (JSC::JSActivation::visitChildren):
      (JSC::JSActivation::getOwnNonIndexPropertyNames):
      * runtime/JSActivation.h:
      (JSActivation):
      (JSC::JSActivation::tearOff):
      * runtime/JSArray.cpp:
      (JSC):
      (JSC::createArrayButterflyInDictionaryIndexingMode):
      (JSC::JSArray::setLengthWritable):
      (JSC::JSArray::defineOwnProperty):
      (JSC::JSArray::getOwnPropertySlot):
      (JSC::JSArray::getOwnPropertyDescriptor):
      (JSC::JSArray::put):
      (JSC::JSArray::deleteProperty):
      (JSC::JSArray::getOwnNonIndexPropertyNames):
      (JSC::JSArray::unshiftCountSlowCase):
      (JSC::JSArray::setLength):
      (JSC::JSArray::pop):
      (JSC::JSArray::push):
      (JSC::JSArray::shiftCount):
      (JSC::JSArray::unshiftCount):
      (JSC::JSArray::sortNumeric):
      (JSC::JSArray::sort):
      (JSC::JSArray::fillArgList):
      (JSC::JSArray::copyToArguments):
      (JSC::JSArray::compactForSorting):
      * runtime/JSArray.h:
      (JSC):
      (JSArray):
      (JSC::JSArray::JSArray):
      (JSC::JSArray::length):
      (JSC::JSArray::createStructure):
      (JSC::JSArray::isLengthWritable):
      (JSC::createArrayButterfly):
      (JSC::JSArray::create):
      (JSC::JSArray::tryCreateUninitialized):
      * runtime/JSBoundFunction.cpp:
      (JSC::boundFunctionCall):
      (JSC::boundFunctionConstruct):
      (JSC::JSBoundFunction::finishCreation):
      * runtime/JSCell.cpp:
      (JSC::JSCell::getOwnNonIndexPropertyNames):
      (JSC):
      * runtime/JSCell.h:
      (JSCell):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::getOwnPropertySlot):
      (JSC::JSFunction::getOwnPropertyDescriptor):
      (JSC::JSFunction::getOwnNonIndexPropertyNames):
      (JSC::JSFunction::defineOwnProperty):
      * runtime/JSFunction.h:
      (JSFunction):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      * runtime/JSONObject.cpp:
      (JSC::Stringifier::Holder::appendNextProperty):
      (JSC::Walker::walk):
      * runtime/JSObject.cpp:
      (JSC):
      (JSC::JSObject::visitButterfly):
      (JSC::JSObject::visitChildren):
      (JSC::JSFinalObject::visitChildren):
      (JSC::JSObject::getOwnPropertySlotByIndex):
      (JSC::JSObject::put):
      (JSC::JSObject::putByIndex):
      (JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
      (JSC::JSObject::enterDictionaryIndexingMode):
      (JSC::JSObject::createArrayStorage):
      (JSC::JSObject::createInitialArrayStorage):
      (JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
      (JSC::JSObject::putDirectAccessor):
      (JSC::JSObject::deleteProperty):
      (JSC::JSObject::deletePropertyByIndex):
      (JSC::JSObject::getOwnPropertyNames):
      (JSC::JSObject::getOwnNonIndexPropertyNames):
      (JSC::JSObject::preventExtensions):
      (JSC::JSObject::fillGetterPropertySlot):
      (JSC::JSObject::putIndexedDescriptor):
      (JSC::JSObject::defineOwnIndexedProperty):
      (JSC::JSObject::allocateSparseIndexMap):
      (JSC::JSObject::deallocateSparseIndexMap):
      (JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
      (JSC::JSObject::putByIndexBeyondVectorLength):
      (JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
      (JSC::JSObject::putDirectIndexBeyondVectorLength):
      (JSC::JSObject::getNewVectorLength):
      (JSC::JSObject::increaseVectorLength):
      (JSC::JSObject::checkIndexingConsistency):
      (JSC::JSObject::growOutOfLineStorage):
      (JSC::JSObject::getOwnPropertyDescriptor):
      (JSC::putDescriptor):
      (JSC::JSObject::putDirectMayBeIndex):
      (JSC::JSObject::defineOwnNonIndexProperty):
      (JSC::JSObject::defineOwnProperty):
      (JSC::JSObject::getOwnPropertySlotSlow):
      * runtime/JSObject.h:
      (JSC::JSObject::getArrayLength):
      (JSObject):
      (JSC::JSObject::getVectorLength):
      (JSC::JSObject::putDirectIndex):
      (JSC::JSObject::canGetIndexQuickly):
      (JSC::JSObject::getIndexQuickly):
      (JSC::JSObject::canSetIndexQuickly):
      (JSC::JSObject::setIndexQuickly):
      (JSC::JSObject::initializeIndex):
      (JSC::JSObject::completeInitialization):
      (JSC::JSObject::inSparseIndexingMode):
      (JSC::JSObject::butterfly):
      (JSC::JSObject::outOfLineStorage):
      (JSC::JSObject::offsetForLocation):
      (JSC::JSObject::indexingShouldBeSparse):
      (JSC::JSObject::butterflyOffset):
      (JSC::JSObject::butterflyAddress):
      (JSC::JSObject::arrayStorage):
      (JSC::JSObject::arrayStorageOrZero):
      (JSC::JSObject::ensureArrayStorage):
      (JSC::JSObject::checkIndexingConsistency):
      (JSC::JSNonFinalObject::JSNonFinalObject):
      (JSC):
      (JSC::JSObject::setButterfly):
      (JSC::JSObject::setButterflyWithoutChangingStructure):
      (JSC::JSObject::JSObject):
      (JSC::JSObject::inlineGetOwnPropertySlot):
      (JSC::JSObject::putDirectInternal):
      (JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
      (JSC::JSObject::putDirectWithoutTransition):
      (JSC::offsetInButterfly):
      (JSC::offsetRelativeToPatchedStorage):
      (JSC::indexRelativeToBase):
      (JSC::offsetRelativeToBase):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::create):
      * runtime/JSSymbolTableObject.cpp:
      (JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
      * runtime/JSSymbolTableObject.h:
      (JSSymbolTableObject):
      * runtime/JSTypeInfo.h:
      (JSC):
      (JSC::TypeInfo::interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero):
      (JSC::TypeInfo::overridesGetPropertyNames):
      * runtime/LiteralParser.cpp:
      (JSC::::parse):
      * runtime/ObjectConstructor.cpp:
      * runtime/ObjectPrototype.cpp:
      (JSC::ObjectPrototype::ObjectPrototype):
      (JSC):
      * runtime/ObjectPrototype.h:
      (ObjectPrototype):
      * runtime/PropertyOffset.h:
      (JSC::offsetInOutOfLineStorage):
      * runtime/PropertyStorage.h: Added.
      (JSC):
      * runtime/PutDirectIndexMode.h: Added.
      (JSC):
      * runtime/RegExpMatchesArray.cpp:
      (JSC::RegExpMatchesArray::RegExpMatchesArray):
      (JSC):
      (JSC::RegExpMatchesArray::create):
      (JSC::RegExpMatchesArray::finishCreation):
      * runtime/RegExpMatchesArray.h:
      (RegExpMatchesArray):
      (JSC::RegExpMatchesArray::createStructure):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::getOwnNonIndexPropertyNames):
      * runtime/RegExpObject.h:
      (RegExpObject):
      * runtime/Reject.h: Added.
      (JSC):
      (JSC::reject):
      * runtime/SparseArrayValueMap.cpp: Added.
      (JSC):
      * runtime/SparseArrayValueMap.h: Added.
      (JSC):
      (SparseArrayEntry):
      (JSC::SparseArrayEntry::SparseArrayEntry):
      (SparseArrayValueMap):
      (JSC::SparseArrayValueMap::sparseMode):
      (JSC::SparseArrayValueMap::setSparseMode):
      (JSC::SparseArrayValueMap::lengthIsReadOnly):
      (JSC::SparseArrayValueMap::setLengthIsReadOnly):
      (JSC::SparseArrayValueMap::find):
      (JSC::SparseArrayValueMap::remove):
      (JSC::SparseArrayValueMap::notFound):
      (JSC::SparseArrayValueMap::isEmpty):
      (JSC::SparseArrayValueMap::contains):
      (JSC::SparseArrayValueMap::size):
      (JSC::SparseArrayValueMap::begin):
      (JSC::SparseArrayValueMap::end):
      * runtime/SparseArrayValueMapInlineMethods.h: Added.
      (JSC):
      (JSC::SparseArrayValueMap::SparseArrayValueMap):
      (JSC::SparseArrayValueMap::~SparseArrayValueMap):
      (JSC::SparseArrayValueMap::finishCreation):
      (JSC::SparseArrayValueMap::create):
      (JSC::SparseArrayValueMap::destroy):
      (JSC::SparseArrayValueMap::createStructure):
      (JSC::SparseArrayValueMap::add):
      (JSC::SparseArrayValueMap::putEntry):
      (JSC::SparseArrayValueMap::putDirect):
      (JSC::SparseArrayEntry::get):
      (JSC::SparseArrayEntry::getNonSparseMode):
      (JSC::SparseArrayValueMap::visitChildren):
      * runtime/StorageBarrier.h: Removed.
      * runtime/StringObject.cpp:
      (JSC::StringObject::putByIndex):
      (JSC):
      (JSC::StringObject::deletePropertyByIndex):
      * runtime/StringObject.h:
      (StringObject):
      * runtime/StringPrototype.cpp:
      * runtime/Structure.cpp:
      (JSC::Structure::Structure):
      (JSC::Structure::materializePropertyMap):
      (JSC::Structure::nonPropertyTransition):
      (JSC):
      * runtime/Structure.h:
      (Structure):
      (JSC::Structure::indexingType):
      (JSC::Structure::indexingTypeIncludingHistory):
      (JSC::Structure::indexingTypeOffset):
      (JSC::Structure::create):
      * runtime/StructureTransitionTable.h:
      (JSC):
      (JSC::toAttributes):
      (JSC::newIndexingType):
      (JSC::StructureTransitionTable::Hash::hash):
      * tests/mozilla/js1_6/Array/regress-304828.js:
      
      Source/WebCore: 
      
      Teach the DOM that to intercept get/put on indexed properties, you now have
      to override getOwnPropertySlotByIndex and putByIndex.
      
      No new tests because no new behavior. One test was rebased because indexed
      property iteration order now matches other engines (indexed properties always
      come first).
      
      * bindings/js/ArrayValue.cpp:
      (WebCore::ArrayValue::get):
      * bindings/js/JSBlobCustom.cpp:
      (WebCore::JSBlobConstructor::constructJSBlob):
      * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
      (WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
      * bindings/js/JSDOMStringListCustom.cpp:
      (WebCore::toDOMStringList):
      * bindings/js/JSDOMStringMapCustom.cpp:
      (WebCore::JSDOMStringMap::deletePropertyByIndex):
      (WebCore):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
      (WebCore):
      (WebCore::JSDOMWindow::putByIndex):
      (WebCore::JSDOMWindow::deletePropertyByIndex):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::getOwnPropertySlotByIndex):
      (WebCore):
      (WebCore::JSDOMWindowShell::putByIndex):
      (WebCore::JSDOMWindowShell::deletePropertyByIndex):
      * bindings/js/JSDOMWindowShell.h:
      (JSDOMWindowShell):
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::JSHistory::deletePropertyByIndex):
      (WebCore):
      * bindings/js/JSInspectorFrontendHostCustom.cpp:
      (WebCore::populateContextMenuItems):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::deletePropertyByIndex):
      (WebCore):
      * bindings/js/JSStorageCustom.cpp:
      (WebCore::JSStorage::deletePropertyByIndex):
      (WebCore):
      * bindings/js/JSWebSocketCustom.cpp:
      (WebCore::JSWebSocketConstructor::constructJSWebSocket):
      * bindings/js/ScriptValue.cpp:
      (WebCore::jsToInspectorValue):
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneSerializer::serialize):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::RuntimeArray):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::createStructure):
      (RuntimeArray):
      
      LayoutTests: 
      
      Modify the JSON test to indicate that iterating over properties now returns
      indexed properties first. This is a behavior change that makes us more
      compliant with other implementations.
              
      Also check in new expected file for the edge cases of indexed property access
      with prototype accessors. This changeset introduces a known regression in that
      department, which is tracked here: https://bugs.webkit.org/show_bug.cgi?id=96596
      
      * fast/js/resources/JSON-stringify.js:
      * platform/mac/fast/js/primitive-property-access-edge-cases-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8dd0535
    • ossy@webkit.org's avatar
      Add SVN mirror handling feature to build.webkit.org · 6b2f531e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85887
      
      Reviewed by Dirk Pranke.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
      (ConfigureBuild.start):
      (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
      (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
      (Factory.__init__):
      (BuildFactory.__init__):
      (TestFactory.__init__):
      (BuildAndTestFactory.__init__):
      (BuildAndPerfTestFactory.__init__):
      (BuildAndPerfTestWebKit2Factory.__init__):
      (DownloadAndPerfTestFactory.__init__):
      (DownloadAndPerfTestWebKit2Factory.__init__):
      (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
      * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
      (SVNMirrorTest):
      (SVNMirrorTest.setUp): Load config.json once at startup.
      (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
      (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
      * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
      (getLatestSVNRevision): Get the latest SVN revison from the given server.
      (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
                            SVN revision is empty (force build triggered without revision) or the server is unavailable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b2f531e
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 27e44406
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96594
      
      * platform/chromium/TestExpectations:
      fast/table/bad-replaced-sizing-preferred-logical-widths.html fails on Mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27e44406
    • dgrogan@chromium.org's avatar
      Fix indexeddb/basics-shared-workers-expected.txt · 22e570c8
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96591
      
      Reviewed by Kent Tamura.
      
      Needed to pass IndexedDBLayoutTest.BasicTests in content_browsertests
      after 128370.
      
      * storage/indexeddb/basics-shared-workers-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22e570c8
    • slewis@apple.com's avatar
      fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html fails on Mac. · ff02b14c
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96583
      
      Unreviewed.
      
      Update TestExpectations
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff02b14c
    • commit-queue@webkit.org's avatar
      [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1. · b00d0e3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81606
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-12
      Reviewed by Tim Horton.
      
      Tools:
      
      6 seconds is harsh for some jquery test cases.
      Therefore, adjust the value to match DumpRenderTree.
      
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR):
      
      LayoutTests:
      
      Unskip jQuery tests which will now consistently pass due to the increased waitUntilDone timeout.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b00d0e3a
    • tkent@chromium.org's avatar
      Introduce ValidationMessageClient · b41f0c0d
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96238
      
      Reviewed by Hajime Morita.
      
      ValidationMessageClient interface is responsible to operate validation
      message UI for interactive form validation. If a Page object has a
      ValidtionMessageClient, ValidationMessae class uses
      ValidtionMessageClient instead of Shadow DOM.
      
      No new tests because of no behavior changes.
      
      * GNUmakefile.list.am: Add ValidtionMessageClient.h.
      * Target.pri: ditto.
      * WebCore.gypi: ditto.
      * WebCore.xcodeproj/project.pbxproj: ditto.
      
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::~ValidationMessage):
      Hide a validation message via ValidationMessageClient if it is available.
      (WebCore::ValidationMessage::validationMessageClient):
      A helper function to get Page::validationMessageClient.
      (WebCore::ValidationMessage::updateValidationMessage):
      Adding title attribute is not neeeded if ValidationMessageClient is
      used. It shoudl be handled in a ValidtionMessageClient implementation.
      (WebCore::ValidationMessage::setMessage):
      Show a validation message via ValidationMessageClient if it is available.
      (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
      Add an assertion that ValidationMessageClient should not be available.
      (WebCore::ValidationMessage::buildBubbleTree): ditto.
      (WebCore::ValidationMessage::requestToHideMessage):
      Hide a validation message via ValidationMessageClient if it is available.
      (WebCore::ValidationMessage::shadowTreeContains):
      Always returns false if ValidationMessageClient is available, it means no Shadow DOM.
      (WebCore::ValidationMessage::deleteBubbleTree):
      Add an assertion that ValidationMessageClient should not be available.
      (WebCore::ValidationMessage::isVisible):
      Ask ValidationMessageClient for visibility if it is available.
      * html/ValidationMessage.h:
      (WebCore): Add a comment.
      (ValidationMessage): Add validtionMessageClient member function.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Initialize m_validationMessageClient.
      (WebCore::Page::PageClients::PageClients):
      Initialize validationMessageClient member with 0.
      So, existing code makes Page::m_validationMessageClient 0.
      * page/Page.h:
      (PageClients): Add validationMessageClient member.
      (WebCore::Page::validationMessageClient):
      Added. Accessor for m_validationMessageClient.
      (Page): Add m_validationMessageClient.
      
      * page/Settings.h:
      (Settings): Updated the comment for setInteractiveFormValidationEnabled.
      
      * page/ValidationMessageClient.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b41f0c0d
    • commit-queue@webkit.org's avatar
      [EFL] Support download attribute feature · e6e86230
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96462
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-09-12
      Reviewed by Gyuyoung Kim.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake: Enable DOWNLOAD_ATTRIBUTE feature.
      
      Source/WebKit/efl:
      
      Add suggested_name field on _Ewk_Download and set it on startDownload
      to get suggested name passed as a download attribute.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::download):
      (WebCore::FrameLoaderClientEfl::startDownload):
      * ewk/ewk_view.h:
      
      Tools:
      
      Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
      and add "download,request" callback to the DumpRenderTree for EFL.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::onDownloadRequest):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      * platform/efl/Skipped: Unskip test cases related to download attributes.
      * platform/efl-wk2/TestExpectations: Add test cases related to download attributes because they are still failed for WK2
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e86230
    • slewis@apple.com's avatar
      css3/filters/custom/filter-fallback-to-software.html fails on Debug WK2. · 07f08607
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94372.
      
      Unreviewed.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07f08607
    • slewis@apple.com's avatar
      Reduce parallism on the wk2 testers. · 4fb42b64
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95906
      
      Reviewed by Dirk Pranke.
      
      The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
      resource contention.  Reducing the number of processes alleviates the issue.
      
      Starting by reducing 25%.
      
      * Scripts/webkitpy/layout_tests/port/mac.py:
      (MacPort.default_child_processes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fb42b64
    • dimich@chromium.org's avatar
      [V8] OOM in Workers due to external memory retention. · 3bda7d4e
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96459
      
      Reviewed by David Levin.
      
      Added memory checks to the locations in Workers code that are about to invoke the next JS block.
      
      * bindings/v8/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * bindings/v8/V8GCController.cpp:
      (WebCore):
      (WebCore::workingSetEstimateMBMutex): Added a Mutex-protected accessors to a static caching WS estimate.
      (WebCore::V8GCController::gcEpilogue):
      (WebCore::V8GCController::checkMemoryUsage):
      * bindings/v8/V8GCController.h:
      (V8GCController):
      * bindings/v8/V8WorkerContextEventListener.cpp:
      (WebCore::V8WorkerContextEventListener::callListenerFunction):
      * bindings/v8/WorkerContextExecutionProxy.cpp:
      (WebCore::WorkerContextExecutionProxy::evaluate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bda7d4e
    • jchaffraix@webkit.org's avatar
      REGRESSION(r122501): replaced elements with percent width are wrongly size... · 9dca48a0
      jchaffraix@webkit.org authored
      REGRESSION(r122501): replaced elements with percent width are wrongly size when inserted inside an auto-table layout
      https://bugs.webkit.org/show_bug.cgi?id=95892
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      r122501 exposed an issue in how preferred logical widths are computed on replaced objects. The code relies on the
      logical width computation methods. Unfortunately the previous code relies on the layout information, which may not
      be up-to-date during preferred logical width computation.
      
      Test: fast/table/bad-replaced-sizing-preferred-logical-widths.html
            fast/replaced/vertical-writing-mode-max-logical-width.html
      
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::computeMaxPreferredLogicalWidth):
      Added this helper method. The main difference with the old code is that it handles the percent logical width
      properly before calling the old code path. This is not totally right but before forking the whole code, it's
      better to have more evidence that forking preferred logical widths and logical width computation is the way to go.
      
      (WebCore::RenderReplaced::computePreferredLogicalWidths):
      Changed to call computeMaxPreferredLogicalWidth. Also fixed an existing bug in vertical-writing modes where we would
      add the wrong paddings and borders.
      
      * rendering/RenderReplaced.h:
      (RenderReplaced): Added computeMaxPreferredLogicalWidth.
      
      LayoutTests:
      
      * fast/replaced/vertical-writing-mode-max-logical-width-replaced-expected.txt: Added.
      * fast/replaced/vertical-writing-mode-max-logical-width-replaced.html: Added.
      * fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt: Added.
      * fast/table/bad-replaced-sizing-preferred-logical-widths.html: Added.
      * fast/table/resources/iframe.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dca48a0
    • beidson@apple.com's avatar
      Assert in NetscapePlugin::destroy() with async plugin init · 08d85a54
      beidson@apple.com authored
      <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      Most of the NPN_* API calls have a plug-in protector during the calls.
      NPN_Invoke and NPN_InvokeDefault do not.
      
      * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
      (WebKit::NPN_Invoke): Protect the plug-in during this call.
      (WebKit::NPN_InvokeDefault): Ditto.
      
      Tools:
      
      Expose NPN_Invoke to plug-in tests:
      * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
      (PluginTest::NPN_Invoke):
      * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
      (PluginTest):
      
      Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
      * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
      (InvokeDestroysPluginWithinNPP_New):
      (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
      (InvokeDestroysPluginWithinNPP_New::NPP_New):
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      LayoutTests:
      
      * platform/mac-wk2/plugins/destroy-during-async-npp-new-expected.txt: Added.
      * platform/mac-wk2/plugins/destroy-during-async-npp-new.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08d85a54
    • commit-queue@webkit.org's avatar
      [CSS Shaders] Cached validated programs are destroyed and recreated when there... · 21ddf69d
      commit-queue@webkit.org authored
      [CSS Shaders] Cached validated programs are destroyed and recreated when there is only one custom filter animating
      https://bugs.webkit.org/show_bug.cgi?id=96563
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-12
      Reviewed by Dean Jackson.
      
      Before this patch, in FilterEffectRenderer::build, we would first clear the old effects and
      then create the new effects.
      
      Suppose we have one FECustomFilter animating on the page. This FECustomFilter holds the last
      reference to the cached validated program. Before this patch, we would first destroy the old
      FECustomFilter, which would destroy its cached validated program. Then, we would create the
      new FECustomFilter and have to recreate the validated program.
      
      This patch makes FilterEffectRenderer::build keep the old effects around until we're
      done creating the new effects. This way, we won't recreate validated programs.
      
      No new tests. We can't test this because the validated program cache is not exposed to web
      pages.
      
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::build):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21ddf69d
    • dpranke@chromium.org's avatar
      refactor TestExpectations tokenization slightly in preparation for the new syntax · cc24e248
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96564
      
      Reviewed by Ojan Vafai.
      
      This change changes how we will tokenize/lex the
      TestExpectations files, in preparation for supporting both the
      old syntax and the new one. This change by itself should be a
      no-op.
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectationParser._tokenize_line):
      (TestExpectationParser):
      (TestExpectationParser._tokenize_line_using_old_format):
      (TestExpectationParser._tokenize_line_using_new_format):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc24e248
    • dpranke@chromium.org's avatar
      remove unused testexpectations editing code from webkitpy, garden-o-matic · 7c6b28b1
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96562
      
      Reviewed by Adam Barth.
      
      This code was prototyped but never fully realized. Removing
      until it reanimates :).
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
      * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
      * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      (BuildCoverageExtrapolator.extrapolate_test_configurations):
      (GardeningHTTPRequestHandler._run_webkit_patch):
      (GardeningHTTPRequestHandler.ping):
      * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
      (BuildCoverageExtrapolatorTest.test_extrapolate):
      (GardeningServerTest.test_rebaseline_new_port):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6b28b1
    • jamesr@google.com's avatar
      Rebaseline chromium-mac pixel results for 128375 · 3157d5c1
      jamesr@google.com authored
      * platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png:
      * platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3157d5c1
    • tony@chromium.org's avatar
      flex item sized incorrectly in a column flexbox with height set via top/bottom · 6e799984
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94855
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Stop using computeContentLogicalHeight() to get the height of the flexbox and
      use computeLogicalHeight directly.  This properly takes into account out of flow
      positioning.
      
      We can actually refactor some of this into common code, but I want to do that as
      a separate pass.
      
      Test: css3/flexbox/columns-height-set-via-top-bottom.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Fix out of date comment.
      (WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalHeight instead of computeContentLogicalHeight.
      This code actually never gets used-- I'll try to remove in a follow up.
      (WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalHeight instead of computeContentLogicalHeight.
      (WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalHeight instead of computeContentLogicalHeight.
      
      LayoutTests:
      
      Test where the height of a column flexbox is set via top and bottom.
      
      * css3/flexbox/columns-height-set-via-top-bottom-expected.txt: Added.
      * css3/flexbox/columns-height-set-via-top-bottom.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e799984
    • abarth@webkit.org's avatar
      [V8] V8DOMWrapper::perContextData has no callers and can be removed · f82d5455
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96574
      
      Reviewed by Kentaro Hara.
      
      * bindings/v8/V8DOMWrapper.cpp:
      * bindings/v8/V8DOMWrapper.h:
      (WebCore::V8DOMWrapper::getCachedWrapper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f82d5455
    • lforschler@apple.com's avatar
      Remove unused bot, apple-xserve-1. · c0f7e1ea
      lforschler@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96570
      
      Reviewed by Stephanie Lewis.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0f7e1ea
    • achicu@adobe.com's avatar
      [CSS Shaders] Implement transform parameter animations for CSS Custom Filters · 02f8d69f
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94980
      
      Reviewed by Dean Jackson.
      
      Based on patch from Joshua Netterfield <jnetterfield@rim.com>.
      
      Source/WebCore:
      
      According to Section 39.2 of Filter Effects 1.0 Editor's draft
      (https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html), animations
      of transforms should be handled following the CSS3 transform interpolation
      rules. This patch implements this functionality.
      
      Test: css3/filters/custom/custom-filter-transforms-animation.html
      
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::blendFunc):
      (WebCore):
      * platform/graphics/filters/CustomFilterNumberParameter.h:
      (WebCore::CustomFilterNumberParameter::blend):
      * platform/graphics/filters/CustomFilterOperation.cpp:
      (WebCore::blendCustomFilterParameters):
      (WebCore::CustomFilterOperation::blend):
      * platform/graphics/filters/CustomFilterOperation.h:
      (WebCore):
      (WebCore::CustomFilterOperation::blendingNeedsRendererSize): Some filters need the box size, so that they could compute
      Transforms. Right now only the CustomFilterOperation needs that, but I've implemented using this generic function.
      (CustomFilterOperation):
      * platform/graphics/filters/CustomFilterParameter.h:
      (CustomFilterParameter):
      * platform/graphics/filters/CustomFilterTransformParameter.h:
      (CustomFilterTransformParameter):
      (WebCore::CustomFilterTransformParameter::blend):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::FilterOperation::blend):
      (FilterOperation):
      (WebCore::FilterOperation::FilterOperation::blendingNeedsRendererSize):
      * platform/graphics/transforms/TransformOperations.cpp: Extracted the blending functions from CSSPropertyAnimation.cpp
      so that they could be reused from other classes.
      (WebCore::TransformOperations::blendByMatchingOperations):
      (WebCore):
      (WebCore::TransformOperations::blendByUsingMatrixInterpolation): Used when the TransformOperations do not match.
      (WebCore::TransformOperations::blend): Uses when the caller doesn't know whether the TransformOperations match or not.
      * platform/graphics/transforms/TransformOperations.h:
      (TransformOperations):
      
      LayoutTests:
      
      Added test transform animations in css3/filters/custom/custom-filter-transform-animation.html.
      
      * animations/resources/animation-test-helpers.js:
      (customFilterParameterMatch): Extracted the parameter matching from filterParametersMatch and added function parameters matching.
      This should work for all functions that have number parameters, ie. arrays, mat4 functions.
      
      (filterParametersMatch):
      * css3/filters/custom/custom-filter-transforms-animation-expected.txt: Added.
      * css3/filters/custom/custom-filter-transforms-animation.html: Added.
      * css3/filters/resources/custom-filter-parser.js: Fixed function parsing.
      (TokenStream.prototype.skip):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f8d69f
    • commit-queue@webkit.org's avatar
      IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible · a4062fe7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94023
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-09-12
      Reviewed by Kentaro Hara.
      
      Transition the put/add/update methods to accept direct ScriptValue
      objects rather than SerializedScriptValues, to eliminate lots of
      redundant deserialization/serialization steps while storing
      values.
      
      Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
      followup get/openCursor work, following this.
      
      No new tests, this is a performance refactor of core IDB
      functionality. Most existing tests cover correctness. Tests that
      might fail include:
      
      storage/indexeddb/objectstore-basics.html
      storage/indexeddb/keypath-basics.html
      storage/indexeddb/index-basics.html
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::update):
      * Modules/indexeddb/IDBCursor.h:
      (IDBCursor):
      * Modules/indexeddb/IDBCursor.idl:
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::generateIndexKeysForValue):
      (WebCore::IDBObjectStore::add):
      (WebCore::IDBObjectStore::put):
      (WebCore):
      * Modules/indexeddb/IDBObjectStore.h:
      (WebCore::IDBObjectStore::add):
      (WebCore::IDBObjectStore::put):
      (IDBObjectStore):
      * Modules/indexeddb/IDBObjectStore.idl:
      * bindings/v8/IDBBindingUtilities.cpp:
      (WebCore):
      (WebCore::createIDBKeyFromScriptValueAndKeyPath):
      (WebCore::deserializeIDBValue):
      (WebCore::canInjectIDBKeyIntoScriptValue):
      * bindings/v8/IDBBindingUtilities.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4062fe7
    • commit-queue@webkit.org's avatar
      [chromium] Remove unused WebGestureEvent fields · 05011f4b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95496
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-12
      Reviewed by Adam Barth.
      
      Remove the no-longer used fields from WebGestureEvent, now that
      chromium has been updated to use the per-event-type fields instead.
      This depends on crrev.com/156346 in chromium.
      
      * public/WebInputEvent.h:
      (WebKit::WebGestureEvent::WebGestureEvent):
      * public/android/WebInputEventFactory.h:
      * src/WebInputEvent.cpp:
      (SameSizeAsWebGestureEvent):
      * src/android/WebInputEventFactory.cpp:
      (WebKit):
      (WebKit::WebInputEventFactory::gestureEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05011f4b
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r128351. · e791cd6f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/128351
      https://bugs.webkit.org/show_bug.cgi?id=96573
      
      Broke FindInPage browser_tests (Requested by jamesr_ on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::cancelPendingScopingEffort):
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      (WebKit::WebFrameImpl::shouldScopeMatches):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e791cd6f
    • cfleizach@apple.com's avatar
      AX: svg:image not accessible · 1210e15e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96341
      
      Reviewed by Adele Peterson.
      
      Source/WebCore: 
      
      Test: accessibility/svg-image.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      
      LayoutTests: 
      
      * accessibility/svg-image.html: Added.
      * platform/mac/accessibility/svg-image-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1210e15e
    • ojan@chromium.org's avatar
      percentage widths rendered wrong in vertical writing mode with orthogonal parent · e143a3b5
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96308
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      When the containingBlock is in a perpendicular writing-mode, we need to use
      it's logicalWidth as the availableHeight for computing percentage values.
      
      Tests: fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html
             fast/writing-mode/percentage-height-orthogonal-writing-modes.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePercentageLogicalHeight):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      Added some FIXMEs for perpendicular writing mode cases.
      
      LayoutTests:
      
      * fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt: Added.
      * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
      * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html: Added.
      * fast/writing-mode/percentage-height-orthogonal-writing-modes.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e143a3b5
    • abarth@webkit.org's avatar
      [v8] document.getCSSCanvasContext doesn't need to be custom · 20c7f5a5
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96560
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Instead of having a special case for toV8(CanvasRenderingContext*)
      inlined into this custom function, we should just make the toV8
      function itself custom.
      
      Test: fast/canvas/canvas-css-crazy.html
      
      * UseV8.cmake:
      * WebCore.gypi:
      * bindings/v8/custom/V8DocumentCustom.cpp:
      * dom/Document.idl:
      * html/canvas/CanvasRenderingContext.idl:
      
      LayoutTests:
      
      Test that document.getCSSCanvasContext returns null for a bogus canvas type.
      
      * fast/canvas/canvas-css-crazy-expected.txt: Added.
      * fast/canvas/canvas-css-crazy.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20c7f5a5
    • eric@webkit.org's avatar
      HTML parser fails to propertly close 4 identical nested formatting elements · 94ee7277
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96385
      
      Reviewed by Adam Barth.
      
      Add missing Adoption agency step 4.a to fix one of our two outlying Adoption Agency bugs.
      This is the same step that Opera was missing (must have been recently added to the spec).
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94ee7277
    • commit-queue@webkit.org's avatar
      Source/WebCore: [GTK] Protect RedirectedXCompositeWindow with USE(GLX) when... · 1f8801c4
      commit-queue@webkit.org authored
      Source/WebCore: [GTK] Protect RedirectedXCompositeWindow with USE(GLX) when building the clutter AC backend
      https://bugs.webkit.org/show_bug.cgi?id=96165
      
      Patch by Siraj Razick <siraj.razick@collabora.co.uk> on 2012-09-12
      Reviewed by Martin Robinson.
      
      RedirectedXCompositeWindow.cpp and RedirectedXCompositeWindow.h files requies openGL specific
      headers to compile so when we build webkit clutter AC backend these files failed to compile,
      This patch protects these two files with USE(GLX) when building webkit with Clutter AC backend.
      
      No new tests since this is a build fix
      
      * platform/gtk/RedirectedXCompositeWindow.cpp:
      * platform/gtk/RedirectedXCompositeWindow.h:
      protects both the files with USE(GLX)
      
      Source/WebKit/gtk: [GTK] Update AcceleratedCompositingContextClutter to match AcceleratedCompositingContext.h API update
      https://bugs.webkit.org/show_bug.cgi?id=96165
      
      Patch by Siraj Razick <siraj.razick@collabora.co.uk> on 2012-09-12
      Reviewed by Martin Robinson.
      
      Due to the refactoring done in bug #90085 AcceleratedCompositingContext API changed, as a result
      AcceleratedCompositingContextClutter doesn't compile anymore. This patch is to update the
      AcceleratedCompositingContextClutter implementations to match the API update, and Make webkit
      AC backend compile again.
      
      * WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
      (WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
      (WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
      (WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
      (WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay):
      (WebKit::flushAndRenderLayersCallback):
      (WebKit::AcceleratedCompositingContext::scheduleLayerFlush):
      (WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
      (WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f8801c4
    • ojan@chromium.org's avatar
      RenderBox::computeLogicalClientHeight is incorrectly named · c3332362
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94288
      
      Reviewed by Tony Chang.
      
      Just renamed a couple methods to make it more clear what they return.
      No behavior changes.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeLogicalHeightUsing):
      (WebCore::RenderBox::computeContentLogicalHeight):
      (WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::mainAxisContentExtent):
      (WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
      (WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
      (WebCore::RenderFlexibleBox::lineBreakLength):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3332362
    • jsbell@chromium.org's avatar
      IndexedDB: The |source| property of IDBFactory.open() request should be null · 73d661ef
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96551
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Per the IDB spec, the source property of the IDBOpenDBRequest returned by IDBFactory.open()
      should be set to null. We were setting it to the IDBFactory object instead.
      
      Tests: storage/indexeddb/basics.html
             storage/indexeddb/basics-workers.html
             storage/indexeddb/mozilla/event-source.html
             storage/indexeddb/readonly.html
      
      * Modules/indexeddb/IDBFactory.cpp:
      (WebCore::IDBFactory::open):
      
      LayoutTests:
      
      Already tested for in several places, so just update expectations/assertions.
      
      * storage/indexeddb/basics-expected.txt:
      * storage/indexeddb/basics-workers-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/resources/event-source.js: Updated assertion.
      (openSuccess):
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/resources/basics.js: Updated assertion.
      (test):
      (openCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73d661ef