- 21 Jan, 2011 40 commits
-
-
andersca@apple.com authored
Reviewed by Dan Bernstein. DrawingAreaProxyImpl::paint should return the unpainted region https://bugs.webkit.org/show_bug.cgi?id=52918 * UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Add unpaintedRegion parameter. * UIProcess/BackingStore.h: (WebKit::BackingStore::size): Add a size getter. * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Initialize the unpainted region to the dirty region, then subtract the painted region. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76393 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: ~InspectorResourceAgent crashes on closing inspected page. https://bugs.webkit.org/show_bug.cgi?id=52900 * inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76392 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rdar://problem/8896057andersca@apple.com authored
Reviewed by Dan Bernstein and Maciej Stachowiak. Give the Web Process access to the PubSub agent. * WebProcess/com.apple.WebProcess.sb: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
crogers@google.com authored
Reviewed by Darin Fisher. Add run-time enable support for the web audio API https://bugs.webkit.org/show_bug.cgi?id=52741 * public/WebRuntimeFeatures.h: * public/WebSettings.h: * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled): * src/WebSettingsImpl.h: 2011-01-21 Chris Rogers <crogers@google.com> Reviewed by Darin Fisher. Add run-time enable support for the web audio API https://bugs.webkit.org/show_bug.cgi?id=52741 * WebPreferenceKeysPrivate.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2011-01-21 Chris Rogers <crogers@google.com> Reviewed by Darin Fisher. Add run-time enable support for the web audio API https://bugs.webkit.org/show_bug.cgi?id=52741 * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2011-01-21 Chris Rogers <crogers@google.com> Reviewed by Darin Fisher. Add run-time enable support for the web audio API https://bugs.webkit.org/show_bug.cgi?id=52741 No new tests since audio API is not yet implemented. * WebCore.exp.in: * bindings/generic/RuntimeEnabledFeatures.cpp: * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled): * page/DOMWindow.idl: * page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled): * page/Settings.h: (WebCore::Settings::webAudioEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76390 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
weinig@apple.com authored
* WebScrollBar.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [GTK] Menulist text often collides with separator https://bugs.webkit.org/show_bug.cgi?id=51155 Rebaseline tests that have different affected by the metrics of the menulist. * platform/gtk/fast/forms/001-expected.checksum: * platform/gtk/fast/forms/001-expected.png: * platform/gtk/fast/forms/001-expected.txt: * platform/gtk/fast/forms/003-expected.checksum: * platform/gtk/fast/forms/003-expected.png: * platform/gtk/fast/forms/003-expected.txt: * platform/gtk/fast/forms/004-expected.checksum: * platform/gtk/fast/forms/004-expected.png: * platform/gtk/fast/forms/004-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt: * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum: * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png: * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt: * platform/gtk/fast/forms/control-clip-overflow-expected.checksum: * platform/gtk/fast/forms/control-clip-overflow-expected.png: * platform/gtk/fast/forms/control-clip-overflow-expected.txt: * platform/gtk/fast/forms/control-restrict-line-height-expected.checksum: * platform/gtk/fast/forms/control-restrict-line-height-expected.png: * platform/gtk/fast/forms/control-restrict-line-height-expected.txt: * platform/gtk/fast/forms/disabled-select-change-index-expected.checksum: * platform/gtk/fast/forms/disabled-select-change-index-expected.png: * platform/gtk/fast/forms/disabled-select-change-index-expected.txt: * platform/gtk/fast/forms/form-element-geometry-expected.checksum: * platform/gtk/fast/forms/form-element-geometry-expected.png: * platform/gtk/fast/forms/form-element-geometry-expected.txt: * platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added. * platform/gtk/fast/forms/input-file-re-render-expected.png: Added. * platform/gtk/fast/forms/menulist-deselect-update-expected.checksum: * platform/gtk/fast/forms/menulist-deselect-update-expected.png: * platform/gtk/fast/forms/menulist-deselect-update-expected.txt: * platform/gtk/fast/forms/menulist-narrow-width-expected.checksum: * platform/gtk/fast/forms/menulist-narrow-width-expected.png: * platform/gtk/fast/forms/menulist-narrow-width-expected.txt: * platform/gtk/fast/forms/menulist-no-overflow-expected.checksum: * platform/gtk/fast/forms/menulist-no-overflow-expected.png: * platform/gtk/fast/forms/menulist-no-overflow-expected.txt: * platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum: * platform/gtk/fast/forms/menulist-restrict-line-height-expected.png: * platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt: * platform/gtk/fast/forms/menulist-separator-painting-expected.checksum: * platform/gtk/fast/forms/menulist-separator-painting-expected.png: * platform/gtk/fast/forms/menulist-separator-painting-expected.txt: * platform/gtk/fast/forms/menulist-style-color-expected.checksum: * platform/gtk/fast/forms/menulist-style-color-expected.png: * platform/gtk/fast/forms/menulist-style-color-expected.txt: * platform/gtk/fast/forms/menulist-width-change-expected.checksum: * platform/gtk/fast/forms/menulist-width-change-expected.png: * platform/gtk/fast/forms/menulist-width-change-expected.txt: * platform/gtk/fast/forms/option-script-expected.checksum: * platform/gtk/fast/forms/option-script-expected.png: * platform/gtk/fast/forms/option-script-expected.txt: * platform/gtk/fast/forms/option-strip-whitespace-expected.checksum: * platform/gtk/fast/forms/option-strip-whitespace-expected.png: * platform/gtk/fast/forms/option-strip-whitespace-expected.txt: * platform/gtk/fast/forms/option-text-clip-expected.checksum: * platform/gtk/fast/forms/option-text-clip-expected.png: * platform/gtk/fast/forms/option-text-clip-expected.txt: * platform/gtk/fast/forms/select-align-expected.checksum: * platform/gtk/fast/forms/select-align-expected.png: * platform/gtk/fast/forms/select-align-expected.txt: * platform/gtk/fast/forms/select-baseline-expected.checksum: * platform/gtk/fast/forms/select-baseline-expected.png: * platform/gtk/fast/forms/select-baseline-expected.txt: * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum: * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png: * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt: * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum: * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png: * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt: * platform/gtk/fast/forms/select-disabled-appearance-expected.checksum: * platform/gtk/fast/forms/select-disabled-appearance-expected.png: * platform/gtk/fast/forms/select-disabled-appearance-expected.txt: * platform/gtk/fast/forms/select-initial-position-expected.checksum: * platform/gtk/fast/forms/select-initial-position-expected.png: * platform/gtk/fast/forms/select-initial-position-expected.txt: * platform/gtk/fast/forms/select-selected-expected.checksum: * platform/gtk/fast/forms/select-selected-expected.png: * platform/gtk/fast/forms/select-selected-expected.txt: * platform/gtk/fast/forms/select-size-expected.checksum: * platform/gtk/fast/forms/select-size-expected.png: * platform/gtk/fast/forms/select-size-expected.txt: * platform/gtk/fast/forms/select-style-expected.checksum: * platform/gtk/fast/forms/select-style-expected.png: * platform/gtk/fast/forms/select-style-expected.txt: * platform/gtk/fast/forms/select-visual-hebrew-expected.checksum: * platform/gtk/fast/forms/select-visual-hebrew-expected.png: * platform/gtk/fast/forms/select-visual-hebrew-expected.txt: * platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum: * platform/gtk/fast/forms/select-writing-direction-natural-expected.png: * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt: * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum: * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png: * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt: 2011-01-21 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [GTK] Menulist text often collides with separator https://bugs.webkit.org/show_bug.cgi?id=51155 Move menulist rendering to RenderThemeGtk and correct padding code for separators in menulists. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members. (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added. (WebCore::RenderThemeGtk::comboBoxArrowSize): Added. (WebCore::getButtonInnerBorder): Added. (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using Mozilla code. (WebCore::RenderThemeGtk::paintMenuList): Ditto. (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer out to handle child widgets of comboboxes. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget. (WebCore::RenderThemeGtk::gtkContainer): Added. (WebCore::getGtkComboBoxButton): Added. (WebCore::getGtkComboBoxPieces): Added. (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here. (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added. (WebCore::RenderThemeGtk::gtkComboBoxButton): Added. (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added. (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added. * platform/gtk/RenderThemeGtk.h: Added new members and methods. * platform/gtk/WidgetRenderingContext.h: Added new members and methods. * platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine): * platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine): * platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons. (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint): * platform/gtk/gtk3drawing.c: (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint): * platform/gtk/gtkdrawing.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76388 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
weinig@apple.com authored
* platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
FrameLoader::checkLoadCompleteForThisFrame uses wrong history item https://bugs.webkit.org/show_bug.cgi?id=48812 * platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
Windows 7 Release bots green. Unreviewed. https://bugs.webkit.org/show_bug.cgi?id=52913 * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Unreviewed; another Chromium build fix attempt for r76378. * src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::setValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76383 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Unreviewed Chromium build fix attempt for r76378. * src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76382 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs@apple.com authored
Reviewed by Sam Weinig. Skip another test that is failing sporadically on the buildbots https://bugs.webkit.org/show_bug.cgi?id=52908 * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76381 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
crogers@google.com authored
Reviewed by Kenneth Russell. Add chromium bundled audio spatialization resources to WebAudio.grd https://bugs.webkit.org/show_bug.cgi?id=52651 * WebKit.grd: 2011-01-21 Chris Rogers <crogers@google.com> Reviewed by Kenneth Russell. Add chromium bundled audio spatialization resources to WebAudio.grd https://bugs.webkit.org/show_bug.cgi?id=52651 No new tests since audio API is not yet implemented. * WebCore.gyp/WebCore.gyp: * platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76380 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Tony Chang. Update chromium/linux baselines after drawing code moved into WebThemeEngine. https://bugs.webkit.org/show_bug.cgi?id=52826 * platform/chromium-linux/css1/box_properties/acid_test-expected.checksum: * platform/chromium-linux/css1/box_properties/acid_test-expected.png: * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum: * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png: * platform/chromium-linux/fast/block/basic/011-expected.checksum: * platform/chromium-linux/fast/block/basic/011-expected.png: * platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum: * platform/chromium-linux/fast/block/margin-collapse/103-expected.png: * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum: * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png: * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: * platform/chromium-linux/fast/forms/basic-inputs-expected.checksum: * platform/chromium-linux/fast/forms/basic-inputs-expected.png: * platform/chromium-linux/fast/forms/basic-selects-expected.checksum: * platform/chromium-linux/fast/forms/basic-selects-expected.png: * platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum: * platform/chromium-linux/fast/forms/box-shadow-override-expected.png: * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum: * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png: * platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum: * platform/chromium-linux/fast/forms/file-input-disabled-expected.png: * platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum: * platform/chromium-linux/fast/forms/form-element-geometry-expected.png: * platform/chromium-linux/fast/forms/formmove-expected.checksum: * platform/chromium-linux/fast/forms/formmove-expected.png: * platform/chromium-linux/fast/forms/formmove2-expected.checksum: * platform/chromium-linux/fast/forms/formmove2-expected.png: * platform/chromium-linux/fast/forms/indeterminate-expected.checksum: * platform/chromium-linux/fast/forms/indeterminate-expected.png: * platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum: * platform/chromium-linux/fast/forms/input-appearance-height-expected.png: * platform/chromium-linux/fast/forms/input-value-expected.checksum: * platform/chromium-linux/fast/forms/input-value-expected.png: * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum: * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png: * platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum: * platform/chromium-linux/fast/forms/menulist-style-color-expected.png: * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type. * platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum: * platform/chromium-linux/fast/forms/radio-attr-order-expected.png: * platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum: * platform/chromium-linux/fast/forms/radio-nested-labels-expected.png: * platform/chromium-linux/fast/forms/radio_checked-expected.checksum: * platform/chromium-linux/fast/forms/radio_checked-expected.png: * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum: * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png: * platform/chromium-linux/fast/forms/select-baseline-expected.checksum: * platform/chromium-linux/fast/forms/select-baseline-expected.png: * platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum: * platform/chromium-linux/fast/inline/positionedLifetime-expected.png: * platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum: * platform/chromium-linux/fast/parser/bad-xml-slash-expected.png: * platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum: * platform/chromium-linux/fast/replaced/replaced-breaking-expected.png: * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum: * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png: * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum: * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png: * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum: * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type. * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum: * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png: * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum: * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png: 2011-01-21 Xiyuan Xia <xiyuan@chromium.org> Reviewed by Tony Chang. Use WebThemeEngine for relevant RenderTheme parts for chromium/linux. https://bugs.webkit.org/show_bug.cgi?id=52826 * platform/chromium/ChromiumBridge.h: * rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar): * rendering/RenderThemeChromiumLinux.h: * rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::setSizeIfAuto): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor): * rendering/RenderThemeChromiumSkia.h: 2011-01-21 Xiyuan Xia <xiyuan@chromium.org> Reviewed by Tony Chang. Use WebThemeEngine for relevant RenderTheme parts for chromium/linux. https://bugs.webkit.org/show_bug.cgi?id=52826 * WebKit.gyp: * src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76379 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52779 Reviewed by Anders Carlsson. Rename ScrollbarClient -> ScrollableArea. Source/WebCore: - Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea since that was its only use case. * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * accessibility/AccessibilityScrollbar.cpp: (WebCore::AccessibilityScrollbar::setValue): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass): * page/FrameView.h: * platform/PopupMenuClient.h: * platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimator::ScrollAnimator): (WebCore::ScrollAnimator::scroll): (WebCore::ScrollAnimator::notityPositionChanged): * platform/ScrollAnimator.h: * platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorWin::ScrollAnimatorWin): (WebCore::ScrollAnimatorWin::scroll): * platform/ScrollAnimatorWin.h: * platform/ScrollView.cpp: (WebCore::ScrollView::scroll): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent): * platform/ScrollView.h: * platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp. (WebCore::ScrollableArea::ScrollableArea): (WebCore::ScrollableArea::~ScrollableArea): (WebCore::ScrollableArea::scroll): (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation): (WebCore::ScrollableArea::setScrollOffsetFromAnimation): * platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h. * platform/Scrollbar.cpp: (WebCore::Scrollbar::createNativeScrollbar): (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::offsetDidChange): (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::isWindowActive): (WebCore::Scrollbar::invalidateRect): (WebCore::Scrollbar::convertToContainingView): (WebCore::Scrollbar::convertFromContainingView): * platform/Scrollbar.h: (WebCore::Scrollbar::disconnectFromScrollableArea): (WebCore::Scrollbar::scrollableArea): * platform/ScrollbarClient.cpp: Removed. * platform/ScrollbarClient.h: Removed. * platform/ScrollbarThemeComposite.cpp: * platform/chromium/FramelessScrollView.h: * platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::paintTickmarks): * platform/efl/ScrollbarEfl.cpp: (Scrollbar::createNativeScrollbar): (ScrollbarEfl::ScrollbarEfl): (scrollbarEflEdjeMessage): * platform/efl/ScrollbarEfl.h: * platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::create): (MainFrameScrollbarGtk::MainFrameScrollbarGtk): (MainFrameScrollbarGtk::gtkValueChanged): * platform/gtk/MainFrameScrollbarGtk.h: * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): (WebCore::ScrollAnimatorMac::scroll): * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): * platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu): * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::scrollToRevealSelection): (WebCore::PopupMenuWin::wndProc): * platform/win/PopupMenuWin.h: * platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::paintTrackBackground): (WebCore::ScrollbarThemeSafari::paintButton): (WebCore::ScrollbarThemeSafari::paintThumb): * platform/wx/ScrollbarThemeWx.cpp: (WebCore::ScrollbarThemeWx::paint): * rendering/RenderDataGrid.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::scroll): * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scroll): (WebCore::RenderListBox::logicalScroll): (WebCore::RenderListBox::setScrollTop): (WebCore::RenderListBox::destroyScrollbar): * rendering/RenderListBox.h: * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar): * rendering/RenderMenuList.h: * rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): * rendering/RenderScrollbar.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createScrollbar): * rendering/RenderTextControlSingleLine.h: Source/WebKit/chromium: * src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::createScrollbar): * src/AutoFillPopupMenuClient.h: * src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): * src/WebScrollbarImpl.h: * tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::createScrollbar): Source/WebKit/qt: * Api/qwebframe.cpp: (QWebFrame::setScrollBarValue): Source/WebKit/win: * WebScrollBar.cpp: (WebScrollBar::scroll): * WebScrollBar.h: Source/WebKit2: * UIProcess/win/WebPopupMenuProxyWin.cpp: (WebKit::WebPopupMenuProxyWin::onMouseWheel): (WebKit::WebPopupMenuProxyWin::scrollToRevealSelection): * UIProcess/win/WebPopupMenuProxyWin.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Ryosuke Niwa. [chromium] Notify WebFrameClient when spellcheck state changes https://bugs.webkit.org/show_bug.cgi?id=52680 * public/WebFrameClient.h: (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged): * src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking): * src/WebFrameImpl.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76377 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Darin Adler. REGRESSION(r76177): All JavaScriptCore tests fail on ARM https://bugs.webkit.org/show_bug.cgi?id=52814 Get the approximateByteSize value before releasing the OwnPtr. * parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76376 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
* rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Sam Weinig. GraphicsLayer should be non-copyable https://bugs.webkit.org/show_bug.cgi?id=52909 Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED on that and KeyframeValueList. * platform/graphics/GraphicsLayer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76374 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
antonm@chromium.org authored
Reviewed by Nate Chapin. [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors https://bugs.webkit.org/show_bug.cgi?id=52901 * fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added. * fast/dom/htmlcollection-conversion-throws-exception.html: Added. 2011-01-21 Anton Muhin <antonm@chromium.org> Reviewed by Nate Chapin. [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors https://bugs.webkit.org/show_bug.cgi?id=52901 Test: fast/dom/htmlcollection-conversion-throws-exception.html * bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getItem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76373 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
Old model: 1) A change is made to a GraphicsLayer. 2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the render timer. 3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the flush and then renders. New model: 1) A change is made to a GraphicsLayer. 2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new LayerChangesFlusher singleton that this host has changes that need to be flushed. 3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration of the message loop. 4) LayerChangesFlusher's hook is called, which calls through to CACFLayerTreeHost::flushPendingLayerChangesNow. 5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes that were just flushed to the context will be rendered. When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer (e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of scheduling the flush. This change has three advantages: 1) Whenever we flush layer changes, we first update layout. This can cause the page to leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost to be dropped. By separating flushing (and thus updating layout) from rendering, we no longer have to worry about this happen during rendering. 2) The new model is much more similar to how things work on the Mac, so will hopefully reduce the number of platform-specific bugs. 3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a layout was pending, is no longer needed. It actually hasn't been needed since at least r75987, but removing it before now would have resulted in a crash whenever a page came out of compositing mode due to (1). Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in CACFLayerTreeHost, but shouldn't be Reviewed by Simon Fraser. Source/WebCore: * WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher. * platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing #includes. (WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member. (WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes, schedule a flush. Removed the call to renderSoon(), which now happens when the flush is finished. (WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also fixed a bug where we'd fail to clear the context's layer. (WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which is no longer needed. Moved code to flush layer changes from here to flushPendingLayerChangesNow, which is called via the above-described mechanism. (WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed code to schedule a render, which now happens after we've flushed. (WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we schedule a render so that the changes will be rendered to the screen. * platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and m_isFlushingLayerChanges. * platform/graphics/ca/win/LayerChangesFlusher.cpp: Added. (WebCore::LayerChangesFlusher::shared): (WebCore::LayerChangesFlusher::LayerChangesFlusher): (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): (WebCore::LayerChangesFlusher::cancelPendingFlush): (WebCore::LayerChangesFlusher::hookCallback): (WebCore::LayerChangesFlusher::hookFired): (WebCore::LayerChangesFlusher::setHook): (WebCore::LayerChangesFlusher::removeHook): * platform/graphics/ca/win/LayerChangesFlusher.cpp: Added. (WebCore::LayerChangesFlusher::shared): Returns the singleton. (WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members. (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of hosts with changes that need to be flushed, and set up our hook if we haven't already. (WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts with changes that need to be flushed. If we have no more such hosts, remove our hook, unless we're currently in the process of calling out to our hosts, in which case we'll take care of the hook once we're done calling out. (WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when our hook fires. Just calls through to hookFired on the singleton. (WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be flushed that it's time to flush. If no hosts re-added themselves to our set during this process, remove our hook. (WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW. (WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx. * platform/graphics/ca/win/LayerChangesFlusher.h: Added. Source/WebKit/win: Update for CACFLayerTreeHost changes * WebView.cpp: (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back to our own flushing function if needed. * WebView.h: Removed shouldRender, which is no longer used or needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76372 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Sam Weinig. Report the sized used by canvases and types arrays https://bugs.webkit.org/show_bug.cgi?id=52856 Report the memory cost associated with canvas elements, and typed arrays to JavaScript as extraCost, so that it can figure this into its GC behavior. * bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView): New templatized function, similar to getDOMObjectWrapper() but calls reportExtraMemoryCost() with the byteLength of the array. * bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSInt16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSInt32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSInt8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSUint16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSUint32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * bindings/js/JSUint8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost() with the size of the canvas backing store. * html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::byteLength): byteLength needs to be public. * platform/graphics/ImageBuffer.h: Add dataSize() method. * platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). * platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76371 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
Also renamed a few functions and data members to match. Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't Reviewed by Simon Fraser. Source/WebCore: * WebCore.vcproj/WebCore.vcproj: Updated files' names and paths. * WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include path. * WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too. * platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp. * platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h. * platform/graphics/ca/win/PlatformCALayerWin.cpp: * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Updated for renames. Source/WebKit/win: Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match. * WebPreferences.cpp: * WebView.cpp: (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree host before we get rid of the layer tree host itself. * WebView.h: Source/WebKit2: Update for WKCACFLayerRenderer -> CACFLayerView rename * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary #includes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Martin Robinson. Remove unnecessary <stdio.h> include https://bugs.webkit.org/show_bug.cgi?id=52884 * jit/JIT.cpp: remove unnecessary include. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Original patch from François Sausset <sausset@gmail.com> Reviewed by Darin Adler. Code cleaning in rendering/mathml/RenderMathMLFraction.cpp https://bugs.webkit.org/show_bug.cgi?id=52201 Replace unneeded doubles by floats and remove unneeded casts. * rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint): * rendering/mathml/RenderMathMLFraction.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76368 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=47597 Reviewed by Darin Adler. This changes the committer/reviewer policy to require an additional reviewer supporting a reviewer nomination to work for a different company and different project affiliation from the nominee. This means reviewer nominations would require four supporting reviewers, one of which knows the reviewer through the community (irc, email, bugs) ensuring that the nominee has the open-source collaboration skills we so highly value here in WebKit. * coding/commit-review-policy.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
Reviewed by Darin Adler. REGRESSION(r73618): Clicking on a search input causes a crash. https://bugs.webkit.org/show_bug.cgi?id=52905 * fast/dom/search-shadow-host-crash-expected.txt: Added. * fast/dom/search-shadow-host-crash.html: Added. 2011-01-21 Dimitri Glazkov <dglazkov@chromium.org> Reviewed by Darin Adler. REGRESSION(r73618): Clicking on a search input causes a crash. https://bugs.webkit.org/show_bug.cgi?id=52905 The problem is caused by TextControlInnerElement being used both as shadow root and an element in a shadow subtree. The code assumed it is only used as a shadow root. Since this code is all just workaround for in-progress conversion to new shadow DOM, I am just adding a check. This code will disappear completely once bug 52788 is fixed. Test: fast/dom/search-shadow-host-crash.html * dom/Node.cpp: (WebCore::Node::setShadowHost): Added an ASSERT for early detection of attempting to stomp on the parentNode. * rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::detach): Added a check to only clear shadow host if we have one. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76366 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dglazkov@chromium.org authored
Updated slider expectations after r76147. * platform/chromium/test_expectations.txt: Removed test that will start passing. * platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76365 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xji@chromium.org authored
Unreviewed. Rebaseline for leopard after r76319. * platform/mac-leopard/fast/dom/52776-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76364 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tony@chromium.org authored
Unreviewed, updating chromium DEPS so we can pull in linux theme changes. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76363 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
* MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52855 Reviewed by Dan Bernstein. Source/WebKit2: * Shared/WebPageCreationParameters.h: Added canRunModal. * UIProcess/API/C/WKPage.h: Added a runModal function pointer to WKPageUIClient. Also removed a lot of redundant typedefs and added a new one, WKPageCallback, for callbacks without arguments or return values. * UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Added a runModal function pointer of 0. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Set canRunModal based on return value of WebUIClient::canRunModal. * UIProcess/WebPageProxy.h: Added runModal. Calls WebUIClient::runModal. * UIProcess/WebPageProxy.messages.in: Added RunModal message. Also removed the periods from the phrases in the comments as Maciej requested a while back. * UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::canRunModal): Added. Returns true or false based on whether a runModal function was supplied in the WKPageUIClient structure. (WebKit::WebUIClient::runModal): Added. Calls the runModal function from the WKPageUIClient structure. * UIProcess/WebUIClient.h: Declared the above functions. * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::canRunModal): Call through to WebPage. (WebKit::WebChromeClient::runModal): Ditto. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_canRunModal based on the creation parameters. Initialize m_isRunningModal to false. (WebKit::WebPage::close): Stop the nested run loop if we are running modal. (WebKit::WebPage::runModal): Send a message to ask the UI process to run modal and then start a nested run loop. It gets stopped when the page is closed. * WebProcess/WebPage/WebPage.h: Defined the canRunModal function and declared the runModal function. Tools: This fixes WebKitTestRunner to compile, but more work is probably needed to get it to pass the tests. * WebKitTestRunner/TestController.cpp: (WTR::TestController::runModal): Added. Calls through to the platform-specific version of runModal. (WTR::TestController::createOtherPage): Changed to be a private static member function so it can refer to runModal, which is a private static member function. (WTR::TestController::initialize): Pass 0 for the runModal function since we don't need to run the main window modal. I suspect this is wrong and will need to change. * WebKitTestRunner/TestController.h: Added declarations for the functions added above. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::runModal): Added. Untested implementation. * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::runModal): Added. * WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::runModal): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. remove non-flaky tests from test expectation file https://bugs.webkit.org/show_bug.cgi?id=52746 * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76360 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aroben@apple.com authored
This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as opposed to just "layer" because there are cases where we flush changes to CACFLayers that don't have a corresponding GraphicsLayer. Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in WKCACFLayerRenderer and friends is confusing Reviewed by Simon Fraser. Source/WebCore: * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::render): Updated for renames. (WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from syncCompositingStateSoon, and updated for other renames. * platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to * m_shouldFlushPendingGraphicsLayerChanges. (WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState. Source/WebKit/win: * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes. * WebView.cpp: (WebView::paint): Updated for rename. (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync. (WebView::notifySyncRequired): Updated for rename. (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState. * WebView.h: Did the renames. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient Reviewed by Simon Fraser. * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (toCACFFillModeType): (fromCACFFillModeType): (toCACFValueFunctionType): (fromCACFValueFunctionType): Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just so we can later convert back to CFStringRef. (toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the results of CACFTimingFunctionCreate. (PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED(). (PlatformCAAnimation::setFillMode): (PlatformCAAnimation::setTimingFunction): (PlatformCAAnimation::setValueFunction): (PlatformCAAnimation::setTimingFunctions): Updated for changes to the above conversion functions. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Fisher. FrameLoader::checkLoadCompleteForThisFrame uses wrong history item https://bugs.webkit.org/show_bug.cgi?id=48812 Test that we avoid updating back/forward list on a canceled navigation if a new navigation is already in process. Also update forward-and-cancel to go forward, ensuring back/forward state is reset if user clicks stop. * http/tests/navigation/back-twice-without-commit-expected.txt: Added. * http/tests/navigation/back-twice-without-commit.html: Added. * http/tests/navigation/forward-and-cancel-expected.txt: * http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back. * http/tests/navigation/resources/back-twice-page-2.html: Added. * http/tests/navigation/resources/back-twice-page-3.html: Added. * http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay. 2011-01-21 Charlie Reis <creis@chromium.org> Reviewed by Darin Fisher. FrameLoader::checkLoadCompleteForThisFrame uses wrong history item https://bugs.webkit.org/show_bug.cgi?id=48812 Most calls to stopAllLoaders now clear the history's provisional item(s). We can now avoid resetting the back/forward state if a new navigation is in progress. Test: http/tests/navigation/back-twice-without-commit.html Test: http/tests/navigation/forward-and-cancel.html * loader/FrameLoader.cpp: * loader/FrameLoader.h: * loader/FrameLoaderTypes.h: * WebCore.exp.in: Update stopAllLoaders signature. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76357 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mihaip@chromium.org authored
Reviewed by Eric Seidel. [Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html https://bugs.webkit.org/show_bug.cgi?id=52860 The test hasn't had a timeout in a while, remove that expectation so that we can more easily see if this re-occurs. Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just like chromium-gpu-win and -linux, for some reason the mac expectation has it as 17,128,4). * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed. * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed. * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum. * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76356 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Unreviewed; Reverted the last change to the text expectation. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76355 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Unreviewed Chromium test expectation update. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
