1. 12 Dec, 2007 1 commit
    • weinig@apple.com's avatar
      WebCore: · c5002665
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Scrub URL out of the tree in preparation for renaming KURL to URL.
                  - Renames Document::URL() -> Document::url()
                  - Renames DocumentLoader::URL() -> DocumentLoader::url()
                  - Renames KURL::url() to KURL::string() and KURL::deprecatedString()
                  - Remove FrameLoader::URL()
                  - Various variable renames.
      
              The change from Document::URL() to Document::url() required changes
              to the bindings scripts as well, because URL() is the name of a DOM
              method.  The code generation scripts now have code to special case URL()
              to url().
      
              * WebCore.base.exp:
              * bindings/js/kjs_events.cpp:
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_navigator.cpp:
              (KJS::Navigator::getValueProperty):
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::initScript):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::put):
              (KJS::Window::allowsAccessFrom):
              (KJS::Location::put):
              (KJS::LocationProtoFuncReplace::callAsFunction):
              (KJS::LocationProtoFuncReload::callAsFunction):
              (KJS::LocationProtoFuncAssign::callAsFunction):
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorCOM.pm:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::insertedIntoParent):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseContent):
              (WebCore::CSSParser::parseBackgroundImage):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::createImportRule):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::setEncodedURL):
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv):
              (WebCore::Document::cookie):
              (WebCore::Document::setCookie):
              (WebCore::Document::domain):
              (WebCore::Document::setDomain):
              (WebCore::Document::getImageMap):
              (WebCore::Document::completeURL):
              * dom/Document.h:
              (WebCore::Document::url):
              (WebCore::Document::baseURL):
              * dom/Element.cpp:
              (WebCore::Element::baseURI):
              * dom/ProcessingInstruction.h:
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSImageProperty):
              * dom/StyledElement.h:
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::endElementNs):
              (WebCore::XMLTokenizer::end):
              (WebCore::):
              * dom/XMLTokenizer.h:
              * editing/Editor.cpp:
              (WebCore::Editor::copy):
              * editing/markup.cpp:
              (WebCore::completeURLs):
              * history/CachedPage.h:
              (WebCore::CachedPage::url):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::setURL):
              (WebCore::HistoryItem::isCurrentDocument):
              * html/HTMLBaseElement.cpp:
              (WebCore::HTMLBaseElement::process):
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::reportErrorToConsole):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::childrenChanged):
              (WebCore::HTMLScriptElement::insertedIntoDocument):
              (WebCore::HTMLScriptElement::evaluateScript):
              * html/HTMLScriptElement.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptExecution):
              * loader/Cache.cpp:
              (WebCore::createResource):
              (WebCore::Cache::requestResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::checkNotify):
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h:
              (WebCore::CachedResource::):
              * loader/CachedScript.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::checkForReload):
              (WebCore::DocLoader::requestResource):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::url):
              (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
              (WebCore::DocumentLoader::setRequest):
              (WebCore::DocumentLoader::startLoadingMainResource):
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FormSubmission::FormSubmission):
              (WebCore::ScheduledRedirection::ScheduledRedirection):
              (WebCore::FrameLoader::changeLocation):
              (WebCore::FrameLoader::urlSelected):
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::loadSubframe):
              (WebCore::FrameLoader::submitFormAgain):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::didExplicitOpen):
              (WebCore::FrameLoader::replaceContentsWithScriptResult):
              (WebCore::FrameLoader::executeScript):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::startIconLoader):
              (WebCore::FrameLoader::commitIconURLToIconDatabase):
              (WebCore::FrameLoader::scheduleRefresh):
              (WebCore::FrameLoader::redirectionTimerFired):
              (WebCore::FrameLoader::loadPlugin):
              (WebCore::FrameLoader::didNotOpenURL):
              (WebCore::FrameLoader::updatePolicyBaseURL):
              (WebCore::FrameLoader::scrollToAnchor):
              (WebCore::FrameLoader::startRedirectionTimer):
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::canLoad):
              (WebCore::FrameLoader::shouldHideReferrer):
              (WebCore::FrameLoader::shouldAllowNavigation):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::clientRedirected):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::didTellBridgeAboutLoad):
              (WebCore::FrameLoader::haveToldBridgeAboutLoad):
              (WebCore::FrameLoader::post):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
              (WebCore::FrameLoader::createHistoryItem):
              (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
              (WebCore::FrameLoader::loadItem):
              (WebCore::FrameLoader::urlsMatchItem):
              (WebCore::FrameLoader::recursiveGoToItem):
              (WebCore::FrameLoader::updateHistoryForStandardLoad):
              (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::url):
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::createDocumentStructure):
              * loader/MainResourceLoader.cpp:
              (WebCore::shouldLoadAsEmptyDocument):
              (WebCore::MainResourceLoader::didFinishLoading):
              * loader/NavigationAction.cpp:
              (WebCore::NavigationAction::NavigationAction):
              * loader/NavigationAction.h:
              (WebCore::NavigationAction::url):
              * loader/PluginDocument.cpp:
              (WebCore::PluginTokenizer::createDocumentStructure):
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::load):
              (WebCore::SubresourceLoader::create):
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::startLoading):
              (WebCore::IconLoader::finishLoading):
              * loader/loader.cpp:
              (WebCore::Loader::servePendingRequests):
              * loader/mac/LoaderNSURLExtras.m:
              (urlOriginalData):
              * page/Chrome.cpp:
              (WebCore::Chrome::setToolTip):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/Frame.cpp:
              (WebCore::Frame::setUserStyleSheetLocation):
              * page/InspectorController.cpp:
              (WebCore::InspectorResource::type):
              (WebCore::addSourceToFrame):
              (WebCore::InspectorController::addScriptResource):
              (WebCore::InspectorController::updateScriptResourceRequest):
              (WebCore::InspectorController::didCommitLoad):
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge getData:andResponse:forURL:]):
              * platform/KURL.h:
              (WebCore::KURL::string):
              (WebCore::KURL::deprecatedString):
              * platform/mac/ClipboardMac.mm:
              (WebCore::ClipboardMac::getData):
              * platform/mac/CookieJar.mm:
              (WebCore::cookies):
              (WebCore::setCookies):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeURL):
              (WebCore::fileWrapperForImage):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::plainText):
              * platform/network/ResourceHandle.cpp:
              (WebCore::ResourceHandle::portAllowed):
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::isNull):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::willSendRequest):
              (WebCore::didReceiveResponse):
              (WebCore::didReceiveData):
              (WebCore::didFinishLoading):
              (WebCore::didFail):
              (WebCore::didReceiveChallenge):
              (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
              (WebCore::ResourceHandle::~ResourceHandle):
              (WebCore::ResourceHandle::start):
              * platform/win/ClipboardUtilitiesWin.cpp:
              (WebCore::createGlobalData):
              (WebCore::urlToMarkup):
              * platform/win/ClipboardWin.cpp:
              (WebCore::writeURL):
              (WebCore::writeImageToDataObject):
              (WebCore::ClipboardWin::writeURL):
              (WebCore::ClipboardWin::writeRange):
              * platform/win/PasteboardWin.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writeURL):
              * plugins/win/PluginDatabaseWin.cpp:
              (WebCore::PluginDatabaseWin::findPlugin):
              * plugins/win/PluginStreamWin.cpp:
              (WebCore::PluginStreamWin::startStream):
              (WebCore::PluginStreamWin::destroyStream):
              * plugins/win/PluginViewWin.cpp:
              (WebCore::scriptStringIfJavaScriptURL):
              (WebCore::PluginViewWin::performRequest):
              * svg/SVGImageLoader.cpp:
              (WebCore::SVGImageLoader::updateFromElement):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::getResponseXML):
              (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
              * xml/XSLImportRule.cpp:
              (WebCore::XSLImportRule::loadSheet):
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::createDocumentFromSource):
              (WebCore::xsltStylesheetPointer):
              (WebCore::xmlDocPtrFromNode):
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
      
              Scrub URL out of the tree in preparation for renaming KURL to URL.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::actionDictionary):
              * WebView/WebDataSource.mm:
              (-[WebDataSource _URL]):
              * WebView/WebView.mm:
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
      
      WebKit/win:
      
              Reviewed by Darin Adler.
      
              Scrub URL out of the tree in preparation for renaming KURL to URL.
      
              * WebFrame.cpp:
              (WebFrame::url):
              (WebFrame::dispatchWillPerformClientRedirect):
              (WebFrame::setTitle):
              (WebFrame::updateGlobalHistoryForStandardLoad):
              (WebFrame::updateGlobalHistoryForReload):
              (WebFrame::cancelledError):
              (WebFrame::blockedError):
              (WebFrame::interruptForPolicyChangeError):
              (WebFrame::createPlugin):
              * WebView.cpp:
              (WebView::notifyDidAddIcon):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5002665
  2. 11 Dec, 2007 26 commits
    • mitz@apple.com's avatar
      WebKitTools: · 2895fb6c
      mitz@apple.com authored
              Reviewed by Mark Rowe and Sam Weinig too!
      
              - added Helvetica Oblique and Helvetica Bold Oblique to the list of
                fonts DumpRenderTree registers.
      
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (initialize):
      
      LayoutTests:
      
              Reviewed by Mark Rowe and Sam Weinig too!
      
              - removed tests that pass when Helvetica Oblique and Helvetica
                Bold Oblique are available.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2895fb6c
    • bdakin@apple.com's avatar
      WebCore: · f88ad441
      bdakin@apple.com authored
              Reviewed by Darin.
      
              Fix for <rdar://problem/5641255> SVGs with width and height 100% 
              fail to render when used as background images
      
              CachedImage now has a setImageContainerSize function. It is only 
              needed for SVG right now.
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::setImageContainerSize):
              * loader/CachedImage.h:
      
              Relatively sized SVGs have no intrinsic size. Because this call is 
              low-level enough that we cannot pass in the container size and get 
              the real size of the SVG, we need to know if it has relative 
              dimensions, and if so, we need to get the size from scaledTileSize.
              * platform/graphics/Image.cpp:
              (WebCore::Image::drawTiled):
              * platform/graphics/Image.h:
              (WebCore::Image::setContainerSize):
              (WebCore::Image::hasRelativeWidth):
              (WebCore::Image::hasRelativeHeight):
      
              Re-factored calculateBackgroundSize a bit so that it returns an 
              IntSize. Made it a member function so that it can send m_width and 
              m_height along to setImageContainerSize.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calculateBackgroundSize):
              (WebCore::RenderBox::calculateBackgroundImageGeometry):
              * rendering/RenderBox.h:
      
              Need to account for relatively sized SVGs in calcViewport()
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::calcViewport):
              
              Added new member variables to store the size of the SVG container. 
              relativeWidthValue() and relativeHeightValue() use the stored SVG 
              container size to correctly calculate the width and height of a 
              relatively sized SVG.
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::SVGSVGElement):
              (WebCore::SVGSVGElement::setContainerSize):
              (WebCore::SVGSVGElement::relativeWidthValue):
              (WebCore::SVGSVGElement::relativeHeightValue):
              * svg/SVGSVGElement.h:
              (WebCore::SVGSVGElement::containerSize):
              
              Re-factored size calculations to use the size of the container.
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::setContainerSize):
              (WebCore::SVGImage::size):
              (WebCore::SVGImage::hasRelativeWidth):
              (WebCore::SVGImage::hasRelativeHeight):
              * svg/graphics/SVGImage.h:
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Tests for <rdar://problem/5641255> SVGs with width and height 100% 
              fail to render when used as background images
      
              * fast/backgrounds/resources/balloon.svg: Added.
              * fast/backgrounds/resources/eyes.svg: Added.
              * fast/backgrounds/resources/hearts.svg: Added.
              * fast/backgrounds/resources/linguistics.svg: Added.
              * fast/backgrounds/resources/map.svg: Added.
              * fast/backgrounds/resources/mouse-repel.svg: Added.
              * fast/backgrounds/svg-as-background-1.html: Added.
              * fast/backgrounds/svg-as-background-2.html: Added.
              * fast/backgrounds/svg-as-background-3.html: Added.
              * fast/backgrounds/svg-as-background-4.html: Added.
              * fast/backgrounds/svg-as-background-5.html: Added.
              * fast/backgrounds/svg-as-background-6.html: Added.
              * platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
              * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
              * platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
              * platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
              * platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
              * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
              * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
              * platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f88ad441
    • ggaren@apple.com's avatar
      Reviewed by Sam Weinig. · e599e82d
      ggaren@apple.com authored
              
              Build fix: Note some variables that are used only for ASSERTs.
      
              * API/testapi.c:
              (Base_finalize):
              (globalObject_initialize):
              (testInitializeFinalize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e599e82d
    • ggaren@apple.com's avatar
      Reviewed by Darin Adler. · 6a39cc34
      ggaren@apple.com authored
              
              Fixed: All JS tests crash on Windows.
      
              NDEBUG wasn't defined when compiling testkjs in release builds, so the
              HashTable definition in HashTable.h included an extra data member.
      
              The solution was to add NDEBUG to the release testkjs configuration on
              Windows and Mac.
              
              For giggles, I also added other missing #defines to testkjs on Windows.
      
              * Configurations/Base.xcconfig:
              * Configurations/JavaScriptCore.xcconfig:
              * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kjs/testkjs.cpp:
              (main):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a39cc34
    • alp@webkit.org's avatar
      2007-12-11 George Wright <george.wright@collabora.co.uk> · 2fe8be81
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=14120
              [GDK] Support input methods
      
              This patch adds infrastructure for input method support.
      
              It also adds Hildon features for the Maemo mobile platform sufficient
              to support the virtual keyboard.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::imContextCommitted):
              (WebKit::EditorClient::EditorClient):
              (WebKit::EditorClient::~EditorClient):
              (WebKit::EditorClient::textFieldDidBeginEditing):
              (WebKit::EditorClient::textFieldDidEndEditing):
              * WebCoreSupport/EditorClientGtk.h:
              * WebView/webkitprivate.h:
              * WebView/webkitwebview.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fe8be81
    • andersca@apple.com's avatar
      Reviewed by Darin. · d73294e8
      andersca@apple.com authored
          
              <rdar://problem/5636865>
              WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)
              
              * Interfaces/IWebView.idl:
              * WebView.cpp:
              (WebView::registerURLSchemeAsLocal):
              * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d73294e8
    • adachan@apple.com's avatar
      Updated the database SPI to take in IWebFrame. · 18b84ea9
      adachan@apple.com authored
              Reviewed by Adam.
      
              * Interfaces/IWebUIDelegatePrivate.idl:
              * WebChromeClient.cpp:
              (WebChromeClient::requestQuotaIncreaseForNewDatabase):
              (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b84ea9
    • darin@apple.com's avatar
      * editing/Editor.cpp: · 6c9732f8
      darin@apple.com authored
              (WebCore::Editor::yankFromKillRing): Try to fix non-Mac builds by adding
              a missing return statement.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c9732f8
    • ap@webkit.org's avatar
      Windows build fix. · c783208d
      ap@webkit.org authored
              * WebView.cpp:
              (WebView::interpretKeyEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c783208d
    • zimmermann@webkit.org's avatar
      Rubberstamped by Mark. · b5b89c88
      zimmermann@webkit.org authored
      Add missing tests - their results have already been checked in over a month ago - I forgot to commit the tests itself.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5b89c88
    • zimmermann@webkit.org's avatar
      Rubberstamped by Mark. · 0e34524d
      zimmermann@webkit.org authored
      Update pixel test results now that filters are disabled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e34524d
    • ggaren@apple.com's avatar
      Reviewed by Darin Adler. · 6f0cf2aa
      ggaren@apple.com authored
              
              Removed bogus ASSERT.
              
              ASSERT should only be used when we know that a code path will not be
              taken. This code path is taken often during the jsFunFuzz test.
      
              * pcre/pcre_exec.cpp:
              (jsRegExpExecute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f0cf2aa
    • darin@apple.com's avatar
      WebCore: · 5377d7de
      darin@apple.com authored
              Reviewed by Geoff.
      
              - exposed many new commands to the DOM Document executeCommand function by
                merging the JSEditor and Editor executeCommand implementations
              - replaced the execCommand function with a EditorCommand class
              - replaced the WTF::StrHash<> class template with the WebCore::StringHash class
              - replaced the WTF::CaseInsensitiveHash<> class template with the
                WebCore::CaseFoldingHash class
      
              * WebCore.base.exp: Updated.
              * WebCore.pro: Added EditorCommand.cpp, removed JSEditor.cpp.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Removed code to set up m_jsEditor.
              (WebCore::Document::~Document): Removed code to delete m_jsEditor.
              (WebCore::command): Added. Helper function that gets an Editor::Command.
              (WebCore::Document::executeCommand): Changed to use Editor::Command instead of
              JSEditor.
              (WebCore::Document::queryCommandEnabled): Ditto.
              (WebCore::Document::queryCommandIndeterm):
              (WebCore::Document::queryCommandState): Ditto.
              (WebCore::Document::queryCommandSupported): Ditto.
              (WebCore::Document::queryCommandValue): Ditto.
      
              * dom/Document.h: Removed JSEditor, jsEditor, m_jsEditor. Changed to
              use CaseFoldingHash.
      
              * editing/Editor.cpp:
              (WebCore::Editor::selectionForCommand): Renamed from selectionForEvent and
              made into a member function so it is accessible from the new EditorCommand.cpp file.
              Also changed to get the selection from the passed-in frame instead of from the
              page, because this should work on the targeted frame unless the event overrides it.
              (WebCore::Editor::handleKeypress): Updated for selectionForCommand change.
              (WebCore::Editor::handleInputMethodKeypress): Ditto.
              (WebCore::imageElementFromImageDocument): Renamed and changed to return
              a HTMLImageElement instead of a Node*.
              (WebCore::Editor::canCopy): Updated for name change.
              (WebCore::Editor::selectionUnorderedListState): Updated for TriState change.
              (WebCore::Editor::selectionOrderedListState): Ditto.
              (WebCore::Editor::selectionStartHasStyle): Make type of local more specific.
              (WebCore::updateState): Moved here from Frame.
              (WebCore::Editor::selectionHasStyle): Ditto.
              (WebCore::Editor::Editor): Initialize m_shouldStartNewKillRingSequence.
              (WebCore::Editor::insertTextWithoutSendingTextEvent): Updated for
              selectionForCommand change.
              (WebCore::Editor::copy): Updated for imageElementFromImageDocument change.
              (WebCore::Editor::toggleBold): Call the ToggleBold command via the command
              machinery since it's no longer in this file as a local function.
              (WebCore::Editor::toggleUnderline): Call the ToggleUnderline command.
              (WebCore::Editor::setBaseWritingDirection): Change type of argument and of
              local variable.
              (WebCore::Editor::addToKillRing): Moved here from EditorMac. Not useful
              without a kill ring, but it's relatively straightforward to implement one.
              (WebCore::Editor::appendToKillRing): Put default implementation here for
              platforms other than Mac. We should probably put a simple kill ring
              implementation here -- doesn't need to be shared with the OS oh platforms
              other than Mac.
              (WebCore::Editor::prependToKillRing): Ditto.
              (WebCore::Editor::yankFromKillRing): Ditto.
              (WebCore::Editor::startNewKillRingSequence): Ditto.
              (WebCore::Editor::setKillRingToYankedState): Ditto.
      
              * editing/Editor.h: Moved the TriState enum here instead of inside the
              Frame class. Added EditorCommandSource enum. Moved selectionHasStyle
              here from the Frame class. Added Editor::Command class with five functions
              for the various things you can do with a command (execute it, check if it
              can be used, and its state and value). Changed hte parameter of
              setBaseWritingDirection to be a const String& rather than a String.
              Got rid of the kill-ring-related operations, but added the kill ring
              functions themselves. Made selectedRange() public. Made the
              m_startNewKillRingSequence not Mac-specific and added "should" to its
              name.
      
              * editing/EditorCommand.cpp: Copied from WebCore/editing/Editor.cpp.
              Retained only the editing commands.
              (WebCore::targetFrame): Moved to the top of the file.
              (WebCore::executeApplyStyle): Added. Helper function for commands
              that need to apply styles.
              (WebCore::executeToggleStyle): Added. Helper function for commands
              that need to toggle styles based on the style of the start of selection.
              (WebCore::executeApplyParagraphStyle): Added. Like executeApplyStyle, but
              for paragraph styles.
              (WebCore::executeInsertFragment): Added. Helper function for commands
              that need to insert a DOM fragment.
              (WebCore::executeInsertNode): Added. Helper function for commands that
              need to insert a tree rooted in a single DOM node.
              (WebCore::stateStyle): Added. Helper function for the state of commands
              that represent style.
              (WebCore::valueStyle): Added. Helper function for the value of commands
              that represent style.
              (WebCore::canScroll): Added. Helper functions for some move and scroll
              commands that need to determine if the renderer they are in can scroll.
              (WebCore::unionDOMRanges): Moved here from EditorMac.
              (WebCore::executeBackColor):
              (WebCore::executeBackwardDelete):
              (WebCore::executeCopy):
              (WebCore::executeCreateLink):
              (WebCore::executeCut):
              (WebCore::executeDelete):
              (WebCore::executeDeleteToMark):
              (WebCore::executeDeleteWordBackward):
              (WebCore::executeDeleteWordForward):
              (WebCore::executeFindString):
              (WebCore::executeFontName):
              (WebCore::executeFontSize):
              (WebCore::executeFontSizeDelta):
              (WebCore::executeForeColor):
              (WebCore::executeFormatBlock):
              (WebCore::executeForwardDelete):
              (WebCore::executeIndent):
              (WebCore::executeInsertBacktab):
              (WebCore::executeInsertHorizontalRule):
              (WebCore::executeInsertHTML):
              (WebCore::executeInsertImage):
              (WebCore::executeInsertLineBreak):
              (WebCore::executeInsertNewline):
              (WebCore::executeInsertNewlineInQuotedContent):
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertParagraph):
              (WebCore::executeInsertTab):
              (WebCore::executeInsertText):
              (WebCore::executeInsertUnorderedList):
              (WebCore::executeJustifyCenter):
              (WebCore::executeJustifyFull):
              (WebCore::executeJustifyLeft):
              (WebCore::executeJustifyRight):
              (WebCore::executeMoveBackward):
              (WebCore::executeMoveBackwardAndModifySelection):
              (WebCore::executeMoveDown):
              (WebCore::executeMoveDownAndModifySelection):
              (WebCore::executeMoveDownByPageAndModifyCaret):
              (WebCore::executeMoveForward):
              (WebCore::executeMoveForwardAndModifySelection):
              (WebCore::executeMoveLeft):
              (WebCore::executeMoveLeftAndModifySelection):
              (WebCore::executeMoveRight):
              (WebCore::executeMoveRightAndModifySelection):
              (WebCore::executeMoveToBeginningOfDocument):
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::executeMoveToBeginningOfLine):
              (WebCore::executeMoveToBeginningOfLineAndModifySelection):
              (WebCore::executeMoveToBeginningOfParagraph):
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::executeMoveToBeginningOfSentence):
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfDocument):
              (WebCore::executeMoveToEndOfDocumentAndModifySelection):
              (WebCore::executeMoveToEndOfSentence):
              (WebCore::executeMoveToEndOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfLine):
              (WebCore::executeMoveToEndOfLineAndModifySelection):
              (WebCore::executeMoveToEndOfParagraph):
              (WebCore::executeMoveToEndOfParagraphAndModifySelection):
              (WebCore::executeMoveParagraphBackwardAndModifySelection):
              (WebCore::executeMoveParagraphForwardAndModifySelection):
              (WebCore::executeMoveUp):
              (WebCore::executeMoveUpAndModifySelection):
              (WebCore::executeMoveUpByPageAndModifyCaret):
              (WebCore::executeMoveWordBackward):
              (WebCore::executeMoveWordBackwardAndModifySelection):
              (WebCore::executeMoveWordForward):
              (WebCore::executeMoveWordForwardAndModifySelection):
              (WebCore::executeMoveWordLeft):
              (WebCore::executeMoveWordLeftAndModifySelection):
              (WebCore::executeMoveWordRight):
              (WebCore::executeMoveWordRightAndModifySelection):
              (WebCore::executeOutdent):
              (WebCore::executePaste):
              (WebCore::executePasteAndMatchStyle):
              (WebCore::executePrint):
              (WebCore::executeRedo):
              (WebCore::executeRemoveFormat):
              (WebCore::executeSelectAll):
              (WebCore::executeSelectToMark):
              (WebCore::executeSetMark):
              (WebCore::executeStrikethrough):
              (WebCore::executeSubscript):
              (WebCore::executeSuperscript):
              (WebCore::executeSwapWithMark):
              (WebCore::executeToggleBold):
              (WebCore::executeToggleItalic):
              (WebCore::executeTranspose):
              (WebCore::executeUnderline):
              (WebCore::executeUndo):
              (WebCore::executeUnlink):
              (WebCore::executeUnscript):
              (WebCore::executeUnselect):
              (WebCore::executeYank):
              (WebCore::executeYankAndSelect):
              (WebCore::supported):
              (WebCore::supportedPaste):
              (WebCore::enabled):
              (WebCore::enabledAnySelection):
              (WebCore::enabledAnySelectionAndMark):
              (WebCore::enableCaretInEditableText):
              (WebCore::enabledCopy):
              (WebCore::enabledCut):
              (WebCore::enabledInEditableText):
              (WebCore::enabledInRichlyEditableText):
              (WebCore::enabledPaste):
              (WebCore::enabledRangeInEditableText):
              (WebCore::enabledRangeInRichlyEditableText):
              (WebCore::enabledRedo):
              (WebCore::enabledUndo):
              (WebCore::stateNone):
              (WebCore::stateBold):
              (WebCore::stateItalic):
              (WebCore::stateOrderedList):
              (WebCore::stateStrikethrough):
              (WebCore::stateSubscript):
              (WebCore::stateSuperscript):
              (WebCore::stateUnderline):
              (WebCore::stateUnorderedList):
              (WebCore::valueNull):
              (WebCore::valueBackColor):
              (WebCore::valueFontName):
              (WebCore::valueFontSize):
              (WebCore::valueFontSizeDelta):
              (WebCore::valueForeColor):
              (WebCore::createCommandMap): Added lots of commands, including all the commands
              from JSEditor. A few commands needed different behavior based on whether they are
              invoked from the DOM or a keyboard binding.
              (WebCore::Editor::command): Added. Gets a command object given a name.
              (WebCore::Editor::Command::Command): Added.
              (WebCore::Editor::Command::execute): Added.
              (WebCore::Editor::Command::isSupported): Added.
              (WebCore::Editor::Command::isEnabled): Added.
              (WebCore::Editor::Command::state): Added.
              (WebCore::Editor::Command::value): Added.
              (WebCore::Editor::execCommand): Changed to call command().execute().
      
              * editing/JSEditor.cpp: Removed.
              * editing/JSEditor.h: Removed.
      
              * editing/mac/EditorMac.mm: Changed to provide kill ring primitives intead of
              kill ring commands, so the kill ring commands can be cross-platform.
              (WebCore::Editor::appendToKillRing): Added.
              (WebCore::Editor::prependToKillRing): Added.
              (WebCore::Editor::yankFromKillRing): Added.
              (WebCore::Editor::startNewKillRingSequence): Added.
              (WebCore::Editor::setKillRingToYankedState): Added.
      
              * page/Frame.cpp: Removed selectionHasStyle, TriState, and updateState.
              * page/Frame.h: Ditto.
      
              * page/mac/WebCoreFrameBridge.mm: Removed selectionHasStyle.
              * page/mac/WebCoreFrameBridge.h: Ditto.
      
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for TriState change.
      
              * platform/text/StringHash.h:
              (WebCore::StringHash::hash): Merged the StrHash<> template classes into this.
              (WebCore::StringHash::equal): Ditto.
              (WebCore::CaseFoldingHash::hash): Merged the CaseInsensitiveHash<> template
              classes into this.
              (WebCore::CaseFoldingHash::equal): Ditto.
      
              * platform/text/StringImpl.cpp:
              (WebCore::equal): Changed to invoke StringHash.
              (WebCore::equalIgnoringCase): Changed to invoke CaseFoldingHash.
      
              * dom/DOMImplementation.cpp:
              (WebCore::addString): Updated to use StringHash and CaseFoldingHash.
              (WebCore::isSVG10Feature): Ditto.
              (WebCore::isSVG11Feature): Ditto.
              * loader/FrameLoader.cpp:
              (WebCore::localSchemes): Ditto.
              * platform/graphics/FontCache.cpp:
              (WebCore::computeHash): Ditto.
              * platform/network/HTTPHeaderMap.h: Ditto.
              * platform/text/PlatformString.h: Ditto.
              * platform/text/StringImpl.h: Ditto.
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget): Ditto.
              * xml/XMLHttpRequest.cpp:
              (WebCore::canSetRequestHeader): Ditto.
      
              * rendering/RenderTreeAsText.cpp: Removed stray include of JSEditor.h.
      
      WebKit/mac:
      
              Reviewed by Geoff.
      
              - change more editing commands to use WebCore::Editor
              - change to use the new WebCore::Editor::command() function
      
              * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
              alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
              insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
              subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
              to use the "forward to WebCore" macro instead of having hand-written implementations.
              (kit): Added function to change a TriState to an AppKit-style tri-state value.
              (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
              first character or copies the selector name, since the Editor commands are not case
              sensitive any more. Returns a command object.
              (-[WebHTMLView coreCommandByName:]): Added.
              (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
              and changed to use the new coreCommandBySelector: method.
              (-[WebHTMLView executeCoreCommandByName:]): Added.
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
              methods that call through to WebCore to also use the state() and isEnabled()
              functions on the commands for the menu item state and user interface item enabling.
              (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
              name rather than having local methods for them; no need for methods with a single
              call site.
              (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
              than the deprecated execCommand().
              (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
              than the deprecated execCommand().
              * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
      
      WebKit/win:
      
              * WebView.cpp:
              (WebView::handleEditingKeyboardEvent): Update for change to Editor API.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5377d7de
    • darin@apple.com's avatar
      * platform/wx/KeyboardEventWx.cpp: · 675b3af3
      darin@apple.com authored
              (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Another try at fixing the
              WX build. Changes the code around a little bit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      675b3af3
    • beidson@apple.com's avatar
      Reviewed by Anders · 774a1659
      beidson@apple.com authored
              Make DumpRenderTree on mac use its own path for Databases testing
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
                for future DRT-only use, then use it to construct the Databases path and set that default
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774a1659
    • darin@apple.com's avatar
      * platform/wx/KeyboardEventWx.cpp: · 02462704
      darin@apple.com authored
              (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Quick try at fixing build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02462704
    • darin@apple.com's avatar
    • mitz@apple.com's avatar
      WebCore: · 67f46968
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia
      
              Test: fast/text/international/complex-character-based-fallback.html
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::glyphDataForCharacter): Added a forceSmallCaps argument
              that forces this function to use the small caps font. It is used for
              combining marks that need to combine with a small cap.
              * platform/graphics/Font.h:
              * platform/win/UniscribeController.cpp:
              (WebCore::UniscribeController::advance): Changed to split the string
              into runs of characters that will be rendered using the same FontData.
              This is done by calling glyphDataForCharacter() for each cahracter to
              find the FontData it should be rendered with.
              (WebCore::UniscribeController::itemizeShapeAndPlace): Added a fontData
              argument that is passed on to shapeAndPlaceItem() instead of the
              smallCaps argument.
              (WebCore::UniscribeController::shapeAndPlaceItem): Added a fontData
              argument and removed the font fallback logic from this function, as
              it is now expected to be called with an item all of whose characters
              can be rendered with the given fontData.
              * platform/win/UniscribeController.h:
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia
      
              * fast/text/international/complex-character-based-fallback.html: Added.
              * platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
              * platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.png: Added.
              * platform/mac/fast/text/international/complex-character-based-fallback-expected.txt: Added.
              * platform/win/fast/text: Added.
              * platform/win/fast/text/international: Added.
              * platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
              * platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
              * platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f46968
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6a50667f
      ap@webkit.org authored
              <rdar://problem/5535636>
              Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
      
              http://bugs.webkit.org/show_bug.cgi?id=13916
              JavaScript detects Tab as a character input on a textfield validation
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a50667f
    • sullivan@apple.com's avatar
      Reviewed by Adele · ff94b4be
      sullivan@apple.com authored
              Tiger build fix -- don't call QTMovieView setDelegate: directly because it's not public
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::createQTMovieView):
              (WebCore::MediaPlayerPrivate::detachQTMovieView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff94b4be
    • kmccullough@apple.com's avatar
      Reviewed by Oliver. · ae9b7815
      kmccullough@apple.com authored
              - <rdar://5599845> Drosera: Does not show loal files in the file list
              on the left side.
      
              * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
              * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
              so the open source community can build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae9b7815
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6b152753
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16325
              <rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work
      
              Fix this on Windows, too!
      
              Test: http/tests/misc/empty-cookie.html
      
              * platform/network/win/CookieJarWin.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              Same fix as on Mac, translated into CF.
      
              * platform/win/CookieJarWin.cpp: Removed - the real one is in platform/network/win.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b152753
    • alp@webkit.org's avatar
      2007-12-11 Christian Dywan <christian@twotoasts.de> · b3fc62d8
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=16371
              Implement additional mouse cursors for Gtk
      
              Added cursor bitmaps from Mozilla:
              http://lxr.mozilla.org/mozilla1.8/source/widget/src/gtk2/nsGtkCursors.h
      
              * platform/gtk/CursorGtk.cpp:
              (WebCore::customCursorNew):
              (WebCore::verticalTextCursor):
              (WebCore::cellCursor):
              (WebCore::contextMenuCursor):
              (WebCore::noDropCursor):
              (WebCore::copyCursor):
              (WebCore::progressCursor):
              (WebCore::aliasCursor):
              (WebCore::noneCursor):
              (WebCore::notAllowedCursor):
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
              * platform/gtk/CursorGtk.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3fc62d8
    • oliver@apple.com's avatar
      Fix character set used for dynamically loaded scripts. · c54c09b0
      oliver@apple.com authored
      Reviewed by Weinig, Dan and Alexey.
      
      Fix for:
          <rdar://problem/5333163> Safari can not display the mouse over pop menu on ChinaTimes News site correctly.
          <rdar://problem/5530048> [Safari]? :Leopard9A576: The typed CH characters displays as garbage in Sina website after reloading the webpage.
          <rdar://problem/5416588> All menus for chinese IBM site have wrong encoding
      
      Use the same logic to determine the charset for a script loaded dynamically
      as we do for a statically loaded script.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c54c09b0
    • justin.garcia@apple.com's avatar
      WebCore: · 08b1c80d
      justin.garcia@apple.com authored
              Reviewed by Oliver Hunt.
      
              <rdar://problem/5482023> GoogleDocs: After FormatBlock in an empty document, certain functions are disabled
              
              We were trying to insert a block of the requested type before the body element.
              
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::doApply): 
              Removed unnecessary ()s in the if condition.
              Removed "|| !upstreamStart.node()->isDescendantOf(root)" from the if condition, since
              a) upstreamStart will never be outside the root editable element, since in that case
              there would be no block inside the editable root to Format, and b) if upstreamStart.node() 
              *is* the root, then refNode is the root, and we shouldn't insert before the root, we should insert
              at [root, 0].
              Added comments to explain the use of upstream() in the second if-clause.
              Added an early return for case where there is nothing selected, in that case, there is nothing
              to move.
      
      LayoutTests:
      
              Reviewed by Oliver Hunt.
              
              <rdar://problem/5482023> GoogleDocs: After performing FormatBlock in an empty document, certain functions are disabled
      
              * editing/execCommand/5482023.html: Added.
              * platform/mac/editing/execCommand/5482023-expected.checksum: Added.
              * platform/mac/editing/execCommand/5482023-expected.png: Added.
              * platform/mac/editing/execCommand/5482023-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08b1c80d
    • adele@apple.com's avatar
      Reviewed and partially fixed by Tim Hatcher. · 1e79a54a
      adele@apple.com authored
              Remaining part of fix for <rdar://problem/5633400>
              Transformed <video> is not clipped correctly until a repaint is forced
      
              Replace the implementation of a QTKit method to avoid repaints from the NSView system associated with the QTMovie
              from clobbering the WebCore repaints.
      
              * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRepaint): Added.
              * html/HTMLMediaElement.h:
              * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::repaint): Added.
              * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): Added.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (method_setImplementation): Added for Tiger.
      
              (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call detachQTMovieView, which now does more cleanup.
              (WebCore::MediaPlayerPrivate::cancelLoad): ditto.
              (WebCore::MediaPlayerPrivate::setVisible): ditto.
              (WebCore::MediaPlayerPrivate::detachQTMovieView): Clear the delegate as well as m_qtMovieView pointer.
      
              (WebCore::MediaPlayerPrivate::repaint): Added.  Triggers a repaint on the video renderer.
              (-[WebCoreMovieObserver repaint]): ditto.
      
              (WebCore::mainThreadSetNeedsDisplay): Added.
               Does a WebCore repaint instead of going through the view repaint system for QTMovieView.
              (WebCore::MediaPlayerPrivate::createQTMovieView): Replace the implementation of _mainThreadSetNeedsDisplay.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e79a54a
  3. 10 Dec, 2007 13 commits
    • darin@apple.com's avatar
      JavaScriptCore: · 4c77b719
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=16379
                REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and
                fast/dom/xmlhttprequest-html-response-encoding.html
                and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function
                find_firstassertedchar
      
              Test: fast/js/regexp-find-first-asserted.html
      
              * pcre/pcre_compile.cpp:
              (compileBracket): Take out unnecessary initialization of out parameters.
              (branchFindFirstAssertedCharacter): Added. Broke out the half of the function that handles
              a branch.
              (bracketFindFirstAssertedCharacter): Renamed from find_firstassertedchar. Also removed the
              options parameter -- the caller can handle the options.
              (jsRegExpCompile): Changed call site to call the appropriate bracket or branch version of
              the find_firstassertedchar function. Also put the REQ_IGNORE_CASE code here instead of
              passing in the options.
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16379
                REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and
                fast/dom/xmlhttprequest-html-response-encoding.html
                and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function
                find_firstassertedchar
      
              * fast/js/regexp-find-first-asserted-expected.txt: Added.
              * fast/js/regexp-find-first-asserted.html: Added.
              * fast/js/resources/regexp-find-first-asserted.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c77b719
    • ggaren@apple.com's avatar
      JavaScriptCore: · e65a290f
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Split this:
              
                                  FunctionBodyNode
                                          ^
                                          |
                                      ProgramNode
                  
              into this:
                  
                                      ScopeNode
                      ^                   ^                   ^
                      |                   |                   |
              FunctionBodyNode        ProgramNode         EvalNode
      
              in preparation for specializing each class more while optimizing global
              variable access.
              
              Also removed some cruft from the FunctionBodyNode interface to simplify
              things.
              
              SunSpider says this patch is a .8% speedup, which seems reasonable,
              since it eliminates a few branches and adds KJS_FAST_CALL in a few
              places.
              
              Layout tests and JS tests pass. Also, this baby builds on Windows! (Qt
              mileage may vary...)
      
      WebCore:
      
              Reviewed by Sam Weinig.
      
              Updated for rename in JavaScriptCore.
      
              * bridge/mac/WebCoreScriptDebugger.mm:
              (-[WebCoreScriptCallFrame scopeChain]):
              (-[WebCoreScriptCallFrame functionName]):
              (-[WebCoreScriptCallFrame evaluateWebScript:]):
      
      WebKit/win:
      
              Reviewed by Sam Weinig.
      
              Updated for rename in JavaScriptCore.
      
              * WebScriptCallFrame.cpp:
              (WebScriptCallFrame::functionName):
              (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65a290f
    • ddkilzer@apple.com's avatar
      Add bug reference. · 2f2c9394
      ddkilzer@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f2c9394
    • ddkilzer@apple.com's avatar
      Use KJS::Window not the ambiguous Window · 6e12d3ee
      ddkilzer@apple.com authored
              Reviewed by ddkilzer.
      
              * bindings/js/kjs_dom.cpp (checkNodeSecurity):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e12d3ee
    • ggaren@apple.com's avatar
      RS by Mark Rowe. · 3394419f
      ggaren@apple.com authored
              
              Mac build fix: added some exported symbols, now that Parser::parse is
              defined in the header.
      
              * JavaScriptCore.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3394419f
    • weinig@apple.com's avatar
      Build fix. · b71dafd4
      weinig@apple.com authored
              Template methods need to be in the header.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * kjs/Parser.cpp:
              * kjs/Parser.h:
              (KJS::Parser::parse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b71dafd4
    • beidson@apple.com's avatar
      Rubberstamped by Sam Weinig · 8f3ccf8f
      beidson@apple.com authored
              Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
              (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f3ccf8f
    • beidson@apple.com's avatar
      Reviewed by John Sullivan · 61f2bae2
      beidson@apple.com authored
              Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
      
              This is because a common UI case is to want to know the originating URL of a Database
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::requestQuotaIncreaseForNewDatabase):
              (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
      
              * WebView/WebUIDelegatePrivate.h:
      
              * WebView/WebView.mm:
              (CallDelegateReturningUnsignedLongLong):
              (CallUIDelegateReturningUnsignedLongLong):
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61f2bae2
    • antti@apple.com's avatar
      Reviewed by Adele. · 7937702e
      antti@apple.com authored
              
              The load events could fire before the event listener was registered making these tests fail occasionally.
              
              No changes to test results.
      
              * media/video-source-media.html:
              * media/video-source-type.html:
              * media/video-source.html:
              * media/video-src-remove.html:
              * media/video-src-source.html:
              * media/video-src.html:
              * media/video-test.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7937702e
    • ggaren@apple.com's avatar
      Reviewed by Sam Weinig. · 7fd592c7
      ggaren@apple.com authored
              
              Merged different implementations of Parser::parse into a single,
              templatized implementation, in preparation for adding yet another
              implementation for "eval" code.
              
              JS and layout tests pass.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fd592c7
    • weinig@apple.com's avatar
      Fix non-mac builds. · ef066035
      weinig@apple.com authored
              * page/WindowFeatures.cpp: #include <wtf/MathExtras.h> for isnan.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef066035
    • andrew@webkit.org's avatar
      2007-09-05 Marvin Decker <marv.decker@gmail.com> · 984118f9
      andrew@webkit.org authored
              Reviewed by Darin.
      
              Fix a divide by 0 in the progress tracker.
              http://bugs.webkit.org/show_bug.cgi?id=15055
      
              * loader/ProgressTracker.cpp:
              (WebCore::ProgressTracker::incrementProgress):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      984118f9
    • weinig@apple.com's avatar
      Reviewed by Darin. · 64c4a86a
      weinig@apple.com authored
              More cleanup of kjs_window.
              - Move WindowFeatures from bridge/ to page/
              - Move functions related to WindowFeatures (boolFeature,
                floatFeature, setWindowFeature, parseWindowFeatures) into the class.
              - Fix up whitespace.
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_window.cpp:
              (KJS::DOMWindowTimer::~DOMWindowTimer):
              (KJS::createWindow):
              (KJS::showModalDialog):
              (KJS::Window::getOwnPropertySlot):
              (KJS::Window::allowsAccessFrom):
              (KJS::Window::shouldInterruptScript):
              (KJS::WindowProtoFuncAToB::callAsFunction):
              (KJS::WindowProtoFuncOpen::callAsFunction):
              (KJS::Window::setReturnValueSlot):
              (KJS::ScheduledAction::execute):
              (KJS::Window::timerFired):
              (KJS::Location::Location):
              (KJS::Location::getValueProperty):
              (KJS::Location::getOwnPropertySlot):
              (KJS::Location::put):
              (KJS::LocationProtoFuncReplace::callAsFunction): Use better variable names.
              (KJS::LocationProtoFuncAssign::callAsFunction): Ditto.
              (KJS::LocationProtoFuncToString::callAsFunction): Remove extraneous calls to
              allowsAccessFrom, cleanup the function a little.
              (KJS::PausedTimeouts::~PausedTimeouts):
              * bridge/WindowFeatures.h: Removed.
              * page/WindowFeatures.cpp: Added.
              (WebCore::isSeparator):
              (WebCore::WindowFeatures::WindowFeatures):
              (WebCore::WindowFeatures::setWindowFeature):
              (WebCore::WindowFeatures::boolFeature):
              (WebCore::WindowFeatures::floatFeature):
              * page/WindowFeatures.h: Copied from WebCore/bridge/WindowFeatures.h.
              (WebCore::WindowFeatures::WindowFeatures):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c4a86a