- 02 Oct, 2012 40 commits
-
-
mkwst@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=98169 http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html and http/tests/inspector/csp-inline-warning-contains-stacktrace.html started failing on Apple Win 7 Release (Tests) in r130150 <http://trac.webkit.org/changeset/130150>. http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r130150%20(28375)/results.html Will be fixed in webkit.org/b/98169 * platform/win/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ojan@chromium.org authored
* platform/chromium/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=96203 Reviewed by Dirk Pranke. Often in debug builds, the first tests in each worker crash because they can't yet open the Xvfb display assigned to them. This indicates Xvfb hasn't yet been set up. To avoid this, the execution should halt for a small amount of time before tests are run so the Xvfb process has enough time to get ready. At the moment this is done right after the Xvfb process is spawned and the execution halts for one second. That value is overriden to zero when testing to not prolong the testing time. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: (XvfbDriver.__init__): (XvfbDriver._start): * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: (XvfbDriverTest.make_driver): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98066 Patch by Brian White <bcwhite@chromium.org> on 2012-10-02 Reviewed by Adam Barth. Chromium uses the document language to offer translation. It's been doing its own detection of this property but it would be better to get it from existing extraction code. * public/WebDocument.h: (WebDocument): * src/WebDocument.cpp: (WebKit::WebDocument::contentLanguage): (WebKit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=97740 Reviewed by Darin Adler. Source/WebCore: Changed parserAppendData to take a string instead of a UChar*. Also added an optional offset argument to handle string+offset. The actual string append now uses the appropriate string size. * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): * dom/CharacterData.h: (CharacterData): * dom/Text.cpp: (WebCore::Text::createWithLengthLimit): * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode): Source/WTF: Added an append method that takes an LChar source. Made both the UChar and LChar versions optimally handle the appendee and appendend string bitness. * wtf/text/WTFString.cpp: (WTF::String::append): * wtf/text/WTFString.h: (String): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ojan@chromium.org authored
http://trac.webkit.org/changeset/130103 http://trac.webkit.org/changeset/130125 https://bugs.webkit.org/show_bug.cgi?id=97974 Causes performance regressions on Dromaeo dom modify tests. * bindings/v8/IntrusiveDOMWrapperMap.h: (WebCore): (ChunkedTable): (WebCore::ChunkedTable::ChunkedTable): (WebCore::ChunkedTable::add): (WebCore::ChunkedTable::remove): (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::reportMemoryUsage): (WebCore::ChunkedTable::Chunk::Chunk): (Chunk): (WebCore::ChunkedTable::clearEntries): (WebCore::ChunkedTable::visitEntries): (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::IntrusiveDOMWrapperMap::get): (WebCore::IntrusiveDOMWrapperMap::set): (WebCore::IntrusiveDOMWrapperMap::contains): (WebCore::IntrusiveDOMWrapperMap::visit): (WebCore::IntrusiveDOMWrapperMap::removeIfPresent): (IntrusiveDOMWrapperMap): (WebCore::IntrusiveDOMWrapperMap::clear): (ChunkedTableTraits): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit): * bindings/v8/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper): (WebCore::ScriptWrappable::reportMemoryUsage): (ScriptWrappable): * bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getCachedWrapper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98170 Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-10-02 Reviewed by Csaba Osztrogonác. * platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.png: * platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.png: * platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.png: * platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=98150 Reviewed by Yury Semikhatsky. Source/WebCore: Style changes. * platform/KURLWTFURLImpl.h: (WebCore::KURLWTFURLImpl::reportMemoryUsage): Source/WTF: Memory instrumentation for ParsedURL was extracted into separate header MemoryInstrumentationParsedURL.h Drive by fix: unnecessary include was removed from String*.cpp files. * GNUmakefile.list.am: * WTF.gypi: * WTF.pro: * WTF.xcodeproj/project.pbxproj: * wtf/MemoryInstrumentation.h: (WTF): * wtf/MemoryInstrumentationParsedURL.h: Added. (WTF): (WTF::reportMemoryUsage): * wtf/text/AtomicString.cpp: * wtf/text/StringImpl.cpp: * wtf/text/WTFString.cpp: * wtf/url/api/ParsedURL.cpp: * wtf/url/api/ParsedURL.h: * wtf/url/api/URLString.cpp: * wtf/url/api/URLString.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98162 Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-02 Reviewed by Kenneth Rohde Christiansen. Use XvfbDriver for layout tests on EFL port. * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._driver_class): * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: (XvfbDriver._start): Set DUMPRENDERTREE_TEMP and LOCAL_RESOURCE_ROOT environment variables in XvfbDriver as those are needed for TestRunner::pathToLocalResource(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=98082 Reviewed by Andreas Kling. Add the GraphicsLayer::create variant that takes a factory to all ports. * platform/graphics/GraphicsLayer.cpp: (WebCore): (WebCore::GraphicsLayer::setGraphicsLayerFactory): * platform/graphics/GraphicsLayer.h: (GraphicsLayer): Rename the GraphicsLayerFactory function typedef to GraphicsLayerFactoryCallback to avoid collisions. * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp: (WebCore::GraphicsLayer::create): (WebCore): * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayer::create): (WebCore): * platform/graphics/clutter/GraphicsLayerClutter.cpp: (WebCore::GraphicsLayer::create): (WebCore): * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create): (WebCore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed property svn:executable. * platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed property svn:executable. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=95062 Reviewed by Martin Robinson. Only increase and decrease reference count of the accessibility UI element if it actually exists. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rakuco@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98152 Reviewed by Laszlo Gombos. This is the first step towards getting rid of the multiple, almost identical Apache httpd.conf files we have in the tree. Before anything else, remove the default comments from them to reduce the diff in later commits. * http/conf/apache2-debian-httpd.conf: * http/conf/apache2-httpd.conf: * http/conf/apache2-msys-httpd.conf: * http/conf/cygwin-httpd.conf: * http/conf/fedora-httpd.conf: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
and computeStatistics should report variance as 0 in such cases. * resources/runner.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=97919 Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-02 Reviewed by James Robinson. Add two new members |numImplThreadScrolls| and |numMainThreadScrolls| to track the total number of times we have impl-thread scrolled and main-thread scrolled, respectively. * chromium/public/WebRenderingStats.h: (WebRenderingStats): (WebKit::WebRenderingStats::WebRenderingStats): (WebKit::WebRenderingStats::enumerateFields): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98119 Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-02 Reviewed by Adam Barth. Some basic support for mountainlion has already been committed but it failed to refer to the chromium TestExpectations. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: (ChromiumPortTestCase.test_all_test_configurations): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vangelis@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=98111 It's not needed and makes the renderer synchronously wait for a glFinish to happen in the gpu process. Reviewed by James Robinson. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=97184 Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-02 Reviewed by Dimitri Glazkov. Source/WebCore: To quickly know whether some shadow dom subtree has any shadow element or not, added hasShadowRootInsertionPoint, registerShadowElement and unregisterShadowElement to class ShadowRoot. The register method or unregister method is used when a shadow element is inserted into document or removed from document. hasShadowInsertionPoint returns true if any shadow element is still registered with the given shadow root. Otherwise returns false. To test hasShadowInsertionPoint, added hasShadowInsertionPoint to Internals. Test: fast/dom/shadow/has-shadow-insertion-point.html * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): Initializes number of shadow elements. * dom/ShadowRoot.h: (WebCore::ShadowRoot::registerShadowElement): Increases number of shadow elements in shadow dom subtree by 1. (WebCore::ShadowRoot::unregisterShadowElement): Decreases number of shadow elements in shadow dom subtree by 1. (WebCore::ShadowRoot::hasShadowInsertionPoint): If number of shadow elements in shadow dom subtree is not equal to 0, returns true. Otherwise, returns false. * html/shadow/HTMLShadowElement.cpp: (WebCore::HTMLShadowElement::HTMLShadowElement): (WebCore::HTMLShadowElement::insertedInto): If a shadow element is inserted into document, register the shadow element with its shadow root. (WebCore::HTMLShadowElement::removedFrom): If a shadow element is removed from document, unregister the shadow element with its shadow root. * html/shadow/HTMLShadowElement.h: Added a new member variable which has information about whether this shadow element has been already registered with its shadow root or not. * testing/Internals.cpp: (WebCore::Internals::hasShadowInsertionPoint): Added a new testing method which returns whether the given shadow root has any shadow element or not. * testing/Internals.h: (Internals): * testing/Internals.idl: LayoutTests: * fast/dom/shadow/has-shadow-insertion-point-expected.txt: Added. * fast/dom/shadow/has-shadow-insertion-point.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rakuco@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98155 Reviewed by Eric Seidel. No test currently uses this port, and the lighttpd configuration does not open it. This helps the efforts of bringing some consistency to the Apache configuration at the moment by opening the same ports in the webkitpy side and in the httpd.conf side (the idea is to remove the httpd.conf side later), and also makes the behavior consistent across the two servers we currently support. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=94925 Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02 Reviewed by Gyuyoung Kim. Change is related to modifications in wk1 unit tests. * PlatformEfl.cmake: Source/WebKit/efl: [EFL][UT] Refactoring an implementation of testing framework for wk1. https://bugs.webkit.org/show_bug.cgi?id=94925 Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02 Reviewed by Gyuyoung Kim. The reason of changing, was to adjust current implementation to use gtest features related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods and lastly to make framework easier to use. * tests/UnitTestUtils/EWKTestBase.cpp: (EWKUnitTests::EWKTestBase::EWKTestBase): (EWKUnitTests::EWKTestBase::webView): Returns current webview. (EWKUnitTests::EWKTestBase::SetUp): Before test is started, SetUp is called. Used this to initialize test view. (EWKUnitTests::EWKTestBase::onLoadFinished): (EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded. (EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page. * tests/UnitTestUtils/EWKTestBase.h: * tests/UnitTestUtils/EWKTestEnvironment.cpp: Used to have global SetUp and TearDown. Global SetUp starts initialization of webkit wherease global TearDown shuts it down. Generally we would like to have only one initialization of webkit while tests are executed. (EWKUnitTests): (EWKUnitTests::EWKTestEnvironment::EWKTestEnvironment): (EWKUnitTests::EWKTestEnvironment::SetUp): Starts initialization of webkit. (EWKUnitTests::EWKTestEnvironment::TearDown): Shuts down of webkit. * tests/UnitTestUtils/EWKTestEnvironment.h: (EWKUnitTests): (EWKTestEnvironment): (EWKUnitTests::EWKTestEnvironment::useX11Window): * tests/UnitTestUtils/EWKTestView.cpp: (EWKUnitTests::EWKTestView::EWKTestView): (EWKUnitTests::EWKTestView::init): Starts initialization of test view. * tests/UnitTestUtils/EWKTestView.h: (EWKTestView): * tests/test_ewk_view.cpp: adjusted current unit tests to new implementation. (TEST_F): * tests/test_runner.cpp: entry point of all tests. (parseCustomArguments): (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
http://trac.webkit.org/changeset/130167 http://trac.webkit.org/changeset/130171 https://bugs.webkit.org/show_bug.cgi?id=98165 Breaks test (Requested by vsevik on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02 * http/tests/inspector/debugger-test.js: (initialize_DebuggerTest): * platform/qt/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
michael.bruning@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=98136 Unreviewed gardening. WebInspectorProxy::platformCreateInspectorPage() is not implemented for the Qt 5.0 WK2 port. * platform/qt-5.0-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=98161 Reviewed by Pavel Feldman. Content scripts should be also added by NetworkUISourceCodeProvider. This patch fixes that. * inspector/front-end/NetworkUISourceCodeProvider.js: (WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hugo.lima@openbossa.org authored
https://bugs.webkit.org/show_bug.cgi?id=98070 Reviewed by Kenneth Rohde Christiansen. This patch just add forward declarations for code correctness. * UIProcess/PageViewportControllerClient.h: (WebCore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=98045 Reviewed by Simon Hausmann. The test needs to show the window and wait for the loadVisuallyCommitted() signal like did in the QML API auto tests. * UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: (tst_QQuickWebView::scrollRequest): * UIProcess/API/qt/tests/util.cpp: (waitForViewportReady): * UIProcess/API/qt/tests/util.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
* http/tests/inspector/debugger-test.js: (initialize_DebuggerTest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98142 Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-02 Reviewed by Laszlo Gombos. Using EXPECT_EQ(true/false, ...) makes clang trip when it tries to convert true/false to a pointer. Tests should use EXPECT_TRUE/FALSE instead. * UIProcess/API/efl/tests/test_ewk2_view.cpp: (showPopupMenu): (TEST_F): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=97883 Reviewed by Andreas Kling. Use SimpleFontData::avgCharWidth() instead to remove duplicated code. * platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontData::create): * platform/graphics/wince/FontPlatformData.h: (FontPlatformData): * platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
* platform/chromium-win/inspector/console/command-line-api-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96862 Reviewed by Simon Hausmann. Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
* inspector/console/command-line-api-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
* platform/chromium-win/inspector/console/command-line-api-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
schenney@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=95866 Reviewed by Eric Seidel. Re-commit for a rolled-out original, now with Chromium Windows build fix. This patch makes all FontData and derived classes ref-counted in all code paths that lead to caching or other retention of a pointer. The goal is to avert crashes and memory leaks, and to bring the code more in line with current WebKit practices. Specifically, this patch allows us to use ref pointers for all the FontData stored in FontFallbackList objects. The FontFallbackList can then own custom font data and manage its lifetime (forthcoming patch). Currently Document owns custom font data and does an end run around FontFallbackList in deleting glyph pages and custom font data, leaving FontFallbackList with invalid pointers. All FontData derived classes have been switched to use static create methods with private constructors. All caches that hold FontData now use RefPtrs. All methods that construct new font data now return PassRefPtr, with the exception of code only used to generate temporary data for text run layout. All methods that handle FontData in a call stack that passes through FontFallbackList::fontDataAt return PassRefPtr. Performance tested with both WebKit Perf-o-matic, which showed performance changes in the noise, and Chrome's page cycling tests with the acid3 benchmark set, which showed no performance difference at all. No new tests as this is refactoring code only and has no impact on functionality. * css/CSSFontFace.cpp: (WebCore::CSSFontFace::getFontData): * css/CSSFontFace.h: (CSSFontFace): * css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): * css/CSSFontFaceSource.h: (CSSFontFaceSource): * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): (WebCore::CSSFontSelector::getFontData): * css/CSSFontSelector.h: * css/CSSSegmentedFontFace.cpp: (WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading): (WebCore::CSSSegmentedFontFace::getFontData): * css/CSSSegmentedFontFace.h: (CSSSegmentedFontFace): * dom/Document.cpp: (WebCore::Document::registerCustomFont): * dom/Document.h: (Document): * platform/graphics/Font.h: (WebCore): * platform/graphics/FontCache.cpp: (WebCore): (WebCore::FontCache::getCachedFontData): (WebCore::FontCache::getNonRetainedLastResortFallbackFont): (WebCore::FontCache::releaseFontData): (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::getFontData): * platform/graphics/FontCache.h: (FontCache): * platform/graphics/FontData.h: * platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::setPlatformFont): * platform/graphics/FontFallbackList.h: (FontFallbackList): * platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataAndPageForCharacter): * platform/graphics/FontSelector.h: (FontSelector): * platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): * platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::fontDataForCharacter): * platform/graphics/SegmentedFontData.h: (WebCore::FontDataRange::FontDataRange): (WebCore::FontDataRange::fontData): (FontDataRange): (WebCore::SegmentedFontData::create): (SegmentedFontData): (WebCore::SegmentedFontData::SegmentedFontData): * platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::verticalRightOrientationFontData): (WebCore::SimpleFontData::uprightOrientationFontData): (WebCore::SimpleFontData::brokenIdeographFontData): * platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::create): (SimpleFontData): (WebCore::SimpleFontData::variantFontData): (DerivedFontData): * platform/graphics/chromium/FontCacheAndroid.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (GetLastResortFallbackFontProcData): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): * platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/mac/FontComplexTextMac.cpp: (WebCore::Font::fontDataForCombiningCharacterSequence): * platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/pango/FontCachePango.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/skia/SimpleFontDataSkia.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/wince/FontCacheWinCE.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): * platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): * platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::createScaledFontData): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::emphasisMarkFontData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98148 Patch by Adrian Perez de Castro <aperez@igalia.com> on 2012-10-02 Reviewed by Xan Lopez. With geolocation disabled in the build, return a sensible value from DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests. This also avoids a compiler warning. * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=98137 Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-02 Reviewed by Kentaro Hara. Source/WebCore: According to the XMLHttpRequest specification, overrideMimeType(mime) sets the "Content-Type" header for the response to mime. However, with the current implementation, calling overrideMimeType(mime) does not affect the value returned by client.getResponseHeader("Content-Type"). This patch makes sure the response's "Content-Type" header is properly updated with the override MIME type. Test: http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveResponse): LayoutTests: Add layout test to check that calling overrideMimeType(mime) properly sets the response's "Content-Type" header to mime. * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header-expected.txt: Added. * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Remove entry for bidi-layout-across-linebreak.html, reinstated meter-optimiums.html as flaky on Mac. * platform/chromium/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=98145 * inspector/debugger/script-snippet-model.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=97680 Reviewed by Pavel Feldman. Source/WebCore: UISourceCodes for scripts having sourceURL are now created by NetworkUISourceCodeProvider. UISourceCodes for anonymous, dynamic and concatenated scripts are now created on demand only. All UISourceCodes created by ResourceScriptMapping are now "temporary". Temporary UISourceCodes are not stored in workspace and removed when a normal UISourceCode with the same url is available. UISourceCodeReplaced event was replaced with TemporaryUISourceCodeAdded/Removed events. * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved): (WebInspector.BreakpointManager.Breakpoint.prototype.remove): * inspector/front-end/NavigatorView.js: * inspector/front-end/NetworkUISourceCodeProvider.js: (WebInspector.NetworkUISourceCodeProvider): (WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource): * inspector/front-end/ResourceScriptMapping.js: (WebInspector.ResourceScriptMapping): (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation): (WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript): (WebInspector.ResourceScriptMapping.prototype.uiLocationToRawLocation): (WebInspector.ResourceScriptMapping.prototype.addScript): (WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts): (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts): (WebInspector.ResourceScriptMapping.prototype._isDynamicScript): (WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace): (WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode): (WebInspector.ResourceScriptMapping.prototype._reset): * inspector/front-end/RevisionHistoryView.js: (WebInspector.RevisionHistoryView): * inspector/front-end/ScriptsNavigator.js: * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): * inspector/front-end/TabbedEditorContainer.js: (WebInspector.TabbedEditorContainer.prototype.removeUISourceCode.get if): (WebInspector.TabbedEditorContainer.prototype.removeUISourceCode): * inspector/front-end/UISourceCode.js: * inspector/front-end/Workspace.js: (WebInspector.Project.prototype.addTemporaryUISourceCode): (WebInspector.Project.prototype.removeTemporaryUISourceCode): LayoutTests: * http/tests/inspector/workspace-test.js: (initialize_WorkspaceTest.InspectorTest.createWorkspace): (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent.temporaryUISourceCodeAdded): (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent): (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent.temporaryUISourceCodeRemoved): (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent): * inspector/debugger/breakpoint-manager-expected.txt: * inspector/debugger/breakpoint-manager.html: * inspector/debugger/dynamic-script-tag-expected.txt: * inspector/debugger/resource-script-mapping.html: * inspector/debugger/scripts-panel-expected.txt: * inspector/debugger/scripts-panel.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-