- 13 Jun, 2013 20 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=117578. Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-13 Reviewed by Darin Adler. ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent even though 'onaudioprocess' listener is not set. This results in unwanted thread hops. Code is optimized to dispatch AudioProcessingEvent only if the listener is set. No new tests, already covered by existing tests. * Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::ScriptProcessorNode): (WebCore::ScriptProcessorNode::process): (WebCore::ScriptProcessorNode::setOnaudioprocess): * Modules/webaudio/ScriptProcessorNode.h: (WebCore::ScriptProcessorNode::onaudioprocess): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=109629 Reviewed by Mark Rowe. * WebKit.vcxproj/WebKit/WebKit.vcxproj: Add generated file. * WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=117586 Reviewed by Brent Fulgham. From Blink r152243 by <abarth@chromium.org> Current String::fromUTF8() implementation converts 8 bit ASCII character into 16 bit. Instead of always trying to convert into a 16 bit buffer, we can add a call to charactersAreAllASCII. In the common case when characters are ASCII, we directly copy it into an 8 bit string buffer. * wtf/text/WTFString.cpp: (WTF::String::fromUTF8): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mvujovic@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=117566 Reviewed by Alexandru Chiculita. Source/WebCore: This patch enables -webkit-background-clip: text; on regions. Test: fast/regions/webkit-background-clip-text.html * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::paintFlowThreadPortionInRegion): Force black text if we're in the text clip paint phase. This makes sure the text's alpha channel does not affect the final opacity of the background clipping result. Rather, the text's alpha channel affects the amount of blending between the text color and the background. * rendering/RenderRegion.cpp: (WebCore::shouldPaintRegionContentsInPhase): Factor out a function to check if we should paint the region contents in a particular phase. Add "PaintPhaseTextClip" so that we draw the contents in the text clipping phase. (WebCore::RenderRegion::paintObject): Call shouldPaintRegionContentsInPhase instead of doing the phase checks directly in this function. Move, update, and clarify the surrounding comments. LayoutTests: * fast/regions/webkit-background-clip-text-expected.html: Added. * fast/regions/webkit-background-clip-text.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=111092 Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-06-13 Reviewed by David Hyatt. During last layout that should update the auto-height regions new auto-height region height is calculated correctly based on the text content, but it requires extra step to reposition the render block after new logical height is set (correct logical height becomes available only during last layout). Tests: fast/regions/autoheight-abspos-bottom-align.html * rendering/RenderRegion.cpp: (WebCore::RenderRegion::updateLogicalHeight): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=117598 Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-13 Reviewed by Martin Robinson. * Source/autotools/symbols.filter: Added missing _ZN7WebCore28notImplementedLoggingChannelEv. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing symbols needed by TestWebKitAPI on WinCairo build. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* WebCore.vcxproj/WebCoreCairo.props: Use proper WebKit_Libraries environment variable, rather than older WebKitLibraries. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=117593 Reviewed by Geoffrey Garen. Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by calling asInt32() / asUInt32() instead of toInt32() / toUInt32() when we already know the value is a int32 / uint32. No new tests, no behavior change. * bindings/js/JSDOMBinding.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=116994 Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-13 Reviewed by Simon Fraser. Source/WebCore: Since a container which has overflow clip of RenderBox which has self painting layer doesn't have a rect of the RenderBox as visual overflow, the container should not clip request repainting rect of the RenderBox. Test: fast/repaint/change-overflow-and-display-of-relative.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint): * rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::shouldUseClipForRepaint): If this has self painting layer, we should not clip for repaint. * rendering/RenderLayerModelObject.h: LayoutTests: * fast/repaint/change-overflow-and-display-of-relative-expected.txt: Added. * fast/repaint/change-overflow-and-display-of-relative.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
First, allow the layers behind opaque gradients to be drawn, then add the blending filters when working with gradients. Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=117532 Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13 Reviewed by Dirk Schulze. Tests: css3/compositing/background-blend-mode-gradient-color.html css3/compositing/background-blend-mode-gradient-gradient.html css3/compositing/background-blend-mode-gradient-image.html css3/compositing/background-blend-mode-multiple-background-layers.html * platform/graphics/GeneratorGeneratedImage.cpp: (WebCore::GeneratorGeneratedImage::draw): * rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=117532 Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13 Reviewed by Dirk Schulze. * css3/compositing/background-blend-mode-gradient-color-expected.txt: Added. * css3/compositing/background-blend-mode-gradient-color.html: Added. * css3/compositing/background-blend-mode-gradient-gradient-expected.txt: Added. * css3/compositing/background-blend-mode-gradient-gradient.html: Added. * css3/compositing/background-blend-mode-gradient-image-expected.txt: Added. * css3/compositing/background-blend-mode-gradient-image.html: Added. * css3/compositing/background-blend-mode-multiple-background-layers-expected.txt: Added. * css3/compositing/background-blend-mode-multiple-background-layers.html: Added. * platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png: Added. * platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png: Added. * platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png: Added. * platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
michael.bruning@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=117591 Reviewed by Tor Arne Vestbø. Source/WebCore: Deployment of the same Qt binaries to different Mac OS X version makes it impossible to link against the correct WebKitSystemInterface version at build time. No new tests, no behavioural change. * WebCore.pri: Tools: Deployment of Qt binaries to different Mac OS X platform version makes it impossible to link against the correct version of the WebKitSystemInterface library, so we need to disable QTKit for media elements. * qmake/mkspecs/features/features.prf: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=116033 Source/WebCore: Start by setting the column height to the flow thread's height divided by the number of columns. Then stretch the column height until contents fits without creating overflowing columns, or until the maximum allowed column height is reached, whichever comes first. This may require several layout iterations (but normally only a couple). For each time we stretch, stretch by the least amount required to make a difference to which box goes where. Also make sure that the columns get tall enough to honor orphans and widows settings. This change takes some tiny steps in preparing for multiple column set support. There is also some minor cleanup and bugfixing; see details below. Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13 Reviewed by David Hyatt. Tests: fast/multicol/newmulticol/balance-images.html fast/multicol/newmulticol/balance-maxheight1.html fast/multicol/newmulticol/balance-maxheight2.html fast/multicol/newmulticol/balance1.html fast/multicol/newmulticol/balance2.html fast/multicol/newmulticol/balance3.html fast/multicol/newmulticol/balance4.html fast/multicol/newmulticol/balance5.html fast/multicol/newmulticol/balance6.html fast/multicol/newmulticol/balance7.html fast/multicol/newmulticol/balance8.html fast/multicol/newmulticol/balance9.html fast/multicol/newmulticol/cell-shrinkback.html fast/multicol/newmulticol/columns-shorthand-parsing.html fast/multicol/newmulticol/orphans-and-widows-balance.html fast/multicol/newmulticol/single-line.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustForUnsplittableChild): (WebCore::RenderBlock::setPageBreak): (WebCore): (WebCore::RenderBlock::updateMinimumPageHeight): (WebCore::calculateMinimumPageHeight): (WebCore::RenderBlock::adjustLinePositionForPagination): (WebCore::RenderBlock::adjustBlockChildForPagination): If no lines cross the boundaries, we need to report where blocks cross instead, so that the column balancer knows how much to stretch columns if necessary. * rendering/RenderBlock.h: * rendering/RenderFlowThread.h: * rendering/RenderMultiColumnBlock.cpp: (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock): (WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange): (WebCore::RenderMultiColumnBlock::relayoutForPagination): (WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild): * rendering/RenderMultiColumnBlock.h: (WebCore::RenderMultiColumnBlock::columnHeightAvailable): (WebCore::RenderMultiColumnBlock::requiresBalancing): (RenderMultiColumnBlock): * rendering/RenderMultiColumnFlowThread.cpp: (WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset): (WebCore::RenderMultiColumnFlowThread::setPageBreak): (WebCore): (WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight): * rendering/RenderMultiColumnFlowThread.h: (RenderMultiColumnFlowThread): * rendering/RenderMultiColumnSet.cpp: Get rid of RenderMultiColumnSet::updateLogicalHeight() override. Make RenderMultiColumnSet behave more like normal blocks, by having computeLogicalHeight() calculate logical top in addition to height, just like any other block. (WebCore::RenderMultiColumnSet::RenderMultiColumnSet): (WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset): This method will become more meaningful once we add support for multiple column sets. (WebCore): (WebCore::RenderMultiColumnSet::pageLogicalTopForOffset): (WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight): (WebCore::RenderMultiColumnSet::calculateBalancedHeight): (WebCore::RenderMultiColumnSet::recordSpaceShortage): (WebCore::RenderMultiColumnSet::updateLogicalWidth): (WebCore::RenderMultiColumnSet::prepareForLayout): (WebCore::RenderMultiColumnSet::computeLogicalHeight): (WebCore::RenderMultiColumnSet::columnCount): (WebCore::RenderMultiColumnSet::columnIndexAtOffset): repaintFlowThreadContent() could end up in an infinite loop because columnIndexAtOffset() could return UINT_MAX (subtracting 1 from unsigned 0, which columnCount() could return), which an unsigned integer obviously can never become larger than. Also always call columnIndexAtOffset() if we want to get the column index for some offset, rather than doing it on our own sometimes. To make this work also during layout, we cannot just return the last column created so far if we're past it, since adding new columns is exactly what we want to do at this point. * rendering/RenderMultiColumnSet.h: (RenderMultiColumnSet): LayoutTests: Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13 Reviewed by David Hyatt. * fast/multicol/newmulticol/balance-images-expected.txt: Added. * fast/multicol/newmulticol/balance-images.html: Added. * fast/multicol/newmulticol/balance-maxheight1-expected.txt: Added. * fast/multicol/newmulticol/balance-maxheight1.html: Added. * fast/multicol/newmulticol/balance-maxheight2-expected.txt: Added. * fast/multicol/newmulticol/balance-maxheight2.html: Added. * fast/multicol/newmulticol/balance1-expected.txt: Added. * fast/multicol/newmulticol/balance1.html: Added. * fast/multicol/newmulticol/balance2-expected.txt: Added. * fast/multicol/newmulticol/balance2.html: Added. * fast/multicol/newmulticol/balance3-expected.txt: Added. * fast/multicol/newmulticol/balance3.html: Added. * fast/multicol/newmulticol/balance4-expected.txt: Added. * fast/multicol/newmulticol/balance4.html: Added. * fast/multicol/newmulticol/balance5-expected.txt: Added. * fast/multicol/newmulticol/balance5.html: Added. * fast/multicol/newmulticol/balance6-expected.txt: Added. * fast/multicol/newmulticol/balance6.html: Added. * fast/multicol/newmulticol/balance7-expected.txt: Added. * fast/multicol/newmulticol/balance7.html: Added. * fast/multicol/newmulticol/balance8-expected.txt: Added. * fast/multicol/newmulticol/balance8.html: Added. * fast/multicol/newmulticol/balance9-expected.txt: Added. * fast/multicol/newmulticol/balance9.html: Added. * fast/multicol/newmulticol/cell-shrinkback-expected.html: Added. * fast/multicol/newmulticol/cell-shrinkback.html: Added. * fast/multicol/newmulticol/columns-shorthand-parsing-expected.html: Added. * fast/multicol/newmulticol/columns-shorthand-parsing.html: Added. * fast/multicol/newmulticol/orphans-and-widows-balance-expected.txt: Added. * fast/multicol/newmulticol/orphans-and-widows-balance.html: Added. * fast/multicol/newmulticol/single-line-expected.html: Added. * fast/multicol/newmulticol/single-line.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zarvai@inf.u-szeged.hu authored
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-13 * platform/qt-5.0-wk2/TestExpectations: * platform/qt/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt-arm/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Adding failure expectations for most of the current failures. * platform/gtk-wk1/TestExpectations: * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=116610 Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-13 Reviewed by Noam Rosenthal. Source/WebKit2: WebKit2 EFL uses fixed layout - because of this ScrollView::contentsToWindow, does not take scroll into account, as it is meant to be handled by UI application. When popup and context menu are created, after calling contentsToWindow their position are not adjusted to page scroll. Added two functions to EwkView and WKView, converting contents position to user viewport coordinates, to adjust popup and context menu positions. * UIProcess/API/C/CoordinatedGraphics/WKView.cpp: (WKViewContentsToUserViewport): * UIProcess/API/C/CoordinatedGraphics/WKView.h: * UIProcess/API/efl/EwkView.cpp: (EwkView::showContextMenu): (EwkView::requestPopupMenu): * UIProcess/CoordinatedGraphics/WebView.cpp: (WebKit::WebView::contentsToUserViewport): * UIProcess/CoordinatedGraphics/WebView.h: Tools: Remove unnecessary code adjusting context menu position to webview position. Now position is calculcated in EwkView. * MiniBrowser/efl/main.c: (on_context_menu_show): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=115713 Reviewed by Gyuyoung Kim. After removed c-ism from WebKit/Efl, There is no reason to keep internal structures like Ewk_Scroll_Request. This patch refactored ewk_view_scroll to use WTF instead of Ewk_Scroll_Request and scrolls of SmartData. * WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::scroll): * ewk/ewk_view.cpp: Removed functions to manage Ewk_Scroll_Request. (_Ewk_View_Private_Data): (_ewk_view_scrolls_flush): (_ewk_view_priv_del): (_ewk_view_smart_calculate): (ewk_view_scroll_offsets_get): (ewk_view_scroll_rects_get): (ewk_view_scroll): * ewk/ewk_view.h: Removed Ewk_Scroll_Request which is private structure. * ewk/ewk_view_private.h: (WebCore): * ewk/ewk_view_single.cpp: (_ewk_view_single_scroll_process_single): (_ewk_view_single_smart_scrolls_process): * ewk/ewk_view_tiled.cpp: (_ewk_view_tiled_smart_scrolls_process): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
lforschler@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt-arm/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Jun, 2013 20 commits
-
-
bfulgham@apple.com authored
* win/tools32/vsprops/WinCairo.props: Switch from using the $WebKitLibraries environment variable to the newer $WebKit_Libraries. * win/tools32/vsprops/debug_wincairo.props: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
* Scripts/webkitpy/common/config/ews.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117563. Reviewed by Brent Fulgham. * building/build.html: * building/debug.html: * building/launch-debugger-vs2005.png: Removed. * building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png. * building/set-as-startup-project-vs2005.png: Removed. * building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png. * building/set-debugging-properties-vs2005.png: Removed. * building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png. * building/tools.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
* platform/efl-wk1/TestExpectations: * platform/efl/TestExpectations: * platform/efl/editing/selection/3690703-2-expected.png: Added. * platform/efl/editing/selection/3690703-2-expected.txt: Added. * platform/efl/editing/selection/3690703-expected.png: Added. * platform/efl/editing/selection/3690703-expected.txt: Added. * platform/efl/editing/selection/3690719-expected.png: Added. * platform/efl/editing/selection/3690719-expected.txt: Added. * platform/efl/editing/selection/4397952-expected.png: Added. * platform/efl/editing/selection/4397952-expected.txt: Added. * platform/efl/editing/selection/4895428-3-expected.png: Added. * platform/efl/editing/selection/4895428-3-expected.txt: Added. * platform/efl/editing/selection/4975120-expected.png: Added. * platform/efl/editing/selection/4975120-expected.txt: Added. * platform/efl/editing/selection/5007143-2-expected.png: Added. * platform/efl/editing/selection/5007143-2-expected.txt: Added. * platform/efl/editing/selection/5007143-expected.png: Added. * platform/efl/editing/selection/5007143-expected.txt: Added. * platform/efl/editing/selection/5057506-expected.png: Added. * platform/efl/editing/selection/5057506-expected.txt: Added. * platform/efl/editing/selection/5195166-1-expected.txt: Added. * platform/efl/editing/selection/7152-2-expected.png: Added. * platform/efl/editing/selection/7152-2-expected.txt: Added. * platform/efl/editing/selection/caret-before-select-expected.png: Added. * platform/efl/editing/selection/caret-before-select-expected.txt: Added. * platform/efl/editing/selection/caret-ltr-right-expected.png: Added. * platform/efl/editing/selection/caret-ltr-right-expected.txt: Added. * platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added. * platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added. * platform/efl/editing/selection/caret-rtl-right-expected.png: Added. * platform/efl/editing/selection/caret-rtl-right-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117572 Reviewed by Mark Rowe. * config.ini: Remove Chromium blog from planet.webkit.org git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117569 Reviewed by Anders Carlsson. * wtf/Compiler.h: Turn on rvalue references and static_assert when compiling with VS2010 (or newer) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117570 <rdar://problem/13484213> Reviewed by Tim Horton. Source/WebCore: Remove RenderEmbeddedObject::PluginInactive and the replacement text. * English.lproj/Localizable.strings: * platform/LocalizedStrings.cpp: * platform/LocalizedStrings.h: * rendering/RenderEmbeddedObject.cpp: (WebCore::unavailablePluginReplacementText): * rendering/RenderEmbeddedObject.h: Source/WebKit/mac: Remove code that deals with inactive plug-ins. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): (WebChromeClient::unavailablePluginButtonClicked): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Source/WebKit2: Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now. * Shared/Plugins/PluginModuleInfo.h: * UIProcess/API/C/WKAPICast.h: (WebKit::toWKPluginLoadPolicy): (WebKit::toPluginModuleLoadPolicy): * UIProcess/Plugins/PluginInfoStore.cpp: * UIProcess/Plugins/PluginInfoStore.h: * UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::shouldUsePlugin): (WebKit::PluginInfoStore::defaultLoadPolicyForPlugin): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::findPlugin): (WebKit::WebPageProxy::unavailablePluginButtonClicked): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton): (WebKit::WebChromeClient::unavailablePluginButtonClicked): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117561 Reviewed by Anders Carlsson. Source/WebKit: * WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files. * WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto. * WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder. * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols. * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto. Source/WebKit/win: * AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue method with get_attribute from IAccessible2 API. * AccessibleBase.h: Ditto. * AccessibleDocument.cpp: Revise signatures for IAccessible2. * AccessibleDocument.h: Ditto. * AccessibleImage.cpp: Revise signatures for IAccessible2. * AccessibleImage.h: Ditto. * Interfaces/Accessible2: Added. * Interfaces/Accessible2/Accessible2.idl: Added. * Interfaces/Accessible2/Accessible2_2.idl: Added. * Interfaces...
-
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117568 Reviewed by Alexey Proskuryakov. Change default font on newer versions of OS X. * page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC' on 10.9 and above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hugo.lima@openbossa.org authored
https://bugs.webkit.org/show_bug.cgi?id=117564 Reviewed by Martin Robinson. * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=117567 Reviewed by Alexey Proskuryakov. Change default font on newer versions of OS X. * page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC' instead of 'STSong' on newer systems. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=117541 Reviewed by Andreas Kling. From Blink r152268 by <pdr@chromium.org> A crash can happen due to a failed ImageBuffer allocation in SVGImage::drawPatternForContainer(). Added a check for that failed allocation. * svg/graphics/SVGImage.cpp: (WebCore::SVGImage::drawPatternForContainer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=115647 Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12 Reviewed by Martin Robinson. Source/WebCore: Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal AtkObject, to include custom implementations for AtkDocument and AtkText objects, taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's AccessibilityUIElementAtk::language(), respectively. Apart from improving encapsulation, this avoids calling deprecated get_document_locale() method. No new functionality, no new tests. * accessibility/atk/WebKitAccessibleInterfaceDocument.cpp: (webkitAccessibleDocumentInterfaceInit): Chains implementation of AtkDocument::get_document_locale() to AtkObject::get_object_locale(). * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (webkitAccessibleGetObjectLocale): Add implementation of locale resolution for objects of type AtkDocument and AtkText. (webkitAccessibleClassInit): Override AtkObject::get_object_locale() method. Tools: Locale resolution is moved to WebKitAccessibleWrapperAtk using AtkObject::get_object_locale() API. Now, implementation of AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can be leveraged to get_object_locale() of AtkObject. Apart from improving encapsulation, this avoids calling deprecated get_document_locale() method. No new functionality, no new tests. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::language): Leverage locale resolution to AtkObject::get_object_locale(). * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::language): Leverage locale resolution to AtkObject::get_object_locale(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hugo.lima@openbossa.org authored
https://bugs.webkit.org/show_bug.cgi?id=117557 Reviewed by Ryosuke Niwa. * Scripts/build-webkit: * Scripts/update-webkit: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=115936 Reviewed by Martin Robinson. Source/Platform: * GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies' CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk CPPFLAGS. Source/WebCore: No new tests - no new functionality. * GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing. These build targets represent source files that are already free of platform layer violations and are as such ready to be pushed down from the WebCore layer into the Platform layer. Source/WebKit2: * GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hugo.lima@openbossa.org authored
https://bugs.webkit.org/show_bug.cgi?id=117558 Reviewed by Ryosuke Niwa. This script isn't used since the GYP removal from WebKit. * Scripts/make-gypi: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=117556 Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12 Reviewed by Beth Dakin. Source/WebCore: No new tests needed. * WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method. Source/WebKit2: Adds method mediaIsInFullscreen() that checks if a media element is in fullscreen mode, which is needed to decide when to display the "Open Video in New Window" context menu item. * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp: (WKBundleHitTestResultMediaIsInFullscreen): Added. Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method. * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h: * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: (WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added. Checks if media element is in fullscreen. * WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=117496 Reviewed by Chris Fleizach. Source/WebCore: We can't make such an assumption. Scripts can insert any element between area and map elements. Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f. Test: accessibility/image-map-with-indirect-area-crash.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): LayoutTests: Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f. * accessibility/image-map-with-indirect-area-crash-expected.txt: Added. * accessibility/image-map-with-indirect-area-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't https://bugs.webkit.org/show_bug.cgi?id=117370 Reviewed by David Hyatt. Test: fast/text/whitespace/inline-whitespace-wrapping-8.html A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line. Likewise when we finish iterating through the objects on a line we should clear our linebreak if the only thing that prevents us fitting on the line is our collapsed trailing whitespace. Removing the trailing space from this measurement means we need to watch out for potential breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces and enter an autowrap inline then we need to mark the beginning of the autowrap inline as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html is an example of such a case. * rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::LineWidth): (WebCore::LineWidth::fitsOnLine): (WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace): (WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace): (WebCore::LineWidth::setTrailingWhitespaceWidth): (WebCore::RenderBlock::LineBreaker::nextSegmentBreak): LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly https://bugs.webkit.org/show_bug.cgi?id=117370 Reviewed by David Hyatt. * fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added. * fast/text/whitespace/inline-whitespace-wrapping-8.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=116745 Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-12 Reviewed by Dirk Schulze. Source/WebCore: If ry is not supplied, it now defaults to the rx value. Also, if rx and ry are not supplied, they default to 0px. This also has the effect that the computed style for any rectangle or inset-rectangle now contains all six parameters. If rx > width/2 then it is clamped to width/2, and if ry > height/2, then it is clamped to height/2. This happens at layout time because given mixed units and relative units, that is the only time this determination can be made. Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html * css/BasicShapeFunctions.cpp: (WebCore::valueForBasicShape): Remove checks for undefined, since rx and ry cannot be undefined in BasicShape...
-