1. 16 Jul, 2009 40 commits
    • abarth@webkit.org's avatar
      2009-07-16 Maxime Simon <simon.maxime@gmail.com> · c459ecc2
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added Haiku-specific files for WebCore/page/.
              https://bugs.webkit.org/show_bug.cgi?id=26949
      
              Adding three new files, DragControllerHaiku.cpp, EventHandlerHaiku.cpp
              and FrameHaiku.cpp
      
              * page/haiku/DragControllerHaiku.cpp: Added.
              (WebCore::DragController::isCopyKeyDown):
              (WebCore::DragController::dragOperation):
              (WebCore::DragController::maxDragImageSize):
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/haiku/EventHandlerHaiku.cpp: Added.
              (WebCore::isKeyboardOptionTab):
              (WebCore::EventHandler::invertSenseOfTabsToLinks):
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::focusDocumentView):
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              (WebCore::EventHandler::passMouseDownEventToWidget):
              (WebCore::EventHandler::eventActivatedView):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              (WebCore::EventHandler::passWheelEventToWidget):
              (WebCore::EventHandler::createDraggingClipboard):
              (WebCore::EventHandler::passMousePressEventToSubframe):
              (WebCore::EventHandler::passMouseMoveEventToSubframe):
              (WebCore::EventHandler::passMouseReleaseEventToSubframe):
              (WebCore::EventHandler::accessKeyModifiers):
              * page/haiku/FrameHaiku.cpp: Added.
              (WebCore::Frame::dragImageForSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c459ecc2
    • abarth@webkit.org's avatar
      2009-07-16 Maxime Simon <simon.maxime@gmail.com> · c2dae2a1
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added Haiku-specific files for WebCore/editing/.
              https://bugs.webkit.org/show_bug.cgi?id=26949
      
              Adding one new file, EditorHaiku.cpp
      
              * editing/haiku/EditorHaiku.cpp: Added.
              (WebCore::Editor::newGeneralClipboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2dae2a1
    • abarth@webkit.org's avatar
      2009-07-16 Maxime Simon <simon.maxime@gmail.com> · a884a839
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added Haiku-specific files for WebCore/bindings/js/.
              https://bugs.webkit.org/show_bug.cgi?id=26949
      
              Adding a new file, ScriptControllerHaiku.cpp
      
              * bindings/js/ScriptControllerHaiku.cpp: Added.
              (WebCore::ScriptController::createScriptInstanceForWidget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a884a839
    • abarth@webkit.org's avatar
      2009-07-16 Maxime Simon <simon.maxime@gmail.com> · 8630eaa0
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added Haiku-specific files for WebCore/platform/text/.
              https://bugs.webkit.org/show_bug.cgi?id=26949
      
              Adding two new files, StringHaiku.cpp
              and TextBreakIteratorInternalICUHaiku.cpp
      
              * platform/text/haiku/StringHaiku.cpp: Added.
              (WebCore::String::String):
              (WebCore::String::operator BString):
              * platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Added.
              (WebCore::currentTextBreakLocaleID):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8630eaa0
    • abarth@webkit.org's avatar
      2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org> · 8466b2ee
      abarth@webkit.org authored
              Reviewed by Jan Alonzo.
      
              [GTK+] Update the focus handling code.
      
              Change focus-in to always call setActive(true), call
              FocusController::setFocusedFrame when no focused frame exists
              other SelectionController::setActive. This is matching Windows
              and Qt.
      
              On focus-out call FocusController::setActive(false) and
              SelectionController::setFocued(false). This is matching Windows
              and Qt as well.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_focus_in_event):
              (webkit_web_view_focus_out_event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8466b2ee
    • abarth@webkit.org's avatar
      2009-07-16 Kent Tamura <tkent@chromium.org> · ba2185d3
      abarth@webkit.org authored
              Reviewed by Eric Seidel and Adam Barth.
      
              A test for for non-multipart file upload form submission.
              This test is disabled for non-Mac platforms because of beginDragWithFiles().
              <https://bugs.webkit.org/show_bug.cgi?id=26505>
      
              * fast/forms/get-file-upload-expected.txt: Added.
              * fast/forms/get-file-upload.html: Added.
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      2009-07-16  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Sends the basename of a selected file for non-multipart form submission.
              <https://bugs.webkit.org/show_bug.cgi?id=26505>
      
              Test: fast/forms/get-file-upload.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::appendFormData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba2185d3
    • abarth@webkit.org's avatar
      2009-07-16 Adam Barth <abarth@webkit.org> · 71d7f363
      abarth@webkit.org authored
              Reviewed by David Levin.
      
              [V8] Centralize hidden property names
              https://bugs.webkit.org/show_bug.cgi?id=27359
      
              No behavior change.  Just moving these names to a central location.
              I'll move the rest of our hidden property names as I sweep though the
              bindings.
      
              * WebCore.gypi:
              * bindings/v8/V8HiddenPropertyName.cpp: Added.
              (WebCore::V8HiddenPropertyName::objectPrototype):
              (WebCore::V8HiddenPropertyName::isolatedWorld):
              * bindings/v8/V8HiddenPropertyName.h: Added.
              * bindings/v8/V8IsolatedWorld.cpp:
              (WebCore::V8IsolatedWorld::V8IsolatedWorld):
              (WebCore::V8IsolatedWorld::getEntered):
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::getHiddenObjectPrototype):
              (WebCore::V8Proxy::installHiddenObjectPrototype):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d7f363
    • barraclough@apple.com's avatar
      2009-07-16 Gavin Barraclough <barraclough@apple.com> · 1da8198c
      barraclough@apple.com authored
              RS by Oliver Hunt.
      
              Revert r45969, this fix does not appear to be valid.
              https://bugs.webkit.org/show_bug.cgi?id=27077
      
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::~CodeBlock):
              (JSC::CodeBlock::unlinkCallers):
              * jit/JIT.cpp:
              * jit/JIT.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1da8198c
    • treat@webkit.org's avatar
      2009-07-16 Adam Treat <adam.treat@torchmobile.com> · 7654928f
      treat@webkit.org authored
              Reviewed by Dave Levin.
      
              cpplint should check for one line control clauses that are surrounded
              by braces
              https://bugs.webkit.org/show_bug.cgi?id=27354
      
              * Scripts/modules/cpplint.py: Added the new lint check.
              * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check
                and fix the other tests as they were not passing this new lint check.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7654928f
    • mitz@apple.com's avatar
      WebCore: · 52608f26
      mitz@apple.com authored
              Reviewed by Simon Fraser.
      
              REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
              https://bugs.webkit.org/show_bug.cgi?id=26747
              rdar://problem/7009243
      
              Test: fast/repaint/background-misaligned.html
      
              * platform/graphics/Image.cpp:
              (WebCore::Image::drawTiled): Moved a variable definition closer to where
              it is used.
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::BitmapImage::draw): In the subimage code path, compute a
              pixel-aligned source rect, because the subiamge is always pixel-aligned
              in source space, and adjust the destination rect to preserve the
              source -> destination mapping. Clip to the (original) destination rect
              to prevent bleeding out.
      
      LayoutTests:
      
              Reviewed by Simon Fraser.
      
              REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
              https://bugs.webkit.org/show_bug.cgi?id=26747
              rdar://problem/7009243
      
              * fast/repaint/background-misaligned.html: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
              * platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
              * platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
              * platform/mac/fast/borders/border-image-rotate-transform-expected.png:
              * platform/mac/fast/repaint/background-misaligned-expected.checksum: Added.
              * platform/mac/fast/repaint/background-misaligned-expected.png: Added.
              * platform/mac/fast/repaint/background-misaligned-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52608f26
    • abarth@webkit.org's avatar
      2009-07-16 Jeremy Orlow <jorlow@chromium.org> · 9749e2be
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Add a sessionStorageEnabled setting to the settings class.
              https://bugs.webkit.org/show_bug.cgi?id=27318
      
              Allow LocalStorage to be enabled without enabling SessionStorage at
              runtime.  There is a settings class setting for localStorage, but not
              for sessionStorage.  We want to be able to test one of these features
              without necessarily enabling the other.
      
              SessionStorage defaults to true so as to not change behavior and
              because there really aren't any security concerns around SessionStorage
              (unlike LocalsStorage).  The flag is needed in Chromium only because
              we want to enable the compile time flag in the default build, but don't
              want it on by default until it's been thoroughly tested.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::sessionStorage):  Check the new flag
              (WebCore::DOMWindow::localStorage):  A bit of cleanup
              * page/Settings.cpp:
              (WebCore::Settings::Settings):  Default the flag to true
              (WebCore::Settings::setSessionStorageEnabled):  Add the new flag
              * page/Settings.h:
              (WebCore::Settings::sessionStorageEnabled):  Get the new flag
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9749e2be
    • mitz@apple.com's avatar
      ../gtk: · 1bc39583
      mitz@apple.com authored
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
              https://bugs.webkit.org/show_bug.cgi?id=24187 
      
              Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
      
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
      
      ../qt:
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
              https://bugs.webkit.org/show_bug.cgi?id=24187 
      
              Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
      
              * Api/qwebframe.cpp:
              (QWebHitTestResultPrivate::QWebHitTestResultPrivate): Add direction as a parameter to the callee of HitTestResult::title().
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bc39583
    • abarth@webkit.org's avatar
      WebCore: · f6149628
      abarth@webkit.org authored
      2009-07-16  Adam Barth  <abarth@webkit.org>
      
              Unreviewed.
      
              Revert 45987.  Tests did not pass on Windows.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::appendFormData):
      
      LayoutTests:
      
      2009-07-16  Adam Barth  <abarth@webkit.org>
      
              Unreviewed.
      
              Revert 45987.  Tests did not pass on Windows.
      
              * fast/forms/get-file-upload-expected.txt: Removed.
              * fast/forms/get-file-upload.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6149628
    • pkasting@chromium.org's avatar
      2009-07-16 Peter Kasting <pkasting@google.com> · d46b748a
      pkasting@chromium.org authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=27323
              Improve support for WebKit checkouts hosted inside other checkouts
              (possible for some ports, e.g. Chromium).
      
              * Scripts/svn-create-patch: Determine SVN root by looking for Repository
                Root string and aborting when it's missing or different than what
                we've already seen.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d46b748a
    • levin@chromium.org's avatar
      2009-07-16 Drew Wilson <atwilson@google.com> · 68314a90
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Added SHARED_WORKER flag to Windows build files, as well as associated .ccp/.h files.
              Added missing V8 bindings to the AllInOne file
      
              https://bugs.webkit.org/show_bug.cgi?id=27321
      
              * WebCore.vcproj/WebCore.vcproj:
              Added missing files to build.
              * bindings/v8/DerivedSourcesAllInOne.cpp:
              Added missing V8 bindings (V8AbstractWorker.cpp and V8SharedWorker.cpp)
              * DerivedSources.cpp
              Added missing JS bindings (JSAbstractWorker.cpp and JSSharedWorker.cpp)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68314a90
    • levin@chromium.org's avatar
      2009-07-16 John Abd-El-Malek <jam@chromium.org> · f57f42f9
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Add a getter in MessagePortChannel for the PlatformMessagePortChannel.
      
              https://bugs.webkit.org/show_bug.cgi?id=27337
      
              * dom/MessagePortChannel.h:
              (WebCore::MessagePortChannel::channel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f57f42f9
    • abarth@webkit.org's avatar
      2009-07-16 Zoltan Horvath <hzoltan@inf.u-szeged.hu> · 74f1264a
      abarth@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Allow custom memory allocation control in ExceptionInfo and RareData struct
              https://bugs.webkit.org/show_bug.cgi?id=27336
      
              Inherits ExceptionInfo and RareData struct from FastAllocBase because these
              have been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.cpp:1289 and
              in JavaScriptCore/bytecode/CodeBlock.h:453.
      
              Remove unnecessary WTF:: namespace from CodeBlock inheritance.
      
              * bytecode/CodeBlock.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74f1264a
    • pkasting@chromium.org's avatar
      Fix accidentally blowing away a ChangeLog entry, plus a spurious comment · a6577d57
      pkasting@chromium.org authored
      that no longer applied to the patch version I checked in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6577d57
    • pkasting@chromium.org's avatar
      2009-07-16 Peter Kasting <pkasting@google.com> · 7f4f6983
      pkasting@chromium.org authored
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=27323
              Improve support for non-Cygwin SVNs on Windows, as well as WebKit
              checkouts hosted inside other checkouts.
      
              * Scripts/commit-log-editor: Modify regex so that trailing whitespace
                (e.g. \r) isn't included in filenames.
              * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog
                without normalizing.  Normalize file paths early instead of late so
                all stages of the script work.  Modify regexes so that trailing
                whitespace (e.g. \r) isn't included in filenames.
              * Scripts/svn-create-patch: Use a regex instead of chomp so we cut off
                line endings even if they don't match Perl's.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f4f6983
    • abarth@webkit.org's avatar
      2009-07-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com> · 07140812
      abarth@webkit.org authored
              Reviewed by Adam Treat.
      
              Add new action to qwebpage to reload without cache.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::updateAction):
              (QWebPagePrivate::updateNavigationActions):
              (QWebPage::triggerAction):
              * Api/qwebpage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07140812
    • abarth@webkit.org's avatar
      2009-07-16 Xiaomei Ji <xji@chromium.org> · 9b343eeb
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              WARNING: NO TEST CASES ADDED OR CHANGED
      
              * WebCore.base.exp: Replace 2 names due to signature change.
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::setToolTip): Add direction as 2nd parameter.
              * page/Chrome.cpp:
              (WebCore::Chrome::setToolTip): Calculate tooltip direction as well and pass it to client to take care when display tooltip.
              * page/ChromeClient.h: Add direction as 2nd parameter to pure virtual function setToolTip().
              * page/chromium/ChromeClientChromium.h:
              (WebCore::ChromeClientChromium::setToolTip): Add setToolTip()
              temprarily to make chromium compile after pick up this webkit patch.
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::spellingToolTip): Besides getting the
              spelling tooltip, get its directionality as well.
              (WebCore::HitTestResult::title): Besides getting the title,
              get its directionality as well.
              * rendering/HitTestResult.h: Add 2 more methods.
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
              * WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              * Misc/WebElementDictionary.mm:
              (-[WebElementDictionary _spellingToolTip]): Change spellingToolTip caller due to signature change.
              (-[WebElementDictionary _title]): Change title caller due to signature change.
              * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
              * WebCoreSupport/ChromeClientQt.h: Add directionality as 2nd parameter to setToolTip().
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
              * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
              * WebElementPropertyBag.cpp:
              (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
      
      2009-07-16  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix tooltip does not get its directionality from its element's directionality.
              https://bugs.webkit.org/show_bug.cgi?id=24187
      
              Per mitz's suggestion in comment #6, while getting the plain-text
              title, we also get the directionality of the title. How to handle
              the directionality is up to clients. Clients could ignore it,
              or use attribute or unicode control characters to display the title
              as what they want.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
              * WebKitSupport/ChromeClientWx.h: Add directionality as 2nd parameter to setToolTip().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b343eeb
    • mrowe@apple.com's avatar
      Rubber-stamped by Geoff Garen. · 6904d0a9
      mrowe@apple.com authored
      Fix FeatureDefines.xcconfig to not be out of sync with the rest of the world.
      
      * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6904d0a9
    • abarth@webkit.org's avatar
      2009-07-16 Shinichiro Hamaji <hamaji@chromium.org> · d52ee1ca
      abarth@webkit.org authored
              Reviewed by Oliver Hunt.
      
              [CAIRO] pattern of a canvas-element changes after modifications on canvas-element
              https://bugs.webkit.org/show_bug.cgi?id=20578
      
              Copy pixel image in ImageBuffer::image() just like CG and Skia glue.
      
              * fast/canvas/canvas-pattern-modify-expected.txt: Added.
              * fast/canvas/canvas-pattern-modify.html: Added.
              * fast/canvas/canvas-pattern-modify.js: Added.
              (dataToArray):
              (getPixel):
              (pixelShouldBe):
              (createCanvasImage):
      
      2009-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              [CAIRO] pattern of a canvas-element changes after modifications on canvas-element
              https://bugs.webkit.org/show_bug.cgi?id=20578
      
              Copy pixel image in ImageBuffer::image() just like CG and Skia glue.
      
              Test: fast/canvas/canvas-pattern-modify.html
      
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (copySurface):
              (WebCore::ImageBuffer::image):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d52ee1ca
    • hyatt@apple.com's avatar
      WebCore: · e123d65c
      hyatt@apple.com authored
      2009-07-16  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27353
              Images mispositioned because of bug in percentage-based relative positioning.
      
              Added fast/css/nested-floating-relative-position-percentages.html
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::relativePositionOffsetX):
      
      LayoutTests:
      
      2009-07-16  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27353
              Images mispositioned because of bug in percentage-based relative positioning.
      
              * fast/css/nested-floating-relative-position-percentages.html: Added.
              * platform/mac/fast/css/nested-floating-relative-position-percentages-expected.checksum: Added.
              * platform/mac/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
              * platform/mac/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e123d65c
    • abarth@webkit.org's avatar
      2009-07-16 Kent Tamura <tkent@chromium.org> · fd7fd50f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              A test for for non-multipart file upload form submission.
              <https://bugs.webkit.org/show_bug.cgi?id=26505>
      
              * fast/forms/get-file-upload-expected.txt: Added.
              * fast/forms/get-file-upload.html: Added.
      
      2009-07-16  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Sends the basename of a selected file for non-multipart form submission.
              <https://bugs.webkit.org/show_bug.cgi?id=26505>
      
              Test: fast/forms/get-file-upload.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::appendFormData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd7fd50f
    • simon.fraser@apple.com's avatar
      2009-07-16 Simon Fraser <simon.fraser@apple.com> · 8b7420ea
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              Video size sometimes jumps just after the video starts loading
              https://bugs.webkit.org/show_bug.cgi?id=27352
      
              Ensure that the media player is at or after the 'HaveMetadata' state so that
              the instrinsic size is known before we create the layer for video. This avoids
              a flash caused by computing the video rect using the default intrinsic size, and then
              re-computing it when that size changes.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::isReadyForRendering):
              (WebCore::MediaPlayerPrivate::updateStates):
              (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b7420ea
    • abarth@webkit.org's avatar
      2009-07-16 Joseph Pecoraro <joepeck02@gmail.com> · 4bf34191
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTools/Scripts/svn-create-patch is broken
              https://bugs.webkit.org/show_bug.cgi?id=27328
      
              * Scripts/svn-create-patch: one line fix for unusual perl behavior
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf34191
    • abarth@webkit.org's avatar
      Unreviewed typo fix in two tests. · 8645369f
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8645369f
    • abarth@webkit.org's avatar
      2009-07-15 Adam Barth <abarth@webkit.org> · 41a823d5
      abarth@webkit.org authored
              Reviewed by Darin Fisher.
      
              Add tests for isolated worlds
              https://bugs.webkit.org/show_bug.cgi?id=27331
      
              These tests are currently disabled on JSC ports.
      
              * http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/all-window-properties.html: Added.
              * http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.
              * http/tests/security/isolatedWorld/all-window-prototypes.html: Added.
              * http/tests/security/isolatedWorld/body-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/body-properties.html: Added.
              * http/tests/security/isolatedWorld/body-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/body-prototype.html: Added.
              * http/tests/security/isolatedWorld/document-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/document-properties.html: Added.
              * http/tests/security/isolatedWorld/document-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/document-prototype.html: Added.
              * http/tests/security/isolatedWorld/global-variables-expected.txt: Added.
              * http/tests/security/isolatedWorld/global-variables.html: Added.
              * http/tests/security/isolatedWorld/image-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/image-properties.html: Added.
              * http/tests/security/isolatedWorld/image-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/image-prototype.html: Added.
              * http/tests/security/isolatedWorld/location-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/location-properties.html: Added.
              * http/tests/security/isolatedWorld/location-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/location-prototype.html: Added.
              * http/tests/security/isolatedWorld/number-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/number-prototype.html: Added.
              * http/tests/security/isolatedWorld/object-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/object-prototype.html: Added.
              * http/tests/security/isolatedWorld/string-prototype-expected.txt: Added.
              * http/tests/security/isolatedWorld/string-prototype.html: Added.
              * http/tests/security/isolatedWorld/window-properties-expected.txt: Added.
              * http/tests/security/isolatedWorld/window-properties.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41a823d5
    • levin@chromium.org's avatar
      2009-07-16 David Levin <levin@chromium.org> · 61a61aa9
      levin@chromium.org authored
              Reviewed by David Kilzer.
      
              cpplint should check for equality comparisons to 0/true/false
              https://bugs.webkit.org/show_bug.cgi?id=27333
      
              * Scripts/modules/cpplint.py: Added the new lint check.
              * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check
                and fix a regex that in another unit test that caused it to fail when
                you have a directory with a number in it (like WebKit-2)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61a61aa9
    • simon.fraser@apple.com's avatar
      2009-07-16 Simon Fraser <simon.fraser@apple.com> · fa2964d0
      simon.fraser@apple.com authored
              New demo files for an up-coming blog post.
      
              * blog-files/3d-transforms/mighty-cubes.png: Added.
              * blog-files/3d-transforms/morphing-cubes.html: Added.
              * blog-files/3d-transforms/perspective-by-example.html: Added.
              * blog-files/3d-transforms/poster-circle.html: Added.
              * blog-files/3d-transforms/poster-circle.png: Added.
              * blog-files/3d-transforms/transform-style.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2964d0
    • beidson@apple.com's avatar
      2009-07-16 Brady Eidson <beidson@apple.com> · e0722ad3
      beidson@apple.com authored
              Reviewed by Antti Koivisto.
              Patch by Brady Eidson and Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=26496
              <rdar://problem/7065391> Microsoft Outlook Web Access fails because XHR stream connection blocks script loading/revalidation
      
              After refreshing a page and when all CachedResources on that page are in validation mode, they got an exemption
              from the connection-per-host limit.  Removing that exemption makes the test case load smoothly after reloads.
      
              * loader/loader.cpp:
              (WebCore::Loader::Host::servePendingRequests): Remove the resourceIsCacheValidator exemption to the connection-per-host limit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0722ad3
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args · 32929e31
      ddkilzer@apple.com authored
              Reviewed by Eric Seidel.
      
              * Scripts/bugzilla-tool:
              (PostCommitsAsPatchesToBug.execute): Added more error checking
              when consuming arguments.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32929e31
    • abarth@webkit.org's avatar
      2009-07-16 Adam Barth <abarth@webkit.org> · 087a57b9
      abarth@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] V8IsolatedWorld::evaluate needs to call didCreateIsolatedScriptContext
              https://bugs.webkit.org/show_bug.cgi?id=27335
      
              evaluateInNewContext makes this delegate call.  evaluateInNewWorld
              needs to make the same call.  This does not appear to be testable with
              our current technology.
      
              * bindings/v8/V8IsolatedWorld.cpp:
              (WebCore::V8IsolatedWorld::evaluate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      087a57b9
    • ddkilzer@apple.com's avatar
      TOOL FIX: scm.py: CommitMessage.message is ambiguous · 146fcabe
      ddkilzer@apple.com authored
              Fixes this error when running bugzilla-tool apply-patches
              --local-commit:
      
              File "bugzilla-tool", line 188, in apply_patches
                scm.commit_locally_with_message(commit_message.message() or patch['name'])
              TypeError: 'list' object is not callable
      
              * Scripts/modules/scm.py: After r45940 (and r45971), rename
              CommitMessage.message attribute to CommitMessage.message_lines.
              (CommitMessage.__init__):
              (CommitMessage.body):
              (CommitMessage.description):
              (CommitMessage.message):
              (CommitMessage.parse_bug_id):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      146fcabe
    • hausmann@webkit.org's avatar
      2009-07-16 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 87ed70ac
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Enable GNU compiler extensions to the ARM compiler
              for all Qt ports using RVCT
              https://bugs.webkit.org/show_bug.cgi?id=27348
      
              * WebKit.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87ed70ac
    • hausmann@webkit.org's avatar
      2009-07-15 Jakub Wieczorek <faw217@gmail.com> · 2dccb741
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix a typo: application/atom=xml -> application/atom+xml.
      
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dccb741
    • dglazkov@chromium.org's avatar
      WebCore: · c8291f35
      dglazkov@chromium.org authored
      2009-07-16  Dean McNamee  <deanm@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27292
              Improve handling of <canvas> path operations on an empty path.
              Implement Skia's Path::hasCurrentPoint().
      
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::lineTo):
              (WebCore::CanvasRenderingContext2D::quadraticCurveTo):
              (WebCore::CanvasRenderingContext2D::bezierCurveTo):
              * platform/graphics/skia/PathSkia.cpp:
              (WebCore::Path::hasCurrentPoint):
      
      LayoutTests:
      
      2009-07-16  Dean McNamee  <deanm@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27292
              Improve handling of <canvas> path operations on an empty path.
              Implement Skia's Path::hasCurrentPoint().
      
              * fast/canvas/canvas-modify-emptyPath-expected.txt:
              * fast/canvas/resources/canvas-modify-emptyPath.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8291f35
    • treat@webkit.org's avatar
      2009-07-16 Yong Li <yong.li@torchmobile.com> · e0087e4e
      treat@webkit.org authored
               Reviewed by George Staikos.
      
               https://bugs.webkit.org/show_bug.cgi?id=27320
               _countof is only included in CE6; for CE5 we need to define it ourself
      
               * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0087e4e
    • ddkilzer@apple.com's avatar
      TOOL FIX: bugzilla-tool: import CommitMessage class · c837b5d3
      ddkilzer@apple.com authored
              * Scripts/bugzilla-tool: After r45940, the CommitMessage class
              needs to be imported for commit_message_for_this_commit().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c837b5d3