1. 08 Feb, 2011 7 commits
    • tony@chromium.org's avatar
      2011-02-07 Tony Chang <tony@chromium.org> · c3ccf5a2
      tony@chromium.org authored
              Reviewed by Adam Barth.
      
              clean up python imports
              https://bugs.webkit.org/show_bug.cgi?id=53966
      
              Convert "import A.B.C.D as D" to "from A.B.C import D" and
              make some imports absolute as required by PEP-8
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/net/irc/ircbot.py:
              * Scripts/webkitpy/common/system/logutils.py:
              * Scripts/webkitpy/common/system/logutils_unittest.py:
              * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
              * Scripts/webkitpy/tool/bot/irc_command.py:
              * Scripts/webkitpy/tool/bot/sheriffircbot.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/prettydiff.py:
              * Scripts/webkitpy/tool/commands/queries.py:
              * Scripts/webkitpy/tool/commands/roll.py:
              * Scripts/webkitpy/tool/commands/stepsequence.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/main.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3ccf5a2
    • commit-queue@webkit.org's avatar
      2011-02-07 James Robinson <jamesr@chromium.org> · 876507a3
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Teach do-webcore-rename about the WebKit move to Source/
              https://bugs.webkit.org/show_bug.cgi?id=53967
      
              * Scripts/do-webcore-rename:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      876507a3
    • ossy@webkit.org's avatar
      Unreviewed. · 46010337
      ossy@webkit.org authored
      [Qt] Fix crashes in QMetaObject::metacall
      https://bugs.webkit.org/show_bug.cgi?id=53912
      
      * platform/qt/Skipped: http/tests/websocket/tests/websocket-protocol-ignored.html added until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46010337
    • mrowe@apple.com's avatar
      Fix the 32-bit build. · f3d9f087
      mrowe@apple.com authored
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
      (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3d9f087
    • commit-queue@webkit.org's avatar
      2011-02-07 Kenji Imasaki <imasaki@chromium.org> · 49a006f8
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              [Chromium] Remove non-Flaky media layout tests and update bugs that
              are associated with media layout tests
              https://bugs.webkit.org/show_bug.cgi?id=53948
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a006f8
    • mjs@apple.com's avatar
      2011-02-07 Maciej Stachowiak <mjs@apple.com> · dddf6cd7
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Add resource load client for injected bundle and move willSendRequest there
              https://bugs.webkit.org/show_bug.cgi?id=53972
      
              * GNUmakefile.am:
              * WebKit2.pro:
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
              (WKBundlePageSetPageLoaderClient):
              (WKBundlePageSetResourceLoadClient):
              * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
              * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
              * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
              * WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added.
              (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource):
              (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
              (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource):
              (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource):
              (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource):
              (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
              * WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
              (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
              (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
              (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
              * WebProcess/WebPage/WebPage.h:
              (WebKit::WebPage::injectedBundleResourceLoadClient):
              * win/WebKit2.vcproj:
      2011-02-07  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Add resource load client for injected bundle and move willSendRequest there
              https://bugs.webkit.org/show_bug.cgi?id=53972
      
              * MiniBrowser/mac/WebBundle/WebBundleMain.m:
              (didCreatePage):
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::InjectedBundlePage):
              (WTR::InjectedBundlePage::didInitiateLoadForResource):
              (WTR::InjectedBundlePage::didReceiveResponseForResource):
              (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
              (WTR::InjectedBundlePage::didFinishLoadForResource):
              (WTR::InjectedBundlePage::didFailLoadForResource):
              (WTR::InjectedBundlePage::willSendRequestForFrame):
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dddf6cd7
    • commit-queue@webkit.org's avatar
      2011-02-07 Xiyuan Xia <xiyuan@chromium.org> · d49856f5
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              [Chromium] Select popup box does not align with select button when appearance is not "menulist".
              https://bugs.webkit.org/show_bug.cgi?id=53942
      
              Added manual test select_webkit_appearance_off_popup_alignment.html.
      
              * manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d49856f5
  2. 07 Feb, 2011 33 commits
    • commit-queue@webkit.org's avatar
      2011-02-07 Aparna Nandyal <aparna.nand@wipro.com> · 081bfeff
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] - Context menu needs "Copy" as well when the selected text is a link.
              https://bugs.webkit.org/show_bug.cgi?id=40983
      
              Added copy option for Qt platform if selection is a link.
              Added a test in tst_qwebpage.cpp.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::populate):
      2011-02-07  Aparna Nandyal  <aparna.nand@wipro.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] - Context menu needs "Copy" as well when the selected text is a link.
              https://bugs.webkit.org/show_bug.cgi?id=40983
      
              Added a test case to create a context sensitive menu.
              A check is made if it has Copy menu item when user
              selects a link and opens context menu.
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::contextMenuCopy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      081bfeff
    • commit-queue@webkit.org's avatar
      2011-02-07 Mike Reed <reed@google.com> · 717d43f3
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
              when drawing <canvas>. Disabled by default.
      
              No new tests. existing canvas layouttests apply
      
              * platform/graphics/chromium/DrawingBufferChromium.cpp:
              (WebCore::DrawingBuffer::publishToPlatformLayer):
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::GetGlobalGrContext):
              (WebCore::PlatformContextSkia::isPrinting):
              (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
              (WebCore::PlatformContextSkia::syncSoftwareCanvas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      717d43f3
    • jcivelli@chromium.org's avatar
      2011-02-07 Jay Civelli <jcivelli@chromium.org> · a5398c7b
      jcivelli@chromium.org authored
              Reviewed by Darin Fisher.
      
              Removing unused code from PopupMenuChromium.
              https://bugs.webkit.org/show_bug.cgi?id=53866
      
             * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::layout):
              (WebCore::PopupMenuChromium::show):
              * platform/chromium/PopupMenuChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5398c7b
    • ojan@chromium.org's avatar
      2011-02-07 Ojan Vafai <ojan@chromium.org> · f577f0bd
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              bring back diff context lines into the review tool
              https://bugs.webkit.org/show_bug.cgi?id=53974
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f577f0bd
    • commit-queue@webkit.org's avatar
      2011-02-07 Kenichi Ishibashi <bashi@google.com> · 090f96a6
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
              https://bugs.webkit.org/show_bug.cgi?id=53791
      
              Test that a live list is updated after the child of an HTMLOutputElement was removed.
      
              * fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
              * fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.
      2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>
      
              Reviewed by Andreas Kling.
      
              HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
              https://bugs.webkit.org/show_bug.cgi?id=53791
      
              Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().
      
              Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html
      
              * html/HTMLOutputElement.cpp:
              (WebCore::HTMLOutputElement::childrenChanged): Calls super class's
              childrenChanged().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      090f96a6
    • commit-queue@webkit.org's avatar
      2011-02-07 Benjamin Poulain <ikipou@gmail.com> · 5930dca3
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] cookiesEnabled could create the cookieJar on the wrong thread.
              https://bugs.webkit.org/show_bug.cgi?id=52289
      
              Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
              in the same thread as the QNetworkAccessManager.
      
              * platform/network/qt/QtNAMThreadSafeProxy.cpp:
              (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
              (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
              * platform/network/qt/QtNAMThreadSafeProxy.h:
              * platform/qt/CookieJarQt.cpp:
              (WebCore::cookiesEnabled):
      2011-02-07  Benjamin Poulain  <ikipou@gmail.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] cookiesEnabled could create the cookieJar on the wrong thread.
              https://bugs.webkit.org/show_bug.cgi?id=52289
      
              Test if the cookie jar is created in the right thread when accessed from
              the navigator object.
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5930dca3
    • commit-queue@webkit.org's avatar
      2011-02-07 Alexey Marinichev <amarinichev@chromium.org> · db5e671a
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Hook up WebGraphicsContext3D::setContextLostCallback.
              https://bugs.webkit.org/show_bug.cgi?id=53722
      
              Test: fast/canvas/webgl/context-lost.html, comment out the line with
              extension.loseContext() and kill the GPU process "Lose context"
              message shows up.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
              (WebCore::WebGLRenderingContextLostCallback::onContextLost):
              (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback):
              (WebCore::WebGLRenderingContext::initializeNewContext):
              (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
              * platform/graphics/GraphicsContext3D.h:
              (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
              * platform/graphics/mac/GraphicsContext3DMac.mm:
              (WebCore::GraphicsContext3D::setContextLostCallback): stub
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::setContextLostCallback): stub
      2011-02-07  Alexey Marinichev  <amarinichev@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Hook up WebGraphicsContext3D::setContextLostCallback.
              https://bugs.webkit.org/show_bug.cgi?id=53722
      
              Test: fast/canvas/webgl/context-lost.html, comment out the line with
              extension.loseContext() and kill the GPU process "Lose context"
              message shows up.
      
              * public/WebGraphicsContext3D.h:
              (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
              * src/GraphicsContext3DChromium.cpp:
              (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
              (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
              (WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
              (WebCore::GraphicsContextLostCallbackAdapter::create):
              (WebCore::GraphicsContext3DInternal::setContextLostCallback):
              * src/GraphicsContext3DInternal.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db5e671a
    • mrowe@apple.com's avatar
      Fix the 32-bit build. · 910fffc3
      mrowe@apple.com authored
      * UIProcess/cf/WebBackForwardListCF.cpp:
      (WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
      to prevent warnings about mixing signed and unsigned comparisons.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      910fffc3
    • abarth@webkit.org's avatar
      2011-02-07 Adam Barth <abarth@webkit.org> · c01dce74
      abarth@webkit.org authored
              Add Leopard Debug back to the core builders.
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c01dce74
    • commit-queue@webkit.org's avatar
      2011-02-07 Ami Fischman <fischman@google.com> · d80cc722
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
              https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
              slightly different scrollbar shading.
              This test isn't flaky on LINUX or MAC according to
              http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
              so take it out of test_expectations.txt; it passes 100% on LINUX and
              fails 100% on MAC, and should pass 100% on MAC with this new
              baseline.
      
              * platform/chromium-mac/media/video-zoom-expected.checksum:
              * platform/chromium-mac/media/video-zoom-expected.png:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d80cc722
    • commit-queue@webkit.org's avatar
      2011-02-07 Adam Klein <adamk@chromium.org> · b4d8b460
      commit-queue@webkit.org authored
              Reviewed by Jian Li.
      
              [chromium] Remove deprecated method WebNotification::dir
              https://bugs.webkit.org/show_bug.cgi?id=53735
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
      2011-02-07  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Jian Li.
      
              [chromium] Remove deprecated method WebNotification::dir
              https://bugs.webkit.org/show_bug.cgi?id=53735
      
              * DumpRenderTree/chromium/NotificationPresenter.cpp:
              (NotificationPresenter::show):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4d8b460
    • paroga@webkit.org's avatar
      2011-02-07 Patrick Gansterer <paroga@webkit.org> · 7da1ec90
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add missing PaintInfo include in RenderThemeWin.cpp
              https://bugs.webkit.org/show_bug.cgi?id=53885
      
              * rendering/RenderThemeWin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7da1ec90
    • jamesr@google.com's avatar
      2011-02-07 James Robinson <jamesr@chromium.org> · 0e8f7588
      jamesr@google.com authored
              Move sputnik expectations to match test movement.
      
              * platform/gtk/fast/js/sputnik: Removed.
              * platform/gtk/fast/js/sputnik/Unicode: Removed.
              * platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
              * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
              * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
              * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
              * platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
              * platform/mac-leopard/fast/js/sputnik: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
              * platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
              * platform/win/fast/js/sputnik: Removed.
              * platform/win/fast/js/sputnik/Conformance: Removed.
              * platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
              * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
              * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
              * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
              * platform/win/fast/js/sputnik/Unicode: Removed.
              * platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
              * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
              * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
              * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
              * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
              * platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e8f7588
    • commit-queue@webkit.org's avatar
      2011-02-07 Ami Fischman <fischman@google.com> · 58d1a8d3
      commit-queue@webkit.org authored
              Reviewed by Eric Carlson.
      
              Removed two of the three almost-duplicate test expectations
              between {media,platform/chromium-{mac,win}} by excluding file
              extensions from the emitted output.
              Removed outdated test_expectation for deleted test.
              http://crbug.com/28993
      
              * media/controls-right-click-on-timebar-expected.txt:
              * media/controls-right-click-on-timebar.html:
              * media/media-file.js:
              (stripExtension):
              * media/media-startTime-expected.txt:
              * media/media-startTime.html:
              * media/video-append-source-expected.txt:
              * media/video-append-source.html:
              * media/video-canvas-source-expected.txt:
              * media/video-canvas-source.html:
              * media/video-dom-src-expected.txt:
              * media/video-dom-src.html:
              * media/video-load-networkState-expected.txt:
              * media/video-load-networkState.html:
              * media/video-played-reset-expected.txt:
              * media/video-played-reset.html:
              * media/video-seek-past-end-paused-expected.txt:
              * media/video-seek-past-end-paused.html:
              * media/video-seek-past-end-playing-expected.txt:
              * media/video-seek-past-end-playing.html:
              * media/video-source-expected.txt:
              * media/video-source-type-expected.txt:
              * media/video-source-type-params-expected.txt:
              * media/video-source-type-params.html:
              * media/video-source-type.html:
              * media/video-source.html:
              * media/video-src-change-expected.txt:
              * media/video-src-change.html:
              * media/video-src-expected.txt:
              * media/video-src-remove-expected.txt:
              * media/video-src-remove.html:
              * media/video-src-set-expected.txt:
              * media/video-src-set.html:
              * media/video-src-source-expected.txt:
              * media/video-src-source.html:
              * media/video-src.html:
              * media/video-test.js:
              (enableFullTestDetailsPrinting):
              (test):
              (testExpected):
              (waitForEvent._eventCallback):
              (waitForEvent):
              (waitForEventAndTest._eventCallback):
              (waitForEventAndTest):
              (testException):
              (endTest):
              * platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
              * platform/chromium-mac/media/media-startTime-expected.txt: Removed.
              * platform/chromium-mac/media/video-append-source-expected.txt: Removed.
              * platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
              * platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
              * platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
              * platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
              * platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
              * platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
              * platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
              * platform/chromium-mac/media/video-source-error-expected.txt: Removed.
              * platform/chromium-mac/media/video-source-expected.txt: Removed.
              * platform/chromium-mac/media/video-source-type-expected.txt: Removed.
              * platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
              * platform/chromium-mac/media/video-src-change-expected.txt: Removed.
              * platform/chromium-mac/media/video-src-expected.txt: Removed.
              * platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
              * platform/chromium-mac/media/video-src-set-expected.txt: Removed.
              * platform/chromium-mac/media/video-src-source-expected.txt: Removed.
              * platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
              * platform/chromium-win/media/media-startTime-expected.txt: Removed.
              * platform/chromium-win/media/video-append-source-expected.txt: Removed.
              * platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
              * platform/chromium-win/media/video-dom-src-expected.txt: Removed.
              * platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
              * platform/chromium-win/media/video-played-reset-expected.txt: Removed.
              * platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
              * platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
              * platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
              * platform/chromium-win/media/video-source-error-expected.txt: Removed.
              * platform/chromium-win/media/video-source-expected.txt: Removed.
              * platform/chromium-win/media/video-source-type-expected.txt: Removed.
              * platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
              * platform/chromium-win/media/video-src-change-expected.txt: Removed.
              * platform/chromium-win/media/video-src-expected.txt: Removed.
              * platform/chromium-win/media/video-src-remove-expected.txt: Removed.
              * platform/chromium-win/media/video-src-set-expected.txt: Removed.
              * platform/chromium-win/media/video-src-source-expected.txt: Removed.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58d1a8d3
    • commit-queue@webkit.org's avatar
      2011-02-07 Qi Zhang <qi.2.zhang@nokia.com> · d10a96e7
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
              https://bugs.webkit.org/show_bug.cgi?id=52974
      
              Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              (WebCore::ContextMenuController::populate):
              (WebCore::ContextMenuController::checkOrEnableIfNeeded):
              * platform/ContextMenuItem.h:
              * platform/LocalizationStrategy.h:
              * platform/LocalizedStrings.cpp:
              (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
              * platform/LocalizedStrings.h:
      2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
              https://bugs.webkit.org/show_bug.cgi?id=52974
      
              Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.
      
              * Api/qwebpage.cpp:
              (webActionForContextMenuAction):
              (QWebPage::triggerAction):
              (QWebPage::action):
              * Api/qwebpage.h:
              * WebCoreSupport/WebPlatformStrategies.cpp:
              (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
              * WebCoreSupport/WebPlatformStrategies.h:
      2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
              https://bugs.webkit.org/show_bug.cgi?id=52974
      
              Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
      
              * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
              (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
              * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d10a96e7
    • tkent@chromium.org's avatar
      2011-02-07 Kenichi Ishibashi <bashi@chromium.org> · 38d5f63d
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
              https://bugs.webkit.org/show_bug.cgi?id=53970
      
              Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
              return the right value.
      
              Test: fast/dom/HTMLObjectElement/form/nested-form-element.html
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::virtualForm): Added.
              * html/HTMLObjectElement.h: Added virtualForm().
      
      2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>
      
              Reviewed by Kent Tamura.
      
              HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
              https://bugs.webkit.org/show_bug.cgi?id=53970
      
              Adds a test that ensures WebKit parses successfully a page that
              contains object elements which are in nested and defective form
              elements.
      
              * fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
              * fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38d5f63d
    • abarth@webkit.org's avatar
      2011-02-07 Adam Barth <abarth@webkit.org> · 908e7c13
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove Leopard Debug as a core builder
              https://bugs.webkit.org/show_bug.cgi?id=53971
      
              The Leopard Debug builder has been failing to compile for several days.
              My understanding is that folks are working on fixing the build, but for
              the time being we should probably remove it from the list of core
              builders so that the core waterfall can be green.  We can certainly add
              it back once the build is fixed.
      
              Also, I've removed the Tiger builders because those no longer appear to
              be attached to the buildbot master.
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      908e7c13
    • ojan@chromium.org's avatar
      2011-02-01 Ojan Vafai <ojan@chromium.org> · 27e5b46a
      ojan@chromium.org authored
              Reviewed by Adam Roben.
      
              include svn revisions in git diffs for the code review tool to use
              https://bugs.webkit.org/show_bug.cgi?id=53569
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      2011-02-01  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Adam Roben.
      
              include svn revisions in git diffs for the code review tool to use
              https://bugs.webkit.org/show_bug.cgi?id=53569
      
              * PrettyPatch/PrettyPatch.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27e5b46a
    • rniwa@webkit.org's avatar
      2011-02-07 Ryosuke Niwa <rniwa@webkit.org> · 97869fda
      rniwa@webkit.org authored
              Unreviewed Leopard build fix.
      
              * WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
              * platform/mac/DragImageMac.mm:
              (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97869fda
    • yuzo@google.com's avatar
      2011-02-07 Yuzo Fujishima <yuzo@google.com> · 64b4de73
      yuzo@google.com authored
              Unreviewed attempt to fix a flaky test.
              https://bugs.webkit.org/show_bug.cgi?id=51757
      
              * fast/css/font-face-download-error.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b4de73
    • zmo@google.com's avatar
      2011-02-07 Zhenyao Mo <zmo@google.com> · 3dacf02c
      zmo@google.com authored
              Unreviewed, test expectations update.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dacf02c
    • jamesr@google.com's avatar
      2011-02-07 James Robinson <jamesr@chromium.org> · 9476e9be
      jamesr@google.com authored
              Reviewed by Dan Bernstein.
      
              Move the sputnik test suite out of fast/js/
              https://bugs.webkit.org/show_bug.cgi?id=53954
      
              The sputnik suite shouldn't go in fast/js/ because it is not fast and
              it is an imported test suite.  This moves it to LayoutTests/sputnik
              and updates references in skipped lists / expectations.
      
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9476e9be
    • rniwa@webkit.org's avatar
      Fixing the change log entry. · 9e785860
      rniwa@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e785860
    • rniwa@webkit.org's avatar
      2011-02-07 Geoffrey Garen <ggaren@apple.com> · d04d6ce2
      rniwa@webkit.org authored
              Reviewed by Sam Weinig.
      
              Removed some dead code from Heap
              https://bugs.webkit.org/show_bug.cgi?id=53969
              
              SunSpider reports no change.
      
              * runtime/MarkedSpace.cpp:
              (JSC::MarkedSpace::shrink):
              (JSC::MarkedSpace::sweep):
              * runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and
              renamed shrinkBlocks to shrink, making it unconditionally shrink as
              much as possible.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d04d6ce2
    • enrica@apple.com's avatar
      Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874 · 62040b85
      enrica@apple.com authored
      Reviewed by Sam Weinig.
      
      When moving code from WebKit to WebCore we needed to move some additional
      functions previously in NSStringExtras.
              
      * WebCore.xcodeproj/project.pbxproj:
      * platform/mac/DragImageMac.mm:
      (WebCore::fontFromNSFont):
      (WebCore::canUseFastRenderer):
      (WebCore::widthWithFont):
      (WebCore::webkit_CGCeiling):
      (WebCore::drawAtPoint):
      (WebCore::drawDoubledAtPoint):
      (WebCore::createDragImageForLink):
      
      Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
              
      Reviewed by Sam Weinig.
      
      Removed unused static function.
              
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62040b85
    • ggaren@apple.com's avatar
      2011-02-07 Geoffrey Garen <ggaren@apple.com> · 9a32dee0
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Removed some dead code from Heap
              https://bugs.webkit.org/show_bug.cgi?id=53969
              
              SunSpider reports no change.
      
              * runtime/MarkedSpace.cpp:
              (JSC::MarkedSpace::shrink):
              (JSC::MarkedSpace::sweep):
              * runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and
              renamed shrinkBlocks to shrink, making it unconditionally shrink as
              much as possible.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a32dee0
    • andersca@apple.com's avatar
      <rdar://problem/8969888> · a9eae98c
      andersca@apple.com authored
      The WebProcess should set LSFileQuarantineEnabled to true
      
      Reviewed by Sam Weinig.
      
      * WebProcess/Info.plist:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9eae98c
    • zmo@google.com's avatar
      2011-02-07 Zhenyao Mo <zmo@google.com> · 6085f96a
      zmo@google.com authored
              Unreviewed, test expectations update.
      
      	* platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6085f96a
    • lforschler@apple.com's avatar
      2011-02-07 Lucas Forschler <lforschler@apple.com> · 648aa2c2
      lforschler@apple.com authored
              Reviewed by Geoff Garen.
      
              Tr #2, Fix the Leopard 32bit debug build.
              
              No new tests required.
      
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityAllInOne.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      648aa2c2
    • ggaren@apple.com's avatar
      2011-02-07 Geoffrey Garen <ggaren@apple.com> · bb9706c5
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Simplified the marked space's mark invariant
              https://bugs.webkit.org/show_bug.cgi?id=53968
              
              SunSpider reports no change.
              
              * runtime/MarkedSpace.cpp:
              (JSC::MarkedSpace::allocate): Mark objects when allocating them. This
              means that, at all times other than the mark phase, an object is live
              if and only if it is marked.
      
              (JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
              simplify testing whether an object is live.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb9706c5
    • bdakin@apple.com's avatar
      Fix for <rdar://problem/8946961> Fix repaint problems · 1cabbdd2
      bdakin@apple.com authored
      with WKScrollbarPainter scrollers while resizing the window
      
      Reviewed by Sam Weinig.
      
      Remove setPainterForPainterController() and 
      removePainterFromPainterController() since they aren't
      used anymore.
      * platform/mac/ScrollAnimatorMac.h:
              
      Return early if they alpha hasn't changed.
      * platform/mac/ScrollAnimatorMac.mm:
      (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
      (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
              
      If we're in a live resize, restore alpha to 1.
      (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
      (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cabbdd2
    • morrita@google.com's avatar
      2011-02-03 MORITA Hajime <morrita@google.com> · d4f3e77a
      morrita@google.com authored
              Reviewed by Darin Fisher.
      
              [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
              https://bugs.webkit.org/show_bug.cgi?id=51013
      
              Unskipped passed test.
      
              * platform/chromium/test_expectations.txt:
      2011-02-03  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
              https://bugs.webkit.org/show_bug.cgi?id=51013
      
              - Added WebTextCheckingCompletion to receive the checked result asynchronously.
              - Added WebViewClient::requestCheckingOfText() and related classes.
              - Implemented EditorClientImpl::requestCheckingOfString().
      
              * WebKit.gyp:
              * public/WebSettings.h:
              * public/WebTextCheckingCompletion.h: Added.
              (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
              * public/WebTextCheckingResult.h: Added.
              (WebKit::WebTextCheckingResult::error):
              (WebKit::WebTextCheckingResult::position):
              (WebKit::WebTextCheckingResult::length):
              (WebKit::WebTextCheckingResult::WebTextCheckingResult):
              * public/WebViewClient.h:
              (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
              * src/AssertMatchingEnums.cpp:
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::requestCheckingOfString):
              * src/EditorClientImpl.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
              * src/WebSettingsImpl.h:
              * src/WebTextCheckingCompletionImpl.cpp: Added.
              (WebKit::toCoreResults):
              (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
              * src/WebTextCheckingCompletionImpl.h: Added.
              (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
      2011-02-03  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
              https://bugs.webkit.org/show_bug.cgi?id=51013
      
              Gave DRT implementation for requestTextCheck().
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (invokeFinishLastTextCheck): Added.
              (WebViewHost::requestTextCheck): Added.
              (WebViewHost::finishLastTextCheck): Added.
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4f3e77a
    • andersca@apple.com's avatar
      2011-02-07 Anders Carlsson <andersca@apple.com> · a9e1c59b
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Crash in web process after the connection had been closed
              https://bugs.webkit.org/show_bug.cgi?id=51115
              <rdar://problem/8964255>
      
              Remove didCloseOnConnectionWorkQueue from Connection::Client and add
              Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
              function, eliminating the race condition in connectionDidClose where m_client could be
              nulled out in the client thread right before we try to dereference it.
      
              * Platform/CoreIPC/Connection.cpp:
              (CoreIPC::Connection::Connection):
              Initialize m_didCloseOnConnectionWorkQueueCallback.
      
              (CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
              Update m_didCloseOnConnectionWorkQueueCallback.
      
              (CoreIPC::Connection::connectionDidClose):
              Call m_didCloseOnConnectionWorkQueueCallback.
      
              * Platform/WorkQueue.h:
              Make WorkQueue noncopyable.
      
              * PluginProcess/PluginProcess.cpp:
              (WebKit::PluginProcess::initializeConnection):
              Call setDidCloseOnConnectionWorkQueueCallback.
      
              * Shared/ChildProcess.cpp:
              (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
              * Shared/ChildProcess.h:
              didCloseOnConnectionWorkQueue is now a static member function.
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::initialize):
              Call setDidCloseOnConnectionWorkQueueCallback.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9e1c59b