1. 28 Mar, 2011 40 commits
    • aestes@apple.com's avatar
      Make embed-prefers-plugins-for-images.html pass on all Apple platforms. · c369811f
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57137
      
      * platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
      * platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
      * platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
      * platform/win/Skipped:
      * plugins/embed-prefers-plugins-for-images-expected.txt:
      * plugins/embed-prefers-plugins-for-images.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c369811f
    • mjs@apple.com's avatar
      Revert accidentally commited change. · b85967f9
      mjs@apple.com authored
      * DumpRenderTree/mac/ResourceLoadDelegate.mm:
      (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85967f9
    • bdakin@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for: · 8e776ca0
      bdakin@apple.com authored
      Horizontal scroller stops appearing after going Forward
      -and corresponding-
      <rdar://problem/9026946>
      
      Reviewed by Darin Adler.
      
      This patch rolls out revision 79053 and fixes the same bug in a  better way.
      
      New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then 
      sets the contents size to 0. This is called when a document is going into the page 
      cache.
      * dom/Document.cpp:
      (WebCore::Document::setInPageCache):
      (WebCore::FrameView::resetScrollbarsAndClearContentsSize):
      
      Roll-out of 79053.
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::restore):
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::reset):
      (WebCore::FrameView::layout):
      * page/FrameView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e776ca0
    • ojan@chromium.org's avatar
      2011-03-28 Ojan Vafai <ojan@chromium.org> · f6e107a4
      ojan@chromium.org authored
              Reviewed by Antti Koivisto.
      
              fix style sharing with :any and sibling selectors
              https://bugs.webkit.org/show_bug.cgi?id=57211
      
              Also tests sibling selector style sharing in general since
              no existing tests seem to cover that codepath.
      
              * fast/css/sibling-selectors-expected.txt: Added.
              * fast/css/sibling-selectors.html: Added.
      2011-03-28  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Antti Koivisto.
      
              fix style sharing with :any and sibling selectors
              https://bugs.webkit.org/show_bug.cgi?id=57211
      
              Test: fast/css/sibling-selectors.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::collectFeaturesFromList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6e107a4
    • ojan@chromium.org's avatar
      2011-03-27 Ojan Vafai <ojan@chromium.org> · 3fd44eaa
      ojan@chromium.org authored
              Reviewed by Antti Koivisto.
      
              fix :-webkit-any(:last-child)
              https://bugs.webkit.org/show_bug.cgi?id=57207
      
              * fast/css/pseudo-any.html:
      2011-03-27  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Antti Koivisto.
      
              fix :-webkit-any(:last-child)
              https://bugs.webkit.org/show_bug.cgi?id=57207
      
              We were passing the wrong arguments to checkSelector. Also, we were not
              passing through the encounteredLink bool.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              * css/CSSStyleSelector.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fd44eaa
    • aestes@apple.com's avatar
      Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode. · 1b4eda83
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57137
      
      * platform/mac-wk2/plugins: Added.
      * platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b4eda83
    • mjs@apple.com's avatar
      2011-03-28 Maciej Stachowiak <mjs@apple.com> · c22802c2
      mjs@apple.com authored
              Reviewed by Darin Adler.
      
              REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
              https://bugs.webkit.org/show_bug.cgi?id=57291
      
              * platform/KURL.cpp:
              (WebCore::KURL::parse): Instead of considering URLs with
              credentials but no host invalid, consider them to have a host
              ending in @ (which fails down the line)/
      2011-03-28  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin Adler.
      
              REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
              https://bugs.webkit.org/show_bug.cgi?id=57291
      
              * http/tests/uri/username-with-no-hostname.html: Adjusted test to be more tolerant
              of exactly how the image load fails.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c22802c2
    • tkent@chromium.org's avatar
      2011-03-28 Kent Tamura <tkent@chromium.org> · 4c3ddb61
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Fix some problems of the appearance of form validation message bubble.
              https://bugs.webkit.org/show_bug.cgi?id=57208
      
              No new tests. Validation message bubble appearance is not testable
              because it depends on a timer.
      
              * css/html.css:
              (::-webkit-validation-bubble):
              (::-webkit-validation-bubble-message):
              (::-webkit-validation-bubble-arrow):
              (::-webkit-validation-bubble-arrow-clipper):
                - Explicitly set margin, padding, and color.
                - Make the shadow darker.
                - Make the background color darker.
                - Make opacity larger.
                - Make the border color lighter.
                - Add inset shadows
                - Change the implementation of an arrow.
                  Stop making a right triangle by the border trick.
                  Use -webkit-transform instead.
                - Make min-width workable by changing display property of
                  -webkit-validation-bubble to "inline-block".
              * html/ValidationMessage.cpp:
              (WebCore::ValidationMessage::buildBubbleTree):
                Change the node structure. Before this change, -webkit-validation-bubble
                had three DIVs inside. After this change, it has two DIVs;
                -webkit-validation-bubble-arrow-clipper and
                -webkit-validation-bubble-message, and
                -webkit-validation-bubble-arrow-clipper contains
                -webkit-validation-bubble-arrow.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c3ddb61
    • mdelaney@apple.com's avatar
      2011-03-28 Matthew Delaney <mdelaney@apple.com> · 08fafab3
      mdelaney@apple.com authored
              Reviewed by Adele Peterson.
      
              Updating small batch of gradient expected results files
              https://bugs.webkit.org/show_bug.cgi?id=57117
      
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
              * platform/mac/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
              * platform/mac/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
              * platform/mac/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08fafab3
    • jberlin@webkit.org's avatar
      REGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2. · c72541a2
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=56539
      
      Unreviewed, remove the platform-specific failing results to get the bots green.
      The test appears to be working in WebKit after r82106 and r82017.
      
      * platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c72541a2
    • scheib@chromium.org's avatar
      2011-03-28 Vincent Scheib <scheib@chromium.org> · c6748218
      scheib@chromium.org authored
              Chromium test expectation for r82159
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6748218
    • enrica@apple.com's avatar
      REGRESSION: Can't enter pasted with context or Edit menu text in search or... · 68c7c11c
      enrica@apple.com authored
      REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
      https://bugs.webkit.org/show_bug.cgi?id=57275
      <rdar://problem/8246691>
      
      Reviewed by Sam Weinig.
      
      We need to classify cut and paste actions as user typing actions even when
      the action is triggered by a context menu selection to
      allow the propagation of the textDidChangeInTextField event.
      
      * editing/EditorCommand.cpp:
      The following methods have been modified to properly set up
      the UserTypingGestureAction when the command source is the
      menu or a key binding sequence.
      (WebCore::executeCut):
      (WebCore::executePaste):
      (WebCore::executePasteAndMatchStyle):
      (WebCore::executePasteAsPlainText):
      (WebCore::executeDelete):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected): Changed to
      call execute command instead of referring to the specific method in
      the editor class.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68c7c11c
    • jberlin@webkit.org's avatar
      Add another test that depends on EventSender to the mac-wk2 Skipped file. · 137ced7f
      jberlin@webkit.org authored
      * platform/mac-wk2/Skipped:
      Add fast/events/onchange-text-form-field.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137ced7f
    • tony@chromium.org's avatar
      2011-03-28 Tony Chang <tony@chromium.org> · e639ab17
      tony@chromium.org authored
              Reviewed by Adam Barth.
      
              [chromium] have DRT write the png checksum into a png comment
              https://bugs.webkit.org/show_bug.cgi?id=57255
      
              * DEPS: Pull in version of chromium with comment writing
      2011-03-28  Tony Chang  <tony@chromium.org>
      
              Reviewed by Adam Barth.
      
              [chromium] have DRT write the png checksum into a png comment
              https://bugs.webkit.org/show_bug.cgi?id=57255
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::dumpImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e639ab17
    • oliver@apple.com's avatar
      2011-03-28 Oliver Hunt <oliver@apple.com> · 3b6dc575
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              instanceof Array test fails when using iframes
              https://bugs.webkit.org/show_bug.cgi?id=17250
      
              Add test cases for correct behaviour
      
              * fast/js/js-constructors-use-correct-global-expected.txt: Added.
              * fast/js/js-constructors-use-correct-global.html: Added.
              * fast/js/resources/js-constructors-use-correct-global.js: Added.
      2011-03-28  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              instanceof Array test fails when using iframes
              https://bugs.webkit.org/show_bug.cgi?id=17250
      
              This is a problem with all built in constructors, the use of
              lexicalGlobalObject rather than the constructors own
              global object reference means that a builtin will always use
              the prototype from the lexical global object rather than that
              of the constructors origin.
      
              * API/JSObjectRef.cpp:
              (JSObjectMakeFunction):
              (JSObjectMakeRegExp):
              * JavaScriptCore.exp:
              * runtime/ArrayConstructor.cpp:
              (JSC::constructArrayWithSizeQuirk):
              * runtime/BooleanConstructor.cpp:
              (JSC::constructBoolean):
              (JSC::constructBooleanFromImmediateBoolean):
              * runtime/BooleanConstructor.h:
              * runtime/DateConstructor.cpp:
              (JSC::constructDate):
              * runtime/DateInstance.cpp:
              * runtime/DateInstance.h:
              * runtime/ErrorConstructor.cpp:
              (JSC::constructWithErrorConstructor):
              (JSC::callErrorConstructor):
              * runtime/FunctionConstructor.cpp:
              (JSC::constructWithFunctionConstructor):
              (JSC::callFunctionConstructor):
              (JSC::constructFunction):
              * runtime/FunctionConstructor.h:
              * runtime/JSCell.cpp:
              (JSC::JSCell::getOwnPropertySlot):
              (JSC::JSCell::put):
              (JSC::JSCell::deleteProperty):
              (JSC::JSCell::toThisObject):
              (JSC::JSCell::toObject):
              * runtime/JSCell.h:
              (JSC::JSCell::JSValue::toObject):
              * runtime/JSNotAnObject.cpp:
              (JSC::JSNotAnObject::toObject):
              * runtime/JSNotAnObject.h:
              * runtime/JSObject.cpp:
              (JSC::JSObject::toObject):
              * runtime/JSObject.h:
              * runtime/JSString.cpp:
              (JSC::StringObject::create):
              (JSC::JSString::toObject):
              (JSC::JSString::toThisObject):
              * runtime/JSString.h:
              * runtime/JSValue.cpp:
              (JSC::JSValue::toObjectSlowCase):
              (JSC::JSValue::toThisObjectSlowCase):
              (JSC::JSValue::synthesizeObject):
              * runtime/JSValue.h:
              * runtime/NumberConstructor.cpp:
              (JSC::constructWithNumberConstructor):
              * runtime/NumberObject.cpp:
              (JSC::constructNumber):
              * runtime/NumberObject.h:
              * runtime/ObjectConstructor.cpp:
              (JSC::constructObject):
              (JSC::constructWithObjectConstructor):
              (JSC::callObjectConstructor):
              * runtime/RegExpConstructor.cpp:
              (JSC::constructRegExp):
              (JSC::constructWithRegExpConstructor):
              (JSC::callRegExpConstructor):
              * runtime/RegExpConstructor.h:
              * runtime/StringConstructor.cpp:
              (JSC::constructWithStringConstructor):
              * runtime/StringObject.h:
      2011-03-25  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              instanceof Array test fails when using iframes
              https://bugs.webkit.org/show_bug.cgi?id=17250
      
              Up date for new toObject api
      
              * UserObjectImp.cpp:
              (UserObjectImp::toPrimitive):
              (UserObjectImp::toBoolean):
              (UserObjectImp::toNumber):
              (UserObjectImp::toString):
      2011-03-28  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              instanceof Array test fails when using iframes
              https://bugs.webkit.org/show_bug.cgi?id=17250
      
              Update for new function and date apis
      
              Test: fast/js/js-constructors-use-correct-global.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::jsDateOrNull):
              * bindings/js/JSLazyEventListener.cpp:
              (WebCore::JSLazyEventListener::initializeJSFunction):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b6dc575
    • adele@apple.com's avatar
      Removing Qt stub, since it doesn't use the same header as the others. · 529cc692
      adele@apple.com authored
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      529cc692
    • bdakin@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is · c2abd4d8
      bdakin@apple.com authored
      changed via delegate method, the page needs a full relayout and repaint
      -and corresponding-
      <rdar://problem/9059129>
      
      Reviewed by Darin Adler.
      
      Call into WebKitSystemInterface to associate the new painter with the existing 
      painter controller. Reset the scrollbar frame rects to the new thickness -- normally 
      this only happens when a scrollbar is created, so we have to reset the thickness 
      here to pick up the new theme thickness. Finally, force a full relayout and style 
      recall with setNeedsRecalcStyleInAllFrames()
      * platform/mac/ScrollAnimatorMac.mm:
      (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
      
      setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This 
      patch moves it to be a member function on Page so that it can be called from 
      FrameView when the scrollbar style changes.
      * page/FrameView.cpp:
      (WebCore::FrameView::setNeedsRecalcStyleInAllFrames):
      * page/FrameView.h:
      * page/Page.cpp:
      (WebCore::Page::setNeedsRecalcStyleInAllFrames):
      * page/Page.h:
      * page/Settings.cpp:
      (WebCore::Settings::setStandardFontFamily):
      (WebCore::Settings::setFixedFontFamily):
      (WebCore::Settings::setSerifFontFamily):
      (WebCore::Settings::setSansSerifFontFamily):
      (WebCore::Settings::setCursiveFontFamily):
      (WebCore::Settings::setFantasyFontFamily):
      (WebCore::Settings::setMinimumFontSize):
      (WebCore::Settings::setMinimumLogicalFontSize):
      (WebCore::Settings::setDefaultFontSize):
      (WebCore::Settings::setDefaultFixedFontSize):
      (WebCore::Settings::setTextAreasAreResizable):
      (WebCore::Settings::setAuthorAndUserStylesEnabled):
      (WebCore::Settings::setFontRenderingMode):
      (WebCore::Settings::setAcceleratedCompositingEnabled):
      (WebCore::Settings::setShowDebugBorders):
      (WebCore::Settings::setShowRepaintCounter):
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2abd4d8
    • dpranke@chromium.org's avatar
      2011-03-28 Dirk Pranke <dpranke@chromium.org> · 947ecf76
      dpranke@chromium.org authored
              RS=Tony Chang.
      
              r81977 moved FontPlatformData.h from
              WebCore/platform/graphics/cocoa to platform/graphics. This
              change updates the chromium build accordingly.
      
              https://bugs.webkit.org/show_bug.cgi?id=57281
      
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      947ecf76
    • scheib@chromium.org's avatar
      2011-03-28 Vincent Scheib <scheib@chromium.org> · 4379f5e1
      scheib@chromium.org authored
              Chromium rebaseline for r82144.
      
              * platform/chromium-linux/fast/block/positioning/058-expected.checksum:
              * platform/chromium-linux/fast/block/positioning/058-expected.png:
              * platform/chromium-win/fast/block/positioning/052-expected.txt:
              * platform/chromium-win/fast/block/positioning/058-expected.checksum:
              * platform/chromium-win/fast/block/positioning/058-expected.png:
              * platform/chromium-win/fast/block/positioning/058-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4379f5e1
    • adele@apple.com's avatar
      Added a few more stubs. · 59059ba6
      adele@apple.com authored
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (LayoutTestController::hasGrammarMarker):
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::hasGrammarMarker):
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      (LayoutTestController::hasGrammarMarker):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59059ba6
    • jer.noble@apple.com's avatar
      MediaPlayerPrivateAVFoundation should report that it supportsFullScreen() · aceccc44
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57249
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      
      LayoutTests:
      
      * platform/mac/media/controls-strict-expected.txt:
      * platform/mac/media/video-controls-rendering-expected.txt:
      * platform/mac/media/video-display-toggle-expected.txt:
      * platform/mac/media/video-no-audio-expected.txt:
      * platform/mac/media/video-zoom-controls-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aceccc44
    • adele@apple.com's avatar
      Build fix. · 730428cf
      adele@apple.com authored
      Source/WebKit/gtk: 
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
      
      Tools: 
      
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::hasGrammarMarker):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730428cf
    • eric.carlson@apple.com's avatar
      2011-03-28 Eric Carlson <eric.carlson@apple.com> · 7dc49650
      eric.carlson@apple.com authored
              Reviewed by Darin Adler.
      
              http streams don't always display video with AVFoundation backend
              https://bugs.webkit.org/show_bug.cgi?id=57203
      
              No new tests, we don't currently have tests for http live streams. Changes verified manually.
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender.
              (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine
                  if m_shouldPrepareToRender is set.
              (WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.
              * platform/graphics/MediaPlayer.h:
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until
                  m_isAllowedToRender has been set.
              (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,
                  it has logic to figure out when setup is required.
              (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't
                  using the preferred rendering mode because if we get a file's metadata between the
                  time supportsAcceleratedRendering() and paint() are called, we will allocate a software
                  renderer even when we prefer a layer backed renderer.
              (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of
                  an explicit list of key path names.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed
                  to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
                  callers need.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the 
                  player item, not the asset, because AVAsset.duration always returns an indefinite time
                  for all streaming files.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed
                  to assetMetadataKeyNames.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until
                  metadata is available.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off
                  into sizeChanged().
              (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize
                  until tracks is non-NULL so we have a size as early as possible.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of
                  KVO observable properties.
              (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to 
                  presentationSize change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dc49650
    • adele@apple.com's avatar
      ../WebKit/chromium: Build fix. · 7b3eeb70
      adele@apple.com authored
      * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
      Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
      
      ../WebKit/win: Build fix.
              
      * WebFrame.cpp: (WebFrame::hasSpellingMarker):
      Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b3eeb70
    • andersca@apple.com's avatar
      2011-03-28 Anders Carlsson <andersca@apple.com> · d8c145d6
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Search field focus ring is missing
              https://bugs.webkit.org/show_bug.cgi?id=57270
              <rdar://problem/8765555>
      
              Add an _automaticFocusRingDisabled method which returns YES.
      
              * platform/mac/ThemeMac.mm:
              (-[WebCoreFlippedView _automaticFocusRingDisabled]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c145d6
    • ggaren@apple.com's avatar
      2011-03-28 Geoffrey Garen <ggaren@apple.com> · a54a9660
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
              https://bugs.webkit.org/show_bug.cgi?id=56823
              
              Partial fix for most of the problem. (TOT still shows a regression, though.)
      
              * runtime/Heap.cpp:
              (JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of
              capacity(), since capacity() is O(n) relative to the size of the heap.
      
              In limited circumstances, capacity() is also worse than highWaterMark()
              for measuring extra cost relative to heap size, since capacity() only
              measures the *current* capacity of the heap, but the heap will grow if
              necessary to attain highWaterMark().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a54a9660
    • aestes@apple.com's avatar
      Check in failing results for embed-prefers-plugins-for-images.html on Leopard. · 0c470b88
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57137
      
      * platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c470b88
    • dglazkov@chromium.org's avatar
      2011-03-28 Dimitri Glazkov <dglazkov@chromium.org> · 55d04d18
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Move more events to EventDispatcher.
              https://bugs.webkit.org/show_bug.cgi?id=57247
      
              No functional changes, covered by existing tests.
      
              * dom/EventDispatcher.cpp:
              (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,
                  since it's not used anywhere outside of the EventDispatcher.
              (WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
              (WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
              (WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
              (WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules
                  as a static function.
              * dom/EventDispatcher.h: Updated decls.
              * dom/Node.cpp:
              (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher.
              (WebCore::Node::dispatchKeyEvent): Ditto.
              (WebCore::Node::dispatchWheelEvent): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55d04d18
    • adele@apple.com's avatar
      Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check... · aeeb7f1e
      adele@apple.com authored
      Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      Test: editing/spelling/grammar.html
      
      * WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
      * editing/Editor.cpp:
      (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar, 
       so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph.  In the case of this bug, 
       when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used 
       in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph 
       is the only one operated on when this information is used.
       (WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
      * editing/Editor.h:
      
      Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * WebView/WebFrame.mm:
      (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
      (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
      * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
      
      Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (hasGrammarMarkerCallback): Added.
      (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
      * DumpRenderTree/LayoutTestController.h:
      * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
      * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
      
      LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * editing/spelling/grammar-expected.txt: Added.
      * editing/spelling/grammar.html: Added.
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeeb7f1e
    • mitz@apple.com's avatar
      <rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements · a8157865
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48983
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/multicol/paginated-layer-crash.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
      into sync with updatePagination() after r68069.
      (WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.
      
      LayoutTests: 
      
      * fast/multicol/paginated-layer-crash-expected.txt: Added.
      * fast/multicol/paginated-layer-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8157865
    • bweinstein@apple.com's avatar
      WebKit2: Downloads started with DownloadCFNet::start never start · d7c45478
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57268
      
      Reviewed by Jon Honeycutt.
      
      * WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
      (WebKit::Download::start): Call CFURLDownloadStart on the download we create.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7c45478
    • scheib@chromium.org's avatar
      2011-03-28 Vincent Scheib <scheib@chromium.org> · c92e548e
      scheib@chromium.org authored
              Chromium rebaseline for r82123.
      
              * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
              * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
              * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
              * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
              * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
              * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
              * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
              * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c92e548e
    • ossy@webkit.org's avatar
      [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled · 24b10f34
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57087
      
      Reviewed by Benjamin Poulain.
      
      Trivial typo fix after r82082.
      
      * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
      (WTR::activateFonts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24b10f34
    • andersca@apple.com's avatar
      Fix Windows build. · c6e3aecb
      andersca@apple.com authored
      * Shared/ShareableBitmap.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6e3aecb
    • andersca@apple.com's avatar
      2011-03-28 Anders Carlsson <andersca@apple.com> · fcca0ef5
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Beep when pressing a menu key equivalent when a plug-in has focus
              https://bugs.webkit.org/show_bug.cgi?id=57264
              <rdar://problem/8935597>
      
              We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView inputContext]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcca0ef5
    • mjs@apple.com's avatar
      2011-03-28 Maciej Stachowiak <mjs@apple.com> · f62ffcd2
      mjs@apple.com authored
              Reviewed by Darin Adler' .
      
              URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
              https://bugs.webkit.org/show_bug.cgi?id=57220
      
              Test: http/tests/uri/username-with-no-hostname.html
      
              * platform/KURL.cpp:
              (WebCore::hostPortIsEmptyButUserPassIsNot):
              (WebCore::KURL::parse):
      2011-03-28  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin Adler' .
      
              URLSs with non-empty username but empty hostname are allowed to load
              https://bugs.webkit.org/show_bug.cgi?id=57220
      
              * http/tests/uri/username-with-no-hostname-expected.txt: Added.
              * http/tests/uri/username-with-no-hostname.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62ffcd2
    • andersca@apple.com's avatar
      2011-03-28 Anders Carlsson <andersca@apple.com> · 794770c7
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              CGImageRefs must hold a strong reference to underlying data
              https://bugs.webkit.org/show_bug.cgi?id=57263
              <rdar://problem/9146179>
      
              Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
              of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
              ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.
      
              * Platform/cg/CGUtilities.cpp:
              (WebKit::paintImage):
              Factor image painting code out into a separate function.
      
              (WebKit::paintBitmapContext):
              Call paintImage.
      
              * Shared/API/c/cg/WKImageCG.cpp:
              (WKImagemakeCGImage):
              Use ShareableBitmap::makeCGImageCopy.
      
              * Shared/ShareableBitmap.h:
              * Shared/cg/ShareableBitmapCG.cpp:
              (WebKit::ShareableBitmap::createGraphicsContext):
              (WebKit::ShareableBitmap::paint):
              (WebKit::ShareableBitmap::makeCGImageCopy):
              (WebKit::ShareableBitmap::makeCGImage):
              (WebKit::ShareableBitmap::releaseBitmapContextData):
              (WebKit::ShareableBitmap::releaseDataProviderData):
              Add makeCGImage and makeCGImageCopy.
      
              * Shared/cg/WebCoreArgumentCodersCG.cpp:
              (CoreIPC::createImage):
              Use ShareableBitmap::makeCGImage.
              
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::setDragImage):
              Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      794770c7
    • ap@apple.com's avatar
      Build fix. · 65dad565
      ap@apple.com authored
              * UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's
              "theEvent".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65dad565
    • hyatt@apple.com's avatar
      Update progressing layout tests on SL. · 6bee139d
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bee139d
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · d1ecae1d
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=57260
              Clean up text input code a little
      
      WebKit/mac:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::handleKeyboardEvent):
              (WebEditorClient::handleInputMethodKeydown):
              * WebView/WebHTMLViewInternal.h:
              Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
              anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
              and also possibly saves resulting commands for later execution.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
              return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
              WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
              handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
              because the first call resulted in no saved commands, becasue it's confusing and apparently
              useless (I couldn't find any broken behavior).
              (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
              (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
              (-[WebHTMLView doCommandBySelector:]): Ditto.
              (-[WebHTMLView insertText:]): Ditto.
      
              * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
              method on WebView.
      
      WebKit2:
              * UIProcess/API/mac/WKView.mm:
              (-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call.
              (-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent:
              and also WebKit1.
      
              * WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1ecae1d