Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 12 Jun, 2009 12 commits
    • eric@webkit.org's avatar
      2009-06-12 Dimitri Glazkov <dglazkov@chromium.org> · c2c22c62
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26191
        Remove xmath include in MathExtras.h, because it is not needed and also
        breaks VS2008 builds with TR1 turned on.

        * wtf/MathExtras.h: Removed xmath include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2c22c62
    • kov@webkit.org's avatar
      2009-06-12 Gustavo Noronha Silva <gns@gnome.org> · 017dd4a8
      kov@webkit.org authored 
              Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25599
        [GTK] Enable more tests

        Implement dumping of status callback.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      017dd4a8
    • pkasting@chromium.org's avatar
      2009-06-11 Peter Kasting <pkasting@google.com> · 6b9aef2c
      pkasting@chromium.org authored 
              Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
        Update Skia's ImageDecoder.h with a few changes designed to reduce the
        delta between specific implementations of ImageDecoder.h.  Update
        Cairo's ImageDecoder.h to sync up with the API changes in the Skia
        version in the last two chage sets.  Update Cairo's PNG/JPEG/GIF
        decoders to use the APIs as well.  All the Cairo image decoder changes
        are direct copies of the Skia versions except ImageDecoder.h, which is
        modified in the necessary ways for the differences between Cairo and
        Skia.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
        * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
        (WebCore::GIFImageDecoder::initFrameBuffer):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version.  Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b9aef2c
    • bfulgham@webkit.org's avatar
      2009-06-12 Brent Fulgham <bfulgham@webkit.org> · 147773fa
      bfulgham@webkit.org authored 
              Unreviewed build correction.

        Revert accidental configuration checkin.  Was not meant to
        be part of the last changeset.

        * config.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      147773fa
    • pkasting@chromium.org's avatar
      (Accidentally missed a couple email addresses in the last patch) · 7d6ee832
      pkasting@chromium.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d6ee832
    • bfulgham@webkit.org's avatar
      2009-06-12 Brent Fulgham <bfulgham@webkit.org> · 1d791242
      bfulgham@webkit.org authored 
              Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26353
        Corrects handling of Cairo fonts that were getting out of
        sync due to default copy construction.  Also refactors
        some incorrect platform font destruction code that belongs
        in the font object's destructor.

        * platform/graphics/win/FontPlatformData.h:
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataCairoWin.cpp:
        (WebCore::FontPlatformData::platformDataInit):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/win/SimpleFontDataWin.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d791242
    • pkasting@chromium.org's avatar
      JavaScriptCore: · a3a95dfb
      pkasting@chromium.org authored 
      2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Update my email address.
        * ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog: Update my email address.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3a95dfb
    • levin@chromium.org's avatar
      2009-06-12 Nate Chapin <japhet@google.com> · 072383c5
      levin@chromium.org authored 
              Reviewed by David Levin.

        Upstream V8Helpers.

        https://bugs.webkit.org/show_bug.cgi?id=26332

        * bindings/v8/V8Helpers.cpp: Added.
        (wrapNPObject): Moved from v8_helpers.cpp.
        (toV8Context): Moved from v8_helpers.cpp.
        (toV8Proxy): Moved from v8_helpers.cpp.
        * bindings/v8/V8Helpers.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      072383c5
    • kevino@webkit.org's avatar
      wx build fix. Adding JSONObject.cpp to the build. · ff20d137
      kevino@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff20d137
    • jberlin@apple.com's avatar
      Index: WebCore/ChangeLog · 50b7aa71
      jberlin@apple.com authored 
      ===================================================================
--- WebCore/ChangeLog	(revision 44622)
+++ WebCore/ChangeLog	(working copy)
@@ -1,3 +1,23 @@
+2009-06-12  Jessie Berlin  <jberlin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24792
+        rdar://problem/6933055
+
+        Changes the radius in which cursor movement around the 4 arrow icon
+        while pan-scrolling does not cause scrolling from around 10 pixels to
+        15 pixels, similar to what is found in IE and Firefox.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::setPanScrollCursor):
+        Factor out the no-pan-scroll radius.
+        * platform/ScrollView.h:
+        Create a constant for the no-pan-scroll radius.
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::panScrollFromPoint):
+        Factor out the no-pan-scroll radius.
+
 2009-06-12  Xan Lopez  <xlopez@igalia.com>
 
         Reviewed by Gustavo Noronha.
Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp	(revision 44622)
+++ WebCore/page/EventHandler.cpp	(working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
 
     // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
     // So we don't want to change the cursor over this area
-    const int noScrollRadius = 9;
-    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
-    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
-    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
-    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
+    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
          
     if (north) {
         if (east)
Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h	(revision 44622)
+++ WebCore/platform/ScrollView.h	(working copy)
@@ -214,7 +214,8 @@ public:
     virtual void hide();
     virtual void setParentVisible(bool);
     
-    // Pan scrolling methods.
+    // Pan scrolling.
+    static const int noPanScrollRadius = 15;
     void addPanScrollIcon(const IntPoint&);
     void removePanScrollIcon();
 
Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp	(revision 44622)
+++ WebCore/rendering/RenderLayer.cpp	(working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
     const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
     const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2
     
-    const int iconRadius = 10;
     Frame* frame = renderer()->document()->frame();
     if (!frame)
         return;
@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
     int xDelta = currentMousePosition.x() - sourcePoint.x();
     int yDelta = currentMousePosition.y() - sourcePoint.y();
 
-    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
+    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
         xDelta = 0;
-    if (abs(yDelta) < iconRadius)
+    if (abs(yDelta) < ScrollView::noPanScrollRadius)
         yDelta = 0;
 
     // Let's attenuate the speed for the short distances


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b7aa71
    • ariya@webkit.org's avatar
      2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 55dcf7ed
      ariya@webkit.org authored 
              Reviewed by Jan Michael Alonzo.

        [Qt] Fix build break
        https://bugs.webkit.org/show_bug.cgi?id=26340

        * JavaScriptCore.pri: Add JSONObject.cpp to LUT files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55dcf7ed
    • xan@webkit.org's avatar
      2009-06-12 Xan Lopez <xlopez@igalia.com> · f5b9f7d1
      xan@webkit.org authored 
              Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25609
        [GTK] Implement support for get_selection and get_n_selections

        Only use the VisibleSelection object if it actually belongs to the
        object we are using.

        This is pretty hacky-ish, but I can't seem to find a direct API to
        get the VisibleSelection for a given object, only the global one.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (selectionBelongsToObject):
        (webkit_accessible_text_get_n_selections):
        (webkit_accessible_text_get_selection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5b9f7d1
  3. 11 Jun, 2009 13 commits
  5. 10 Jun, 2009 15 commits