GitLab

https://bugs.webkit.org/show_bug.cgi?id=70889

Reviewed by Oliver Hunt.

Source/JavaScriptCore: 

* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):

LayoutTests: 

* fast/js/native-error-prototype-expected.txt:
* fast/js/script-tests/native-error-prototype.js:
* fast/js/script-tests/toString-recursion.js:
* fast/js/toString-recursion-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72397

Reviewed by Dan Bernstein.

Source/WebCore:

screenToWindow and windowToScreen already use root view coordinates everywhere, with the
exception of Mac WebKit1 which doesn't even implement the functions.

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper position]):
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::screenToRootView):
(WebCore::Chrome::rootViewToScreen):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::refresh):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenToRootView):
(WebKit::ChromeClientImpl::rootViewToScreen):
* src/ChromeClientImpl.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::screenToRootView):
(WebKit::WebPopupMenuImpl::rootViewToScreen):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::rootViewToScreen):
(WebCore::ChromeClientEfl::screenToRootView):
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::rootViewToScreen):
(WebKit::ChromeClient::screenToRootView):
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::screenToRootView):
(WebChromeClient::rootViewToScreen):

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::rootViewToScreen):
(WebCore::ChromeClientQt::screenToRootView):
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::rootViewToScreen):
(WebChromeClient::screenToRootView):
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::rootViewToScreen):
(WebKit::ChromeClientWinCE::screenToRootView):
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::rootViewToScreen):
(WebCore::ChromeClientWx::screenToRootView):
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::screenToRootView):
(WebKit::WebChromeClient::rootViewToScreen):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
https://bugs.webkit.org/show_bug.cgi?id=70421

Patch by Eugene Nalimov <enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object.
Before that there were no DOM objects that simultaneously were nodes and active objects.
DOM object could be held in one of 3 maps -- node map, active objects map, and all other
objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the
active DOM objects map only, its event listener could be garbage collected, because special
code that groups listeners with wrappers could handle only wrappers for objects in the node
map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be
garbage collected prematurely itself (see https://bugs.webkit.org/show_bug.cgi?id=66878).
Fix is to introduce 4th map -- active nodes map, and change the code accordingly.

Test: media/audio-garbage-collect.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GetDomMapFunction):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
(WebCore::DOMDataStore::weakNodeCallback):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::activeDomNodeMap):
* bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
* bindings/v8/V8DOMMap.cpp:
(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):
* bindings/v8/V8DOMMap.h:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::getWrapperSlow):
* bindings/v8/V8GCController.cpp:
(WebCore::GCPrologueSpecialCase):
(WebCore::void):
(WebCore::Node):
(WebCore::GCPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::GCEpilogueHelper::GCEpilogueSpecialCase):
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcEpilogue):
* dom/Node.h:
(WebCore::Node::isActiveNode):
* html/HTMLAudioElement.h:
(WebCore::HTMLAudioElement::isActiveNode):

LayoutTests: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
https://bugs.webkit.org/show_bug.cgi?id=70421 and https://bugs.webkit.org/show_bug.cgi?id=66878

Patch by Eugene Nalimov <enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

* media/audio-garbage-collect-expected.txt: Added.
* media/audio-garbage-collect.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=71518

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-15
Reviewed by Darin Fisher.

Adds stubs for Chromium port, and defines shared memory structure to
be used between browser and WebKit.

Includes just the parts that touch the public interface so they can be
reviewed separately. See also:
https://bugs.webkit.org/show_bug.cgi?id=69451 and
http://codereview.chromium.org/8345027

* WebKit.gyp:
* public/WebGamepad.h: Added.
(WebKit::WebGamepad::WebGamepad):
* public/WebGamepads.h: Added.
(WebKit::WebGamepads::WebGamepads):
* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::sampleGamepads):
* public/WebRuntimeFeatures.h:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed gardening.

* platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/mac/fast/table/multiple-captions-display-expected.txt:
* platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72399

Reviewed by Eric Carlson.

* media/track/track-cues-seeking.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Still waiting on mac results.

* platform/chromium-win/css3/flexbox/repaint-expected.png: Added.
* platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72398

Reviewed by Eric Carlson.

* media/track/track-webvtt-tc013-settings.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72369

Reviewed by Eric Carlson.

* media/track/track-webvtt-tc003-newlines.html:
* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/72387>

Reviewed by Darin Adler.

* platform/KURL.cpp:
(WebCore::KURL::init): Remove useless const.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72379

Reviewed by Adam Barth.

* editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
* platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
* platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
* platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
* platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

rather than the timing of the events (since actual timing can not be guaranteed).
https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Tony Gentilcore.

* media/track/track-cues-cuechange-expected.txt:
* media/track/track-cues-cuechange.html:
* media/track/track-cues-enter-exit-expected.txt:
* media/track/track-cues-enter-exit.html:
* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72325

Reviewed by Ojan Vafai.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=65796

This adds test to ensure that the bug does not reappear unnoticed.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-15
Reviewed by Nikolas Zimmermann.

* svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
* svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
* svg/custom/zero-path-square-cap-rendering3.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72338

Reviewed by Dan Bernstein.

Source/WebCore:

Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
are in root view coordinates by changing contentsToWindow calls to contentsToRootView.

In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.

* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
* platform/chromium/FramelessScrollView.cpp:
(WebCore::FramelessScrollView::invalidateRect):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateRootView):
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
* src/ChromeClientImpl.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::invalidateRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):
* src/WebPopupMenuImpl.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::invalidateRootView):
(WebCore::ChromeClientQt::invalidateContentsAndRootView):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::invalidateRootView):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndRootView):
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateRootView):
(WebKit::WebChromeClient::invalidateContentsAndRootView):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72391

Reviewed by Ojan Vafai.

These tests had <div id="console"></p> in them which causes a lot of extra whitespace.

* fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html:
* fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-change-child-node.html:
* fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html:
* fast/dom/HTMLElement/attr-dir-auto-change-text.html:
* fast/dom/HTMLElement/attr-dir-auto-children-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-children.html:
* fast/dom/HTMLElement/attr-dir-auto-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html:
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html:
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:
* fast/dom/HTMLElement/attr-dir-auto-text-form-control.html:
* fast/dom/HTMLElement/attr-dir-auto.html:
* fast/dom/HTMLElement/attr-dir-value-change-expected.txt:
* fast/dom/HTMLElement/attr-dir-value-change.html:
* fast/dom/HTMLElement/attr-empty-string-expected.txt:
* fast/dom/HTMLElement/attr-empty-string.html:
* fast/dom/HTMLElement/attr-false-string-expected.txt:
* fast/dom/HTMLElement/attr-false-string.html:
* fast/dom/HTMLElement/attr-invalid-string-expected.txt:
* fast/dom/HTMLElement/attr-invalid-string.html:
* fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt:
* fast/dom/HTMLElement/attr-missing-ancestor-false.html:
* fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt:
* fast/dom/HTMLElement/attr-missing-ancestor-true.html:
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt:
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html:
* fast/dom/HTMLElement/attr-missing-parent-false-expected.txt:
* fast/dom/HTMLElement/attr-missing-parent-false.html:
* fast/dom/HTMLElement/attr-missing-parent-true-expected.txt:
* fast/dom/HTMLElement/attr-missing-parent-true.html:
* fast/dom/HTMLElement/attr-true-string-expected.txt:
* fast/dom/HTMLElement/attr-true-string.html:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html:
* fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt:
* fast/dom/HTMLElement/iscontenteditable-designmodeon.html:
* fast/dom/HTMLElement/set-false-expected.txt:
* fast/dom/HTMLElement/set-false.html:
* fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
* fast/dom/HTMLElement/set-inherit-parent-false.html:
* fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
* fast/dom/HTMLElement/set-inherit-parent-true.html:
* fast/dom/HTMLElement/set-invalid-value-expected.txt:
* fast/dom/HTMLElement/set-invalid-value.html:
* fast/dom/HTMLElement/set-true-expected.txt:
* fast/dom/HTMLElement/set-true.html:
* fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
* fast/dom/HTMLElement/set-value-caseinsensitive.html:
* fast/dom/Orientation/create-event-orientationchange.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/72356>

Reviewed by Daniel Bates.

* Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
Extracted common package logic into RunLeaks.pm.  Fixed call to
RunLeaks::parseLeaksOutput().
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72349

Patch by Peter Kasting <pkasting@google.com> on 2011-11-15
Reviewed by Adam Roben.

* Scripts/VCSUtils.pm:
(isSVNDirectory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
https://bugs.webkit.org/show_bug.cgi?id=61528

Patch by Philip Rogers <pdr@google.com> on 2011-11-15
Reviewed by Stephen White.

Source/WebCore:

Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html
       fast/canvas/2d.text.draw.fill.maxWidth.negative.html
       fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
       fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

* fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.gradient.html: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.veryLarge-expected.txt: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.verySmall-expected.txt: Added.
* fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html: Added.
* platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
* platform/qt/Skipped:
* resources/Ahem.ttf: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72258

Reviewed by Martin Robinson.

Source/WebCore:

Add common download errors to ErrorsGtk.

* platform/gtk/ErrorsGtk.cpp:
(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):
* platform/gtk/ErrorsGtk.h:

Source/WebKit/gtk:

Use errors from WebCore to emit the error signals.

* webkit/webkitdownload.cpp:
(webkitDownloadEmitError): Helper function that emits the error
signal for the given ResourceError.
(webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
(webkit_download_cancel): Ditto.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Ditto.
(webkit_download_error): Ditto.

Source/WebKit2:

* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked):
(WebKit::DownloadClient::cannotShowURL):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72137

Source/WebCore:

Use Skia to draw vertical text. This is much
faster and has higher fidelity than the old method
of drawing text on a path.

The graphics context passed to Skia has been
rotated 90 degrees but the character advances
have not, so it is necessary to unrotate the canvas,
and re-rotate the positions.

This generates correct output (or, at least,
consistent with Chromium CG on Mac) for all vertical
text tests, one of which is mentioned below.

Reviewed by Stephen White.

Test: fast/writing-mode/text-orientation-basic.html

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

LayoutTests:

Ignore vertical text tests on Skia on Mac for now.

Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72381

Reviewed by Tony Gentilcore.

* media/media-blocked-by-willsendrequest.html:
    Don't assume the media events will be dispatched before the window 'load' event.
* platform/chromium/test_expectations.txt:
    Don't skip media/media-blocked-by-willsendrequest.html. 


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-15
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Unskip 24 tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=37325

Patch by Philip Rogers <pdr@google.com> on 2011-11-15
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/svg-padding.xhtml

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

* svg/hittest/svg-padding-expected.txt: Added.
* svg/hittest/svg-padding.xhtml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72377

re-landing r100269.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

* src/js/DevTools.js:
(WebInspector.setInspectedTabId):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72270

Reviewed by NOBODY.

* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72381

* platform/chromium/test_expectations.txt: Mark test as flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/100269
https://bugs.webkit.org/show_bug.cgi?id=72383

"Broke dozens of tests due to exception in loadingFinished"
(Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

* src/js/DevTools.js:
():
(devtools.domContentLoaded):
(WebInspector.UIString):
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=15598

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The "font" CSS property is turned into a real shorthand, as its longhands used to float around
in the resulting style declaration without any reference to their underlying "font" property.

Test: fast/css/font-shorthand.html

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
(WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
(WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.
* css/CSSMutableStyleDeclaration.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
(WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.
* css/CSSParser.h: Added optional "implicit" parameter to addProperty().
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap): Added "font" shorthand map entry.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
(WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.
* css/CSSStyleSelector.h: Made updateFont() public.
* css/FontValue.cpp:
(WebCore::FontValue::customCssText): Made use of StringBuilder.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.

LayoutTests:

* fast/css/font-shorthand-expected.txt: Added.
* fast/css/font-shorthand.html: Added.
* fast/inspector-support/style-expected.txt:
* fast/inspector-support/style.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72297

Unreviewed, GTK rebaseline after r100159.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72262

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-15
Reviewed by Antonio Gomes.

No new tests needed, this is purely cosmetic.

* platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
* platform/qt/RenderThemeQStyle.h:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
since the mobile theme actually didn't do this.
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72377

This includes support for themed toolbar, remote debugging routines,
removes a couple of obsolete overrides from the DevTools.js

Reviewed by Yury Semikhatsky.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

* src/js/DevTools.js:
(WebInspector.setInspectedTabId):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72364

* platform/qt/Skipped: Skip failing tests until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72376

* platform/chromium/test_expectations.txt: Mark test flaky on win.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100267 268f45cc-cd09-0410-ab3c-d52691b4dbfc