1. 01 Oct, 2009 1 commit
    • bdakin@apple.com's avatar
      WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box- · c20916e7
      bdakin@apple.com authored
      shadow (29927)
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=29927
      
      Reviewed by Dan Bernstein.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      (WebCore::ShadowParseContext::ShadowParseContext):
      (WebCore::ShadowParseContext::commitValue):
      (WebCore::ShadowParseContext::commitLength):
      (WebCore::ShadowParseContext::commitColor):
      (WebCore::cssPropertyID):
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * page/animation/AnimationBase.cpp:
      (WebCore::ensurePropertyMap):
      
      LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor 
      prefix to box-shadow (29927)
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=29927
      
      Reviewed by Dan Bernstein.
      
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c20916e7
  2. 17 Sep, 2009 1 commit
  3. 18 Aug, 2009 1 commit
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe · 4f4d58b2
      mitz@apple.com authored
      Update Windows and Qt results after r47462.
      
      * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f4d58b2
  4. 31 Jul, 2009 1 commit
  5. 29 Jul, 2009 1 commit
  6. 28 Jul, 2009 1 commit
  7. 23 Jul, 2009 2 commits
    • mrowe@apple.com's avatar
      Update layout test results for the addition of a new computed style property in r46285. · d8a4e4af
      mrowe@apple.com authored
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8a4e4af
    • hausmann@webkit.org's avatar
      2009-07-23 Simon Hausmann <simon.hausmann@nokia.com> · be79664c
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Rebaseline the Qt results for computed-style.html and
              computed-style-without-rendered.html after r46240, similar to r46252.
      
              * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be79664c
  8. 02 Jul, 2009 1 commit
    • hausmann@webkit.org's avatar
      WebKitTools: · 361ca3d1
      hausmann@webkit.org authored
      2009-07-02  Antonio Gomes   <antonio.gomes@openbossa.org>
      
              Reviewed by Simon Hausmann.
      
              https://bugs.webkit.org/show_bug.cgi?id=26896
      
              [Qt] Set DRT's default fontsize to 13.
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::WebPage::WebPage):
      
      LayoutTests:
      
      2009-07-02  Antonio Gomes   <antonio.gomes@openbossa.org>
      
              Reviewed by Simon Hausmann.
      
              https://bugs.webkit.org/show_bug.cgi?id=26896
      
              Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
              files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .
      
              * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      361ca3d1
  9. 30 Jun, 2009 1 commit
  10. 05 Mar, 2009 1 commit
    • eric@webkit.org's avatar
      Rubber-stamped by Adam Roben. · 6520a6d0
      eric@webkit.org authored
              Move all of the fast/css/*computed* tests into fast/css/getComputedStyle
              in preparation for adding a bunch more getComputedStyle tests.
      
              * fast/css/getComputedStyle/computed-style-display-none-expected.txt: Renamed from LayoutTests/fast/css/computed-style-display-none-expected.txt.
              * fast/css/getComputedStyle/computed-style-display-none.html: Renamed from LayoutTests/fast/css/computed-style-display-none.html.
              * fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/fast/css/computed-style-expected.txt.
              * fast/css/getComputedStyle/computed-style-negative-top-expected.txt: Renamed from LayoutTests/fast/css/computed-style-negative-top-expected.txt.
              * fast/css/getComputedStyle/computed-style-negative-top.html: Renamed from LayoutTests/fast/css/computed-style-negative-top.html.
              * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
              * fast/css/getComputedStyle/computed-style-without-renderer.html: Renamed from LayoutTests/fast/css/computed-style-without-renderer.html.
              * fast/css/getComputedStyle/computed-style.html: Renamed from LayoutTests/fast/css/computed-style.html.
              * fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-position-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-background-position.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-position.html.
              * fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-size-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-background-size.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-size.html.
              * fast/css/getComputedStyle/getComputedStyle-border-box-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-box-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-border-box.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-box.html.
              * fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-image-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-border-image.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-image.html.
              * fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-border-spacing.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing.html.
              * fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-borderRadius.html: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius.html.
              * fast/css/getComputedStyle/getComputedStyle-relayout-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-relayout-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-relayout.html: Renamed from LayoutTests/fast/css/getComputedStyle-relayout.html.
              * fast/css/getComputedStyle/getComputedStyle-transform-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-transform-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-transform.html: Renamed from LayoutTests/fast/css/getComputedStyle-transform.html.
              * fast/css/getComputedStyle/getComputedStyle-zIndex-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-zIndex-auto.html: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto.html.
              * fast/css/marginComputedStyle.html: Removed.
              * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-expected.txt.
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt.
              * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.checksum.
              * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.png.
              * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.txt.
              * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-expected.txt.
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-without-renderer-expected.txt.
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-expected.txt.
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6520a6d0
  11. 03 Oct, 2007 1 commit
  12. 19 Sep, 2007 1 commit
    • adele's avatar
      WebCore: · 79c8ed27
      adele authored
              Reviewed by Maciej.
      
              Fix for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
              and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
      
              Tests:
      
              This fix has a few steps:
              1) Removes the ignore value for the -webkit-user-select property.  We now decide when to prevent selection from starting by calling canStartSelection on the node.
              2) Implements canStartSelection which returns false for all elements that used to have -webkit-user-select:ignore set, true for content editable nodes, 
                 and walks up the tree to ask the parent before allowing selection to be started on any other nodes.
              3) We used to disallow selection from starting within -webkit-user-select:none blocks, but now we only use canStartSelection for that.  This will allow easy selections
                 in cases like iChat where there's a mix of selectable and non-selectable content.
              4) Makes -webkit-user-select inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value.
      
      
              * css/html4.css: Removed all usage of -webkit-user-select: ignore.  This is now handled internally with canStartSelection().
                Now -webkit-user-select won't be unintentionally overridden by nodes that don't want to allow selection to be started, but do want to honor the -webkit-user-select to
                determine whether or not selection is allowed at all.
      
              * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
                Don't try to determine whether selection is allowed inside the root node here.  VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions.
              
              * dom/Node.h:
              * dom/Node.cpp: (WebCore::Node::canStartSelection): Added. Always allows selection to be started in a content editable node.  If there's a parent, ask the parent if starting a selection is allowed.
                If there's no parent, default to allowing selection.
              * html/HTMLAnchorElement.h:
              * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::canStartSelection): Added. If its not a link, then calls the base class. Disallows selection for non-editable links.
                Allows selection for editable links.
                This logic used to be done in CSSStyleSelector by changing the user-select property.
              * html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canStartSelection): Added. Disallows selection from starting in buttons.
              * html/HTMLImageElement.h: (WebCore::HTMLImageElement::canStartSelection): Added. Disallows selection from starting in images.
              * html/HTMLInputElement.h:
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canStartSelection): Added. Disallows selection from anything that's not a text field.  Text fields call up to the base class.
                When they're editable, text controls will always be selectable because of the case for content editable content. Otherwise, they'll respect their parent element's decision about starting a selection. 
              * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canStartSelection): Added. Disallows selection from starting in popup buttons.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect().
              (WebCore::EventHandler::handleMousePressEventTripleClick): ditto.
              (WebCore::EventHandler::handleMousePressEventSingleClick): ditto.
              (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect.
              (WebCore::EventHandler::selectCursor): Paint an ibeam in any region that allows you to click to create a selection.
              (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and calls canStartSelection instead of checking the user-select property.
              (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
              * page/EventHandler.h:
              * page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Calls canStartSelection instead of checking the user-select property to decide when to prevent selection creation. 
              * rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): ditto.
              * rendering/RenderObject.h: Removed helper methods that are no longer needed.
      
              * rendering/RenderStyle.h: Made userSelect inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited 
                anyways since we already allowed the text value to override the none value.
                Removed the SELECT_AUTO and SELECT_IGNORE values since they're no longer used.
              (WebCore::):
              (WebCore::RenderStyle::userSelect):
              (WebCore::RenderStyle::setUserSelect):
              (WebCore::RenderStyle::initialUserSelect):
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareNonInheritedData::operator==):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleRareInheritedData::operator==):
              (WebCore::RenderStyle::diff):
      
              * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Remove case for SELECT_AUTO and SELECT_IGNORE
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):  Remove adjustment for links.  This is now handled in HTMLAnchorElement::canStartSelection.
              (WebCore::CSSStyleSelector::applyProperty): Map CSS_VAL_AUTO to SELECT_TEXT.  Remove CSS_VAL_IGNORE.
      
      LayoutTests:
      
              Reviewed by Maciej.
      
              Tests for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
              and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
      
              * fast/css/computed-style-expected.txt: Updated for default -webkit-user-select value.
              * fast/css/computed-style-without-renderer-expected.txt: ditto.
      
              * editing/selection/5333725.html: Re-enabled.
              * editing/selection/5333725.html-disabled: Removed.
      
              * editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Removed. Adjusted this test to be more specific and renamed it to textfield-inside-anchor. 
              * editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Removed. 
              * fast/forms/textfield-inside-anchor-expected.txt: Added.
              * fast/forms/textfield-inside-anchor.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79c8ed27
  13. 10 Sep, 2007 1 commit
    • justing's avatar
      WebCore: · 91d64cca
      justing authored
              Reviewed by Darin.
      
              <rdar://problem/5467405> 
              Revert back behavior of -webkit-user-select to fix widget selection problems
              
              Rolled out r25086 and r25057.  I will be re-opening:
              <rdar://problem/5333725> -webkit-user-select: none makes selection difficult
              Which we will either to defer or fix by introducing a new value of -webkit-user-select.
              <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
              Which we will either defer or fix with Adele's patch that doesn't involve making 
              -webkit-user-select inherited.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectAll):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::canMouseDownStartSelect):
              * page/EventHandler.h:
              * rendering/RenderObject.cpp:
              (WebCore::selectStartNode):
              (WebCore::RenderObject::canSelect):
              (WebCore::RenderObject::shouldSelect):
              (WebCore::RenderObject::draggableNode):
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareNonInheritedData::operator==):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleRareInheritedData::operator==):
              (WebCore::RenderStyle::diff):
              * rendering/RenderStyle.h:
              (WebCore::):
              (WebCore::RenderStyle::userSelect):
              (WebCore::RenderStyle::setUserSelect):
              (WebCore::RenderStyle::initialUserSelect):
      
      LayoutTests:
      
              Reviewed by Darin.
              
              <rdar://problem/5467405> 
              Revert back behavior of -webkit-user-select to fix widget selection problems
      
              * editing/selection/5333725.html: Removed.
              * editing/selection/5333725.html-disabled: Added.
              * editing/selection/user-select-text-inside-user-select-ignore.html: Removed.
              * editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Added.
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91d64cca
  14. 14 Aug, 2007 2 commits
    • adele's avatar
      LayoutTests: · 1b756f15
      adele authored
              Reviewed by Maciej.
      
              Test for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
      
              * editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Added.
              * editing/selection/user-select-text-inside-user-select-ignore.html: Added.
              * fast/css/computed-style-expected.txt: Updated now that we've eliminated the auto value.
              * fast/css/computed-style-without-renderer-expected.txt: ditto.
      
      WebCore:
      
              Reviewed by Maciej.
      
              Fix for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
      
              This change makes -webkit-user-select an inherited css property.  For "user-select: none" we were already 
              acting like it was an inheritable property, where we let user-select:text on the children override its parent's user-select:none.
              By making user-select really inherited (instead of inherited for some values), we eliminate the need for crawling up the tree to see 
              if an ancestor has user-select ignore set.
      
              * page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect):
                Now that user-select is inherited, you don't need to walk up the render tree looking for ancestors with user-select:ignore set.
      
              * css/CSSStyleSelector.cpp: Eliminate SELECT_AUTO.
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              (WebCore::CSSStyleSelector::applyProperty):
              * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
              * rendering/RenderStyle.h:
              (WebCore::): Eliminate SELECT_AUTO.  Make userSelect inherited.
              (WebCore::RenderStyle::userSelect):
              (WebCore::RenderStyle::setUserSelect):
              (WebCore::RenderStyle::initialUserSelect):
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareNonInheritedData::operator==):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleRareInheritedData::operator==):
              (WebCore::RenderStyle::diff):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b756f15
    • antti's avatar
      LayoutTests: · edcfa244
      antti authored
              Reviewed by Darin.
              
              Add test for <rdar://problem/5143183>
              Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y
              
              Also update a few tests to expect background-position instead of background-position-x/y
      
              * fast/css/background-position-serialize-expected.txt: Added.
              * fast/css/background-position-serialize.html: Added.
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/remove-shorthand-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
              
              Fix <rdar://problem/5143183>
              Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y
              
              Safari was using non-standard background-position-x/y properties when serializing style, both normal 
              and computed. As a result Safari generated CSS would not render correctly in Firefox. 
              
              Use standard background-position property instead.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::cssText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edcfa244
  15. 21 Jul, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 0f38e08e
      weinig authored
              Reviewed by Mitz.
      
              Update tests for <rdar://problem/5352013>
              The computed style for background-position is wrong for the initial value
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-background-position-expected.txt:
      
      WebCore:
      
              Reviewed by Mitz.
      
              Patch for <rdar://problem/5352013>
              The computed style for background-position is wrong for the initial value
      
              - Set the initial value for background-position-x and background-position-y (and
                therefore background-position) to 0% instead of 0px.
      
              * rendering/RenderStyle.cpp:
              (WebCore::BackgroundLayer::BackgroundLayer):
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::initialBackgroundXPosition):
              (WebCore::RenderStyle::initialBackgroundYPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f38e08e
  16. 20 Jul, 2007 3 commits
    • weinig's avatar
      LayoutTests: · 243792c5
      weinig authored
              Reviewed by Beth Dakin.
      
              Tests for <rdar://problem/5351901>
              Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-background-position-expected.txt: Added.
              * fast/css/getComputedStyle-background-position.html: Added.
      
      WebCore:
      
              Reviewed by Beth Dakin.
      
              Fix for <rdar://problem/5351901>
              Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
      
              - Return a space separated CSSValueList for background-position
                instead of a CSSPrimitiveValue (string type).
              - Remove the "else if (renderer)" case as it never returns a different
                value than just calling length.value().
              - Make background-position-x and background-position-y behave like
                background-position.  Fix case of initial value return 'auto' instead
                of 0.
      
              Test: fast/css/getComputedStyle-background-position.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243792c5
    • weinig's avatar
      LayoutTests: · ec39da16
      weinig authored
              Reviewed by Darin.
      
              Add tests for <rdar://problem/5351252>
              Computed value for -webkit-background-size and border-spacing
              should be space separated CSSValueLists.
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-background-size-expected.txt: Added.
              * fast/css/getComputedStyle-background-size.html: Added.
              * fast/css/getComputedStyle-border-spacing-expected.txt: Added.
              * fast/css/getComputedStyle-border-spacing.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/5351252>
              Computed value for -webkit-background-size and border-spacing
              should be space separated CSSValueLists.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec39da16
    • weinig's avatar
      LayoutTests: · a4beec1e
      weinig authored
              Reviewed by Beth Dakin.
      
              Computed style for border radii should return a CSSValueList instead 
              of CSSPrimitiveValue (with a Pair type) when the radii are not the same. 
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-borderRadius-expected.txt: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius-expected.txt.
              * fast/css/getComputedStyle-borderRadius.html: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius.html.
              * fast/dom/getComputedStyle-borderRadius-expected.txt: Removed.
              * fast/dom/getComputedStyle-borderRadius.html: Removed.
      
      WebCore:
      
              Reviewed by Beth Dakin.
      
              Update for fix for http://bugs.webkit.org/show_bug.cgi?id=14646
              <rdar://problem/5340449>
      
              - Return a CSSValueList instead of CSSValue (with a Pair type) for
                computed values of border radii.
              - Add ability to CSSValueList to print out a space separated list
                instead of a comma.
              - Add border radii to list of computed styles that we create and can
                iterate over.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::getBorderRadiusCornerValue):
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::CSSValueList):
              (WebCore::CSSValueList::cssText):
              * css/CSSValueList.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4beec1e
  17. 08 Jul, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 1a99c50f
      weinig authored
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12384
                getComputedStyle with td.style.display='none' reports '' for all properties except display
      
              * fast/css/computed-style-without-renderer-expected.txt: Added.
              * fast/css/computed-style-without-renderer.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12384
                getComputedStyle with td.style.display='none' reports '' for all properties except display
      
              Test: fast/css/computed-style-without-renderer.html
      
              Implement rich computed style for elements that do not have a renderer.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of
              a RenderObject.
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
              use the computed style returned by the node instead of going through the
              renderer. Changed properties that compute by measuring the renderer to
              fall back on returning the length from the RenderStyle if a renderer does
              not exist.
              (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number
              of properties we can compute even if the element has no renderer.
              (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed
              to use the computed style returned by the node instead of going through the
              renderer.
              * dom/Element.cpp:
              (WebCore::ElementRareData::ElementRareData): Added a computed style member,
              used to cache computed style for elements that do not have a renderer.
              (WebCore::ElementRareData::resetComputedStyle): Added.
              (WebCore::Element::~Element): Delete the cached computed style.
              (WebCore::Element::recalcStyle): Added code to delete the cached computed
              style when necessary.
              (WebCore::Element::computedStyle): Added. Returns the style used in rendering
              the element, if available. Otherwise uses the style selector to compute style
              for the element.
              * dom/Element.h:
              * dom/Node.cpp:
              (WebCore::Node::computedStyle): Added. This method returns either the style
              used in rendering the node, or the style that would be used if the node
              had a renderer.
              * dom/Node.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a99c50f