1. 01 Oct, 2009 40 commits
    • bdakin@apple.com's avatar
      WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box- · c20916e7
      bdakin@apple.com authored
      shadow (29927)
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=29927
      
      Reviewed by Dan Bernstein.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      (WebCore::ShadowParseContext::ShadowParseContext):
      (WebCore::ShadowParseContext::commitValue):
      (WebCore::ShadowParseContext::commitLength):
      (WebCore::ShadowParseContext::commitColor):
      (WebCore::cssPropertyID):
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * page/animation/AnimationBase.cpp:
      (WebCore::ensurePropertyMap):
      
      LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor 
      prefix to box-shadow (29927)
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=29927
      
      Reviewed by Dan Bernstein.
      
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c20916e7
    • eric@webkit.org's avatar
      2009-10-01 Yaar Schnitman <yaar@chromium.org> · 34cd2f31
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Make it possible to override the list of feature defines when building
              downstream.
      
              https://bugs.webkit.org/show_bug.cgi?id=29979
      
              * chromium/features.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34cd2f31
    • bweinstein@apple.com's avatar
      2009-10-01 Brian Weinstein <bweinstein@apple.com> · cdaf6f6b
      bweinstein@apple.com authored
              Rubber-stamped by Adam Roben.
      
              Added fast/inline/relative-positioned-overflow.html to Skipped list because
              it hits an asssert in Windows debug builds. Assertion failure is being tracked
              by <https://bugs.webkit.org/show_bug.cgi?id=29966>.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdaf6f6b
    • bdakin@apple.com's avatar
      Rubber-stamped by Sam Weinig. · b64d4612
      bdakin@apple.com authored
      Appeasing the Bot. 
      
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b64d4612
    • bweinstein@apple.com's avatar
      2009-10-01 Brian Weinstein <bweinstein@apple.com> · 16df99d7
      bweinstein@apple.com authored
              Reviewed by Beth Dakin.
      
              Update expected Windows results after new CSS Text Kerning changes.
      
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/win/fast/css/text-rendering-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16df99d7
    • xan@webkit.org's avatar
      2009-10-01 Xan Lopez <xlopez@igalia.com> · 527fe3ad
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Set the type for the fake event, otherwise the test ASSERTs in
              debug builds.
      
              * tests/testhittestresult.c:
              (load_status_cb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      527fe3ad
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 73e707be
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Disable HTTP loading tests that fail on the buildbot.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e707be
    • atwilson@chromium.org's avatar
      REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot · ac8b946a
      atwilson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29344
      
      Reviewed by Eric Seidel.
      
      * fast/workers/resources/dedicated-worker-lifecycle.js:
      (runTests):
      Allocate objects on the stack to try to force a GC to eliminate flakiness.
      * fast/workers/resources/worker-util.js:
      (gc):
      Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
      (waitUntilThreadCountMatches):
      Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac8b946a
    • bdakin@apple.com's avatar
      Rubber-stamped by Sam Weinig. · 52176259
      bdakin@apple.com authored
      At bad merge at some point in the development of my patch must have 
      put TextRenderMode.h in a weird spot in the xcodeproj. Moving it 
      back where it belongs!
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52176259
    • abarth@webkit.org's avatar
      2009-10-01 Adam Barth <abarth@webkit.org> · 5d1a968f
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove FrameLoader::schedule* APIs
              https://bugs.webkit.org/show_bug.cgi?id=29950
      
              Change clients of FrameLoader::schedule* to call redirectScheduler
              directly.
      
              No behavior change.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::createWindow):
              (WebCore::JSDOMWindow::open):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::navigateIfAllowed):
              (WebCore::JSLocation::reload):
              * bindings/v8/V8Utilities.cpp:
              (WebCore::navigateIfAllowed):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::createWindow):
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8LocationCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              (WebCore::Document::processHttpEquiv):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::write):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::receivedFirstData):
              * loader/FrameLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              * page/History.cpp:
              (WebCore::History::back):
              (WebCore::History::forward):
              (WebCore::History::go):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d1a968f
    • bdakin@apple.com's avatar
      Just removing a comment I accidentally committed earlier. · 1a1e4d53
      bdakin@apple.com authored
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::getCFStringAttributes):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a1e4d53
    • jorlow@chromium.org's avatar
      2009-09-30 Jeremy Orlow <jorlow@chromium.org> · 5ab43290
      jorlow@chromium.org authored
              Reviewed by Darin Adler.
      
              Clean up use of const and mutable in StorageMap
              https://bugs.webkit.org/show_bug.cgi?id=29933
      
              What's the point of having every single member variable be mutable and nearly
              every method be const?  Let's clean it up.
      
              * storage/StorageMap.cpp:
              (WebCore::StorageMap::setIteratorToIndex):
              (WebCore::StorageMap::key):
              (WebCore::StorageMap::importItem):
              * storage/StorageMap.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ab43290
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 409426a4
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable Local tests for Qt.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409426a4
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 70842645
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP loading tests for Qt.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70842645
    • bdakin@apple.com's avatar
      WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and · 3a72daae
      bdakin@apple.com authored
      ligature
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=6136
      
      Reviewed by Dave Hyatt.
      
      This patch makes the SVG CSS property text-rendering work with any 
      HTML, much like it does in Firefox. It accepts four possible input 
      values: auto, optimizeSpeed, optimizeLegibility, and 
      geometricPrecision. Right now, in this implementation, here is what 
      those values correspond to:
      
      auto = optimizeSpeed = what we normally when the value's not set
      optimizeLegibility = geometricPrecision = ligatures + kerning
      
      Add new file TextRenderingMode.h to the project files.
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      
      CSS support for the new CSSPropertyTextRendering
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSValueKeywords.in:
      
      All the old SVG CSS support for this property can go away. When 
      it's used in SVG, it will just fall into the normal HTML case.
      * css/SVGCSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
      * css/SVGCSSParser.cpp:
      (WebCore::CSSParser::parseSVGValue):
      * css/SVGCSSPropertyNames.in:
      * css/SVGCSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applySVGProperty):
      * css/SVGCSSValueKeywords.in:
      
      FontDescription stores the m_textRendering bit.
      * platform/graphics/FontDescription.h:
      (WebCore::FontDescription::FontDescription):
      (WebCore::FontDescription::textRenderingMode):
      (WebCore::FontDescription::setTextRenderingMode):
      (WebCore::FontDescription::operator==):
      
      We want to fall into the complex text rendering code path if 
      kerning and ligatures have been enabled with this property.
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::canUseGlyphCache):
      
      Now takes a TextRenderingMode as a parameter.
      * platform/graphics/SimpleFontData.h:
      
      New header for the enum.
      * platform/graphics/TextRenderingMode.h: Added.
      (WebCore::):
      
      getCFStringAttributes() now takes a TextRenderingMode as an 
      attribute.
      * platform/graphics/mac/CoreTextController.cpp:
      (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
      
      Enable kerning and ligatures whenever the TextRenderingMode is 
      OptimizeLegibility or GeometricPrecision
      * platform/graphics/mac/FontMacATSUI.mm:
      (WebCore::disableLigatures):
      (WebCore::initializeATSUStyle):
      (WebCore::ATSULayoutParameters::initialize):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::getCFStringAttributes):
      
      More SVG CSS stuff that isn't needed anymore since SVG will use the 
      new HTML CSS implementation.
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::InheritedFlags::operator==):
      (WebCore::SVGRenderStyle::setBitDefaults):
      * rendering/style/SVGRenderStyleDefs.h:
      
      LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and 
      ligature
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=6136
      
      Reviewed by Dave Hyatt.
      
      New tests.
      * fast/css/parsing-text-rendering-expected.txt: Added.
      * fast/css/parsing-text-rendering.html: Added.
      * fast/css/resources/parsing-text-rendering.js: Added.
      (test):
      * fast/css/text-rendering.html: Added.
      * platform/mac/fast/css/text-rendering-expected.checksum: Added.
      * platform/mac/fast/css/text-rendering-expected.png: Added.
      * platform/mac/fast/css/text-rendering-expected.txt: Added.
      
      New and improved results.
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a72daae
    • eric@webkit.org's avatar
      2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com> · e59a07dd
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=29187
      
              Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
              bug regarding templated classes.
      
              The compiler bug is reported at:
              https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
      
              The change will be reverted when the above bug is fixed in winscw compiler.
      
              * wtf/ListRefPtr.h:
              (WTF::::~ListRefPtr):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e59a07dd
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · b539bdb8
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable URI tests for Qt, skip the single test we don't pass.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b539bdb8
    • japhet@chromium.org's avatar
      2009-10-01 Nate Chapin <japhet@chromium.org> · 1368ffd3
      japhet@chromium.org authored
              Reviewed by Darin Adler.
      
              Add baseline pngs for a couple of tests that currently only have checksums.
      
              https://bugs.webkit.org/show_bug.cgi?id=28322
      
              * platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
              * platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1368ffd3
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · e365adab
      kenneth@webkit.org authored
      WebKitTools:
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP tests for Qt
      
      * Scripts/run-webkit-tests:
      
      LayoutTests:
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e365adab
    • eric@webkit.org's avatar
      2009-10-01 Yaar Schnitman <yaar@chromium.org> · 5a3edbf5
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Added windows-specific dependencies, updated some revisions and
              re-organized file to make revision tracking easier. Also removed
              extensions/v8 dependency that is no longer needed upstream.
      
              https://bugs.webkit.org/show_bug.cgi?id=29973
      
              * chromium/DEPS:
      2009-10-01  Yaar Schnitman  <yaar@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              build-webkit --chromium now also works on cygwin.
      
              https://bugs.webkit.org/show_bug.cgi?id=29973
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a3edbf5
    • eric@webkit.org's avatar
      2009-10-01 Yury Semikhatsky <yurys@chromium.org> · f4b3a8ac
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Use isClosure property of scope proxy to decide whether the
              scope is a closure.
      
              https://bugs.webkit.org/show_bug.cgi?id=29965
      
              * inspector/front-end/ScopeChainSidebarPane.js:
              (WebInspector.ScopeChainSidebarPane.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b3a8ac
    • simon.fraser@apple.com's avatar
      2009-10-01 Simon Fraser <simon.fraser@apple.com> · f478d5f7
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Odd color transitions on anchors with transition-property: all
              https://bugs.webkit.org/show_bug.cgi?id=29911
      
              When transitioning maybe-invalid colors, if the source and destination
              color are both invalid, then don't animate.
      
              This fixes an issue where a child element of an element running a color
              transition, with -webkit-transition-property:all, would show a color change.
              This happened because the "maybe invalid color" logic copied the color style
              into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
              to animate while the transition ran, and to then to disappear when the transition
              finished.
      
              Test: transitions/color-transition-all.html
      
              * page/animation/AnimationBase.cpp:
              (WebCore::PropertyWrapperMaybeInvalidColor::equals):
              (WebCore::PropertyWrapperMaybeInvalidColor::blend):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f478d5f7
    • eric@webkit.org's avatar
      2009-10-01 Victor Wang <victorw@chromium.org> · fb4d844b
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Allow dragging a node who has child nodes.
      
              https://bugs.webkit.org/show_bug.cgi?id=28632
      
              * fast/events/drag-parent-node-expected.txt: Added.
              * fast/events/drag-parent-node.html: Added.
              * fast/events/resources/bookmark.gif: Added.
      2009-10-01  Victor Wang  <victorw@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              Allow dragging a node who has child nodes.
      
              https://bugs.webkit.org/show_bug.cgi?id=28632
      
              Test: fast/events/drag-parent-node.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::shouldDragAutoNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb4d844b
    • eric@webkit.org's avatar
      2009-10-01 Philippe Normand <pnormand@igalia.com> · aeb4c271
      eric@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] media player: better mute support
              https://bugs.webkit.org/show_bug.cgi?id=29960
      
              Handle volume and mute state with the two corresponding properties
              of playbin2.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::setMuted):
              (WebCore::MediaPlayerPrivate::setVolume):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeb4c271
    • eric@webkit.org's avatar
      2009-10-01 Philippe Normand <pnormand@igalia.com> · 03bf8df6
      eric@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] video sink pad template colorspace is wrong
              https://bugs.webkit.org/show_bug.cgi?id=29953
      
              Set sink pad template colorspace depending on byte order.
      
              * platform/graphics/gtk/VideoSinkGStreamer.cpp:
              (webkit_video_sink_idle_func):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03bf8df6
    • eric@webkit.org's avatar
      2009-10-01 Vitaly Repeshko <vitalyr@chromium.org> · 76d2a71c
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Refactored V8 event listeners:
              (This change should fix http://crbug.com/21079 and
              https://bugs.webkit.org/show_bug.cgi?id=29093.)
               o All listeners use weak handles to JS objects to avoid creating
                 cycles and leaking memory.
               o "Object" variants of listeners removed.
               o All event accessor callbacks are generated.
               o Custom event accessors removed.
               o All wrappers have hidden dependencies on their listeners to
                 prevent listeners from being collected.
               o All variats of getEventListener function grouped in V8DOMWrapper.
               o Pointers to C++ EventListener wrappers are stored in JS objects
                 instead of event listener lists.
              https://bugs.webkit.org/show_bug.cgi?id=29825
      
              * WebCore.gypi: Removed "Object" listeners.
              * bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
              * bindings/v8/DOMObjectsInclude.h:
      
              V8AbstractEventListener manages weak JS handle:
              * bindings/v8/V8AbstractEventListener.cpp:
              (WebCore::weakEventListenerCallback):
              (WebCore::V8AbstractEventListener::V8AbstractEventListener):
              (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
              (WebCore::V8AbstractEventListener::handleEvent):
              (WebCore::V8AbstractEventListener::disposeListenerObject):
              (WebCore::V8AbstractEventListener::setListenerObject):
              * bindings/v8/V8AbstractEventListener.h:
              (WebCore::V8AbstractEventListener::cast):
              (WebCore::V8AbstractEventListener::isLazy):
              (WebCore::V8AbstractEventListener::getListenerObject):
              (WebCore::V8AbstractEventListener::getExistingListenerObject):
              (WebCore::V8AbstractEventListener::hasExistingListenerObject):
              (WebCore::V8AbstractEventListener::disconnectFrame):
              (WebCore::V8AbstractEventListener::disconnected):
              (WebCore::V8AbstractEventListener::prepareListenerObject):
              (WebCore::V8AbstractEventListener::lineNumber):
              (WebCore::V8AbstractEventListener::virtualisAttribute):
      
              Grouped getEventListener functions:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getTemplate):
              (WebCore::V8DOMWrapper::getEventListener):
              * bindings/v8/V8DOMWrapper.h:
      
              Removed most event listener objects bookkeeping:
              * bindings/v8/V8EventListenerList.cpp:
              * bindings/v8/V8EventListenerList.h:
              (WebCore::V8EventListenerList::findWrapper):
              (WebCore::V8EventListenerList::clearWrapper):
              (WebCore::V8EventListenerList::doFindWrapper):
              (WebCore::V8EventListenerList::getHiddenProperty):
              (WebCore::V8EventListenerList::findOrCreateWrapper):
      
              Added hidden properties for storing EventListener wrappers:
              * bindings/v8/V8HiddenPropertyName.cpp:
              (WebCore::V8HiddenPropertyName::listener):
              (WebCore::V8HiddenPropertyName::attributeListener):
              * bindings/v8/V8HiddenPropertyName.h:
      
              * bindings/v8/V8LazyEventListener.cpp:
              (WebCore::V8LazyEventListener::V8LazyEventListener):
              (WebCore::V8LazyEventListener::callListenerFunction):
              (WebCore::V8LazyEventListener::prepareListenerObject):
              * bindings/v8/V8LazyEventListener.h:
              (WebCore::V8LazyEventListener::isLazy):
              * bindings/v8/V8ObjectEventListener.cpp: Removed.
              * bindings/v8/V8ObjectEventListener.h: Removed.
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::disconnectFrame):
              (WebCore::V8Proxy::disconnectEventListeners):
              * bindings/v8/V8Proxy.h:
              * bindings/v8/V8WorkerContextEventListener.cpp:
              (WebCore::V8WorkerContextEventListener::reportError):
              (WebCore::V8WorkerContextEventListener::getReceiverObject):
              * bindings/v8/V8WorkerContextEventListener.h:
              * bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
              * bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
              * bindings/v8/WorkerContextExecutionProxy.cpp:
              (WebCore::WorkerContextExecutionProxy::dispose):
              (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
              (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
              * bindings/v8/WorkerContextExecutionProxy.h:
              * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8CustomEventListener.cpp:
              (WebCore::V8EventListener::V8EventListener):
              (WebCore::V8EventListener::getListenerFunction):
              (WebCore::V8EventListener::callListenerFunction):
              * bindings/v8/custom/V8CustomEventListener.h:
              * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
              * bindings/v8/custom/V8MessagePortCustom.cpp:
              (WebCore::getEventListener):
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8NodeCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8NotificationCenterCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8WebSocketCustom.cpp:
              * bindings/v8/custom/V8WorkerContextCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8WorkerCustom.cpp:
              * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76d2a71c
    • hausmann@webkit.org's avatar
      Make Software Input Panel requests work with QGraphicsWebView · 5a0d4fe1
      hausmann@webkit.org authored
      _and_ QWebView by sharing the event code in handleSoftwareInputPanel().
      
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
      Reviewed by Tor Arne Vestbø.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::mouseReleaseEvent):
      (QWebPagePrivate::handleSoftwareInputPanel):
      * Api/qwebpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a0d4fe1
    • zoltan@webkit.org's avatar
      2009-10-01 Zoltan Horvath <zoltan@webkit.org> · 0aaef196
      zoltan@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Allow custom memory allocation control for the whole JavaScriptCore
              https://bugs.webkit.org/show_bug.cgi?id=27029
      
              Since in JavaScriptCore almost every class which has been instantiated by operator new is
              inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
              when USE_SYSTEM_MALLOC=0.
      
              Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
              (It's needed for the functionality of TCmalloc.)
      
              Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.
      
              * JavaScriptCore.pri:
              * wtf/FastMalloc.cpp:
              (WTF::sleep):
              * wtf/FastMalloc.h:
      
      2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Don't use TCmalloc in DumpRenderTree
              https://bugs.webkit.org/show_bug.cgi?id=27029
      
              Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
      
              * DumpRenderTree/qt/DumpRenderTree.pro:
      
      2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
              https://bugs.webkit.org/show_bug.cgi?id=27029
      
              Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
              so these Qt-ports will use TCmalloc as other ports.
      
              * WebKit.pri:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aaef196
    • aroben@apple.com's avatar
      Land expected failure results for two tests on Windows · 80aa186c
      aroben@apple.com authored
      These failures are covered by <http://webkit.org/b/29963> and
      <http://webkit.org/b/29964>.
      
      Rubber-stamped in advance by Eric Carlson.
      
      * platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
      Added.
      * platform/win/fast/forms/basic-inputs-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80aa186c
    • vestbo@webkit.org's avatar
      Rename QWebGraphicsItem to QGraphicsWebView · 449d5dfb
      vestbo@webkit.org authored
      Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
      Reviewed by Tor Arne Vestbø.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      449d5dfb
    • eric@webkit.org's avatar
      2009-10-01 Dumitru Daniliuc <dumi@chromium.org> · 14f47f62
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Read-only transactions do not change file sizes and therefore
              should not trigger quota updates.
      
              https://bugs.webkit.org/show_bug.cgi?id=29945
      
              * storage/SQLTransaction.cpp:
              (WebCore::SQLTransaction::openTransactionAndPreflight):
              (WebCore::SQLTransaction::runStatements):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f47f62
    • tonikitoo@webkit.org's avatar
      2009-09-28 Antonio Gomes <tonikitoo@webkit.org> · b758796d
      tonikitoo@webkit.org authored
          Reviewed by Simon Hausmann.
      
          https://bugs.webkit.org/show_bug.cgi?id=29248
          [Qt] [API] Make it possible to have 'invisible' loads
      
          Make QWebFrame's setHtml and setContent methods to not change
          session and global history at all.
      
          * Api/qwebframe.cpp:
          (QWebFrame::setHtml):
          (QWebFrame::setContent):
          * tests/qwebframe/qwebframe.pro:
          * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b758796d
    • timothy@apple.com's avatar
      Fix list box scrolling by correctly overriding the scroll() · 8af4f2e9
      timothy@apple.com authored
      function on RenderBox.
      
      <rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
      of listboxes is broken (29756)
      
      Reviewed by Dan Bernstein.
      
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scroll):
      * rendering/RenderListBox.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::scroll):
      * rendering/RenderTextControlSingleLine.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8af4f2e9
    • eric@webkit.org's avatar
      2009-10-01 Yury Semikhatsky <yurys@chromium.org> · 0ae6607b
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Make a copy of listeners array before dispatching an event in
              WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
              listener removes itself from the array next listener will be skipped.
      
              https://bugs.webkit.org/show_bug.cgi?id=29920
      
              * inspector/front-end/Object.js:
              (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ae6607b
    • zoltan@webkit.org's avatar
      2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu> · ac3beb0b
      zoltan@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.
      
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac3beb0b
    • hausmann@webkit.org's avatar
      Fixed software input panel support on web input elements. · 6b841ef5
      hausmann@webkit.org authored
      Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
      Reviewed by Simon Hausmann.
      
      Send the RequestSoftwareInputPanel event if the element supports focus
      and the element is clicked.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      (QWebPagePrivate::mousePressEvent):
      (QWebPagePrivate::mouseReleaseEvent):
      * Api/qwebpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b841ef5
    • hausmann@webkit.org's avatar
      Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent · a1c768cc
      hausmann@webkit.org authored
      Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=29681
      
      Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:
      
          * Fixed surrounding text to exclude preedit string
          * Avoid emission of microFocusChanged during setComposition()
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::inputMethodEvent):
      (QWebPage::inputMethodQuery):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::respondToChangedSelection):
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage::inputMethods):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1c768cc
    • eric@webkit.org's avatar
      2009-10-01 Jakub Wieczorek <faw217@gmail.com> · 9cf66854
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement eventSender.scheduleAsynchronousClick().
      
              https://bugs.webkit.org/show_bug.cgi?id=29931
      
              * platform/qt/Skipped:
      2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Implement eventSender.scheduleAsynchronousClick().
      
              https://bugs.webkit.org/show_bug.cgi?id=29931
      
              * DumpRenderTree/qt/jsobjects.cpp:
              (EventSender::scheduleAsynchronousClick):
              * DumpRenderTree/qt/jsobjects.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cf66854
    • eric@webkit.org's avatar
      2009-10-01 Jakub Wieczorek <faw217@gmail.com> · 83760042
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
              fast/events/open-window-from-another-frame.html from the Skipped list.
      
              https://bugs.webkit.org/show_bug.cgi?id=29930
      
              * platform/qt/Skipped:
      2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
              fast/events/open-window-from-another-frame.html from the Skipped list.
      
              https://bugs.webkit.org/show_bug.cgi?id=29930
      
              * DumpRenderTree/qt/jsobjects.cpp:
              (LayoutTestController::setPopupBlockingEnabled):
              * DumpRenderTree/qt/jsobjects.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83760042
    • eric@webkit.org's avatar
      2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> · 4f864b9b
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Add new key event test ensuring that IME keypresses are handled.
      
              * GNUmakefile.am:
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Re-enable skipped tests which were previously failing.
      
              * platform/gtk/Skipped:
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Ensure that keyboard events filtered by the GtkIMContext still create
              the proper DOM events.
      
              No tests added. Instead previously skipped tests have been enabled.
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::keyIdentifierForGdkKeyCode):
              (WebCore::singleCharacterString):
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Ensure that keyboard events filtered by the GtkIMContext still create
              the proper DOM events.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::clearPendingIMData):
              (WebKit::imContextCommitted):
              (WebKit::imContextPreeditChanged):
              (WebKit::EditorClient::shouldBeginEditing):
              (WebKit::EditorClient::shouldEndEditing):
              (WebKit::interpretEditorCommandKeyEvent):
              (WebKit::handleCaretBrowsingKeyboardEvent):
              (WebKit::EditorClient::handleKeyboardEvent):
              (WebKit::EditorClient::handleInputMethodKeydown):
              * tests/testkeyevents.c: Added.
              (test_info_new):
              (test_info_destroy):
              (key_event_fixture_setup):
              (key_event_fixture_teardown):
              (key_press_event_cb):
              (key_release_event_cb):
              (load_status_cb):
              (map_event_cb):
              (test_keypress):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f864b9b