1. 11 Jan, 2009 4 commits
  2. 10 Jan, 2009 11 commits
    • abarth@webkit.org's avatar
      WebCore: · 97ae7979
      abarth@webkit.org authored
      2009-01-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21456
      
              We shouldn't update the document pointer of inactive windows.  This
              behavior differs slightly from Firefox, I'd argue that this behavior is
              more correct (we both differ from IE).  The HTML 5 spec is a bit in flux
              on this point.
      
              Test: http/tests/security/xss-inactive-closure.html
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::clearWindowShell):
              (WebCore::ScriptController::updateDocument):
              * bindings/js/ScriptController.h:
      
      LayoutTests:
      
      2009-01-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Test that we don't do goofy things with the document pointer after
              navigation.
      
              * fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
              * fast/dom/Window/dom-access-from-closure-window-expected.txt:
              * http/tests/security/resources/childWithButton.html: Added.
              * http/tests/security/resources/xss-inactive-closure-child-2.html: Added.
              * http/tests/security/resources/xss-inactive-closure-child.html: Added.
              * http/tests/security/xss-inactive-closure-expected.txt: Added.
              * http/tests/security/xss-inactive-closure.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ae7979
    • darin@apple.com's avatar
      2009-01-10 Darin Adler <darin@apple.com> · 8bfd024b
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/5845089> REGRESSION (r30044): Mail custom stationery missing images
              because of change to -[HTMLObjectElement data]
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Added a thread
              violation check because I saw this being done off the main thread while testing Mail, and it
              caused problems. Put all the one time initialization under a single guard to make things just
              a little faster other times, and to make it clearer which things are one-time. Added a call to
              the new patchMailRemoveAttributesMethod function.
              (-[WebView initWithFrame:frameName:groupName:]): Added a thread violation check here too,
              because I assumed it would be slightly better to have a public method name in the violation
              message. This calls commonInitialization later, so it will hit that one eventually.
              (objectElementDataAttribute): Added. Just returns the value of the "data" attribute.
              (recursivelyRemoveMailAttributes): Added. Patch to an internal Mail method that in turn patches
              a WebKit method and removes the patch again on the way out.
              (patchMailRemoveAttributesMethod): Added. On Leopard only, checks the Mail version, and then
              applies the patch that fixes this bug.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bfd024b
    • zecke@webkit.org's avatar
      [QT] Make SharedTimer use QBasicTimer · c6025402
      zecke@webkit.org authored
      Kill the SharedTimerQt.h and the usage of signal and slots
      by using QBasicTimer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6025402
    • zecke@webkit.org's avatar
      2009-01-09 Benjamin Otte <otte@gnome.org> · 12ed92f7
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=23194
      
              make the finalize function the dispose function. Not releasing held
              objects in dispose can cause crashers later.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12ed92f7
    • zecke@webkit.org's avatar
      2009-01-09 Benjamin Otte <otte@gnome.org> · 7e27c75f
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=23194
      
              Remove broken code that uses a fallback. The previous code did 2
              policy decisions which caused crashes.
              Download is still notImplemented();
      
              * webkit/webkitwebpolicydecision.cpp:
              (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e27c75f
    • zecke@webkit.org's avatar
      2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com> · 0513f59a
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              [CURL] POST without body becomes GET
              https://bugs.webkit.org/show_bug.cgi?id=23182
      
              Make sure that method is always set to POST even when the body is
              empty. Cleaned up httpBody null check.
      
              * platform/network/curl/ResourceHandleManager.cpp:
              (WebCore::ResourceHandleManager::setupPOST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0513f59a
    • treat@webkit.org's avatar
      Build fix. · 2f05e642
      treat@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f05e642
    • adele@apple.com's avatar
      2009-01-09 Adele Peterson <adele@apple.com> · 524122c2
      adele@apple.com authored
              Reviewed by Darin Adler.
      
              Fix infinite recursion in clientPaddingLeft and clientPaddingRight.  This changes the code back to
              how it was before RenderTextControlSingleLine was split out from RenderTextControl.
              
              No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
      
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
              (WebCore::RenderTextControlSingleLine::clientPaddingRight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      524122c2
    • darin@apple.com's avatar
      WebCore: · 2ca65e12
      darin@apple.com authored
      2009-01-09  Darin Adler  <darin@apple.com>
      
              Reviewed by Jon Honeycutt.
      
              Bug 22913: REGRESSION: Space bar doesn't scroll on windows
              https://bugs.webkit.org/show_bug.cgi?id=22913
              rdar://problem/6479834
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
              defaultSpaceEventHandler.
              (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
              on the shift key.
              * page/EventHandler.h: Added defaultSpaceEventHandler.
      
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::platformScroll): Return false, because this function does
              not scroll. In an earlier version of this patch, I used this to prevent the
              patch from affecting the Mac, but I decided to use #if instead.
      
      WebKit/win:
      
      2009-01-09  Darin Adler  <darin@apple.com>
      
              Reviewed by Jon Honeycutt.
      
              Bug 22913: REGRESSION: Space bar doesn't scroll on windows
              https://bugs.webkit.org/show_bug.cgi?id=22913
              rdar://problem/6479834
      
              * WebView.cpp:
              (WebView::keyPress): Removed code to handle space bar here; put it in
              WebCore instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ca65e12
    • weinig@apple.com's avatar
      2009-01-09 Sam Weinig <sam@webkit.org> · d3577913
      weinig@apple.com authored
              Check in correct results for failing test.
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3577913
    • barraclough@apple.com's avatar
      JavaScriptCore: · aca3ce7a
      barraclough@apple.com authored
      2009-01-09  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Stage two of converting JSValue from a pointer to a class type.
              Remove the class JSValue.  The functionallity has been transitioned
              into the wrapper class type JSValuePtr.
      
              The last stage will be to rename JSValuePtr to JSValue, remove the
              overloaded -> operator, and switch operations on JSValuePtrs from
              using '->' to use '.' instead.
      
              * API/APICast.h:
              * JavaScriptCore.exp:
              * runtime/JSCell.h:
              (JSC::asCell):
              (JSC::JSValuePtr::asCell):
              (JSC::JSValuePtr::isNumber):
              (JSC::JSValuePtr::isString):
              (JSC::JSValuePtr::isGetterSetter):
              (JSC::JSValuePtr::isObject):
              (JSC::JSValuePtr::getNumber):
              (JSC::JSValuePtr::getString):
              (JSC::JSValuePtr::getObject):
              (JSC::JSValuePtr::getCallData):
              (JSC::JSValuePtr::getConstructData):
              (JSC::JSValuePtr::getUInt32):
              (JSC::JSValuePtr::getTruncatedInt32):
              (JSC::JSValuePtr::getTruncatedUInt32):
              (JSC::JSValuePtr::mark):
              (JSC::JSValuePtr::marked):
              (JSC::JSValuePtr::toPrimitive):
              (JSC::JSValuePtr::getPrimitiveNumber):
              (JSC::JSValuePtr::toBoolean):
              (JSC::JSValuePtr::toNumber):
              (JSC::JSValuePtr::toString):
              (JSC::JSValuePtr::toObject):
              (JSC::JSValuePtr::toThisObject):
              (JSC::JSValuePtr::needsThisConversion):
              (JSC::JSValuePtr::toThisString):
              (JSC::JSValuePtr::getJSNumber):
              * runtime/JSImmediate.h:
              (JSC::JSValuePtr::isUndefined):
              (JSC::JSValuePtr::isNull):
              (JSC::JSValuePtr::isUndefinedOrNull):
              (JSC::JSValuePtr::isBoolean):
              (JSC::JSValuePtr::getBoolean):
              (JSC::JSValuePtr::toInt32):
              (JSC::JSValuePtr::toUInt32):
              * runtime/JSNumberCell.h:
              (JSC::JSValuePtr::uncheckedGetNumber):
              (JSC::JSValuePtr::toJSNumber):
              * runtime/JSObject.h:
              (JSC::JSValuePtr::isObject):
              (JSC::JSValuePtr::get):
              (JSC::JSValuePtr::put):
              * runtime/JSString.h:
              (JSC::JSValuePtr::toThisJSString):
              * runtime/JSValue.cpp:
              (JSC::JSValuePtr::toInteger):
              (JSC::JSValuePtr::toIntegerPreserveNaN):
              (JSC::JSValuePtr::toInt32SlowCase):
              (JSC::JSValuePtr::toUInt32SlowCase):
              * runtime/JSValue.h:
              (JSC::JSValuePtr::makeImmediate):
              (JSC::JSValuePtr::immediateValue):
              (JSC::JSValuePtr::JSValuePtr):
              (JSC::JSValuePtr::operator->):
              (JSC::JSValuePtr::operator bool):
              (JSC::JSValuePtr::operator==):
              (JSC::JSValuePtr::operator!=):
              (JSC::JSValuePtr::encode):
              (JSC::JSValuePtr::decode):
              (JSC::JSValuePtr::toFloat):
              (JSC::JSValuePtr::asValue):
              (JSC::operator==):
              (JSC::operator!=):
      
      WebCore:
      
      2009-01-09  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Delete references to JSValue, removing this class.
      
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::self):
              * bindings/js/ScriptCallStack.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aca3ce7a
  3. 09 Jan, 2009 25 commits
    • eric@webkit.org's avatar
      2009-01-09 Dimitri Glazkov <dglazkov@chromium.org> · 28344cb4
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add svg/graphics/skia files.
              https://bugs.webkit.org/show_bug.cgi?id=23147
      
              * svg/graphics/skia/RenderPathSkia.cpp: Added.
              (WebCore::RenderPath::strokeContains):
              * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
              (WebCore::SVGPaintServerPattern::setup):
              * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
              (WebCore::SVGPaintServer::draw):
              (WebCore::SVGPaintServer::teardown):
              (WebCore::SVGPaintServer::renderPath):
              * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
              (WebCore::SVGResourceFilter::createPlatformData):
              (WebCore::SVGResourceFilter::prepareFilter):
              (WebCore::SVGResourceFilter::applyFilter):
              * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
              (WebCore::SVGResourceMasker::applyMask):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28344cb4
    • eric@webkit.org's avatar
      2009-01-09 Dimitri Glazkov <dglazkov@chromium.org> · 12e6ce8b
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add SkiaFontWin to platform/graphics/chromium
              https://bugs.webkit.org/show_bug.cgi?id=23215
      
              * platform/graphics/skia/SkiaFontWin.cpp: Added.
              (WebCore::CachedOutlineKey::CachedOutlineKey):
              (WebCore::operator==):
              (WebCore::CachedOutlineKeyHash::hash):
              (WebCore::CachedOutlineKeyHash::equal):
              (WebCore::FIXEDToSkScalar):
              (WebCore::deleteOutline):
              (WebCore::addPolyCurveToPath):
              (WebCore::getPathForGlyph):
              (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
              (WebCore::SkiaWinOutlineCache::removePathsForFont):
              * platform/graphics/skia/SkiaFontWin.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12e6ce8b
    • eric@webkit.org's avatar
      2009-01-09 Dimitri Glazkov <dglazkov@chromium.org> · 8679e243
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
              https://bugs.webkit.org/show_bug.cgi?id=23215
      
              * platform/graphics/skia/PlatformContextSkia.cpp: Added.
              (PlatformContextSkia::State::State):
              (PlatformContextSkia::State::~State):
              (PlatformContextSkia::State::applyAlpha):
              (PlatformContextSkia::PlatformContextSkia):
              (PlatformContextSkia::~PlatformContextSkia):
              (PlatformContextSkia::setCanvas):
              (PlatformContextSkia::save):
              (PlatformContextSkia::restore):
              (PlatformContextSkia::drawRect):
              (PlatformContextSkia::setupPaintCommon):
              (PlatformContextSkia::setupPaintForFilling):
              (PlatformContextSkia::setupPaintForStroking):
              (PlatformContextSkia::setDrawLooper):
              (PlatformContextSkia::setMiterLimit):
              (PlatformContextSkia::setAlpha):
              (PlatformContextSkia::setLineCap):
              (PlatformContextSkia::setLineJoin):
              (PlatformContextSkia::setPorterDuffMode):
              (PlatformContextSkia::setFillColor):
              (PlatformContextSkia::getDrawLooper):
              (PlatformContextSkia::getStrokeStyle):
              (PlatformContextSkia::setStrokeStyle):
              (PlatformContextSkia::setStrokeColor):
              (PlatformContextSkia::getStrokeThickness):
              (PlatformContextSkia::setStrokeThickness):
              (PlatformContextSkia::getTextDrawingMode):
              (PlatformContextSkia::setTextDrawingMode):
              (PlatformContextSkia::setUseAntialiasing):
              (PlatformContextSkia::fillColor):
              (PlatformContextSkia::beginPath):
              (PlatformContextSkia::addPath):
              (PlatformContextSkia::setFillRule):
              (PlatformContextSkia::setGradient):
              (PlatformContextSkia::setPattern):
              (PlatformContextSkia::setDashPathEffect):
              (PlatformContextSkia::paintSkPaint):
              (PlatformContextSkia::bitmap):
              (PlatformContextSkia::isPrinting):
              * platform/graphics/skia/PlatformContextSkia.h: Added.
              (PlatformContextSkia::currentPath):
              (PlatformContextSkia::canvas):
              (PlatformContextSkia::gdk_skia):
              * platform/graphics/skia/PlatformGraphics.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8679e243
    • andersca@apple.com's avatar
      2009-01-09 Anders Carlsson <andersca@apple.com> · 37a0264a
      andersca@apple.com authored
              Fix build.
              
              * WebCore.LP64.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37a0264a
    • eric@webkit.org's avatar
      2009-01-09 Dimitri Glazkov <dglazkov@chromium.org> · c4e62104
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add TransformationMatrixSkia to platform/graphics/skia
              https://bugs.webkit.org/show_bug.cgi?id=23215
      
              * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
              (WebCore::TransformationMatrix::TransformationMatrix):
              (WebCore::TransformationMatrix::setMatrix):
              (WebCore::TransformationMatrix::map):
              (WebCore::TransformationMatrix::mapRect):
              (WebCore::TransformationMatrix::isIdentity):
              (WebCore::TransformationMatrix::reset):
              (WebCore::TransformationMatrix::scale):
              (WebCore::TransformationMatrix::rotate):
              (WebCore::TransformationMatrix::translate):
              (WebCore::TransformationMatrix::shear):
              (WebCore::TransformationMatrix::det):
              (WebCore::TransformationMatrix::inverse):
              (WebCore::TransformationMatrix::operator SkMatrix):
              (WebCore::TransformationMatrix::operator==):
              (WebCore::TransformationMatrix::operator*=):
              (WebCore::TransformationMatrix::operator*):
              (WebCore::TransformationMatrix::a):
              (WebCore::TransformationMatrix::setA):
              (WebCore::TransformationMatrix::b):
              (WebCore::TransformationMatrix::setB):
              (WebCore::TransformationMatrix::c):
              (WebCore::TransformationMatrix::setC):
              (WebCore::TransformationMatrix::d):
              (WebCore::TransformationMatrix::setD):
              (WebCore::TransformationMatrix::e):
              (WebCore::TransformationMatrix::setE):
              (WebCore::TransformationMatrix::f):
              (WebCore::TransformationMatrix::setF):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4e62104
    • ap@webkit.org's avatar
      2009-01-09 Brent Fulgham <bfulgham@gmail.com> · 8cdd47ad
      ap@webkit.org authored
              Reviewed by Adam Roben.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
              Separate CFNetwork-specific code in WebKit.dll into separate
              implementation files. Create cURL stub files to be populated
              with new implementation in a future bug report. 
      
              * WebCookieManager.cpp: Move CFNetwork-specific routines to
                the new WebCookieManagerCFNet.cpp file.
              (WebCookieManager::Release):
              * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
              (WebCookieManager::cookieStorage):
              * WebCookieManagerCurl.cpp: Added.
              (WebCookieManager::cookieStorage):
              (WebCookieManager::setCookieStorage):
              * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
                methods in this file.
              (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebFrameLoaderClient::savePlatformDataToCachedPage):
              * WebDownload.cpp: Move CFNetwork-specific logic to the new
                WebDownloadCFNet.cpp
              (WebDownload::bundleExtension):
              (WebDownload::bundleMagicNumber):
              (WebDownload::bundlePathForTargetPath):
              (WebDownload::extractResumeDataFromBundle): Made static class method
                so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
              (WebDownload::appendResumeDataToBundle): Made static class method
                so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
              * WebDownload.h:
              * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
              (WebDownload::initToResumeWithBundle):
              (WebDownload::setDestination):
              (didFailCallback):
              * WebDownloadCurl.cpp: Added.
              (WebDownload::init):
              (WebDownload::initWithRequest):
              (WebDownload::initToResumeWithBundle):
              (WebDownload::start):
              (WebDownload::cancel):
              (WebDownload::cancelForResume):
              (WebDownload::deletesFileUponFailure):
              (WebDownload::setDeletesFileUponFailure):
              (WebDownload::setDestination):
              (WebDownload::cancelAuthenticationChallenge):
              (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
              (WebDownload::useCredential):
              * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
                new cURL files. Modify Cairo targets to exclude CFNet files.
              * WebMutableURLRequest.cpp: Conditionalize the single method
                with a CFNetwork-speicic call.
              (WebMutableURLRequest::mutableCopy):
              * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
                causes build problems for cURL. This will be removed later.
              (WebURLAuthenticationChallenge::initWithProtectionSpace):
              * WebURLAuthenticationChallengeSender.cpp:
              * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
              (WebURLAuthenticationChallengeSender::useCredential):
              * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
              (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
              (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
              (WebURLAuthenticationChallengeSender::useCredential):
              * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
                for the cURL target.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cdd47ad
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 71ee454e
      ap@webkit.org authored
              <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
      
              Test: http/tests/appcache/reload.html
      
              On Windows, reloading resulted in the following sequence of events:
              1) A new main resource loader was created and associated with the cache. Its document loader
              was not associated with the cache yet.
              2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
              teardown started, with newestCache being zeroed out.
              3) The new document loader was associated with the cache group, and cache update started.
              4) Since newestCache was null, this caused many problems.
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
              no functional changes.
              (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
              if its newest cache pointer is already saved for teardown. Note that the cache pointer
              validity is ensured by MainResourceLoader that holds a reference to it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71ee454e
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · e8b51549
      ap@webkit.org authored
              Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
      
              * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
              raise exceptions, as needed for AppCache tests. I do not know why this error was not
              implemented.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8b51549
    • darin@chromium.org's avatar
      2009-01-09 Darin Fisher <darin@chromium.org> · 45f77239
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=23214
              Upstream platform/network/chromium/
      
              * platform/network/chromium/AuthenticationChallenge.h: Added.
              (WebCore::AuthenticationChallenge::AuthenticationChallenge):
              (WebCore::AuthenticationChallenge::sourceHandle):
              * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
              (WebCore::AuthenticationChallenge::platformCompare):
              * platform/network/chromium/CookieJarChromium.cpp: Added.
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookiesEnabled):
              * platform/network/chromium/DNSChromium.cpp: Added.
              (WebCore::prefetchDNS):
              * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
              (WebCore::NetworkStateNotifier::updateState):
              (WebCore::NetworkStateNotifier::NetworkStateNotifier):
              * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
              * platform/network/chromium/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              * platform/network/chromium/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::):
              (WebCore::ResourceRequest::ResourceRequest):
              (WebCore::ResourceRequest::frame):
              (WebCore::ResourceRequest::setFrame):
              (WebCore::ResourceRequest::setTargetType):
              (WebCore::ResourceRequest::targetType):
              (WebCore::ResourceRequest::originPid):
              (WebCore::ResourceRequest::setOriginPid):
              (WebCore::ResourceRequest::securityInfo):
              (WebCore::ResourceRequest::setSecurityInfo):
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              * platform/network/chromium/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              (WebCore::ResourceResponse::getSecurityInfo):
              (WebCore::ResourceResponse::setSecurityInfo):
              (WebCore::ResourceResponse::isContentFiltered):
              (WebCore::ResourceResponse::setIsContentFiltered):
              (WebCore::ResourceResponse::doUpdateResourceResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45f77239
    • barraclough@apple.com's avatar
      fix tyop in Changelog · 40d79e18
      barraclough@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d79e18
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 4dce3609
      mitz@apple.com authored
              - fixed <rdar://problem/6234347> Add/change conditional key
                bindings for changing paragraph- and character-level writing
                direction (to match NSTextView)
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Added
              code to validate makeBaseWritingDirectionLeftToRight: and
              makeBaseWritingDirectionRightToLeft:.
              (writingDirectionKeyBindingsEnabled): Changed this function to
              always return YES, except on Tiger and Leopard.
              (-[WebHTMLView makeBaseWritingDirectionLeftToRight:]): Renamed
              changeBaseWritingDirectionToLTR: to this.
              (-[WebHTMLView makeBaseWritingDirectionRightToLeft:]): Renamed
              changeBaseWritingDirectionToRTL: to this.
              (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Now calls
              makeBaseWritingDirectionLeftToRight:.
              (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Now calls
              makeBaseWritingDirectionRightToLeft:.
              * WebView/WebView.mm: Added makeBaseWritingDirectionLeftToRight
              and makeBaseWritingDirectionRightToLeft to
              FOR_EACH_RESPONDER_SELECTOR.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dce3609
    • adele@apple.com's avatar
      2009-01-09 Darin Adler <darin@apple.com> · 3c70daa8
      adele@apple.com authored
              Reviewed and landed by Adele Peterson.
      
              Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
              https://bugs.webkit.org/show_bug.cgi?id=23160
      
              * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
              * WebView.cpp:
              (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
              * WebView.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c70daa8
    • wsiegrist@apple.com's avatar
      2009-01-09 William Siegrist <wsiegrist@apple.com> · 53a2c52a
      wsiegrist@apple.com authored
      Reviewed by David Kilzer
      
      Update URLs which go through redirects by changing bugs.webkit.org URLs to use https and removing /projects/webkit from Trac URLs.
      
      Replace tabs in bugpriorities.html with spaces.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53a2c52a
    • oliver@apple.com's avatar
      2009-01-09 David Levin <levin@chromium.org> · 1fbb3cfa
      oliver@apple.com authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23175
      
              Adjustment to previous patch.  Remove call to initilizeThreading from JSGlobalCreate
              and fix jsc.cpp instead.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fbb3cfa
    • abarth@webkit.org's avatar
      2009-01-09 Joel Weinberger <jww@cs.berkeley.edu> · 9b698b6a
      abarth@webkit.org authored
              Reviewed by Darin Adler.
              Landed by Adam Barth.
      
              The test intended to test reload, but reference reload in one place and
              replace in another. This makes them consistent.
      
              * http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b698b6a
    • hausmann@webkit.org's avatar
      2009-01-09 Simon Hausmann <simon.hausmann@nokia.com> · b667971b
      hausmann@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              Documentation fixes, remove duplicated docs, document missing
              parameters and return values.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b667971b
    • weinig@apple.com's avatar
      2009-01-09 Sam Weinig <sam@webkit.org> · 93675548
      weinig@apple.com authored
              Roll r39720 back in with a working interpreted mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93675548
    • pkasting@chromium.org's avatar
      2009-01-09 Peter Kasting <pkasting@google.com> · a2910e11
      pkasting@chromium.org authored
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=22995
              Fix flaky image animation by resetting the metadata for a frame when
              we get new data for that frame.  This fixes animations that halted
              when the next frame of the animation wasn't complete by the time the
              current frame's duration expired.
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::destroyDecodedData):
              (WebCore::BitmapImage::dataChanged):
              * platform/graphics/BitmapImage.h:
              (WebCore::FrameData::~FrameData):
              * platform/graphics/cairo/ImageCairo.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/qt/ImageQt.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/wx/ImageWx.cpp:
              (WebCore::FrameData::clear):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2910e11
    • oliver@apple.com's avatar
      2830fd1c
    • hausmann@webkit.org's avatar
      2009-01-09 Simon Hausmann <simon.hausmann@nokia.com> · 5eae4747
      hausmann@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              Swap the .h and the .cpp output in the Qt build for the
              UserAgentStyleSheetData files, to put the definition in the .cpp file
              and the declaration in the header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eae4747
    • oliver@apple.com's avatar
      include files missed in last commit. · 2177dad1
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2177dad1
    • oliver@apple.com's avatar
      2009-01-09 David Levin <levin@chromium.org> · 586afefe
      oliver@apple.com authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23175
      
              Added a template to make the pointer and flags combination
              in UString more readable and less error prone.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      586afefe
    • hausmann@webkit.org's avatar
      2009-01-09 Simon Hausmann <simon.hausmann@nokia.com> · a9e00962
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Fix linking against QtWebKit on Windows, by defining the EXPORT macros
              _exactly_ the same way as in qglobal.h, depending on QT_NODLL,
              QT_MAKEDLL and QT_SHARED.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9e00962
    • vestbo@webkit.org's avatar
      2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com> · 8f297046
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Prevent qmake from generating duplicate rules for embedded stylesheets
      
              The STYLESHEETS_EMBED variable used to contain only one file name, but
              now that it is a list of files we need to change it to be a dependency
              for the stylesheet generator instead of the input.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f297046
    • hausmann@webkit.org's avatar
      WebCore: · 68671a47
      hausmann@webkit.org authored
          2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>
      
                  Reviewed by Tor Arne Vestbø.
      
                  Fix qmake warning about missing test function, a contains() call was
                  missing.
      
      WebKit/qt:
          2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>
      
                  Reviewed by Tor Arne Vestbø.
      
                  Remove qwebnetworkinterface.h from WEBKIT_API_HEADERS as it's not
                  public Qt 4.4/4.5 API.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68671a47