- 17 Dec, 2002 16 commits
-
-
sullivan authored
- fixed 2895826 -- ICON: Need a "no plug-in" icon * Resources/nullplugin.tiff: new plug-in icon. Blue 3-D lego with question marks. WebBrowser: - fixed 312965 -- SJ: Need Home button art with thinner lines - also added an all-purpose document icon with a compass instead of a spider, and a tweaked version of the app icon * Resources/Images/Home.tif: * Resources/Images/HomeDisabled.tif: * Resources/Images/HomePressed.tif: * Resources/compass.icns: new versions * document.icns: Removed. this was the spider, he's gone now but his name remains. * Resources/document.icns: Added. put it in here with the app icon. * WebBrowser.pbproj/project.pbxproj: updated for new/removed files git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3114 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rjw authored
done with a horrible hack and should be removed when 3129490 is fixed. Reviewed by hyatt. * WebCoreSupport.subproj/WebTextRenderer.m: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3113 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- fixed 3120729 - HOMEPAGE: Can't set a DIV innerHTML property with html content starting with <html><head><head/><body> * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Pop <html> and <body>, and remove <head> to allow a full HTML document to be made and inserted as a contextual fragment. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3112 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
when you try to insert a block in between two inlines that have already been wrapped in an anonymous block. Reviewed by mjs * khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow): (RenderFlow::makeChildrenNonInline): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3109 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
get cached in the b/f cache. Reviewed by trey. * WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3106 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rjw authored
has a bug that sometimes causes line height to be 20% too large. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
Reworking the code to update the page icon led me to roll the WebIconDB API for URL to NSString. In addition, the vestigial "Site" was removed. Everything below is renaming, except where noted. Reviewed by Darin * English.lproj/StringsNotToBeLocalized.txt: * History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem icon]): * Misc.subproj/WebIconDatabase.h: * Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): Use _web_isFileURL. (-[WebIconDatabase iconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconForFileURL:withSize:]): Cons up a NSURL to get the path. Test explicitly for .htm and .html suffixes. (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForURL:]): (-[WebIconDatabase _releaseFutureIconForURL:]): (-[WebIconDatabase _sendNotificationForURL:]): * Misc.subproj/WebIconDatabasePrivate.h: * Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]): * WebKit.exp: * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): WebBrowser: 3127109 - REGRESSION: generic favicon shown while page from same domain is loading We now avoid jumping to the generic icon when we're loading and are moving to a URL within the same domain as the current one. In addition, some name changes for the URL->NSString changes in the WebIconDB API. Reviewed by John * BookmarkSource.m: (-[BookmarkSource imageForContentItem:]): Adopt API change. * BrowserWindowController.h: New ivar, _acceptsGenericIcon. * BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Init new ivar. (-[BrowserWindowController acceptsGenericIcon]): New getter. (-[BrowserWindowController setAcceptsGenericIcon:]): New setter. (-[BrowserWindowController updateLocationFieldIcon]): Obey new ivar as to we will accept a generic icon when updating. * LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): If the new URL is in the same site as the old one, avoid accepting a generic icon. (-[LocationChangeHandler locationChangeDone:forDataSource:]): Reset _acceptsGenericIcon * NewBookmarksController.m: (-[NewBookmarksController awakeFromNib]): Adopt API change. * TitleBarButton.m: (-[TitleBarButton drawPathRepresentingPopUpMenuForEvent:URL:]): Adopt API change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3104 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
cblu authored
Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex Reviewed by darin. * Misc.subproj/WebNSStringExtras.m: (-[NSString _web_looksLikeAbsoluteURL]): trim whitespace because _web_URLWithString allows whitespace * Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:]): trim whitespace because we shouldn't replace spaces with escape characters (+[NSURL _web_URLWithString:relativeToURL:]): trim whitespace because we shouldn't replace spaces with escape characters WebKit: Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex Reviewed by darin. * Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): don't trim whitespace because _web_URLWithString does this for us * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginURLFromCString:]): tweak git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed build; WebFileDatabase was importing a file that is internal * Database.subproj/WebFileDatabase.h: Don't import WebLRUFileList.h. * Database.subproj/WebFileDatabase.m: Do import WebLRUFileList.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3102 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- to help with performance of various bookmark operations, added a call that returns the internal array of children, to complement the safer call that returns a copy. Reviewed by Darin * Bookmarks.subproj/WebBookmark.h: commented -children and new -rawChildren * Bookmarks.subproj/WebBookmark.m: (-[WebBookmark rawChildren]): new method, returns nil at this level. (-[WebBookmark contentMatches:]): use -rawChildren instead of -children * Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList rawChildren]): new method, returns internal array without copying WebBrowser: - fixed 3129823 -- displaying many bookmarks in outline view is very slow Deployed new rawChildren call everywhere appropriate in WebBrowser. This prevents a lot of array-creation. On my machine, the time it takes to display a folder containing 1000 items went from 0.96 sec to 0.0084 sec. Reviewed by Darin * BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): (-[BookmarksController goToNthFavoriteLeaf:]): (-[BookmarksController _addBookmarksToMenu]): (-[BookmarksController mergeBookmarksFrom:to:]): (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): (-[BookmarksController importInternetExplorerFavorites]): (-[BookmarksController updateBookmarkSources]): (-[BookmarksController favoriteBookmarks]): (-[BookmarksController addFavoriteBookmark:atIndex:]): (-[BookmarksController recursivelyAddChildFoldersOf:toMenu:withIndentationLevel:]): use -rawChildren instead of -children * BookmarksViewController.m: (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]): use -rawChildren instead of -children (-[BookmarksViewController bookmarkSources]): use -rawChildren instead of -children (-[BookmarksViewController refreshContents]): log timing (-[BookmarksViewController canRemoveBookmarkSource:]): use -rawChildren instead of -children (-[BookmarksViewController deleteSelectedContentItems]): log timing (-[BookmarksViewController child:ofContentItem:usingSource:]): use -rawChildren instead of -children (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]): use -rawChildren instead of -children (-[BookmarksViewController paste:]): log timing; use -rawChildren instead of -children (-[BookmarksViewController initWithBookmark:bookmark:]): use -rawChildren instead of -children (+[CompletionController _addBookmarkTree:]): use -rawChildren instead of -children (+[CompletionController _removeBookmarkTree:]): use -rawChildren instead of -children * FavoriteButton.m: (-[FavoriteButton _contentsMenu]): use -rawChildren instead of -children * WebBrowser.pbproj/project.pbxproj: version wars git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3101 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kocienda authored
Fix for this bug: Radar 3128631 (WebFileDatabase walks its whole directory tree to expire files) Complete reworking of the way in which the disk cache database keeps track of the files on disk. This should result in fewer I/O operations, and should fix the extremely bad behavior that involved walking the entire disk cache tree evey time a single file needed to be deleted. * Database.subproj/WebFileDatabase.h: Use new WebLRUFileList code. * Database.subproj/WebFileDatabase.m: Ditto. * Database.subproj/WebLRUFileList.h: Added. * Database.subproj/WebLRUFileList.m: Ditto. * Misc.subproj/WebFoundationLogging.h: Added WebFoundationLogWebFileDatabaseActivity channel * Misc.subproj/WebFoundationLogging.m: Ditto * WebFoundation.pbproj/project.pbxproj: Added WebLRUFileList. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3100 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Maciej. - remove leftover bits of NO_LICENSE * acconfig.h: Remove NO_LICENSE. * configure.in: Remove all the NO_LICENSE-related bits. WebBrowser: Reviewed by Maciej. - remove leftover bits of NO_LICENSE * WebBrowser.pbproj/project.pbxproj: Remove build styles setting HAVE_CONFIG_H and also INCLUDE_TEST_SUITE too, because that hasn't been used anywhere for like forever. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3099 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Don and Maciej. * force-clean-timestamp: Trigger a full build since we are setting MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs. Tools: * Scripts/check-copyright: Added. JavaScriptCore: Reviewed by Don and Maciej. - fixed 3129115 -- need Apple copyright added to open source documents * tons of files: Added our copyright to files we modified, and updated all to standard format. - other changes * JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2. Also removed completion.cpp. * kjs/completion.cpp: Removed. * kjs/completion.h: Made the Completion constructor inline. * kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now. WebFoundation: Reviewed by Don and Maciej. * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes. * WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2. WebCore: Reviewed by Don and Maciej. - fixed 3129115 -- need Apple copyright added to open source documents * tons of files: Added copyright message to files we modified and standardized format of copyrights too. - fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off * khtml/misc/loader.cpp: (Cache::getLRUListFor): Use the first list for 0-sized objects. (Cache::removeFromLRUList): Allow 0-sized objects. - other changes * khtml/rendering/render_style.h: Remove bogus unused private constructor. * kwq/KWQFont.h: Added copy constructor and assignment operator. * kwq/KWQFont.mm: (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could cause retain/release problems. (QFont::operator=): Retain the new NSFont and release the old one. * WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2. WebKit: Reviewed by Don and Maciej. * WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we spoof as Mac IE, and added comments. * WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. * WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2 WebBrowser: Reviewed by Don and Maciej. - fixed 3106686 -- Remove "world leak" debugging window before beta * Test/PageLoadTestController.m: (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo box so it automatically sizes to the number of pltsuite files so we don't have to edit the nib all the time. (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the window closes. The one in the page load test window is still there. * Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]): Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later. - fixed 3124310 -- remove "app refuses to launch" code before shipping * main.m: (main): Remove all the licensing code. - other changes * BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static so we would know if any were unused and for cleanliness. (-[NSNetService hostName:andPort:]): Remove some silly assertions. (decode_name): Change printf for errors to ERROR. (decode_srv): Ditto. (decode_txt): Removed because it's unused. (skip_question): Ditto. (MyDictionaryKeyHashCallBack): Removed silly assertion. (MyCreateCFDictionaryFromTXT): Ditto. * WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3098 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- fixed 3125283 - HOMEPAGE: in onload of an IMG, the width and height are equal to zero There were two problems here. First, the calls to get image width and height didn't force a layout in all the cases where it was required. Second, layout wouldn't lay out images at all until parsing was done, due to a hack to block inline layout until that point. I'm not sure if this will have other bad consquences, but nearly every page I tried, including Hebrew and Japanese pages as well as every page on the base PLT laid out properly. * khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Force a layout if not laid out. (HTMLImageElementImpl::height): Likewise. * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Remove setBlockBidi hack - this was preventing images from getting laid out until the document was totally done parsing. * khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): More setBLockBidi removal. (RenderFlow::layout): Likewise. (RenderFlow::close): Likewise. (RenderFlow::addChildToFlow): Likewise. (RenderFlow::printTree): Likewise. * khtml/rendering/render_flow.h: * khtml/rendering/render_object.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Dec, 2002 20 commits
-
-
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
a float), make sure the block gets a fresh layout, so that it can readjust its contents now that they don't have to flow around the float. Reviewed by darin * khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3095 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
cblu authored
Reviewed by rjw. * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Added comment about our tragic dependence on a non-retained reference to the controller. (-[WebDataSource _recursiveStopLoading]): Call webFrame before calling _stopLoading because we release the controller in _stopLoading and we depend on it in webFrame. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3094 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rjw authored
Reviewed by darin. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3093 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fixed 3125412 - HOMEPAGE: 2nd load of html in the same div fails. - fixed 3052113 - HOMEPAGE: "site menu" part of .mac home page editing doesn't work - fixed 3075392 - HOMEPAGE: "pages" section of mac.com homepage editing is missing * khtml/html/html_baseimpl.h: * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Function that loads new URL, to be called if src attribute is set explicitly and the element is already attached. (HTMLFrameElementImpl::parseAttribute): Call updateForNewURL when src attrinute is set. (HTMLFrameElementImpl::contentDocument): Don't involve render widget in getting the content document. * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Allow contextual fragments to be created (and therefore innerHTML to be set on) TR and HTML elements. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3090 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
The layer knows about the overflow out of the object. The object does not. Duh. Fixes disney.com bustage. Reviewed by sullivan * khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3089 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
their own minmax widths will get the correct value during the ifrst pass. With this change weather.com is actually fixed. Reviewed by mjs * khtml/rendering/render_box.cpp: (RenderBox::calcWidth): * khtml/rendering/render_flow.cpp: (RenderFlow::calcMinMaxWidth): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3088 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
overflow: hidden elements bounds-check their minwidth and maxwidth values to ensure that you don't grow the clipped element. Reviewed by mjs * khtml/rendering/render_box.cpp: (RenderBox::calcWidth): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3087 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
trey authored
Turns out that an empty UserStyle was causing WebCore to reload the base URL of the page, since it tried to load the style "". Reviewed by Darin * khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration): Of the UserStyle is empty, set it to an empty string instead of an empty URL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3086 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- fixed 3129008 - REGRESSION: Successive hot/cached runs of cvs-base PLT are slightly slower This was due to me reintroducing a leak of the document. Now fixed. * khtml/ecma/kjs_dom.cpp: (DOMDocument::~DOMDocument): forget self from cached DOM object table. (KJS::getDOMDocumentNode): Instead of storing the document in the marked per-document table, store it in the unmarked table, and as a property on the Window object. (KJS::getDOMNode): use getDocumentNode when appropriate. * khtml/ecma/kjs_dom.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3085 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kocienda authored
Fix for these bugs: Radar 3128622 (files that can't be mmap'd are opened twice) Radar 3128624 (names of "not mappable" files kept in ever-growing set) It turns out that simply reading in the bytes using the NSData initWithContentsOfFile: method is faster than attempting to mmap disk cache files to read them. Since the mmap code is now removed, the issues raised by the bugs simply go away. * Database.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:]) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3084 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
existing line box if possible. This patch also fixes RTL bullets and line height calculations involving image bullets that are the biggest thing on the line. List markers also correctly move to avoid floats. Reviewed by mjs * khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3083 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
existing line box if possible. This patch also fixes RTL bullets and line height calculations involving image bullets that are the biggest thing on the line. List markers also correctly move to avoid floats. Reviewed by mjs * khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3082 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
* WebKit.pbproj/project.pbxproj: Bump version to 37u3 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3080 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- fixed 3128858 -- Supply Finder bits for decoded BinHex files * Downloads.subproj/WebBinHexDecoder.h: Add a _finderFlags field. * Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]): Decode Finder flags. (-[WebBinHexDecoder fileAttributes]): Put Finder flags in dictionary. * Downloads.subproj/WebMacBinaryDecoder.m: Tweaked things for no good reason. (It is good to always import your own header first as a check that it's self-sufficient). * WebKit.pbproj/project.pbxproj: Let Electron wipe the slate clean of pre-Electron iniquity. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3079 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- fixed 3128766 -- macconnection.com tries to add properties to the navigator DOM object, which fails * khtml/ecma/kjs_window.cpp: (Window::get): Set up properties named navigator and clientInformation the first time either is queried. These will hold a persistent shared object rather than making one every time it's asked for. * WebCore.pbproj/project.pbxproj: Let Electron undo Maciej's evil. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3078 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
cblu authored
Fixed: 3094928 - Apply Finder bits to decoded downloads Reviewed by darin. * Misc.subproj/WebNSFileManagerExtras.h: * Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_createFileAtPath:contents:attributes:]): new, creates file and sets Finder bits. WebKit: Fixed: 3094928 - Apply Finder bits to decoded downloads Reviewed by darin. * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_createFileAtPath:contents:attributes: so we set Finder bits * Downloads.subproj/WebMacBinaryDecoder.h: * Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): save Finder bits (-[WebMacBinaryDecoder fileAttributes]): return Finder bits WebBrowser: Fixed: 3094928 - Apply Finder bits to decoded downloads Reviewed by darin. * DownloadRow.m: (-[DownloadRow _updateIconAndFilename]): no changes, moved up (-[DownloadRow _stopProgressAnimation]): call _updateIconAndFilename so we pick up icon changes. The Finder will update the icon after we close the file if it has the custom icon bit. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3077 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
* JavaScriptCore.pbproj/project.pbxproj: Bump version to 37u2. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3075 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- fixed likely B&I build problem. * WebKit.pbproj/project.pbxproj: Get at other frameworks in B&I build. Bump version to 37u2. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Dec, 2002 4 commits
-
-
darin authored
- implemented user-agent spoofing as described in bug 3044569 * WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Find the suffix of the host name that contains exactly one dot, lower-case it, and look it up in the user-agent spoof table. For now, anything in the table pretends to be MacIE. Don't fret that this table is simple. We will complicate it as needed. The technique is flexible, even though it may not look it now. * WebView.subproj/WebControllerPrivate.h: Add userAgentWhenPretendingToBeMacIE field. * WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release userAgentWhenPretendingToBeMacIE. (-[WebController _defaultsDidChange]): Release and nil userAgentWhenPretendingToBeMacIE. * Makefile.am: Added rules to build WebUserAgentSpoofTable.c using gperf. * WebView.subproj/WebUserAgentSpoofTable.c: Added. Generated file. * WebView.subproj/WebUserAgentSpoofTable.gperf: Added. Table * English.lproj/StringsNotToBeLocalized.txt: Update for above changes. - fixed a crash I saw in a simplistic way * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Don't assert if the webFrame is nil, just return a partial dictionary. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3073 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
Reviewed by Darin. * Scripts/set-module-version: Accept `u' in source version. WebCore: Reviewed by Darin. * WebCore.pbproj/project.pbxproj: Updated source version to 37u2. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3072 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- fixed regression where clicked-on buttons were getting keyboard focus * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Check clickCount here the way NSWindow does. See below for rationale. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): I didn't read the code in [NSWindow sendEvent:] that I was stealing carefully enough. The old needsPanelToBecomeKey flag is used to decide whether something should really get first responder, and I need to do check that too. And while I was in here, did the same clickCount check that NSWindow does for good measure. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3071 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- fixed 3128383 - DOM nodes should always use the same JS object * khtml/ecma/kjs_binding.h: * khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::ScriptInterpreter): Set auto-delete to true on document dictionary. (ScriptInterpreter::getDOMObjectForDocument): New function - gets DOM object from per-document dictionary. (ScriptInterpreter::putDOMObjectForDocument): New function - put DOM object into per-document dictionary. (ScriptInterpreter::deleteDOMObjectsForDocument): Clear all objects from specific per-document dictionary. (ScriptInterpreter::mark): Mark per-document objects. (ScriptInterpreter::forgetDOMObjectsForDocument): Clear objects for this document from all interpreters. * khtml/ecma/kjs_dom.h: * khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Use per-document rather than general DOM object dictionary. * khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Call forgetDOMObjectsForDocument. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
