1. 09 Apr, 2013 40 commits
    • eric.carlson@apple.com's avatar
      [Mac] user caption styles not applied to correct element · c1ce91d5
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114230
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Test: media/track/track-css-user-override.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::updateActiveTextTrackCues): Drive by clean-up so we don't log excessively.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize
          new member variables.
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Set cue font size when it is
          inserted into the tree.
      (WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Update the font size of 
          all active cues.
      (WebCore::MediaControlTextTrackContainerElement::updateSizes): Set size-relative CSS properties
          after a time because this can be called during layout.
      * html/shadow/MediaControlElements.h:
      
      * html/shadow/MediaControls.cpp:
      (WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged before updateSizes.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::setFontSize): New, set the cue's font size.
      * html/track/TextTrackCue.h:
      
      * html/track/TextTrackCueGeneric.cpp:
      (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set cue properties on the cue element
          instead of on the cue box to match what we do for the "cue" pseudo element.
      (WebCore::TextTrackCueGeneric::setFontSize): New, set the cue's font size.
      * html/track/TextTrackCueGeneric.h:
      
      * html/track/TextTrackList.cpp:
      (TextTrackList::remove): Drive-by cleanup, don't ASSERT when the media element is NULL.
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride): New, allow user CSS overrides
          to be tested in DRT.
      (WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): New, generate a user style
          sheet override. Moved here from CaptionUserPreferencesMac.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Don't ignore background color importance.
      (WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Implement even when we don't 
          have the media accessibility framework so this can be tested in DRT. Apply all cue properties
          to the element used for the "cue" pseudo element.
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress): Drive-by cleanup, remove logging
          because this method is called so frequently and the logging is not especially useful.
      (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Only log when the ready/network
          state changes because this method is called so frequently.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): Drive-by cleanup, remove logging
          because this method is called so frequently and the logging is not especially useful.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Make the logging more useful.
      
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState): Reset captions style sheet override.
      (WebCore::Internals::captionsStyleSheetOverride): New, return the captions style sheet override.
      (WebCore::Internals::setCaptionsStyleSheetOverride): New, override the captions style sheet override.
      * testing/Internals.h:
      * testing/Internals.idl:
      
      LayoutTests: 
      
      * media/track/track-css-user-override-expected.txt: Added.
      * media/track/track-css-user-override.html: Added.
      * media/track/track-cue-container-rendering-position-expected.txt:
      * media/track/track-cue-container-rendering-position.html:
      * media/track/track-cue-rendering-expected.txt:
      * media/track/track-cue-rendering.html: Font size is not applied instantly when a video element is
          resized, so check after a very short delay.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1ce91d5
    • simon.fraser@apple.com's avatar
      Repaint rect too small on elements with shadows · ce1e8dbe
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114225
      
      Source/WebCore:
      
      Reviewed by Dain Adler.
      
      We assumed that shadows (box-shadow, text-shadow, svg shadows)
      only required inflating the repaint rect by the blur radius of
      the shadow. However, this is incorrect; the shadow can extend
      further, which resulted in clipped or incorrectly invalidated
      shadows.
      
      Fix by disambiguating the blur radius (which is 2x the standard
      deviation of the Gaussian distribution used to generate the blur),
      from the painting extent, which is how far the shadow visually
      projects. Using a 1.4 multiplier of the blur radius is a good
      approximation for the painting extent.
      
      Renamed ShadowData::blur() to ShadowData::radius(), and added
      ShadowData::paintingExtent(). Use the latter in all places
      which relate to invalidation.
      
      Test: fast/box-shadow/shadow-repaint.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::valueForShadow):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontAttributesForSelectionStart):
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::blendFunc):
      * rendering/EllipsisBox.cpp:
      (WebCore::EllipsisBox::paint):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::applyShadowToGraphicsContext):
      (WebCore::InlineTextBox::paintDecoration):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::applyBoxShadowForBackground):
      (WebCore::areaCastingShadowInHole):
      (WebCore::RenderBoxModelObject::paintBoxShadow):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::getShadowExtent):
      (WebCore::RenderStyle::getShadowInsetExtent):
      (WebCore::RenderStyle::getShadowHorizontalExtent):
      (WebCore::RenderStyle::getShadowVerticalExtent):
      * rendering/style/ShadowData.cpp:
      (WebCore::ShadowData::ShadowData):
      (WebCore::ShadowData::operator==):
      (WebCore::calculateShadowExtent):
      * rendering/style/ShadowData.h:
      (WebCore::ShadowData::ShadowData):
      (WebCore::ShadowData::radius):
      (WebCore::ShadowData::paintingExtent):
      * rendering/svg/SVGRenderingContext.cpp:
      (WebCore::SVGRenderingContext::prepareToRenderSVGContent):
      
      LayoutTests:
      
      Reviewed by Darin Alder.
      
      New test for invalidation with box-shadow. Update test results affected
      by shadow extent.
      
      * compositing/geometry/foreground-layer-expected.txt:
      * compositing/iframes/composited-parent-iframe-expected.txt:
      * compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
      * compositing/iframes/connect-compositing-iframe-expected.txt:
      * compositing/iframes/connect-compositing-iframe2-expected.txt:
      * compositing/iframes/connect-compositing-iframe3-expected.txt:
      * compositing/iframes/enter-compositing-iframe-expected.txt:
      * compositing/iframes/iframe-resize-expected.txt:
      * compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * compositing/iframes/overlapped-iframe-expected.txt:
      * compositing/iframes/page-cache-layer-tree-expected.txt:
      * compositing/iframes/scrolling-iframe-expected.txt:
      * compositing/visible-rect/iframe-and-layers-expected.txt:
      * fast/box-shadow/shadow-repaint-expected.txt: Added.
      * fast/box-shadow/shadow-repaint.html: Added.
      * platform/mac/fast/multicol/shadow-breaking-expected.png:
      * platform/mac/fast/multicol/shadow-breaking-expected.txt:
      * platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
      * platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
      * platform/mac/svg/css/arrow-with-shadow-expected.png:
      * platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
      * platform/mac/svg/css/clippath-with-shadow-expected.png:
      * platform/mac/svg/css/composite-shadow-example-expected.png:
      * platform/mac/svg/css/composite-shadow-example-expected.txt:
      * platform/mac/svg/css/composite-shadow-text-expected.txt:
      * platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
      * platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
      * platform/mac/svg/css/group-with-shadow-expected.png:
      * platform/mac/svg/css/group-with-shadow-expected.txt:
      * platform/mac/svg/css/mask-with-shadow-expected.png:
      * platform/mac/svg/css/path-with-shadow-expected.png:
      * platform/mac/svg/css/path-with-shadow-expected.txt:
      * platform/mac/svg/css/shadow-and-opacity-expected.png:
      * platform/mac/svg/css/shadow-and-opacity-expected.txt:
      * platform/mac/svg/css/shadow-changes-expected.png:
      * platform/mac/svg/css/shadow-changes-expected.txt:
      * platform/mac/svg/css/shadow-with-large-radius-expected.png:
      * platform/mac/svg/css/shadow-with-negative-offset-expected.png:
      * platform/mac/svg/css/stars-with-shadow-expected.png:
      * platform/mac/svg/css/stars-with-shadow-expected.txt:
      * platform/mac/svg/css/text-gradient-shadow-expected.png:
      * platform/mac/svg/css/text-gradient-shadow-expected.txt:
      * platform/mac/svg/css/text-shadow-multiple-expected.png:
      * platform/mac/svg/custom/repaint-shadow-expected.png:
      * platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
      * svg/css/arrow-with-shadow-expected.txt:
      * svg/css/circle-in-mask-with-shadow-expected.txt:
      * svg/css/clippath-with-shadow-expected.txt:
      * svg/css/mask-with-shadow-expected.txt:
      * svg/css/shadow-with-large-radius-expected.txt:
      * svg/css/shadow-with-negative-offset-expected.txt:
      * svg/css/text-shadow-multiple-expected.txt:
      * svg/custom/repaint-shadow-expected.txt:
      * svg/filters/shadow-on-rect-with-filter-expected.txt:
      * svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce1e8dbe
    • simon.fraser@apple.com's avatar
      window.internals.repaintRectsAsText() is hard to use because it doesn't force layout · bc887bf9
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114219
      
      Reviewed by Beth Dakin.
      
      Force layout when setTracksRepaints() is set to true, to flush out any pending
      repaints from a layout that hasn't happened yet. Also force layout in
      trackedRepaintRectsAsText(), so that any pending layout happpens and thus
      repaints.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::setTracksRepaints):
      (WebCore::FrameView::trackedRepaintRectsAsText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc887bf9
    • roger_fong@apple.com's avatar
      Kill old processes between runs on WinEWS bots. · 7db91bea
      roger_fong@apple.com authored
      Temporarily disable tests to let bots catch up again.
      
      * EWSTools/start-queue-win.sh:
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7db91bea
    • commit-queue@webkit.org's avatar
      LLInt conditional branch compilation fault on MIPS. · fd04cad4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114264
      
      Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-04-09
      Reviewed by Filip Pizlo.
      
      Fix conditional branch compilation in LLInt offlineasm.
      
      * offlineasm/mips.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd04cad4
    • cfleizach@apple.com's avatar
      AX: Bounding paths should be made available through accessibility · 2c282bf0
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113817
      
      Unreviewed build fix (again).
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c282bf0
    • andersca@apple.com's avatar
      If we fail to decode a message name, pass the message length as the name · 522261ae
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114305
      <rdar://problem/13605703>
      
      Reviewed by Sam Weinig.
      
      * Platform/CoreIPC/ArgumentDecoder.h:
      (CoreIPC::ArgumentDecoder::length):
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::processIncomingMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      522261ae
    • cfleizach@apple.com's avatar
      AX: Bounding paths should be made available through accessibility · cd3f5106
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113817
      
      Unreviewed build fix.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (WebTransformCGPathToNSBezierPath):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd3f5106
    • zhajiang@rim.com's avatar
      [BlackBerry] Main page is rendered at wrong large scale after back from any... · 5df081e2
      zhajiang@rim.com authored
      [BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
      https://bugs.webkit.org/show_bug.cgi?id=114296
      
      Patch by Jacky Jiang  <zhajiang@rim.com>.
      Reviewed by Rob Buis.
      
      PR: 308655
      We were relying on the load state Committed to reset m_userPerformedManualZoom
      and m_userPerformedManualScroll; however, the main resources of the
      articles on read.thestar.com were preloaded and the WebPage didn't get
      any load state change callbacks when going back to the main page from
      the articles. Therefore, m_userPerformedManualZoom had never been reset
      in this case and we picked up the wrong scale when restoring the main page.
      Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
      we are going back or forward.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::goBackOrForward):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5df081e2
    • benjamin@webkit.org's avatar
      Mark mouse-events-scaled-iframe.html as flaky · a0385b92
      benjamin@webkit.org authored
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0385b92
    • cfleizach@apple.com's avatar
      AX: Bounding paths should be made available through accessibility · fc2537ae
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113817
      
      Reviewed by Tim Horton.
      
      Minor fix from review feedback.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc2537ae
    • dino@apple.com's avatar
      Don't create another plugin process for restarted plugins · d2e255d0
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114233
      
      Reviewed by Geoff Garen.
      
      A snapshotting plugin starts in a separate process from
      regular plugins. This can be a little confusing to users
      because they might see two plugin processes. We can set
      the minimum life and timeout on the snapshotting process
      to much smaller values, since the process doesn't need
      to live that long. This will reduce some potential
      confusion. Also, since there is another plugin process
      running real plugins, it should be paged in if it needs
      to restart.
      
      There was, however, a bug in the process management. A
      restarted plugin received a special PluginProcess::Type,
      so that it could cross fade into the page nicely. This
      caused it to start a *third* plugin process. Instead
      mark a restarted flag directly on the PluginProxy and
      revert back to two process types.
      
      * PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.
      
      * UIProcess/Plugins/PluginProcessProxy.cpp: Add two new
          timeout values for snapshotting processes.
      (WebKit::PluginProcessProxy::didFinishLaunching): Chose which
          of the timeout pairs to use.
      
      * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
      (WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead
          look at the process flag to see if we are restarted.
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::create): Copy the new flag into constructor.
      (WebKit::PluginProxy::PluginProxy): Remember the flag.
      * WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin): When we are creating the proxy, separate
          the concept of snapshotting and restarting.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2e255d0
    • mhahnenberg@apple.com's avatar
      JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly · 35793949
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114235
      
      Reviewed by Geoffrey Garen.
      
      Due to the way that numCacheableSlots is currently calculated, checking an object's prototype for enumerable 
      properties causes us not to cache any properties at all. We should only cache properties on the object itself
      since we currently don't take advantage of any sort of name caching for properties in the prototype chain.
      This fix undoes a ~2% SunSpider regression caused by http://trac.webkit.org/changeset/147570.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::getOwnNonIndexPropertyNames):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35793949
    • glenn@skynav.com's avatar
      [webkitpy] Remove chromium deprecated port support. · 1cc9fb43
      glenn@skynav.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114228
      
      Reviewed by Ryosuke Niwa.
      
      * Scripts/webkitpy/common/config/ports.py:
      (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
      (ChromiumPort): Removed.
      (ChromiumAndroidPort): Removed.
      (ChromiumXVFBPort): Removed.
      * Scripts/webkitpy/common/config/ports_unittest.py:
      (DeprecatedPortTest.test_chromium_port): Removed.
      (DeprecatedPortTest.test_chromium_android_port): Removed.
      (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
      * Scripts/webkitpy/tool/steps/update_unittest.py:
      (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
      (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cc9fb43
    • timothy_horton@apple.com's avatar
      [wk2] IconDatabase images should be decoded in the WebProcess · f827b9bd
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112524
      <rdar://problem/10133914>
      
      Reviewed by Oliver Hunt.
      
      In the interests of keeping decoding of data coming in from the greater Internet
      in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.
      
      * UIProcess/WebIconDatabase.cpp:
      (WebKit::WebIconDatabase::setIconBitmapForIconURL):
      Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
      Use the new setIconBitmapForIconURL IconDatabase method.
      
      * UIProcess/WebIconDatabase.h:
      (WebIconDatabase):
      Rename setIconDataForIconURL to setIconBitmapForIconURL.
      
      * UIProcess/WebIconDatabase.messages.in: Ditto.
      
      * WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
      (WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
      In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.
      
      No testable behavior change.
      
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::updateIconRecord):
      Added updateIconRecord, which factors most of setIconDataForIconURL out so it can
      be shared with setIconBitmapForIconURL. This function will set either a bitmap or
      raw image data for the given icon URL.
      
      (WebCore::IconDatabase::setIconBitmapForIconURL):
      Added; make a copy of the bitmap for thread-safety purposes, and call updateIconRecord.
      
      (WebCore::IconDatabase::setIconDataForIconURL):
      Factored out of what is now updateIconRecord.
      
      * loader/icon/IconDatabase.h:
      (IconDatabase): Add setIconBitmapForIconURL and updateIconRecord.
      
      * loader/icon/IconDatabaseBase.h:
      (WebCore::IconDatabaseBase::setIconBitmapForIconURL): Added.
      * loader/icon/IconRecord.cpp:
      (WebCore::IconRecord::setImage): Set the image for an icon record directly (as opposed
      to setting the image data, which causes the image to be decoded in the WebProcess).
      * loader/icon/IconRecord.h:
      (IconRecord): Add setImage.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f827b9bd
    • cfleizach@apple.com's avatar
      AX: The bounding paths should be made available through accessibility · 81f8cd51
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113817
      
      Reviewed by David Kilzer.
      
      Source/WebCore: 
      
      This allows bounding paths to be returned for some web elements (image map areas and SVG shapes).
      This provides more accuracy when assistive technologies highlight elements.
      The Mac and iOS platforms share some code to help transform paths to their screen coordinates.
      
      Tests: platform/iphone-simulator/accessibility/element-paths.html
             platform/mac/accessibility/element-paths.html
      
      * accessibility/AccessibilityImageMapLink.cpp:
      (WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
      (WebCore):
      (WebCore::AccessibilityImageMapLink::elementPath):
      (WebCore::AccessibilityImageMapLink::elementRect):
      * accessibility/AccessibilityImageMapLink.h:
      (AccessibilityImageMapLink):
      (WebCore::AccessibilityImageMapLink::supportsPath):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::elementPath):
      (WebCore::AccessibilityObject::supportsPath):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore):
      (WebCore::AccessibilityRenderObject::supportsPath):
      (WebCore::AccessibilityRenderObject::elementPath):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper _accessibilityPath]):
      (-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
      (-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):
      (-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
      (-[WebAccessibilityObjectWrapper accessibilityFrame]):
      (-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
      * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
      (WebCore):
      * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
      (PathConversionInfo):
      (ConvertPathToScreenSpaceFunction):
      (-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
      (-[WebAccessibilityObjectWrapperBase convertPointToScreenSpace:]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
      (WebTransformCGPathToNSBezierPath):
      (-[WebAccessibilityObjectWrapper bezierPathFromPath:]):
      (-[WebAccessibilityObjectWrapper path]):
      (-[WebAccessibilityObjectWrapper position]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      Tools: 
      
      Add a pathDescription property for testing so that it's possible
      to verify that a path is being returned correctly.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (getPathDescriptionCallback):
      (AccessibilityUIElement::pathDescription):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
      (_CGPathEnumerationIteration):
      (AccessibilityUIElement::pathDescription):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::pathDescription):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
      (WTR::AccessibilityUIElement::pathDescription):
      (WTR):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::AccessibilityUIElement::pathDescription):
      (WTR):
      
      LayoutTests: 
      
      Add new tests for Mac and iOS to verify that path output works.
      Modify existing tests to indicate that there is a new AXAttribute, AXPath.
      
      * platform/iphone-simulator/accessibility/element-paths-expected.txt: Added.
      * platform/iphone-simulator/accessibility/element-paths.html: Added.
      * platform/mac/accessibility/document-links-expected.txt:
      * platform/mac/accessibility/element-paths-expected.txt: Added.
      * platform/mac/accessibility/element-paths.html: Added.
      * platform/mac/accessibility/image-map2-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81f8cd51
    • benjamin@webkit.org's avatar
      Remove the WebKit copy of GLU and the file using it · 9f50c06e
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114249
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
      Reviewed by Darin Adler.
      
      Source/ThirdParty: 
      
      * glu/.gitignore: Removed.
      * glu/LICENSE.txt: Removed.
      * glu/README.webkit: Removed.
      * glu/glu.gyp: Removed.
      * glu/gluos.h: Removed.
      * glu/internal_glu.h: Removed.
      * glu/libtess/GNUmakefile: Removed.
      * glu/libtess/Imakefile: Removed.
      * glu/libtess/README: Removed.
      * glu/libtess/alg-outline: Removed.
      * glu/libtess/dict-list.h: Removed.
      * glu/libtess/dict.c: Removed.
      * glu/libtess/dict.h: Removed.
      * glu/libtess/geom.c: Removed.
      * glu/libtess/geom.h: Removed.
      * glu/libtess/memalloc.c: Removed.
      * glu/libtess/memalloc.h: Removed.
      * glu/libtess/mesh.c: Removed.
      * glu/libtess/mesh.h: Removed.
      * glu/libtess/normal.c: Removed.
      * glu/libtess/normal.h: Removed.
      * glu/libtess/priorityq-heap.c: Removed.
      * glu/libtess/priorityq-heap.h: Removed.
      * glu/libtess/priorityq-sort.h: Removed.
      * glu/libtess/priorityq.c: Removed.
      * glu/libtess/priorityq.h: Removed.
      * glu/libtess/render.c: Removed.
      * glu/libtess/render.h: Removed.
      * glu/libtess/sweep.c: Removed.
      * glu/libtess/sweep.h: Removed.
      * glu/libtess/tess.c: Removed.
      * glu/libtess/tess.h: Removed.
      * glu/libtess/tessmono.c: Removed.
      * glu/libtess/tessmono.h: Removed.
      
      Source/WebCore: 
      
      * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f50c06e
    • akling@apple.com's avatar
      Throttle resize events during live window resize. · b704b429
      akling@apple.com authored
      <http://webkit.org/b/114292>
      <rdar://problem/13411454>
      
      Reviewed by Geoffrey Garen.
      
      Limit resize events to one at max every 0.2 seconds during live window resize.
      This mitigates heavy CPU usage during resize on pages with complex onresize handlers.
      If there's a pending resize event when the live resize ends, it fires immediately.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::sendResizeEvent):
      
          Factored out dispatch of the resize event after layout so we can call it on a timer
          instead of immediately while live window resize is active.
      
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::delayedResizeEventTimerFired):
      (WebCore::FrameView::willEndLiveResize):
      (WebCore::FrameView::scheduleResizeEvent):
      * page/FrameView.h:
      * platform/ScrollableArea.h:
      
          Made willStartLiveResize() and willEndLiveResize() virtual so we can override
          them on FrameView.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b704b429
    • commit-queue@webkit.org's avatar
      Add webp to supported image mime types if WEBP feature is enabled/used · 60947694
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112819
      
      Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-09
      Reviewed by Darin Adler.
      
      Add WebP to list of supported image types in MIMETypeRegistry if enabled.
      
      No new tests: WebP image decoding already covered by exisiting tests.
      
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60947694
    • commit-queue@webkit.org's avatar
      Whitespace in particular source code changes rendering; does not in Firefox · 6af48874
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100943
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-04-09
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      A render inline which requires a line box is considered a possible
      trailing object. So, ensureLineBoxInsideIgnoredSpaces will be called
      for it, even if it is placed after a text render ending with a single
      space.
      
      Tests: fast/text/whitespace/trailing-space-before-empty-span-1.html
             fast/text/whitespace/trailing-space-before-empty-span-2.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (TrailingObjects):
      (WebCore::TrailingObjects::appendBoxIfNeeded):
      (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
      
      LayoutTests:
      
      * fast/text/whitespace/trailing-space-before-empty-span-1-expected.html: Added.
      * fast/text/whitespace/trailing-space-before-empty-span-1.html: A test
          with a span whose text ends with a single span. A following span
          is empty but requires a line box (because it has some padding).
          The second span should be rendered.
      * fast/text/whitespace/trailing-space-before-empty-span-2-expected.html: Added.
      * fast/text/whitespace/trailing-space-before-empty-span-2.html: Same
          test as trailing-space-before-empty-span-1.html except that second
          span contains whitespace only text.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6af48874
    • abucur@adobe.com's avatar
      Use DOM ordering for list counts · 259fe836
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110352
      
      Reviewed by Elliott Sprehn.
      
      Source/WebCore:
      
      Currently the list items ordering is made by traversing the render tree. This gives bad results for:
      - list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
      - list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
      list so the numbering gets broken.
      
      To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
      so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
      namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
      for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
      pre-order traversal methods aware of the pseudo-elements.
      An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
      no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
      first parent of the <li> or the shadow root if there is no ancestor.
      The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
      To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
      of this method. The CSS counters and the list items now have the same traversal algorithm.
      
      In later patches I'll add tests that should cover the regions and shadow DOM use cases.
      Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
      Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
      
      Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
      and fast/dom/shadow/shadow-and-list-elements.html
      
      * dom/Node.cpp:
      (WebCore::Node::pseudoAwarePreviousSibling):
      (WebCore):
      (WebCore::Node::pseudoAwareNextSibling):
      (WebCore::Node::pseudoAwareFirstChild):
      (WebCore::Node::pseudoAwareLastChild):
      * dom/Node.h:
      (Node):
      * dom/NodeTraversal.cpp:
      (WebCore):
      (WebCore::NodeTraversal::previousIncludingPseudo):
      (NodeTraversal):
      (WebCore::NodeTraversal::nextIncludingPseudo):
      (WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
      * dom/NodeTraversal.h:
      (ElementTraversal):
      (NodeTraversal):
      (WebCore::ElementTraversal::previousIncludingPseudo):
      (WebCore::ElementTraversal::nextIncludingPseudo):
      (WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
      (WebCore::ElementTraversal::pseudoAwarePreviousSibling):
      * html/HTMLLIElement.cpp:
      (WebCore::HTMLLIElement::attach):
      * html/HTMLOListElement.cpp:
      (WebCore::HTMLOListElement::updateItemValues):
      (WebCore::HTMLOListElement::recalculateItemCount):
      * rendering/RenderCounter.cpp:
      (WebCore::previousInPreOrder):
      (WebCore::previousSiblingOrParent):
      (WebCore::parentElement):
      (WebCore::nextInPreOrder):
      * rendering/RenderListItem.cpp:
      (WebCore):
      (WebCore::enclosingList):
      (WebCore::RenderListItem::nextListItem):
      (WebCore::previousListItem):
      (WebCore::RenderListItem::calcValue):
      (WebCore::RenderListItem::explicitValueChanged):
      (WebCore::previousOrNextItem):
      (WebCore::RenderListItem::updateListMarkerNumbers):
      * rendering/RenderListItem.h:
      (RenderListItem):
      
      LayoutTests:
      
      The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
      inside the shadow tree no longer see the root <ol> element.
      The test fast/lists/positioned-count-crash.html has the correct rendering after changing
      the list counting to be in DOM order.
      
      * fast/dom/shadow/shadow-and-list-elements-expected.html:
      * fast/lists/positioned-count-crash-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      259fe836
    • rakuco@webkit.org's avatar
      [EFL] Declare TEST_THEME_DIR in a single place. · 58ad2803
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114285
      
      Reviewed by Anders Carlsson.
      
      .:
      
      Instead of adding the `THEME_DIR' preprocessor variable in many
      different CMakeList.txt files in the tree, declare it in
      OptionsEfl.cmake so that we avoid needlessly duplicating code around.
      
      While here, rename it to `TEST_THEME_DIR', which is the name used our
      WebKit2 infrastructure, to better reflect the purpose of this value.
      
      * Source/cmake/OptionsEfl.cmake: Add the TEST_THEME_DIR preprocessor
      definition.
      
      Source/WebKit2:
      
      * PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is
      now defined in OptionsEfl.cmake.
      
      Tools:
      
      Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
      
      * DumpRenderTree/efl/CMakeLists.txt:
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::createInspectorView):
      (DumpRenderTreeChrome::initialize):
      (DumpRenderTreeChrome::onDownloadRequest):
      * EWebLauncher/CMakeLists.txt:
      * EWebLauncher/main.c:
      (findThemePath):
      * EWebLauncher/url_bar.c:
      (url_bar_add):
      * MiniBrowser/efl/CMakeLists.txt:
      * MiniBrowser/efl/main.c:
      (window_create):
      * TestWebKitAPI/PlatformEfl.cmake:
      * TestWebKitAPI/efl/PlatformWebView.cpp:
      (TestWebKitAPI::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/PlatformEfl.cmake:
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58ad2803
    • commit-queue@webkit.org's avatar
      [BlackBerry] InputHandler: fix calls to HTMLInputElement methods · c66038fa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114283
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-09
      Reviewed by Rob Buis.
      
      Fix calls with wrong names.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::convertInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c66038fa
    • commit-queue@webkit.org's avatar
      [EFL] --minimal build fails with error: `setSeamlessIFramesEnabled' is not a... · 3cc006a9
      commit-queue@webkit.org authored
      [EFL] --minimal build fails with error: `setSeamlessIFramesEnabled' is not a member of `WebCore::RuntimeEnabledFeatures'
      https://bugs.webkit.org/show_bug.cgi?id=113951
      
      Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-09
      Reviewed by Laszlo Gombos.
      
      Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
      * ewk/ewk_view.cpp:
      (_ewk_view_priv_new):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cc006a9
    • rafael.lobo@openbossa.org's avatar
      [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds · 473281d4
      rafael.lobo@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112582
      
      Reviewed by Andreas Kling.
      
      Source/WebKit/qt:
      
      We've been exposing different time unit for requestAnimationFrame because
      of wrong conversion before serviceScriptedAnimations function calls.
      Fixed it to use seconds instead of milliseconds.
      
      * WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
      
      Source/WebKit2:
      
      We've been exposing different time unit for requestAnimationFrame because
      of wrong conversion before serviceScriptedAnimations function calls.
      Fixed it to use seconds instead of milliseconds.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
      
      LayoutTests:
      
      Add test to measure if the time interval is coherent with the unit
      of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
      
      * fast/animation/request-animation-frame-time-unit-expected.txt: Added.
      * fast/animation/request-animation-frame-time-unit.html: Added.
      * fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      473281d4
    • michael.bruning@digia.com's avatar
      [Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h. · 5eafa335
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114284
      
      Reviewed by Andreas Kling.
      
      The class QtWebPageFindClient was removed in r142073 when the functionality
      was folded into QQuickWebViewPrivate.
      
      * UIProcess/API/qt/qquickwebview_p.h:
      (WebKit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eafa335
    • bruno.abinader@basyskom.com's avatar
      [Texmap] TextureMapperLayer refactor for readiblity · bb711bb7
      bruno.abinader@basyskom.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114278
      
      Reviewed by Noam Rosenthal.
      
      Removes non-needed return values, function parameters and changes
      boolean values with enums for readibility.
      
      No behavioral changes, thus no tests.
      
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::computeTransformsRecursive):
      (WebCore::TextureMapperLayer::paintSelf):
      (WebCore::TextureMapperLayer::sortByZOrder):
      (WebCore::TextureMapperLayer::computeOverlapRegions):
      (WebCore::TextureMapperLayer::paintUsingOverlapRegions):
      (WebCore::commitSurface):
      (WebCore::TextureMapperLayer::paintWithIntermediateSurface):
      (WebCore::TextureMapperLayer::paintRecursive):
      * platform/graphics/texmap/TextureMapperLayer.h:
      (TextureMapperLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb711bb7
    • commit-queue@webkit.org's avatar
      [WebSocket] Ignore incoming message in CLOSING state · 92c18ef3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85934
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Change WebSocket implementation to suit the new WebSocket API, which
      states that we should ignore messages in CLOSING state.
      
      No new tests, updating existing tests.
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::didReceiveMessage):
      
      LayoutTests:
      
      * http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
      * http/tests/websocket/tests/hybi/client-close.html: Change expected results.
      * http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame
      instead of using regular message sending call.
      * http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()
      only after receiving all messages from server.
      * http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra
      WebSocket.close() call that caused regression.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c18ef3
    • commit-queue@webkit.org's avatar
      [GTK][AC] upversion of clutter and its dependecy · 88deaa45
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114016
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-09
      Reviewed by Gustavo Noronha Silva.
      
      Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
      
      .:
      
      * Source/autotools/Versions.m4:
      
      Tools:
      
      * gtk/jhbuild-optional.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88deaa45
    • commit-queue@webkit.org's avatar
      Web Inspector: Add Localized strings after r144154 and r135127 · 8e4d2402
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114269
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-09
      Reviewed by Timothy Hatcher.
      
      No new tests, no behavior change.
      
      * English.lproj/localizedStrings.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e4d2402
    • rakuco@webkit.org's avatar
      Remove empty directories · f0cd49ac
      rakuco@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0cd49ac
    • rakuco@webkit.org's avatar
      [EFL] Move tables/mozilla_expected_failures/bugs/bug89315.html's expectations to efl/. · 75dc2355
      rakuco@webkit.org authored
      There is no point in keeping the rebaselined results WK2-only. While
      here, actually unskip the test and provide a more accurate pixel result
      (the previous one was fine, but this one passes with --tolerance=0).
      
      * platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Removed.
      * platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
      * platform/efl/TestExpectations:
      * platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
      * platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75dc2355
    • michael.bruning@digia.com's avatar
      Fix GTK WebKit2 build after r148005. · abd10e01
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114270
      
      Reviewed by Andreas Kling.
      
      Fix GTK build break that went through the buildbot undetected.
      
      * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
      (webkit_file_chooser_request_get_selected_files):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abd10e01
    • antti@apple.com's avatar
      Throttle compositing layer flushes in subframes · 07a5be6e
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114267
      
      Reviewed by Andreas Kling.
      
      Throttle compositing layer flushes in all frames, not just the main one.
              
      This especially reduces flushes/repaints generated by ads in iframes.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadProgressingStatusChanged):
      * page/FrameView.cpp:
      (WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
      * page/FrameView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07a5be6e
    • rakuco@webkit.org's avatar
      [EFL] Gardening. · d6dbf580
      rakuco@webkit.org authored
      Now unskip a few compositing-related tests which are not failing
      anymore.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6dbf580
    • michael.bruning@digia.com's avatar
      [Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage. · 6e2c6543
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112850
      
      Reviewed by Andreas Kling.
      
      Removes direct references to WebPageProxy from QQuickWebPage and prepares the
      class for the move to QRawWebView. The access to the device scale factor and
      CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
      accessors to these properties are temporarily added. Eventually, this access will
      be provided through QRawWebView when the move is complete.
      
      This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
      to QQuickWebViewPrivate as it is mainly used from there.
      
      * UIProcess/API/qt/qquickwebpage.cpp:
      (QQuickWebPagePrivate::QQuickWebPagePrivate):
      (QQuickWebPagePrivate::paint):
      (QQuickWebPage::updatePaintNode):
      * UIProcess/API/qt/qquickwebpage_p.h:
      * UIProcess/API/qt/qquickwebpage_p_p.h:
      (QQuickWebPagePrivate):
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::initialize):
      (QQuickWebViewPrivate::handleMouseEvent):
      (QQuickWebViewPrivate::processDidCrash):
      (QQuickWebViewPrivate::coordinatedGraphicsScene):
      (QQuickWebViewPrivate::deviceScaleFactor):
      (QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
      (QQuickWebViewFlickablePrivate::onComponentComplete):
      (QQuickWebView::keyPressEvent):
      (QQuickWebView::keyReleaseEvent):
      (QQuickWebView::inputMethodEvent):
      (QQuickWebView::focusInEvent):
      (QQuickWebView::itemChange):
      (QQuickWebView::touchEvent):
      (QQuickWebView::wheelEvent):
      (QQuickWebView::hoverEnterEvent):
      (QQuickWebView::hoverMoveEvent):
      (QQuickWebView::hoverLeaveEvent):
      (QQuickWebView::dragMoveEvent):
      (QQuickWebView::dragEnterEvent):
      (QQuickWebView::dragLeaveEvent):
      (QQuickWebView::dropEvent):
      * UIProcess/API/qt/qquickwebview_p_p.h:
      (WebCore):
      (WebKit):
      (QQuickWebViewPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e2c6543
    • commit-queue@webkit.org's avatar
      Table border doesn't show up · afc43040
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=13709
      
      Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Border issue is fixed when border width is less than 0.8pt
      
      Border width is stored as unsigned. Border width (specified by
      author) is converted into pixels and some times this pixel value
      goes less than 1px. In this case, border width becomes 0px when
      pixel value (double type) assigned to unsigned type.
      Border width should not fall to 0px unless it is specified by
      author.
      
      Test: fast/borders/border-width-less-then-a-unit-of-pt.html
      
      * css/StyleBuilder.cpp:
      ApplyPropetyComputeLength class is replaced with 3 classes :
      ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
      and ApplyPropertyComputeTransformOriginZ.
      
      (WebCore::ApplyPropertyComputeBorderWidth::applyValue):
      (WebCore::ApplyPropertyComputeBorderWidth::createHandler):
      This class handles all width properties like border, outline,
      etc. These all properties stores value in integer types.
      Pixel value rounded of to 1px if value less than 1px and greater
      than 0px.
      
      (WebCore):
      (ApplyPropertyComputeTextSpacing):
      (WebCore::ApplyPropertyComputeTextSpacing::setValue):
      (WebCore::ApplyPropertyComputeTextSpacing::applyValue):
      (WebCore::ApplyPropertyComputeTextSpacing::createHandler):
      This class handles all spacing properties like word-spacing,
      letter-spacing etc.
      
      (ApplyPropertyComputeTransformOriginZ):
      (WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
      (WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
      (WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
      This class handles TransformOriginZ Property.
      
      (WebCore::StyleBuilder::StyleBuilder):
      ApplyProprtyComputeLength class usage changed with defined new
      classes as per class definition.
      
      LayoutTests:
      
      This test file have border width, outline offset, outline width, border
      spacing and column rule width properties test cases.
      * fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
      * fast/borders/border-width-less-then-a-unit-of-pt.html: Added.
      
      Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
      in efl, gtk and mac.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      
      Updated the test result for table/mozilla_expected_failures/bug89315.html
      Border is expected for table in test table/mozilla_expected_failures/bug89315.html
      * platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
      * platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
      * tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afc43040
    • commit-queue@webkit.org's avatar
      [Qt] Unskip and update inspector tests · b587f2c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114263
      
      Unreviewed gardening.
      
      Removed fast/events/autoscroll.html after r147830.
      Unskip inspector/timeline/timeline-animation-frame.html that is now passing.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-09
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b587f2c5
    • michael.bruning@digia.com's avatar
      [Qt][WK2] Use C API to enable Navigator Qt Object. · e22e804c
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112810
      
      Reviewed by Andreas Kling.
      
      Replace the direct reference to the WebPageProxy with use of
      C API.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e22e804c
    • rakuco@webkit.org's avatar
      [EFL] More gardening. · 2e37c198
      rakuco@webkit.org authored
      Unskip some tests which have stopped crashing after r147759,
      147933 and others.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e37c198