1. 25 Mar, 2010 5 commits
    • abarth@webkit.org's avatar
      2010-03-25 Adam Barth <abarth@webkit.org> · c1ac376b
      abarth@webkit.org authored
              Unreviewed.  Move OutputCapture to webkitpy.common.system.
              https://bugs.webkit.org/show_bug.cgi?id=36093
      
              * Scripts/webkitpy/common/net/bugzilla_unittest.py:
              * Scripts/webkitpy/common/net/credentials_unittest.py:
              * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
              * Scripts/webkitpy/outputcapture.py: Removed.
              * Scripts/webkitpy/tool/commands/commandtest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/commands/queuestest.py:
              * Scripts/webkitpy/tool/multicommandtool_unittest.py:
              * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
              * Scripts/webkitpy/tool/steps/steps_unittest.py:
              * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1ac376b
    • abarth@webkit.org's avatar
      2010-03-25 Adam Barth <abarth@webkit.org> · 9fad24e5
      abarth@webkit.org authored
              Unreviewed.
      
              Create webkitpy.common.net as described in
              https://bugs.webkit.org/show_bug.cgi?id=36093
      
              * Scripts/webkitpy/bugzilla.py: Removed.
              * Scripts/webkitpy/bugzilla_unittest.py: Removed.
              * Scripts/webkitpy/buildbot.py: Removed.
              * Scripts/webkitpy/buildbot_unittest.py: Removed.
              * Scripts/webkitpy/commitinfo.py:
              * Scripts/webkitpy/common/net: Added.
              * Scripts/webkitpy/common/net/__init__.py: Added.
              * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
              * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
              * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
              * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
              * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
              * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
              * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
              * Scripts/webkitpy/common/net/irc/ircbot.py:
              * Scripts/webkitpy/common/net/irc/ircproxy.py:
              * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
              * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
              * Scripts/webkitpy/common/net/irc/unittests.py:
              * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
              * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
              * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
              * Scripts/webkitpy/credentials.py: Removed.
              * Scripts/webkitpy/credentials_unittest.py: Removed.
              * Scripts/webkitpy/irc: Removed.
              * Scripts/webkitpy/irc/__init__.py: Removed.
              * Scripts/webkitpy/irc/ircbot.py: Removed.
              * Scripts/webkitpy/irc/ircproxy.py: Removed.
              * Scripts/webkitpy/irc/messagepump.py: Removed.
              * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
              * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
              * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
              * Scripts/webkitpy/irc/unittests.py: Removed.
              * Scripts/webkitpy/networktransaction.py: Removed.
              * Scripts/webkitpy/networktransaction_unittest.py: Removed.
              * Scripts/webkitpy/scm_unittest.py:
              * Scripts/webkitpy/statusserver.py: Removed.
              * Scripts/webkitpy/tool/bot/queueengine.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/queries.py:
              * Scripts/webkitpy/tool/commands/queries_unittest.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/commands/queuestest.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/main.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
              * Scripts/webkitpy/unittests.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fad24e5
    • cjerdonek@webkit.org's avatar
      In webkitpy, renamed MockBugzillaTool to MockTool. · be166968
      cjerdonek@webkit.org authored
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/tool/commands/commandtest.py:
      * Scripts/webkitpy/tool/commands/queries_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/commands/queuestest.py:
      * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
      * Scripts/webkitpy/tool/commands/upload_unittest.py:
      * Scripts/webkitpy/tool/mocktool.py:
      * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
      * Scripts/webkitpy/tool/steps/steps_unittest.py:
      * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be166968
    • abarth@webkit.org's avatar
      2010-03-25 Adam Barth <abarth@webkit.org> · e6a80c6d
      abarth@webkit.org authored
              Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
      
              * Scripts/webkitpy/mock_bugzillatool.py: Removed.
              * Scripts/webkitpy/tool/commands/commandtest.py:
              * Scripts/webkitpy/tool/commands/queries_unittest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/commands/queuestest.py:
              * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
              * Scripts/webkitpy/tool/commands/upload_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
              * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
              * Scripts/webkitpy/tool/steps/steps_unittest.py:
              * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6a80c6d
    • cjerdonek@webkit.org's avatar
      In Scripts/webkitpy, moved commands_references.py and the commands · 4d7c5781
      cjerdonek@webkit.org authored
      folder into webkitpy/patch.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=36483
      
      This is part of master bug 36093 to organize webkitpy.
      
      * Scripts/webkitpy/commands: Removed.
      * Scripts/webkitpy/commands/__init__.py: Removed.
      * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
      * Scripts/webkitpy/commands/commandtest.py: Removed.
      * Scripts/webkitpy/commands/download.py: Removed.
      * Scripts/webkitpy/commands/download_unittest.py: Removed.
      * Scripts/webkitpy/commands/early_warning_system.py: Removed.
      * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
      * Scripts/webkitpy/commands/openbugs.py: Removed.
      * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
      * Scripts/webkitpy/commands/queries.py: Removed.
      * Scripts/webkitpy/commands/queries_unittest.py: Removed.
      * Scripts/webkitpy/commands/queues.py: Removed.
      * Scripts/webkitpy/commands/queues_unittest.py: Removed.
      * Scripts/webkitpy/commands/queuestest.py: Removed.
      * Scripts/webkitpy/commands/sheriffbot.py: Removed.
      * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
      * Scripts/webkitpy/commands/upload.py: Removed.
      * Scripts/webkitpy/commands/upload_unittest.py: Removed.
      * Scripts/webkitpy/commands_references.py: Removed.
      * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
      * Scripts/webkitpy/tool/commands/commandtest.py:
      * Scripts/webkitpy/tool/commands/download.py:
      * Scripts/webkitpy/tool/commands/download_unittest.py:
      * Scripts/webkitpy/tool/commands/early_warning_system.py:
      * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
      * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
      * Scripts/webkitpy/tool/commands/queries_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/commands/queuestest.py:
      * Scripts/webkitpy/tool/commands/sheriffbot.py:
      * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
      * Scripts/webkitpy/tool/commands/upload.py:
      * Scripts/webkitpy/tool/commands/upload_unittest.py:
      * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
      * Scripts/webkitpy/tool/main.py:
      * Scripts/webkitpy/unittests.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7c5781
  2. 18 Mar, 2010 1 commit
    • eric@webkit.org's avatar
      2010-03-18 Adam Barth <abarth@webkit.org> · 8c1ae61f
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              First cut at SheriffBot
              https://bugs.webkit.org/show_bug.cgi?id=36253
      
              This patch contains a first attempt at writing a sheriff bot.
              Currently, we're missing the logic that actually finds the SVN revision
              numbers to complain about, but once we have that, we'll have the rest
              of the infrustructure to ping IRC and to file bugs.
      
              There's a lot to fill in for the SheriffBot, but this patch give us the
              framework in which to do it.
      
              This patch required a bit of refactoring of AbstractQueue because
              SheriffBot is the first bot that doesn't process patches (it processes
              SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
              hold the parts of AbstractQueue that are specific to dealing with
              patches.  Some of the choices here might not be obvious yet, but we can
              tweak them as our needs become clearer.
      
              * Scripts/webkitpy/commands/queues.py:
              * Scripts/webkitpy/commands/queues_unittest.py:
              * Scripts/webkitpy/commands/sheriffbot.py: Added.
              * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
              * Scripts/webkitpy/mock_bugzillatool.py:
                  Added a MockIRC object to the mock tool.
              * Scripts/webkitpy/multicommandtool.py:
                  Added a finalize method so the tool can disconnect from IRC
                  cleanly instead of just droping the socket.
              * Scripts/webkitpy/multicommandtool_unittest.py:
              * Scripts/webkitpy/patch/patcher.py:
                  Added support for talking to IRC.
              * Scripts/webkitpy/unittests.py:
                  We should add a commands/unittests.py file at some point to make
                  the commands module more self-contained.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c1ae61f
  3. 17 Mar, 2010 1 commit
    • eric@webkit.org's avatar
      2010-03-17 Eric Seidel <eric@webkit.org> · 58afae5c
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add more infrastructure for sheriff-bot, including making what-broke more awesome
              https://bugs.webkit.org/show_bug.cgi?id=36254
      
              * Scripts/webkitpy/bugzilla.py:
               - Made the various URL methods return None when passed None.
              * Scripts/webkitpy/bugzilla_unittest.py:
               - Test that the url methods work as expected.
              * Scripts/webkitpy/buildbot.py:
               - Add a static Build.build_url so that its possible to generate a build url without a Build object.
               - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
              * Scripts/webkitpy/changelogs.py:
               - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
               - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
               - Make ChangeLog.parse_latest_entry_from_file a public method.
              * Scripts/webkitpy/changelogs_unittest.py:
               - Add tests for new ChangeLog entry parsing.
              * Scripts/webkitpy/commands/queries.py:
               - Make "what-broke" not print "ok" builders, only failing ones.
               - Print much more information on failing builders, including links and authorship/reviewer information.
              * Scripts/webkitpy/commands/queues_unittest.py:
               - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
              * Scripts/webkitpy/mock_bugzillatool.py:
               - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
              * Scripts/webkitpy/patch/patcher.py:
               - Remove code which was broken now that this file has moved.
               - Code was also redundant now that SCM.find_checkout_root() exists.
              * Scripts/webkitpy/scm.py:
               - Greatly simplify modified_changelogs now that I understand list comprehensions.
               - Expect ChangeLogEntry objects instead of raw strings.
               - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
               - Add commit_with_message argument to all sites since someone half-added it before. :(
               - Get rid of copy/paste code using _status_regexp()
              * Scripts/webkitpy/scm_unittest.py:
               - Fix these tests!
               - Add new tests for new scm code.
               - Fix spelling of "awsome" to "awesome".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58afae5c
  4. 15 Mar, 2010 1 commit
  5. 13 Mar, 2010 1 commit
    • cjerdonek@webkit.org's avatar
      Moved webkitpy/mock.py into webkitpy/thirdparty since it is · f6062b1c
      cjerdonek@webkit.org authored
      third-party code.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=35499
      
      Updated the import statement in all of the below except where noted.
      
      * Scripts/webkitpy/bugzilla_unittest.py:
      * Scripts/webkitpy/commands/commandtest.py:
      * Scripts/webkitpy/commands/download_unittest.py:
      * Scripts/webkitpy/commands/early_warning_system_unittest.py:
      * Scripts/webkitpy/commands/queries_unittest.py:
      * Scripts/webkitpy/commands/queues_unittest.py:
      * Scripts/webkitpy/commands/queuestest.py:
      * Scripts/webkitpy/commands/upload.py:
      * Scripts/webkitpy/commands/upload_unittest.py:
      * Scripts/webkitpy/commands_references.py: Added.
        - Added a file containing an absolute import of Mock so that
          the imports in the commands folder can import from this file
          (similar to style_references.py).  This helps limit the
          number of affected files in future refactorings.
      
      * Scripts/webkitpy/credentials_unittest.py:
      * Scripts/webkitpy/mock.py: Removed.
        - Moved to Scripts/webkitpy/thirdparty.
      
      * Scripts/webkitpy/mock_bugzillatool.py:
      * Scripts/webkitpy/patchcollection_unittest.py:
      * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
      * Scripts/webkitpy/steps/steps_unittest.py:
      * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
      * Scripts/webkitpy/steps_references.py: Added.
        - Added a file containing an absolute import of Mock so that
          the imports in the steps folder can import from this file
          (similar to style_references.py).  This helps limit the
          number of affected files in future refactorings.
      
      * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
        - Also eliminated trailing white space and carriage returns.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6062b1c
  6. 25 Feb, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-02-25 Adam Barth <abarth@webkit.org> · cd4817a6
      abarth@webkit.org authored
              Reviewed by David Levin.
      
              EWS leaks memory slowly
              https://bugs.webkit.org/show_bug.cgi?id=35395
      
              The EWS bots leak memory very slowly.  If you run them for about a
              month, each one will take up around 1 GB of virutal memory.  If you run
              several of them on one machine, you'll eventually exhaust all available
              memory and grind the bots to a halt.
      
              This patch introduces a --exit-after-iteration option to the queues so
              that we run them for a finite amount of time.  Once they exit and
              restart, they'll reclaim the leaked memory.  I'm not sure how many
              iterations I'll end up running them for.  I'll need to sort that out
              operationally, but my initial guess is around 1000.
      
              * Scripts/webkitpy/commands/queues.py:
              * Scripts/webkitpy/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd4817a6
  7. 27 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-27 Eric Seidel <eric@webkit.org> · 7e9dacdd
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              webkit-patch needs an open-bugs command
              https://bugs.webkit.org/show_bug.cgi?id=30793
      
              * Scripts/test-webkitpy: import OpenBugsTest
              * Scripts/webkit-patch: import OpenBugs
              * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
              * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
              * Scripts/webkitpy/commands/queries_unittest.py: ditto
              * Scripts/webkitpy/commands/queues_unittest.py: ditto
              * Scripts/webkitpy/commands/upload_unittest.py: ditto
              * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e9dacdd
  8. 21 Jan, 2010 1 commit
  9. 14 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-14 Eric Seidel <eric@webkit.org> · 64674696
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
              https://bugs.webkit.org/show_bug.cgi?id=33638
      
              * Scripts/webkitpy/bugzilla.py:
               - Add Bug.id() to match Attachment.id()
               - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
               - Add back a missing variable to _validate_setter_email found by the new unit tests!
              * Scripts/webkitpy/commands/queries.py:
               - Add FIXMEs about the commands being confusingly named.
              * Scripts/webkitpy/commands/queries_unittest.py:
               - Update results to reflect the newly restructured mock bug cache.
              * Scripts/webkitpy/commands/queues.py:
               - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
               - Add a FIXME about eventually sorting the patches into some order.
              * Scripts/webkitpy/commands/queues_unittest.py:
               - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
              * Scripts/webkitpy/commands/upload_unittest.py:
               - Update results to match the newly restructured mock bug cache.
              * Scripts/webkitpy/mock_bugzillatool.py:
               - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
               - Add a few more attachments and bug dictionaries for use by the tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64674696
  10. 07 Jan, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-01-07 Adam Barth <abarth@webkit.org> · ccdbe3aa
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              bugzilla-tool needs a new name
              https://bugs.webkit.org/show_bug.cgi?id=28459
      
              Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
              make more sense with the new name.
      
              * Scripts/bugzilla-tool: Removed.
              * Scripts/webkit-patch: Added.
              * Scripts/webkit-tools-completion.sh:
              * Scripts/webkitpy/bugzilla_unittest.py:
              * Scripts/webkitpy/commands/download.py:
              * Scripts/webkitpy/commands/download_unittest.py:
              * Scripts/webkitpy/commands/early_warning_system.py:
              * Scripts/webkitpy/commands/queries.py:
              * Scripts/webkitpy/commands/queues.py:
              * Scripts/webkitpy/commands/queues_unittest.py:
              * Scripts/webkitpy/commands/upload.py:
              * Scripts/webkitpy/commands/upload_unittest.py:
              * Scripts/webkitpy/queueengine.py:
              * Scripts/webkitpy/steps/completerollout.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccdbe3aa
  11. 04 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-03 Eric Seidel <eric@webkit.org> · 81e8a766
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Rename Scripts/modules to Scripts/webkitpy
              https://bugs.webkit.org/show_bug.cgi?id=33128
      
              Just search-replace and svn mv commands.
      
              * Scripts/bugzilla-tool:
              * Scripts/check-webkit-style:
              * Scripts/modules: Removed.
              * Scripts/modules/BeautifulSoup.py: Removed.
              * Scripts/modules/__init__.py: Removed.
              * Scripts/modules/bugzilla.py: Removed.
              * Scripts/modules/bugzilla_unittest.py: Removed.
              * Scripts/modules/buildbot.py: Removed.
              * Scripts/modules/buildbot_unittest.py: Removed.
              * Scripts/modules/buildsteps.py: Removed.
              * Scripts/modules/buildsteps_unittest.py: Removed.
              * Scripts/modules/changelogs.py: Removed.
              * Scripts/modules/changelogs_unittest.py: Removed.
              * Scripts/modules/commands: Removed.
              * Scripts/modules/commands/__init__.py: Removed.
              * Scripts/modules/commands/commandtest.py: Removed.
              * Scripts/modules/commands/download.py: Removed.
              * Scripts/modules/commands/download_unittest.py: Removed.
              * Scripts/modules/commands/early_warning_system.py: Removed.
              * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
              * Scripts/modules/commands/queries.py: Removed.
              * Scripts/modules/commands/queries_unittest.py: Removed.
              * Scripts/modules/commands/queues.py: Removed.
              * Scripts/modules/commands/queues_unittest.py: Removed.
              * Scripts/modules/commands/queuestest.py: Removed.
              * Scripts/modules/commands/upload.py: Removed.
              * Scripts/modules/commands/upload_unittest.py: Removed.
              * Scripts/modules/comments.py: Removed.
              * Scripts/modules/committers.py: Removed.
              * Scripts/modules/committers_unittest.py: Removed.
              * Scripts/modules/cpp_style.py: Removed.
              * Scripts/modules/cpp_style_unittest.py: Removed.
              * Scripts/modules/credentials.py: Removed.
              * Scripts/modules/credentials_unittest.py: Removed.
              * Scripts/modules/diff_parser.py: Removed.
              * Scripts/modules/diff_parser_unittest.py: Removed.
              * Scripts/modules/executive.py: Removed.
              * Scripts/modules/executive_unittest.py: Removed.
              * Scripts/modules/grammar.py: Removed.
              * Scripts/modules/mock.py: Removed.
              * Scripts/modules/mock_bugzillatool.py: Removed.
              * Scripts/modules/multicommandtool.py: Removed.
              * Scripts/modules/multicommandtool_unittest.py: Removed.
              * Scripts/modules/outputcapture.py: Removed.
              * Scripts/modules/patchcollection.py: Removed.
              * Scripts/modules/queueengine.py: Removed.
              * Scripts/modules/queueengine_unittest.py: Removed.
              * Scripts/modules/scm.py: Removed.
              * Scripts/modules/scm_unittest.py: Removed.
              * Scripts/modules/statusbot.py: Removed.
              * Scripts/modules/stepsequence.py: Removed.
              * Scripts/modules/style: Removed.
              * Scripts/modules/style.py: Removed.
              * Scripts/modules/style_unittest.py: Removed.
              * Scripts/modules/text_style.py: Removed.
              * Scripts/modules/text_style_unittest.py: Removed.
              * Scripts/modules/user.py: Removed.
              * Scripts/modules/webkit_logging.py: Removed.
              * Scripts/modules/webkit_logging_unittest.py: Removed.
              * Scripts/modules/webkit_mechanize.py: Removed.
              * Scripts/modules/webkitport.py: Removed.
              * Scripts/modules/webkitport_unittest.py: Removed.
              * Scripts/test-webkit-python: Removed.
              * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
              * Scripts/validate-committer-lists:
              * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
              * Scripts/webkitpy/bugzilla.py:
              * Scripts/webkitpy/bugzilla_unittest.py:
              * Scripts/webkitpy/buildbot.py:
              * Scripts/webkitpy/buildbot_unittest.py:
              * Scripts/webkitpy/buildsteps.py:
              * Scripts/webkitpy/buildsteps_unittest.py:
              * Scripts/webkitpy/commands/commandtest.py:
              * Scripts/webkitpy/commands/download.py:
              * Scripts/webkitpy/commands/download_unittest.py:
              * Scripts/webkitpy/commands/early_warning_system.py:
              * Scripts/webkitpy/commands/early_warning_system_unittest.py:
              * Scripts/webkitpy/commands/queries.py:
              * Scripts/webkitpy/commands/queries_unittest.py:
              * Scripts/webkitpy/commands/queues.py:
              * Scripts/webkitpy/commands/queues_unittest.py:
              * Scripts/webkitpy/commands/queuestest.py:
              * Scripts/webkitpy/commands/upload.py:
              * Scripts/webkitpy/commands/upload_unittest.py:
              * Scripts/webkitpy/comments.py:
              * Scripts/webkitpy/credentials.py:
              * Scripts/webkitpy/credentials_unittest.py:
              * Scripts/webkitpy/executive.py:
              * Scripts/webkitpy/executive_unittest.py:
              * Scripts/webkitpy/mock_bugzillatool.py:
              * Scripts/webkitpy/multicommandtool.py:
              * Scripts/webkitpy/multicommandtool_unittest.py:
              * Scripts/webkitpy/queueengine.py:
              * Scripts/webkitpy/queueengine_unittest.py:
              * Scripts/webkitpy/scm.py:
              * Scripts/webkitpy/scm_unittest.py:
              * Scripts/webkitpy/statusbot.py:
              * Scripts/webkitpy/stepsequence.py:
              * Scripts/webkitpy/webkit_logging_unittest.py:
              * Scripts/webkitpy/webkitport_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81e8a766
  12. 20 Dec, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-12-20 Adam Barth <abarth@webkit.org> · d31a63fa
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [bzt] Optimize status updates for new dashboard
              https://bugs.webkit.org/show_bug.cgi?id=32797
      
              This patch makes the queues slightly more chatty with the web service.
              Also, this patch introduces some testing for the queues!
      
              * Scripts/modules/commands/early_warning_system.py:
              * Scripts/modules/commands/early_warning_system_unittest.py: Added.
              * Scripts/modules/commands/queues.py:
              * Scripts/modules/commands/queues_unittest.py:
              * Scripts/modules/commands/queuestest.py: Added.
              * Scripts/modules/mock_bugzillatool.py:
              * Scripts/modules/patchcollection.py:
              * Scripts/modules/queueengine.py:
              * Scripts/run-webkit-unittests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31a63fa
  13. 17 Dec, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-12-16 Eric Seidel <eric@webkit.org> · 04ef1fe0
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              post-diff is failing with exception under guess_reviewer_from_bug
              https://bugs.webkit.org/show_bug.cgi?id=32642
      
              Also refactor output capturing code into
              OutputCapture.assert_outputs to share more code between tests.
      
              * Scripts/modules/buildsteps.py:
               - Add the missing include.
               - Give guess_reviewer_from_bug a private underscore.
              * Scripts/modules/buildsteps_unittest.py: Added.
               - Test to make sure _guess_reviewer_from_bug works as expected.
              * Scripts/modules/commands/commandtest.py:
               - Custom code is now obsoleted by OutputCapture.assert_outputs
              * Scripts/modules/commands/queues_unittest.py:
               - ditto
              * Scripts/modules/credentials_unittest.py:
               - ditto
              * Scripts/modules/mock_bugzillatool.py:
               - fetch_reviewed_patches_from_bug can never return None
              * Scripts/modules/multicommandtool_unittest.py:
               - Custom code is now obsoleted by OutputCapture.assert_outputs
              * Scripts/modules/outputcapture.py:
               - Add assert_outputs to share more code between tests.
              * Scripts/run-webkit-unittests:
               - Add buildsteps_unittest.py
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ef1fe0
  14. 15 Dec, 2009 1 commit
    • eric@webkit.org's avatar
      2009-12-15 Eric Seidel <eric@webkit.org> · 9800e5c6
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              queue sub-commands need --status-host so they can report status
              https://bugs.webkit.org/show_bug.cgi?id=32313
      
              Make --status-bot a global option and make
              run_bugzilla_tool pass --status-bot to sub-commands.
      
              * Scripts/bugzilla-tool:
               - Rename _status to status_bot and make it non-lazy.
              * Scripts/modules/commands/queues.py:
               - Move status updates out of WorkQueue and into individual queues.
              * Scripts/modules/commands/queues_unittest.py:
               - Test that --status-host is passed to bugzilla-tool when run as subcommand.
              * Scripts/modules/mock_bugzillatool.py:
               - Add a MockStatusBot
              * Scripts/modules/workqueue.py:
               - Remove status_host and work_work_logs_directory callbacks.
               - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
              * Scripts/modules/workqueue_unittest.py:
               - Update unit tests to reflect new callbacks.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9800e5c6
  15. 09 Dec, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-12-09 Adam Barth <abarth@webkit.org> · 692de286
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [bzt] Implement abstract Steps
              https://bugs.webkit.org/show_bug.cgi?id=32212
      
              This is a fairly disruptive change that refactors how we build
              commands.  Instead of using a landing sequence, we can now assemble a
              sequence of steps directly.  We still use the landing sequence in the
              interim, but this will be removed soon.
      
              * Scripts/bugzilla-tool:
              * Scripts/modules/buildsteps.py:
              * Scripts/modules/commands/download.py:
              * Scripts/modules/commands/early_warning_system.py:
              * Scripts/modules/commands/queues.py:
              * Scripts/modules/commands/queues_unittest.py:
              * Scripts/modules/landingsequence.py:
              * Scripts/modules/mock_bugzillatool.py:
              * Scripts/modules/processutils.py: Removed.
              * Scripts/modules/scm.py:
              * Scripts/modules/scm_unittest.py:
              * Scripts/modules/webkitport.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692de286
  16. 02 Dec, 2009 1 commit
    • eric@webkit.org's avatar
      2009-12-02 Eric Seidel <eric@webkit.org> · bdf38888
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              REGRESSION(51595): commit-queue is throwing exceptions
              https://bugs.webkit.org/show_bug.cgi?id=32083
      
              * Scripts/modules/commands/queues.py:
               - Don't use default value of [] as it ends up getting shared.
               - Make log_progress accept arrays of ints as well as strings.
               - Return an exit code from execute()
              * Scripts/modules/commands/queues_unittest.py: Added.
               - Test to make sure log_progress will accept ints.
               - Test to make sure run_bugzilla_tool will accept ints.
              * Scripts/modules/workqueue.py:
               - Print the stack trace on unexpected exceptions for easier debugging.
              * Scripts/run-webkit-unittests:
               - Add queues_unittest.
      
              * Scripts/modules/commands/queues.py:
              * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
              * Scripts/modules/mock_bugzillatool.py:
              * Scripts/modules/workqueue.py:
              * Scripts/run-webkit-unittests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdf38888
  17. 27 Nov, 2009 1 commit
  18. 25 Nov, 2009 2 commits
  19. 24 Nov, 2009 1 commit
  20. 20 Nov, 2009 1 commit
  21. 11 Nov, 2009 1 commit
  22. 16 Oct, 2009 1 commit
    • eric@webkit.org's avatar
      2009-10-15 Yuzo Fujishima <yuzo@google.com> · b66f65b2
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Add mod_pywebsocket to test Web Sockets.
              http://code.google.com/p/pywebsocket/
              https://bugs.webkit.org/show_bug.cgi?id=27490
      
              * pywebsocket/COPYING: Added.
              * pywebsocket/MANIFEST.in: Added.
              * pywebsocket/README: Added.
              * pywebsocket/example/echo_client.py: Added.
              * pywebsocket/example/echo_wsh.py: Added.
              * pywebsocket/mod_pywebsocket/__init__.py: Added.
              * pywebsocket/mod_pywebsocket/dispatch.py: Added.
              * pywebsocket/mod_pywebsocket/handshake.py: Added.
              * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
              * pywebsocket/mod_pywebsocket/msgutil.py: Added.
              * pywebsocket/mod_pywebsocket/standalone.py: Added.
              * pywebsocket/mod_pywebsocket/util.py: Added.
              * pywebsocket/setup.py: Added.
              * pywebsocket/test/config.py: Added.
              * pywebsocket/test/mock.py: Added.
              * pywebsocket/test/run_all.py: Added.
              * pywebsocket/test/test_dispatch.py: Added.
              * pywebsocket/test/test_handshake.py: Added.
              * pywebsocket/test/test_mock.py: Added.
              * pywebsocket/test/test_msgutil.py: Added.
              * pywebsocket/test/test_util.py: Added.
              * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
              * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
              * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b66f65b2
  23. 09 Apr, 2009 1 commit