1. 02 Oct, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [Shadow] ShadowRoot should know whether <shadow> in its treescope · c19324ed
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97184
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-02
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      To quickly know whether some shadow dom subtree has any shadow element
      or not, added hasShadowRootInsertionPoint, registerShadowElement and
      unregisterShadowElement to class ShadowRoot. The register method or
      unregister method is used when a shadow element is inserted into
      document or removed from document. hasShadowInsertionPoint returns true
      if any shadow element is still registered with the given shadow root.
      Otherwise returns false. To test hasShadowInsertionPoint, added
      hasShadowInsertionPoint to Internals.
      
      Test: fast/dom/shadow/has-shadow-insertion-point.html
      
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::ShadowRoot):
      Initializes number of shadow elements.
      * dom/ShadowRoot.h:
      (WebCore::ShadowRoot::registerShadowElement):
      Increases number of shadow elements in shadow dom subtree by 1.
      (WebCore::ShadowRoot::unregisterShadowElement):
      Decreases number of shadow elements in shadow dom subtree by 1.
      (WebCore::ShadowRoot::hasShadowInsertionPoint):
      If number of shadow elements in shadow dom subtree is not equal to 0,
      returns true. Otherwise, returns false.
      * html/shadow/HTMLShadowElement.cpp:
      (WebCore::HTMLShadowElement::HTMLShadowElement):
      (WebCore::HTMLShadowElement::insertedInto):
      If a shadow element is inserted into document, register the shadow
      element with its shadow root.
      (WebCore::HTMLShadowElement::removedFrom):
       If a shadow element is removed from document, unregister the shadow
      element with its shadow root.
      * html/shadow/HTMLShadowElement.h:
      Added a new member variable which has information about whether
      this shadow element has been already registered with its shadow root
      or not.
      * testing/Internals.cpp:
      (WebCore::Internals::hasShadowInsertionPoint):
      Added a new testing method which returns whether the given shadow
      root has any shadow element or not.
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * fast/dom/shadow/has-shadow-insertion-point-expected.txt: Added.
      * fast/dom/shadow/has-shadow-insertion-point.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c19324ed
  2. 24 Sep, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: implement testing harness for pure protocol tests. · b3cd24a0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90675
      
      Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      .:
      
      Added export symbols required for Gtk+ to support the Inspector Protocol
      testing harness.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Implementing the testing harness as the APIs of Internals object not
      only reduced platform specific patching of DRTs but also minimized the
      the effort required to open up the new dummy inspector Frontend.
      
      The openDummyInspectorFrontend method will return the handle to newly
      created DOMWindow. This DOMWindow object can be utilized inside the test
      case to communicate using postMessage WebAPI.
      
      The newly created DOMWindow will host the protocol-test.html which
      will seed the necessary JS libraries to communicate with the
      InspectorBackend.
      
      Test: inspector-protocol/css-getSupportedCSSProperties.html
      
      * WebCore.exp.in:
      * WebCore.gypi:
      * inspector/InspectorClient.h:
      (InspectorClient):
      * testing/Internals.cpp:
      (InspectorFrontendClientDummy):
      (WebCore::InspectorFrontendClientDummy::~InspectorFrontendClientDummy):
      (WebCore):
      (WebCore::InspectorFrontendClientDummy::InspectorFrontendClientDummy):
      (InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::~InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
      (WebCore::Internals::consoleMessageArgumentCounts):
      (WebCore::Internals::openDummyInspectorFrontend):
      (WebCore::Internals::closeDummyInspectorFrontend):
      * testing/Internals.h:
      (WebCore):
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Adding the export symbol definitions required on Apple Windows and WinCairo
      ports to support Inspector Protocol testing harness.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Adding the resources required for the dummy frontend page to load minimal
      frontend. These resources provide the mechanism to talk to the Inspector Backend.
      
      Adding the inspector-protocol folder to host the relevant test cases
      utilizing the inspector protocol test harness. Added an example test
      case for getting all supported CSS properties using the inspector
      protocol and searching for a particular property being supported.
      
      * http/tests/inspector-protocol: Added.
      * http/tests/inspector-protocol/resources: Added.
      * http/tests/inspector-protocol/resources/InspectorTest.js: Added.
      (InspectorTest.sendCommand):
      (WebInspector.dispatchMessageFromBackend):
      (InspectorTest.log):
      (InspectorTest.completeTest):
      * http/tests/inspector-protocol/resources/protocol-test.html: Added.
      * http/tests/inspector-protocol/resources/protocol-test.js: Added.
      (log):
      (closeTest):
      (runTest):
      * inspector-protocol: Added.
      * inspector-protocol/css-getSupportedCSSProperties-expected.txt: Added.
      * inspector-protocol/css-getSupportedCSSProperties.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3cd24a0
  3. 14 Sep, 2012 1 commit
    • jchaffraix@webkit.org's avatar
      Revert r127457 and following fixes due to several hit-testing regressions · 5083f636
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96830
      
      Reviewed by Antonio Gomes.
      
      .:
      
      This change reverts r127457, r127863 and r128505.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      This change reverts r127457, r127863 and r128505.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      * rendering/HitTestRequest.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestLocation::HitTestLocation):
      * rendering/HitTestResult.h:
      (HitTestLocation):
      * rendering/RenderFrameBase.cpp:
      * rendering/RenderFrameBase.h:
      (RenderFrameBase):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hitTest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      This change reverts r127457, r127863 and r128505.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      Source/WebKit2:
      
      This change reverts r127457, r127863 and r128505.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      This change reverts r127457, r127863 and r128505. As the tests relies on the extended API
      after r127457, we cannot keep them.
      
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Removed.
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Removed.
      * fast/dom/nodesFromRect/resources/child-frame.html: Removed.
      * fast/dom/nodesFromRect/resources/nodesFromRect.js:
      (check):
      (checkShadowContent):
      * touchadjustment/iframe-boundary-expected.txt: Removed.
      * touchadjustment/iframe-boundary.html: Removed.
      * touchadjustment/resources/inner-content-page.html: Removed.
      * touchadjustment/resources/inner-navigation-frame.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5083f636
  4. 05 Sep, 2012 1 commit
    • kaustubh@motorola.com's avatar
      [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals · 478c5093
      kaustubh@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92735
      
      Reviewed by Hajime Morita.
      
      .: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Added symbols for GTK builds for corresponding APIs.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      Covered by existing test cases.
      
      * testing/Internals.cpp:
      (WebCore::Internals::numberOfPages):
      (WebCore):
      (WebCore::Internals::pageProperty):
      (WebCore::Internals::pageSizeAndMarginsInPixels):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/efl: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Source/WebKit/gtk: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/qt: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit/win: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl
      
      * WebFrame.cpp:
      (WebFrame::numberOfPages):
      
      Source/WebKit2: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Add symbols for Mac Win builds for corresponding newly added APIs.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      Tools: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * DumpRenderTree/TestRunner.cpp:
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::addUserStyleSheet):
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::DRTTestRunner):
      (DRTTestRunner::hasCustomPageSizeStyle):
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (DRTTestRunner):
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunner::evaluateScriptInIsolatedWorld):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      (TestRunner::abortModal):
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Fixed test cases to use internals API instead of testRunner.
      
      * printing/numberOfPages-expected.txt:
      * printing/page-count-layout-overflow.html:
      * printing/page-count-relayout-shrink.html:
      * printing/page-count-with-one-word.html:
      * printing/page-format-data-display-none.html:
      * printing/page-format-data-expected.txt:
      * printing/page-format-data.html:
      * printing/page-rule-selection-expected.txt:
      * printing/page-rule-selection.html:
      * printing/resources/paged-media-test-utils.js:
      (numberOfPagesShouldBe):
      * printing/script-tests/numberOfPages.js:
      * printing/zoomed-document.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      478c5093
  5. 04 Sep, 2012 1 commit
    • allan.jensen@nokia.com's avatar
      Allow child-frame content in hit-tests. · 8083183d
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95204
      
      .:
      
      Reviewed by Antonio Gomes.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Antonio Gomes.
      
      Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
      it is now handled by the hit test itself controlled by the AllowChildFrameContent
      flag in HitTestRequest.
      
      Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
             touchadjustment/iframe-boundary.html
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowChildFrameContent):
      (WebCore::HitTestRequest::childFrameHitTest):
      (WebCore::HitTestRequest::testChildFrameScrollBars):
      * rendering/RenderFrameBase.cpp:
      (WebCore::RenderFrameBase::nodeAtPoint):
      (WebCore):
      * rendering/RenderFrameBase.h:
      (RenderFrameBase):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hitTest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Reviewed by Antonio Gomes.
      
      Update symbols for the Windows build-system.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Reviewed by Antonio Gomes.
      Touch-Adjustment test by Kevin Ellis
      
      Two new tests for hit-testing child frame content. One for testing it as an option to
      nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.
      
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
      * fast/dom/nodesFromRect/resources/child-frame.html: Added.
      * fast/dom/nodesFromRect/resources/nodesFromRect.js:
      (check):
      (checkShadowContent):
      (checkRect):
      (nodesFromRectAsString):
      * touchadjustment/iframe-boundary-expected.txt: Added.
      * touchadjustment/iframe-boundary.html: Added.
      * touchadjustment/resources/inner-content-page.html: Added.
      * touchadjustment/resources/inner-navigation-frame.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8083183d
  6. 20 Aug, 2012 1 commit
    • adamk@chromium.org's avatar
      Remove redundant TOUCH_LISTENER event type · af87202c
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94524
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Code that needs to determine whether there are touch listeners
      can instead call Document::touchEventHandlerCount(), added in r107832.
      TOUCH_LISTENER didn't fit very well into the hasListenerType() model
      anyway, as there's not a 1:1 correspondance between the enum value and
      an event.
      
      * dom/Document.cpp:
      (WebCore::Document::addListenerTypeIfNeeded): Remove two bits of code:
      the bookkeeping for TOUCH_LISTENER, and the notification into
      ChromeClient (which is handled by calls to didAddTouchEventHandler in
      all the places that call addListenerTypeIfNeeded).
      (WebCore::Document::didRemoveTouchEventHandler): Remove bookkeeping for TOUCH_LISTENER.
      * dom/Document.h:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::restore): Call touchEventHandlerCount instead of hasListenerType.
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateType): ditto
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleTouchEvent): ditto
      * page/Frame.cpp:
      (WebCore::Frame::setDocument): ditto
      * testing/Internals.cpp: Remove hasTouchEventListener method since its
      data source no longer exists.
      * testing/Internals.h: ditto
      (Internals):
      * testing/Internals.idl: ditto
      
      Source/WebKit/chromium:
      
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove
      bookkeeping for TOUCH_LISTENER.
      
      LayoutTests:
      
      Removed tests for hasTouchEventListener as they're redundant
      with tests for touchEventHandlerCount.
      
      * fast/events/touch/touch-handler-count-expected.txt:
      * fast/events/touch/touch-handler-count.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af87202c
  7. 17 Aug, 2012 1 commit
    • allan.jensen@nokia.com's avatar
      Touch adjustment for context menu gestures · 4a470ad1
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94101
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Adds a new filter for detecting nodes that provides extra context-menu items,
      and use that in a new set of functions for adjusting context-menu gestures.
      
      Tests: touchadjustment/context-menu-select-text.html
             touchadjustment/context-menu.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::adjustGesturePosition):
      * page/EventHandler.h:
      (EventHandler):
      * page/TouchAdjustment.cpp:
      (WebCore::TouchAdjustment::nodeProvidesContextMenuItems):
      (TouchAdjustment):
      (WebCore::findBestContextMenuCandidate):
      * page/TouchAdjustment.h:
      * testing/Internals.cpp:
      (WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
      (WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      Two new tests for context-menu touch adjustment.
      
      * touchadjustment/context-menu-expected.txt: Added.
      * touchadjustment/context-menu-select-text-expected.txt: Added.
      * touchadjustment/context-menu-select-text.html: Added.
      * touchadjustment/context-menu.html: Added.
      * touchadjustment/resources/touchadjustment.js:
      (nodeToString):
      (testTouchPoint):
      (testTouchPointContextMenu):
      (adjustTouchPointContextMenu):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a470ad1
  8. 16 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      .: FormController, WebHistoryItem: Enable reading selected file names from document state · 2f936c8d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91231
      
      Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
      Reviewed by Jochen Eisinger.
      
      This change enables Chromium to set up file permissions properly when
      the session restore feature restores a page with selected files.
      
      * Source/autotools/symbols.filter: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.
      
      Source/WebCore: FormController, FileInputType: Enable reading selected file names from document state
      https://bugs.webkit.org/show_bug.cgi?id=91231
      
      Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
      Reviewed by Jochen Eisinger.
      
      This change enables Chromium to set up file permissions properly when
      the session restore feature restores a page with selected files.
      
      Test: fast/forms/file/selected-files-from-history-state.html
      
      * WebCore.exp.in: Exported FormController::getReferencedFilePaths.
      * html/FileInputType.cpp:
      (WebCore::FileInputType::filesFromFormControlState): Added. Extracts FileChooserFileInfos from a FormControlState.
      (WebCore):
      (WebCore::FileInputType::restoreFormControlState): Refactored to use filesFromFormControlState.
      * html/FileInputType.h:
      (FileInputType): Added filesFromFormControlState.
      * html/FormController.cpp:
      (SavedFormState): Added getReferencedFilePaths.
      (WebCore::SavedFormState::getReferencedFilePaths): Added. Extracts selected file paths from SavedFormState.
      (WebCore):
      (WebCore::FormController::setStateForNewFormElements): Refactored to use formStatesFromStateVector.
      (WebCore::FormController::formStatesFromStateVector):
      (WebCore::FormController::getReferencedFilePaths): Added. Static. Extracts selected file paths from a document state.
      * html/FormController.h:
      (FormController): Added getReferencedFilePaths and formStatesFromStateVector.
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::filesFromFileInputFormControlState): Added. Delegates to FileInputType::filesFromFormControlState.
      (WebCore):
      * html/HTMLInputElement.h: Added filesFromFileInputFormControlState.
      (HTMLInputElement):
      * testing/Internals.cpp:
      (WebCore::Internals::getReferencedFilePaths): Calls FormController::getReferencedFilePaths.
      (WebCore):
      * testing/Internals.h:
      (Internals): Added getReferencedFilePaths.
      * testing/Internals.idl: Added binding for getReferencedFilePaths.
      
      Source/WebKit/chromium: WebHistoryItem: Enable reading selected file names from document state
      https://bugs.webkit.org/show_bug.cgi?id=91231
      
      Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
      Reviewed by Jochen Eisinger.
      
      This change enables Chromium to set up file permissions properly when
      the session restore feature restores a page with selected files.
      
      * public/WebHistoryItem.h:
      (WebHistoryItem): Added getReferencedFilePaths.
      * src/WebHistoryItem.cpp:
      (WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state.
      (WebKit):
      
      Source/WebKit2: FormController, WebHistoryItem: Enable reading selected file names from document state
      https://bugs.webkit.org/show_bug.cgi?id=91231
      
      Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
      Reviewed by Jochen Eisinger.
      
      This change enables Chromium to set up file permissions properly when
      the session restore feature restores a page with selected files.
      
      * win/WebKit2.def: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.
      
      LayoutTests: FormController: Enable reading selected file names from document state
      https://bugs.webkit.org/show_bug.cgi?id=91231
      
      Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
      Reviewed by Jochen Eisinger.
      
      This change enables Chromium to set up file permissions properly when
      the session restore feature restores a page with selected files.
      
      * fast/forms/file/selected-files-from-history-state-expected.txt: Added.
      * fast/forms/file/selected-files-from-history-state.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f936c8d
  9. 15 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Rename window.internals.fastMallocStatistics to mallocStatistics · 4ba6cdbe
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94033
      
      Patch by Scott Graham <scottmg@chromium.org> on 2012-08-15
      Reviewed by Adam Barth.
      
      PerformanceTests:
      
      * resources/runner.js:
      (PerfTestRunner.storeHeapResults):
      (PerfTestRunner.getUsedMallocHeap):
      (PerfTestRunner.getAndPrintMemoryStatistics):
      (PerfTestRunner.initAndStartLoop):
      
      Source/WebCore:
      
      Mechanical rename. In preparation for plumbing allocation information
      from allocators that aren't "fastMalloc".
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * WebCore.vcproj/WebCoreTestSupport.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/DocumentLoader.h:
      (WebCore::DocumentLoader::didTellClientAboutLoad):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::loadResource):
      * testing/FastMallocStatistics.h: Removed.
      * testing/FastMallocStatistics.idl: Removed.
      * testing/Internals.cpp:
      (WebCore::Internals::mallocStatistics):
      * testing/Internals.h:
      (WebCore):
      (Internals):
      * testing/Internals.idl:
      * testing/MallocStatistics.h: Added.
      * testing/MallocStatistics.idl: Added.
      
      Tools:
      
      * GNUmakefile.am:
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PerfTest):
      * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
      (test_run_memory_test):
      
      LayoutTests:
      
      * fast/harness/fastmallocstatistics-object.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ba6cdbe
  10. 01 Aug, 2012 1 commit
  11. 30 Jul, 2012 4 commits
    • vsevik@chromium.org's avatar
      Web Inspector: Resource agent's reference to cached resources should be weak. · 58d6bc3d
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92108
      
      Reviewed by Pavel Feldman.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      NetworkResourcesData now stores a raw pointer to CachedResource.
      CachedResource now notifies InspectorInstrumentation that it will be destroyed.
      InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
      Destroyed resources content is saved to NetworkResourcesData.
      
      Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
             http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
      
      * WebCore.exp.in:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
      (WebCore::InspectorInstrumentation::registerInstrumentingAgents):
      (WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::willDestroyCachedResource):
      (WebCore):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didReceiveData):
      (WebCore::InspectorResourceAgent::willDestroyCachedResource):
      (WebCore):
      (WebCore::InspectorResourceAgent::getResponseBody):
      * inspector/InspectorResourceAgent.h:
      (InspectorResourceAgent):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::NetworkResourcesData::ResourceData::ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::setContent):
      (WebCore::NetworkResourcesData::setResourceContent):
      (WebCore::NetworkResourcesData::removeCachedResource):
      (WebCore):
      * inspector/NetworkResourcesData.h:
      (ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::base64Encoded):
      (WebCore::NetworkResourcesData::ResourceData::cachedResource):
      (NetworkResourcesData):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::~CachedResource):
      (WebCore::CachedResource::removeClient):
      (WebCore::CachedResource::deleteIfPossible):
      (WebCore):
      * loader/cache/CachedResource.h:
      (CachedResource):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
      (WebCore::CachedResourceLoader::garbageCollectDocumentResources):
      (WebCore::CachedResourceLoader::clearPreloads):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::evict):
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      (WebCore::Internals::garbageCollectDocumentResources):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58d6bc3d
    • shinyak@chromium.org's avatar
      Prohibit having AuthorShadowDOM of input or textarea element for a while and... · f5c4f8b3
      shinyak@chromium.org authored
      Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals.
      https://bugs.webkit.org/show_bug.cgi?id=92611
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Prohibit having AuthorShadowDOM of input elemnet unless a flag in RuntimeEnabledFeatures is not enabled.
      The flag can be enabled in Internals.
      
      The elements in UserAgentShadowDOM of input element assume that they have a renderer when the input
      element has a renderer. However, this does not hold when AuthorShadowDOM is added to input element.
      So until we fix the issue, we should disable to have AuthorShadowDOM for input element, because it may
      cause crashes and security problems.
      
      Tests: fast/dom/shadow/input-with-validation-without-shadow.html
             fast/dom/shadow/input-with-validation.html
             fast/dom/shadow/shadow-disable.html
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures):
      (WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
      (WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
      * dom/ShadowRoot.cpp:
      (WebCore::allowsAuthorShadowRoot): The input element or textarea element does not allow to have a ShadowDOM unless
      is a flag in RuntimeEnabledFeatures is not enabled.
      * html/HTMLInputElement.h:
      (WebCore::isHTMLInputElement):
      (WebCore):
      * html/HTMLTextAreaElement.h:
      (WebCore::isHTMLTextAreaElement):
      (WebCore):
      * testing/Internals.cpp:
      (WebCore::Internals::setAuthorShadowDOMForAnyElementEnabled):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if
      new WebKitShadowRoot() throws an exception.
      * fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available.
      * fast/dom/shadow/shadow-disable-expected.txt:
      * fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5c4f8b3
    • vsevik@chromium.org's avatar
      Unreviewed, rolling out r124000. · e7823052
      vsevik@chromium.org authored
      http://trac.webkit.org/changeset/124000
      https://bugs.webkit.org/show_bug.cgi?id=92632
      
      seems to have broken chromium Range_InstanceSizeUnknown unit
      test across many platforms (Requested by tomhudson on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didReceiveData):
      (WebCore::InspectorResourceAgent::getResponseBody):
      * inspector/InspectorResourceAgent.h:
      (InspectorResourceAgent):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::NetworkResourcesData::ResourceData::ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::setContent):
      (WebCore::NetworkResourcesData::setResourceContent):
      * inspector/NetworkResourcesData.h:
      (ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::cachedResource):
      (NetworkResourcesData):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::~CachedResource):
      (WebCore::CachedResource::removeClient):
      (WebCore::CachedResource::deleteIfPossible):
      (WebCore):
      * loader/cache/CachedResource.h:
      (CachedResource):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
      (WebCore::CachedResourceLoader::clearPreloads):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::evict):
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7823052
    • vsevik@chromium.org's avatar
      Web Inspector: Resource agent's reference to cached resources should be weak. · e14cf6de
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92108
      
      Reviewed by Pavel Feldman.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      NetworkResourcesData now stores a raw pointer to CachedResource.
      CachedResource now notifies InspectorInstrumentation that it will be destroyed.
      InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
      Destroyed resources content is saved to NetworkResourcesData.
      
      Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
             http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
      
      * WebCore.exp.in:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
      (WebCore::InspectorInstrumentation::registerInstrumentingAgents):
      (WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::willDestroyCachedResource):
      (WebCore):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didReceiveData):
      (WebCore::InspectorResourceAgent::willDestroyCachedResource):
      (WebCore):
      (WebCore::InspectorResourceAgent::getResponseBody):
      * inspector/InspectorResourceAgent.h:
      (InspectorResourceAgent):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::NetworkResourcesData::ResourceData::ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::setContent):
      (WebCore::NetworkResourcesData::setResourceContent):
      (WebCore::NetworkResourcesData::removeCachedResource):
      (WebCore):
      * inspector/NetworkResourcesData.h:
      (ResourceData):
      (WebCore::NetworkResourcesData::ResourceData::base64Encoded):
      (WebCore::NetworkResourcesData::ResourceData::cachedResource):
      (NetworkResourcesData):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::~CachedResource):
      (WebCore::CachedResource::removeClient):
      (WebCore::CachedResource::deleteIfPossible):
      (WebCore):
      * loader/cache/CachedResource.h:
      (CachedResource):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
      (WebCore::CachedResourceLoader::garbageCollectDocumentResources):
      (WebCore::CachedResourceLoader::clearPreloads):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::evict):
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      (WebCore::Internals::garbageCollectDocumentResources):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
      * http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
      * http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e14cf6de
  12. 26 Jul, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Add FastMalloc statistics in window.internals · 7a7180c3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91274
      
      Patch by Olivier Blin <olivier.blin@softathome.com> on 2012-07-26
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Test: fast/harness/fastmallocstatistics-object.html
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * WebCore.vcproj/WebCoreTestSupport.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * testing/FastMallocStatistics.h: Added.
      (WebCore):
      (FastMallocStatistics):
      (WebCore::FastMallocStatistics::create):
      (WebCore::FastMallocStatistics::reservedVMBytes):
      (WebCore::FastMallocStatistics::committedVMBytes):
      (WebCore::FastMallocStatistics::freeListBytes):
      (WebCore::FastMallocStatistics::FastMallocStatistics):
      * testing/FastMallocStatistics.idl: Added.
      * testing/Internals.cpp:
      (WebCore::Internals::fastMallocStatistics):
      (WebCore):
      * testing/Internals.h:
      (WebCore):
      (Internals):
      * testing/Internals.idl:
      
      Tools:
      
      * GNUmakefile.am:
      
      LayoutTests:
      
      * fast/harness/fastmallocstatistics-object-expected.txt: Added.
      * fast/harness/fastmallocstatistics-object.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a7180c3
    • kaustubh@motorola.com's avatar
      .: [DRT] LTC:: pageNumberForElementById() could be moved to Internals. · 8e91b051
      kaustubh@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Exporting Internals::pageNumber symbols for the Gtk build.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      Covered by existing test cases.
      
      * testing/Internals.cpp:
      (WebCore::Internals::counterValue):
      (WebCore):
      (WebCore::Internals::pageNumber):
      * testing/Internals.h:
      (Internals):
      (WebCore::Internals::pageNumber):
      * testing/Internals.idl:
      
      Source/WebKit/efl: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      
      Source/WebKit/gtk: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/qt: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit/win: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Moved the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebFrame.cpp: Added comment for removing the function. Removed implementation.
      
      Tools: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::setPrinting):
      * DumpRenderTree/chromium/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR):
      * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      (LayoutTestController):
      
      LayoutTests: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
      https://bugs.webkit.org/show_bug.cgi?id=92091
      
      Reviewed by Adam Barth.
      
      Move the pageNumberForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * printing/pageNumerForElementById-expected.txt:
      * printing/resources/paged-media-test-utils.js:
      (pageNumberForElementShouldBe):
      * printing/return-from-printing-mode.html:
      * printing/script-tests/pageNumerForElementById.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e91b051
  13. 23 Jul, 2012 2 commits
    • thakis@chromium.org's avatar
      [chromium] Show search tickmarks on css-styled scrollbars · c7ae2b49
      thakis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91949
      
      Reviewed by Adrienne Walker.
      
      This is done by letting RenderScrollbarTheme::paintTickmarks()
      delegate to the native ScrollbarTheme. To make this possible,
      move paintTickmarks() from ScrollbarThemeComposite to the
      superclass ScrollbarTheme.
      
      For testing, add internals.addTextMatchMarker() and add a pixel test.
      
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintTickmarks):
      Moved paintTickmarks() from ScrollbarThemeComposite to here.
      * platform/ScrollbarThemeComposite.h:
      Remove paintTickmarks().
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::paintTickmarks):
      Switch to drawing tickmarks as vectors, so they can be arbitrarily wide.
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      (ScrollbarThemeChromiumMac):
      Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::paint):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
      * rendering/RenderScrollbarTheme.cpp:
      (WebCore::RenderScrollbarTheme::paintTickmarks):
      Delegate to the native ScrollbarTheme for tickmark drawing.
      (WebCore):
      * rendering/RenderScrollbarTheme.h:
      (RenderScrollbarTheme):
      Override paintTickmarks().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7ae2b49
    • pierre.rossi@gmail.com's avatar
      Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client · 81b05961
      pierre.rossi@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91006
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      The rationale here is that the client doesn't need to know about the touch
      event handler count. needTouchEvents was already used for that purpose.
      
      Test: fast/events/touch/touch-handler-count.html
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::didAddTouchEventHandler): Only notify the client if needed.
      (WebCore::Document::didRemoveTouchEventHandler): Ditto. Also unset the TOUCH_LISTENER
      flag for the document if we reach a count of zero. The rationale being that
      hasListenerType() is relied upon in other places in combination with TOUCH_LISTENER for
      the same purpose.
      * dom/Document.h:
      (Document):
      (WebCore::Document::touchEventHandlerCount):
      * loader/EmptyClients.h:
      * page/ChromeClient.h:
      (ChromeClient):
      * page/Frame.cpp: Removed notifyChromeClientTouchEventHandlerCountChanged.
      (WebCore::Frame::setDocument): call needsTouchEvents directly.
      * page/Frame.h: Ditto.
      (Frame):
      * testing/Internals.cpp:
      (WebCore::Internals::hasTouchEventListener): expose Document::hasListenerType indirectly
      for additional testing.
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/blackberry:
      
      Removed numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/ChromeClientBlackBerry.h:
      
      Source/WebKit/chromium:
      
      Rename the functions to follow a more boolean logic.
      
      * public/WebViewClient.h:
      (WebKit::WebViewClient::hasTouchEventHandlers):
      * src/ChromeClientImpl.cpp:
      (WebKit):
      (WebKit::ChromeClientImpl::needTouchEvents):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::hasTouchEventHandlers):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      Source/WebKit/efl:
      
      Removed numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/qt:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2:
      
      Remove numTouchEventHandlersChanged stub.
      
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      LayoutTests:
      
      Extend the touch-handler-count test to also cover the hasListenerType logic.
      
      * fast/events/touch/touch-handler-count-expected.txt:
      * fast/events/touch/touch-handler-count.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81b05961
  14. 17 Jul, 2012 1 commit
    • tkent@chromium.org's avatar
      Internals: Remove injectPagePopupController() · 498cd57e
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91471
      
      Reviewed by Hajime Morita.
      
      r122558 introduced injectPagePopupController(), however we'd like to
      avoid adding such JavaScript binding code. We can avoid it by exposing a
      PagePopupController for a mock and injecting the following code to the
      popup document:
      
      <script>window.pagePopupController = window.internals.pagePopupController</script>
      
      No new tests. This is a kind of refactoring.
      
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::pagePopupController):
      Added. Accessor for PagePopupControler owned by the MockPagePopupDriver.
      * testing/InternalSettings.h:
      (InternalSettings): Declare pagePopupController() for Internals::pagePopupController().
      * testing/Internals.cpp:
      (WebCore::Internals::pagePopupController):
      Added. This uses InternalSettings::pagePopupController().
      * testing/Internals.h:
      (Internals): Declare pagePopupController() for Internals.idl.
      * testing/Internals.idl: Declare pagePopupController.
      
      * testing/MockPagePopupDriver.cpp:
      Moved m_pagePopupController from MockPagePopup to MockPagePopupDriver.
      (WebCore::MockPagePopup::MockPagePopup):
      Added a script element to prepare window.pagePopupController.
      Removed a callsite of injectPagePopupController().
      (WebCore::MockPagePopupDriver::openPagePopup):
      (WebCore::MockPagePopupDriver::closePagePopup):
      * testing/MockPagePopupDriver.h:
      (WebCore::MockPagePopupDriver::pagePopupController):
      Accessor for a PagePopupController object.
      (MockPagePopupDriver): Add RefPtr<PagePopupController> data member.
      
      * testing/v8/WebCoreTestSupport.cpp: Remove injectPagePopupController().
      * testing/v8/WebCoreTestSupport.h: ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      498cd57e
  15. 16 Jul, 2012 2 commits
    • commit-queue@webkit.org's avatar
      .: Expose an export for the iconUrl list so Internals can use it · 466dbd4b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-16
      Reviewed by Kent Tamura.
      
      * Source/autotools/symbols.filter: export iconURLs
      
      Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-16
      Reviewed by Kent Tamura.
      
      As it turns out, it can contain stale URLs in the case that some script
      manipulates the DOM, which breaks scripts trying to reset the favicon
      URL. Also added a method in Internals to allow tests to get the list of
      icon
      
      Tests: fast/dom/icon-url-change.html
             fast/dom/icon-url-list.html
      
      * WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
      * dom/Document.cpp:
      (WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
      (WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
      (WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
      * dom/Document.h:
      (Document): removed the addIconURL method which is no longer used
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
      (WebCore):
      (WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
      * html/HTMLLinkElement.h:
      (HTMLLinkElement): declared the icon type and size accessors
      * testing/Internals.cpp:
      (WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
      (WebCore):
      * testing/Internals.h:
      (Internals): declared the method for unit testing the icon URL list
      * testing/Internals.idl: exported the Document::iconURLs function
      
      Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-16
      Reviewed by Kent Tamura.
      
      * win/WebKit2.def: export the DocumentL::iconURLs function
      
      LayoutTests: Add some new unit tests to test the favicon changing dynamically
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-16
      Reviewed by Kent Tamura.
      
      * fast/dom/icon-url-change-expected.txt: Added.
      * fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
      * fast/dom/icon-url-list-expected.txt: Added.
      * fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
      * fast/dom/icon-url-property-expected.txt: update unit test expectations
      * fast/dom/icon-url-property.html: update and enable existing favicon test
      * platform/chromium/TestExpectations: reenable the url-property test
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      466dbd4b
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=91299 · 03247b23
      bdakin@apple.com authored
      Paginated views should restrict available height to column height
      -and corresponding-
      <rdar://problem/11152108>
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore: 
      
      Now that RenderViews can have columns, availableLogicalHeight needs to consider 
      that column height, much like how availableLogicalWidth already considers column 
      width.
      
      availableLogicalHeight is newly virtual, like the already-virtual 
      availableLogicalWidth.
      * rendering/RenderBox.h:
      (RenderBox):
      
      Check with the columnHeight.
      * rendering/RenderView.cpp:
      (WebCore):
      (WebCore::RenderView::availableLogicalHeight):
      * rendering/RenderView.h:
      
      setPagination now takes pageLength as an optional parameter. 
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setPagination):
      * testing/InternalSettings.h:
      (WebCore::InternalSettings::setPagination):
      (InternalSettings):
      * testing/InternalSettings.idl:
      * testing/Internals.cpp:
      (WebCore::Internals::setPagination):
      * testing/Internals.h:
      (WebCore::Internals::setPagination):
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests: 
      
      New test.
      * fast/multicol/resources/big-green.png: Added.
      * fast/multicol/shrink-to-column-height-for-pagination.html: Added.
      * platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
      * platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03247b23
  16. 11 Jul, 2012 2 commits
  17. 10 Jul, 2012 2 commits
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r122178. · 6aedce2f
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/122178
      https://bugs.webkit.org/show_bug.cgi?id=90857
      
      browser tests, PrerenderBrowserTest.PrerenderFavicon and other
      tests, started to fail (Requested by hayato on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-10
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * dom/Document.cpp:
      (WebCore::Document::iconURLs):
      (WebCore::Document::addIconURL):
      (WebCore::Document::setUseSecureKeyboardEntryWhenActive):
      * dom/Document.h:
      (Document):
      * html/HTMLLinkElement.cpp:
      * html/HTMLLinkElement.h:
      (HTMLLinkElement):
      * testing/Internals.cpp:
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      * fast/dom/icon-url-change-expected.txt: Removed.
      * fast/dom/icon-url-change.html: Removed.
      * fast/dom/icon-url-list-expected.txt: Removed.
      * fast/dom/icon-url-list.html: Removed.
      * fast/dom/icon-url-property-expected.txt:
      * fast/dom/icon-url-property.html:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aedce2f
    • abarth@webkit.org's avatar
      LayoutTestController.dumpConfigurationForViewport should move to Internals · 41d97fbf
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=45652
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This patch replaces LayoutTestController.dumpConfigurationForViewport
      with Internals.configurationForViewport. The old
      dumpConfigurationForViewport function just ended up calling WebCore
      functions anyway, so there's no benefit in implementing the API in the
      LayoutTestController.
      
      As a result, these tests can now run on every port.
      
      * testing/Internals.cpp:
      (WebCore::Internals::configurationForViewport):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/DumpRenderTreeSupport.cpp:
      * WebKitSupport/DumpRenderTreeSupport.h:
      (DumpRenderTreeSupport):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Tools:
      
      Remove dumpConfigurationForViewport from LayoutTestController. This API
      has been replaced by an API on Internals that does the same thing in a
      port-agnostic way.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      
      LayoutTests:
      
      Update these tests to use the Internals API rather than the
      LayoutTestController API.  This changed the output format of the tests
      slightly because the LayoutTestController API printed directly to
      stdout whereas the new API just returns a string that we pipe to stdout
      using alert.
      
      This patch also cleans up some platform-specific results for these
      tests that had drifted out of sync a bit. The patch also correctly
      marks the legacy tests as failing on GTK instead of checking in bogus
      expected results for them.
      
      This patch unskips these tests on Chromium. Once this patch lands, I'll
      go through an unskip them on the other ports as well.
      
      * fast/viewport/viewport-1-expected.txt:
      * fast/viewport/viewport-1.html:
      * fast/viewport/viewport-10-expected.txt:
      * fast/viewport/viewport-10.html:
      * fast/viewport/viewport-100-expected.txt:
      * fast/viewport/viewport-100.html:
      * fast/viewport/viewport-101-expected.txt:
      * fast/viewport/viewport-101.html:
      * fast/viewport/viewport-102-expected.txt:
      * fast/viewport/viewport-102.html:
      * fast/viewport/viewport-103-expected.txt:
      * fast/viewport/viewport-103.html:
      * fast/viewport/viewport-104-expected.txt:
      * fast/viewport/viewport-104.html:
      * fast/viewport/viewport-105-expected.txt:
      * fast/viewport/viewport-105.html:
      * fast/viewport/viewport-106-expected.txt:
      * fast/viewport/viewport-106.html:
      * fast/viewport/viewport-107-expected.txt:
      * fast/viewport/viewport-107.html:
      * fast/viewport/viewport-108-expected.txt:
      * fast/viewport/viewport-108.html:
      * fast/viewport/viewport-109-expected.txt:
      * fast/viewport/viewport-109.html:
      * fast/viewport/viewport-11-expected.txt:
      * fast/viewport/viewport-11.html:
      * fast/viewport/viewport-110-expected.txt:
      * fast/viewport/viewport-110.html:
      * fast/viewport/viewport-111-expected.txt:
      * fast/viewport/viewport-111.html:
      * fast/viewport/viewport-112-expected.txt:
      * fast/viewport/viewport-112.html:
      * fast/viewport/viewport-113-expected.txt:
      * fast/viewport/viewport-113.html:
      * fast/viewport/viewport-114-expected.txt:
      * fast/viewport/viewport-114.html:
      * fast/viewport/viewport-115-expected.txt:
      * fast/viewport/viewport-115.html:
      * fast/viewport/viewport-116-expected.txt:
      * fast/viewport/viewport-116.html:
      * fast/viewport/viewport-117-expected.txt:
      * fast/viewport/viewport-117.html:
      * fast/viewport/viewport-118-expected.txt:
      * fast/viewport/viewport-118.html:
      * fast/viewport/viewport-119-expected.txt:
      * fast/viewport/viewport-119.html:
      * fast/viewport/viewport-12-expected.txt:
      * fast/viewport/viewport-12.html:
      * fast/viewport/viewport-120-expected.txt:
      * fast/viewport/viewport-120.html:
      * fast/viewport/viewport-121-expected.txt:
      * fast/viewport/viewport-121.html:
      * fast/viewport/viewport-122-expected.txt:
      * fast/viewport/viewport-122.html:
      * fast/viewport/viewport-123-expected.txt:
      * fast/viewport/viewport-123.html:
      * fast/viewport/viewport-124-expected.txt:
      * fast/viewport/viewport-124.html:
      * fast/viewport/viewport-125-expected.txt:
      * fast/viewport/viewport-125.html:
      * fast/viewport/viewport-126-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-126-expected.txt.
      * fast/viewport/viewport-126.html:
      * fast/viewport/viewport-127-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-127-expected.txt.
      * fast/viewport/viewport-127.html:
      * fast/viewport/viewport-128-expected.txt:
      * fast/viewport/viewport-128.html:
      * fast/viewport/viewport-129-expected.txt:
      * fast/viewport/viewport-129.html:
      * fast/viewport/viewport-13-expected.txt:
      * fast/viewport/viewport-13.html:
      * fast/viewport/viewport-130-expected.txt:
      * fast/viewport/viewport-130.html:
      * fast/viewport/viewport-131-expected.txt:
      * fast/viewport/viewport-131.html:
      * fast/viewport/viewport-132-expected.txt:
      * fast/viewport/viewport-132.html:
      * fast/viewport/viewport-14-expected.txt:
      * fast/viewport/viewport-14.html:
      * fast/viewport/viewport-15-expected.txt:
      * fast/viewport/viewport-15.html:
      * fast/viewport/viewport-16-expected.txt:
      * fast/viewport/viewport-16.html:
      * fast/viewport/viewport-17-expected.txt:
      * fast/viewport/viewport-17.html:
      * fast/viewport/viewport-18-expected.txt:
      * fast/viewport/viewport-18.html:
      * fast/viewport/viewport-19-expected.txt:
      * fast/viewport/viewport-19.html:
      * fast/viewport/viewport-2-expected.txt:
      * fast/viewport/viewport-2.html:
      * fast/viewport/viewport-20-expected.txt:
      * fast/viewport/viewport-20.html:
      * fast/viewport/viewport-21-expected.txt:
      * fast/viewport/viewport-21.html:
      * fast/viewport/viewport-22-expected.txt:
      * fast/viewport/viewport-22.html:
      * fast/viewport/viewport-23-expected.txt:
      * fast/viewport/viewport-23.html:
      * fast/viewport/viewport-24-expected.txt:
      * fast/viewport/viewport-24.html:
      * fast/viewport/viewport-25-expected.txt:
      * fast/viewport/viewport-25.html:
      * fast/viewport/viewport-26-expected.txt:
      * fast/viewport/viewport-26.html:
      * fast/viewport/viewport-27-expected.txt:
      * fast/viewport/viewport-27.html:
      * fast/viewport/viewport-28-expected.txt:
      * fast/viewport/viewport-28.html:
      * fast/viewport/viewport-29-expected.txt:
      * fast/viewport/viewport-29.html:
      * fast/viewport/viewport-3-expected.txt:
      * fast/viewport/viewport-3.html:
      * fast/viewport/viewport-30-expected.txt:
      * fast/viewport/viewport-30.html:
      * fast/viewport/viewport-31-expected.txt:
      * fast/viewport/viewport-31.html:
      * fast/viewport/viewport-32-expected.txt:
      * fast/viewport/viewport-32.html:
      * fast/viewport/viewport-33-expected.txt:
      * fast/viewport/viewport-33.html:
      * fast/viewport/viewport-34-expected.txt:
      * fast/viewport/viewport-34.html:
      * fast/viewport/viewport-35-expected.txt:
      * fast/viewport/viewport-35.html:
      * fast/viewport/viewport-36-expected.txt:
      * fast/viewport/viewport-36.html:
      * fast/viewport/viewport-37-expected.txt:
      * fast/viewport/viewport-37.html:
      * fast/viewport/viewport-38-expected.txt:
      * fast/viewport/viewport-38.html:
      * fast/viewport/viewport-39-expected.txt:
      * fast/viewport/viewport-39.html:
      * fast/viewport/viewport-4-expected.txt:
      * fast/viewport/viewport-4.html:
      * fast/viewport/viewport-40-expected.txt:
      * fast/viewport/viewport-40.html:
      * fast/viewport/viewport-41-expected.txt:
      * fast/viewport/viewport-41.html:
      * fast/viewport/viewport-42-expected.txt:
      * fast/viewport/viewport-42.html:
      * fast/viewport/viewport-43-expected.txt:
      * fast/viewport/viewport-43.html:
      * fast/viewport/viewport-44-expected.txt:
      * fast/viewport/viewport-44.html:
      * fast/viewport/viewport-45-expected.txt:
      * fast/viewport/viewport-45.html:
      * fast/viewport/viewport-46-expected.txt:
      * fast/viewport/viewport-46.html:
      * fast/viewport/viewport-47-expected.txt:
      * fast/viewport/viewport-47.html:
      * fast/viewport/viewport-48-expected.txt:
      * fast/viewport/viewport-48.html:
      * fast/viewport/viewport-49-expected.txt:
      * fast/viewport/viewport-49.html:
      * fast/viewport/viewport-5-expected.txt:
      * fast/viewport/viewport-5.html:
      * fast/viewport/viewport-50-expected.txt:
      * fast/viewport/viewport-50.html:
      * fast/viewport/viewport-51-expected.txt:
      * fast/viewport/viewport-51.html:
      * fast/viewport/viewport-52-expected.txt:
      * fast/viewport/viewport-52.html:
      * fast/viewport/viewport-53-expected.txt:
      * fast/viewport/viewport-53.html:
      * fast/viewport/viewport-54-expected.txt:
      * fast/viewport/viewport-54.html:
      * fast/viewport/viewport-55-expected.txt:
      * fast/viewport/viewport-55.html:
      * fast/viewport/viewport-56-expected.txt:
      * fast/viewport/viewport-56.html:
      * fast/viewport/viewport-57-expected.txt:
      * fast/viewport/viewport-57.html:
      * fast/viewport/viewport-58-expected.txt:
      * fast/viewport/viewport-58.html:
      * fast/viewport/viewport-59-expected.txt:
      * fast/viewport/viewport-59.html:
      * fast/viewport/viewport-6-expected.txt:
      * fast/viewport/viewport-6.html:
      * fast/viewport/viewport-60-expected.txt:
      * fast/viewport/viewport-60.html:
      * fast/viewport/viewport-61-expected.txt:
      * fast/viewport/viewport-61.html:
      * fast/viewport/viewport-62-expected.txt:
      * fast/viewport/viewport-62.html:
      * fast/viewport/viewport-63-expected.txt:
      * fast/viewport/viewport-63.html:
      * fast/viewport/viewport-64-expected.txt:
      * fast/viewport/viewport-64.html:
      * fast/viewport/viewport-65-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-65-expected.txt.
      * fast/viewport/viewport-65.html:
      * fast/viewport/viewport-66-expected.txt:
      * fast/viewport/viewport-66.html:
      * fast/viewport/viewport-67-expected.txt:
      * fast/viewport/viewport-67.html:
      * fast/viewport/viewport-68-expected.txt:
      * fast/viewport/viewport-68.html:
      * fast/viewport/viewport-69-expected.txt:
      * fast/viewport/viewport-69.html:
      * fast/viewport/viewport-7-expected.txt:
      * fast/viewport/viewport-7.html:
      * fast/viewport/viewport-70-expected.txt:
      * fast/viewport/viewport-70.html:
      * fast/viewport/viewport-71-expected.txt:
      * fast/viewport/viewport-71.html:
      * fast/viewport/viewport-72-expected.txt:
      * fast/viewport/viewport-72.html:
      * fast/viewport/viewport-73-expected.txt:
      * fast/viewport/viewport-73.html:
      * fast/viewport/viewport-74-expected.txt:
      * fast/viewport/viewport-74.html:
      * fast/viewport/viewport-75-expected.txt:
      * fast/viewport/viewport-75.html:
      * fast/viewport/viewport-76-expected.txt:
      * fast/viewport/viewport-76.html:
      * fast/viewport/viewport-77-expected.txt:
      * fast/viewport/viewport-77.html:
      * fast/viewport/viewport-78-expected.txt:
      * fast/viewport/viewport-78.html:
      * fast/viewport/viewport-79-expected.txt:
      * fast/viewport/viewport-79.html:
      * fast/viewport/viewport-8-expected.txt:
      * fast/viewport/viewport-8.html:
      * fast/viewport/viewport-80-expected.txt:
      * fast/viewport/viewport-80.html:
      * fast/viewport/viewport-81-expected.txt:
      * fast/viewport/viewport-81.html:
      * fast/viewport/viewport-82-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-82-expected.txt.
      * fast/viewport/viewport-82.html:
      * fast/viewport/viewport-83-expected.txt:
      * fast/viewport/viewport-83.html:
      * fast/viewport/viewport-84-expected.txt: Renamed from LayoutTests/platform/efl/fast/viewport/viewport-87-expected.txt.
      * fast/viewport/viewport-84.html:
      * fast/viewport/viewport-85-expected.txt:
      * fast/viewport/viewport-85.html:
      * fast/viewport/viewport-86-expected.txt:
      * fast/viewport/viewport-86.html:
      * fast/viewport/viewport-87-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-87-expected.txt.
      * fast/viewport/viewport-87.html:
      * fast/viewport/viewport-88-expected.txt:
      * fast/viewport/viewport-88.html:
      * fast/viewport/viewport-9-expected.txt:
      * fast/viewport/viewport-9.html:
      * fast/viewport/viewport-90-expected.txt:
      * fast/viewport/viewport-90.html:
      * fast/viewport/viewport-91-expected.txt:
      * fast/viewport/viewport-91.html:
      * fast/viewport/viewport-legacy-handheldfriendly-expected.txt:
      * fast/viewport/viewport-legacy-handheldfriendly.html:
      * fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt:
      * fast/viewport/viewport-legacy-mobileoptimized-2.html:
      * fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt:
      * fast/viewport/viewport-legacy-mobileoptimized-3.html:
      * fast/viewport/viewport-legacy-mobileoptimized-expected.txt:
      * fast/viewport/viewport-legacy-mobileoptimized.html:
      * fast/viewport/viewport-legacy-ordering-1-expected.txt:
      * fast/viewport/viewport-legacy-ordering-1.html:
      * fast/viewport/viewport-legacy-ordering-2-expected.txt:
      * fast/viewport/viewport-legacy-ordering-2.html:
      * fast/viewport/viewport-legacy-ordering-3-expected.txt:
      * fast/viewport/viewport-legacy-ordering-3.html:
      * fast/viewport/viewport-legacy-ordering-4-expected.txt:
      * fast/viewport/viewport-legacy-ordering-4.html:
      * fast/viewport/viewport-legacy-ordering-5-expected.txt:
      * fast/viewport/viewport-legacy-ordering-5.html:
      * fast/viewport/viewport-legacy-ordering-6-expected.txt:
      * fast/viewport/viewport-legacy-ordering-6.html:
      * fast/viewport/viewport-legacy-ordering-7-expected.txt:
      * fast/viewport/viewport-legacy-ordering-7.html:
      * fast/viewport/viewport-legacy-ordering-8-expected.txt:
      * fast/viewport/viewport-legacy-ordering-8.html:
      * fast/viewport/viewport-legacy-ordering-9-expected.txt:
      * fast/viewport/viewport-legacy-ordering-9.html:
      * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt:
      * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
      * fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt:
      * fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
      * fast/viewport/viewport-legacy-xhtmlmp.html:
      * fast/viewport/viewport-warnings-1-expected.txt:
      * fast/viewport/viewport-warnings-1.html:
      * fast/viewport/viewport-warnings-2-expected.txt:
      * fast/viewport/viewport-warnings-2.html:
      * fast/viewport/viewport-warnings-3-expected.txt:
      * fast/viewport/viewport-warnings-3.html:
      * fast/viewport/viewport-warnings-4-expected.txt:
      * fast/viewport/viewport-warnings-4.html:
      * fast/viewport/viewport-warnings-5-expected.txt:
      * fast/viewport/viewport-warnings-5.html:
      * fast/viewport/viewport-warnings-6-expected.txt:
      * fast/viewport/viewport-warnings-6.html:
      * platform/chromium/TestExpectations:
      * platform/efl/fast/viewport/viewport-126-expected.txt: Removed.
      * platform/efl/fast/viewport/viewport-127-expected.txt: Removed.
      * platform/efl/fast/viewport/viewport-65-expected.txt: Removed.
      * platform/efl/fast/viewport/viewport-82-expected.txt: Removed.
      * platform/efl/fast/viewport/viewport-84-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/viewport/viewport-84-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Removed.
      * platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41d97fbf
  18. 09 Jul, 2012 1 commit
    • commit-queue@webkit.org's avatar
      .: Expose an export for the iconUrl list so Internals can use it · 546c67d5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-09
      Reviewed by Kent Tamura.
      
      * Source/autotools/symbols.filter: export iconURLs
      
      Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-09
      Reviewed by Kent Tamura..
      
      As it turns out, it can contain stale URLs in the case that some script
      manipulates the DOM, which breaks scripts trying to reset the favicon
      URL. Also added a method in Internals to allow tests to get the list of
      icon
      
      Tests: fast/dom/icon-url-change.html
             fast/dom/icon-url-list.html
      
      * WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
      * dom/Document.cpp:
      (WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
      (WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
      (WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
      * dom/Document.h:
      (Document): removed the addIconURL method which is no longer used
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
      (WebCore):
      (WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
      * html/HTMLLinkElement.h:
      (HTMLLinkElement): declared the icon type and size accessors
      * testing/Internals.cpp:
      (WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
      (WebCore):
      * testing/Internals.h:
      (Internals): declared the method for unit testing the icon URL list
      * testing/Internals.idl: exported the Document::iconURLs function
      
      Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-09
      Reviewed by Kent Tamura.
      
      * win/WebKit2.def: export the DocumentL::iconURLs function
      
      LayoutTests: Add some new unit tests to test the favicon changing dynamically
      https://bugs.webkit.org/show_bug.cgi?id=88665
      
      Patch by Pete Williamson <petewil@google.com> on 2012-07-09
      Reviewed by Kent Tamura.
      
      * fast/dom/icon-url-change-expected.txt: Added.
      * fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
      * fast/dom/icon-url-list-expected.txt: Added.
      * fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
      * fast/dom/icon-url-property-expected.txt: update unit test expectations
      * fast/dom/icon-url-property.html: update and enable existing favicon test
      * platform/chromium/TestExpectations: reenable the url-property test
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      546c67d5
  19. 26 Jun, 2012 2 commits
    • gyuyoung.kim@samsung.com's avatar
      Change return type in bandwidth attribute of network information API · acdcc66d
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89959
      
      Reviewed by Adam Barth.
      
      According to network information API spec, bandwidth attribute should return double type.
      But, existing implementation has used *long* and *unsigned int* types.
      
      Source/WebCore:
      
      No new tests. Covered by existing tests.
      
      * Modules/networkinfo/NetworkInfo.cpp:
      (WebCore::NetworkInfo::NetworkInfo):
      * Modules/networkinfo/NetworkInfo.h:
      (WebCore::NetworkInfo::create):
      (WebCore::NetworkInfo::bandwidth):
      (NetworkInfo):
      * Modules/networkinfo/NetworkInfoClient.h:
      (NetworkInfoClient):
      * Modules/networkinfo/NetworkInfoConnection.cpp:
      (WebCore::NetworkInfoConnection::bandwidth):
      * Modules/networkinfo/NetworkInfoConnection.h:
      (NetworkInfoConnection):
      * testing/Internals.cpp:
      (WebCore::Internals::setNetworkInformation):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/NetworkInfoClientEfl.cpp:
      (WebCore::NetworkInfoClientEfl::bandwidth):
      * WebCoreSupport/NetworkInfoClientEfl.h:
      (NetworkInfoClientEfl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acdcc66d
    • commit-queue@webkit.org's avatar
      Crash at WebCore::TextIterator::handleTextBox · 6310cb67
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89526
      <rdar://problem/10305315>
      
      Patch by Alice Cheng <alice_cheng@apple.com> on 2012-06-26
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
      This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range.  To fix this,
      recalculate the range for marking after SpellingCorrectionCommand.
      
      Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html
      
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::applyAlternativeTextToRange):
      * editing/Editor.cpp:  (WebCore::Editor::markAndReplaceFor):
      * testing/Internals.cpp:
      (WebCore):
      (WebCore::Internals::hasAutocorrectedMarker):
      * testing/Internals.h: (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
      * platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6310cb67
  20. 22 Jun, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [Shadow] parentTreeScope() of nested shadow DOM subtree returns document(). · da0060a4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89172
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-22
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      Added setParentTreeScope to set parent treescope of shadow root to be
      host's treescope in ElementShadow::addShadowRoot.
      
      Test: fast/dom/shadow/parent-tree-scope-in-shadow.html
      
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::addShadowRoot):
      Added setParentTreeScope.
      * testing/Internals.cpp:
      (WebCore::Internals::parentTreeScope):
      Newly added. This method returns a parent tree scope's root node of
      a given node, because a tree scope's root node is either document node
      or shadow root node and both nodes derive from TreeScope. So root nodes
      are treated as TreeScope.
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      Added parentTreeScope.
      
      LayoutTests:
      
      * fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt: Added.
      * fast/dom/shadow/parent-tree-scope-in-shadow.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da0060a4
  21. 19 Jun, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Add a scheme registry for bypassing Content Security Policy. · 828d2390
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89373
      
      Patch by Mike West <mkwst@chromium.org> on 2012-06-19
      Reviewed by Adam Barth.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      The Content Security Policy specification notes that "Enforcing a CSP
      policy should not interfere with the operation of user-supplied scripts
      such as third-party user-agent add-ons and JavaScript bookmarklets."
      (https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model)
      This use case can be at least partially addressed by adding a scheme
      registry for certain types of URLs whose resources should be loaded
      regardless of a page's defined policy directives.
      
      See http://crbug.com/133223 for additional context.
      
      Test: http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
      
      * WebCore.exp.in:
          Exporting new symbols for use by Internals.
      * page/ContentSecurityPolicy.cpp:
      (WebCore::isAllowedByAllWithURL):
          Adding a check against the new SchemeRegistry method to determine
          whether or not we should proceed with checking the URL against the
          policy.
      * platform/SchemeRegistry.cpp:
      (WebCore::CSPBypassingSchemes):
      (WebCore):
      (WebCore::SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy):
      (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
      (WebCore::SchemeRegistry::schemeShouldBypassContentSecurityPolicy):
      * platform/SchemeRegistry.h:
      (SchemeRegistry):
          Adding the scheme registry for CSP-bypassing URL schemes.
      * testing/Internals.cpp:
      (WebCore):
      (WebCore::Internals::registerURLSchemeAsBypassingContentSecurityPolicy):
      (WebCore::Internals::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
          Adding a method to Internals so that we can write a layout test.
      
      Source/WebKit/chromium:
      
      * public/WebSecurityPolicy.h:
      (WebSecurityPolicy):
      * src/WebSecurityPolicy.cpp:
      (WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy):
      (WebKit):
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      828d2390
  22. 14 Jun, 2012 1 commit
    • tkent@chromium.org's avatar
      Validate form state strings in FormController::setStateForNewFormElements() · bcc71634
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88768
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.
      
      Source/WebCore:
      
      Reject invalid form state vectors. This state vectors are generated by
      WebKit itself. However it can be invalid because
      - Serialized state vectors can be corrupted
      - A future version of WebKit might change the format
      
      So we had better reject unexpected state vectors as possible.
      
      Test: fast/forms/state-restore-broken-state.html
      
      * WebCore.exp.in: Expose some symbols used by Internals.cpp.
      * html/FormController.cpp:
      (WebCore::isNotFormControlTypeCharacter): A helper for state validation.
      (WebCore::FormController::setStateForNewFormElements):
      Reject state vectors of which size is not a multiple of 3, or a type name is invalid.
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      Returns a form state vector of the previous document.
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      Sets a form state vector for the previous document.
      * testing/Internals.h: Declare new functions.
      * testing/Internals.idl: ditto.
      
      Source/WebKit2:
      
      * win/WebKit2.def: Expose some symbols used by Internals.cpp.
      * win/WebKit2CFLite.def: ditto.
      
      LayoutTests:
      
      * fast/forms/resources/state-restore-broken-state-1.html: Added.
      * fast/forms/resources/state-restore-broken-state-2.html: Added.
      * fast/forms/state-restore-broken-state-expected.txt: Added.
      * fast/forms/state-restore-broken-state.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcc71634
  23. 13 Jun, 2012 1 commit
    • commit-queue@webkit.org's avatar
      REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and... · 12bd64b5
      commit-queue@webkit.org authored
      REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and ScriptProfileNode.idl should be T[]
      https://bugs.webkit.org/show_bug.cgi?id=84863
      
      Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2012-06-13
      Reviewed by Kentaro Hara.
      
      With reference to http://www.w3.org/TR/WebIDL/#idl-sequence
      "Sequences must not be used as the type of an attribute, constant or exception field."
      So we should use T[] instead of sequence<T>.
      
      Source/WebCore:
      
      Tests: bindings/scripts/test/TestObj.idl
             fast/harness/user-preferred-language.html
             inspector/profiler/cpu-profiler-profiling-without-inspector.html
             media/track/track-language-preference.html
      
      * bindings/scripts/CodeGenerator.pm:
      (GetSequenceType): Getter for getting sequence type.
      (GetArrayType): Getter for getting array type.
      (AssertNotSequenceType): Check sequences must not be used as the type of an attribute,
      constant or exception field.
      * bindings/scripts/CodeGeneratorCPP.pm:
      (SkipFunction): Exclude bindings code for type sequence.
      (SkipAttribute): Check for sequences must not be used as the type of an attribute,
      constant or exception field.
      (AddIncludesForType): Exclude header inclusion code for type array/sequence.
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipAttribute): Check for sequences must not be used as the type of an attribute,
      constant or exception field.
      (SkipFunction): Exclude bindings code for type sequence.
      * bindings/scripts/CodeGeneratorJS.pm:
      (AddIncludesForType): Exclude header inclusion code for type array/sequence.
      (GenerateImplementation):  Check for sequences must not be used as the type of an attribute,
      constant or exception field.
      (GetNativeType):
      (JSValueToNative):
      (NativeToJSValue):
      * bindings/scripts/CodeGeneratorObjC.pm:
      (SkipFunction): Exclude bindings code for type sequence.
      (SkipAttribute): Exclude bindings code for type array.
      (AddForwardDeclarationsForType):
      (AddIncludesForType):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateNormalAttrGetter):
      (GetNativeType):
      (JSValueToNative):
      (CreateCustomSignature):
      (NativeToJSValue):
      * bindings/scripts/test/JS/JSTestObj.cpp: Updated code from run-bindings-tests.
      (WebCore):
      (WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
      * bindings/scripts/test/JS/JSTestObj.h: Updated code from run-bindings-tests.
      (WebCore):
      * bindings/scripts/test/TestObj.idl: Tests.
      * bindings/scripts/test/V8/V8TestObj.cpp:  Updated code from run-bindings-tests.
      (TestObjV8Internal):
      (WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
      (WebCore):
      * inspector/ScriptProfileNode.idl: Using sequence<T> for children().
      * page/Console.idl: Using Array[T] for profiles attribute.
      * testing/Internals.idl: Using sequence<T> for userPreferredLanguages().
      
      LayoutTests:
      
      * fast/harness/user-preferred-language.html: Using getter and setter
      for userPreferredLanguages.
      * inspector/profiler/cpu-profiler-profiling-without-inspector.html:
      Use ScriptProfileNode.children as function.
      * media/track/track-language-preference-expected.txt:
      * media/track/track-language-preference.html: Using setter for
      userPreferredLanguages.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12bd64b5
  24. 12 Jun, 2012 3 commits
    • morrita@google.com's avatar
      Shadow Pseudo ID should be able to nest to point nested shadow DOM. · 649eaeb6
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=62218
      
      Reviewed by Dimitri Glazkov.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      - updateSpecifiersWithElementName() didn't take nesting into account.
        tag history can contain selector entries which isn't marked as ShadowDescendant yet.
        such entry can be found by investigating isUnknownPseudoElement().
      - SelectorChecker::checkSelector() was too strict. Unknown pseudo elements are essentially a kind of class or id
        in implementation perspective. For such, rejecting by missing elementStyle doesn't make sense:
        It isn't a pseudo but a real element for WebCore after all.
      - Added Internals::setShadowPseudoId() to create a test harness whose DOM tree contains pseudo shadow ids.
      
      Before this change, following selecdtor chain is created for "p::-shadow-child::-nested-shadow-child":
      
        [both tag name and -shadow-id are set] <-(ShadowDescendant)- [-nested-shadow-id]
      
      What we want, which is created by this change is:
      
        [tag] <-(ShadowDescendant)- [-shadow-id is set] <-(ShadowdescenDant)- [-nested-shadow-id]
      
      Test: fast/dom/shadow/shadow-nested-pseudo-id.html
      
      * WebCore.exp.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::updateSpecifiersWithElementName):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector):
      * testing/Internals.cpp:
      (WebCore::Internals::setShadowPseudoId):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      * fast/dom/shadow/shadow-nested-pseudo-id-expected.txt: Added.
      * fast/dom/shadow/shadow-nested-pseudo-id.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649eaeb6
    • commit-queue@webkit.org's avatar
      [EFL] Enable SHADOW_DOM flag · f128e801
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87732
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-12
      Reviewed by Kentaro Hara.
      
      .:
      
      Enable SHADOW_DOM flag by default at compile time for EFL port.
      
      * Source/autotools/symbols.filter: Fix GTK build by adding new symbol.
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore:
      
      Test: fast/dom/shadow/shadow-root-innerHTML.html
      
      * dom/ShadowRoot.idl: Add JSGenerateToJSObject extended attribute so
      that the ShadowRoot properties are accessible on JS side.
      * testing/Internals.idl: Fix SHADOW_DOM ifdef check.
      
      Source/WebKit:
      
      Add WebCore/bindings/generic to include directories so
      that we can include RuntimeEnabledFeatures.h.
      
      * CMakeLists.txt:
      
      Source/WebKit/efl:
      
      Add Ewk setting to toggle Shadow DOM support at runtime.
      
      * ewk/ewk_settings.cpp:
      (ewk_settings_shadow_dom_enable_get):
      (ewk_settings_shadow_dom_enable_set):
      * ewk/ewk_settings.h:
      
      Tools:
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
      SHADOW_DOM by default in DRT.
      * DumpRenderTree/efl/DumpRenderTreeView.cpp:
      (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
      Chromium and Mac ports.
      (drtViewAdd):
      * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
      at compile time for EFL port.
      
      LayoutTests:
      
      Unskip most of the test cases associated to Shadow DOM now that the
      feature is enabled by default for EFL's DRT.
      
      * platform/efl/Skipped:
      * platform/efl/TestExpectations:
      * platform/efl/fast/dom/shadow/form-in-shadow-expected.txt: Added.
      * platform/efl/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f128e801
    • kaustubh@motorola.com's avatar
      [DRT] LTC:: counterValueForElementById() could be moved to Internals. · 479cf83d
      kaustubh@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84406
      
      Reviewed by Hajime Morita.
      
      .: 
      
      Exporting Internals::counterValueForElement symbols for the Gtk build.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      Covered by existing test cases.
      
      * testing/Internals.cpp:
      (WebCore::Internals::counterValue):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/efl: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      
      Source/WebKit/gtk: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/qt: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit/win: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * Interfaces/IWebFramePrivate.idl:
      * WebFrame.cpp:
      * WebFrame.h:
      
      Source/WebKit2: 
      
      Exporting Internals::counterValueForElement symbols for the win build.
      
      * win/WebKit2.def:
      
      Tools: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::setPOSIXLocale):
      * DumpRenderTree/chromium/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR):
      * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      (LayoutTestController):
      
      LayoutTests: 
      
      Move the counterValueForElementById from LayoutTestCotroller to Internals and
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * fast/css/counters/2displays-expected.txt:
      * fast/css/counters/2displays.html:
      * fast/css/counters/adding-nodes.html:
      * fast/css/counters/after-continuation-expected.txt:
      * fast/css/counters/after-continuation.html:
      * fast/css/counters/content-021-expected.txt:
      * fast/css/counters/content-021.html:
      * fast/css/counters/counter-before-content-not-incremented.html:
      * fast/css/counters/counter-increment-000-expected.txt:
      * fast/css/counters/counter-increment-000.html:
      * fast/css/counters/counter-increment-001-expected.txt:
      * fast/css/counters/counter-increment-001.html:
      * fast/css/counters/counter-increment-002.html:
      * fast/css/counters/counter-increment-inherit-expected.txt:
      * fast/css/counters/counter-increment-inherit.htm:
      * fast/css/counters/counter-increment-overflow.html:
      * fast/css/counters/counter-increment-tests-expected.txt:
      * fast/css/counters/counter-increment-tests.htm:
      * fast/css/counters/counter-reset-000.html:
      * fast/css/counters/counter-reset-001.html:
      * fast/css/counters/counter-reset-002.html:
      * fast/css/counters/counterValueForElementById-expected.txt:
      * fast/css/counters/counterValueForElementById.html:
      * fast/css/counters/deep-before-expected.txt:
      * fast/css/counters/deep-before.html:
      * fast/css/counters/invalidate-cached-counter-node.html:
      * fast/css/counters/nesting.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      479cf83d
  25. 28 May, 2012 1 commit
    • gyuyoung.kim@samsung.com's avatar
      Move allowRoundingHacks to Internals interface · 741d355c
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87328
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter: Add allowRoundingHacks symbol filter.
      
      Source/WebCore:
      
      Add allowRoundingHacks function, because it is able to work in the
      cross-port way by means of the Internals interface.
      
      In addition, a function is added in order to restore default setting values.
      
      No new tests, since we are improving here the infra-structure for testing
      a specific method.
      
      * testing/Internals.cpp:
      (WebCore::Internals::reset):
      (WebCore):
      (WebCore::Internals::resetDefaultsToConsistentValues):
      (WebCore::Internals::allowRoundingHacks):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def: Add setAllowsRoundingHacks() to symbol filter.
      
      Tools:
      
      Remove allowRoundingHacks functions, because it is able to work in the
      cross-port way through the Internals interface.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      
      LayoutTests:
      
      Invoke allowRoundingHacks function from internals, because it is able to work in the
      cross-port way via the Internals interface.
      
      * platform/mac/fast/text/rounding-hacks-expansion.html:
      * platform/mac/fast/text/rounding-hacks.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      741d355c
  26. 19 May, 2012 1 commit
  27. 18 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Expose FrameSelection::absoluteCaretBounds via window.internals · 42b64a5f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86390
      
      Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-18
      Reviewed by Ryosuke Niwa.
      
      .:
      
      Exports necessary symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Add 'absoluteCaretBounds' method to Internals, which returns the
      FrameSelection::absoluteCaretBounds.
      
      Test: editing/selection/internal-caret-rect.html
      
      * WebCore.exp.in: Export the necessary symbols.
      * testing/Internals.cpp:
      (WebCore::Internals::absoluteCaretBounds): Implementation of new method.
      (WebCore):
      * testing/Internals.h: Declare the new method.
      (Internals):
      * testing/Internals.idl: Declare the new method.
      
      Source/WebKit2:
      
      Exports necessary symbols.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      A simple test case for the new 'absoluteCaretBounds' method.
      
      * editing/selection/internal-caret-rect-expected.txt: Added.
      * editing/selection/internal-caret-rect.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42b64a5f
  28. 16 May, 2012 1 commit
    • keishi@webkit.org's avatar
      [chromium] Add WebKit API to access inner text value of input element · 39a4df32
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85353
      
      Reviewed by Kent Tamura.
      
      .:
      
      * Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
      
      Source/WebCore:
      
      Test: fast/forms/editing-value.html
      
      We need this to implement the datalist UI for  <input type=email multiple>.
      HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed.
      We need to append the selected suggestion to the end without modifying the rest of the text.
      
      * WebCore.exp.in: Added HTMLInputElement::setEditingValue
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setEditingValue):
      (WebCore):
      * html/HTMLInputElement.h:
      (HTMLInputElement):
      * testing/Internals.cpp:
      (WebCore::Internals::setEditingValue):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      * public/WebInputElement.h:
      (WebInputElement):
      * src/WebInputElement.cpp:
      (WebKit::WebInputElement::editingValue):
      (WebKit):
      (WebKit::WebInputElement::setEditingValue):
      
      Source/WebKit2:
      
      * win/WebKit2.def: Added HTMLInputElement::setEditingValue
      * win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue
      
      LayoutTests:
      
      * fast/forms/editing-value-expected.txt: Added.
      * fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39a4df32
  29. 10 May, 2012 1 commit
    • morrita@google.com's avatar
      ElementShadow should minimize the usage of "ShadowRoot" name · 49d99d93
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85970
      
      Reviewed by Dimitri Glazkov.
      
      .:
      
      Removed symbols which no longer exists
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      This change cleans two out dated assumptions which brought in at
      early stage of Shadow DOM implementation.
      
      - Removed Element::hasShadowRoot(): shadow existence can be checked by Element::shadow().
      - Made ElementShadow::removeAllShadowRoots() private: we no longer allow ShadowRoot removal.
        It can only happens at the ElementShadow destruction.
      
      Most of changes in element implementations are basically simple
      replacement from hasShadowRoot() to shadow().
      
      No new tests. Covered by existing tests.
      
      * WebCore.exp.in:
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildFrameDisconnector::collectDescendant):
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseChild):
      * dom/Document.cpp:
      (WebCore::Document::buildAccessKeyMap):
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle):
      (WebCore::Element::ensureShadowRoot):
      (WebCore::Element::childrenChanged):
      * dom/Element.h:
      (Element):
      (WebCore::isShadowHost):
      (WebCore):
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::~ElementShadow):
      (WebCore::ElementShadow::removeAllShadowRoots):
      * dom/ElementShadow.h:
      (ElementShadow):
      (WebCore::ElementShadow::host):
      * dom/EventDispatcher.cpp:
      * dom/Node.cpp:
      (WebCore::oldestShadowRootFor):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::create):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::createShadowSubtree):
      (WebCore::FileInputType::multipleAttributeChanged):
      * html/HTMLDetailsElement.cpp:
      (WebCore::HTMLDetailsElement::createShadowSubtree):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::createShadowSubtree):
      * html/HTMLKeygenElement.cpp:
      (WebCore::HTMLKeygenElement::HTMLKeygenElement):
      (WebCore::HTMLKeygenElement::shadowSelect):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::hasMediaControls):
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::createShadowSubtree):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::createShadowSubtree):
      * html/HTMLSummaryElement.cpp:
      (WebCore::HTMLSummaryElement::createShadowSubtree):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::createShadowSubtree):
      * html/InputType.cpp:
      (WebCore::InputType::destroyShadowSubtree):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleMouseDownEvent):
      (WebCore::RangeInputType::createShadowSubtree):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::createShadowSubtree):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::trackLimiterElementOf):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::unbind):
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      * page/FocusController.cpp:
      (WebCore):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::uploadButton):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::updateReferencedText):
      (WebCore::SVGTRefElement::detachTarget):
      * testing/Internals.cpp:
      (WebCore::Internals::ensureShadowRoot):
      (WebCore::Internals::youngestShadowRoot):
      (WebCore::Internals::oldestShadowRoot):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Removed symbols which no longer exists
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Removed tests cases which exercise shadow root removals.
      Such functionality was only available from Internals object
      and it made little sense to test it.
      
      * fast/dom/shadow/content-element-move-expected.txt:
      * fast/dom/shadow/content-element-move.html:
      * fast/dom/shadow/dynamically-created-shadow-root-expected.html:
      * fast/dom/shadow/dynamically-created-shadow-root.html:
      * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
      * fast/dom/shadow/layout-tests-can-access-shadow.html:
      * fast/dom/shadow/multiple-shadowroot-expected.txt:
      * fast/dom/shadow/multiple-shadowroot.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49d99d93