1. 20 Nov, 2002 4 commits
  2. 19 Nov, 2002 7 commits
    • cblu's avatar
      Fixed: 3106061 - REGRESSION: Copy in text view copies all text not just selection · 704bb20b
      cblu authored
              * Misc.subproj/WebSearchableTextView.m:
              (-[WebSearchableTextView copy:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      704bb20b
    • cblu's avatar
      Fixed: 3092588 - redraw errors in QT controller if window is in background · 634e3f1b
      cblu authored
      	We need to send update events after we activate/deactivate after all.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView windowBecameKey:]):
              (-[WebBaseNetscapePluginView windowResignedKey:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      634e3f1b
    • cblu's avatar
      Fixed: 3020720 - dropping a folder in the page address makes the folder open... · 9332bfeb
      cblu authored
      	Fixed: 3020720 - dropping a folder in the page address makes the folder open in Finder, empties the field
      
              * Misc.subproj/WebNSPasteboardExtras.m:
              (-[NSPasteboard _web_bestURL]): Don't accept directories.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9332bfeb
    • cblu's avatar
      Fixed: 3068112 - extra line breaks when copying from source window · fbd4b010
      cblu authored
              * Misc.subproj/WebSearchableTextView.m:
              (-[WebSearchableTextView copy:]): Convert CRLF to LF
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbd4b010
    • hyatt's avatar
      Make sure that if the scrollers are shown/hidden that we · 83212c1f
      hyatt authored
      	force an immediate layout, since if we don't, an intervening
      	display can cause us to show scrollbars when they really
      	shouldn't be there.
      
              * WebView.subproj/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView updateScrollers]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83212c1f
    • cblu's avatar
      Fixed: 3100597 - repro NSArray exception using contextual menu · 914b6e5d
      cblu authored
              * Misc.subproj/WebNSPasteboardExtras.m:
              (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): more error checking
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      914b6e5d
    • trey's avatar
      WebKit: · f1e3a112
      trey authored
      	Just a tweak to the description printout.
      
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem description]):
      
      WebBrowser:
      
      	Implementation of the UI for auto-complete.  The back end is simplistic at this
      	stage, as it just searches for http://www.WhatYouTyped.
      
              * ABHomePagesController.m:
              (-[ABHomePagesController refreshContents]):  Added notes for a future fix.
              * BrowserWindowController.h:  Added BrowserWindowWillResize notification.
              * BrowserWindowController.m:
              (-[BrowserWindowController windowDidLoad]):  Create CompletionController.
              (-[BrowserWindowController windowWillResize:toSize:]):  Post resize notification.
              (-[BrowserWindowController dealloc]):  Free CompletionController.
              (-[BrowserWindowController controlTextDidChange:]):  Forward to CompletionController.
              (-[BrowserWindowController controlTextDidEndEditing:]):  Forward to CompletionController.
              (-[BrowserWindowController control:textView:doCommandBySelector:]):  Forward to CompletionController.
              * CompletionController.h: Added.
              * CompletionController.m: Added.
              (-[CompletionController initWithSourceField:]):   Hook up to a field to operate on.
              (-[CompletionController dealloc]):
              (-[CompletionController _executeQuery]):  Get a result set.
              (-[CompletionController _matchingPrefixOfString:]):  Determine piece of a result
      	that matched.
              (-[CompletionController _buildUI]):  Build completion window and table view.
              (placementViewForControl):  Utility function.
              (-[CompletionController _positionWindow]):  Position the window wrt location field.
              (-[CompletionController _showMatchesWindow]):  Show it,
              (-[CompletionController _hideMatchesWindow]):  hide it.
              (-[CompletionController _sourceWindowWillMoveOrResize:]):
              (-[CompletionController _sourceWindowWillMiniaturize:]):
              (-[CompletionController _sourceWindowWillClose:]):
      		Hide UI on various source window changes.
              (-[CompletionController _abortCompletion:]):  wrapper for performAfterDelay.
              (-[CompletionController abortCompletion]):  Bail out of completion operation.
              (-[CompletionController completeString:]):  Do a query, bring up the UI.
              (-[CompletionController _reflectSelectedRow]):  Update location field when a
      	completion is selected in the TableView
              (-[CompletionController controlTextDidChange:]):  Drive completion on new text.
              (-[CompletionController control:textView:doCommandBySelector:]):
      	Drive completion on arrows, backspace, escape, return.
              (-[CompletionController goToItemAtRow:]):  Double click sends performClick to location field.
              (-[CompletionController tableViewSelectionDidChange:]):  Drive UI when row selected.
              (-[CompletionController numberOfRowsInTableView:]):  Supply tableView data.
              (-[CompletionController tableView:objectValueForTableColumn:row:]):  Supply tableView data.
              * TitleBarButton.m:
              (-[TitleBarButton hitTest:]):  Bug fix to allow superview to process mouse events
      	that we don't handle.  Allows proper sending of WindowWillMove.
              * WebBrowser.pbproj/project.pbxproj:  New class added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1e3a112
  3. 18 Nov, 2002 5 commits
    • cblu's avatar
      Real fix for: 3104183 - Assert loading www.louisvuitton.com · 4f7065eb
      cblu authored
      	Since we don't consider plug-in content as a subresource, attaching plug-in streams to the datasource has no affect on the loading state of the datasource. Both stopLoading on WebFrame and _stopLoading datasource, would not stop plug-ins streams after the data source was done loading. Because of this, I've decided to not keep a list of plug-in streams attached to the data source and pulled my previous change. To fix this bug, WebBaseResourceHandleDelegate now retains the controller.
      
              * Plugins.subproj/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream start]):
              (-[WebNetscapePluginStream cancel]):
              (-[WebNetscapePluginStream handleDidFinishLoading:]):
              (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
              * WebView.subproj/WebBaseResourceHandleDelegate.h:
              * WebView.subproj/WebBaseResourceHandleDelegate.m:
              (-[WebBaseResourceHandleDelegate _releaseResources]):
              (-[WebBaseResourceHandleDelegate setDataSource:]):
              (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
              (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]):
              (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
              (-[WebBaseResourceHandleDelegate _cancelWithError:]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _stopLoading]):
              (-[WebDataSource _makeHandleDelegates:deferCallbacks:]):
              (-[WebDataSource _defersCallbacksChanged]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f7065eb
    • cblu's avatar
      Fixed: 3104183 - Assert loading www.louisvuitton.com · 6d927229
      cblu authored
      	We need to treat plug-in streams like subresources except they don't change the loading state of the data source.
      
              * Plugins.subproj/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream start]): call _addPluginStream
              (-[WebNetscapePluginStream cancel]): call _removePluginStream
              (-[WebNetscapePluginStream handleDidFinishLoading:]): call _removePluginStream
              (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): call _removePluginStream
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]): release pluginStreams
              (-[WebDataSource _addPluginStream:]): just like addSubresourceClient except don't change the loading state.
              (-[WebDataSource _removePluginStream:]): just like removeSubresourceClient except don't change the loading state.
              (-[WebDataSource _stopLoading]): stop plug-ins streams
              (-[WebDataSource _makeHandleDelegates:deferCallbacks:]):
              (-[WebDataSource _defersCallbacksChanged]): call _makeHandleDelegates:deferCallbacks: for subresources and plug-in streams.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d927229
    • rjw's avatar
      Check for usesBackForwardList was excluding all load types. · f8dec244
      rjw authored
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8dec244
    • cblu's avatar
      Fixed: 3098767 - REGRESSION: standalone quicktime content just shows blank window · 81cc7651
      cblu authored
      	Check the instance not the class for the class type.
      
              * Plugins.subproj/WebNetscapePluginRepresentation.m:
              (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81cc7651
    • kocienda's avatar
      WebKit: · 357eb7e0
      kocienda authored
      	Added feature to import bookmarks/favorites from MSIE. This
      	fixes Radar 2961230 (import Mac IE bookmarks).
      
              * Bookmarks.subproj/WebBookmarkImporter.h: Added.
              * Bookmarks.subproj/WebBookmarkImporter.m: Added.
              (_breakStringIntoLines):
              (_HREFRangeFromSpec):
              (_HREFTextFromSpec):
              (_linkTextRangeFromSpec):
              (_linkTextFromSpec):
              (-[WebBookmarkImporter initWithPath:group:]):
              (-[WebBookmarkImporter topBookmark]):
              (-[WebBookmarkImporter error]):
              (-[WebBookmarkImporter dealloc]):
              * Bookmarks.subproj/WebBookmarkList.m:
              (-[WebBookmarkList init]): Create the bookmark list object. This
      	was not created with the -init initializer, causing bookmark lists
      	to fail.
              * English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
              * WebKit.exp:
              * WebKit.pbproj/project.pbxproj:
      
      WebBrowser:
      
      	Added calls in Debug menu to import IE Favorites.
      	No doubt that this code will move somewhere else once
      	we figure out the interaction design for importing
      	bookmarks.
      
              * Debug/DebugUtilities.m:
              (-[DebugUtilities createDebugMenu]):
              (-[BrowserDocument importInteretExplorerBookmarks:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357eb7e0
  4. 17 Nov, 2002 6 commits
    • trey's avatar
      Code cleanup to make some internal methods return autoreleased objects. · 00178efe
      trey authored
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _addBackForwardItemClippedAtTarget:]):
              (-[WebFrame _createItem]):
              (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
              (-[WebFrame _transitionToCommitted]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00178efe
    • trey's avatar
      Fixed 3102076 - REGRESSION: infinite recursion involving bridge end · c3ec7092
      trey authored
      	Fixed 3100929 - REGRESSION: serverRedirectedForDataSource: not sent on server redirects
      	Fixed 3103381 - REGRESSION: Going back from anchor doesn't restore scroll position
      
              * WebView.subproj/WebBaseResourceHandleDelegate.m:
              (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):  Return the copy of the
      	request that we make instead of the original.
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:willSendRequest:]):  Call super after we make our mods
      	to the request, so the copy that super makes for us includes those mods.
      
              * WebView.subproj/WebFramePrivate.h:  Added new state, WebFrameStateCompleting.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToLayoutAcceptable]):  Completing state is a NOP.
              (-[WebFrame _transitionToCommitted]):  Completing state is a NOP.
              (-[WebFrame _isLoadComplete]):  Go to Completing state before calling [bridge end].
      	Go to Completed state afterwards, only if no new loads started in the meantime.
              (-[WebFrame _loadItem:fromItem:withLoadType:]):  When doing anchor nav to get to the
      	item, save and restore scroll state, and set the current item.
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
      	Reorder the steps so the right scroll state gets saved to the right place.  Also, don't
      	add a backForward item if we're doing a client redirect to an anchor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3ec7092
    • hyatt's avatar
      Back out my previous fix. I have a better one that is · 1ea3cc0f
      hyatt authored
      	confined to WebCore.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _isLoadComplete]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ea3cc0f
    • hyatt's avatar
      The needsdisplay is necessary even for HTML documents. · bb86b999
      hyatt authored
      	I over-optimized here.  Fixes the directory.apple.com
      	regression and the santa clara library regression.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _isLoadComplete]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb86b999
    • darin's avatar
      WebCore: · b1961817
      darin authored
      	- moved all NSURL and CFURL use out of WebCore
      
              * kwq/KWQKURL.h: Remove getNSURL() and getNSURLFromString().
              * kwq/KWQKURL.mm: Ditto.
      
              * kwq/KWQKCookieJar.mm:
              (KWQKCookieJar::cookie): Pass an NSString instead of an NSURL.
              (KWQKCookieJar::setCookie): Ditto.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::openURL): Ditto.
              (KWQKHTMLPart::openURLRequest): Ditto.
              (KWQKHTMLPart::submitForm): Ditto.
              (KWQKHTMLPart::urlSelected): Ditto.
              (KWQKHTMLPart::createPart): Ditto.
              (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto.
              (KWQKHTMLPart::userAgent): Ditto.
              (KWQKHTMLPart::requestedURLString): Receive an NSString instead of an NSURL.
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow): Pass an NSString instead of an NSURL.
              (KHTMLPartBrowserExtension::setIconURL): Ditto.
              (KHTMLPartBrowserExtension::setTypedIconURL): Ditto.
              * kwq/KWQKJavaAppletWidget.h: Remove use of NSURL, just use QString instead.
              * kwq/KWQKJavaAppletWidget.mm:
              (KJavaAppletWidget::KJavaAppletWidget): No need to set the QString to nil.
              (KJavaAppletWidget::~KJavaAppletWidget): No need to release the QString.
              (KJavaAppletWidget::showApplet): Pass an NSString instead of an NSURL.
              * kwq/KWQLoader.mm:
              (KWQServeRequest): Pass an NSString instead of an NSURL.
              (KWQCheckCacheObjectStatus): Ditto.
              * kwq/WebCoreBridge.h: Change all methods to use NSString instead of NSURL.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:headers:]): Receive an NSString instead of an NSURL.
              (-[WebCoreBridge completeURLForDOMString:]): Return an NSString instead of an NSURL.
              (-[WebCoreBridge elementAtPoint:]): WebCoreElementLinkURL and WebCoreElementImageURL
      	are now strings.
              (-[WebCoreBridge URL]): Return an NSString instead of an NSURL.
              * kwq/WebCoreCookieAdapter.h: Change all methods to use NSString instead of NSURL.
              * kwq/WebCoreCookieAdapter.m:
              (-[WebCoreCookieAdapter cookiesForURL:]): Ditto.
              (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.
      
              * khtml/rendering/render_applet.cpp: (RenderApplet::processArguments):
      	Tweaked this file a tiny bit, mainly because header dependencies weren't working
      	and we need this file to be recompiled due to inline function changes.
      
      WebKit:
      
      	- update for change to WebCore API so it never uses NSURL
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createWindowWithURL:frameName:]): Take NSString instead of NSURL.
              (-[WebBridge startLoadingResource:withURL:]): Ditto.
              (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto.
              (-[WebBridge reportClientRedirectToURL:delay:fireDate:]): Ditto.
              (-[WebBridge setIconURL:]): Ditto.
              (-[WebBridge setIconURL:withType:]): Ditto.
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): Ditto.
              (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): Ditto.
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.
              (-[WebBridge userAgentForURL:]): Ditto.
              (-[WebBridge requestedURL]): Return NSString instead of NSURL.
              (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Take NSString instead of NSURL.
              (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): Take NSString instead of NSURL.
      
              * WebCoreSupport.subproj/WebCookieAdapter.m:
              (-[WebCookieAdapter cookiesForURL:]): Take NSString instead of NSURL.
              (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.
      
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]): Pass NSString instead of NSURL.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Pass NSString instead of NSURL
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Turn bridge URL into NSURL so we
      	can call _web_URLByRemovingFragment on it.
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _elementAtPoint:]): Convert NSString to NSURL when making the WebKit element dictionary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1961817
    • mjs's avatar
      WebCore: · bb798fe2
      mjs authored
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
      
              * khtml/html/html_formimpl.cpp:
              (HTMLGenericFormElementImpl::defaultEventHandler):
              * kwq/KWQEvent.h:
              * kwq/KWQEvent.mm:
              (QKeyEvent::QKeyEvent): Implemented.
              (QKeyEvent::key): Likewise.
              (QKeyEvent::state): Likewise.
              (QKeyEvent::accept): Likewise.
              (QKeyEvent::ignore): Likewise.
              (QKeyEvent::isAutoRepeat): Likewise.
              (QKeyEvent::text): Likewise.
              (QKeyEvent::ascii): Likewise.
              (QKeyEvent::count): Likewise.
              (QKeyEvent::isAccepted): Likewise.
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::keyEvent): Translate the event to a QEvent and send
      	it through the DOM event mechanism.
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge interceptKeyEvent:toView:]): Pass event to the
      	KWQ part.
      	* kwq/WebCoreBridgePrivate.h: Added.
              * WebCore.pbproj/project.pbxproj: Added new file.
      
      WebKit:
      
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
      
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (+[WebHTMLView load]): Pose as NSWindow too now.
              (-[WebHTMLView _interceptKeyEvent:toView:]): Pass event to WebCore and
      	see if WebCore wants to block it.
              (-[WebNSWindow sendEvent:]): For all key events that would go to a
      	subview of a WebHTMLView, let the WebHTMLView take a first crack
      	at it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb798fe2
  5. 15 Nov, 2002 8 commits
    • darin's avatar
      - fixed 3079214 -- text/plain page shows up slowly, a few pages at a time · 922ba374
      darin authored
              * WebView.subproj/WebTextView.m:
              (-[WebTextView initWithFrame:]): Remove unneeded setWidthTracksTextView:, because
      	that's the default.
              (-[WebTextView dataSourceUpdated:]): Replace the thing each time in the RTF case.
              (-[WebTextView viewDidMoveToSuperview]): Here's where we resize, but only the width.
      	Resizing the height was causing the bug.
              (-[WebTextView layout]): Do nothing.
              (-[WebTextView setAcceptsDrags:]): Update to new name. Since we weren't
      	importing WebDocument.h, we never noticed that this file got out of sync.
              (-[WebTextView acceptsDrags]): Ditto.
              (-[WebTextView setAcceptsDrops:]): Ditto.
              (-[WebTextView acceptsDrops]): Ditto.
      
              * WebView.subproj/WebDocument.h: Fix typo. It said setAcceptsDrags: twice.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922ba374
    • darin's avatar
      61200eb4
    • mjs's avatar
      - fixed 3102016 - REGRESSION: Command-clicking on a link can open _two_ windows. · b8cae6d0
      mjs authored
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _setJustOpenedForTargetedLink:]):
              (-[WebDataSource _justOpenedForTargetedLink]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame findOrCreateFramedNamed:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueAfterNavigationPolicy:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              (-[WebFrame _downloadRequest:toPath:]):
              (-[WebFrame _setJustOpenedForTargetedLink:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8cae6d0
    • darin's avatar
      * WebView.subproj/WebFramePrivate.m: · 960f8f20
      darin authored
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
      	Give the listener a slightly longer lifetime, to make this API a bit more foolproof.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      960f8f20
    • mjs's avatar
      Fix world leak I introduced, and also add an early return when needed. · 4e042174
      mjs authored
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e042174
    • mjs's avatar
      WebKit: · 62074c91
      mjs authored
      	Make navigation policy asynchronous for real.
      
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):
              (-[WebPolicyDecisionListenerPrivate dealloc]):
              (-[WebPolicyDecisionListener usePolicy:]):
              (-[WebPolicyDecisionListener _initWithTarget:action:]):
              (-[WebPolicyDecisionListener dealloc]):
              (-[WebPolicyDecisionListener _invalidate]):
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added.
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame stopLoading]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
              (-[WebFrame _continueAfterNavigationPolicy:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
      
      WebBrowser:
      
      	Make navigation policy asynchronous.
      
              * BrowserWebController.m:
              (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62074c91
    • mjs's avatar
      Wrap content policy invocation to look asynchronous. · 252d3fe7
      mjs authored
              * WebView.subproj/WebBaseResourceHandleDelegate.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
              (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      252d3fe7
    • mjs's avatar
      Refactor so that all invocations of navigation policy are set up · 604b1965
      mjs authored
      	to be asynchronous. However, the actually delegate method is not
      	async yet.
      
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient stopLoadingForPolicyChange]):
              (-[WebMainResourceClient continueAfterNavigationPolicy:request:]):
              (-[WebMainResourceClient handle:willSendRequest:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      604b1965
  6. 14 Nov, 2002 10 commits
    • mjs's avatar
      Refactor things a bit so all loads bottleneck through a single · 7a17f0c4
      mjs authored
      	method (_loadDataSource:withLoadType:).
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame loadRequest:]):
              (-[WebFrame reload]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadItem:fromItem:withLoadType:]):
              (-[WebFrame _loadRequest:triggeringAction:loadType:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):
              (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              (-[WebFrame _downloadRequest:toPath:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a17f0c4
    • mjs's avatar
      WebKit: · 6a96e2b0
      mjs authored
      	Change things so the public interface to loading is loadRequest:
      	and everything else is private.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
              * Plugins.subproj/WebPluginController.m:
              (-[WebPluginController showURL:inFrame:]):
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              (-[WebController init]):
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _createFrameNamed:inParent:allowsScrolling:]):
              (-[WebController _downloadURL:toPath:]):
              * WebView.subproj/WebFrame.h:
              * WebView.subproj/WebFrame.m:
              (-[WebFrame init]):
              (-[WebFrame initWithName:webView:controller:]):
              (-[WebFrame loadRequest:]):
              (-[WebFrame reload]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]):
              (-[WebFrame _clearProvisionalDataSource]):
              (-[WebFrame _loadItem:fromItem:withLoadType:]):
              (-[WebFrame _loadRequest:triggeringAction:]):
              (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
              (-[WebFrame _itemForRestoringDocState]):
              (-[WebFrame _setProvisionalDataSource:]):
              (-[WebFrame _startLoading]):
              (-[WebFrame _downloadRequest:toPath:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:willSendRequest:]):
              (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              * WebView.subproj/WebView.m:
              (-[WebView concludeDragOperation:]):
      
      WebBrowser:
      
      	Change things so the public interface to loading is loadRequest:
      	and everything else is private.
      
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController initWithBrowserDocument:]):
              * Debug/SnippetController.h:
              * Debug/SnippetController.m:
              (-[SnippetController dealloc]):
              (-[SnippetController windowWillClose:]):
              (-[SnippetController load]):
              (-[SnippetController loadComplete]):
              (-[SnippetController mainDataSource]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a96e2b0
    • hyatt's avatar
      Move text measurement and layout beyond onload. This · d4a14ac7
      hyatt authored
      	shoudl speed up i-bench substantially and morrison's
      	PLT test slightly.  Note that the adjustFrames layout
      	stuff has been removed from isLoadComplete.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]):
              (-[WebFrame _isLoadComplete]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a14ac7
    • darin's avatar
      WebFoundation: · 726fa2c5
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/Localizable.strings: Updated to include the new
      	error messages that Maciej just added. I wonder what effect this
      	will have if we see those errors in Alex-32?
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      726fa2c5
    • sheridan's avatar
      Alex-32 stamp · 98191978
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98191978
    • gramps's avatar
      * WebView.subproj/WebControllerPolicyDelegate.h: · 76387d3c
      gramps authored
      Added missing semi-colon in definition of WebPolicyDecisionListener to
      fix build error.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76387d3c
    • mjs's avatar
      WebKit: · 61d1c337
      mjs authored
      	Combined file URL policy with content policy. We don't actually
      	bother to ask earlier for file URLs yet, since that will make
      	things more complicated.
      
              * Misc.subproj/WebKitErrors.h:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _handleUnimplementablePolicy:errorCode:forURL:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              * WebView.subproj/WebView.m:
              (+[WebView initialize]):
      
      WebBrowser:
      
      	Combined file URL policy with content policy. Also adjusted error
      	handling to continue to handle file errors well.
      
              * BrowserWebController.m:
              (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
              * LocationChangeError.m:
              (-[LocationChangeHandler specializedTitleForError:]):
              (-[LocationChangeHandler specializedMessageForError:]):
              * LocationChangeHandler.m:
              (-[LocationChangeHandler locationChangeDone:forDataSource:]):
              * WebBrowser.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d1c337
    • darin's avatar
      WebCore: · 043758d8
      darin authored
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      
      	Don't force all redirects to be reloads, because the ones from JavaScript must
      	not be. Maybe a better solution post-Alex-32 will be to pass a flag that distinguishes
      	redirects from other location changes.
      
              * khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Don't ignore the anchor when
      	comparing URLs to see if they should be a reload. We'll still do a reload if the URLs
      	are actually equal, but if they differ in anchor we will just go to the anchor.
      	This is the bug fix.
      
              * kwq/WebCoreBridge.h: Add reload parameter.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:]): Stuff the reload
      	parameter into the URLArgs.
      
      WebKit:
      
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      
      	Make the reload flag pass across the bridge.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Pass a reload flag, based on the load type, to the bridge.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Pass a
      	reload flag of NO in the anchor case. Preserve reload load types even when
      	doing client redirects (have to talk with Trey about this tomorrow).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043758d8
    • darin's avatar
      WebCore: · 3866e312
      darin authored
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
      
              * kwq/WebCoreBridge.h: Add needsLayout.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render
      	tree root says "layouted" is false. It would be more elegant to use more of this
      	WebCore layout logic and have less of our own on the WebKit side.
      
              * WebCore.pbproj/project.pbxproj: Oh, that Project Builder.
      
      WebKit:
      
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
      
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
      	If the WebCore side needs layout, then do layout before trying to draw.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3866e312
    • trey's avatar
      Fixed client redirects, some more. The upshot is that they do not · 3a55cfde
      trey authored
      	generate two items in the back-forward list.  iBench still works.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge reportClientRedirectTo:delay:fireDate:]):  Call straight to the frame for all impl.
              (-[WebBridge reportClientRedirectCancelled]):  Call straight to the frame for all impl.
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
      	clientRedirect param removed when sending _loadURL: to frame.
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
      	clientRedirect param  removed. Check our own ivar to know if we are in client redirect case.
              (-[WebFrame _loadURL:intoChild:]):
      	clientRedirect param removed when sending _loadURL: .
              (-[WebFrame _clientRedirectedTo:delay:fireDate:]):
      	Note that we are doing a redirect if time=0 and we're not completed.  Also includes
      	previous impl moved from Bridge.
              (-[WebFrame _clientRedirectCancelled]):  Previous impl moved from Bridge.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a55cfde