1. 15 Jan, 2003 1 commit
    • darin's avatar
      WebCore: · c12a0350
      darin authored
              Reviewed by Ken.
      	- fixed problem where Content-Type was coming in with suffixes like "charset"
              * kwq/WebCoreBridge.h: Add contentType and refresh parameters, and remove "headers"
      	parameter, from openURL method.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Get the
      	content type from a parameter, and the refresh header from a separate parameter rather
      	than extracting both from a headers dictionary.
              Reviewed by Ken.
      	- fixed problem where Content-Type was going into WebCore with suffixes like "charset"
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
      	Pass in contentType from the response, rather than the "Content-Type" header.
      	Also pass in the refresh header separately.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 14 Jan, 2003 4 commits
    • darin's avatar
      Reviewed by Maciej. · 5c611c4d
      darin authored
      	- fixed 3147036 -- words separated only by newlines are getting rammed together on XML page
      	- fixed 3147032 -- preformatted text is missing much whitespace on XML page
              * khtml/xml/xml_tokenizer.cpp: (XMLHandler::characters): Don't try to strip whitespace at all,
      	because it needs to be in the DOM.
      	- add support for more MIME types
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Add "application/xml" and "application/xhtml+xml".
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make FOUC work with XML. · bcb09ec8
      hyatt authored
              Reviewed by darin.
              * khtml/html/html_baseimpl.cpp:
              * khtml/xml/dom_xmlimpl.cpp:
              * khtml/xml/dom_xmlimpl.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 0bb44c36
      darin authored
      	- first cut at XML parsing with expat
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML
      	code for text/xml documents.
              * WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project.
      	Added new QXml files, removed old ones.
              * kwq/KWQXml.h: Removed.
              * kwq/KWQXml.mm: Removed.
              * kwq/KWQXmlAttributes.h: Added.
              * kwq/KWQXmlAttributes.mm: Added.
              * kwq/KWQXmlDefaultHandler.h: Added.
              * kwq/KWQXmlDefaultHandler.mm: Added.
              * kwq/KWQXmlSimpleReader.h: Added.
              * kwq/KWQXmlSimpleReader.mm: Added.
              * kwq/KWQString.h: Add fromUtf8 functions.
              * kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just
      	calls fromStringWithEncoding. We may need something more efficient later,
      	at least for all-ASCII text.
      	- other changes
              * khtml/khtml_part.h: Fix spelling of occurrence.
              * khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect.
      	It doesn't seem to work yet, but this does no harm.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly · 2028aa44
      rjw authored
              handles the visually ordered encodings.  The patch also picks up changes
              from kde that accounts for european numbers correctly in bidiReorderLine().
              Reviewed by Dave.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 13 Jan, 2003 1 commit
    • darin's avatar
      Reviewed by Ken. · 908cf2a7
      darin authored
      	- fixed 3143781 -- submitting the same form twice doesn't work properly
      	(example at directory.apple.com)
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same
      	form twice" logic when the form is one that affects the frame that the form is in.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 12 Jan, 2003 5 commits
    • darin's avatar
      * WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat). · 767b3718
      darin authored
              * kwq/KWQKHTMLPart.cpp: Reformatted a bit.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 68877da7
      darin authored
      	- first step towards integrating expat for XML support: make it compile and link
              * kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat.
      	Mainly just used to make sure we link.
              * WebCore.pbproj/project.pbxproj: Added expat files.
              * expat/COPYING: Added.
              * expat/Changes: Added.
              * expat/MANIFEST: Added.
              * expat/README: Added.
              * expat/expat_config.h: Added.
              * expat/lib/ascii.h: Added.
              * expat/lib/asciitab.h: Added.
              * expat/lib/expat.h: Added.
              * expat/lib/iasciitab.h: Added.
              * expat/lib/internal.h: Added.
              * expat/lib/latin1tab.h: Added.
              * expat/lib/nametab.h: Added.
              * expat/lib/utf8tab.h: Added.
              * expat/lib/xmlparse.c: Added.
              * expat/lib/xmlrole.c: Added.
              * expat/lib/xmlrole.h: Added.
              * expat/lib/xmltok.c: Added.
              * expat/lib/xmltok.h: Added.
              * expat/lib/xmltok_impl.c: Added.
              * expat/lib/xmltok_impl.h: Added.
              * expat/lib/xmltok_ns.c: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · d8d3bd9d
      darin authored
      	- minor cleanup of plug-in-related classes in ECMA directory
              * khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions
      	ref() and deref(). Instead just make Plugin and MimeType both derive from
      	PluginBase and remove APPLE_CHANGES.
              (Navigator::getValueProperty): Don't use "Konqueror" for the fallback.
      	Just return Undefined() for that case since we will never reach it anyway.
      	- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two
      	identical if statements, the logic of this function becomes much clearer.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. 11 Jan, 2003 1 commit
    • darin's avatar
      Reviewed by Dave. · c935e41a
      darin authored
      	- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims
      	link to current page
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
      	Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct
      	from an empty ATTR_HREF). Did a similar cleanup on the image code.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. 10 Jan, 2003 1 commit
    • darin's avatar
      JavaScriptCore: · 33188225
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Updated to match above changes.
              * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Update to match above.
              * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL
      	that was in the Info plist instead of project settings.
              * English.lproj/InfoPlist.strings: Update to match above.
              * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Updated to match above changes.
              * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions
      	to 0.8.1 and 52u to keep up with the branch.
              * English.lproj/InfoPlist.strings: Update to match above.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 09 Jan, 2003 4 commits
  8. 08 Jan, 2003 4 commits
    • cblu's avatar
      WebCore: · 0ce577a1
      cblu authored
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
              Reviewed by dave.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::createPart): call [_bridge frameRequiredForMIMEType:] to determine if we should create a plug-in view or iframe
              * kwq/WebCoreBridge.h: add frameRequiredForMIMEType:
      	Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
              Reviewed by dave.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge frameRequiredForMIMEType:]): added, returns YES for non-plug-in views
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      3136213 - Page loads stopped by backtracking don't finish when moving forward · 8807f2f1
      trey authored
      	We need to remove the entry from the KHTML image cache when a load
      	has an error, so it will be reloaded next time we try.
              Reviewed by Darin,
              * khtml/misc/loader.cpp:
              (Loader::slotFinished):  Remove cache entry on job error.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · e94e43ff
      darin authored
      	- fixed 96/72 dpi snafu; no need to do something different for AppKit,
                because it always uses pixel sizes, not font size
              * khtml/css/css_valueimpl.cpp:
              * khtml/css/css_valueimpl.h:
              * khtml/css/cssstyleselector.cpp:
              * kwq/KWQPaintDeviceMetrics.mm:
      	Rolled out change from 2002-12-05
      	- a cut at implementing heretofore unimplemented QTextStream classes
              * kwq/KWQTextStream.h:
              * kwq/KWQTextStream.mm:
      	First cut implementation.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sheridan's avatar
      Safari-49 stamp. · ca58bc0a
      sheridan authored
      Note that I am not using "Alexander" in the tag name any more (RIP Great Alex)
      and that I did not rev the marketing version.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. 05 Jan, 2003 2 commits
    • mjs's avatar
      JavaScriptCore: · 6bdbdeb1
      mjs authored
              Reviewed by no one cause I'm just changing copyright strings.
              * JavaScriptCore.pbproj/project.pbxproj: Added non-Apple copyrights to
      	copyright strings.
              * English.lproj/InfoPlist.strings: Likewise.
              Reviewed by no one cause I'm just changing copyright strings.
              * WebCore.pbproj/project.pbxproj: Added non-Apple copyrights to
      	copyright strings.
              * English.lproj/InfoPlist.strings: Likewise.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      JavaScriptCore: · 9b19889b
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Fix "Apple Compupter" typo.
      	Remove unneeded CFBundleLongVersionString we don't use anywhere else.
              * WebFoundation.pbproj/project.pbxproj: Fix "Apple Compupter" typo.
              * Resources/Info.plist: Fix "Apple Compupter" typo.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. 04 Jan, 2003 2 commits
  11. 03 Jan, 2003 4 commits
    • rjw's avatar
      Fix for 3138425. Don't open a new window when document.open() is called · 5f65a093
      rjw authored
              with < 2 parameters.
              Reviewed by darin.
              * khtml/ecma/kjs_html.cpp:
              * khtml/ecma/kjs_window.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      WebCore: · b026936c
      rjw authored
              Fixed 3138743, 3138678, and 3138854.  Removed the RenderText
              widths cache, replaced it with a much simply monospace character
              cache.  Should be much faster for covered cases too!  Also fixed
              buffer overrun problem causing the crash in 3138854.
              Reviewed by darin.
              * khtml/rendering/font.cpp:
              * khtml/rendering/font.h:
              * khtml/rendering/render_text.cpp:
              * khtml/rendering/render_text.h:
              * kwq/KWQFont.h:
              * kwq/KWQFont.mm:
              * kwq/WebCoreTextRendererFactory.h:
              * kwq/WebCoreTextRendererFactory.m:
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
              Support for fixes to 3138743, 3138678.  Added
              isFontFixedPitch used to determine if font is fixed
              pitch.  Makes use of appkit private _isFakeFixedPitch
              (detects courier and monoca).  Updated our fakey test
              to use the appkit's version.
              Reviewed by darin.
              * WebCoreSupport.subproj/WebTextRenderer.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              (-[WebTextRendererFactory isFontFixedPitch:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      - fixed 3138673 -- reproducible crash in JavaScript · 70d94889
      sullivan authored
              Reviewed by Darin, OK'ed by Don.
              * khtml/xml/dom_docimpl.cpp:
      	Check for nil view or nil part before dereferencing.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for percentage table heights. A check was missing to · 7c6e5520
      hyatt authored
      	look for a fixed height on the containing block.
              Reviewed by darin
              * khtml/rendering/render_table.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. 02 Jan, 2003 6 commits
    • kocienda's avatar
      Building Safari-48 · b9e87464
      kocienda authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 3136473. <object>s with no specified size should be · b30fb841
      hyatt authored
      	0x0.  They should not be 300x200.  Fixes thinker.org.
              Reviewed by john and darin.
              * khtml/rendering/render_frames.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej and Trey. · ba021ece
      darin authored
      	- fixed 3138063 -- REGRESSION: JavaScript-submitted form activates input type=image (webmail.mac.com)
      	JavaScript-submitted forms must not get a submit button activated as return-key-submitted ones do.
              * khtml/html/html_formimpl.h: Add boolean activateSubmitButton parameter to submit.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::prepareSubmit): Pass true for activateSubmitButton.
              (HTMLFormElementImpl::submit): Only activate a button if activateSubmitButton is true.
              * khtml/dom/html_form.cpp: (HTMLFormElement::submit): Pass false for activateSubmitButton.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for the 3137790. This patch passes the mouse event x and y as · 559ff05c
      hyatt authored
      	distinct arguments to constructZTree, so that the damageRect can
      	really reflect your clip rect.
      	This allows me to prune out layers that are clipped so
      	that if x,y aren't inside the clip rect, the layer doesn't get added to
      	the list.
      	This patch also makes the "clip" property apply to the element that specifies the clip instead of to the element's kids.  This is ambiguous in the spec, but it turns out other browsers do it this way, so there really is an interpretation that must be followed. :)
      	Reviewed by darin
              * khtml/rendering/render_layer.cpp:
              * khtml/rendering/render_layer.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for bug #3137935. When a float causes a line to get · a14d1741
      hyatt authored
      	moved down past the float, the line would incorrectly break
      	rather than expanding to use the newly-available width.
              Reviewed by darin.
              * khtml/rendering/bidi.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John. · 5be0ed74
      darin authored
      	- fixed 3131190 -- <textarea wrap="hard"> eats text on blur
              * kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Add missing parentheses so we don't
      	always return 0 or 1 for the number of paragraphs.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. 01 Jan, 2003 3 commits
    • mjs's avatar
      WebCore: · 51e8fadc
      mjs authored
              Reviewed by Darin.
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
      	(KWQKHTMLPart::KWQKHTMLPart): Initialize new mouseDownMayStartDrag
      	and mouseDownMayStartSelect methods.
              (KWQKHTMLPart::khtmlMousePressEvent): Make sure a mouse down
      	won't be used to start a drag or selection if the default action
      	is prevented on the mouse down event.
      	(KWQKHTMLPart::mouseDown): Since the default action wasn't
      	prevented, decide if this might be the start of a drag or
              (KWQKHTMLPart::khtmlMouseMoveEvent): On a drag or selection, call
      	back to the bridge to handle selection or autoscrolling
      	* kwq/WebCoreBridge.h: Prototype new methods.
      	Reviewed by Darin.
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView.
              (-[WebBridge mayStartDragWithMouseDown:]): Likewise.
              (-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDragged:]): Instead of doing drag handling
      	here, just pass the event to WebCore.
      	(-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
      	mousemove event instead of sending the current event (likely a
      	mouse up as if it were a mouse move).
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLViewPrivate dealloc]): Release drag element if any.
              (-[WebHTMLView _dragImageForElement:]): New method. Split out the
      	code to make the special drag image for links.
      	(-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
      	here. This method will get called only if WebCore hasn't blocked
      	default drag handling.
              (-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do
      	autoscroll. Autoscroll is still lame, we need a timer.
              (-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element
      	is a link or image and so may be dragged; remember the drag element.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Don. · 9b33efdb
      darin authored
      	- fixed 3137566 -- non-reproducible nil-dereference in KHTMLView::clearPart
      	deallocating KWQPageState
              * kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Add nil check.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix tables so that malformations inside them are properly pulled · a176a20d
      hyatt authored
      	out of the table without being flattened.
      	Fixes 3131480.
              Reviewed by gramps
              * khtml/html/dtd.cpp:
              * khtml/html/htmlparser.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. 31 Dec, 2002 2 commits
    • kocienda's avatar
      Building Safari-47 · 9baeec4e
      kocienda authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Trey. · c67613fa
      darin authored
      	- fixed 3132141 -- enter key does not work with input type=image
      	Made the logic handle image and submit type inputs in the same way.
              * khtml/html/html_formimpl.h: Remove unused m_clicked flags.
              * khtml/html/html_formimpl.cpp:
              (HTMLButtonElementImpl::HTMLButtonElementImpl): Remove code to set the m_clicked flag.
      	The only place this flag was looked at is better handled by the m_activeSubmit flag.
              (HTMLButtonElementImpl::defaultEventHandler): Remove more m_clicked flag code.
              (HTMLInputElementImpl::HTMLInputElementImpl): Remove more m_clicked flag code.
              (HTMLInputElementImpl::isSuccessfulSubmitButton): An image is also a successful submit
      	button, and unlike a submit element, it doesn't require a name because it will just submit
              x and y with no name in that case. I suppose we could rename this function, but I think it's
              still a pretty clear name even if not 100% accurate.
              (HTMLInputElementImpl::encoding): Remove use of m_clicked and use m_activeSubmit instead.
      	This was the only place using m_clicked at all. Also remove bogus check for a -1 coordinate.
      	The coordinate defaults to 0, not -1, and it was never happening.
              (HTMLInputElementImpl::defaultEventHandler): Remove more m_clicked flag code.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3218 268f45cc-cd09-0410-ab3c-d52691b4dbfc