1. 09 Sep, 2011 8 commits
  2. 08 Sep, 2011 32 commits
    • ukai@chromium.org's avatar
      Unreviewed, update chromium test expectations. · da560641
      ukai@chromium.org authored
      * platform/chromium/test_expectations.txt: chromium/compositing/zoom-animator-scale-test missing on leopard gpu
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da560641
    • ukai@chromium.org's avatar
      Unreviewed, update chromium test expectations. · 5a8f23ea
      ukai@chromium.org authored
      * platform/chromium/test_expectations.txt: add webaudio/sample-accurate-scheduling.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a8f23ea
    • sullivan@chromium.org's avatar
      Crashes in WebCore::InsertNodeBeforeCommand constructor. · f91bb620
      sullivan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67763
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that
      positions which are before or after a given node cannot return that node as the editable root.
      
      Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html
      
      * editing/htmlediting.cpp:
      (WebCore::editableRootForPosition): use containerNode instead of deprecatedNode.
      
      LayoutTests:
      
      Tests for crash when the selection is outside the contenteditable node.
      
      * editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added.
      * editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f91bb620
    • dbates@webkit.org's avatar
      XSS filter bypass via non-standard URL encoding · adf5c3c2
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66588
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Tests: http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html
             http/tests/security/xssAuditor/script-tag-with-16bit-unicode.html
             http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html
             http/tests/security/xssAuditor/script-tag-with-16bit-unicode3.html
             http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html
             http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html
             http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html
             http/tests/security/xssAuditor/window-open-without-url-should-not-assert.html
      
      Implement support for decoding non-standard 16-bit Unicode escape sequences of
      the form %u26C4 as described in <http://www.w3.org/International/iri-edit/draft-duerst-iri.html#anchor29>.
      
      See also <http://en.wikipedia.org/wiki/Percent-encoding#Non-standard_implementations>.
      
      * GNUmakefile.list.am: Added DecodeEscapeSequences.h.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * html/parser/XSSAuditor.cpp:
      (WebCore::decode16BitUnicodeEscapeSequences): Added.
      (WebCore::decodeStandardURLEscapeSequences): Added.
      (WebCore::fullyDecodeString): Modified to call decode16BitUnicodeEscapeSequences().
      (WebCore::XSSAuditor::init): Modified to return early when the URL of the document
      is the empty string. This can happen when opening a new browser window or calling
      window.open("").
      * platform/KURL.cpp:
      (WebCore::decodeURLEscapeSequences): Abstracted code into template-function decodeEscapeSequences().
      This function just calls decodeEscapeSequences<URLEscapeSequence>().
      * platform/text/DecodeEscapeSequences.h: Added.
      (WebCore::Unicode16BitEscapeSequence::findInString):
      (WebCore::Unicode16BitEscapeSequence::matchStringPrefix):
      (WebCore::Unicode16BitEscapeSequence::decodeRun):
      (WebCore::URLEscapeSequence::findInString):
      (WebCore::URLEscapeSequence::matchStringPrefix):
      (WebCore::URLEscapeSequence::decodeRun):
      (WebCore::decodeEscapeSequences):
      
      LayoutTests: 
      
      Add tests for decoding non-standard 16-bit Unicode escape sequences.
      
      Also add a test to ensure that we don't cause an assertion failure when
      calling window.open("").
      
      * http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl: Added.
      (isUTF16Surrogate):
      (decodeRunOf16BitUnicodeEscapeSequences):
      (decode16BitUnicodeEscapeSequences):
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html: Added.
      * http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Updated expected
      result since we now pass this test. We should rename this file to something more descriptive,
      see <https://bugs.webkit.org/show_bug.cgi?id=67818>.
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt: Added.
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html: Added.
      * http/tests/security/xssAuditor/window-open-without-url-should-not-assert-expected.txt: Added.
      * http/tests/security/xssAuditor/window-open-without-url-should-not-assert.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adf5c3c2
    • ukai@chromium.org's avatar
      Unreviewed. Chromium rebaseline of css3/bdi-element.html · 4fc0052d
      ukai@chromium.org authored
      * platform/chromium-cg-mac/css3/bdi-element-expected.png: Added.
      * platform/chromium-linux/css3/bdi-element-expected.png: Added.
      * platform/chromium-mac/css3/bdi-element-expected.png: Added.
      * platform/chromium-win/css3/bdi-element-expected.png: Added.
      * platform/chromium-win/css3/bdi-element-expected.txt: Added.
      * platform/chromium/css3/bdi-element-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fc0052d
    • eric@webkit.org's avatar
      [BiDi] Add support for the BDI element · 0c65fb0f
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=50913
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      This patch is ridiculously trivial now that we have unicode-bidi: isolate support in WebKit.
      
      Test: css3/bdi-element.html
      
      * css/html.css:
      (bdi):
      
      LayoutTests:
      
      * css3/bdi-element.html: Added.
      * platform/mac/css3/bdi-element-expected.png: Added.
      * platform/mac/css3/bdi-element-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c65fb0f
    • rolandsteiner@chromium.org's avatar
      Unreviewed, rolling out r94809. · 55b28ab6
      rolandsteiner@chromium.org authored
      http://trac.webkit.org/changeset/94809
      https://bugs.webkit.org/show_bug.cgi?id=67718
      
      commit _still_ premature, despite CQ eagerness
      
      Source/WebCore:
      
      * html/HTMLAttributeNames.in:
      * html/HTMLStyleElement.cpp:
      * html/HTMLStyleElement.h:
      * html/HTMLStyleElement.idl:
      
      LayoutTests:
      
      * fast/css/style-scoped/basic-attribute-expected.txt: Removed.
      * fast/css/style-scoped/basic-attribute.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55b28ab6
    • rolandsteiner@chromium.org's avatar
      <style scoped>: Add 'scoped' attribute · 16a03c20
      rolandsteiner@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67718
      
      Source/WebCore:
      
      Add 'scoped' attribute to IDL and attribute list,
      implement and test setting/resetting of the attribute.
      
      Reviewed by Dimitri Glazkov.
      
      Test: fast/css/style-scoped/basic-attribute.html
      
      * html/HTMLAttributeNames.in:
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::scoped):
      (WebCore::HTMLStyleElement::setScoped):
      (WebCore::HTMLStyleElement::scopingElement):
      * html/HTMLStyleElement.h:
      * html/HTMLStyleElement.idl:
      
      LayoutTests:
      
      Test setting/resetting of the 'scoped' attribute in various circumstances.
      
      Reviewed by Dimitri Glazkov.
      
      * fast/css/style-scoped/basic-attribute-expected.txt: Added.
      * fast/css/style-scoped/basic-attribute.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16a03c20
    • tony@chromium.org's avatar
      remove fast/exclusions/triangle-exclusion.html which was originally added as a placeholder · 78ef321c
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67795
      
      * fast/exclusions/triangle-exclusion.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78ef321c
    • japhet@chromium.org's avatar
      2011-09-08 Nate Chapin <japhet@chromium.org> · ed6c2130
      japhet@chromium.org authored
              Chromium rebaseline zoom-animator-scale-test.html and mark a couple
              svg-as-background tests flaky on chromium-win.
      
              * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Removed.
              * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed.
              * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
              * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed6c2130
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r94781. · a1fee1c1
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/94781
      https://bugs.webkit.org/show_bug.cgi?id=67806
      
      Broke Objective-C binding on Mac (Requested by rniwa on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08
      
      Source/WebCore:
      
      * dom/Element.idl:
      * dom/Node.cpp:
      (WebCore::Node::contains):
      * dom/Node.idl:
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::mergeParagraphs):
      
      LayoutTests:
      
      * fast/dom/Element/contains-method-expected.txt: Added.
      * fast/dom/Element/contains-method.html: Renamed from LayoutTests/fast/dom/Node/contains-method.html.
      * fast/dom/Element/script-tests/contains-method.js: Added.
      * fast/dom/Node/contains-method-expected.txt: Removed.
      * fast/dom/Node/script-tests/contains-method.js: Removed.
      * fast/dom/Window/window-properties-expected.txt:
      * perf/document-contains-expected.txt: Removed.
      * perf/document-contains.html: Removed.
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/mac/fast/dom/Window/window-properties-expected.txt:
      * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1fee1c1
    • ossy@webkit.org's avatar
      [WK2] evetSender.keyDown is unimplemented · 2c9112e8
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57515
      
      * platform/wk2/Skipped: Skip fast/dom/shadow/access-key.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9112e8
    • commit-queue@webkit.org's avatar
      Chromium shadow-buffer-partial test change. · c27047f9
      commit-queue@webkit.org authored
      Part1: Update and disable test.
      https://bugs.webkit.org/show_bug.cgi?id=67724
      
      Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-08
      Reviewed by Kenneth Russell.
      
      * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c27047f9
    • commit-queue@webkit.org's avatar
      frame-loading-via-document-write.html test cases have extra slash in path · 574b7f45
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67784
      
      Removing extra slash in path: file:////tmp/... => file:///tmp/...
      
      Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-08
      Reviewed by Andreas Kling.
      
      * fast/dom/frame-loading-via-document-write.html:
      * http/tests/security/frame-loading-via-document-write.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      574b7f45
    • ap@apple.com's avatar
      Some file-url-mimetypes subtests fail on rare extensions · 0f02d113
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=67679
      
              * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
              * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
              * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
              * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
              Update platform specific results, too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f02d113
    • commit-queue@webkit.org's avatar
      Crashes in WebCore::ReplaceSelectionCommand::doApply · 7bc041d6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67762
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-08
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.
      
      Tests: editing/inserting/insert-without-enclosing-block.html
      
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::doApply): Added null check.
      
      LayoutTests:
      
      WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.
      
      * editing/inserting/insert-without-enclosing-block-expected.txt: Added.
      * editing/inserting/insert-without-enclosing-block.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bc041d6
    • japhet@chromium.org's avatar
      2011-09-08 Nate Chapin <japhet@chromium.org> · 67f89746
      japhet@chromium.org authored
              Chromium baselines for new tests added in r94775 and r94779.
      
              * platform/chromium-cg-mac/platform/chromium/fast/repaint: Added.
              * platform/chromium-cg-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
              * platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Added.
              * platform/chromium-linux/css3/unicode-bidi-isolate-basic-expected.png: Added.
              * platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Added.
              * platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
              * platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.png: Added.
              * platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f89746
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening after r94771. · e64c687c
      ossy@webkit.org authored
      * fast/dom/constructed-objects-prototypes-expected.txt: Update, it will pass on Qt, GTK, SL, Win.
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e64c687c
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r94784. · 05306459
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/94784
      https://bugs.webkit.org/show_bug.cgi?id=67796
      
      Commit was premature (Requested by rolandsteiner on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08
      
      Source/WebCore:
      
      * html/HTMLAttributeNames.in:
      * html/HTMLStyleElement.cpp:
      * html/HTMLStyleElement.h:
      * html/HTMLStyleElement.idl:
      
      LayoutTests:
      
      * fast/css/style-scoped/basic-attribute-expected.txt: Removed.
      * fast/css/style-scoped/basic-attribute.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05306459
    • wjmaclean@chromium.org's avatar
      [chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation. · bcdc0689
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66472
      
      Source/WebCore:
      
      This patch contains plumbing from Internals to WebViewImpl that can be removed
      at a later time when the zoom animator code is complete.
      
      Reviewed by James Robinson.
      
      Test: platform/chromium/compositing/zoom-animator-scale-test.html
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      (WebCore::Settings::setZoomAnimatorScale):
      (WebCore::Settings::zoomAnimatorScale):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::LayerRendererChromium):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::setZoomAnimatorScale):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::commitTo):
      (WebCore::CCLayerTreeHost::setZoomAnimatorScale):
      (WebCore::CCLayerTreeHost::updateLayers):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::setZoomAnimatorScale):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * testing/Internals.cpp:
      (WebCore::Internals::setZoomAnimatorScale):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      This patch contains plumbing from Internals to WebViewImpl that can be removed
      at a later time when the zoom animator code is complete.
      
      Reviewed by James Robinson.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setZoomLevel):
      (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
      
      LayoutTests:
      
      Initial tests for zoomAnimatorChromium backend.
      
      Reviewed by James Robinson.
      
      * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
      * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
      * platform/chromium/compositing/zoom-animator-scale-test.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcdc0689
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · 29f045f8
      ossy@webkit.org authored
      * platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29f045f8
    • eric.carlson@apple.com's avatar
      HTMLMediaElement is missing initialTime attribute · f381ec99
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67791
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: media/media-initialTime.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::initialTime):
      * html/HTMLMediaElement.h:
      * html/HTMLMediaElement.idl:
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::initialTime):
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::initialTime):
      
      LayoutTests: 
      
      * media/media-initialTime-expected.txt: Added.
      * media/media-initialTime.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f381ec99
    • robert@webkit.org's avatar
      Elements with position:absolute don't move to correct position after images load · d739d387
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=54611
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Test: fast/block/positioning/absolute-layout-after-image-load.html
      
      In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
      this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
      the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
      There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check.
      
      Note: Although the issue is encountered only on first load without a fragment identifier, it
      happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
      because scrolling to the fragment always happens before the image has loaded, rendering the page
      and clearing the initial dirty bits in the positioned element's renderer. When the image finally
      loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
      re-rendered.
      
      Note: This was originally landed in r94755 but positioned-float-layout-after-image-load.html exposed
            an ASSERT bug, unrelated to this change, and was rolled out. That issue is tracked separately
            in bug 67759.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when
                                                       deciding whether to mark children for layout
      
      LayoutTests:
      
      * fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
      * fast/block/positioning/absolute-layout-after-image-load.html: Added.
      * fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d739d387
    • rolandsteiner@chromium.org's avatar
      <style scoped>: Add 'scoped' attribute · 393117c9
      rolandsteiner@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67718
      
      Source/WebCore:
      
      Add 'scoped' attribute to IDL and attribute list,
      implement and test setting/resetting of the attribute.
      
      Reviewed by Dimitri Glazkov.
      
      Test: fast/css/style-scoped/basic-attribute.html
      
      * html/HTMLAttributeNames.in:
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::scoped):
      (WebCore::HTMLStyleElement::setScoped):
      (WebCore::HTMLStyleElement::scopingElement):
      * html/HTMLStyleElement.h:
      * html/HTMLStyleElement.idl:
      
      LayoutTests:
      
      Test setting/resetting of the 'scoped' attribute in various circumstances.
      
      Reviewed by Dimitri Glazkov.
      
      * fast/css/style-scoped/basic-attribute-expected.txt: Added.
      * fast/css/style-scoped/basic-attribute.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      393117c9
    • commit-queue@webkit.org's avatar
      Rebaseline for bug 65583 (path based border radius drawing on skia) part 2 · 12931cc5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67751
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-09-08
      Reviewed by Kenneth Russell.
      
      * fast/borders/border-radius-circle-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-circle-expected.txt.
      * fast/borders/border-radius-groove-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-01-expected.txt.
      * fast/borders/border-radius-groove-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-02-expected.txt.
      * fast/borders/border-radius-groove-03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-03-expected.txt.
      * fast/borders/border-radius-wide-border-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt.
      * fast/borders/border-radius-wide-border-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-02-expected.txt.
      * fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
      * fast/gradients/background-clipped-expected.txt: Renamed from LayoutTests/platform/gtk/fast/gradients/background-clipped-expected.txt.
      * fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt.
      * fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt.
      * fast/transforms/shadows-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/shadows-expected.txt.
      * platform/chromium-linux/fast/: 20 changes.
      * platform/chromium-win/fast/: 19 changes.
      * platform/chromium/test_expectations.txt:
      * platform/mac/fast/: 9 changes.
      * platform/qt/fast/: 10 removals.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12931cc5
    • arv@chromium.org's avatar
      Move Element.contains to Node · beefbd65
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67651
      
      Reviewed by Darin Adler.
      
      This moves the contains method from Element to Node as in the DOM4 working draft:
      http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains
      
      This also special cases Document contains to make it O(1) instead of O(depth).
      
      Source/WebCore:
      
      Tests: fast/dom/Node/contains-method.html
             perf/document-contains.html
      
      * dom/Element.idl:
      * dom/Node.cpp:
      (WebCore::Node::contains): Added document special case.
      * dom/Node.idl:
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::mergeParagraphs): Added a null check.
      
      LayoutTests:
      
      * fast/dom/Element/contains-method-expected.txt: Removed.
      * fast/dom/Element/script-tests/contains-method.js: Removed.
      * fast/dom/Node/contains-method-expected.txt: Added.
      * fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html.
      * fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests.
      * fast/dom/Window/window-properties-expected.txt:
      * perf/document-contains-expected.txt: Added.
      * perf/document-contains.html: Added.
                                     Perf test to ensure that document.contains is O(1).
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/mac/fast/dom/Window/window-properties-expected.txt:
      * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      beefbd65
    • crogers@google.com's avatar
      Check AudioContext createChannelMerger() for thread safety · baf6d3ab
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67247
      
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      Test: webaudio/audiochannelmerger-stereo.html
      
      * webaudio/AudioChannelMerger.cpp:
      (WebCore::AudioChannelMerger::process):
      (WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
      * webaudio/AudioChannelMerger.h:
      
      LayoutTests:
      
      * webaudio/audiochannelmerger-stereo-expected.txt: Added.
      * webaudio/audiochannelmerger-stereo.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baf6d3ab
    • fsamuel@chromium.org's avatar
      Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms · cdf0c235
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67723
      
      Reviewed by Adam Barth.
      
      Tools:
      
      * DumpRenderTree/chromium/EventSender.h:
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::enableFixedLayoutMode):
      (LayoutTestController::setFixedLayoutSize):
      * DumpRenderTree/chromium/LayoutTestController.h:
      
      LayoutTests:
      
      * platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
      * platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added.
      * platform/chromium/fast/repaint/fixed-layout-360x240.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdf0c235
    • eric@webkit.org's avatar
      Reviewed by Ryosuke Niwa. · a26de04c
      eric@webkit.org authored
      [BiDi] [CSS3] MASTER: Add support for the unicode-bidi:isolate CSS property
      https://bugs.webkit.org/show_bug.cgi?id=50912
      
      Source/WebCore:
      
      This patch adds support for CSS3 unicode-bidi: isolate property, under the -webkit- vendor prefix.
      Parsing support was added in a previous patch, this wires up the RenderStyle values
      to code changes in the BidiResolver.
      
      The effect of this patch is that it makes it possible to "isolate" runs of text
      so that their RTL-ness or LTR-ness does not bleed out into the rest of your text
      and effect layout.  This is important because many unicode characters (like parenthesis, ':', '-', etc.)
      do not have intrinsic directionality and are affected by whatever characters come before/after.
      If you have usernames which include RTL text, if you inject those usernames in your page
      you might end up with nearby characters moving!
      (like 'RTL USERNAME - my awesome site' as a title, could end up as
      'my awesome site - USERNAME RTL' when correct would be 'USERNAME RTL - my awesome site'.)
      This patch makes it possible to wrap sections of text in isolated spans, so that
      they correctly order all their RTL/LTR contents, but also correctly participate in the
      larger RTL/LTR ordering without affecting nearby characters.
      
      Because much of this code is old and rarely touched, I've included extra background
      information in hopes of expanding my set of potential reviewers:
      
      WebKit uses the standard "Unicode Bidi Algorithm" henceforth known as the UBA.
      The UBA is defined at http://unicode.org/reports/tr9/ for those not faint of heart.
      
      Text layout is done per-block (<div>, <p>, etc), and begins with a string of text
      (which in our case comes from the rendering tree) and a specified width.
      First:  Text is measured and wrapped into lines.
      Second: The UBA is run over the lines of text.
      Third:  WebKit builds InlineBoxes (its linebox tree) and eventually render the text.
      
      This patch modifies our UBA to ignore all text content inside "isolated" inlines (treating them as neutral characters)
      and then adds another step after running the UBA, where we run the UBA recursively on any
      previously identified "isolated" content.
      
      The result of the UBA is an ordered list of "runs" of text with the RTL runs
      correctly RTL and the LTR runs LTR.
      
      The UBA does three things:
      1.  It assigns a "class" to each character in a text stream (like neutral, strongly-RTL, strongly-LTR, etc.)
      2.  Divides the text stream up into "runs" of characters of the same directionality (all RTL, all LTR).
      3.  Re-orders those runs.
      
      The UBA in WebKit is implemented by BidiResolver<T> in BidiResolver.h
      
      The InlineBidiResolver (BidiResolver specialization which knows about the rendering tree)
      walks along its InlineIterators, looking at each character and running the
      Unicode Bidi Algorithm (UBA).  It walks through the rendering tree subtree under
      a block, using a (poorly named) bidiNext function which returns the next inline object.
      Each inline object (or text character there-in) has a corresponding meaning in the UBA
      such as a "strong RTL" character or a "neutral" character.  The UBA reads these sequence
      of characters, and figures out what direction (RTL or LTR) to assign to any neutral
      characters it encounters, based on surrounding characters.
      
      As the InlineBidiResolver is walking the rendering tree, the InlineIterator::advance()
      function calls bidiNext(), which in turn can call notifyObserverEnteredObject/notifyObserverWillExitObject
      notifying InlineBidiResolver that it is entering or exiting an "isolated"
      span, at which point it will either start or stop ignoring the stream of characters
      from the InlineIterator.  When the InlineBidiResolver is ignoring the stream of
      characters, instead of creating separate BidiRuns at each RTL/LTR boundary
      as it normally would, it instead creates one "fake" run for the entire
      isolated span.  These fake runs participate in the normal UBA run ordering process,
      but after the main UBA, a second pass is made where we examine
      the list of isolatedRuns() and run the UBA on each of them, replacing the fake
      run we previously inserted, with the resulting list of runs from that inner UBA run.
      The way it "ignores" characters is by treating them all as neutral when inside an isolate.
      Thus all the characters end up grouped in a single run, but their directionality (as a group)
      is correctly affected by any surrounding strong characters.
      
      If you understood that last paragraph, than the rest of the change is just plumbing.
      
      I added a huge number of FIXMEs to this code, because this code has a variety of
      design choices (or lack there of) which make some of this very difficult.
      
      For example the bidiNext iterator function has two sets of mutually exclusive
      parameters and can be used optionally with or without an observer.  Prior to this
      change there was only ever one object which cared about observing a walk over inlines
      and that was InlineBidiResolver.  This patch (regretfully) templatizes bidiNext
      to support a new Observer type.  The correct fix would be to rip bidiNext into
      multiple functions and rip need for observation out of InlineBidiResolver.
      Unfortunately I've tried both in separate bugs and failed.  This code is very very
      old and very poorly understood.  We're slowly moving forward, this is another tiny step.
      
      This is my fourth iteration of this patch (I'm happy to do more!), but I believe
      it's a good compromise between fixing all of the design gotcha's of our bidi
      system and doing the minimum amount to add this killer CSS feature.
      
      I ran the PLT.  (It averaged 0.2% faster with this change, but I attribute that to noise).
      
      Test: css3/unicode-bidi-isolate-basic.html and css3/unicode-bidi-isolate-aharon.html
      
      * platform/text/BidiResolver.h:
      (WebCore::BidiCharacterRun::setNext):
       - Needed by the new replaceRunWithRuns function.
      (WebCore::BidiResolver::BidiResolver):
      (WebCore::BidiResolver::~BidiResolver):
      (WebCore::BidiResolver::enterIsolate):
      (WebCore::BidiResolver::exitIsolate):
      (WebCore::BidiResolver::inIsolate):
      (WebCore::BidiResolver::isolatedRuns):
       - Used to track isolated spans of text as they're encoutered.
         They're stuffed away here to be processed recursively
         after the main UBA has done its thang.
      (WebCore::::appendRun):
      (WebCore::::embed):
      (WebCore::::commitExplicitEmbedding):
      (WebCore::::createBidiRunsForLine):
      * platform/text/BidiRunList.h:
      (WebCore::::replaceRunWithRuns):
       - This effectively takes all the runs from one runlist and adds them to
         this one, replacing the fake run we inserted during a previous pass of the UBA.
       - This RunList now owns the runs, so we call clear() on the other RunList
         so that we don't end up double-freeing the runs.
      (WebCore::::clear):
       - This allows us to "take" runs from another run list and then clear it.
      * rendering/BidiRun.h:
      (WebCore::BidiRun::object):
      * rendering/InlineIterator.h:
      (WebCore::InlineIterator::object):
      (WebCore::InlineIterator::offset):
      (WebCore::notifyObserverEnteredObject): Mostly just renaming and adding a FIXME about plaintext.
      (WebCore::notifyObserverWillExitObject): Mostly just renaming.
      (WebCore::addPlaceholderRunForIsolatedInline):
      (WebCore::isIsolatedInline):
      (WebCore::InlineBidiResolver::appendRun):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::statusWithDirection):
      (WebCore::constructBidiRuns):
       - This is the heavy-lifting of this change.  This function
         runs the UBA recursively on all the previously identified isolated spans.
       - If we encounter more isolated spans in our run, we just add them to the
         main list an keep going.  Because the runs are linked lists and we have
         direct pointers to our placeholder objects, we don't care what order
         we process the placeholders in, so long as when we're done, they're all processed.
      (WebCore::RenderBlock::layoutInlineChildren):
      
      LayoutTests:
      
      Two new tests for testing unicode-bidi: isolate behavior.
      Note that the test from Aharon Lanin has one failing subtest
      I've asked him if the test might have a typo in:
      https://bugs.webkit.org/show_bug.cgi?id=50912#c30
      
      * css3/unicode-bidi-isolate-aharon.html: Added.
       - Some various unicode-bidi: isolate tests from Aharon.
      * css3/unicode-bidi-isolate-basic.html: Added.
       - This test tries all possible orderings of strong-LTR, strong-RTL and neutral characters
         across unicode-bidi: isolate spans to make sure that we match expected rendering.
       - A little red bleeds through the test, but that appears to be from anti-aliasing
         and possible automatic font kerning, not layout failures.
      * platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
      * platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
      * platform/mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
      * platform/mac/css3/unicode-bidi-isolate-basic-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a26de04c
    • macpherson@chromium.org's avatar
      Update tests for inherit and initial values for -webkit-columns and related CSS properties. · 26562f41
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67685
      
      Reviewed by Eric Seidel.
      
      * fast/multicol/inherit-column-values-expected.txt:
      * fast/multicol/inherit-column-values.html:
      * fast/multicol/initial-column-values-expected.txt:
      * fast/multicol/initial-column-values.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26562f41
    • commit-queue@webkit.org's avatar
      Implement a ProgressEvent constructor for JSC · f90548b9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67537
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      The spec for the ProgressEvent constructor is here:
      http://www.w3.org/TR/progress-events/#interface-progressevent
      
      Test: fast/events/constructors/progress-event-constructor.html
      
      * bindings/generic/EventConstructors.h: Added a definition for the ProgressEvent constructor.
      * bindings/js/JSDictionary.cpp:
      (WebCore::JSDictionary::convertValue): Converts an ECMA-262 Number into an IDL unsigned long long value. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long
      * bindings/js/JSEventConstructors.cpp: Added #includes for ProgressEvent.
      * dom/ProgressEvent.cpp:
      (WebCore::ProgressEventInit::ProgressEventInit):
      (WebCore::ProgressEvent::ProgressEvent):
      * dom/ProgressEvent.h: Added a definition for ProgressEventInit.
      (WebCore::ProgressEvent::create):
      * dom/ProgressEvent.idl: Makes ProgressEvent constructible.
      
      LayoutTests:
      
      * fast/events/constructors/progress-event-constructor-expected.txt: Added.
      * fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
      * platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f90548b9
    • japhet@chromium.org's avatar
      2011-09-08 Nate Chapin <japhet@chromium.org> · cb46f2a5
      japhet@chromium.org authored
              Rebaseline svg/W3C-SVG-1.1-SE/filters-image-05-f.svg text for chromium win/linux.
      
              * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
              * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Removed.
              * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb46f2a5