Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 06 Jan, 2011 11 commits
  3. 05 Jan, 2011 21 commits
    • commit-queue@webkit.org's avatar
      2011-01-05 Helder Correia <helder@sencha.com> · 13b196e5
      commit-queue@webkit.org authored 
              Reviewed by Simon Fraser.

        Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
        https://bugs.webkit.org/show_bug.cgi?id=51869

        GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
        The shadow is being drawn, but getting clipped to the rect being filled.
        The solution is to draw the gradient into a CGLayer (when a shadow is
        required), then render the layer to the GraphicsContext.

        This patch also fixes:
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html

        New test to ensure that shadows are drawn when fillStyle is a gradient,
        possibly with some transparency and blur, and specifically using
        fillRect.

        * fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
        https://bugs.webkit.org/show_bug.cgi?id=51869

        GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
        The shadow is being drawn, but getting clipped to the rect being filled.
        The solution is to draw the gradient into a CGLayer (when a shadow is
        required), then render the layer to the GraphicsContext.

        This patch also fixes:
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html

        Test: fast/canvas/canvas-fillRect-gradient-shadow.html

        * platform/graphics/Gradient.h:
        * platform/graphics/cg/GradientCG.cpp:
        (WebCore::Gradient::paint):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b196e5
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · 1f3fb4c5
      simon.fraser@apple.com authored 
              Reviewed by Ariya Hidayat.

        Directly composited SVG images fail to render
        https://bugs.webkit.org/show_bug.cgi?id=51975

        There was already code, added in r67900, to detect whether an image
        may be directly composited, by checking to see if it's a bitmap image.

        However, CachedImage::image() returns the nullImage() if m_image is null,
        which is a BitmapImage, confusing this test.

        Test: compositing/images/direct-svg-image.html

        * loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
        exactly the same method.
        (WebCore::CachedImage::image): Use Image::nullImage().
        * loader/cache/CachedImage.h:
        (WebCore::CachedImage::hasImage): New method to ask whether the m_image is
        non-null.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
        so that we don't test the nullImage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f3fb4c5
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · b81b821c
      simon.fraser@apple.com authored 
              Reviewed by Darin Adler.

        Fix percentage values in radius of radial gradients
        https://bugs.webkit.org/show_bug.cgi?id=51979

        Handle percentage values for the ending size of radial gradients.

        Test: fast/gradients/css3-radial-gradients3.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
        non-null if percentage values are allowed, and compute percentage values when we see them.
        (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
        percentages are OK when resolving end radii.
        * css/CSSGradientValue.h: New parameter for resolveRadius.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b81b821c
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · 92bc9b02
      simonjam@chromium.org authored 
              Reviewed by Adam Barth.

        [Web Timing] Zero out some values on cross-origin redirects
        https://bugs.webkit.org/show_bug.cgi?id=49294

        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately.
        (checkTimingWhileDeferred): Ditto.
        (checkWebTimingOnDOMContentLoaded): Ditto.
        (checkWebTimingWhileAsync): Ditto.
        (checkWebTimingOnLoad): Ditto.
        (checkWebTimingAfterLoad): Ditto.
        * fast/dom/webtiming-expected.txt:
        * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
        * http/tests/misc/resources/webtiming-no-origin.html: Added.
        * http/tests/misc/webtiming-origins-expected.txt: Added.
        * http/tests/misc/webtiming-origins.html: Added.
        * platform/gtk/Skipped: Skip new web timing test.
        * platform/mac/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        [Web Timing] Zero out some values on cross-origin redirects
        https://bugs.webkit.org/show_bug.cgi?id=49294

        Tests: http/tests/misc/webtiming-cross-origin-redirect.php
               http/tests/misc/webtiming-origins.html

        * loader/DocumentLoadTiming.h:
        (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::~FrameLoader):
        (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
        (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
        * loader/FrameLoader.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
        * page/PerformanceNavigation.cpp:
        (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::redirectStart): Ditto.
        (WebCore::PerformanceTiming::redirectEnd): Ditto.
        (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
        (WebCore::PerformanceTiming::unloadEventEnd): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bc9b02
    • commit-queue@webkit.org's avatar
      2011-01-05 Helder Correia <helder@sencha.com> · 77eb884c
      commit-queue@webkit.org authored 
              Reviewed by Ariya Hidayat.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        This is an intermediate step to solve this bug. Use QPalette::Highlight
        instead of default half-transparent black as the focus ring color.

        * platform/qt/editing/selection/caret-and-focus-ring-expected.checksum: Added.
        * platform/qt/editing/selection/caret-and-focus-ring-expected.png: Added.
        * platform/qt/editing/selection/caret-and-focus-ring-expected.txt: Added.
        * platform/qt/fast/css/focus-ring-outline-color-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-color-expected.png:
        * platform/qt/fast/css/focus-ring-outline-offset-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-offset-expected.png:
        * platform/qt/fast/css/focus-ring-outline-width-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-width-expected.png:
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        This is an intermediate step to solve this bug. Use QPalette::Highlight
        instead of default half-transparent black as the focus ring color.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawFocusRingForPath):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::platformFocusRingColor):
        * platform/qt/RenderThemeQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77eb884c
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · f6fac390
      simonjam@chromium.org authored 
              Reviewed by Darin Fisher.

        [Web Timing] requestStart and responseStart should be available even if the document is still loading
        https://bugs.webkit.org/show_bug.cgi?id=51368

        * http/tests/misc/webtiming-slow-load-expected.txt: Added.
        * http/tests/misc/webtiming-slow-load.php: Added.
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] requestStart and responseStart should be available even if the document is still loading
        https://bugs.webkit.org/show_bug.cgi?id=51368

        Test: http/tests/misc/webtiming-slow-load.php

        * page/PerformanceTiming.cpp:
        (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete.
        (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6fac390
    • tkent@chromium.org's avatar
      2011-01-05 Kent Tamura <tkent@chromium.org> · 7d475455
      tkent@chromium.org authored 
              Unreviewed, test expectation update.

        Rebaseline of renderer-destruction-by-invalidateSelection-crash.html

        * platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
        * platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
        * platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d475455
    • commit-queue@webkit.org's avatar
      2011-01-05 Jenn Braithwaite <jennb@chromium.org> · e117e221
      commit-queue@webkit.org authored 
              Reviewed by Adam Barth.

        fast/encoding/parser-tests.html is slow on debug builds
        https://bugs.webkit.org/show_bug.cgi?id=51721

        Break up parser tests to run 10 tests per batch.

        * fast/encoding/parser-tests-10-expected.txt: Added.
        * fast/encoding/parser-tests-10.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-100-expected.txt: Added.
        * fast/encoding/parser-tests-100.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-110-expected.txt: Added.
        * fast/encoding/parser-tests-110.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-120-expected.txt: Added.
        * fast/encoding/parser-tests-120.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-20-expected.txt: Added.
        * fast/encoding/parser-tests-20.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-30-expected.txt: Added.
        * fast/encoding/parser-tests-30.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-40-expected.txt: Added.
        * fast/encoding/parser-tests-40.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-50-expected.txt: Added.
        * fast/encoding/parser-tests-50.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-60-expected.txt: Added.
        * fast/encoding/parser-tests-60.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-70-expected.txt: Added.
        * fast/encoding/parser-tests-70.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-80-expected.txt: Added.
        * fast/encoding/parser-tests-80.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-90-expected.txt: Added.
        * fast/encoding/parser-tests-90.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-expected.txt:
        * fast/encoding/parser-tests.html:
        * fast/encoding/resources/parser-tests.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e117e221
    • hans@chromium.org's avatar
      2011-01-05 Hans Wennborg <hans@chromium.org> · a61b08a8
      hans@chromium.org authored 
              Reviewed by Jeremy Orlow.

        [Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266
        https://bugs.webkit.org/show_bug.cgi?id=51731

        Fix the layout test by using a known-good date value rather than
        new Date(), which sometimes causes the test to fail.

        (The underlying reason for failing to store certain Date values
        should of course be fixed too, but that will come in a later patch.)

        * platform/chromium/test_expectations.txt:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a61b08a8
    • senorblanco@chromium.org's avatar
      2011-01-05 Stephen White <senorblanco@chromium.org> · 4e86967a
      senorblanco@chromium.org authored 
              Unreviewed; test expectations update..

        Fix the expectations for the hyphenation tests on chromium-win.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e86967a
    • senorblanco@chromium.org's avatar
      2011-01-05 Stephen White <senorblanco@chromium.org> · 5ef61c7b
      senorblanco@chromium.org authored 
              Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Add expectations for new tests introduced by r75097.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ef61c7b
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · 3f478caa
      simon.fraser@apple.com authored 
              Reviewed by Dave Hyatt.

        Implement repeating CSS3 gradients
        https://bugs.webkit.org/show_bug.cgi?id=51843

        Add support for repeating gradients, via the new gradient functions
        -webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.

        Tests: fast/gradients/css3-repeating-linear-gradients.html
               fast/gradients/css3-repeating-radial-gradients.html

        * css/CSSGradientValue.h:
        (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats.
        (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in.
        (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat.
        (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto
        (WebCore::CSSRadialGradientValue::create): Ditto.
        (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which
        is used for repeating radial gradients. Add code to repeat the stops,
        adding stops before the start, and after the end until the 0-N range is
        covered, where N is large enough to ensure the box is covered. Fix an issue
        with repeating gradients where if both stops were < 0, it would fail to clamp
        them to 0.

        (WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
        because they are guaranteed to fill the box already.
        (WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
        corner in order to inform addStops() how much additional extent is required.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat.
        (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat.
        (WebCore::CSSParser::parseRadialGradient): Ditto.
        (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions.
        (WebCore::CSSParser::parseGeneratedImage): Ditto.
        * css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
        * platform/graphics/cg/GradientCG.cpp: Remove unused #include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f478caa
    • senorblanco@chromium.org's avatar
      2011-01-05 Stephen White <senorblanco@chromium.org> · 9b4b6660
      senorblanco@chromium.org authored 
              Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Add a few failing tests to chromium's test expectations file.
        * platform/chromium-gpu/test_expectations.txt:
        Mark the shadow-offset tests as crashing on win debug (GPU).  Remove
        a duplicate MAC expectation.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b4b6660
    • senorblanco@chromium.org's avatar
      2011-01-05 Stephen White <senorblanco@chromium.org> · 0b0d6778
      senorblanco@chromium.org authored 
              Unreviewed; test expectations fix.

        Update chromium GPU test_expectations.txt file to match the
        layout of the CPU results more closely.

        * platform/chromium-gpu/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b0d6778
    • mjs@apple.com's avatar
      2011-01-05 Maciej Stachowiak <mjs@apple.com> · 1758d155
      mjs@apple.com authored 
              Reviewed by Anders Carlsson.

        Remove entries from WebKit2 skipped list that no longer exist
        https://bugs.webkit.org/show_bug.cgi?id=51936

        * platform/mac-wk2/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1758d155
    • bweinstein@apple.com's avatar
      Land failing Windows results after r75031. Fixing the tests is being tracked by · 33bc4199
      bweinstein@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=51912.

* platform/win/accessibility/document-role-expected.txt:
* platform/win/accessibility/selection-and-focus-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33bc4199
    • inferno@chromium.org's avatar
      2011-01-05 Abhishek Arya <inferno@chromium.org> · 67a47c8a
      inferno@chromium.org authored 
              Reviewed by Dave Hyatt.

        Do not merge anonymous blocks when one of them is the one getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        Test: fast/block/merge-anonymous-block-remove-child-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to merge two anonymous blocks,
        one of which is getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        * fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
        * fast/block/merge-anonymous-block-remove-child-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67a47c8a
    • mitz@apple.com's avatar
      <rdar://problem/8799835> hyphenate-character: auto should fall back to... · 2e09ed2f
      mitz@apple.com authored 
      <rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915

Reviewed by Darin Adler.

WebCore: 

This changes the results of existing tests in fast/text.

* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added.
* rendering/style/RenderStyle.cpp:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.

LayoutTests: 

* platform/mac/fast/text/basic/014-expected.checksum:
* platform/mac/fast/text/basic/014-expected.png:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.checksum:
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e09ed2f
    • commit-queue@webkit.org's avatar
      2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn> · 0f5d54e5
      commit-queue@webkit.org authored 
              Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        Test case for recursive svg <use>.
        This test case passes if no crash occurs.

        * svg/custom/recursive-use-expected.txt: Added.
        * svg/custom/recursive-use.svg: Added.
2011-01-05  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        We should check recursive <use> at the begining of
        WebCore::SVGUseElement::buildInstanceTree instead
        of at the end of it because the target element's
        children may cause infinite recursive <use>.

        Test: svg/custom/recursive-use.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        * svg/SVGUseElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f5d54e5
    • antti@apple.com's avatar
      Not reviewed. · 009f9b28
      antti@apple.com authored 
      Update a pixel test result for https://bugs.webkit.org/show_bug.cgi?id=8852.

* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      009f9b28
    • tkent@chromium.org's avatar
      2011-01-04 Kent Tamura <tkent@chromium.org> · 10a51bcb
      tkent@chromium.org authored 
              Unreviewed, test expectation update.

        insecure-css-in-main-frame.html is flaky on Chromium-linux too.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10a51bcb
  5. 04 Jan, 2011 8 commits
    • tkent@chromium.org's avatar
      2011-01-04 Kent Tamura <tkent@chromium.org> · f45443f3
      tkent@chromium.org authored 
              Unreviewed, test expectation update

        - slow-loading-image-in-pattern.html had a wrong expectation for Chromium-win.
        - insecure-css-in-main-frame.html is flaky on Chromium-win?

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f45443f3
    • yael.aharon@nokia.com's avatar
      2011-01-04 Yael Aharon <yael.aharon@nokia.com> · b392a813
      yael.aharon@nokia.com authored 
              Reviewed by Darin Adler.

        CSS3 :nth-child selector and valid whitespace test fails
        https://bugs.webkit.org/show_bug.cgi?id=36279

        * fast/css/css3-nth-space-expected.txt: Added.
        * fast/css/css3-nth-space.html: Added.
2011-01-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        CSS3 :nth-child selector and valid whitespace test fails
        https://bugs.webkit.org/show_bug.cgi?id=36279

        Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

        Test: fast/css/css3-nth-space.html

        * css/tokenizer.flex:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b392a813
    • tonyg@chromium.org's avatar
      2011-01-04 Tony Gentilcore <tonyg@chromium.org> · c4418ef4
      tonyg@chromium.org authored 
              Unreviewed expectations update.

        Fix text metrics for "You should not see this at all" message
        https://bugs.webkit.org/show_bug.cgi?id=51909

        * http/tests/misc/acid3-expected.checksum:
        * http/tests/misc/acid3-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4418ef4
    • cfleizach@apple.com's avatar
      WK2: Support Accessibility · aa50410b
      cfleizach@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=51859

Reviewed by Sam Weinig.

Tools: 

Use rootObject() method to get top of accessibility tree.

* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):

WebCore: 

WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views. 

Test: platform/mac/accessibility/webkit-scrollarea.html

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityImageMapLink.cpp:
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityListBoxOption.cpp:
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp: Added.
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):
* accessibility/AccessibilityScrollView.h: Added.
(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):
* accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
* dom/Document.cpp:
(WebCore::Document::axObjectCache):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
* loader/FrameLoaderClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):
* platform/Scrollbar.h:
* platform/Widget.h:
(WebCore::Widget::axObjectCache):

WebKit/gtk: 

Use rootObject() method to get top of ax tree.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible):

WebKit/mac: 

Use rootObject() method to get top of AX tree.

* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::accessibilityRemoteObject):
* WebView/WebFrame.mm:
(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityFocusedUIElement]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _accessibilityParentForSubview:]):

WebKit/win: 

Use rootObject() method to get the top of the AX tree.

* AccessibleDocument.cpp:
(AccessibleDocument::AccessibleDocument):

WebKit2: 

Implement remote accessibility API to support cross process accessibility
on the Mac platform.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::accessibilityChildTokenReceived):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
(WebKit::WebPageProxy::sendAccessibilityPresenterToken):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::accessibilityPosition):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
(-[AccessibilityWebPageObject setWebPage:]):
(-[AccessibilityWebPageObject setRemoteParent:]):
(-[AccessibilityWebPageObject dealloc]):
(-[AccessibilityWebPageObject accessibilityIsIgnored]):
(-[AccessibilityWebPageObject accessibilityAttributeNames]):
(-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[AccessibilityWebPageObject accessibilityActionNames]):
(-[AccessibilityWebPageObject accessibilityChildren]):
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
(-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[AccessibilityWebPageObject accessibilityHitTest:]):
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::sendAccessibilityPresenterToken):
(WebKit::WebPage::accessibilityRemoteObject):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::presenterApplicationPid):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

LayoutTests: 

* platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
* platform/mac/accessibility/webkit-scrollarea.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa50410b
    • tkent@chromium.org's avatar
      2011-01-04 Kent Tamura <tkent@chromium.org> · 7b216a5f
      tkent@chromium.org authored 
              Unreviewed, test expectation update.

        Add home-end-expected.txt for Chromium-win again.  It's a
        platform-dependent text test.

        * platform/chromium-win/editing/selection/home-end-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b216a5f
    • tkent@chromium.org's avatar
      2011-01-04 Kent Tamura <tkent@chromium.org> · d8350171
      tkent@chromium.org authored 
              Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt: Fix a syntax error in the previous change

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8350171
    • tkent@chromium.org's avatar
      2011-01-04 Kent Tamura <tkent@chromium.org> · 1faffa33
      tkent@chromium.org authored 
              Unreviewed, test expectation update.

        * platform/chromium-win/editing/selection/home-end-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1faffa33
    • xji@chromium.org's avatar
      2011-01-04 Xiaomei Ji <xji@chromium.org> · 74e0327b
      xji@chromium.org authored 
              Reviewed by Dan Bernstein.

        Implement sel.modify('move', 'left'/'right', 'lineBoundary').
        https://bugs.webkit.org/show_bug.cgi?id=33435

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingLeft):
        * editing/visible_units.cpp:
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):
        (WebCore::leftBoundaryOfLine):
        (WebCore::rightBoundaryOfLine):
        * editing/visible_units.h:
2011-01-04  Xiaomei Ji  <xji@chromium.org>

        Implement sel.modify('move', 'left'/'right', 'lineBoundary').
        https://bugs.webkit.org/show_bug.cgi?id=33435

        * editing/selection/home-end-expected.txt:
        * editing/selection/home-end.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e0327b