1. 06 Jan, 2011 27 commits
    • jamesr@google.com's avatar
      2011-01-06 James Robinson <jamesr@chromium.org> · c0dca2a1
      jamesr@google.com authored
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Tests for window.webkitAnimationTime.
      
              * animations/animation-time-expected.txt: Added.
              * animations/animation-time.html: Added.
              * animations/script-tests/animation-time.js: Added.
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Chromium DRT support for webkitAnimationTime.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::paintInvalidatedRegion):
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Implements mozilla's animationTime property as described here:
              https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
              and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
              The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
              This property exposes a notion of a 'current' time to use for declarative animations and allows
              scripts to synchronize imperative animations with declarative ones if they choose to.  Once queried
              this time is saved and used for all declarative animation updates until the embedder paints/composites
              the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
              if the page is in a background tab).
      
              This patch also ensures that all declarative animations started in the same script execution block
              are synchronized even if some time elapses while script is running.
      
              Test: fast/animation/animation-time.html
      
              * WebCore.gypi:
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::webkitAnimationTime):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * page/Frame.cpp:
              (WebCore::Frame::currentAnimationTime):
              * page/Frame.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              (WebCore::Page::animationTime):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
              * page/animation/AnimationTimeController.cpp: Added.
              (WebCore::AnimationTimeController::AnimationTimeController):
              (WebCore::AnimationTimeController::~AnimationTimeController):
              (WebCore::AnimationTimeController::currentAnimationTime):
              (WebCore::AnimationTimeController::clearCurrentAnimationTime):
              (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
              * page/animation/AnimationTimeController.h: Added.
              (WebCore::AnimationTimeController::create):
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              WebKit API support for webkitAnimationTime.
      
              * public/WebWidget.h:
              * src/WebPopupMenuImpl.cpp:
              (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::clearCurrentAnimationTime):
              * src/WebViewImpl.h:
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Tells the page to clear the current animation time after producing a frame.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::drawRect):
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
              (WebKit::ChunkedUpdateDrawingArea::display):
              (WebKit::ChunkedUpdateDrawingArea::setSize):
              * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
              (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0dca2a1
    • inferno@chromium.org's avatar
      2011-01-06 Abhishek Arya <inferno@chromium.org> · c8367559
      inferno@chromium.org authored
              Reviewed by Simon Fraser.
      
              Null out the parent stylesheet pointer when a css rule is removed.
              https://bugs.webkit.org/show_bug.cgi?id=51993
      
              Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html
                     fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html
      
              * css/CSSRuleList.cpp:
              (WebCore::CSSRuleList::deleteRule):
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::deleteRule):
      2011-01-06  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Tests that we do not crash when accessing a deleted parent stylesheet
              from a removed css rule.
              https://bugs.webkit.org/show_bug.cgi?id=51993
      
              * fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash-expected.txt: Added.
              * fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html: Added.
              * fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash-expected.txt: Added.
              * fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8367559
    • enne@google.com's avatar
      2011-01-04 Adrienne Walker <enne@google.com> · a6ff32f7
      enne@google.com authored
              Reviewed by Kenneth Russell.
      
              Add test cases for storing NaN in typed arrays.
              https://bugs.webkit.org/show_bug.cgi?id=46990
      
              * fast/canvas/webgl/array-unit-tests-expected.txt:
              * fast/canvas/webgl/array-unit-tests.html:
      2011-01-04  Adrienne Walker  <enne@google.com>
      
              Reviewed by Kenneth Russell.
      
              NaN in a TypedArray should be converted to zero only for Float32Array.
              https://bugs.webkit.org/show_bug.cgi?id=46990
      
              Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html
      
              * bindings/js/JSArrayBufferViewHelper.h:
              (WebCore::convertArrayValue):
              (WebCore::constructArrayBufferView):
              * html/canvas/Float32Array.h:
              (WebCore::Float32Array::set):
              (WebCore::Float32Array::item):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6ff32f7
    • jparent@chromium.org's avatar
      2011-01-06 Julie Parent <jparent@chromium.org> · d6905af5
      jparent@chromium.org authored
              Reviewed by Tony Chang.
      
              Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
              https://bugs.webkit.org/show_bug.cgi?id=51217
      
              * TestResultServer/model/jsonresults.py:
              Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
              Adds missing documentation.
              * TestResultServer/model/jsonresults_unittest.py:
              Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
              Update test_merge to take a number of builds to truncate at.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6905af5
    • mrobinson@webkit.org's avatar
      2011-01-06 Martin Robinson <mrobinson@igalia.com> · a655a151
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Enable blob support by default
              https://bugs.webkit.org/show_bug.cgi?id=51994
      
              * configure.ac: Enable Blob support by default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a655a151
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · 2f8fbd0e
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] Add elliptical gradient support to GradientSkia
              https://bugs.webkit.org/show_bug.cgi?id=51841
      
              Marks fast/gradients/css3-radial-gradients3.html as expected to fail.
              Also marks
              canvas/philip/tests/2d.shadow.gradient.alpha.html
              canvas/philip/tests/2d.shadow.gradient.basic.html
              canvas/philip/tests/2d.shadow.gradient.transparent.2.html
              as passing on Chromium-mac as a result of r75139.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f8fbd0e
    • paroga@webkit.org's avatar
      2011-01-06 Patrick Gansterer <paroga@webkit.org> · 2e9dfdd4
      paroga@webkit.org authored
              Unreviewed Windows build fix for r75161.
      
              * platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e9dfdd4
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · 282464c3
      andreip@google.com authored
              Unreviewed, rolling out r75152.
      
              [Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
              https://bugs.webkit.org/show_bug.cgi?id=51988
      
              Rolling out since, on closer inspection, the expectations are wrong and the corresponding test really fails.
      
              * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
              * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Removed.
              * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
              * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      282464c3
    • paroga@webkit.org's avatar
      2011-01-06 Patrick Gansterer <paroga@webkit.org> · c2be439f
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r75139.
      
              Try to remove include after adding forward-declaration in r75145.
      
              * platform/graphics/Gradient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2be439f
    • reni@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=51811 · fa0c6686
      reni@webkit.org authored
      Merge m_height and m_width members of ImageData into the new m_size member.
      
      Patch by Renata Hodovan <reni@webkit.org> on 2011-01-06
      Reviewed by Andreas Kling.
      
      Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
      width and height argument, except ImageData. This patch refactors ImageData
      to follow the style of other Image types in WebKit.
      Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
      This patch also refactors the PassRefPtr usages of ImageData.
      
      It's just a refactoring, so we don't need any new tests.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneSerializer::write):
      (WebCore::CloneDeserializer::readTerminal):
      * bindings/v8/SerializedScriptValue.cpp:
      (WebCore::ZigZag::Reader::readImageData):
      * html/ImageData.cpp:
      (WebCore::ImageData::create):
      (WebCore::ImageData::ImageData):
      * html/ImageData.h:
      (WebCore::ImageData::size):
      (WebCore::ImageData::width):
      (WebCore::ImageData::height):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::createEmptyImageData):
      (WebCore::CanvasRenderingContext2D::createImageData):
      (WebCore::CanvasRenderingContext2D::getImageData):
      * html/canvas/CanvasRenderingContext2D.h:
      * platform/graphics/haiku/ImageBufferHaiku.cpp:
      (WebCore::getImageData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa0c6686
    • yael.aharon@nokia.com's avatar
      WebCore: document.querySelector(':nth-child(foo)') should throw a syntax error · 74e1d449
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51231
      
      Reviewed by Darin Adler.
      
      Also fixes 
      CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
      https://bugs.webkit.org/show_bug.cgi?id=21815
      
      Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
      as parameters to nth selector.
      
      Tests: fast/css/css3-nth-tokens-script.html
             fast/css/css3-nth-tokens-style.html
      
      * css/CSSGrammar.y:
      * css/CSSParser.cpp:
      (WebCore::isValidNthToken):
      * css/CSSParser.h:
      
      LayoutTests: document.querySelector(':nth-child(foo)') should throw a syntax error
      https://bugs.webkit.org/show_bug.cgi?id=51231
      CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
      https://bugs.webkit.org/show_bug.cgi?id=21815
      
      Reviewed by Darin Adler.
      
      * fast/css/css3-nth-tokens-script-expected.txt: Added.
      * fast/css/css3-nth-tokens-script.html: Added.
      * fast/css/css3-nth-tokens-style-expected.txt: Added.
      * fast/css/css3-nth-tokens-style.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e1d449
    • commit-queue@webkit.org's avatar
      2011-01-06 Jan Erik Hanssen <jhanssen@sencha.com> · 2bb13e35
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
              https://bugs.webkit.org/show_bug.cgi?id=51453
      
              Check if m_reply is NULL before accessing.
      
              * manual-tests/load-deferrer-resume-crash.html: Added.
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::setLoadMode):
              (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bb13e35
    • darin@apple.com's avatar
      Redo the half-done rename from the last check-in. · 4f8b99d5
      darin@apple.com authored
      Sorry for the broken build last night.
      
      * WebProcess/WebPage/WebBackForwardListProxy.cpp:
      (WebKit::WebBackForwardListProxy::removeItem): Renamed.
      * WebProcess/WebPage/WebBackForwardListProxy.h: Updated
      for new name.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didRemoveBackForwardItem): Updated to
      use the new name.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f8b99d5
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · ea22600c
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
              https://bugs.webkit.org/show_bug.cgi?id=51989
      
              Updating the test expectations for the chromium-gpu platform.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea22600c
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · 3294e841
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
              https://bugs.webkit.org/show_bug.cgi?id=51989
      
              Added suppressions for
              svg/batik/text/textEffect.svg
              svg/batik/text/textEffect3.svg
              svg/css/composite-shadow-text.svg
              svg/custom/js-late-gradient-and-object-creation.svg
              svg/custom/js-late-gradient-creation.svg
              svg/text/selection-background-color.xhtml
              svg/text/selection-styles.xhtml
              svg/text/text-gradient-positioning.svg
      
              These tests are all failing as a result of the same change: r75153.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3294e841
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · ccc33c5b
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
              https://bugs.webkit.org/show_bug.cgi?id=51989
      
              Updating Chromium expectations until we find a fix.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc33c5b
    • andreip@google.com's avatar
      2011-01-06 Andrei Popescu <andreip@google.com> · 7bfff60f
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
              https://bugs.webkit.org/show_bug.cgi?id=51988
      
              * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
              * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Added.
              * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
              * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bfff60f
    • abecsi@webkit.org's avatar
      2011-01-06 Andras Becsi <abecsi@webkit.org> · 164e3947
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.
      
              No new tests needed.
      
              * WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      164e3947
    • ossy@webkit.org's avatar
      Unreviewed. · 0f9c820d
      ossy@webkit.org authored
      [Qt] Web Timing related bugs
      https://bugs.webkit.org/show_bug.cgi?id=51245
      
      * platform/qt/Skipped: Add new tests.
       - http/tests/misc/webtiming-origins.html
       - http/tests/misc/webtiming-slow-load.php
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9c820d
    • abarth@webkit.org's avatar
      2011-01-06 Adam Barth <abarth@webkit.org> · 804f218d
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              The EWS should log outside of the working directory
              https://bugs.webkit.org/show_bug.cgi?id=51986
      
              This patch prepare us for using git clean -x -d -f in the EWS wrapper
              script, which will actually clean the working copy back to a pristine
              state instead of leaving untracked directories and ignored files.
      
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      804f218d
    • commit-queue@webkit.org's avatar
      2011-01-06 Helder Correia <helder@sencha.com> · 6b3f0472
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
              https://bugs.webkit.org/show_bug.cgi?id=51985
      
              r75139 introduced GraphicsContext::hasShadow(). This can now simplify
              and unify some code in the Qt and GTK ports.
      
              No new tests necessary for this refactoring.
      
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawConvexPolygon):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::fillRoundedRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b3f0472
    • mjs@apple.com's avatar
      Fix build for Darin's previous change w/ the obvious renaming. · 8ab585f9
      mjs@apple.com authored
      Rubber stamped by Dan Bernstein.
      
      * WebProcess/WebPage/WebBackForwardListProxy.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didRemoveBackForwardItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ab585f9
    • jam@chromium.org's avatar
      2010-12-29 John Abd-El-Malek <jam@chromium.org> · 58914a59
      jam@chromium.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
              https://bugs.webkit.org/show_bug.cgi?id=51710
      
              * WebKit.gyp:
              * public/WebAutoFillClient.h: Added.
              (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion):
              (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion):
              (WebKit::WebAutoFillClient::didClearAutoFillSelection):
              (WebKit::WebAutoFillClient::removeAutocompleteSugestion):
              (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion):
              (WebKit::WebAutoFillClient::textFieldDidBeginEditing):
              (WebKit::WebAutoFillClient::textFieldDidEndEditing):
              (WebKit::WebAutoFillClient::textFieldDidChange):
              (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown):
              (WebKit::WebAutoFillClient::~WebAutoFillClient):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58914a59
    • darin@apple.com's avatar
      Fix Chromium Mac build. · 0e18bf4e
      darin@apple.com authored
      * platform/graphics/Gradient.h: Forward-declare CGContextRef.
      This might even make it possible to remove the include of
      <CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
      do that at this time because I don't want to break the Windows
      build when fixing the Chromium build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e18bf4e
    • darin@apple.com's avatar
      2011-01-05 Darin Adler <darin@apple.com> · 30fcbfca
      darin@apple.com authored
              Reviewed by Geoff Garen.
      
              Back/Forward entries in WebKit2 leak
              https://bugs.webkit.org/show_bug.cgi?id=51983
      
              Besides fixing the leak, this also fixes a problem where
              all history items were sent over to the UI process, but
              we wanted to send only back/forward items.
      
              * UIProcess/WebBackForwardList.cpp:
              (WebKit::WebBackForwardList::pageClosed): Added.
              Tells the web process about all the back/forward
              items being removed.
              (WebKit::WebBackForwardList::addItem): Ditto.
              Also removed a redundant call to didChangeBackForwardList.
              (WebKit::WebBackForwardList::clear): Ditto.
      
              * UIProcess/WebBackForwardList.h: Added pageClosed.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::close): Added a call to pageClosed.
              (WebKit::WebPageProxy::backForwardRemovedItem): Added.
              Sends a message to the web page in the web process.
      
              * UIProcess/WebPageProxy.h: Added backForwardRemovedItem.
      
              * WebProcess/WebPage/WebBackForwardListProxy.cpp:
              (WebKit::updateBackForwardItem): Added an itemID argument,
              since callers will now be getting it and we don't want to
              get it twice. Removed the code to generate an ID. Also
              removed some local variables to make the code a little
              tighter and clearer.
              (WebKit::WK2NotifyHistoryItemChanged): Only call
              updateBackForwardItem for items that already have IDs.
              We don't want to send cross-process messages for every
              history item; just the ones that are top level back/forward
              items.
              (WebKit::WebBackForwardListProxy::removeItem):
              Added. For use when the UI process tells us to remove it.
              (WebKit::WebBackForwardListProxy::addItem): Added code to
              assign an ID and put this item into the maps. This is called
              exactly once on each back/forward item.
      
              * WebProcess/WebPage/WebBackForwardListProxy.h: Added
              removeItem.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::didRemoveBackForwardItem): Added.
      
              * WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.
      
              * WebProcess/WebPage/WebPage.messages.in: Added
              DidRemoveBackForwardItem message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30fcbfca
    • sfalken@apple.com's avatar
      Windows build fix. · 17eca208
      sfalken@apple.com authored
      Back out attempted change to built-product-archive.
      
      * BuildSlaveSupport/built-product-archive:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17eca208
    • sfalken@apple.com's avatar
      Windows build fix. · 24e443d3
      sfalken@apple.com authored
      Include configuration name when unpacking a build archive.
      
      Needed, since we split Windows build results into configuration-specific directories
      under WebKitOutputDir.
      
      * BuildSlaveSupport/built-product-archive:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24e443d3
  2. 05 Jan, 2011 13 commits
    • sfalken@apple.com's avatar
      Windows build fix. · 1c577514
      sfalken@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c577514
    • commit-queue@webkit.org's avatar
      2011-01-05 Xianzhu Wang <wangxianzhu@google.com> · c9e7da71
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
              https://bugs.webkit.org/show_bug.cgi?id=51736
      
              No new tests. This change has potential effect on @font-face CSS feature
              on ports using Skia. Tested on Chromium that this change won't break
              fast/css/font-face-remote.html. This change can make the test pass on
              other ports using Skia.
      
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::RemoteFontStream::read):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9e7da71
    • commit-queue@webkit.org's avatar
      2011-01-05 Helder Correia <helder@sencha.com> · 13b196e5
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
              https://bugs.webkit.org/show_bug.cgi?id=51869
      
              GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
              The shadow is being drawn, but getting clipped to the rect being filled.
              The solution is to draw the gradient into a CGLayer (when a shadow is
              required), then render the layer to the GraphicsContext.
      
              This patch also fixes:
              canvas/philip/tests/2d.shadow.gradient.alpha.html
              canvas/philip/tests/2d.shadow.gradient.basic.html
              canvas/philip/tests/2d.shadow.gradient.transparent.2.html
      
              New test to ensure that shadows are drawn when fillStyle is a gradient,
              possibly with some transparency and blur, and specifically using
              fillRect.
      
              * fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.
      2011-01-05  Helder Correia  <helder@sencha.com>
      
              Reviewed by Simon Fraser.
      
              Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
              https://bugs.webkit.org/show_bug.cgi?id=51869
      
              GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
              The shadow is being drawn, but getting clipped to the rect being filled.
              The solution is to draw the gradient into a CGLayer (when a shadow is
              required), then render the layer to the GraphicsContext.
      
              This patch also fixes:
              canvas/philip/tests/2d.shadow.gradient.alpha.html
              canvas/philip/tests/2d.shadow.gradient.basic.html
              canvas/philip/tests/2d.shadow.gradient.transparent.2.html
      
              Test: fast/canvas/canvas-fillRect-gradient-shadow.html
      
              * platform/graphics/Gradient.h:
              * platform/graphics/cg/GradientCG.cpp:
              (WebCore::Gradient::paint):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b196e5
    • sfalken@apple.com's avatar
      2011-01-05 Steve Falkenburg <sfalken@apple.com> · 3bc314c4
      sfalken@apple.com authored
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * win/tools/vsprops/common.vsprops: 
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * WebKit.vcproj/InterfacesCommon.vsprops:
              * WebKit.vcproj/InterfacesPostBuild.cmd:
              * WebKit.vcproj/InterfacesPreBuild.cmd:
              * WebKit.vcproj/WebKit.make:
              * WebKit.vcproj/WebKitGUID.vcproj:
              * WebKit.vcproj/WebKitGUIDCommon.vsprops:
              * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
              * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
              * WebKit.vcproj/WebKitLibCommon.vsprops:
              * WebKit.vcproj/WebKitLibPostBuild.cmd:
              * WebKit.vcproj/WebKitLibPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * WebCore.vcproj/QTMovieWinCommon.vsprops:
              * WebCore.vcproj/QTMovieWinPostBuild.cmd:
              * WebCore.vcproj/QTMovieWinPreBuild.cmd:
              * WebCore.vcproj/WebCore.make:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/WebCoreCommon.vsprops:
              * WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
              * WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
              * WebCore.vcproj/WebCoreMediaQT.vsprops:
              * WebCore.vcproj/WebCorePostBuild.cmd:
              * WebCore.vcproj/WebCorePreBuild.cmd:
              * WebCore.vcproj/copyForwardingHeaders.cmd:
              * WebCore.vcproj/copyInspectorFiles.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
              
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
              
              For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
              for proper operation of the instrumentation/optimization scripts.
      
              * JavaScriptCore.vcproj/JavaScriptCore.make:
              * JavaScriptCore.vcproj/JavaScriptCore.sln:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePGOOptimize.vsprops: Added.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
              * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
              * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
              * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
              * JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
              * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
              * JavaScriptCore.vcproj/jsc/jsc.vcproj:
              * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
              * JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
              * JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
              * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
              * JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
              * JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
              * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
              * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
              * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
              * DumpRenderTree/win/ImageDiffCommon.vsprops:
              * DumpRenderTree/win/ImageDiffPostBuild.cmd:
              * DumpRenderTree/win/ImageDiffPreBuild.cmd:
              * FindSafari/FindSafari.vcproj:
              * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
              * MiniBrowser/MiniBrowserPostBuild.cmd:
              * MiniBrowser/MiniBrowserPreBuild.cmd:
              * Scripts/webkitdirs.pm:
              * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
              * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
              * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
              * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
              * TestWebKitAPI/win/copy-resources.cmd:
              * WebKitAPITest/WebKitAPITestCommon.vsprops:
              * WebKitAPITest/WebKitAPITestPostBuild.cmd:
              * WebKitAPITest/WebKitAPITestPreBuild.cmd:
              * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
              * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
              * WebKitTestRunner/win/InjectedBundle.vcproj:
              * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
              * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
              * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
              * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
              * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
              * WinLauncher/WinLauncherCommon.vsprops:
              * WinLauncher/WinLauncherPostBuild.cmd:
              * WinLauncher/WinLauncherPreBuild.cmd:
      2011-01-05  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Darin Adler.
      
              Debug and Release builds on Windows clobber each other
              https://bugs.webkit.org/show_bug.cgi?id=49185
      
              Changes the structure of WebKitBuild build products directory so we
              completely separate each build configuration into independent directories.
              
              Although we previously had per-configuration directories for obj, this change adds
              per-configuration directories for bin, lib, obj, and include. Each configuration's
              build products are stored within a directory inside of WebKitBuild.
              
              Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
              defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
      
              * win/WebKit2.make:
              * win/WebKit2.vcproj:
              * win/WebKit2Common.vsprops:
              * win/WebKit2Generated.make:
              * win/WebKit2GeneratedCommon.vsprops:
              * win/WebKit2WebProcessPostBuild.cmd:
              * win/WebKit2WebProcessPreBuild.cmd:
              * win/WebKitPostBuild.cmd:
              * win/WebKitPreBuild.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc314c4
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · 1f3fb4c5
      simon.fraser@apple.com authored
              Reviewed by Ariya Hidayat.
      
              Directly composited SVG images fail to render
              https://bugs.webkit.org/show_bug.cgi?id=51975
      
              There was already code, added in r67900, to detect whether an image
              may be directly composited, by checking to see if it's a bitmap image.
      
              However, CachedImage::image() returns the nullImage() if m_image is null,
              which is a BitmapImage, confusing this test.
      
              Test: compositing/images/direct-svg-image.html
      
              * loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
              exactly the same method.
              (WebCore::CachedImage::image): Use Image::nullImage().
              * loader/cache/CachedImage.h:
              (WebCore::CachedImage::hasImage): New method to ask whether the m_image is
              non-null.
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
              so that we don't test the nullImage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f3fb4c5
    • simon.fraser@apple.com's avatar
      2011-01-05 Simon Fraser <simon.fraser@apple.com> · b81b821c
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              Fix percentage values in radius of radial gradients
              https://bugs.webkit.org/show_bug.cgi?id=51979
      
              Handle percentage values for the ending size of radial gradients.
      
              Test: fast/gradients/css3-radial-gradients3.html
      
              * css/CSSGradientValue.cpp:
              (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
              non-null if percentage values are allowed, and compute percentage values when we see them.
              (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
              percentages are OK when resolving end radii.
              * css/CSSGradientValue.h: New parameter for resolveRadius.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b81b821c
    • ap@apple.com's avatar
      2011-01-05 Alexey Proskuryakov <ap@apple.com> · b9997acd
      ap@apple.com authored
              Reviewed by Anders Carlsson.
      
              https://bugs.webkit.org/show_bug.cgi?id=51973
              Make main frame PDF printing work
      
              * UIProcess/API/mac/PDFViewController.h:
              * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation):
              Ask PDFDocument to create an NSPrintOperation.
      
              * UIProcess/API/mac/WKView.h:
              * UIProcess/API/mac/WKView.mm:
              (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either
              from scratch or from a PDF view.
              (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers
              and footers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9997acd
    • commit-queue@webkit.org's avatar
      2011-01-05 Jan Erik Hanssen <jhanssen@sencha.com> · ca748a37
      commit-queue@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] TestNetscapePlugin doesn't link on OS X
              https://bugs.webkit.org/show_bug.cgi?id=51948
      
              Only add a dependency on libX11 on X11 systems
      
              * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca748a37
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · d1b4d8a2
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              change the way we do comment highlighting in the code review tool
              https://bugs.webkit.org/show_bug.cgi?id=51971
      
              Store a space-separated list of base line IDs on each line that has
              comments associated with that line. This allows for overlapping comments,
              but more importantly, makes adding side-by-side diff support easier.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b4d8a2
    • commit-queue@webkit.org's avatar
      2011-01-05 Jeff Miller <jeffm@apple.com> · 6601cf39
      commit-queue@webkit.org authored
              Reviewed by Adam Roben.
      
              check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
              https://bugs.webkit.org/show_bug.cgi?id=51970
      
              * Scripts/webkitpy/style/checker.py:
              Add -readability/naming for WebKit2 C API directories.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6601cf39
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · 10618cf8
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              minor code cleanup for code review tool
              https://bugs.webkit.org/show_bug.cgi?id=51962
      
              Consolidates some queries to using shared functions.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10618cf8
    • ojan@chromium.org's avatar
      2011-01-05 Ojan Vafai <ojan@chromium.org> · 5f240620
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              assorted cleanups to prepare for side-by-side diffing
              https://bugs.webkit.org/show_bug.cgi?id=51961
      
              Mostly, use selector queries instead of assuming comments are next siblings.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f240620
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · 92bc9b02
      simonjam@chromium.org authored
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately.
              (checkTimingWhileDeferred): Ditto.
              (checkWebTimingOnDOMContentLoaded): Ditto.
              (checkWebTimingWhileAsync): Ditto.
              (checkWebTimingOnLoad): Ditto.
              (checkWebTimingAfterLoad): Ditto.
              * fast/dom/webtiming-expected.txt:
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
              * http/tests/misc/resources/webtiming-no-origin.html: Added.
              * http/tests/misc/webtiming-origins-expected.txt: Added.
              * http/tests/misc/webtiming-origins.html: Added.
              * platform/gtk/Skipped: Skip new web timing test.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      2011-01-05  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              Tests: http/tests/misc/webtiming-cross-origin-redirect.php
                     http/tests/misc/webtiming-origins.html
      
              * loader/DocumentLoadTiming.h:
              (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::~FrameLoader):
              (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
              (WebCore::FrameLoader::completed):
              (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
              (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
              * page/PerformanceNavigation.cpp:
              (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::redirectStart): Ditto.
              (WebCore::PerformanceTiming::redirectEnd): Ditto.
              (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
              (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bc9b02