1. 05 Apr, 2013 1 commit
  2. 03 Apr, 2013 2 commits
    • cfleizach@apple.com's avatar
      clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList() · 28f89a88
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113828
      
      Reviewed by Tim Horton.
      
      static_cast changed to toAccessibilityList().
      
      * accessibility/AccessibilityList.h:
      (WebCore::toAccessibilityList):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28f89a88
    • commit-queue@webkit.org's avatar
      AXRoleDescripton for DL is "list"; should be "description list" · 93ff7379
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111665
      
      Patch by James Craig <james@cookiecrook.com> on 2013-04-02
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Defining the role and description strings, and accessors for DL.
      This previously relied on getting the role and description from the platform API.
      
      Updated existing test coverage.
      
      * English.lproj/Localizable.strings:
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      * platform/LocalizedStrings.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      * platform/LocalizedStrings.h:
      (WebCore):
      * platform/blackberry/LocalizedStringsBlackBerry.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      * platform/chromium/LocalizedStringsChromium.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::AXDescriptionListText):
      (WebCore):
      
      Source/WebKit/chromium:
      
      Defining the role and description strings.
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Tools:
      
      Defining the role and description strings.
      
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      
      LayoutTests:
      
      Updating expectation strings for DL role description.
      
      * platform/mac/accessibility/lists-expected.txt:
      * platform/mac/accessibility/role-subrole-roledescription-expected.txt:
      * platform/mac/accessibility/role-subrole-roledescription.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93ff7379
  3. 02 Apr, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: Need to get line thickness from fraction on web · 042e8bc3
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113720
      
      Reviewed by David Kilzer.
      
      Expose the line thickness property for fractions, which is needed to
      help determine the type of equation.
      
      Test: platform/mac/accessibility/mathml-line-fraction.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::mathLineThickness):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::mathLineThickness):
      (WebCore):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      042e8bc3
  4. 29 Mar, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue · 871bfe42
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112276
      
      Patch by Greg Hughes <ghughes@apple.com> on 2013-03-29
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Added support for accessibility search predicates to accept multiple search keys. The search will return the first item that matches any one of the provided search keys.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
      (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
      (WebCore):
      * accessibility/AccessibilityObject.h:
      (AccessibilitySearchCriteria):
      (WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
      (AccessibilityObject):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      
      Tools:
      
      Added support to test accessibility search predicates with multiple keys.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (uiElementForSearchPredicateCallback):
      * DumpRenderTree/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::uiElementForSearchPredicate):
      * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
      (AccessibilityUIElement::uiElementForSearchPredicate):
      * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
      (AccessibilityUIElement::uiElementForSearchPredicate):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::uiElementForSearchPredicate):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::uiElementForSearchPredicate):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
      (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
      
      LayoutTests:
      
      Updated the search predicate test to test passing multiple search keys (link OR heading).
      
      * platform/mac/accessibility/search-predicate-expected.txt:
      * platform/mac/accessibility/search-predicate.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      871bfe42
  5. 27 Mar, 2013 1 commit
  6. 26 Mar, 2013 1 commit
  7. 24 Mar, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: Crash in WebCore::AccessibilitySpinButton::incrementButton() · 9a52dddd
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111582
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      There are two ways to create a spin button: from a textfield counter or from ARIA.
      If an ARIA spin button is created, it was returning true for isSpinButton, so we were 
      casting to the other kind of spin button, leading to a crash.
      
      We need to be more specific about our class types.
      
      Test: platform/mac/accessibility/aria-spinbutton-crash.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isNativeSpinButton):
      * accessibility/AccessibilitySpinButton.h:
      (WebCore::AccessibilitySpinButton::isNativeSpinButton):
      (WebCore::toAccessibilitySpinButton):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
      * platform/mac/accessibility/aria-spinbutton-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a52dddd
  8. 07 Mar, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: Can't activate links with VoiceOver in Safari · 50d4cd3f
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111755
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      VoiceOver is relying on the press action being the first action in the list. We changed
      that order inadvertently recently, which confuses VoiceOver.
      
      Test: platform/mac/accessibility/press-action-is-first.html
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityActionNames]):
      
      Tools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (supportedActionsCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::supportedActions):
      
      LayoutTests: 
      
      * platform/mac/accessibility/press-action-is-first-expected.txt: Added.
      * platform/mac/accessibility/press-action-is-first.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50d4cd3f
  9. 06 Mar, 2013 1 commit
    • tkent@chromium.org's avatar
      Rename WebCore/editing/visible_units.* to VisibleUnits.* · 8c35c12b
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111426
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      No new tests. Just a refactoring.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityObject.cpp:
      * accessibility/AccessibilityRenderObject.cpp:
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      * dom/Position.cpp:
      * dom/Range.cpp:
      * editing/AlternativeTextController.cpp:
      * editing/ApplyBlockElementCommand.cpp:
      * editing/ApplyStyleCommand.cpp:
      * editing/CompositeEditCommand.cpp:
      * editing/DeleteSelectionCommand.cpp:
      * editing/EditingAllInOne.cpp:
      * editing/EditingStyle.cpp:
      * editing/Editor.cpp:
      * editing/FormatBlockCommand.cpp:
      * editing/FrameSelection.cpp:
      * editing/IndentOutdentCommand.cpp:
      * editing/InsertLineBreakCommand.cpp:
      * editing/InsertListCommand.cpp:
      * editing/InsertParagraphSeparatorCommand.cpp:
      * editing/InsertTextCommand.cpp:
      * editing/ReplaceSelectionCommand.cpp:
      * editing/SurroundingText.cpp:
      * editing/TextCheckingHelper.cpp:
      * editing/TextIterator.cpp:
      * editing/TypingCommand.cpp:
      * editing/VisiblePosition.cpp:
      * editing/VisibleSelection.cpp:
      * editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
      * editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
      * editing/htmlediting.cpp:
      * editing/markup.cpp:
      * editing/visible_units.cpp: Removed.
      * editing/visible_units.h: Removed.
      * page/Frame.cpp:
      * page/mac/FrameMac.mm:
      * platform/win/EditorWin.cpp:
      
      Source/WebKit/mac: 
      
      * WebView/WebFrame.mm:
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/mac/WebPageMac.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c35c12b
  10. 05 Mar, 2013 2 commits
    • cfleizach@apple.com's avatar
      AX: Support aria-posinset/setsize · 3e26e43d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109725
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      Expose aria-setsize and aria-posinset through accessibility.
      Right now only the Mac platform exposes them.
      
      Test: platform/mac/accessibility/aria-setsize-posinset.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::supportsARIASetSize):
      (WebCore):
      (WebCore::AccessibilityObject::supportsARIAPosInset):
      (WebCore::AccessibilityObject::ariaSetSize):
      (WebCore::AccessibilityObject::ariaPosInset):
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      * html/HTMLAttributeNames.in:
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-setsize-posinset-expected.txt: Added.
      * platform/mac/accessibility/aria-setsize-posinset.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e26e43d
    • cfleizach@apple.com's avatar
      AX: cellForColumnAndRow fails for tables with hidden table cells · 55378e41
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110050
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      If a table had hidden cells, then accessibility code was being confused in a few ways.
      1) The cellForColumnAndRow method would return the wrong information since that was
         using the RenderTableSection to retrieve a cell, which did not have the same data as the AXTable
      2) The way we were adding children made it impossible to determine column and row range because we 
         would skip rows that had hidden children
      3) AccessibilityARIAGrid and AccessibilityTable were using different methods for cellForColumnAndRow
      
      The fix does a few things to make things right:
      1) Always add an accessibility row, even if there are no visible cells in that row.
      2) Have one method for AXTable and AXARIAGrid for cellForColumnAndRow.
      3) Change cellForColumnAndRow to query the accessibility children rather than the RenderTableSection in determining the row, col info.
      4) cellForColumnAndRow should use unsigned values instead of int values.
      
      Test: accessibility/table-with-hidden-head-section.html
      
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore):
      * accessibility/AccessibilityARIAGrid.h:
      (AccessibilityARIAGrid):
      * accessibility/AccessibilityARIAGridCell.cpp:
      (WebCore::AccessibilityARIAGridCell::rowIndexRange):
      (WebCore::AccessibilityARIAGridCell::columnIndexRange):
      * accessibility/AccessibilityARIAGridCell.h:
      (AccessibilityARIAGridCell):
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::addChildren):
      (WebCore::AccessibilityTable::cellForColumnAndRow):
      * accessibility/AccessibilityTable.h:
      (WebCore):
      (AccessibilityTable):
      * accessibility/AccessibilityTableCell.cpp:
      (WebCore::AccessibilityTableCell::rowIndexRange):
      (WebCore::AccessibilityTableCell::columnIndexRange):
      * accessibility/AccessibilityTableCell.h:
      (AccessibilityTableCell):
      * accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
      (webkitAccessibleTableGetColumnAtIndex):
      (webkitAccessibleTableGetRowAtIndex):
      (webkitAccessibleTableGetColumnExtentAt):
      (webkitAccessibleTableGetRowExtentAt):
      (webkitAccessibleTableGetColumnHeader):
      (webkitAccessibleTableGetRowHeader):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      * rendering/RenderTableSection.h:
      (RenderTableSection):
      (WebCore::RenderTableSection::rowRendererAt):
      
      Source/WebKit/chromium: 
      
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::cellColumnIndex):
      (WebKit::WebAccessibilityObject::cellColumnSpan):
      (WebKit::WebAccessibilityObject::cellRowIndex):
      (WebKit::WebAccessibilityObject::cellRowSpan):
      
      LayoutTests: 
      
      * accessibility/table-with-hidden-head-section-expected.txt: Added.
      * accessibility/table-with-hidden-head-section.html: Added.
      * platform/chromium/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55378e41
  11. 27 Feb, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: Mac platform should support ability to scroll an element into visible · c6756ec1
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109860
      
      Reviewed by Beth Dakin.
      
      Source/WebCore: 
      
      Support the scrollToMakeVisible() action for MacOS accessibility clients.
      
      Tests: platform/mac/accessibility/scroll-to-visible-action.html
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityActionNames]):
      (-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
      
      Tools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (scrollToMakeVisibleCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::scrollToMakeVisible):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
      (WTR::AccessibilityUIElement::scrollToMakeVisible):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
      (AccessibilityUIElement):
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::AccessibilityUIElement::scrollToMakeVisible):
      (WTR):
      
      LayoutTests: 
      
      * platform/mac/accessibility/scroll-to-visible-action.html: Added.
      * platform/mac/accessibility/scroll-to-visible-action-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6756ec1
  12. 17 Feb, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase · 100fa9e2
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110061
      
      Reviewed by David Kilzer.
      
      Rename the base accessibility wrapper class so that the iOS class can share the same name.
      
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/WebAccessibilityObjectWrapper.h: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h.
      * accessibility/mac/WebAccessibilityObjectWrapper.mm: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm.
      * accessibility/mac/WebAccessibilityObjectWrapperBase.h: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.h.
      * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      100fa9e2
  13. 15 Feb, 2013 3 commits
    • cfleizach@apple.com's avatar
      AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS · 67fe1a26
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109849
      
      Reviewed by David Kilzer.
      
      Split up the WebAccessibilityObjectWrapper so that iOS can share more
      code with MacOS. I imagine over time, more code will move into this base class,
      but for now this will be a good start.
      
      A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
      of that. iOS will be able to do the same.
      
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/WebAccessibilityObjectWrapper.h:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper detach]):
      (-[WebAccessibilityObjectWrapper attachmentView]):
      (-[WebAccessibilityObjectWrapper accessibilityObject]):
      (-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
      (-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
      (-[WebAccessibilityObjectWrapper accessibilityTitle]):
      (-[WebAccessibilityObjectWrapper accessibilityDescription]):
      (-[WebAccessibilityObjectWrapper accessibilityHelpText]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Added.
      (std):
      (-[WebAccessibilityObjectWrapperMac detach]):
      (-[WebAccessibilityObjectWrapperMac attachmentView]):
      (CFAutoreleaseHelper):
      (AXObjectIsTextMarker):
      (AXObjectIsTextMarkerRange):
      (AXTextMarkerRange):
      (AXTextMarkerRangeStart):
      (AXTextMarkerRangeEnd):
      (SearchKeyEntry):
      (createAccessibilitySearchKeyMap):
      (accessibilitySearchKeyForString):
      (textMarkerForVisiblePosition):
      (-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
      (visiblePositionForTextMarker):
      (-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
      (visiblePositionForStartOfTextMarkerRange):
      (visiblePositionForEndOfTextMarkerRange):
      (textMarkerRangeFromMarkers):
      (AXAttributedStringRangeIsValid):
      (AXAttributeStringSetFont):
      (CreateCGColorIfDifferent):
      (AXAttributeStringSetColor):
      (AXAttributeStringSetNumber):
      (AXAttributeStringSetStyle):
      (AXAttributeStringSetBlockquoteLevel):
      (AXAttributeStringSetSpelling):
      (AXAttributeStringSetHeadingLevel):
      (AXAttributeStringSetElement):
      (AXAttributedStringAppendText):
      (nsStringForReplacedNode):
      (-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
      (textMarkerRangeFromVisiblePositions):
      (-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
      (-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
      (-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
      (-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
      (convertToVector):
      (convertToNSArray):
      (-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
      (-[WebAccessibilityObjectWrapperMac position]):
      (createAccessibilityRoleMap):
      (roleValueToNSString):
      (-[WebAccessibilityObjectWrapperMac role]):
      (-[WebAccessibilityObjectWrapperMac subrole]):
      (-[WebAccessibilityObjectWrapperMac roleDescription]):
      (-[WebAccessibilityObjectWrapperMac scrollViewParent]):
      (-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
      (-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
      (-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
      (-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
      (-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
      (-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
      (-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
      (rendererForView):
      (-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
      (-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
      (-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
      (-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
      (-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
      (-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
      (-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
      (-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
      ([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67fe1a26
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r143066. · b9ee7bc5
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/143066
      https://bugs.webkit.org/show_bug.cgi?id=109986
      
      Broke the Apple Lion build (among others). (Requested by
      ddkilzer on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
      
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/WebAccessibilityObjectWrapper.h:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
      (-[WebAccessibilityObjectWrapper detach]):
      (-[WebAccessibilityObjectWrapper accessibilityObject]):
      (-[WebAccessibilityObjectWrapper attachmentView]):
      (CFAutoreleaseHelper):
      (AXObjectIsTextMarker):
      (AXObjectIsTextMarkerRange):
      (AXTextMarkerRange):
      (AXTextMarkerRangeStart):
      (AXTextMarkerRangeEnd):
      (SearchKeyEntry):
      (createAccessibilitySearchKeyMap):
      (accessibilitySearchKeyForString):
      (textMarkerForVisiblePosition):
      (-[WebAccessibilityObjectWrapper textMarkerForVisiblePosition:]):
      (visiblePositionForTextMarker):
      (-[WebAccessibilityObjectWrapper visiblePositionForTextMarker:]):
      (visiblePositionForStartOfTextMarkerRange):
      (visiblePositionForEndOfTextMarkerRange):
      (textMarkerRangeFromMarkers):
      (AXAttributedStringRangeIsValid):
      (AXAttributeStringSetFont):
      (CreateCGColorIfDifferent):
      (AXAttributeStringSetColor):
      (AXAttributeStringSetNumber):
      (AXAttributeStringSetStyle):
      (AXAttributeStringSetBlockquoteLevel):
      (AXAttributeStringSetSpelling):
      (AXAttributeStringSetHeadingLevel):
      (AXAttributeStringSetElement):
      (AXAttributedStringAppendText):
      (nsStringForReplacedNode):
      (-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
      (textMarkerRangeFromVisiblePositions):
      (-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
      (-[WebAccessibilityObjectWrapper accessibilityActionNames]):
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
      (-[WebAccessibilityObjectWrapper renderWidgetChildren]):
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      (convertToVector):
      (convertToNSArray):
      (-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
      (-[WebAccessibilityObjectWrapper position]):
      (createAccessibilityRoleMap):
      (roleValueToNSString):
      (-[WebAccessibilityObjectWrapper role]):
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      (-[WebAccessibilityObjectWrapper scrollViewParent]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
      (-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
      (-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
      (-[WebAccessibilityObjectWrapper accessibilityIsIgnored]):
      (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformIncrementAction]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformDecrementAction]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
      (-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
      (-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
      (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      (rendererForView):
      (-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
      (-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
      (-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]):
      (-[WebAccessibilityObjectWrapper _convertToNSRange:]):
      (-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
      (-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
      (-[WebAccessibilityObjectWrapper doAXRTFForRange:]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      (-[WebAccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
      (-[WebAccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
      (-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
      (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
      (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.m: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9ee7bc5
    • cfleizach@apple.com's avatar
      AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS · eb3e5837
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109849
      
      Reviewed by David Kilzer.
      
      Split up the WebAccessibilityObjectWrapper so that iOS can share more 
      code with MacOS. I imagine over time, more code will move into this base class,
      but for now this will be a good start.
      
      A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
      of that. iOS will be able to do the same.
      
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/WebAccessibilityObjectWrapper.h:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper detach]):
      (-[WebAccessibilityObjectWrapper attachmentView]):
      (-[WebAccessibilityObjectWrapper accessibilityObject]):
      (-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
      (-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
      (-[WebAccessibilityObjectWrapper accessibilityTitle]):
      (-[WebAccessibilityObjectWrapper accessibilityDescription]):
      (-[WebAccessibilityObjectWrapper accessibilityHelpText]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.m: Added.
      (std):
      (-[WebAccessibilityObjectWrapperMac detach]):
      (-[WebAccessibilityObjectWrapperMac attachmentView]):
      (CFAutoreleaseHelper):
      (AXObjectIsTextMarker):
      (AXObjectIsTextMarkerRange):
      (AXTextMarkerRange):
      (AXTextMarkerRangeStart):
      (AXTextMarkerRangeEnd):
      (SearchKeyEntry):
      (createAccessibilitySearchKeyMap):
      (accessibilitySearchKeyForString):
      (textMarkerForVisiblePosition):
      (-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
      (visiblePositionForTextMarker):
      (-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
      (visiblePositionForStartOfTextMarkerRange):
      (visiblePositionForEndOfTextMarkerRange):
      (textMarkerRangeFromMarkers):
      (AXAttributedStringRangeIsValid):
      (AXAttributeStringSetFont):
      (CreateCGColorIfDifferent):
      (AXAttributeStringSetColor):
      (AXAttributeStringSetNumber):
      (AXAttributeStringSetStyle):
      (AXAttributeStringSetBlockquoteLevel):
      (AXAttributeStringSetSpelling):
      (AXAttributeStringSetHeadingLevel):
      (AXAttributeStringSetElement):
      (AXAttributedStringAppendText):
      (nsStringForReplacedNode):
      (-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
      (textMarkerRangeFromVisiblePositions):
      (-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
      (-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
      (-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
      (-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
      (convertToVector):
      (convertToNSArray):
      (-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
      (-[WebAccessibilityObjectWrapperMac position]):
      (createAccessibilityRoleMap):
      (roleValueToNSString):
      (-[WebAccessibilityObjectWrapperMac role]):
      (-[WebAccessibilityObjectWrapperMac subrole]):
      (-[WebAccessibilityObjectWrapperMac roleDescription]):
      (-[WebAccessibilityObjectWrapperMac scrollViewParent]):
      (-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
      (-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
      (-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
      (-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
      (-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
      (-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
      (-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
      (-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
      (rendererForView):
      (-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
      (-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
      (-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
      (-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
      (-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
      (-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
      (-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
      (-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
      (-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
      ([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
      (-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb3e5837
  14. 14 Feb, 2013 1 commit
    • cfleizach@apple.com's avatar
      Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard) · a59d8e4e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90250
      
      Reviewed by Eric Seidel.
      
      The Leopard era checks for accessibility lists and accessibility tables can be removed now.
      
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore):
      * accessibility/AccessibilityARIAGrid.h:
      (AccessibilityARIAGrid):
      (WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):
      * accessibility/AccessibilityList.cpp:
      (WebCore::AccessibilityList::computeAccessibilityIsIgnored):
      * accessibility/AccessibilityList.h:
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::AccessibilityTable):
      (WebCore::AccessibilityTable::init):
      * accessibility/AccessibilityTable.h:
      (AccessibilityTable):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a59d8e4e
  15. 01 Feb, 2013 1 commit
  16. 28 Jan, 2013 1 commit
    • commit-queue@webkit.org's avatar
      HTML5 promotes DL from specific 'definition list' to superset 'description... · fe847770
      commit-queue@webkit.org authored
      HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
      https://bugs.webkit.org/show_bug.cgi?id=107650
      
      Source/WebCore:
      
      Patch by James Craig <james@cookiecrook.com> on 2013-01-28
      Reviewed by Chris Fleizach.
      
      Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
      
      Test: platform/mac/accessibility/definition-list-term.html:
      Test: accessibility/lists.html
      
      * English.lproj/Localizable.strings:
      * accessibility/AccessibilityList.cpp:
      (WebCore::AccessibilityList::isDescriptionList):
      * accessibility/AccessibilityList.h:
      (AccessibilityList):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      * platform/LocalizedStrings.cpp:
      (WebCore::AXDefinitionText):
      (WebCore::AXDescriptionListTermText):
      (WebCore):
      (WebCore::AXDescriptionListDetailText):
      * platform/LocalizedStrings.h:
      (WebCore):
      * platform/blackberry/LocalizedStringsBlackBerry.cpp:
      (WebCore::AXDefinitionText):
      (WebCore::AXDescriptionListDetailText):
      (WebCore):
      (WebCore::AXDescriptionListTermText):
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::AXDefinitionText):
      (WebCore):
      (WebCore::AXDescriptionListTermText):
      (WebCore::AXDescriptionListDetailText):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::AXDefinitionText):
      (WebCore):
      (WebCore::AXDescriptionListTermText):
      (WebCore::AXDescriptionListDetailText):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::AXDefinitionText):
      (WebCore::AXDescriptionListTermText):
      (WebCore):
      (WebCore::AXDescriptionListDetailText):
      
      Source/WebKit/chromium:
      
      Patch by James Craig <james@cookiecrook.com> on 2013-01-28
      Reviewed by Chris Fleizach.
      
      Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      * src/LocalizedStrings.cpp:
      (WebCore::AXDefinitionText):
      (WebCore):
      (WebCore::AXDescriptionListTermText):
      (WebCore::AXDescriptionListDetailText):
      
      Tools:
      
      Patch by James Craig <james@cookiecrook.com> on 2013-01-28
      Reviewed by Chris Fleizach.
      
      Updating accessibility strings and accessors for DL/DT/DD.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
      (createDescriptionList):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      
      LayoutTests:
      
      Patch by James Craig <james@cookiecrook.com> on 2013-01-28
      Reviewed by Chris Fleizach.
      
      Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
      Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt
      
      * accessibility/lists.html:
      * platform/gtk/accessibility/lists-expected.txt: Removed.
      * platform/mac/accessibility/definition-list-term-expected.txt:
      * platform/mac/accessibility/definition-list-term.html:
      * platform/mac/accessibility/lists-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe847770
  17. 14 Jan, 2013 1 commit
    • dmazzoni@google.com's avatar
      AX: Need to implement ColorWellRole · 505a43b7
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106756
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Maps input type=color to the accessible role ColorWellRole.
      Adds a new accessor to AccessibilityObject to get the color
      value in a cross-platform way that doesn't require parsing.
      
      Test: accessibility/color-well.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
      (WebCore::AccessibilityNodeObject::colorValue):
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isColorWell):
      (AccessibilityObject):
      (WebCore::AccessibilityObject::colorValue):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::stringValue):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      * html/HTMLInputElement.cpp:
      (WebCore):
      (WebCore::HTMLInputElement::isColorControl):
      * html/HTMLInputElement.h:
      (HTMLInputElement):
      
      Source/WebKit/chromium:
      
      Adds an accessibility interface to access the value of a
      color control.
      
      * public/WebAccessibilityObject.h:
      (WebAccessibilityObject):
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::colorValue):
      (WebKit):
      
      Tools:
      
      Returns a string representation of the value of a color
      when the role is Color Well, to make it easy to write layout
      tests for color controls.
      
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      
      LayoutTests:
      
      Adds a test of accessibility attributes for input type=color.
      
      * accessibility/color-well.html: Added.
      * platform/chromium/accessibility/color-well-expected.txt: Added.
      * platform/mac/accessibility/color-well-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      505a43b7
  18. 11 Jan, 2013 1 commit
    • dmazzoni@google.com's avatar
      AX: Computed hierarchical level is not consistent with aria-level · 9ce023ed
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106638
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Make hierarchicalLevel computation 1-based to match the aria-level spec.
      
      Extends an existing test: platform/mac/accessibility/aria-tree.html.
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::hierarchicalLevel):
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests:
      
      Extend aria-tree.html to check the hierarchicalLevel automatically
      computed when aria-level is not provided. Make sure they're consistent.
      Now, the mac disclosureLevel will be one less than the web aria-level.
      
      * platform/mac/accessibility/aria-tree-expected.txt:
      * platform/mac/accessibility/aria-tree.html:
      * platform/mac/accessibility/aria-treegrid-expected.txt:
      * platform/mac/accessibility/aria-treegrid.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ce023ed
  19. 08 Jan, 2013 1 commit
  20. 07 Jan, 2013 1 commit
  21. 17 Dec, 2012 1 commit
    • cfleizach@apple.com's avatar
      Seamless iframe should not announce a new browsing context · c516190d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86317
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Introduce a new role for seamless frames so that the platforms can decide what to do
      with this kind of object. For the mac, it's exposed as a group.
      
      Test: platform/mac/accessibility/seamless-iframe.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isWebArea):
      (WebCore::AccessibilityObject::isSeamlessWebArea):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::parentObjectIfExists):
      (WebCore::AccessibilityRenderObject::parentObject):
      (WebCore::AccessibilityRenderObject::boundingBoxRect):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      
      Source/WebKit/chromium: 
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      LayoutTests: 
      
      * platform/mac/accessibility/seamless-iframe-expected.txt: Added.
      * platform/mac/accessibility/seamless-iframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c516190d
  22. 12 Dec, 2012 1 commit
    • cfleizach@apple.com's avatar
      AX: aria-busy should be exposed everywhere, not just on live regions · 70645b4d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104814
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      The aria-busy attribute should be exposed on all elements.
      This isn't entirely clear in the ARIA spec, but that will be fixed with
      ARIA1.1 (ISSUE-538).
      
      Existing tests that dump attributes cover this new behavior.
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      
      LayoutTests:
      
      Update tests that dump all attributes to include aria busy attribute.
      
      * accessibility/transformed-element-expected.txt:
      * platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
      * platform/mac/accessibility/bounds-for-range-expected.txt:
      * platform/mac/accessibility/document-attributes-expected.txt:
      * platform/mac/accessibility/document-links-expected.txt:
      * platform/mac/accessibility/image-link-expected.txt:
      * platform/mac/accessibility/image-map2-expected.txt:
      * platform/mac/accessibility/internal-link-anchors-expected.txt:
      * platform/mac/accessibility/internal-link-anchors2-expected.txt:
      * platform/mac/accessibility/lists-expected.txt:
      * platform/mac/accessibility/plugin-expected.txt:
      * platform/mac/accessibility/radio-button-group-members-expected.txt:
      * platform/mac/accessibility/table-attributes-expected.txt:
      * platform/mac/accessibility/table-cell-spans-expected.txt:
      * platform/mac/accessibility/table-cells-expected.txt:
      * platform/mac/accessibility/table-detection-expected.txt:
      * platform/mac/accessibility/table-one-cell-expected.txt:
      * platform/mac/accessibility/table-sections-expected.txt:
      * platform/mac/accessibility/table-with-aria-role-expected.txt:
      * platform/mac/accessibility/table-with-rules-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70645b4d
  23. 13 Nov, 2012 3 commits
    • cfleizach@apple.com's avatar
      AX: MathML types need to be semantically identified in AX tree · e37a0742
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101263
      
      Reviewed by Beth Dakin.
      
      Source/WebCore: 
      
      Semantically identify various MathML elements within the AX tree. This will allow
      screen readers to identify math types so that equations can be output more accurately.
      
      Test: platform/mac/accessibility/mathml-elements.html
      
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      (WebCore::AccessibilityObject::isMathElement):
      (WebCore::AccessibilityObject::isMathFraction):
      (WebCore::AccessibilityObject::isMathFenced):
      (WebCore::AccessibilityObject::isMathSubscriptSuperscript):
      (WebCore::AccessibilityObject::isMathRow):
      (WebCore::AccessibilityObject::isMathUnderOver):
      (WebCore::AccessibilityObject::isMathRoot):
      (WebCore::AccessibilityObject::isMathSquareRoot):
      (WebCore::AccessibilityObject::isMathText):
      (WebCore::AccessibilityObject::isMathNumber):
      (WebCore::AccessibilityObject::isMathOperator):
      (WebCore::AccessibilityObject::isMathFenceOperator):
      (WebCore::AccessibilityObject::isMathSeparatorOperator):
      (WebCore::AccessibilityObject::isMathIdentifier):
      (WebCore::AccessibilityObject::isMathTable):
      (WebCore::AccessibilityObject::isMathTableRow):
      (WebCore::AccessibilityObject::isMathTableCell):
      (WebCore::AccessibilityObject::mathRadicandObject):
      (WebCore::AccessibilityObject::mathRootIndexObject):
      (WebCore::AccessibilityObject::mathUnderObject):
      (WebCore::AccessibilityObject::mathOverObject):
      (WebCore::AccessibilityObject::mathNumeratorObject):
      (WebCore::AccessibilityObject::mathDenominatorObject):
      (WebCore::AccessibilityObject::mathBaseObject):
      (WebCore::AccessibilityObject::mathSubscriptObject):
      (WebCore::AccessibilityObject::mathSuperscriptObject):
      (WebCore::AccessibilityObject::mathFencedOpenString):
      (WebCore::AccessibilityObject::mathFencedCloseString):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::startOfContinuations):
          Handle a case where a MathML render element is created with the node of their parent (which could lead to an assert).
      (WebCore::AccessibilityRenderObject::textUnderElement):
          Handle the cases for RenderMathMLOperators which use the node of their parent, which confuses the normal textUnderElement() routine.
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
          Handle ignored cases for math elements
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::isMathElement):
      (WebCore::AccessibilityRenderObject::isMathFraction):
      (WebCore::AccessibilityRenderObject::isMathFenced):
      (WebCore::AccessibilityRenderObject::isMathSubscriptSuperscript):
      (WebCore::AccessibilityRenderObject::isMathRow):
      (WebCore::AccessibilityRenderObject::isMathUnderOver):
      (WebCore::AccessibilityRenderObject::isMathSquareRoot):
      (WebCore::AccessibilityRenderObject::isMathRoot):
      (WebCore::AccessibilityRenderObject::isMathOperator):
      (WebCore::AccessibilityRenderObject::isMathFenceOperator):
      (WebCore::AccessibilityRenderObject::isMathSeparatorOperator):
      (WebCore::AccessibilityRenderObject::isMathText):
      (WebCore::AccessibilityRenderObject::isMathNumber):
      (WebCore::AccessibilityRenderObject::isMathIdentifier):
      (WebCore::AccessibilityRenderObject::isMathTable):
      (WebCore::AccessibilityRenderObject::isMathTableRow):
      (WebCore::AccessibilityRenderObject::isMathTableCell):
      (WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
          Make sure anonymouse blocks are ignored within math tree; make sure non-element type objects are ignored (like <mstyle>).
      (WebCore::AccessibilityRenderObject::mathRadicandObject):
      (WebCore::AccessibilityRenderObject::mathRootIndexObject):
      (WebCore::AccessibilityRenderObject::mathNumeratorObject):
      (WebCore::AccessibilityRenderObject::mathDenominatorObject):
      (WebCore::AccessibilityRenderObject::mathUnderObject):
      (WebCore::AccessibilityRenderObject::mathOverObject):
      (WebCore::AccessibilityRenderObject::mathBaseObject):
      (WebCore::AccessibilityRenderObject::mathSubscriptObject):
      (WebCore::AccessibilityRenderObject::mathSuperscriptObject):
      (WebCore::AccessibilityRenderObject::mathFencedOpenString):
      (WebCore::AccessibilityRenderObject::mathFencedCloseString):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      * rendering/mathml/RenderMathMLBlock.cpp:
      (WebCore::RenderMathMLBlock::RenderMathMLBlock):
      * rendering/mathml/RenderMathMLBlock.h:
      (WebCore::RenderMathMLBlock::isRenderMathMLFenced):
      (WebCore::RenderMathMLBlock::isRenderMathMLFraction):
      (WebCore::RenderMathMLBlock::isRenderMathMLRoot):
      (WebCore::RenderMathMLBlock::isRenderMathMLSquareRoot):
      (WebCore::RenderMathMLBlock::isRenderMathMLSubSup):
      (WebCore::RenderMathMLBlock::isRenderMathMLUnderOver):
      (WebCore::RenderMathMLBlock::setIgnoreInAccessibilityTree):
      (WebCore::RenderMathMLBlock::ignoreInAccessibilityTree):
          Add ability to identify anonymous render blocks as items that AX should ignore.
      (RenderMathMLBlock):
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::createMathMLOperator):
          Identify which kind of math operator is being created on the fly (Fence or Separator)
      (WebCore::RenderMathMLFenced::makeFences):
      (WebCore::RenderMathMLFenced::addChild):
      * rendering/mathml/RenderMathMLFenced.h:
      (WebCore::RenderMathMLFenced::isRenderMathMLFenced):
      (RenderMathMLFenced):
      * rendering/mathml/RenderMathMLFraction.h:
      (WebCore::RenderMathMLFraction::isRenderMathMLFraction):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::RenderMathMLOperator):
      (WebCore::RenderMathMLOperator::updateFromElement):
      (WebCore::RenderMathMLOperator::createGlyph):
           Mark anonymous render blocks as AX ignored.
      * rendering/mathml/RenderMathMLOperator.h:
      (WebCore::RenderMathMLOperator::setOperatorType):
      (WebCore::RenderMathMLOperator::operatorType):
      (RenderMathMLOperator):
      * rendering/mathml/RenderMathMLRoot.h:
      (WebCore::RenderMathMLRoot::isRenderMathMLRoot):
      * rendering/mathml/RenderMathMLSquareRoot.h:
      (WebCore::RenderMathMLSquareRoot::isRenderMathMLSquareRoot):
      * rendering/mathml/RenderMathMLSubSup.h:
      (WebCore::RenderMathMLSubSup::isRenderMathMLSubSup):
      * rendering/mathml/RenderMathMLUnderOver.h:
      (WebCore::RenderMathMLUnderOver::isRenderMathMLUnderOver):
      
      Source/WebKit/chromium: 
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
          Add new accessibility role.
      
      LayoutTests: 
      
      * platform/mac/accessibility/mathml-elements-expected.txt: Added.
      * platform/mac/accessibility/mathml-elements.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e37a0742
    • cfleizach@apple.com's avatar
      WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid · 9df54f8d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101616
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      If the rowheader role is exposed because the element is not within a table, the mac platform
      should map that to a generic group.
      
      Test: platform/mac/accessibility/rowheader-outside-table-role.html
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      
      LayoutTests:
      
      * platform/mac/accessibility/rowheader-outside-table-role-expected.txt: Added.
      * platform/mac/accessibility/rowheader-outside-table-role.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9df54f8d
    • cfleizach@apple.com's avatar
      AX: file upload input text value is not exposed through accessibility · 581e52e1
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100583
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      This is a hard problem to solve on the Mac because there are three pieces of information
           1) The type of button 2) The text on the button 3) The text for the value.
      I think the best compromise is to label this as a file upload button type in the role description,
      and then expose the file path text as the AXTitle.
      This will give the more relevant information and should be clear what is happening.
      
      Test: platform/mac/accessibility/file-upload-button-subrole.html
      
      * English.lproj/Localizable.strings:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      (-[WebAccessibilityObjectWrapper accessibilityTitle]):
      * platform/LocalizedStrings.cpp:
      (WebCore::AXFileUploadButtonText):
      * platform/LocalizedStrings.h:
      
      LayoutTests:
      
      * platform/mac/accessibility/file-upload-button-subrole-expected.txt: Added.
      * platform/mac/accessibility/file-upload-button-subrole.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      581e52e1
  24. 30 Oct, 2012 1 commit
    • cfleizach@apple.com's avatar
      AX: Support embedded SVG objects in AX tree · db3569a2
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97571
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      This patch allows an SVG image from another resource to be hooked into the AX
      hierarchy. This is done by creating an AX wrapper for the root SVG that holds onto
      its native parent image. The SVGChromeClient is then used to connect to this SVG resource.
      
      Test: accessibility/svg-remote-element.html
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AXObjectCache.cpp:
      (WebCore::createFromRenderer):
      * accessibility/AccessibilityAllInOne.cpp:
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isAccessibilitySVGRoot):
      (AccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::detach):
      (WebCore::AccessibilityRenderObject::offsetBoundingBoxForRemoteSVGElement):
      (WebCore::AccessibilityRenderObject::boundingBoxRect):
      (WebCore::AccessibilityRenderObject::remoteSVGElementHitTest):
      (WebCore::AccessibilityRenderObject::elementAccessibilityHitTest):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::isSVGImage):
      (WebCore::AccessibilityRenderObject::detachRemoteSVGRoot):
      (WebCore::AccessibilityRenderObject::remoteSVGRootElement):
      (WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
      (WebCore::AccessibilityRenderObject::addChildren):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/AccessibilitySVGRoot.cpp: Added.
      (WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
      (WebCore::AccessibilitySVGRoot::~AccessibilitySVGRoot):
      (WebCore::AccessibilitySVGRoot::create):
      (WebCore::AccessibilitySVGRoot::parentObject):
      * accessibility/AccessibilitySVGRoot.h: Added.
      (AccessibilitySVGRoot): Class provides ability to wrap the SVG root of a remote accessibility element.
      (WebCore::AccessibilitySVGRoot::setParent):
      (WebCore::AccessibilitySVGRoot::isAccessibilitySVGRoot):
      (WebCore::toAccessibilitySVGRoot):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper position]): The position of AX elements within a remote SVG element needs to be handled 
      in a special manner.
      (createAccessibilityRoleMap):
      * loader/EmptyClients.h:
      (EmptyChromeClient): Expose isEmptyChromeClient() so Accessibility will know when to apply different policies for finding
      the accessibility bounding rect of elements.
      (WebCore::EmptyChromeClient::isEmptyChromeClient):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::isEmptyChromeClient):
      (ChromeClient):
      * svg/graphics/SVGImage.cpp:
      * svg/graphics/SVGImageChromeClient.h: Added.
      (SVGImageChromeClient): Expose the SVGImageChromeClient so that Accessibility can reference its image.
      (WebCore::SVGImageChromeClient::SVGImageChromeClient):
      (WebCore::SVGImageChromeClient::isSVGImageChromeClient):
      (WebCore::SVGImageChromeClient::image):
      (WebCore::SVGImageChromeClient::chromeDestroyed):
      (WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
      (WebCore::toSVGImageChromeClient):
      
      LayoutTests: 
      
      Added a new test that links in an svg file. Accessibility of that remote svg file is tested.
      Test skipped on chromium until clickPoint() is implemented in DRT.
      
      * accessibility/svg-remote-element.html: Added.
      * accessibility/resources/svg-face.svg: Added.
      * platform/chromium/TestExpectations:
      * platform/mac/accessibility/svg-remote-element-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db3569a2
  25. 24 Oct, 2012 1 commit
  26. 19 Oct, 2012 1 commit
    • cfleizach@apple.com's avatar
      AX: Refactor accessibility name computation so it's more platform independent · 1eb3e14c
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99502
      
      Reviewed by Beth Dakin.
      
      Source/WebCore: 
      
      The current model of determining the accessible text for an object has a lot of Mac biases built in
      due to legacy implementation. 
      
      This change categorizes and orders accessibility text based on WAI-ARIA text computation rules and then
      allows the platform (only Mac right now) to decide how best to apply that text to its own AX API.
      http://www.w3.org/TR/wai-aria/roles#textalternativecomputation
      
      This change tried very hard not to change any test behavior, even though it exposed a number of weird
      edge cases where we were treating attributes differently based on element type. 
      
      Future patches will resolve those discrepancies.
      
      * accessibility/AccessibilityImageMapLink.cpp:
      (WebCore::AccessibilityImageMapLink::accessibilityText):
      * accessibility/AccessibilityImageMapLink.h:
      (AccessibilityImageMapLink):
      * accessibility/AccessibilityMediaControls.cpp:
      (WebCore::AccessibilityMediaControl::accessibilityText):
      * accessibility/AccessibilityMediaControls.h:
      (AccessibilityMediaControl):
      (WebCore::AccessibilityMediaTimeDisplay::isMediaControlLabel):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::titleElementText):
      (WebCore::AccessibilityNodeObject::accessibilityText):
      (WebCore::AccessibilityNodeObject::ariaLabeledByText):
      (WebCore::AccessibilityNodeObject::alternativeText):
      (WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
      (WebCore::AccessibilityNodeObject::visibleText):
      (WebCore::AccessibilityNodeObject::helpText):
      (WebCore::AccessibilityNodeObject::ariaDescribedByAttribute):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (AccessibilityText):
      (WebCore::AccessibilityText::AccessibilityText):
      (WebCore::AccessibilityObject::isMediaControlLabel):
      (AccessibilityObject):
      (WebCore::AccessibilityObject::accessibilityText):
      (WebCore::AccessibilityObject::setAccessibleName):
      (WebCore::AccessibilityObject::accessibilityDescription):
      (WebCore::AccessibilityObject::title):
      (WebCore::AccessibilityObject::helpText):
      (WebCore::AccessibilityObject::stringValue):
      (WebCore::AccessibilityObject::textUnderElement):
      (WebCore::AccessibilityObject::text):
      (WebCore::AccessibilityObject::textLength):
      (WebCore::AccessibilityObject::setRoleValue):
      (WebCore::AccessibilityObject::roleValue):
      (WebCore::AccessibilityObject::selection):
      (WebCore::AccessibilityObject::hierarchicalLevel):
      * accessibility/AccessibilityRenderObject.cpp:
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
      (-[WebAccessibilityObjectWrapper accessibilityTitle]):
      (-[WebAccessibilityObjectWrapper accessibilityDescription]):
      (-[WebAccessibilityObjectWrapper accessibilityHelpText]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      * platform/LocalizedStrings.cpp:
      (WebCore::localizedMediaControlElementHelpText):
      
      LayoutTests: 
      
      Update a test to reflect change in what shoud be recognized as a title.
      
      * platform/mac/accessibility/aria-radiobutton-text.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1eb3e14c
  27. 18 Oct, 2012 1 commit
  28. 22 Sep, 2012 1 commit
    • dmazzoni@google.com's avatar
      AX: Layout tests would be easier to write if AccessibilityController could find an element by id · 8dea0ad0
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97301
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Add a method to get the DOM "id" attribute from an accessible object, only for layout tests.
      
      Makes existing test more cross-platform:
      Tests: accessibility/aria-hidden-with-elements.html
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      Tools:
      
      Adds a new accessibleElementById method to AccessibilityController, to make it
      easier to write cross-platform layout tests.
      
      Implemented for Chromium and for Mac (DRT and WKTR).
      
      * DumpRenderTree/AccessibilityController.cpp:
      (getAccessibleElementByIdCallback):
      (AccessibilityController::getJSClass):
      * DumpRenderTree/AccessibilityController.h:
      (AccessibilityController):
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
      (AccessibilityController::AccessibilityController):
      (AccessibilityController::findAccessibleElementByIdRecursive):
      (AccessibilityController::getAccessibleElementById):
      (AccessibilityController::accessibleElementByIdGetterCallback):
      * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
      (AccessibilityController):
      * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
      (AccessibilityController::accessibleElementById):
      * DumpRenderTree/mac/AccessibilityCommonMac.h: added
      * DumpRenderTree/mac/AccessibilityCommonMac.mm: added
      (+[NSString stringWithJSStringRef:]):
      (-[NSString createJSStringRef]):
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (findAccessibleObjectById):
      (AccessibilityController::accessibleElementById):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      * DumpRenderTree/win/AccessibilityControllerWin.cpp:
      (AccessibilityController::accessibleElementById):
      * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
      (WTR::AccessibilityController::accessibleElementById):
      * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
      (AccessibilityController):
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
      (+[NSString stringWithJSStringRef:]):
      (-[NSString createJSStringRef]):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
      (WTR::findAccessibleObjectById):
      (WTR):
      (WTR::AccessibilityController::accessibleElementById):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
      
      LayoutTests:
      
      Modifies an existing test to use the new accessibleElementById
      method of AccessibilityController, enabling the test to pass on
      both Mac and Chromium.
      
      * accessibility/aria-hidden-with-elements.html:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dea0ad0
  29. 10 Sep, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Properly expose <legend> elements to ATs · 802c0122
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84137
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-10
      Reviewed by Chris Fleizach.
      
      Created a new WebCore Accessibility Role, LegendRole. Used it to map to
      the expected platform role, ATK_ROLE_LABEL. Also established the needed
      AtkRelation pair, label-for/labelled-by between the legend and fieldset.
      
      Source/WebCore:
      
      No new test needed - Existing legend.html test is now unskipped for Gtk.
      
      * accessibility/AccessibilityObject.h: Added LegendRole
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Map legendTag to LegendRole
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetName): Fieldset accessible should take its name from the associated LegendRole/label
      (setAtkRelationSetFromCoreObject): Set label-for/labelled-by AtkRelation pair between fieldset and legend
      (atkRole): Map LegendRole to ATK_ROLE_LABEL
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):  Map LegendRole to NSAccessibilityGroupRole
      
      Source/WebKit/chromium:
      
      * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend
      * src/AssertMatchingEnums.cpp: added the assert matching rule for
      WebAccessibilityRoleLegend and LegendRole
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString): added "Legend" string for WebAccessibilityRoleLegend
      
      LayoutTests:
      
      * accessibility/legend.html: Modified the test to be more platform-agnostic.
      * platform/gtk/TestExpectations: Removed legend.html from the skipped list.
      * platform/gtk/accessibility/legend-expected.txt: Added.
      * platform/mac/accessibility/legend-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      802c0122
  30. 07 Sep, 2012 1 commit
    • dmazzoni@google.com's avatar
      Source/WebCore: AX: ARIA spin button should support range value attributes · 85f30799
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96076
      
      Reviewed by Chris Fleizach.
      
      Make an ARIA spin button support ARIA range attributes like
      aria-valuenow, aria-valuemin, etc. - just like slider, progressbar,
      and scrollbar.
      
      Test: accessibility/spinbutton-value.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isSpinButton):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::valueDescription):
      (WebCore):
      (WebCore::AccessibilityRenderObject::isAriaRange):
      (WebCore::AccessibilityRenderObject::valueForRange):
      (WebCore::AccessibilityRenderObject::maxValueForRange):
      (WebCore::AccessibilityRenderObject::minValueForRange):
      (WebCore::AccessibilityRenderObject::stringValue):
      (WebCore::AccessibilityRenderObject::title):
      (WebCore::AccessibilityRenderObject::isGenericFocusableElement):
      (WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      Source/WebKit/chromium: AX: ARIA spin button should support range value attributes
      https://bugs.webkit.org/show_bug.cgi?id=96076
      
      Reviewed by Chris Fleizach.
      
      Expose supportsRangeValue to simplify Chromium logic for when to
      extract a value from a range.
      
      * public/WebAccessibilityObject.h:
      (WebAccessibilityObject):
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::supportsRangeValue):
      (WebKit):
      
      Tools: New time input needs accessibility
      https://bugs.webkit.org/show_bug.cgi?id=96032
      
      Reviewed by Chris Fleizach.
      
      Add support for valueDescription for testing.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (getValueDescription):
      (AccessibilityUIElement::AccessibilityUIElement):
      (AccessibilityUIElement::valueDescriptionGetterCallback):
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
      (AccessibilityUIElement):
      
      LayoutTests: AX: ARIA spin button should support range value attributes
      https://bugs.webkit.org/show_bug.cgi?id=96076
      
      Reviewed by Chris Fleizach.
      
      Test that an ARIA spin button exposes ARIA range attributes like
      aria-valuenow, aria-valuemin, etc.
      
      * accessibility/spinbutton-value-expected.txt: Added.
      * accessibility/spinbutton-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85f30799
  31. 29 Aug, 2012 3 commits
    • dmazzoni@google.com's avatar
      AX: Canvas should have a distinct role · 56a82822
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95248
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Add new role for a canvas element, and a method to determine if
      a canvas has fallback content, so each platform can decide on the
      appropriate role mapping to use.
      
      Test: accessibility/canvas-description-and-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isCanvas):
      (WebCore::AccessibilityObject::canvasHasFallbackContent):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      Add support for canvas accessibility role.
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      Map new CanvasRole to the same as ImageRole.
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      Add support for canvas accessibility role.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      Add new tests for canvas role.
      
      * accessibility/canvas.html: Deleted.
      * accessibility/canvas-expected.txt: Deleted.
      * accessibility/canvas-description-and-role.html: Added.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas.html: Added.
      * platform/mac/accessibility/canvas-expected.txt: Added.
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56a82822
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r126972. · 6aa5c7e9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/126972
      https://bugs.webkit.org/show_bug.cgi?id=95349
      
      accessibility/canvas-description-and-role.html has been
      failing consistently on several bots and Dominic needs some
      time to investigate why (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-29
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityNodeObject.h:
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityDescription):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      * accessibility/canvas-description-and-role.html: Removed.
      * accessibility/canvas-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/canvas-expected.txt.
      * accessibility/canvas.html: Renamed from LayoutTests/platform/mac/accessibility/canvas.html.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa5c7e9
    • dmazzoni@google.com's avatar
      AX: Canvas should have a distinct role · a48d7b3c
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95248
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Add new role for a canvas element, and a method to determine if
      a canvas has fallback content, so each platform can decide on the
      appropriate role mapping to use.
      
      Test: accessibility/canvas-description-and-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isCanvas):
      (WebCore::AccessibilityObject::canvasHasFallbackContent):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      Add support for canvas accessibility role.
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      Map new CanvasRole to the same as ImageRole.
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      Add support for canvas accessibility role.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      Add new tests for canvas role.
      
      * accessibility/canvas.html: Deleted.
      * accessibility/canvas-expected.txt: Deleted.
      * accessibility/canvas-description-and-role.html: Added.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas.html: Added.
      * platform/mac/accessibility/canvas-expected.txt: Added.
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48d7b3c
  32. 22 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Source/WebCore: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON · 6152cb9e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      Test: platform/gtk/accessibility/aria-toggle-button-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::determineAccessibilityRole): using buttonRoleType
      to classify a button-related role.
      (WebCore::AccessibilityNodeObject::determineAriaRoleAttribute): using buttonRoleType
      to classify a button-related role.
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::ariaPressedIsPresent): checks if aria-pressed
      attribute is present.
      (WebCore::AccessibilityObject::buttonRoleType): returns a specific button-related
      role if the object is a button-related role.
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject): added new role ToggleButtonRole.
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole): using buttonRoleType
      to classify a button-related role.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole): added a mapping between ToggleButtonRole and
      ATK_ROLE_TOGGLE_BUTTON.
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap): added a mapping between
      ToggleButtonRole and NSAccessibilityButtonRole
      
      Source/WebKit/chromium: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      * public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that
      matchs with WebCore ToggleButtonRole
      * src/AssertMatchingEnums.cpp: added the assert matching rule for
      WebAccessibilityRoleToggleButton and ToggleButtonRole
      
      Tools: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
      
      LayoutTests: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a test to verify that when aria-pressed is present, buttons
      will have the appropiate role.
      
      * platform/gtk/accessibility/aria-toggle-button-role-expected.txt: Added.
      * platform/gtk/accessibility/aria-toggle-button-role.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6152cb9e