1. 29 Mar, 2013 17 commits
    • abucur@adobe.com's avatar
      [CSS Regions] Add performance tests · bfe3d62b
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113303
      
      Reviewed by Antti Koivisto.
      
      Add simple performance tests for regions, without nested named flows: a region chain and a flow article.
      The regions.js script is used to generate the tests and can set the following parameters: the number of regions,
      the number of paragraphs, the regions width, height, max-height and the propability of a forced break after a paragraph.
      
      The tests are skipped for now. They should be enabled once the regions performance is stable enough to create a baseline.
      
      * Layout/RegionsAuto.html: Added. A few regions with a short article. The regions have auto-height and some
      paragraphs (80%) have forced breaks after. Stress test for the auto-height algorithm.
      * Layout/RegionsAutoMaxHeight.html: Added. A lot of regions with auto-height and max-height. Tests the impact of
      max-height on the auto-height algorithm.
      * Layout/RegionsFixed.html: Added. A lot of regions with a long article. Some paragraphs (50%) have forced breaks after.
      Stress test for the regions layout algorithm.
      * Layout/RegionsFixedShort.html: Added. A lot of short regions with a long content. Tests the impact of unforced breaks
      on the layout speed.
      * Layout/resources/regions.css: Added.
      (.articleInFlow):
      (.articleNone):
      (.region):
      (.contentParagraph):
      (.breakAfter):
      (.regionContainer):
      * Layout/resources/regions.js: Added.
      (.):
      * Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfe3d62b
    • loislo@chromium.org's avatar
      Web Inspector: Flame Chart. Developers will have more clue · d3d3e993
      loislo@chromium.org authored
      if two different profiles will have same colors for same functions.
      https://bugs.webkit.org/show_bug.cgi?id=113410
      
      Reviewed by Pavel Feldman.
      
      The code related to color generator was extracted into a separate class.
      The instance of the class was stored as static private member of the FlameChart class,
      so all the profiles will share the same instance and will use same colors.
      The colors itself were slightly adjusted.
      
      Drive by fix: coordinatesToNodeIndex was fixed. The error was introduced in the patch about left padding.
      
      * inspector/front-end/FlameChart.js:
      (WebInspector.FlameChart):
      (WebInspector.FlameChart.ColorGenerator):
      (WebInspector.FlameChart.ColorGenerator.prototype._colorPairForID):
      (WebInspector.FlameChart.prototype._calculateTimelineData):
      (WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
      (WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3d3e993
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting · fd7c639f
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=113562
      
      Reviewed by George Staikos.
      Internally reviewed by Mike Fenton and Gen Mak.
      
      .:
      
      * Source/cmake/OptionsBlackBerry.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore:
      
      No new tests, just disable CONTEXT_MENUS for blackberry porting.
      
      * platform/blackberry/ContextMenuBlackBerry.cpp:
      * platform/blackberry/ContextMenuItemBlackBerry.cpp:
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      * WebCoreSupport/ContextMenuClientBlackBerry.cpp:
      * WebCoreSupport/ContextMenuClientBlackBerry.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd7c639f
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Context menu doesn't showup anymore after rebase. · e0741c6b
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=113570
      
      Reviewed by George Staikos.
      
      The upstreaming patch for bug: 103058, reverses the return value of
      Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
      so we should reverse our logic in webkit part that calls it also.
      
      This only applys to master_41 which is a new rebase, don't apply it to master_40.
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0741c6b
    • commit-queue@webkit.org's avatar
      Fix build warning after r147022 · 43622b80
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113567
      
      Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-03-29
      Reviewed by Kentaro Hara.
      
      Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
      No new tests, no change on behavior.
      
      * page/EventHandler.cpp:
      (WebCore::expandSelectionToRespectUserSelectAll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43622b80
    • commit-queue@webkit.org's avatar
      Web Inspector: ability to use AnchorBox as an anchor for Popover · 1196dbd0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113563
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
      Reviewed by Pavel Feldman.
      
      No new test: no change in behaviour.
      
      - Ability to pass AnchorBox instead of Element for popover anchor.
      
      * inspector/front-end/Popover.js:
      (WebInspector.Popover.prototype._positionElement):
      (WebInspector.PopoverHelper.prototype._eventInHoverElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1196dbd0
    • caseq@chromium.org's avatar
      Web Inspector: assign Scroll events to rendering category (was painting) · c859375c
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113564
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/TimelinePresentationModel.js: /ScrollLayer.*category/s/painting/rendering/
      (WebInspector.TimelinePresentationModel._initRecordStyles):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c859375c
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skip failing test after r147205. · 977d2368
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      977d2368
    • philn@webkit.org's avatar
      [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow · 7c38184f
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113512
      
      Reviewed by Martin Robinson.
      
      When the HTTP source element is slow downloading data for on-disk
      buffering the playback position might reach an unbuffered region
      and have bad consequences, pausing the pipeline beforehand
      prevents this case to happen.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c38184f
    • keishi@webkit.org's avatar
      Add the event handler content attributes that are defined in the spec to HTMLElement · b61c383f
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86363
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Test: fast/events/event-attribute.html
      
      We are missing some event handler content attributes from HTMLElement that are defined in the spec.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::eventNameForAttributeName): Returns event name for a given attribute name by looking it up on a HashMap.
      (WebCore::HTMLElement::parseAttribute): Sets up event listeners for content attributes.
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::parseAttribute): Removed event listener content attributes that was added to HTMLElement.
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::parseAttribute): Ditto.
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::parseAttribute): Ditto.
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parseAttribute): Ditto.
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::parseAttribute): Ditto.
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::parseAttribute): Ditto.
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::parseAttribute): Ditto.
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::parseAttribute): Ditto.
      
      LayoutTests:
      
      * fast/events/event-attribute-expected.txt: Added.
      * fast/events/event-attribute.html: Added. Tests that setting attribute creates event listeners.
      * fast/events/form-onchange-expected.txt: Added.
      * fast/events/form-onchange.html: Added. Test for Bug 24516.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b61c383f
    • caseq@chromium.org's avatar
      Web Inspector: timeline paint rectangles are off for transformed layers · 5f0ea769
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112919
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      - pass RenderObject instead of Frame to InspectorInstrumentation::didPaint;
      - take transforms into account and convert paint clip rect into quad;
      - emit quads, not rects as Paint and Layout record data;
      - adjust client to using quads, compute width/height from quad coords.
      
      * inspector/InspectorInstrumentation.cpp: Pass RenderObject, not frame to {will,did}Paint.
      (WebCore):
      (WebCore::InspectorInstrumentation::willPaintImpl):
      (WebCore::InspectorInstrumentation::didPaintImpl):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Added.
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::willPaint):
      (WebCore::InspectorInstrumentation::didPaint):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::didLayout):
      (WebCore::InspectorTimelineAgent::didPaint):
      (WebCore::InspectorTimelineAgent::localToPageQuad): Convert local clip rect to transformed quad.
      (WebCore):
      * inspector/InspectorTimelineAgent.h:
      (WebCore):
      (InspectorTimelineAgent):
      * inspector/TimelineRecordFactory.cpp: Emit quads as Paint and Layout records data.
      (WebCore::createQuad):
      (WebCore):
      (WebCore::TimelineRecordFactory::createPaintData):
      (WebCore::TimelineRecordFactory::createLayoutData):
      * inspector/TimelineRecordFactory.h:
      (WebCore):
      (TimelineRecordFactory):
      * inspector/front-end/TimelinePanel.js: Highlight a quad iff formatted record has highlightQuad field.
      (WebInspector.TimelinePanel.prototype._mouseOut):
      (WebInspector.TimelinePanel.prototype._mouseMove):
      (WebInspector.TimelinePanel.prototype._highlightQuad):
      (WebInspector.TimelinePanel.prototype._hideQuadHighlight):
      * inspector/front-end/TimelinePresentationModel.js:
      (WebInspector.TimelinePresentationModel.Record): Set highlightQuad for Paint and Layout
      (WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
      (WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
      (WebInspector.TimelinePresentationModel.quadWidth):
      (WebInspector.TimelinePresentationModel.quadHeight):
      * page/FrameView.cpp:
      (WebCore::FrameView::paintContents):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::paintContents):
      
      LayoutTests:
      
      - adjust to changed record format;
      - simplify test using InspectorTest.evaluateWithTimeline().
      
      * http/tests/inspector/timeline-test.js:
      * inspector/timeline/timeline-layout-expected.txt:
      * inspector/timeline/timeline-paint-expected.txt:
      * inspector/timeline/timeline-paint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f0ea769
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 1e8ff9ad
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
      * platform/qt/TestExpectations:
      * platform/qt/compositing/contents-opaque/control-layer-expected.txt: Rebaseline after r147127.
      * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
      * platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8ff9ad
    • caseq@chromium.org's avatar
      Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad() · 6891828a
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112911
      
      Reviewed by Pavel Feldman.
      
      - added Quad type and DOMAgent.highlightQuad() to protocol;
      - retained DOMAgent.highlightRect(), but implement it via highlightQuad.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::parseQuad):
      (WebCore):
      (WebCore::InspectorDOMAgent::highlightRect):
      (WebCore::InspectorDOMAgent::highlightQuad):
      (WebCore::InspectorDOMAgent::innerHighlightQuad):
      * inspector/InspectorDOMAgent.h:
      (InspectorDOMAgent):
      * inspector/InspectorOverlay.cpp: Mostly just renames of rect to quad.
      (WebCore::InspectorOverlay::paint):
      (WebCore::InspectorOverlay::getHighlight):
      (WebCore::InspectorOverlay::hideHighlight):
      (WebCore::InspectorOverlay::highlightQuad):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::drawQuadHighlight):
      (WebCore::InspectorOverlay::reportMemoryUsage):
      * inspector/InspectorOverlay.h:
      (InspectorOverlay):
      * inspector/InspectorOverlayPage.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6891828a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 40ba0c40
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Adding a crashing expectation for the
      ttp/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html layout test. Skipping the perf/ tests when
      using the debug build.
      * platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt: Rebaselining after r147156.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40ba0c40
    • commit-queue@webkit.org's avatar
      [EFL] New baselines for accessibility tests. · e8979e1d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113510
      
      Unreviewed, EFL gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-29
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      * platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
      * platform/efl/accessibility/aria-checkbox-text-expected.txt: Added.
      * platform/efl/accessibility/aria-combobox-expected.txt: Added.
      * platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
      * platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
      * platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Added.
      * platform/efl/accessibility/aria-roles-expected.txt: Added.
      * platform/efl/accessibility/aria-tables-expected.txt: Added.
      * platform/efl/accessibility/aria-toggle-button-with-title-expected.txt: Added.
      * platform/efl/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
      * platform/efl/accessibility/image-link-expected.txt: Added.
      * platform/efl/accessibility/image-map1-expected.txt: Added.
      * platform/efl/accessibility/image-map2-expected.txt: Added.
      * platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
      * platform/efl/accessibility/legend-expected.txt: Added.
      * platform/efl/accessibility/menu-list-sends-change-notification-expected.txt: Added.
      * platform/efl/accessibility/notification-listeners-expected.txt: Added.
      * platform/efl/accessibility/svg-image-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8979e1d
    • commit-queue@webkit.org's avatar
      REGRESSION(r143102): Ignore table cell's height attribute when checking if... · 463bddeb
      commit-queue@webkit.org authored
      REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
      https://bugs.webkit.org/show_bug.cgi?id=113526
      
      Source/WebCore:
      
      It matches shipping Safari and Firefox behaviour.
      
      Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-29
      Reviewed by Antti Koivisto.
      
      Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
      
      LayoutTests:
      
      Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-29
      Reviewed by Antti Koivisto.
      
      * fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added.
      * fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      463bddeb
    • eustas@chromium.org's avatar
      Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu. · c777e938
      eustas@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113496
      
      Reviewed by Pavel Feldman.
      
      Integrate CookiesTable with DataGrid context menu
      instead of overriding it.
      
      * inspector/front-end/CookiesTable.js:
      Pass context menu callback to DataGrid constructor.
      * inspector/front-end/DataGrid.js:
      Added context menu callback constructor parameter. Fixed JSDoc.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c777e938
  2. 28 Mar, 2013 23 commits
    • ryuan.choi@samsung.com's avatar
      [EFL] Build break with latest EFL libraries after r146265 · 183ec6a7
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113558
      
      Unreviewed build fix.
      
      
      * TestWebKitAPI/PlatformWebView.h:
      * WebKitTestRunner/PlatformWebView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      183ec6a7
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed. Fix build break when running --update-efl in WebKit EFL. · fc7f5cb8
      gyuyoung.kim@samsung.com authored
      * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
      in libgcrypt build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc7f5cb8
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r147123. · 9548c91e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/147123
      https://bugs.webkit.org/show_bug.cgi?id=113557
      
      wrong TextExpectation removal (Requested by shinyak|gardener
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9548c91e
    • shinyak@chromium.org's avatar
      [Chromium] Unreviewed gardening. · 4527995c
      shinyak@chromium.org authored
      Test expectations update and rebaselining.
      
      * platform/chromium-mac-lion/fast/lists/003-vertical-expected.png:
      * platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt:
      * platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
      * platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt:
      * platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
      * platform/chromium-mac/fast/lists/003-vertical-expected.png:
      * platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4527995c
    • shinyak@chromium.org's avatar
      [Chromium] Unreviewed gardening. Test Expectations update. · d6fc59d2
      shinyak@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6fc59d2
    • commit-queue@webkit.org's avatar
      [chromium] Remove unused WebRegularExpression API · c1071f2d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113520
      
      Patch by James Robinson <jamesr@chromium.org> on 2013-03-28
      Reviewed by Kent Tamura.
      
      Last reference to these files removed in r190880.
      
      * WebKit.gyp:
      * public/WebRegularExpression.h: Removed.
      * public/WebTextCaseSensitivity.h: Removed.
      * src/AssertMatchingEnums.cpp:
      * src/WebRegularExpression.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1071f2d
    • beidson@apple.com's avatar
      We leak NetworkConnectionToWebProcess objects. · 8b5d46e5
      beidson@apple.com authored
      <rdar://problem/13393118> and https://bugs.webkit.org/show_bug.cgi?id=113551
      
      Reviewed by Anders Carlsson.
      
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::NetworkConnectionToWebProcess::didClose): Remove this from the global set
        of NetworkConnectionToWebProcess objects.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b5d46e5
    • ggaren@apple.com's avatar
      Simplified the bytecode by removing op_loop and op_loop_if_* · 0408d89a
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113548
      
      Reviewed by Filip Pizlo.
      
      Regular jumps will suffice.
      
      These opcodes are identical to branches, except they also do timeout
      checking. That style of timeout checking has been broken for a long 
      time, and when we add back timeout checking, it won't use these opcodes.
      
      * JavaScriptCore.order:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      * bytecode/Opcode.h:
      (JSC):
      (JSC::padOpcodeName):
      * bytecode/PreciseJumpTargets.cpp:
      (JSC::computePreciseJumpTargets):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitJump):
      (JSC::BytecodeGenerator::emitJumpIfTrue):
      (JSC::BytecodeGenerator::emitJumpIfFalse):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      * jit/JIT.h:
      (JIT):
      (JSC):
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0408d89a
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't cross editing boundary when touch hold selection expands · 73737236
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113537
      
      Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Set editing boundary crossing rule to make sure it won't cross
      editing boundary when selection expands.
      
      Reviewed Internally By Genevieve Mak and Mike Fenton.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
      (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73737236
    • mkwst@chromium.org's avatar
      Unreviewed gardening. · acbe30a5
      mkwst@chromium.org authored
      http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
      crashes sometimes. Applying the patch from wkbug.com/111902 fixes it
      locally for me: skipping it until that patch lands.
      
      * platform/mac/TestExpectations:
          Marking http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
          as crashy in Debug.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acbe30a5
    • pdr@google.com's avatar
      Fix compiler warning in IDBTransaction::modeToString · e63cf670
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113547
      
      Reviewed by Darin Adler.
      
      Not all compilers are smart enough to handle this switch. This patch refactors
      modeToString to not return from the default case.
      
      No new tests as this is just a compiler fix.
      
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::modeToString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e63cf670
    • simon.fraser@apple.com's avatar
      GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect · 99f9b2b5
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113544
      
      Reviewed by Tim Horton.
      
      The functions added in r147058 to update the visible rects of GraphicsLayerCAs
      should not have actually set the m_visibleRect on the layer, because this
      caused a later call to adjustTiledLayerVisibleRect() to think that the visible
      rect had not changed, so it did no expansion.
      
      Clarify the logic to ask the GraphicsLayer whether, given a new visible
      rect, it would need to make new tiles (which happens later during a flush).
      
      Add a function to RenderLayerCompositor to call this code (but which has
      no callers yet).
      
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::visibleRectChangeRequiresFlush): Make private.
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
      (WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush):
      * platform/graphics/ca/GraphicsLayerCA.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::noteVisibleRectChanged):
      * rendering/RenderLayerCompositor.h:
      (RenderLayerCompositor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99f9b2b5
    • rafaelw@chromium.org's avatar
      [HTMLTemplateElement] <template> should be able to be a foster parent · fd287db1
      rafaelw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113541
      
      Source/WebCore:
      
      Reviewed by Eric Seidel
      
      This adds to the check in findFosterSite to include whether the parent is a DocumentFragment which is a template contents.
      
      Tests added to html5lib suite.
      
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::findFosterSite):
      
      LayoutTests:
      
      Reviewed by Eric Seidel.
      
      * html5lib/resources/template.dat:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd287db1
    • ggaren@apple.com's avatar
      Simplified the bytecode by removing op_jmp_scopes · b4787ec4
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113545
      
      Reviewed by Filip Pizlo.
      
      We already have op_pop_scope and op_jmp, so we don't need op_jmp_scopes.
      Using op_jmp_scopes was also adding a "jump to self" to codegen for
      return statements, which was pretty silly.
      
      * JavaScriptCore.order:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecode/PreciseJumpTargets.cpp:
      (JSC::computePreciseJumpTargets):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitComplexPopScopes):
      (JSC::BytecodeGenerator::emitPopScopes):
      * bytecompiler/BytecodeGenerator.h:
      (BytecodeGenerator):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ContinueNode::emitBytecode):
      (JSC::BreakNode::emitBytecode):
      (JSC::ReturnNode::emitBytecode):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      * jit/JIT.h:
      * jit/JITOpcodes.cpp:
      * jit/JITOpcodes32_64.cpp:
      * jit/JITStubs.cpp:
      * jit/JITStubs.h:
      * llint/LLIntSlowPaths.cpp:
      * llint/LLIntSlowPaths.h:
      * llint/LowLevelInterpreter.asm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4787ec4
    • tony@chromium.org's avatar
      Convert some flexbox layout tests to using flexbox.css · 2226e07b
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113534
      
      Reviewed by Ojan Vafai.
      
      This allows tests to be run without the -webkit prefix for flexbox tests allowing
      some of them to run in Firefox.
      
      * css3/flexbox/flex-align-baseline.html:
      * css3/flexbox/flex-align-column.html:
      * css3/flexbox/flex-align-end.html:
      * css3/flexbox/flex-align-max.html:
      * css3/flexbox/flex-align-percent-height.html:
      * css3/flexbox/flex-align-stretch.html:
      * css3/flexbox/flex-align-vertical-writing-mode.html:
      * css3/flexbox/flex-align.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2226e07b
    • tony@chromium.org's avatar
      [chromium] Unreviewed, fix up some lint errors in TestExpectations. · 295ef2a0
      tony@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      295ef2a0
    • aelias@chromium.org's avatar
      [chromium] Use widget.parent() for plugin WebMouseEvents · 7e381b0f
      aelias@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113543
      
      Reviewed by James Robinson.
      
      In r142571 I switches widget.parent() to widget.root() in the plugin
      WebCore event -> WebMouseEvent creator, to make the converter the
      inverse of the one going the other way and avoid null pointer crashes.
      But the plugin code expects it to be parent() (see
      http://crbug.com/223335).
      
      * src/WebInputEventConversion.cpp:
      (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e381b0f
    • beidson@apple.com's avatar
      Resources are never revalidated/reloaded if a cached response exists on disk. · 7bcc163b
      beidson@apple.com authored
      <rdar://problem/13479890> and https://bugs.webkit.org/show_bug.cgi?id=113542
      
      Reviewed by Alexey Proskuryakov.
      
      Trying to get a cached resource in didReceiveResponse and then aborting the load
      meant we never performed any new loads.
      
      We can check and see if the data is cached data inside didReceiveBuffer, instead.
      
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::didReceiveResponse): Don't try for cached resources here.
      (WebKit::NetworkResourceLoader::didReceiveData): This callback should never be used.
      (WebKit::NetworkResourceLoader::didReceiveBuffer): Try to see if this data objected represents
        a file based mmaped buffer.
      * NetworkProcess/NetworkResourceLoader.h:
      
      Refactor these utility functions to start from either a CFURLCachedResponse or a SharedBuffer:
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm:
      (CFCachedURLResponseGetMemMappedData):
      (CFURLCacheIsMemMappedData):
      (WebKit::tryGetShareableHandleFromCFData):
      (WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
      (WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bcc163b
    • wangxianzhu@chromium.org's avatar
      [Chromium] Don't create SolidColorLayer for full transparent background · 87a308e2
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113524
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Test: GraphicsLayerChromiumTest.setContentsToSolidColor
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::setContentsToSolidColor):
      
      Source/WebKit/chromium:
      
      * tests/GraphicsLayerChromiumTest.cpp:
      (GraphicsLayerChromiumTest::setContentsToSolidColor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87a308e2
    • commit-queue@webkit.org's avatar
      use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl · 96f0e6db
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113518
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Use enum XMLHttpRequestResponseType type instead of DOMString for
      XMLHttpRequest responseType.
      
      Argument validation now happens in the bindings.
      XMLHttpRequest::setResponseType should then never receive invalid
      arguments. So, replace console message with ASSERT_NOT_REACHED();
      
      Test: fast/xmlhttprequest/xmlhttprequest-set-responsetype.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::setResponseType):
      * xml/XMLHttpRequest.idl:
      
      LayoutTests:
      
      Update xmlhttprequest-responsetype-set-invalidtype expected result:
      Test all valide responseType. Remove expected console message in case
      of invalid responseType. Rename to xmlhttprequest-set-responsetype
      
      * fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt.
      * fast/xmlhttprequest/xmlhttprequest-set-responsetype.html: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html.
      * fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96f0e6db
    • commit-queue@webkit.org's avatar
      [css3-text] Add platform support for "wavy" text decoration style · de3db7b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92868
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-28
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      This patch uses GraphicsContext::strokePath() to implement
      wavy decoration for the CSS3 property "text-decoration-style".
      
      No new tests as this is covered with existing tests.
      
      * rendering/InlineTextBox.cpp:
      (WebCore::textDecorationStyleToStrokeStyle): Remove obsolete comment.
      (WebCore::adjustStepToDecorationLength): Add function to adjust
      variables used to calculate the lenght of Bezier curves.
      (WebCore::strokeWavyTextDecoration): Add function to stroke wavy
      decoration based on cubic Bezier curve.
      (WebCore::InlineTextBox::paintDecoration): Call
      strokeWavyTextDecoration when necessary.
      
      LayoutTests:
      
      Rebaseline chromium-linux expectation for
      fast/css3-text/css3-text-decoration/text-decoration-style.html.
      
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de3db7b1
    • commit-queue@webkit.org's avatar
      REGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit). · f57a189a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113538
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
      Reviewed by Simon Fraser.
      
      Run run-bindings-tests --reset-results to fix broken tests after
      r147149.
      
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::shortAttrAttrSetter):
      (WebCore::TestObjV8Internal::unsignedShortAttrAttrSetter):
      (WebCore::TestObjV8Internal::longAttrAttrSetter):
      (WebCore::TestObjV8Internal::longLongAttrAttrSetter):
      (WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
      (WebCore::TestObjV8Internal::testObjAttrAttrSetter):
      (WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
      (WebCore::TestObjV8Internal::createAttrSetter):
      (WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetter):
      (WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
      (WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
      (WebCore::TestObjV8Internal::conditionalAttr1AttrSetter):
      (WebCore::TestObjV8Internal::conditionalAttr2AttrSetter):
      (WebCore::TestObjV8Internal::conditionalAttr3AttrSetter):
      (WebCore::TestObjV8Internal::anyAttributeAttrSetter):
      (WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetter):
      (WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetter):
      (WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetter):
      (WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetter):
      (WebCore::TestObjV8Internal::floatArrayAttrSetter):
      (WebCore::TestObjV8Internal::doubleArrayAttrSetter):
      (WebCore::TestObjV8Internal::mutablePointAttrSetter):
      (WebCore::TestObjV8Internal::immutablePointAttrSetter):
      (WebCore::TestObjV8Internal::strawberryAttrSetter):
      (WebCore::TestObjV8Internal::strictFloatAttrSetter):
      (WebCore::TestObjV8Internal::idAttrSetter):
      (WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
      (WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
      (WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
      (WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
      (WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
      (WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
      * bindings/scripts/test/V8/V8TestTypedefs.cpp:
      (WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
      (WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
      (WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetter):
      (WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f57a189a
    • timothy_horton@apple.com's avatar
      [wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be... · ed3cca7c
      timothy_horton@apple.com authored
      [wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
      https://bugs.webkit.org/show_bug.cgi?id=113430
      <rdar://problem/12729564>
      
      Reviewed by Brady Eidson.
      
      http://trac.webkit.org/changeset/147152 was wrong, and should have been
      (as the ChangeLog stated) testing the argument to redirectDataToPlugin,
      not the value of m_pluginView.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::redirectDataToPlugin):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed3cca7c